[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Lari Taskula changed: What|Removed |Added Blocks|18494 |

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Lari Taskula changed: What|Removed |Added Blocks||18494

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Katrin Fischer changed: What|Removed |Added Status|Pushed to Master

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Mason James changed: What|Removed |Added CC|

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Jonathan Druart changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Katrin Fischer changed: What|Removed |Added Severity|enhancement

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #77 from Katrin Fischer --- I think I need help to fix the tests. :( My guess right now is that the "from" address, which for claims and orders is the email of the librarian sending it, is

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #76 from Katrin Fischer --- Ok, I will try... :( -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #75 from Jonathan Druart --- (In reply to Katrin Fischer from comment #74) > Which tests does it break? t/db_dependent/Letters.t? Yes. -- You are receiving this mail because:

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #74 from Katrin Fischer --- Which tests does it break? t/db_dependent/Letters.t? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug.

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #73 from Jonathan Druart --- Katrin, could you have a look, it seems that the tests are failing now -- You are receiving this mail because: You are watching all bug changes. You

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Kyle M Hall changed: What|Removed |Added CC|

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Jonathan Druart changed: What|Removed |Added Attachment #56706|0

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #71 from Jonathan Druart --- (In reply to Katrin Fischer from comment #60) > Hi Jonathan, I have added a patch asking for confirmation, but honestly.. I > am not persuaded by it.

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Jonathan Druart changed: What|Removed |Added Attachment #56707|0

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Jonathan Druart changed: What|Removed |Added Attachment #56709|0

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Jonathan Druart changed: What|Removed |Added Attachment #56708|0

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Jonathan Druart changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #70 from Jonathan Druart --- Created attachment 56795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56795=edit Bug 5260: Use post params instead of get to

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Jonathan Druart changed: What|Removed |Added Attachment #56705|0

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #69 from Jonathan Druart --- Created attachment 56794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56794=edit Bug 5260: simplify script and error handling No

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #68 from Jonathan Druart --- Created attachment 56793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56793=edit Bug 5260: Insert the new letter for existing

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #67 from Jonathan Druart --- Created attachment 56792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56792=edit Bug 5260: make tests pass even without patron

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Jonathan Druart changed: What|Removed |Added Attachment #56680|0

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Jonathan Druart changed: What|Removed |Added Attachment #56679|0

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Jonathan Druart changed: What|Removed |Added Attachment #56562|0

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Jonathan Druart changed: What|Removed |Added Attachment #56568|0

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Jonathan Druart changed: What|Removed |Added Attachment #56560|0

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Jonathan Druart changed: What|Removed |Added Attachment #56561|0

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #56 from Katrin Fischer --- Created attachment 56706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56706=edit [SIGNED OFF] Bug 5260: Insert the new letter for existing

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #60 from Katrin Fischer --- Hi Jonathan, I have added a patch asking for confirmation, but honestly.. I am not persuaded by it. I think this will get annoying quite fast when you are working with

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #59 from Katrin Fischer --- Created attachment 56709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56709=edit Bug 5260: QA follow-up - Ask for confirmation before sending

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #58 from Katrin Fischer --- Created attachment 56708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56708=edit [SIGNED OFF] Bug 5260: Use post params instead of get to avoid

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Katrin Fischer changed: What|Removed |Added Attachment #56686|0 |1

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #57 from Katrin Fischer --- Created attachment 56707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56707=edit [SIGNED OFF] Bug 5260: simplify script and error handling No

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #54 from Katrin Fischer --- (In reply to Jonathan Druart from comment #53) > Katrin, > Could you have a look at the 4 patches please? They should not introduce any > regression. > I am wondering

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #53 from Jonathan Druart --- Katrin, Could you have a look at the 4 patches please? They should not introduce any regression. I am wondering if we should not add a confirmation

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #52 from Jonathan Druart --- Created attachment 56689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56689=edit Bug 5260: Use post params instead of get to

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #49 from Jonathan Druart --- Created attachment 56686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56686=edit Bug 5260: make tests pass even without patron

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #50 from Jonathan Druart --- Created attachment 56687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56687=edit Bug 5260: Insert the new letter for existing

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #51 from Jonathan Druart --- Created attachment 56688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56688=edit Bug 5260: simplify script and error handling No

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Katrin Fischer changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Katrin Fischer changed: What|Removed |Added Blocks|17469 |

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Katrin Fischer changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #48 from Katrin Fischer --- Created attachment 56680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56680=edit Bug 5260: QA follow-up - Add sample ACQORDER notice to sample

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #47 from Katrin Fischer --- Hi Jonathan, thx for the review and catching this! I have (hopefully) fixed the problem. Can you please take a look at the follow-up patch? > Is there a good reason

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #46 from Katrin Fischer --- Created attachment 56679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56679=edit Bug 5260: QA follow-up: Fix error when no notice template is

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Jonathan Druart changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #43 from Katrin Fischer --- Created attachment 56568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56568=edit Bug 5260: Follow-up - Reindenting POD of SendAlerts -- You are

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #42 from Katrin Fischer --- (In reply to Martin Renvoize from comment #40) > Comment on attachment 56560 [details] [review] > Bug 5260 - Add option to send an order by e-mail to the acquisition

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Katrin Fischer changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Katrin Fischer changed: What|Removed |Added Text to go in the|It will be possible to send

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #40 from Martin Renvoize --- Comment on attachment 56560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56560 Bug 5260 - Add option to send an order by e-mail to the

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #39 from Martin Renvoize --- Created attachment 56562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56562=edit Bug 5260 - Schema changes Schema changes for new column

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Martin Renvoize changed: What|Removed |Added Attachment #56549|0

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #38 from Martin Renvoize --- Created attachment 56561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56561=edit Bug 5260: Unit tests for new functionality in SendAlert

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #36 from Katrin Fischer --- Ready for testing now! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes.

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #35 from Katrin Fischer --- Created attachment 56551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56551=edit Bug 5260 - Schema changes Schema changes for new column in the

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #34 from Katrin Fischer --- Created attachment 56550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56550=edit Bug 5260: Unit tests for new functionality in SendAlert -- You

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Katrin Fischer changed: What|Removed |Added Attachment #56483|0 |1

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #32 from Zeno Tajoli --- Hi Katrin, in my humble opinion the option to recieve a Bcc copy of e-mail is quite important. If we can develop it with this patch for me is better. -- You are receiving

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Katrin Fischer changed: What|Removed |Added Text to go in the|It will be possible to send

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Katrin Fischer changed: What|Removed |Added Text to go in the|It will be possible to send

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #30 from Katrin Fischer --- Zeno, thx for the feedback. I am still working on the tests and have to rebase now on Marcel's bug. New patches coming soon. -- You are receiving this mail because:

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Katrin Fischer changed: What|Removed |Added Text to go in the|It will be possible to send

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Katrin Fischer changed: What|Removed |Added Depends on|

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Silvia Simonetti changed: What|Removed |Added CC|s.simone...@cineca.it |

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Zeno Tajoli changed: What|Removed |Added Text to go in the|It will be possible to send |It will be

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Zeno Tajoli changed: What|Removed |Added Text to go in the||It will be

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #29 from Zeno Tajoli --- I take a look of code and for me is good. I undeline that we need to update the description of ClaimsBccCopy sys preference. With this patch it becames: "[... ] blind copy

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #28 from Katrin Fischer --- Aware of missing tests - working on it, but would love some first feedback if someone would like to take a look. -- You are receiving this mail because: You are

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #27 from Katrin Fischer --- Created attachment 56484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56484=edit Bug 5260 - Add option to send an order by e-mail to the

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Katrin Fischer changed: What|Removed |Added Attachment #56449|0 |1

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #25 from Katrin Fischer --- Created attachment 56450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56450=edit Bug 5260 - Schema changes Schema changes for new column in the

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Katrin Fischer changed: What|Removed |Added Status|ASSIGNED

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 --- Comment #24 from Katrin Fischer --- Created attachment 56449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56449=edit Bug 5260 - Add option to send an order by e-mail to the

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Katrin Fischer changed: What|Removed |Added Depends on|

[Koha-bugs] [Bug 5260] Add option to send an order by e-mail to the acquisition module

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5260 Katrin Fischer changed: What|Removed |Added Summary|It would be nice if Koha's