[Koha-bugs] [Bug 5596] add author to holds to pull report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5596 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Version|rel_3_6 |rel_3_8 --- Comment #11 from Jared Camins-Esakov jcam...@cpbibliography.com --- Will not be pushed to 3.6.x. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5596] add author to holds to pull report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5596 Ian Walls koha.sek...@gmail.com changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #9 from Ian Walls koha.sek...@gmail.com --- Adds output of author to template, since it was already exported. Marking as Passed QA. Issue of subtitles will be addressed in bug 7715 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5596] add author to holds to pull report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5596 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||paul.poul...@biblibre.com --- Comment #10 from Paul Poulain paul.poul...@biblibre.com --- (In reply to comment #7) I agree that I broke the rules in including an additional change, but I disagree that extra CPU cycles is a reason why a change like this might be rejected. Using GetMarcBiblio is currently the ONLY way we have to get subtitle, for better or worse. Agreeing with Owen and Ian in fact... My feeling is that an acceptable circumventing would be to memoize the GetMarcBiblio sub. Once it's done, subsequent calls to the function will cost nothing (note : I've said memoize, not memoize with memcache, as this 2nd option will give a longer persistency, but at the -heavy- price of a http call to memcached) The best/long term option would be to use a good ORM internal caching things like that, but they are not close. patch pushed (that removes subtitle, that was already here before the patch)) -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5596] add author to holds to pull report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5596 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Version|master |rel_3_6 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5596] add author to holds to pull report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5596 Kristina khspaces-subscripti...@yahoo.de changed: What|Removed |Added Attachment #8205|0 |1 is obsolete|| --- Comment #8 from Kristina khspaces-subscripti...@yahoo.de --- Created attachment 8253 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8253action=edit signed-off patch Tested this on BibLibre sandbox and it works fine. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5596] add author to holds to pull report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5596 Kristina khspaces-subscripti...@yahoo.de changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||khspaces-subscriptions@yaho ||o.de -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5596] add author to holds to pull report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5596 Ian Walls koha.sek...@gmail.com changed: What|Removed |Added Status|Signed Off |Failed QA CC||koha.sek...@gmail.com --- Comment #5 from Ian Walls koha.sek...@gmail.com --- Adding author is easy enough; requires a template only change, since the value is already pulled in the SQL. Unfortunately, the addition of subtitle introduces n calls to GetMarcBiblio, where n = number of pending reserves. This is a serious performance killer, as it requires parsing each MARCXML record to extract the subtitle. Given that subtitle is not part of the original request of this bug report, and it'll cost a lot of extra CPU cycles to extract it, I'm marking this patch as Failed QA. Please submit a separate bug report for adding subtitle to the holds to pull report. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5596] add author to holds to pull report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5596 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #8187|0 |1 is obsolete|| --- Comment #6 from Owen Leonard oleon...@myacpl.org --- Created attachment 8205 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8205action=edit Bug 5596 [REVISED 2] add author to holds to pull report Adding output of author. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5596] add author to holds to pull report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5596 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #7 from Owen Leonard oleon...@myacpl.org --- I agree that I broke the rules in including an additional change, but I disagree that extra CPU cycles is a reason why a change like this might be rejected. Using GetMarcBiblio is currently the ONLY way we have to get subtitle, for better or worse. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5596] add author to holds to pull report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5596 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #8035|0 |1 is obsolete|| --- Comment #3 from Owen Leonard oleon...@myacpl.org --- Created attachment 8180 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8180action=edit Bug 5596 [REVISED] add author to holds to pull report Adding output of author and, for good measure, subtitle. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5596] add author to holds to pull report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5596 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5596] add author to holds to pull report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5596 Liz Rea wizzy...@gmail.com changed: What|Removed |Added Attachment #8180|0 |1 is obsolete|| --- Comment #4 from Liz Rea wizzy...@gmail.com --- Created attachment 8187 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8187action=edit Bug 5596 [REVISED] add author to holds to pull report Adding output of author and, for good measure, subtitle. Signed-off-by: Liz Rea wizzy...@gmail.com Passes tests, author and subtitle shown on holds to pull report. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5596] add author to holds to pull report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5596 Liz Rea wizzy...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||wizzy...@gmail.com -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5596] add author to holds to pull report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5596 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Nicole C. Engard neng...@gmail.com --- Bug 5596 - add author to holds to pull report Apply? [yn] y Applying: Bug 5596 - add author to holds to pull report error: patch failed: circ/pendingreserves.pl:184 error: circ/pendingreserves.pl: patch does not apply error: patch failed: koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt:125 error: koha-tmpl/intranet-tmpl/prog/en/modules/circ/pendingreserves.tt: patch does not apply Patch failed at 0001 Bug 5596 - add author to holds to pull report When you have resolved this problem run git am --resolved. If you would prefer to skip this patch, instead run git am --skip. To restore the original branch and stop patching run git am --abort. Patch left in /tmp/Bug-5596---add-author-to-holds-to-pull-report-yfIo_v.patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5596] add author to holds to pull report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5596 --- Comment #1 from Owen Leonard oleon...@myacpl.org --- Created attachment 8035 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8035action=edit Bug 5596 - add author to holds to pull report Adding output of author and, for good measure, subtitle. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 5596] add author to holds to pull report
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5596 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
