[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||20828


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20828
[Bug 20828] Step 4 of moremember is used for Housebound and additional
attributes
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||19085


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19085
[Bug 19085] Empty files in English web installer
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17891


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17891
[Bug 17891] typo in housebound.tt div tag
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #141 from Alex Sassmannshausen 
 ---
Hello Paul, Jonathan,

Jonathan mostly covered the facts in his response.  To confirm:

(In reply to Paul Poulain from comment #136)
> OK, guys, I've a functional question:
>  * I'm a chooser = how do I know that today (or tomorrow, or next weeks)
> I'll have to do some choices ?
>  * I'm a deliverer = same question : how do I know I've to deliver ?
The primary workflow here is that choosers and deliverers work in close concert
with the library anyway: they have a weekly day, where they all get together
and work through their respective tasks for instance.

I like what you're proposing, which is, by the sound of it, a decentralised
version of the above.

>  * I want to take profit of this service, can I register from the OPAC ?

Again, currently this is managed by staff at the branch, or even indirectly, by
the library service as a whole.  It would be nice to allow people to sign up to
it.

At present we don't have specific time-scales to further develop those features
— but the architecture certainly should make the above options easy to
implement, and I'm happy to provide guidance to anyone seeking to do so.

HTH,

Alex

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #140 from Jonathan Druart  
---
Yep, IIRC the goal with this first patch was to get a first shoot in.
As you can see with the quantity of patches and the low number of this bug
report, it was a long standing one.

AFAIK there is nothing planned yet to improve this feature.
But Alex must know better than me: )

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #139 from Paul Poulain  ---
thx for your quick answer joubu.
Then, in my opinion, it lowers a lot the interest of the feature. Anyone around
planning/thinking of adding this kind of feature (a kind of "housebound
dashboard")

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #138 from Jonathan Druart  
---
(In reply to Paul Poulain from comment #136)
> OK, guys, I've a functional question:
>  * I'm a chooser = how do I know that today (or tomorrow, or next weeks)
> I'll have to do some choices ?
>  * I'm a deliverer = same question : how do I know I've to deliver ?

The information is only displayed on the patron detail pages at the intranet
(show+edit views) and on the housebound page (tab HouseBound in the member
module). Nothing at the OPAC.

>  * I want to take profit of this service, can I register from the OPAC ?

Nope :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #137 from Paul Poulain  ---
PS : sorry Claire, I know you're not a guy ;-)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Paul Poulain  changed:

   What|Removed |Added

 CC||paul.poul...@biblibre.com

--- Comment #136 from Paul Poulain  ---
OK, guys, I've a functional question:
 * I'm a chooser = how do I know that today (or tomorrow, or next weeks) I'll
have to do some choices ?
 * I'm a deliverer = same question : how do I know I've to deliver ?
 * I want to take profit of this service, can I register from the OPAC ?

Thank you for any answer/feedback ;-)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Nicole C. Engard  changed:

   What|Removed |Added

 CC|neng...@gmail.com   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Zeno Tajoli  changed:

   What|Removed |Added

  Text to go in the||The Housebound module is an
  release notes||addition to Koha to allow
   ||the library to link
   ||together housebound
   ||patrons, volunteers,
   ||delivers and book choosers.
   ||- Ability to create
   ||housebound profiles &
   ||scheduled visits for
   ||patrons.
   ||- Ability to
   ||record users as Deliverers
   ||or Choosers (or both),
   ||using extended patron
   ||attributes.
   ||- Ability to
   ||link choosers and
   ||deliverers to individual
   ||delivery runs.
   ||- 'Delivery
   ||Frequencies' are
   ||customizable through
   ||authorised
   ||  values
   ||('HSBND_FREQ').

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||17576


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17576
[Bug 17576] Add HSBND_FREQ authorised value to translated installer sample
files
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #135 from Kyle M Hall  ---
Pushed to master for 16.11, thanks Alex, Jonathan!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56348|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56352|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #134 from Alex Sassmannshausen 
 ---
(In reply to Jonathan Druart from comment #133)
> Great work Alex, thanks for your perseverance! :)

Indeed, thanks to you and your perseverance too! :-)

> Marked as Passed QA

Great news!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #133 from Jonathan Druart  
---
Great work Alex, thanks for your perseverance! :)
I have squashed 2 or 3 patches for the readability (add and deletion of the
same files).

Marked as Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #132 from Jonathan Druart  
---
Created attachment 56606
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56606=edit
Bug 5670: Add a confirmation message on delete

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #131 from Jonathan Druart  
---
Created attachment 56605
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56605=edit
Bug 5670: Use the fa icon for the save button

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #128 from Jonathan Druart  
---
Created attachment 56602
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56602=edit
Bug 5670: Update constraint name to match with the one in updatedatabase

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #130 from Jonathan Druart  
---
Created attachment 56604
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56604=edit
Bug 5670: Use Koha.Preference to retrieve syspref from templates

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #129 from Jonathan Druart  
---
Created attachment 56603
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56603=edit
Bug 5670: Does not return 0 in Koha::Patron->housebound_* methods

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56369|0   |1
is obsolete||

--- Comment #127 from Jonathan Druart  
---
Created attachment 56601
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56601=edit
Bug 5670: [Followup] Add 'step 4' edit button.

* koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt:
  Place housebound role form inside the 'step 4' section.
* koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt:
  Add 'step 4' edit button for housebound role.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56368|0   |1
is obsolete||

--- Comment #126 from Jonathan Druart  
---
Created attachment 56600
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56600=edit
Bug 5670: Add auth_val_cat to auth_val_cat.sql.

* installer/data/mysql/atomicupdate/housebound_tables.sql: Insert
  HSBND_FREQ in authorised value categories.
* installer/data/mysql/mandatory/auth_val_cat.sql: Add HSBND_FREQ.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56367|0   |1
is obsolete||

--- Comment #125 from Jonathan Druart  
---
Created attachment 56599
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56599=edit
DO NOT PUSH: Moar Housebound Schema files.

* Koha/Schema/Result/Borrower.pm: New method.
* Koha/Schema/Result/HouseboundRole.pm: New file.

https://bugs.koha-community.org/show_bug.cgi?id=5670

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56366|0   |1
is obsolete||

--- Comment #124 from Jonathan Druart  
---
Created attachment 56598
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56598=edit
Bug 5670: [QA Followup] HouseboundRole CRUD from UI.

* koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt: Add
  HouseboundRole form.
* members/memberentry.pl: Handle HouseboundRole CRUD.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56365|0   |1
is obsolete||

--- Comment #123 from Jonathan Druart  
---
Created attachment 56597
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56597=edit
Bug 5670: [QA Followup] Display HouseboundRole info.

* Koha/Patron.pm (housebound_role): New method.
* koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt: Add
  section for HouseboundRole information
* members/moremember.pl: Pass HouseboundRole info to template.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56359|0   |1
is obsolete||

--- Comment #117 from Jonathan Druart  
---
Created attachment 56591
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56591=edit
Bug 5670: remove useless call to ->new when ->search is enought

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56360|0   |1
is obsolete||

--- Comment #118 from Jonathan Druart  
---
Created attachment 56592
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56592=edit
Bug 5670: [QA Followup] Improve template style.

* koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: Remove
  toggler class from form, improve look and layout of action buttons.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56364|0   |1
is obsolete||

--- Comment #122 from Jonathan Druart  
---
Created attachment 56596
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56596=edit
Bug 5670: [QA Followup] Correct housebound role search.

* Koha/Patrons.pm (search_housebound_choosers)
  (search_housebound_deliverers): Use new table.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56357|0   |1
is obsolete||

--- Comment #115 from Jonathan Druart  
---
Created attachment 56589
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56589=edit
Bug 5670: Add the 'required' class to required fields

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56358|0   |1
is obsolete||

--- Comment #116 from Jonathan Druart  
---
Created attachment 56590
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56590=edit
Bug 5670: mv housebound_* to search_housebound_*

I think it's better to prefix the subroutine names used to search with
'search_'.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56361|0   |1
is obsolete||

--- Comment #119 from Jonathan Druart  
---
Created attachment 56593
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56593=edit
Bug 5670: [QA Followup] More "required" messages.

* koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: Mark
  houseboundvisit fields as required.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56363|0   |1
is obsolete||

--- Comment #121 from Jonathan Druart  
---
Created attachment 56595
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56595=edit
Bug 5670: [QA Followup] Create HouseboundRole objects.

* Koha/Patron/HouseboundRole.pm: New file.
* Koha/Patron/HouseboundRoles.pm: New file.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56362|0   |1
is obsolete||

--- Comment #120 from Jonathan Druart  
---
Created attachment 56594
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56594=edit
Bug 5670: [QA Followup] Create housebound roles table.

* installer/data/mysql/atomicupdate/housebound_tables.sql (housebound_role):
  New table.
* installer/data/mysql/kohastructure.sql (housebound_role): New table.
* installer/data/mysql/en/mandatory/auth_values.sql: Remove HSBND_ROLE entries.
* installer/data/mysql/en/mandatory/patron_attributes.sql: Remove
  HSBND_ROLE entry.
* installer/data/mysql/en/mandatory/patron_attributes.txt: Remove
  explanatory text.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56355|0   |1
is obsolete||

--- Comment #113 from Jonathan Druart  
---
Created attachment 56587
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56587=edit
Bug 5670: [QA Followup] Small QA fixes.

* koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: Remove
  `console.log` invocations.
* members/housebound.pl ($houseboundvisits, $chooser, $deliverer):
  Remove unused variables.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56346|0   |1
is obsolete||

--- Comment #106 from Jonathan Druart  
---
Created attachment 56580
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56580=edit
DO NOT PUSH: Add Housebound Schema files.

* Koha/Schema/Result/HouseboundProfile.pm: New file.
* Koha/Schema/Result/HouseboundVisit.pm: New file.

https://bugs.koha-community.org/show_bug.cgi?id=5670

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56353|0   |1
is obsolete||

--- Comment #111 from Jonathan Druart  
---
Created attachment 56585
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56585=edit
Bug 5670: [QA Followup] Avoid CGI::param in list context.

* members/housebound.pl: Force `borrowernumber` to scalar context.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56356|0   |1
is obsolete||

--- Comment #114 from Jonathan Druart  
---
Created attachment 56588
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56588=edit
Bug 5670: [QA Followup] Fix `div.patroninfo`.

* members/housebound.pl: Provide full patron hash keys, extended patron
  attributes & picture to template.
* koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt:
  Refactor to use new information.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56354|0   |1
is obsolete||

--- Comment #112 from Jonathan Druart  
---
Created attachment 56586
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56586=edit
Bug 5670: [QA Followup] Housebound link from patron edit.

* koha-tmpl/intranet-tmpl/prog/en/includes/members-menu.inc: Add a link
  to the housebound module view if it is switched on.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56350|0   |1
is obsolete||

--- Comment #109 from Jonathan Druart  
---
Created attachment 56583
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56583=edit
Bug 5670: [Followup] Refactor .pl; error messages.

* members/housebound.pl: Refactor & store messages for encountered
  errors.
* koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: Show
  messages.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56349|0   |1
is obsolete||

--- Comment #108 from Jonathan Druart  
---
Created attachment 56582
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56582=edit
Bug 5670: [Followup] Return Koha::Patron objects.

* Koha/Patron/HouseboundVisit.pm (chooser, deliverer): Use
  `_new_from_dbic` to return Koha::Patron objects.
* t/db_dependent/Patron/HouseboundVisits.t: Remove TODO section for this.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56351|0   |1
is obsolete||

--- Comment #110 from Jonathan Druart  
---
Created attachment 56584
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56584=edit
Bug 5670: [QA Followup] Don't force ISO dates.

* koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: Use
  ".datepicker" class for date input, use `$KohaDates` to filter our iso
  dates.
* members/housebound.pl: Use DateTime and Koha::DateUtils to parse
  incoming date to ISO format.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #56347|0   |1
is obsolete||

--- Comment #107 from Jonathan Druart  
---
Created attachment 56581
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56581=edit
Bug 5670: Housebound Readers Module

New module to handle management of circulation to Housebound readers.

- Ability to create housebound profiles & scheduled visits for patrons.
- Ability to record users as Deliverers or Choosers (or both), using
  extended patron attributes.
- Ability to link choosers and deliverers to individual delivery runs.
- 'Delivery Frequencies' are customizable through authorised
  values ('HSBND_FREQ').

* koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc: add
  Housebound menu if appropriate.
* Koha/Patron.pm (housebound_profile): New method.
* Koha/Patrons.pm (housebound_choosers, housebound_deliverers): New
  methods.
* Koha/Patron/HouseboundProfile.pm: New File.
* Koha/Patron/HouseboundProfiles.pm: New File.
* Koha/Patron/HouseboundVisits.pm: New File.
* Koha/Patron/HouseboundVisit.pm: New File.
* koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: New file.
* members/housebound.pl: New file.
* installer/data/mysql/kohastructure.sql: Add housebound_* tables.
* installer/data/mysql/sysprefs.sql: Add HouseboundModule syspref.
* koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref:
  Add HouseboundModule syspref.
* installer/data/mysql/atomicupdate/housebound_tables.sql: New file.
* t/db_dependent/Patron/Borrower_Housebound.t: New file.
* t/db_dependent/Patron/Borrower_HouseboundProfiles.t: New file.
* t/db_dependent/Patron/Borrower_HouseboundVisits.t: New file.

Test plan:
- Apply patch.
- Run atomic update script.
- Run Unit Tests (t/db_dependent/Patron/Housebound*)
- Optionally, add additional authorised values to 'HSBND_FREQ'.
- Switch on 'HouseboundModule' syspref.
- Ensure 'ExtendedPatronAttributes syspref is on.
- On patron pages, when editing, add some to the Housebound deliverer
  and chooser groups.
- On a patron page, the Housebound menu should now be present.
  - create housebound profile
+ ensure Frequency values seem pulled from 'HSBND_FREQ'.
  - create 'housebound visits' (deliveries)
+ ensure chooser/deliverer lists are populated with patrons that
  have the Chooser or Deliverer Attribute type.
  - edit visits.
  - delete visits.
- Switch off 'HouseboundModule'
  - the Housebound menu should disappear

Signed-off-by: Chris Cormack 

Signed-off-by: Claire Gravely 

Bug 5670: [Followup] Rename test files.

* t/db_dependent/Patron/Borrower_Housebound.t: Rename to
  t/db_dependent/Patron/Housebound.t.
* t/db_dependent/Patron/Borrower_HouseboundProfiles.t: Rename to
  t/db_dependent/Patron/HouseboundProfiles.t.
* t/db_dependent/Patron/Borrower_HouseboundVisits.t: Rename to
  t/db_dependent/Patron/HouseboundVisits.t.

Signed-off-by: Claire Gravely 

Bug 5670: [QA Followup] Fix category_type ref.

* koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: Replace
  references to `category_type` with `categorycode`.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

 QA Contact|koha-b...@lists.koha-commun |jonathan.dru...@bugs.koha-c
   |ity.org |ommunity.org

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Sally Healey  changed:

   What|Removed |Added

 CC||sally.healey@cheshireshared
   ||services.gov.uk

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Alex Sassmannshausen  changed:

   What|Removed |Added

  Attachment #56298|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Claire Gravely  changed:

   What|Removed |Added

  Attachment #56341|0   |1
is obsolete||

--- Comment #105 from Claire Gravely  ---
Created attachment 56369
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56369=edit
Bug 5670: [Followup] Add 'step 4' edit button.

* koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt:
  Place housebound role form inside the 'step 4' section.
* koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt:
  Add 'step 4' edit button for housebound role.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Claire Gravely  changed:

   What|Removed |Added

  Attachment #56337|0   |1
is obsolete||

--- Comment #104 from Claire Gravely  ---
Created attachment 56368
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56368=edit
Bug 5670: Add auth_val_cat to auth_val_cat.sql.

* installer/data/mysql/atomicupdate/housebound_tables.sql: Insert
  HSBND_FREQ in authorised value categories.
* installer/data/mysql/mandatory/auth_val_cat.sql: Add HSBND_FREQ.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Claire Gravely  changed:

   What|Removed |Added

  Attachment #56308|0   |1
is obsolete||

--- Comment #103 from Claire Gravely  ---
Created attachment 56367
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56367=edit
DO NOT PUSH: Moar Housebound Schema files.

* Koha/Schema/Result/Borrower.pm: New method.
* Koha/Schema/Result/HouseboundRole.pm: New file.

https://bugs.koha-community.org/show_bug.cgi?id=5670

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Claire Gravely  changed:

   What|Removed |Added

  Attachment #55891|0   |1
is obsolete||

--- Comment #97 from Claire Gravely  ---
Created attachment 56361
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56361=edit
Bug 5670: [QA Followup] More "required" messages.

* koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: Mark
  houseboundvisit fields as required.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Claire Gravely  changed:

   What|Removed |Added

  Attachment #55867|0   |1
is obsolete||

--- Comment #95 from Claire Gravely  ---
Created attachment 56359
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56359=edit
Bug 5670: remove useless call to ->new when ->search is enought

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Claire Gravely  changed:

   What|Removed |Added

  Attachment #56299|0   |1
is obsolete||

--- Comment #99 from Claire Gravely  ---
Created attachment 56363
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56363=edit
Bug 5670: [QA Followup] Create HouseboundRole objects.

* Koha/Patron/HouseboundRole.pm: New file.
* Koha/Patron/HouseboundRoles.pm: New file.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Claire Gravely  changed:

   What|Removed |Added

  Attachment #56301|0   |1
is obsolete||

--- Comment #101 from Claire Gravely  ---
Created attachment 56365
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56365=edit
Bug 5670: [QA Followup] Display HouseboundRole info.

* Koha/Patron.pm (housebound_role): New method.
* koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt: Add
  section for HouseboundRole information
* members/moremember.pl: Pass HouseboundRole info to template.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Claire Gravely  changed:

   What|Removed |Added

  Attachment #56302|0   |1
is obsolete||

--- Comment #102 from Claire Gravely  ---
Created attachment 56366
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56366=edit
Bug 5670: [QA Followup] HouseboundRole CRUD from UI.

* koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt: Add
  HouseboundRole form.
* members/memberentry.pl: Handle HouseboundRole CRUD.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Claire Gravely  changed:

   What|Removed |Added

  Attachment #56300|0   |1
is obsolete||

--- Comment #100 from Claire Gravely  ---
Created attachment 56364
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56364=edit
Bug 5670: [QA Followup] Correct housebound role search.

* Koha/Patrons.pm (search_housebound_choosers)
  (search_housebound_deliverers): Use new table.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Claire Gravely  changed:

   What|Removed |Added

  Attachment #55890|0   |1
is obsolete||

--- Comment #96 from Claire Gravely  ---
Created attachment 56360
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56360=edit
Bug 5670: [QA Followup] Improve template style.

* koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: Remove
  toggler class from form, improve look and layout of action buttons.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #98 from Claire Gravely  ---
Created attachment 56362
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56362=edit
Bug 5670: [QA Followup] Create housebound roles table.

* installer/data/mysql/atomicupdate/housebound_tables.sql (housebound_role):
  New table.
* installer/data/mysql/kohastructure.sql (housebound_role): New table.
* installer/data/mysql/en/mandatory/auth_values.sql: Remove HSBND_ROLE entries.
* installer/data/mysql/en/mandatory/patron_attributes.sql: Remove
  HSBND_ROLE entry.
* installer/data/mysql/en/mandatory/patron_attributes.txt: Remove
  explanatory text.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Claire Gravely  changed:

   What|Removed |Added

  Attachment #55737|0   |1
is obsolete||

--- Comment #90 from Claire Gravely  ---
Created attachment 56354
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56354=edit
Bug 5670: [QA Followup] Housebound link from patron edit.

* koha-tmpl/intranet-tmpl/prog/en/includes/members-menu.inc: Add a link
  to the housebound module view if it is switched on.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Claire Gravely  changed:

   What|Removed |Added

  Attachment #55736|0   |1
is obsolete||

--- Comment #89 from Claire Gravely  ---
Created attachment 56353
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56353=edit
Bug 5670: [QA Followup] Avoid CGI::param in list context.

* members/housebound.pl: Force `borrowernumber` to scalar context.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Claire Gravely  changed:

   What|Removed |Added

  Attachment #55738|0   |1
is obsolete||

--- Comment #91 from Claire Gravely  ---
Created attachment 56355
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56355=edit
Bug 5670: [QA Followup] Small QA fixes.

* koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: Remove
  `console.log` invocations.
* members/housebound.pl ($houseboundvisits, $chooser, $deliverer):
  Remove unused variables.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Claire Gravely  changed:

   What|Removed |Added

  Attachment #55735|0   |1
is obsolete||

--- Comment #88 from Claire Gravely  ---
Created attachment 56352
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56352=edit
Bug 5670: [QA Followup] Fix category_type ref.

* koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: Replace
  references to `category_type` with `categorycode`.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Claire Gravely  changed:

   What|Removed |Added

  Attachment #55866|0   |1
is obsolete||

--- Comment #94 from Claire Gravely  ---
Created attachment 56358
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56358=edit
Bug 5670: mv housebound_* to search_housebound_*

I think it's better to prefix the subroutine names used to search with
'search_'.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Claire Gravely  changed:

   What|Removed |Added

  Attachment #55865|0   |1
is obsolete||

--- Comment #93 from Claire Gravely  ---
Created attachment 56357
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56357=edit
Bug 5670: Add the 'required' class to required fields

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Claire Gravely  changed:

   What|Removed |Added

  Attachment #55739|0   |1
is obsolete||

--- Comment #92 from Claire Gravely  ---
Created attachment 56356
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56356=edit
Bug 5670: [QA Followup] Fix `div.patroninfo`.

* members/housebound.pl: Provide full patron hash keys, extended patron
  attributes & picture to template.
* koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt:
  Refactor to use new information.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Claire Gravely  changed:

   What|Removed |Added

  Attachment #55335|0   |1
is obsolete||

--- Comment #85 from Claire Gravely  ---
Created attachment 56349
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56349=edit
Bug 5670: [Followup] Return Koha::Patron objects.

* Koha/Patron/HouseboundVisit.pm (chooser, deliverer): Use
  `_new_from_dbic` to return Koha::Patron objects.
* t/db_dependent/Patron/HouseboundVisits.t: Remove TODO section for this.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Claire Gravely  changed:

   What|Removed |Added

  Attachment #55734|0   |1
is obsolete||

--- Comment #87 from Claire Gravely  ---
Created attachment 56351
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56351=edit
Bug 5670: [QA Followup] Don't force ISO dates.

* koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: Use
  ".datepicker" class for date input, use `$KohaDates` to filter our iso
  dates.
* members/housebound.pl: Use DateTime and Koha::DateUtils to parse
  incoming date to ISO format.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Claire Gravely  changed:

   What|Removed |Added

  Attachment #55334|0   |1
is obsolete||

--- Comment #84 from Claire Gravely  ---
Created attachment 56348
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56348=edit
Bug 5670: [Followup] Rename test files.

* t/db_dependent/Patron/Borrower_Housebound.t: Rename to
  t/db_dependent/Patron/Housebound.t.
* t/db_dependent/Patron/Borrower_HouseboundProfiles.t: Rename to
  t/db_dependent/Patron/HouseboundProfiles.t.
* t/db_dependent/Patron/Borrower_HouseboundVisits.t: Rename to
  t/db_dependent/Patron/HouseboundVisits.t.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Claire Gravely  changed:

   What|Removed |Added

  Attachment #55336|0   |1
is obsolete||

--- Comment #86 from Claire Gravely  ---
Created attachment 56350
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56350=edit
Bug 5670: [Followup] Refactor .pl; error messages.

* members/housebound.pl: Refactor & store messages for encountered
  errors.
* koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: Show
  messages.

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Claire Gravely  changed:

   What|Removed |Added

  Attachment #55326|0   |1
is obsolete||

--- Comment #83 from Claire Gravely  ---
Created attachment 56347
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56347=edit
Bug 5670: Housebound Readers Module

New module to handle management of circulation to Housebound readers.

- Ability to create housebound profiles & scheduled visits for patrons.
- Ability to record users as Deliverers or Choosers (or both), using
  extended patron attributes.
- Ability to link choosers and deliverers to individual delivery runs.
- 'Delivery Frequencies' are customizable through authorised
  values ('HSBND_FREQ').

* koha-tmpl/intranet-tmpl/prog/en/includes/circ-menu.inc: add
  Housebound menu if appropriate.
* Koha/Patron.pm (housebound_profile): New method.
* Koha/Patrons.pm (housebound_choosers, housebound_deliverers): New
  methods.
* Koha/Patron/HouseboundProfile.pm: New File.
* Koha/Patron/HouseboundProfiles.pm: New File.
* Koha/Patron/HouseboundVisits.pm: New File.
* Koha/Patron/HouseboundVisit.pm: New File.
* koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: New file.
* members/housebound.pl: New file.
* installer/data/mysql/kohastructure.sql: Add housebound_* tables.
* installer/data/mysql/sysprefs.sql: Add HouseboundModule syspref.
* koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref:
  Add HouseboundModule syspref.
* installer/data/mysql/atomicupdate/housebound_tables.sql: New file.
* t/db_dependent/Patron/Borrower_Housebound.t: New file.
* t/db_dependent/Patron/Borrower_HouseboundProfiles.t: New file.
* t/db_dependent/Patron/Borrower_HouseboundVisits.t: New file.

Test plan:
- Apply patch.
- Run atomic update script.
- Run Unit Tests (t/db_dependent/Patron/Housebound*)
- Optionally, add additional authorised values to 'HSBND_FREQ'.
- Switch on 'HouseboundModule' syspref.
- Ensure 'ExtendedPatronAttributes syspref is on.
- On patron pages, when editing, add some to the Housebound deliverer
  and chooser groups by setting their extended attributes.
- On a patron page, the Housebound menu should now be present.
  - create housebound profile
+ ensure Frequency values seem pulled from 'HSBND_FREQ'.
  - create 'housebound visits' (deliveries)
+ ensure chooser/deliverer lists are populated with patrons that
  have the Chooser or Deliverer Attribute type.
  - edit visits.
  - delete visits.
- Switch off 'HouseboundModule'
  - the Housebound menu should disappear

Signed-off-by: Chris Cormack 

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Claire Gravely  changed:

   What|Removed |Added

  Attachment #54385|0   |1
is obsolete||

--- Comment #82 from Claire Gravely  ---
Created attachment 56346
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56346=edit
DO NOT PUSH: Add Housebound Schema files.

* Koha/Schema/Result/HouseboundProfile.pm: New file.
* Koha/Schema/Result/HouseboundVisit.pm: New file.

https://bugs.koha-community.org/show_bug.cgi?id=5670

Signed-off-by: Claire Gravely 

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #81 from Alex Sassmannshausen 
 ---
Created attachment 56341
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56341=edit
Bug 5670: [Followup] Add 'step 4' edit button.

* koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt:
  Place housebound role form inside the 'step 4' section.
* koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt:
  Add 'step 4' edit button for housebound role.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #80 from Alex Sassmannshausen 
 ---
Created attachment 56337
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56337=edit
Bug 5670: Add auth_val_cat to auth_val_cat.sql.

* installer/data/mysql/atomicupdate/housebound_tables.sql: Insert
  HSBND_FREQ in authorised value categories.
* installer/data/mysql/mandatory/auth_val_cat.sql: Add HSBND_FREQ.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Alex Sassmannshausen  changed:

   What|Removed |Added

 Depends on||17216


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17216
[Bug 17216] Add a new table to store authorized value categories
-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #79 from Alex Sassmannshausen 
 ---
New Test Plan:

Test plan:
- Apply patches (DO NOT PUSH contain the schema updates).
- Run atomic update script.
- Run Unit Tests (t/db_dependent/Patron/Housebound*)
- Optionally, add additional authorised values of 'Frequency'
  categories.
- Enable HouseboundModule module.
- On a patron page, you should see details of housebound roles
- When editing or creating a patron you can set the housebound roles.
- On a patron page, the Housebound menu should have been added.
  - create housebound profile
+ ensure Frequency values are from correct authorised values.
  - create 'housebound visits' (deliveries)
+ ensure chooser/deliverer lists are populated with patrons that
have the Chooser or Deliverer Attribute type (none by default: you
will have to grant some users those attributes).
  - edit the profile/instances.
  - delete the instances.
- Switch off 'HouseboundModule'
  - the Housebound menu should disappear

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #78 from Alex Sassmannshausen 
 ---
Created attachment 56308
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56308=edit
DO NOT PUSH: Moar Housebound Schema files.

* Koha/Schema/Result/Borrower.pm: New method.
* Koha/Schema/Result/HouseboundRole.pm: New file.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #77 from Alex Sassmannshausen 
 ---
The migration to using a new table, housebound_role, is now complete.

Thanks for all your work on this so far, hopefully we now have a pretty solid
feature!

Alex

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #75 from Alex Sassmannshausen 
 ---
Created attachment 56301
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56301=edit
Bug 5670: [QA Followup] Display HouseboundRole info.

* Koha/Patron.pm (housebound_role): New method.
* koha-tmpl/intranet-tmpl/prog/en/modules/members/moremember.tt: Add
  section for HouseboundRole information
* members/moremember.pl: Pass HouseboundRole info to template.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #76 from Alex Sassmannshausen 
 ---
Created attachment 56302
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56302=edit
Bug 5670: [QA Followup] HouseboundRole CRUD from UI.

* koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt: Add
  HouseboundRole form.
* members/memberentry.pl: Handle HouseboundRole CRUD.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #74 from Alex Sassmannshausen 
 ---
Created attachment 56300
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56300=edit
Bug 5670: [QA Followup] Correct housebound role search.

* Koha/Patrons.pm (search_housebound_choosers)
  (search_housebound_deliverers): Use new table.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #73 from Alex Sassmannshausen 
 ---
Created attachment 56299
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56299=edit
Bug 5670: [QA Followup] Create HouseboundRole objects.

* Koha/Patron/HouseboundRole.pm: New file.
* Koha/Patron/HouseboundRoles.pm: New file.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #72 from Alex Sassmannshausen 
 ---
Created attachment 56298
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56298=edit
Bug 5670: [QA Followup] Abandon Extended Patron Attr.

This patch series abandons the use of Extended Patron Attributes in
the HouseboundModule.  Instead we provide a separate table with a UI
from borrower edit/create.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #71 from Alex Sassmannshausen 
 ---
(In reply to Jonathan Druart from comment #67)
> (In reply to Alex Sassmannshausen from comment #66)
> > (In reply to Jonathan Druart from comment #65)
> > > (In reply to Jonathan Druart from comment #64)
> > > > > My alternative proposal now would be:
> > > > > - create a new custom table "housebound_role"
> > > > > - with three columns (borrower_id, deliverer, chooser)
> > > 
> > > The PK for this new table would be borrower_id, so should not it be 2 new
> > > columns in the borrowers table instead?
> > 
> > I considered that, but proposed a new table because:
> > - the borrowers table is quite large as it is.  Adding columns to it would
> > make it slightly less discoverable
> > - the vast majority of borrowers in the system will have neither a
> > "deliverer" nor a "chooser" role, so those columns will just be empty/false
> > in the borrowers table (this is particularly the case if the housebound
> > module is switched off!).
> > - in the housebound_role table the columns will only exist if the borrower
> > is in fact a volunteer of some form (either chooser or deliverer), so each
> > entry will be "doing something".
> > 
> > Conversely, joins are quite cheap, so I think I prefer this design.
> 
> My concern is more about the DB normalization, I think we need to keep that
> in mind and normalize it as much as possible to keep data integrity.
> I'd like to get more opinions before you start.

Fair enough, I've opened a thread on Koha-Dev.  Let's see where that goes.  If
worst comes to worst we might be able to hammer it out at the hackfest.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #70 from Alex Sassmannshausen 
 ---
(In reply to Katrin Fischer from comment #69)
> oh, I might have misread - chooser and deliverer would also each link to a
> borrowernumber.

Yeah, either way, a borrower could be either chooser or deliverer or both.

That should be possible with either a separate table for the module, or an
extension of the borrowers table.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #69 from Katrin Fischer  ---
oh, I might have misread - chooser and deliverer would also each link to a
borrowernumber.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #68 from Katrin Fischer  ---
Wondering, could be chooser and deliverer be the same person?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #67 from Jonathan Druart  
---
(In reply to Alex Sassmannshausen from comment #66)
> (In reply to Jonathan Druart from comment #65)
> > (In reply to Jonathan Druart from comment #64)
> > > > My alternative proposal now would be:
> > > > - create a new custom table "housebound_role"
> > > > - with three columns (borrower_id, deliverer, chooser)
> > 
> > The PK for this new table would be borrower_id, so should not it be 2 new
> > columns in the borrowers table instead?
> 
> I considered that, but proposed a new table because:
> - the borrowers table is quite large as it is.  Adding columns to it would
> make it slightly less discoverable
> - the vast majority of borrowers in the system will have neither a
> "deliverer" nor a "chooser" role, so those columns will just be empty/false
> in the borrowers table (this is particularly the case if the housebound
> module is switched off!).
> - in the housebound_role table the columns will only exist if the borrower
> is in fact a volunteer of some form (either chooser or deliverer), so each
> entry will be "doing something".
> 
> Conversely, joins are quite cheap, so I think I prefer this design.

My concern is more about the DB normalization, I think we need to keep that in
mind and normalize it as much as possible to keep data integrity.
I'd like to get more opinions before you start.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #66 from Alex Sassmannshausen 
 ---
(In reply to Jonathan Druart from comment #65)
> (In reply to Jonathan Druart from comment #64)
> > > My alternative proposal now would be:
> > > - create a new custom table "housebound_role"
> > > - with three columns (borrower_id, deliverer, chooser)
> 
> The PK for this new table would be borrower_id, so should not it be 2 new
> columns in the borrowers table instead?

I considered that, but proposed a new table because:
- the borrowers table is quite large as it is.  Adding columns to it would make
it slightly less discoverable
- the vast majority of borrowers in the system will have neither a "deliverer"
nor a "chooser" role, so those columns will just be empty/false in the
borrowers table (this is particularly the case if the housebound module is
switched off!).
- in the housebound_role table the columns will only exist if the borrower is
in fact a volunteer of some form (either chooser or deliverer), so each entry
will be "doing something".

Conversely, joins are quite cheap, so I think I prefer this design.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #65 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #64)
> > My alternative proposal now would be:
> > - create a new custom table "housebound_role"
> > - with three columns (borrower_id, deliverer, chooser)

The PK for this new table would be borrower_id, so should not it be 2 new
columns in the borrowers table instead?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #64 from Jonathan Druart  
---
(In reply to Alex Sassmannshausen from comment #63)
> (In reply to Jonathan Druart from comment #62)
> > (In reply to Alex Sassmannshausen from comment #61)
> > > > Same for HSBND_ROLE, it seems that another value is not taken into 
> > > > account
> > > > completely. It appears when editing a patron, but not on the housebound
> > > > details. What is the use case exactly?
> > > 
> > > You should find that HSBND_ROLE appears when creating an individual
> > > housebound_visit.  Any patrons tagged as chooser or deliverer will then
> > > appear as values which can be selected in the chooser and deliverer
> > > dropdowns in the edit/create visit screen.
> > 
> > Ok but what could be a third value? What could be a third value and how it
> > is supposed to behave?
> 
> Thinking about this some more last night, it feels like the current design
> is not appropriate.  You're quite right asking whether there could be third
> values, and the answer is there cannot.  The UI expects there to be only two
> values.
> 
> My alternative proposal now would be:
> - create a new custom table "housebound_role"
> - with three columns (borrower_id, deliverer, chooser)
> - remove the current dependency on extended patron attributes
> - remove HSBND_ROLE authorised values
> 
> So within this approach, I reduce complexity (no extended attributes, fewer
> authorised values), and confirm that housebound roles are not supposed to be
> extensible.
> 
> WDYT?

Yes, I think that it makes more sense and will be less confusing for developers
and users.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #63 from Alex Sassmannshausen 
 ---
(In reply to Jonathan Druart from comment #62)
> (In reply to Alex Sassmannshausen from comment #61)
> > > Same for HSBND_ROLE, it seems that another value is not taken into account
> > > completely. It appears when editing a patron, but not on the housebound
> > > details. What is the use case exactly?
> > 
> > You should find that HSBND_ROLE appears when creating an individual
> > housebound_visit.  Any patrons tagged as chooser or deliverer will then
> > appear as values which can be selected in the chooser and deliverer
> > dropdowns in the edit/create visit screen.
> 
> Ok but what could be a third value? What could be a third value and how it
> is supposed to behave?

Thinking about this some more last night, it feels like the current design is
not appropriate.  You're quite right asking whether there could be third
values, and the answer is there cannot.  The UI expects there to be only two
values.

My alternative proposal now would be:
- create a new custom table "housebound_role"
- with three columns (borrower_id, deliverer, chooser)
- remove the current dependency on extended patron attributes
- remove HSBND_ROLE authorised values

So within this approach, I reduce complexity (no extended attributes, fewer
authorised values), and confirm that housebound roles are not supposed to be
extensible.

WDYT?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #62 from Jonathan Druart  
---
(In reply to Alex Sassmannshausen from comment #61)
> > Same for HSBND_ROLE, it seems that another value is not taken into account
> > completely. It appears when editing a patron, but not on the housebound
> > details. What is the use case exactly?
> 
> You should find that HSBND_ROLE appears when creating an individual
> housebound_visit.  Any patrons tagged as chooser or deliverer will then
> appear as values which can be selected in the chooser and deliverer
> dropdowns in the edit/create visit screen.

Ok but what could be a third value? What could be a third value and how it is
supposed to behave?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #61 from Alex Sassmannshausen 
 ---
(In reply to Jonathan Druart from comment #58)
> Alex,
> 
> Sorry, not ready yet.
> 
> 1/ see comment 54

This should be fixed now.

> 2/ see last 3 patches, feel free to disagree.

Yeah, I like the patches — also added some more "required" markup to the
houseboundvisit page now.  Looks a bit naff, but at least it's clear.

> 3/ please adapt the Edit/Delete/Add a new delivery buttons to use the
> bootstrap buttons (you can contact Owen if you need help)

This is done.

> 4/ Some thinkings (not blocker):
> I think I would have preferred not to see this feature using the patron
> attributes. Specific columns in the borrowers table may have been better (?).
> What could be the different values of HSBND_FREQ? It seems that we could
> have avoid it if the user had the ability to select several days. But I may
> be missing something here.

Right, these are interesting questions.  Let's talk about HSBND_ROLE first.
I guess they could be implemented as a separate table or as extensions to the
borrowers table.  I don't consider either approach superior in this context
though.  The approach I have taken has the great benefit that it is working now
— and I'm not sure how much time I can still take to put into this feature.  So
I'd be tempted to keep it as is, unless there is a compelling case to change
it.

HSBND_FREQ is an authorised value because it will allow customers to specify
"distribution rotas" for their needs.  The field basically states, how often
does a visit for this profile take place?
This could take the shape of, for instance, once every week, once every month,
every other week, etc.  I.e. this is metadata about with what regularity a
profile is acted upon.

Individual visits are then organised according to that metadata.  The
individual dates associated with a visit should normally fall within the
pattern given by the HSBND_FREQ selected.

> Same for HSBND_ROLE, it seems that another value is not taken into account
> completely. It appears when editing a patron, but not on the housebound
> details. What is the use case exactly?

You should find that HSBND_ROLE appears when creating an individual
housebound_visit.  Any patrons tagged as chooser or deliverer will then appear
as values which can be selected in the chooser and deliverer dropdowns in the
edit/create visit screen.

HTH!

Alex

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #60 from Alex Sassmannshausen 
 ---
Created attachment 55891
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55891=edit
Bug 5670: [QA Followup] More "required" messages.

* koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: Mark
  houseboundvisit fields as required.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #59 from Alex Sassmannshausen 
 ---
Created attachment 55890
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55890=edit
Bug 5670: [QA Followup] Improve template style.

* koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: Remove
  toggler class from form, improve look and layout of action buttons.

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

Jonathan Druart  changed:

   What|Removed |Added

 CC||oleon...@myacpl.org

--- Comment #58 from Jonathan Druart  
---
Alex,

Sorry, not ready yet.

1/ see comment 54
2/ see last 3 patches, feel free to disagree.
3/ please adapt the Edit/Delete/Add a new delivery buttons to use the bootstrap
buttons (you can contact Owen if you need help)

4/ Some thinkings (not blocker):
I think I would have preferred not to see this feature using the patron
attributes. Specific columns in the borrowers table may have been better (?).
What could be the different values of HSBND_FREQ? It seems that we could have
avoid it if the user had the ability to select several days. But I may be
missing something here.
Same for HSBND_ROLE, it seems that another value is not taken into account
completely. It appears when editing a patron, but not on the housebound
details. What is the use case exactly?

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #57 from Jonathan Druart  
---
Created attachment 55867
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55867=edit
Bug 5670: remove useless call to ->new when ->search is enought

-- 
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #55 from Jonathan Druart  
---
Created attachment 55865
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55865=edit
Bug 5670: Add the 'required' class to required fields

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #56 from Jonathan Druart  
---
Created attachment 55866
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55866=edit
Bug 5670: mv housebound_* to search_housebound_*

I think it's better to prefix the subroutine names used to search with
'search_'.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 5670] Housebound Readers Module

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5670

--- Comment #54 from Jonathan Druart  
---
Comment on attachment 55734
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55734
Bug 5670: [QA Followup] Don't force ISO dates.

Review of attachment 55734:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=5670=55734)
-

::: koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt
@@ +208,4 @@
>  
>  [% ELSIF ( method == 'visit_update_or_create' ) %]
>Manage housebound deliveries
> +   class="toggler"

This 'toggler' class does not seem useful, could you confirm?

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the QA Contact for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/