[Koha-bugs] [Bug 6427] Rewrite of the accounts system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Martin Renvoize changed: What|Removed |Added Blocks|14373 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14373 [Bug 14373] Disallow payment of accruing fines -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Bug 6427 depends on bug 14027, which changed state. Bug 14027 Summary: Add TableTools plugin for DataTables https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14027 What|Removed |Added Status|BLOCKED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hallchanged: What|Removed |Added Resolution|--- |DUPLICATE Status|Patch doesn't apply |RESOLVED --- Comment #747 from Kyle M Hall --- *** This bug has been marked as a duplicate of bug 14825 *** -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Katrin Fischerchanged: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #746 from Katrin Fischer --- Hi Kyle, not sure about the dependency on 13790 - maybe this should be blocked by it and not the other way around (might have made a mistake there)? Also I saw you split of some patches for a more granular approach - what shall we do here? Patch currently doesn't apply - so choosing that for now. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hallchanged: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14825 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hallchanged: What|Removed |Added Blocks|2696| Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2696 [Bug 2696] Fine Payments Should Show What Was Paid For -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Nicole Engard (ByWater) nic...@bywatersolutions.com changed: What|Removed |Added CC||nic...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=13098 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Blocks|11622 | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Blocks||14373 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #733 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 39674 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39674action=edit Bug 6427 - Update existing Koha perl modules Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #734 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 39675 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39675action=edit Bug 6427 - Add new TT plugin to deal with currency Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #737 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 39678 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39678action=edit Bug 6427 - Update OPAC scripts Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #39063|0 |1 is obsolete|| Attachment #39064|0 |1 is obsolete|| Attachment #39065|0 |1 is obsolete|| Attachment #39066|0 |1 is obsolete|| Attachment #39067|0 |1 is obsolete|| Attachment #39069|0 |1 is obsolete|| Attachment #39070|0 |1 is obsolete|| Attachment #39071|0 |1 is obsolete|| Attachment #39072|0 |1 is obsolete|| Attachment #39073|0 |1 is obsolete|| Attachment #39074|0 |1 is obsolete|| Attachment #39075|0 |1 is obsolete|| Attachment #39076|0 |1 is obsolete|| Attachment #39077|0 |1 is obsolete|| Attachment #39078|0 |1 is obsolete|| Attachment #39079|0 |1 is obsolete|| --- Comment #730 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 39671 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39671action=edit Bug 6427 - Update database This patch set re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #731 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 39672 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39672action=edit Bug 6427 - Update schema files Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #739 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 39680 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39680action=edit Bug 6427 - Delete unused and unnecessary files Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #741 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 39682 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39682action=edit Bug 6427 - Make fines tabs link to account payment page Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #738 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 39679 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39679action=edit Bug 6427 - Add update cron scripts Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #740 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 39681 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39681action=edit Bug 6427 - Unit Tests Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #732 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 39673 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39673action=edit Bug 6427 - Add new Accounts related Koha modules Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #735 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 39676 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39676action=edit Bug 6427 - Add new staff scripts for managing accounts Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #736 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 39677 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39677action=edit Bug 6427 - Update existing intranet scripts Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #742 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 39683 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39683action=edit Bug 6427 [QA Followup] - Improvements to OPAC view -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #743 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 39684 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39684action=edit Bug 6427 [QA Followup] - Fix accounts table default sorting -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #745 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 39686 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39686action=edit Bug 6427 [QA Followup] - Fix kohastructure.sql -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #744 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 39685 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39685action=edit Bug 6427 [QA Followup] - Drop old accounts tables -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #38247|0 |1 is obsolete|| Attachment #38248|0 |1 is obsolete|| Attachment #38249|0 |1 is obsolete|| Attachment #38250|0 |1 is obsolete|| Attachment #38251|0 |1 is obsolete|| Attachment #38252|0 |1 is obsolete|| Attachment #38253|0 |1 is obsolete|| Attachment #38254|0 |1 is obsolete|| Attachment #38255|0 |1 is obsolete|| Attachment #38256|0 |1 is obsolete|| Attachment #38257|0 |1 is obsolete|| Attachment #38258|0 |1 is obsolete|| Attachment #38259|0 |1 is obsolete|| Attachment #38260|0 |1 is obsolete|| Attachment #38261|0 |1 is obsolete|| Attachment #38262|0 |1 is obsolete|| --- Comment #714 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 39063 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39063action=edit Bug 6427 - Update database This patch set re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #718 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 39067 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39067action=edit Bug 6427 - Add new TT plugin to deal with currency Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #725 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 39075 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39075action=edit Bug 6427 - Make fines tabs link to account payment page Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #727 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 39077 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39077action=edit Bug 6427 [QA Followup] - Fix accounts table default sorting -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #726 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 39076 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39076action=edit Bug 6427 [QA Followup] - Improvements to OPAC view -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #729 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 39079 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39079action=edit Bug 6427 [QA Followup] - Fix kohastructure.sql -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #728 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 39078 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39078action=edit Bug 6427 [QA Followup] - Drop old accounts tables -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #716 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 39065 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39065action=edit Bug 6427 - Add new Accounts related Koha modules Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #715 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 39064 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39064action=edit Bug 6427 - Update schema files Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #717 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 39066 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39066action=edit Bug 6427 - Update existing Koha perl modules Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #723 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 39073 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39073action=edit Bug 6427 - Delete unused and unnecessary files Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #724 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 39074 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39074action=edit Bug 6427 - Unit Tests Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #722 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 39072 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39072action=edit Bug 6427 - Add update cron scripts Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #721 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 39071 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39071action=edit Bug 6427 - Update OPAC scripts Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #720 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 39070 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39070action=edit Bug 6427 - Update existing intranet scripts Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #719 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 39069 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=39069action=edit Bug 6427 - Add new staff scripts for managing accounts Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=12159 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #709 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 38258 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38258action=edit Bug 6427 - Make fines tabs link to account payment page Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #710 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 38259 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38259action=edit Bug 6427 [QA Followup] - Improvements to OPAC view -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #707 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 38256 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38256action=edit Bug 6427 - Delete unused and unnecessary files Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #711 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 38260 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38260action=edit Bug 6427 [QA Followup] - Fix accounts table default sorting -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #713 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 38262 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38262action=edit Bug 6427 [QA Followup] - Fix kohastructure.sql -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #705 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 38254 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38254action=edit Bug 6427 - Update OPAC scripts Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #699 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 38248 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38248action=edit Bug 6427 - Update schema files Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #708 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 38257 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38257action=edit Bug 6427 - Unit Tests Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #706 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 38255 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38255action=edit Bug 6427 - Add update cron scripts Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #37229|0 |1 is obsolete|| Attachment #37230|0 |1 is obsolete|| Attachment #37231|0 |1 is obsolete|| Attachment #37232|0 |1 is obsolete|| Attachment #37233|0 |1 is obsolete|| Attachment #37235|0 |1 is obsolete|| Attachment #37236|0 |1 is obsolete|| Attachment #37237|0 |1 is obsolete|| Attachment #37238|0 |1 is obsolete|| Attachment #37239|0 |1 is obsolete|| Attachment #37240|0 |1 is obsolete|| Attachment #37241|0 |1 is obsolete|| Attachment #37242|0 |1 is obsolete|| Attachment #37243|0 |1 is obsolete|| Attachment #37244|0 |1 is obsolete|| --- Comment #698 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 38247 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38247action=edit Bug 6427 - Update database This patch set re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #702 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 38251 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38251action=edit Bug 6427 - Add new TT plugin to deal with currency Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #701 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 38250 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38250action=edit Bug 6427 - Update existing Koha perl modules Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #700 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 38249 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38249action=edit Bug 6427 - Add new Accounts related Koha modules Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #704 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 38253 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38253action=edit Bug 6427 - Update existing intranet scripts Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #703 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 38252 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38252action=edit Bug 6427 - Add new staff scripts for managing accounts Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #712 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 38261 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38261action=edit Bug 6427 [QA Followup] - Drop old accounts tables -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Depends on||14027 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #37234|0 |1 is obsolete|| -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #697 from Katrin Fischer katrin.fisc...@bsz-bw.de --- There have been some commnts that need to be addressed - I am switching to failed QA for the moment. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Jeremy Wellner jwell...@stanwood.wednet.edu changed: What|Removed |Added CC||jwell...@stanwood.wednet.ed ||u --- Comment #696 from Jeremy Wellner jwell...@stanwood.wednet.edu --- With Stanwood-Camano School District our textbook libraries really need this functionality to the point that we will offer to have this move onto our production server for more testing. Fines are a big deal for us as it prevents 12th graders from being allowed to graduate. What can we do to help this along further? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #695 from Josef Moravec josef.mora...@gmail.com --- (In reply to Josef Moravec from comment #694) I think that account_credits table should have foreign key to account_debits.debit_id, without this key, it´s impossible to group payments by fee type in reports. But this work is almost done, so it may be the best approach to open new bug for this enhancement... I am sorry, I just missed the table account_offsets... -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Josef Moravec josef.mora...@gmail.com changed: What|Removed |Added CC||josef.mora...@gmail.com --- Comment #693 from Josef Moravec josef.mora...@gmail.com --- I tried this by creating new instance, but web installer presented an SQL error when creating db structure: ERROR 1064 (42000) at line 3484: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'account_credits ( credit_id int(11) NOT NULL AUTO_INCREMENT, borrow' at line 1 I think the problem is on this line in kohastructure.sql: 3484 CREATE TABLE IF account_credits ( -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #694 from Josef Moravec josef.mora...@gmail.com --- I think that account_credits table should have foreign key to account_debits.debit_id, without this key, it´s impossible to group payments by fee type in reports. But this work is almost done, so it may be the best approach to open new bug for this enhancement... -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #691 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 37243 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37243action=edit Bug 6427 [QA Followup] - Fix accounts table default sorting -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #689 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 37241 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37241action=edit Bug 6427 - Make fines tabs link to account payment page Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #688 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 37240 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37240action=edit Bug 6427 - Unit Tests Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #690 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 37242 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37242action=edit Bug 6427 [QA Followup] - Improvements to OPAC view -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #686 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 37238 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37238action=edit Bug 6427 - Add update cron scripts Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #681 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 37233 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37233action=edit Bug 6427 - Add new TT plugin to deal with currency Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #682 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 37234 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37234action=edit Bug 6427 - Add TableTools plugin for DataTables Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #683 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 37235 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37235action=edit Bug 6427 - Add new staff scripts for managing accounts Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #684 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 37236 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37236action=edit Bug 6427 - Update existing intranet scripts Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #685 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 37237 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37237action=edit Bug 6427 - Update OPAC scripts Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #687 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 37239 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37239action=edit Bug 6427 - Delete unused and unnecessary files Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #37147|0 |1 is obsolete|| Attachment #37148|0 |1 is obsolete|| Attachment #37149|0 |1 is obsolete|| Attachment #37150|0 |1 is obsolete|| Attachment #37151|0 |1 is obsolete|| Attachment #37152|0 |1 is obsolete|| Attachment #37153|0 |1 is obsolete|| Attachment #37154|0 |1 is obsolete|| Attachment #37155|0 |1 is obsolete|| Attachment #37156|0 |1 is obsolete|| Attachment #37157|0 |1 is obsolete|| Attachment #37158|0 |1 is obsolete|| Attachment #37159|0 |1 is obsolete|| Attachment #37160|0 |1 is obsolete|| Attachment #37161|0 |1 is obsolete|| Attachment #37162|0 |1 is obsolete|| --- Comment #677 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 37229 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37229action=edit Bug 6427 - Update database This patch set re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #680 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 37232 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37232action=edit Bug 6427 - Update existing Koha perl modules Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #679 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 37231 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37231action=edit Bug 6427 - Add new Accounts related Koha modules Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #678 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 37230 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37230action=edit Bug 6427 - Update schema files Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #692 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 37244 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37244action=edit Bug 6427 [QA Followup] - Drop old accounts tables -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Depends on|2546, 8798 |13790 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #36324|0 |1 is obsolete|| Attachment #36326|0 |1 is obsolete|| Attachment #36327|0 |1 is obsolete|| Attachment #36328|0 |1 is obsolete|| Attachment #36329|0 |1 is obsolete|| Attachment #36330|0 |1 is obsolete|| Attachment #36331|0 |1 is obsolete|| Attachment #36332|0 |1 is obsolete|| Attachment #36333|0 |1 is obsolete|| Attachment #36334|0 |1 is obsolete|| Attachment #36335|0 |1 is obsolete|| Attachment #36337|0 |1 is obsolete|| Attachment #36338|0 |1 is obsolete|| Attachment #36340|0 |1 is obsolete|| Attachment #36380|0 |1 is obsolete|| Attachment #36393|0 |1 is obsolete|| --- Comment #645 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 37127 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37127action=edit Bug 6427 - Update database This patch set re-engineers Koha's accounting system to be faster, more stable, and have a better historical accounting of fees and payments while also unifying much of the payment logic and simplifying the code behind it. Three new tables have been created: account_debits stores fines and fees owed by the patron. account_credits stores payments, write-offs, and other line items that reduce the amount owed by a patron. account_offsets stores data about changes to debits and credits, including which credits paid which debits. borrowers.account_balance stores the current balance of the patron, so it does not have to be calculated each time it needs to be displayed. issues.issue_id has been added so that individual fines can be directly linked to the issue that caused them without ambiguity. The various accounting code strings ( F, FU, Rent, etc ), some of which have little or no documentation have been replaced by what enumerated data types which are documented via POD. There are three, one for each of Debits ( fees/fines ), Credits ( payments ), and Offsets. The system continues to allow custom fee types ( moving MANUAL_INV to MANUAL_DEBIT ) while additionally allowing custom payment types ( MANUAL_CREDIT ). The system also allows for overpayment, the the outstanding credit being applied to future fees as they are created. The system also allows for a librarian to accept a different amount of money than what is to be paid, and will calculate the change to be given. Test Plan: 1) Apply this patch 2) Create some manual fees 3) Test the fee payments * Pay one fee * Pay multiple fees * Make a partial payment * Write off a fee 4) View the fees/payments, verify they are correct 5) Check out some items as overdue that should have fines 6) Run fines.pl, verify fines were generated 7) Pay on an accruing fine 8) Run fines.pl again, verify the fine hasn't changed 9) Increase the daily fine in issuing rules 10) Run fines.pl again, verify the fine has increased 11) Decrease the daily fine in issuing rules 12) Run fines.pl again, verify the fine has decreased 13) Test dropbox mode 14) Test WhenLostChargeReplacementFee both ways 15) Test RefundLostItemFeeOnReturn both ways 16) Test WhenLostForgiveFine both ways 17) Test CalculateFinesOnReturn both ways Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #655 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 37138 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37138action=edit Bug 6427 - Delete unused and unnecessary files Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #652 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 37135 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37135action=edit Bug 6427 - Update existing intranet scripts Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #653 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 37136 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37136action=edit Bug 6427 - Update OPAC scripts Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #650 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 37133 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37133action=edit Bug 6427 - Add TableTools plugin for DataTables Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #647 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 37129 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37129action=edit Bug 6427 - Add new Accounts related Koha modules Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #651 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 37134 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37134action=edit Bug 6427 - Add new staff scripts for managing accounts Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #646 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 37128 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37128action=edit Bug 6427 - Update schema files Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #649 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 37131 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37131action=edit Bug 6427 - Add new TT plugin to deal with currency Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #648 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 37130 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37130action=edit Bug 6427 - Update existing Koha perl modules Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #659 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 37142 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37142action=edit Bug 6427 [QA Followup] - Fix accounts table default sorting -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #658 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 37141 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37141action=edit Bug 6427 [QA Followup] - Improvements to OPAC view -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #654 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 37137 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37137action=edit Bug 6427 - Add update cron scripts Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #657 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 37140 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37140action=edit Bug 6427 - Make fines tabs link to account payment page Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #660 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 37143 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37143action=edit Bug 6427 [QA Followup] - Drop old accounts tables -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6427] Rewrite of the accounts system
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6427 --- Comment #656 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 37139 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37139action=edit Bug 6427 - Unit Tests Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Sean McGarvey se...@pascolibraries.org -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/