[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #211 from M. Tompsett --- Created attachment 27225 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27225&action=edit Bug 6874 - id based on contents, filename, and directory. This patch corrects the inability to upload the same file to a different directory, or even a renamed file to the same directory. By including the filename and directory as part of the $id SHA generation, only identical files in the same directory with the same file name will generate the same $id. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #210 from M. Tompsett --- Further testing has shown an problem with the id generation. You can't upload a file with identical contents to different directories. I'll add a patch for that. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What|Removed |Added Attachment #27154|0 |1 is obsolete|| --- Comment #209 from M. Tompsett --- Created attachment 27155 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27155&action=edit Bug 6874 - Clean up file URL generation This adds a dependency on bug 5010, particularly the OPAC system preference: OpacProtocol. This is used to generate the http or https for the OPACBaseURL. This now checks for proper configuration of the system preference. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What|Removed |Added Depends on||5010 --- Comment #208 from M. Tompsett --- I have attached my rework which includes a dependency on bug 5010. I have set the status to ASSIGNED, because I have not tested it yet, and did not feel like asking anyone else to sign off until I have revisited a full testing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What|Removed |Added Attachment #27125|0 |1 is obsolete|| --- Comment #207 from M. Tompsett --- Created attachment 27154 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27154&action=edit Bug 6874 - Clean up file URL generation This adds a dependency on bug 5010, particularly the OPAC system preference: OpacProtocol. This is used to generate the http or https for the OPACBaseURL. This now checks for proper configuration of the system preference. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #206 from M. Tompsett --- (In reply to Robin Sheat from comment #205) >(after all, you might > want to host your Koha on gopher://... :) YES! Oh man. I haven't heard of that protocol for like decades, since university. Actually, Bernardo Gonzalez Kriegel, putting 'http://' or 'https://' into the OPACBaseURL can break things, because some places would then generate http://http://, because we are totally inconsistent in our appending in code vs. appending in templates. That kind of mistake busts really well in FireFox. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #205 from Robin Sheat --- (In reply to Bernardo Gonzalez Kriegel from comment #204) > Putting 'https://' on OPACBaseURL brakes something? > Is it safe to use it that way? We tend to not put the https:// part in, and it seems to work, though I bet there are corner cases that don't. I don't know what would happen if you included the protocol. Really, the whole syspref should be redesigned so that it requires it, so it can be set properly. I'm not sure what the best solution here is, perhaps make it work so that it'll add http:// unless the syspref =~ m|^\w+://| (after all, you might want to host your Koha on gopher://... :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #204 from Bernardo Gonzalez Kriegel --- (In reply to Robin Sheat from comment #203) > No it's not. In fact, these days we pretty much won't deploy anything > without it. People's passwords and personal information goes over it, after > all. Even more so when it's LDAPified to a corporate authentication server. Good point, you are right. Putting 'https://' on OPACBaseURL brakes something? Is it safe to use it that way? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #203 from Robin Sheat --- (In reply to Bernardo Gonzalez Kriegel from comment #201) > But... is strange to put OPAC under https No it's not. In fact, these days we pretty much won't deploy anything without it. People's passwords and personal information goes over it, after all. Even more so when it's LDAPified to a corporate authentication server. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #202 from Bernardo Gonzalez Kriegel --- Sorry, pressed wrong key. Mark, It's an idea, don't fully know if http(s):// is the expected beginning of base url. But that explained the wrong behavior I got. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #201 from Bernardo Gonzalez Kriegel --- (In reply to Robin Sheat from comment #199) > > /me points to https:// and frowns. But... is strange to put OPAC under https It's possible of course, but my followup only inserts it if it's not there. It can be modified to recongnize ^http only... Mark, it's just an idea, ta -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #200 from M. Tompsett --- Perhaps we need a dependency on bug 5010 to solve OPAC http vs. https issues? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #199 from Robin Sheat --- (In reply to Bernardo Gonzalez Kriegel from comment #197) > Created attachment 27125 [details] [review] > Bug 6874 - Fix file URL > > This patch prepends 'http://' to file upload URL, > because this patch series assumes (wrongly) that > OAPCBaseURL is filled WITH that :) /me points to https:// and frowns. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874
--- Comment #198 from Bernardo Gonzalez Kriegel ---
(In reply to M. Tompsett from comment #196)
> (In reply to Bernardo Gonzalez Kriegel from comment #194)
>
> So just to clarify. You tried to use this without OPACBaseURL set in the
> first place? And it seemed to upload fine. Then, you set the OPACBaseURL,
> and after logging out and back in, when you tried to check on the file it
> busted?
>
> I just patched the license stuff. I'll attempt to recreate your problem
> tomorrow.
Mark, found it!
Your OPACBaseURL must be filled with "http://";, that's it
And it's wrong, or at last it's not suggested when you fill the preference
("The OPAC is located at http:// ... ")
Look my followup, use it or not, fix as you like and squash with previous patch
Regards :)
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #197 from Bernardo Gonzalez Kriegel --- Created attachment 27125 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27125&action=edit Bug 6874 - Fix file URL This patch prepends 'http://' to file upload URL, because this patch series assumes (wrongly) that OAPCBaseURL is filled WITH that :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #196 from M. Tompsett --- (In reply to Bernardo Gonzalez Kriegel from comment #194) So just to clarify. You tried to use this without OPACBaseURL set in the first place? And it seemed to upload fine. Then, you set the OPACBaseURL, and after logging out and back in, when you tried to check on the file it busted? I just patched the license stuff. I'll attempt to recreate your problem tomorrow. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #195 from M. Tompsett --- Created attachment 27114 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27114&action=edit Bug 6874 - License Text Update This updates the license text for - C4/UploadedFiles.pm - cataloguing/value_builder/upload.pl - opac/opac-retrieve-file.pl to GPL v3 as per the http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence text. TEST PLAN - 1) Don't apply this patch as part of 6874. 2) Run the koha qa test tool. -- It will FAIL for those three file. 3) Apply this patch 4) Run the koha qa test tool. -- License problem is corrected, no FAILs. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Bernardo Gonzalez Kriegel changed: What|Removed |Added CC||bgkrie...@gmail.com --- Comment #194 from Bernardo Gonzalez Kriegel --- Hi, testing Found a problem, at first I have an empty OPACbaseURL, file upload worked. Then I set base url, now when I upload a file, the original file name is not appended at the end of the 'new' name, I got something like "/cgi-bin/koha/opac-retrieve-file.pl?id=775f48aaf5f7a44fa534dae4e7dc876ea7191115", with a missing "_filename.ext" But file is created, and I can delete it, but url does not work Other little things, koha-qa FAIL C4/UploadedFiles.pm FAIL cataloguing/value_builder/upload.pl ... FAIL opac/opac-retrieve-file.pl with error FAIL forbidden patterns forbidden pattern: Koha is now under the GPLv3 license (line 9) Just an old version of licence on files, update http://wiki.koha-community.org/wiki/Coding_Guidelines#Licence -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Jared Camins-Esakov changed: What|Removed |Added CC|jcam...@cpbibliography.com | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #193 from M. Tompsett --- Given that master has had things added to it. I rebased against master. The only thing that really needs sign off is the last patch (kohastructure.sql, jquery.js, refocus, and more). You can find a mega test plan in comment 175. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What|Removed |Added Attachment #26423|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What|Removed |Added Attachment #26422|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What|Removed |Added Attachment #26419|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What|Removed |Added Attachment #26421|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What|Removed |Added Attachment #26420|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What|Removed |Added Attachment #26418|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #191 from M. Tompsett --- Created attachment 26883 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26883&action=edit Bug 6874: Force user to select a directory This patch adds a javascript and a server-side checks Test plan: 1/ Choose a file, leave the radios not selected and submit 2/ You have a javascript alert which prevents form to be submitted 3/ Disable javascript and repeat step 1 4/ Form is submitted but form is redisplayed with an error message telling you to choose a directory. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What|Removed |Added Attachment #26424|0 |1 is obsolete|| --- Comment #192 from M. Tompsett --- Created attachment 26884 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26884&action=edit Bug 6874 - kohastructure.sql, jquery.js, refocus, and more Two problems were discovered while doing a fresh install of Koha. These problems in the kohastructure.sql file are addressed with this patch. Clicking the plug-in icon should cause the popup window to refocus. This adds the refocus code to the upload.pl file. The path to the jquery.js script was wrong in the upload_delete_file.tt file. Changed [% themelang %] to [% interface %]. If a user clones 856$u after uploading a file, deletes the file, and then clicks the plugin icon on the first 856$u, this will go immediately to the upload screen with an informative error message. After some validation was added, it was extended to include other cases. This serves to patch 6874 to a state where sign off should be possible. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #189 from M. Tompsett --- Created attachment 26881 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26881&action=edit Bug 6874: Move uploadPath syspref to koha-conf.xml Signed-off-by: Kyle M Hall Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #190 from M. Tompsett --- Created attachment 26882 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26882&action=edit Bug 6874 - File upload in MARC - QA Followup * Renames uploadPath to upload_path to follow the standard naming conventions in koha-conf which use underscores rather than camel case * Remove reference to intranet-tmpl and replace with [% interface %] required to pass qa Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #188 from M. Tompsett --- Created attachment 26880 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26880&action=edit Bug 6874: Add unit tests for C4::UploadedFiles Add unit tests for C4::UploadedFiles and move a variable declaration at subroutine level instead of file level. Add dependency to Test::CGI::Multipart Still works, and the newly-provided unit tests have good test coverage: C4/UploadedFiles.pm 90.765.066.7100.0 100.00.286.4 Signed-off-by: Jared Camins-Esakov Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #187 from M. Tompsett --- Created attachment 26879 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26879&action=edit Bug 6874: QA follow-up Squash of the following commits: return with explicit undef removed Follow-up for PBP fixes follow-up fix POD syntax follow-up jquery has moved Signed-off-by: Paul Poulain Signed-off-by: Jared Camins-Esakov Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #186 from M. Tompsett --- Created attachment 26878 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26878&action=edit Bug 6874: File upload in MARC New cataloging plugin upload.pl and new system preference 'uploadPath'. upload.pl provide a way to upload files on the server and store a link (url) to it in MARC uploadPath is the absolute path on the server where the files will be stored. It's possible to have a hierarchy of directories under this path and the plugin will allow to choose in which directory to store the file. Stored value in MARC subfield looks like this: /cgi-bin/koha/opac-retrieve-file.pl?id= So both 'uploadPath' and 'OPACBaseURL' sysprefs have to be set for this plugin to work correctly Signed-off-by: Kyle M Hall Signed-off-by: Paul Poulain Signed-off-by: Jared Camins-Esakov Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #185 from M. de Rooy --- (In reply to M. Tompsett from comment #184) > I hope this helps someone decide to take the plunge and test this. :) Looking back at the history of this patch, I definitely admire the perseverance of Julian and Mark to get this into Koha. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #184 from M. Tompsett --- Someone asked about how to test and why I have my name on so many things. I thought perhaps posting this might help people find the test plan and some background details. > Also, why many commits have only your sign? > Why is your sign at all? Because I didn’t write all the first part. I tested it, because we wanted the same functionality. > It's also difficult to test something without a clear test plan. Yes, yes, it is. I started... Comment 109. Comment 123. Katrin makes similar comments regarding the test plan being difficult or lacking in Comment 128. Comment 131. Comment 142. Which all cumulated into what you are looking for: Comment 175 I only wrote the last patch, which is not signed off. And in my mind, it is the only thing stopping this from reaching QA. > Could you add a description of what to test, before and after patch Before, Koha does not host files, and 856$u needs to point to some external source. After, Koha’s tag editor lets you upload a file and have a URL automatically generated to point to that newly hosted file. I hope this helps someone decide to take the plunge and test this. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #183 from M. Tompsett --- I rebase'd to master. The last patch still needs sign off. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What|Removed |Added Attachment #23613|0 |1 is obsolete|| --- Comment #182 from M. Tompsett --- Created attachment 26424 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26424&action=edit Bug 6874 - kohastructure.sql, jquery.js, refocus, and more Two problems were discovered while doing a fresh install of Koha. These problems in the kohastructure.sql file are addressed with this patch. Clicking the plug-in icon should cause the popup window to refocus. This adds the refocus code to the upload.pl file. The path to the jquery.js script was wrong in the upload_delete_file.tt file. Changed [% themelang %] to [% interface %]. If a user clones 856$u after uploading a file, deletes the file, and then clicks the plugin icon on the first 856$u, this will go immediately to the upload screen with an informative error message. After some validation was added, it was extended to include other cases. This serves to patch 6874 to a state where sign off should be possible. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What|Removed |Added Attachment #23611|0 |1 is obsolete|| --- Comment #180 from M. Tompsett --- Created attachment 26422 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26422&action=edit [SIGNED OFF] Bug 6874 - File upload in MARC - QA Followup * Renames uploadPath to upload_path to follow the standard naming conventions in koha-conf which use underscores rather than camel case * Remove reference to intranet-tmpl and replace with [% interface %] required to pass qa Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What|Removed |Added Attachment #23612|0 |1 is obsolete|| --- Comment #181 from M. Tompsett --- Created attachment 26423 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26423&action=edit [SIGNED OFF] Bug 6874: Force user to select a directory This patch adds a javascript and a server-side checks Test plan: 1/ Choose a file, leave the radios not selected and submit 2/ You have a javascript alert which prevents form to be submitted 3/ Disable javascript and repeat step 1 4/ Form is submitted but form is redisplayed with an error message telling you to choose a directory. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What|Removed |Added Attachment #23610|0 |1 is obsolete|| --- Comment #179 from M. Tompsett --- Created attachment 26421 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26421&action=edit [SIGNED OFF] Bug 6874: Move uploadPath syspref to koha-conf.xml Signed-off-by: Kyle M Hall Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What|Removed |Added Attachment #23609|0 |1 is obsolete|| --- Comment #178 from M. Tompsett --- Created attachment 26420 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26420&action=edit [SIGNED OFF] Bug 6874: Add unit tests for C4::UploadedFiles Add unit tests for C4::UploadedFiles and move a variable declaration at subroutine level instead of file level. Add dependency to Test::CGI::Multipart Still works, and the newly-provided unit tests have good test coverage: C4/UploadedFiles.pm 90.765.066.7100.0 100.00.286.4 Signed-off-by: Jared Camins-Esakov Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What|Removed |Added Attachment #23607|0 |1 is obsolete|| --- Comment #176 from M. Tompsett --- Created attachment 26418 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26418&action=edit [SIGNED OFF] Bug 6874: File upload in MARC New cataloging plugin upload.pl and new system preference 'uploadPath'. upload.pl provide a way to upload files on the server and store a link (url) to it in MARC uploadPath is the absolute path on the server where the files will be stored. It's possible to have a hierarchy of directories under this path and the plugin will allow to choose in which directory to store the file. Stored value in MARC subfield looks like this: /cgi-bin/koha/opac-retrieve-file.pl?id= So both 'uploadPath' and 'OPACBaseURL' sysprefs have to be set for this plugin to work correctly Signed-off-by: Kyle M Hall Signed-off-by: Paul Poulain Signed-off-by: Jared Camins-Esakov Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What|Removed |Added Attachment #23608|0 |1 is obsolete|| --- Comment #177 from M. Tompsett --- Created attachment 26419 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=26419&action=edit [SIGNED OFF] Bug 6874: QA follow-up Squash of the following commits: return with explicit undef removed Follow-up for PBP fixes follow-up fix POD syntax follow-up jquery has moved Signed-off-by: Paul Poulain Signed-off-by: Jared Camins-Esakov Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874
M. Tompsett changed:
What|Removed |Added
Status|In Discussion |Needs Signoff
--- Comment #175 from M. Tompsett ---
MEGA TEST PLAN
--
git checkout -b bug_6874 origin/master
git bz apply 6874
-- yes, it should all apply smoothly.
I intentionally restored an old backup from a couple months ago to force the
upgrade.
staff client:
-- upgrade
-- login
Koha administration
MARC Bibliographic framework
MARC structure (for BKS)
Search for 856
Subfields
Edit (for u)
Other options
Plugin: upload.pl
Save changes
Search the catalog tab
{choose a word, any word. I used fancy, because I knew we had a cookbook}
click first link
Edit
Edit record
8 (that's the tab name)
click the name for 856
scroll down to u and click the plugin icon
-- Correctly got a configuration error message.
At a command prompt:
vi ~/koha-dev/etc/koha-conf.xml
/enable_plug
-- add in:
{appropriate path. I used /home/mtompset/uploads}
:wq
mkdir {appropriate path used}
-- I even added some subdirectories
sudo chown -R -v www-data.www-data {appropriate path used}
Back in staff client:
click the plugin icon again
-- this time an upload screen pops up
click the 'Upload file' button
-- message about no file or destination
browse for a file, select one
click the 'Upload file' button
-- message about no destination
click the 'Cancel' button
click the plugin icon
click a destination radio button
click the 'Upload file' button
-- message about no file
browse for a file, select one
click the 'Upload file' button
-- message about success
click the 'close' button.
-- the text box has been filled in with a nice URL
click the plugin icon
click cancel
click the plugin icon
click delete
-- the test box should be blanked, and a success message given
click Close
-- reupload a file properly
click the plugin icon
click delete
click upload file
browse for a file, select a destination, click upload file
click close on success message
click 'Clone this subfield'
click the second plugin icon
click delete
click close
click the first plugin icon
-- Nice error message about a URL which points to nothing.
click cancel
In the second 856$u type in a URL (eg. www.google.com)
click the second plugin icon
-- this jumps immediately to the upload screen, but does not give an error
message, because the URL does not have opac-retrieve-file in it.
click save (we need to save the bibliographic record)
In OPAC:
search for the same word (I used fancy)
find the entry you just updated with links
click the two links. The dangling entry should give you a 500 error, and the
other link should work just fine.
get back to the detail page
In staff client:
edit
edit record
8
change the 856$u to a valid file in the first link.
save
In OPAC:
refresh the detail page, and click the first link again
this time it should get downloaded nicely.
>From a command line:
prove -v t/db_dependent/UploadedFiles.t
perldoc C4::Biblio
perldoc C4::UploadedFiles
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What|Removed |Added Attachment #21435|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What|Removed |Added Attachment #23590|0 |1 is obsolete|| --- Comment #169 from M. Tompsett --- Created attachment 23608 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23608&action=edit [SIGNED OFF] Bug 6874: QA follow-up Squash of the following commits: return with explicit undef removed Follow-up for PBP fixes follow-up fix POD syntax follow-up jquery has moved Signed-off-by: Paul Poulain Signed-off-by: Jared Camins-Esakov Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What|Removed |Added Attachment #21803|0 |1 is obsolete|| --- Comment #174 from M. Tompsett --- Created attachment 23613 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23613&action=edit Bug 6874 - kohastructure.sql, jquery.js, refocus, and more Two problems were discovered while doing a fresh install of Koha. These problems in the kohastructure.sql file are addressed with this patch. Clicking the plug-in icon should cause the popup window to refocus. This adds the refocus code to the upload.pl file. The path to the jquery.js script was wrong in the upload_delete_file.tt file. Changed [% themelang %] to [% interface %]. If a user clones 856$u after uploading a file, deletes the file, and then clicks the plugin icon on the first 856$u, this will go immediately to the upload screen with an informative error message. After some validation was added, it was extended to include other cases. This serves to patch 6874 to a state where sign off should be possible. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What|Removed |Added Attachment #23589|0 |1 is obsolete|| --- Comment #168 from M. Tompsett --- Created attachment 23607 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23607&action=edit [SIGNED OFF] Bug 6874: File upload in MARC New cataloging plugin upload.pl and new system preference 'uploadPath'. upload.pl provide a way to upload files on the server and store a link (url) to it in MARC uploadPath is the absolute path on the server where the files will be stored. It's possible to have a hierarchy of directories under this path and the plugin will allow to choose in which directory to store the file. Stored value in MARC subfield looks like this: /cgi-bin/koha/opac-retrieve-file.pl?id= So both 'uploadPath' and 'OPACBaseURL' sysprefs have to be set for this plugin to work correctly Signed-off-by: Kyle M Hall Signed-off-by: Paul Poulain Signed-off-by: Jared Camins-Esakov Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What|Removed |Added Attachment #23591|0 |1 is obsolete|| --- Comment #170 from M. Tompsett --- Created attachment 23609 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23609&action=edit [SIGNED OFF] Bug 6874: Add unit tests for C4::UploadedFiles Add unit tests for C4::UploadedFiles and move a variable declaration at subroutine level instead of file level. Add dependency to Test::CGI::Multipart Still works, and the newly-provided unit tests have good test coverage: C4/UploadedFiles.pm 90.765.066.7100.0 100.00.286.4 Signed-off-by: Jared Camins-Esakov Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What|Removed |Added Attachment #21801|0 |1 is obsolete|| --- Comment #172 from M. Tompsett --- Created attachment 23611 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23611&action=edit [SIGNED OFF] Bug 6874 - File upload in MARC - QA Followup * Renames uploadPath to upload_path to follow the standard naming conventions in koha-conf which use underscores rather than camel case * Remove reference to intranet-tmpl and replace with [% interface %] required to pass qa Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #171 from M. Tompsett --- Created attachment 23610 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23610&action=edit [SIGNED OFF] Bug 6874: Move uploadPath syspref to koha-conf.xml Signed-off-by: Kyle M Hall Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What|Removed |Added Attachment #21802|0 |1 is obsolete|| --- Comment #173 from M. Tompsett --- Created attachment 23612 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23612&action=edit [SIGNED OFF] Bug 6874: Force user to select a directory This patch adds a javascript and a server-side checks Test plan: 1/ Choose a file, leave the radios not selected and submit 2/ You have a javascript alert which prevents form to be submitted 3/ Disable javascript and repeat step 1 4/ Form is submitted but form is redisplayed with an error message telling you to choose a directory. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #167 from M. Tompsett --- I've almost got something nice working. I fixed DelUploadedFile and added DanglingEntry. Hopefully something will be finished in 24 hours. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What|Removed |Added Attachment #21434|0 |1 is obsolete|| --- Comment #166 from M. Tompsett --- Comment on attachment 21434 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21434 [SIGNED-OFF] Bug 6874: Add unit tests for C4::UploadedFiles I rebased this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #165 from M. Tompsett --- Created attachment 23591 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23591&action=edit [SIGNED OFF] Bug 6874: Add unit tests for C4::UploadedFiles and move a variable declaration at subroutine level instead of file level. Add dependency to Test::CGI::Multipart Signed-off-by: Jared Camins-Esakov Still works, and the newly-provided unit tests have good test coverage: C4/UploadedFiles.pm 90.765.066.7100.0 100.00.286.4 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What|Removed |Added Attachment #21433|0 |1 is obsolete|| --- Comment #164 from M. Tompsett --- Comment on attachment 21433 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21433 [SIGNED-OFF] Bug 6874: QA follow-up I rebased this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #163 from M. Tompsett --- Created attachment 23590 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23590&action=edit [SIGNED OFF] Bug 6874: QA follow-up Squash of the following commits: return with explicit undef removed Follow-up for PBP fixes follow-up fix POD syntax follow-up jquery has moved Signed-off-by: Paul Poulain Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What|Removed |Added Attachment #21432|0 |1 is obsolete|| --- Comment #162 from M. Tompsett --- Comment on attachment 21432 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21432 [SIGNED-OFF] Bug 6874: File upload in MARC I rebased it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #161 from M. Tompsett --- Created attachment 23589 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23589&action=edit [SIGNED OFF] Bug 6874: File upload in MARC New cataloging plugin upload.pl and new system preference 'uploadPath'. upload.pl provide a way to upload files on the server and store a link (url) to it in MARC uploadPath is the absolute path on the server where the files will be stored. It's possible to have a hierarchy of directories under this path and the plugin will allow to choose in which directory to store the file. Stored value in MARC subfield looks like this: /cgi-bin/koha/opac-retrieve-file.pl?id= So both 'uploadPath' and 'OPACBaseURL' sysprefs have to be set for this plugin to work correctly Signed-off-by: Kyle M Hall Signed-off-by: Paul Poulain Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What|Removed |Added Attachment #23588|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #160 from M. Tompsett --- Created attachment 23588 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23588&action=edit Bug 6874: File upload in MARC New cataloging plugin upload.pl and new system preference 'uploadPath'. upload.pl provide a way to upload files on the server and store a link (url) to it in MARC uploadPath is the absolute path on the server where the files will be stored. It's possible to have a hierarchy of directories under this path and the plugin will allow to choose in which directory to store the file. Stored value in MARC subfield looks like this: /cgi-bin/koha/opac-retrieve-file.pl?id= So both 'uploadPath' and 'OPACBaseURL' sysprefs have to be set for this plugin to work correctly Signed-off-by: Kyle M Hall Signed-off-by: Paul Poulain Signed-off-by: Jared Camins-Esakov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874
--- Comment #159 from M. Tompsett ---
(In reply to Paul Poulain from comment #158)
> (In reply to M. Tompsett from comment #156)
> > I have some other related questions:
> > - should validate URLs, since not all 856$u urls will be uploaded file urls.
> Not sure I understand well the question, but isn't
> misc/cronjobs/check-url-quick.pl what you're asking ?
No.
if ( is this one of our uploaded files ) { continue processing as expected }
else { give big warning, and then go immediately to the upload, not the delete
page }
> > - is telling a user to check errors logs reasonable? They may not have shell
> > access to the system.
> No, it isn't
Then we need to fix that. However, I think that is in part of the signed off
patches.
> > - If a valid external url is detected, then a different response is needed
> > than if we discover a url to a deleted file.
> I think check-url-quick.pl achieve the goal, and it's better because it
> detects when an URL becomes invalid at any time.
This isn't about an invalid URL. Frankly, I don't care about the validity as
much as I care about the process flow. If I have a url in the 856$u field and
click the plugin icon, I do not expect to attempt to delete an external url
(not our hosted files that were uploaded).
> > - How will the user know to delete the text field before clicking the plugin
> > icon in order to continue onto the upload screen to put a different file in
> > place?
> I don't understand this one.
Test this.
Upload a file.
Clone the field.
Now there are two fields pointing to the same uploaded file.
Click the plug in icon, and delete the file, but then cancel.
Now there are two fields: one blanked (because you just deleted), and the other
with a dangling reference.
Now, click the plugin icon for the non-empty 856$u field.
It's going to prompt to delete. The user will click "Delete", because there is
no way to go to upload otherwise, and an error will be generated (because the
file was already deleted). And there is no meaningful feedback suggesting to
clear the field before clicking the plugin icon, so the user will be frustrated
because they can't seem to upload a file anymore, because they overlook the
obvious idea of clearing the field.
> Are my answer OK and is it back to go to signed-off ?
> (I have not tested the patches still applies cleanly)
If I have clarified what I mean, and you do test and see the process flow, then
you'll understand that with a couple more validations the process can be made
smoother.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #158 from Paul Poulain --- (In reply to M. Tompsett from comment #156) > I have some other related questions: > - should validate URLs, since not all 856$u urls will be uploaded file urls. Not sure I understand well the question, but isn't misc/cronjobs/check-url-quick.pl what you're asking ? > - external urls will generate the same apparent error deleting as the > cloning scenario I mentioned in comment #154. see my previous answer. > - is telling a user to check errors logs reasonable? They may not have shell > access to the system. No, it isn't > - If a valid external url is detected, then a different response is needed > than if we discover a url to a deleted file. I think check-url-quick.pl achieve the goal, and it's better because it detects when an URL becomes invalid at any time. > - How will the user know to delete the text field before clicking the plugin > icon in order to continue onto the upload screen to put a different file in > place? I don't understand this one. > The signed off patches need a rebase. Feedback on these questions would be > useful. I'm leaving the status at In Discussion, because even if my patch > was signed off, the problem with respect to external urls and deleted files, > due to a clone, would still exist. And that seems like enough to merit not > just running for QA's approval. Are my answer OK and is it back to go to signed-off ? (I have not tested the patches still applies cleanly) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #157 from Paul Poulain --- (In reply to M. Tompsett from comment #154) > Shoot... My librarian colleague came up with a scenario that breaks this. > > 1) Upload and set everything for a 856$u. > 2) Clone the subfield. > 3) Click the plugin icon. > This is where the problem comes in, because now the two subfields you can > end up deleting the file for the current 856$u, but the other 856$u still > has a reference to the deleted file in it. I think it's not a big deal: the user just get an invalid URL. That's exactly the same thing as when the librarian fills an invalid URL. Also note that the script misc/cronjobs/check-url-quick.pl will detect the problem. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #156 from M. Tompsett --- I have some other related questions: - should validate URLs, since not all 856$u urls will be uploaded file urls. - external urls will generate the same apparent error deleting as the cloning scenario I mentioned in comment #154. - is telling a user to check errors logs reasonable? They may not have shell access to the system. - If a valid external url is detected, then a different response is needed than if we discover a url to a deleted file. - How will the user know to delete the text field before clicking the plugin icon in order to continue onto the upload screen to put a different file in place? The signed off patches need a rebase. Feedback on these questions would be useful. I'm leaving the status at In Discussion, because even if my patch was signed off, the problem with respect to external urls and deleted files, due to a clone, would still exist. And that seems like enough to merit not just running for QA's approval. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #155 from M. Tompsett --- While we're waiting for a design suggestion to solve the test case I posted, could the original author please rebase his first two signed off patches? Thank you. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What|Removed |Added Status|Needs Signoff |In Discussion --- Comment #154 from M. Tompsett --- Shoot... My librarian colleague came up with a scenario that breaks this. 1) Upload and set everything for a 856$u. 2) Clone the subfield. 3) Click the plugin icon. This is where the problem comes in, because now the two subfields you can end up deleting the file for the current 856$u, but the other 856$u still has a reference to the deleted file in it. Any ideas? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #153 from Dobrica Pavlinusic --- I'm applying on 3.2.x branch, but since it's removed in another patch, it would probably be better to drop all changes to sysprefs from this patchset instead of modifying it and than reverting it back. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #152 from Dobrica Pavlinusic --- I also have conflict in sysprefs: CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Dobrica Pavlinusic changed: What|Removed |Added CC||dpav...@rot13.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874
--- Comment #151 from M. Tompsett ---
Comment on attachment 21434
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21434
[SIGNED-OFF] Bug 6874: Add unit tests for C4::UploadedFiles
Review of attachment 21434:
-->
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6874&attachment=21434)
-
::: C4/Installer/PerlDependencies.pm
@@ +692,5 @@
> +'Test::CGI::Multipart' => {
> +'usage'=> 'Tests',
> +'required' => '0',
> +'min_ver' => '0.0.3',
> +},
This needs a rebase now. :(
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #150 from M. Tompsett --- Test Plan for my patch: - click plugin icon (after all the necessary configuration and setup). No red message is given. - Turn off javascript - click 'Upload file' Should get pretty red message about both things not selected. - go through combinations of one or the other, but not both, and clicking upload Should get pretty red message each time with appropriate message. - Turn on javascript - go through combinations of none, one, and then the other, javascript alerts should warn appropriately. - after linking the 856$u field to a preset URL, click the plugin icon, and delete the file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What|Removed |Added Attachment #21635|0 |1 is obsolete|| --- Comment #148 from M. Tompsett --- Created attachment 21802 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21802&action=edit [SIGNED OFF] Bug 6874: Force user to select a directory This patch adds a javascript and a server-side checks Test plan: 1/ Choose a file, leave the radios not selected and submit 2/ You have a javascript alert which prevents form to be submitted 3/ Disable javascript and repeat step 1 4/ Form is submitted but form is redisplayed with an error message telling you to choose a directory. Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What|Removed |Added Attachment #21799|0 |1 is obsolete|| --- Comment #149 from M. Tompsett --- Created attachment 21803 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21803&action=edit Bug 6874 - kohastructure.sql, jquery.js, refocus, and more Two problems were discovered while doing a fresh install of Koha. These problems in the kohastructure.sql file are addressed with this patch. Clicking the plug-in icon should cause the popup window to refocus. This adds the refocus code to the upload.pl file. The path to the jquery.js script was wrong in the upload_delete_file.tt file. Changed [% themelang %] to [% interface %]. After some validation was added, it was extended to include other cases. This serves to patch 6874 to a state where sign off should be possible. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What|Removed |Added Attachment #21800|0 |1 is obsolete|| --- Comment #147 from M. Tompsett --- Created attachment 21801 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21801&action=edit [SIGNED OFF] Bug 6874 - File upload in MARC - QA Followup * Renames uploadPath to upload_path to follow the standard naming conventions in koha-conf which use underscores rather than camel case * Remove reference to intranet-tmpl and replace with [% interface %] required to pass qa Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What|Removed |Added Attachment #21436|0 |1 is obsolete|| --- Comment #146 from M. Tompsett --- Created attachment 21800 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21800&action=edit [SIGNED OFF] Bug 6874 - File upload in MARC - QA Followup * Renames uploadPath to upload_path to follow the standard naming conventions in koha-conf which use underscores rather than camel case * Remove reference to intranet-tmpl and replace with [% interface %] required to pass qa Signed-off-by: Mark Tompsett -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What|Removed |Added Attachment #21546|0 |1 is obsolete|| --- Comment #145 from M. Tompsett --- Comment on attachment 21546 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21546 Bug 6874 - kohastructure.sql & jquery.js fix with refocus squashed my patches into one on the end. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What|Removed |Added Attachment #21798|0 |1 is obsolete|| --- Comment #144 from M. Tompsett --- Created attachment 21799 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21799&action=edit Bug 6874 - kohastructure.sql, jquery.js, refocus, and more Two problems were discovered while doing a fresh install of Koha. These problems in the kohastructure.sql file are addressed with this patch. Clicking the plug-in icon should cause the popup window to refocus. This adds the refocus code to the upload.pl file. The path to the jquery.js script was wrong in the upload_delete_file.tt file. Changed [% themelang %] to [% interface %]. After some validation was added, it was extended to include other cases. This serves to patch 6874 to a state where sign off should be possible. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #143 from M. Tompsett --- Created attachment 21798 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21798&action=edit Bug 6874 - kohastructure.sql, jquery.js, refocus, and more Two problems were discovered while doing a fresh install of Koha. These problems in the kohastructure.sql file are addressed with this patch. Clicking the plug-in icon should cause the popup window to refocus. This adds the refocus code to the upload.pl file. The path to the jquery.js script was wrong in the upload_delete_file.tt file. Changed [% themelang %] to [% interface %]. After some validation was added, it was extended to include other cases. This serves to patch 6874 to a state where sign off should be possible. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #142 from M. Tompsett --- Testing with Javascript enabled. click plugin icon click Submit Query with nothing filled in. - Was only told about the file location not filled in. I would expected to be told neither were filled in, if I get told this. Selected a file click Submit Query - expected to be told location not filled it. As expected. closed pop up window. click plugin icon click location, but not select a file. - Refreshed blank. A valid behaviour, but confusing since now we have the file location validation. selected a file and chose a location click Submit Query - File uploaded as expected. click close - URL is filled in nicely, as expected. click plugin icon - Would you like to delete window pops up. Okay behaviour. click cancel - windows closes no changes as expected. click plugin icon click delete - told it was deleted successfully, as expected. URL is blanked, as expected. click close repeat steps to get back to delete popup and click delete upload a new file -- after a few cycles of trying to repeat the nothing, browse, root, browse & root selections, I realized I would really like a way to clear the file selected. Though, perhaps this isn't the real need. I did try testing with Javascript off, but it is nearly impossible to work with different browers and scripting off. I was able to trigger your non-javascript red message under IE 10, but not Firefox 24 since the plugin icon refused to popup a window. The problem with it disabled was that then the 'close' doesn't work with javascript disabled, and the URL isn't filled in, but the file is uploaded. On a positive note it continues to behave as if there was no file uploaded, which is what is expected from a blank 856$u field. However, there are table entries and files sitting on the server now. SUGGESTIONS FOR IMPROVEMENTS: - If we validate the location, could we also validate if the filename is set? - Could we add a 'Cancel' which just closes the window to this? Not just a 'Submit Query' button. - Could we change 'Submit Query' to 'Upload File'? - When nothing was selected, got a refresh, which is okay, but strange in light of validation message logic that was added. - Javascript off generates bizarre (but not unstable) state of file uploaded and table pointing to it, but textbox empty, under IE 10. I couldn't even open the new popup windows under FireFox 24. I think if we document this requires Javascript, this is passable. This is getting really close to useable. Thank you for working on this, Julian. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #141 from M. Tompsett --- First patch needs to be rebased. uploaddatabase.pl patch issues. Still going ahead with testing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Julian Maurice changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #140 from Julian Maurice --- Created attachment 21635 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21635&action=edit Bug 6874: Force user to select a directory This patch adds a javascript and a server-side checks Test plan: 1/ Choose a file, leave the radios not selected and submit 2/ You have a javascript alert which prevents form to be submitted 3/ Disable javascript and repeat step 1 4/ Form is submitted but form is redisplayed with an error message telling you to choose a directory. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #139 from M. Tompsett --- Squashed my patches together as per Katrin Fischer's request. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What|Removed |Added Attachment #21543|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 M. Tompsett changed: What|Removed |Added Attachment #21489|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #138 from M. Tompsett --- Created attachment 21546 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21546&action=edit Bug 6874 - kohastructure.sql & jquery.js fix with refocus Two problems were discovered while doing a fresh install of Koha. These problems in the kohastructure.sql file are addressed with this patch. Clicking the plug-in icon should cause the popup window to refocus. This adds the refocus code to the upload.pl file. The path to the jquery.js script was wrong in the upload_delete_file.tt file. Changed [% themelang %] to [% interface %]. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #137 from Katrin Fischer --- As they haven't been signed off you could squash your patches into one - but don't squash them with Julian's. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #136 from M. Tompsett --- Seeing as I can't sign off on my own patches. Could you squash these into a single patch, re-test, and re-post, Julian? Thanks. I'll continue testing once reposted. :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #135 from M. Tompsett --- Created attachment 21543 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21543&action=edit Bug 6874 - Focus and jquery.js fix Clicking the plug in show cause the popup window to refocus. The patch to the jquery.js script was wrong. Changed [% themelang %] to [% interface %]. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 Katrin Fischer changed: What|Removed |Added Version|3.14|master --- Comment #134 from Katrin Fischer --- Reading through the comments of M.Tompset I think this is failed QA. There are issues and further testing should be postponed until those are fixed. Julian, could you please take a look and provide follow-ups where needed? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874
--- Comment #133 from M. Tompsett ---
Comment on attachment 21432
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21432
[SIGNED-OFF] Bug 6874: File upload in MARC
Review of attachment 21432:
-->
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=6874&attachment=21432)
-
::: cataloguing/value_builder/upload.pl
@@ +50,5 @@
> +var id = document.getElementById(index).value;
> +if(id.match(/id=([0-9a-f]+)/)){
> +id = RegExp.\$1;
> +}
> +
> window.open(\"../cataloguing/plugin_launcher.pl?plugin_name=upload.pl&index=\"+index+\"&id=\"+id,
> 'upload', 'width=600,height=400,toolbar=false,scrollbars=no');
var newin=... (this line)
newin.focus();
::: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/upload.tt
@@ +3,5 @@
> +http://www.w3.org/1999/xhtml";>
> +
> +Upload plugin
> +
> +
This should be interface, not themelang.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #132 from M. Tompsett --- initial state: blank, no records in uploaded_files, no files on filesystem. click plug in icon - expected window pops up. click submit query with nothing clicked. - nothing happens, refreshes as expected. click submit query with root selected - nothing happens, refreshes as expected. click browse, but cancel - nothing happens as expected click browse and choose a file - file name appears as expected click submit query with root not selected - "Error: Failed to upload file. See logs for details." current state: file is uploaded, but database is blank. checked error logs jquery.js issue and "Use of uninitialized $dir" error. click Close. delete file from file system. make sure the jquery.js line in upload.tt has interface not themelang click plug in icon - expected window pops up click browse and choose a file - file name appears as expected click submit query with root not selected - "Error: Failed to upload file. See logs for details." ++ FIX REQUESTED: I was expecting to have a refresh of the page with perhaps a "You forgot to select a location" in red, just above/beside/below the "Choose where to upload file". I was also expect to NOT have the file uploaded. This disconnect between the file existing and the record not existing in the database leads to weird problems. ++ click Close. delete file from file system. click plug in icon - expected window pops up click browse and choose a file - file name appears as expected click root - NOTE: I was lazy and didn't create subdirectories in this testing. click submit query - happy it worked kind of message click close - URL is filled in nicely. Not finished fully testing, but I thought I'd mention this problem since I found it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #131 from M. Tompsett --- Set up VM from scratch (include qa-test-tools, git-bz [fishsoup branch], koha origin/master branch) $ git checkout -b bug_6874 origin/master $ git bz apply 6874 $ perl Makefile.PL $ make $ make test $ make install Remember to set up some useful data after you get a working Koha. :) Configure patch - edit koha-conf.xml and make sure to fill in (e.g. /home/mtompset/uploads) - make sure to give that directory correct permissions (e.g. sudo chown www-data.www-data /home/mtompset/uploads) - attach the plug-in to the 856$u subfield (e.g. - log in to staff client - click 'Koha administration' - click 'MARC bibliographic framework' - click 'MARC structure' for a framework - Find the 856 tag - click 'Subfields' - Find the 'u' subfield - click 'Edit' - click 'Other options (choose one)' - select 'upload.pl' in the Plugin drop-down - click 'Save changes') You will want to test in both MARC21 and UNIMARC systems. $ ./koha_perl_deps -m -u $ perldoc C4::Biblio $ perldoc C4::UploadedFiles This will trigger all the functions in C4::UploadedFiles $ prove -v t/db_dependent/UploadedFiles.t Once you have a bilio with 856$u linked up to a file, go to the same biblio on the OPAC. (e.g. http://demo.library.kohasystem.ca/cgi-bin/koha/opac-detail.pl?biblionumber=14206) Then unlink the upload.pl plugin and refresh the OPAC. This latter step is necessary to test a secondary code point under UNIMARC. In the staff client, find a biblio. Add it to your cart. Click the cart at the top of the page. This will test opac-retrieve-file.pl fully: While at the OPAC detail page for the item added - Click the 'Online resources:' URL. 1) It should work. - Delete the file from the filesystem. (e.g. sudo rm /home/mtompset/uploads/*) - Click the 'Online resources:' URL. 2) It should fail. - Open up MySQL and delete the record from the uploaded_files table. 3) It should fail. - Make sure to clear the 856$u entry for that biblio manually and save. opac-detail.pl change is tested just by viewing the details of the biblio with an 856$u link. opac-basket.pl change is tested by adding the item to your cart and clicking the "Cart" button. To test the template files, it is a matter of doing a lot of upload, delete, upload, whatever type tests in the staff client. This has not been fully tested, but there are some issues that I want to test to the point of being able to say what is wrong and how I was expecting it to be handled. I'm beginning to run short of testing time today again. However, I am pretty confident that I have tested the following thoroughly: C4/Biblio.pm C4/Installer/PerlDependencies.pm C4/UploadedFiles.pm basket/basket.pl etc/koha-conf.xml installer/data/mysql/kohastructure.sql installer/data/mysql/updatedatabase.pl opac/opac-basket.pl opac/opac-detail.pl opac/opac-retrieve-file.pl t/db_dependent/UploadedFiles.t Patches with updatedatabase.pl in them need to be rebased. I have already attached an extra patch to correct issues in kohastructure.sql I will continue my testing later of: catalogue/MARCdetail.pl catalogue/detail.pl cataloguing/value_builder/upload.pl koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/upload.tt koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/value_builder/upload_delete_file.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #130 from M. Tompsett --- Created attachment 21489 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21489&action=edit Bug 6874 - Patch kohastructure.sql issues follow up Two problems were discovered while doing a fresh install of Koha. These problems in the kohastructure.sql file are addressed with this patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #129 from M. Tompsett --- Fear not. :) I'll be getting to less programmer oriented testing instructions. The programmer oriented instructions are a matter of proving that the code changes introduced do not cause any problems by triggering all the code points. Now, back to testing... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 6874] File upload in MARC
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6874 --- Comment #128 from Katrin Fischer --- Hi Mark, actually I was more thinking about some 'non-programmer' notes about testing the actual functionality :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
