[Koha-bugs] [Bug 7024] Can't delete other library's messages to the patron with AllowAllMessageDeletion on
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7024 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7024] Can't delete other library's messages to the patron with AllowAllMessageDeletion on
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7024 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added CC||ch...@bigballofwax.co.nz Patch Status|Passed QA |Patch Pushed --- Comment #4 from Chris Cormack ch...@bigballofwax.co.nz 2011-10-15 07:25:20 UTC --- Pushed please test -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7024] Can't delete other library's messages to the patron with AllowAllMessageDeletion on
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7024 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Attachment #5875|0 |1 is obsolete|| --- Comment #2 from Nicole C. Engard neng...@gmail.com 2011-10-14 13:44:26 UTC --- Created attachment 5892 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5892 [SIGNED-OFF] Fix for Bug 7024 - Can't delete other library's messages with AllowAllMessageDeletion on The display of messages to the patron on the checkout screen lacked the same logic controlling messages to other librarians, affecting conditions under which the [Delete] link would be shown. This match makes the two categories consistent with each other: A delete link will be shown if the logged in branch matches the branch where the message was set OR if AllowAllMessageDeletion is turned on. Signed-off-by: Nicole C. Engard neng...@bywatersolutions.com -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7024] Can't delete other library's messages to the patron with AllowAllMessageDeletion on
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7024 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added CC||neng...@gmail.com Patch Status|Needs Signoff |Signed Off -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7024] Can't delete other library's messages to the patron with AllowAllMessageDeletion on
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7024 Ian Walls ian.wa...@bywatersolutions.com changed: What|Removed |Added CC||ian.walls@bywatersolutions. ||com Patch Status|Signed Off |Passed QA --- Comment #3 from Ian Walls ian.wa...@bywatersolutions.com 2011-10-14 13:51:22 UTC --- Template only change, easy to read. While this does introduce a string, it's the same string [Delete] that already exists in conditions of the code, so no new translation is required. Marking as Passed QA -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7024] Can't delete other library's messages to the patron with AllowAllMessageDeletion on
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7024 --- Comment #1 from Owen Leonard oleon...@myacpl.org 2011-10-13 14:12:12 UTC --- Created attachment 5875 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=5875 Proposed fix The display of messages to the patron on the checkout screen lacked the same logic controlling messages to other librarians, affecting conditions under which the [Delete] link would be shown. This match makes the two categories consistent with each other: A delete link will be shown if the logged in branch matches the branch where the message was set OR if AllowAllMessageDeletion is turned on. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7024] Can't delete other library's messages to the patron with AllowAllMessageDeletion on
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7024 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Priority|P5 |PATCH-Sent Patch Status|--- |Needs Signoff -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are the QA Contact for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
