https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Andrew Isherwood changed:
What|Removed |Added
CC|bugzi...@warmlight.co.uk|
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Jonathan Druart changed:
What|Removed |Added
Blocks||25999
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Jonathan Druart changed:
What|Removed |Added
Blocks||23551
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Martin Renvoize changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
David Nind changed:
What|Removed |Added
CC||da...@davidnind.com
Text to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Martin Renvoize changed:
What|Removed |Added
Version(s)||19.05.00
released
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Nick Clemens changed:
What|Removed |Added
CC||n...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Katrin Fischer changed:
What|Removed |Added
Attachment #89051|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Katrin Fischer changed:
What|Removed |Added
Attachment #89052|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Katrin Fischer changed:
What|Removed |Added
Attachment #89044|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Katrin Fischer changed:
What|Removed |Added
Attachment #89046|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Katrin Fischer changed:
What|Removed |Added
Attachment #89049|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Katrin Fischer changed:
What|Removed |Added
Attachment #89047|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Katrin Fischer changed:
What|Removed |Added
Attachment #89048|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Katrin Fischer changed:
What|Removed |Added
Attachment #89050|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Katrin Fischer changed:
What|Removed |Added
Attachment #89045|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Katrin Fischer changed:
What|Removed |Added
Patch complexity|--- |Small patch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
--- Comment #75 from Katrin Fischer ---
I guess I was too sleepy last night - the date field shows up once you actually
click on a hold to renew. I think it might be debatable to show it with
clicking the checkbox, but really no
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Katrin Fischer changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
--- Comment #74 from Katrin Fischer ---
Hi Andrew, it might be my messed up rebase (changes from 21757 caused a
conflict), but now the hold due date never shows up.
Test case:
- Hold renewals allowed
- Renewal limit overrides are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Katrin Fischer changed:
What|Removed |Added
Attachment #89034|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Katrin Fischer changed:
What|Removed |Added
Attachment #89033|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Katrin Fischer changed:
What|Removed |Added
Attachment #89032|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Katrin Fischer changed:
What|Removed |Added
Attachment #89029|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Katrin Fischer changed:
What|Removed |Added
Attachment #89027|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Katrin Fischer changed:
What|Removed |Added
Attachment #89031|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Katrin Fischer changed:
What|Removed |Added
Attachment #89030|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Katrin Fischer changed:
What|Removed |Added
Attachment #89028|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Katrin Fischer changed:
What|Removed |Added
Attachment #89026|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
--- Comment #64 from Liz Rea ---
Created attachment 89034
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89034=edit
Bug 7088: (follow-up) Modify checkbox enabling
As described in comment #50, we need to only
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
--- Comment #63 from Liz Rea ---
Created attachment 89033
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89033=edit
Bug 7088: (follow-up) AllowRenewalLimitOverride fix
This patch causes the click event listener on
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
--- Comment #60 from Liz Rea ---
Created attachment 89030
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89030=edit
Bug 7088: (follow-up) Set syspref default to off
As per item 2 here:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
--- Comment #59 from Liz Rea ---
Created attachment 89029
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89029=edit
Bug 7088: (follow-up) Remove script "type" attribute
As per item 1 here:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
--- Comment #62 from Liz Rea ---
Created attachment 89032
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89032=edit
Bug 7088: (follow-up) Add pref to checkbox
As per commit #29 here:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
--- Comment #61 from Liz Rea ---
Created attachment 89031
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89031=edit
Bug 7088: (follow-up) Default hold checkbox display
As per item 4 here:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Liz Rea changed:
What|Removed |Added
Attachment #85434|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
--- Comment #58 from Liz Rea ---
Created attachment 89028
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89028=edit
Bug 7088: (follow-up) Fix renewal limit bug
There was a bug in that altering the state of the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
--- Comment #57 from Liz Rea ---
Created attachment 89027
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89027=edit
Bug 7088: Allow renew on hold items with due date
This patch adds the ability for items that are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Liz Rea changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are receiving
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
--- Comment #55 from Andrew Isherwood ---
Hi Katrin - I've re-tested and all seems fine to me. I recorded a video just to
make sure you agree: https://nimb.ws/oMZJ7F
--
You are receiving this mail because:
You are watching all bug
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
--- Comment #54 from Katrin Fischer ---
(In reply to Andrew Isherwood from comment #53)
> Hi Katrin - It sounds like you didn't rebuild the CSS. Can you check you
> did, the hold date input box was behaving correctly for me after I
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
--- Comment #53 from Andrew Isherwood ---
Hi Katrin - It sounds like you didn't rebuild the CSS. Can you check you did,
the hold date input box was behaving correctly for me after I performed the
last modifications.
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #52
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
--- Comment #51 from Andrew Isherwood ---
Created attachment 88868
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88868=edit
Bug 7088: (follow-up) Modify checkbox enabling
As described in comment #50, we need to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Andrew Isherwood changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
--- Comment #50 from Katrin Fischer ---
(In reply to Katrin Fischer from comment #49)
> Hi Andrew,
>
> I am very sorry, not sure the last patch is quite right. I think what
> happens now is that either will make 'all' checkboxes
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #49
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Andrew Isherwood changed:
What|Removed |Added
Status|Failed QA |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
--- Comment #47 from Andrew Isherwood ---
Created attachment 88446
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88446=edit
Bug 7088: (follow-up) AllowRenewalLimitOverride fix
This patch causes the click event
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
--- Comment #46 from Andrew Isherwood ---
Sorry, my comment above is incorrect. The click event listener is currently
only created if the AllowRenewalLimitOverride syspref is turned on, I think it
needs adapting so it is created if
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
--- Comment #45 from Andrew Isherwood ---
(In reply to Katrin Fischer from comment #44)
> Hm, maybe the checkbox should now shop up in this case then? Right now the
> checkbox just appears to have no effect - and if I understand you
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
--- Comment #44 from Katrin Fischer ---
(In reply to Andrew Isherwood from comment #43)
> (In reply to Katrin Fischer from comment #42)
> > Hi Andrew,
> >
> > sorry, we are almost there. Most things worked really well (like checkbox
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
--- Comment #43 from Andrew Isherwood ---
(In reply to Katrin Fischer from comment #42)
> Hi Andrew,
>
> sorry, we are almost there. Most things worked really well (like checkbox
> visibility), but found one case that didn't work as
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #42
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Katrin Fischer changed:
What|Removed |Added
QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Katrin Fischer changed:
What|Removed |Added
QA Contact|katrin.fisc...@bsz-bw.de|testo...@bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Martin Renvoize changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
--- Comment #41 from Owen Leonard ---
(In reply to Owen Leonard from comment #40)
> I do have one issue: The new date picker should be hidden initially,
> correct? For me it isn't.
Sorry, my mistake -- I didn't rebuild CSS. I think
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
--- Comment #40 from Owen Leonard ---
What about changing the label to "Due date for on hold items" ?
I think having the second date picker is something which looks to me like
clutter but I assume that those who want to use the
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Liz Rea changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #39 from
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Martin Renvoize changed:
What|Removed |Added
Status|Failed QA |Signed Off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Andrew Isherwood changed:
What|Removed |Added
Attachment #83094|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Andrew Isherwood changed:
What|Removed |Added
Attachment #83093|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
--- Comment #38 from Andrew Isherwood ---
Created attachment 85440
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85440=edit
Bug 7088: (follow-up) Add pref to checkbox
As per commit #29 here:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Andrew Isherwood changed:
What|Removed |Added
Attachment #84510|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Andrew Isherwood changed:
What|Removed |Added
Attachment #83092|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Andrew Isherwood changed:
What|Removed |Added
Attachment #84509|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Andrew Isherwood changed:
What|Removed |Added
Attachment #84850|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
--- Comment #31 from Liz Rea ---
Just a note for testers, if you are testing as I was, with an item that has
multiple items that are not all checked out, you will need
AllowRenewalIfOtherItemsAvailable turned on to see the checkbox.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
--- Comment #30 from Andrew Isherwood ---
Thanks for the feedback regarding the pref Katrin, good spot, I'd completely
missed that, I'll create a patch to sort it out shortly.
As far as the second date selector for on hold due dates
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Andrew Isherwood changed:
What|Removed |Added
Status|Failed QA |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
--- Comment #27 from Andrew Isherwood ---
Created attachment 84850
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84850=edit
Bug 7088: (follow-up) Default hold checkbox display
As per item 4 here:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
--- Comment #26 from Andrew Isherwood ---
Created attachment 84510
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84510=edit
Bug 7088: (follow-up) Set syspref default to off
As per item 2 here:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
--- Comment #25 from Andrew Isherwood ---
Created attachment 84509
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84509=edit
Bug 7088: (follow-up) Remove script "type" attribute
As per item 1 here:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #24
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Katrin Fischer changed:
What|Removed |Added
QA Contact|tomasco...@gmail.com|katrin.fisc...@bsz-bw.de
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Tomás Cohen Arazi changed:
What|Removed |Added
CC||tomasco...@gmail.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Andrew Isherwood changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
PTFS Europe Sandboxes changed:
What|Removed |Added
Attachment #83005|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
PTFS Europe Sandboxes changed:
What|Removed |Added
Attachment #83004|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
PTFS Europe Sandboxes changed:
What|Removed |Added
Attachment #83006|0 |1
is
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Andrew Isherwood changed:
What|Removed |Added
Attachment #79691|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Andrew Isherwood changed:
What|Removed |Added
Attachment #82274|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Andrew Isherwood changed:
What|Removed |Added
Attachment #79690|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Andrew Isherwood changed:
What|Removed |Added
Attachment #79689|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
--- Comment #15 from Andrew Isherwood ---
Created attachment 82274
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82274=edit
Bug 7088: (follow-up) Fix renewal limit bug
There was a bug in that altering the state
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
--- Comment #14 from Andrew Isherwood ---
Test plan:
- Go to the Patron Details page for a patron who has an item on loan that would
fulfil an outstanding loan request.
- TEST: Observe that it is NOT possible to select this item
-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Andrew Isherwood changed:
What|Removed |Added
Attachment #79691|Bug 7088: Compiled CSS |Bug 7088: DO NOT PUSH -
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Fiona Borthwick changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Andrew Isherwood changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
--- Comment #11 from Andrew Isherwood ---
Created attachment 79689
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79689=edit
Bug 7088: Add AllowRenewalOnHoldOverride syspref
Enables the renewal of on hold items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
--- Comment #12 from Andrew Isherwood ---
Created attachment 79690
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79690=edit
Bug 7088: Allow renew on hold items with due date
This patch adds the ability for items
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
--- Comment #13 from Andrew Isherwood ---
Created attachment 79691
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79691=edit
Bug 7088: Compiled CSS
This is never going to merge, but I'm including it as I'm not
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Sally Healey changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Marjorie Barry-Vila marjorie.barry-v...@ccsr.qc.ca changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Nicole C. Engard neng...@gmail.com changed:
What|Removed |Added
Status|REOPENED|NEW
---
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
mathieu saby mathieu.s...@univ-rennes2.fr changed:
What|Removed |Added
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Nicole C. Engard neng...@gmail.com changed:
What|Removed |Added
Status|RESOLVED|REOPENED
1 - 100 of 105 matches
Mail list logo