[Koha-bugs] [Bug 7243] Do not take rentals as fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #34 from Jared Camins-Esakov jcam...@cpbibliography.com --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7243] Do not take rentals as fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Signed Off |Passed QA CC||ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7243] Do not take rentals as fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #13917|0 |1 is obsolete|| --- Comment #33 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 14742 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14742action=edit Bug 7243: Rewording and renaming Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7243] Do not take rentals as fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7243] Do not take rentals as fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #30 from Jared Camins-Esakov jcam...@cpbibliography.com --- Marking as Passed QA as the code has met all the requirements set forth by QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7243] Do not take rentals as fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #13693|0 |1 is obsolete|| --- Comment #29 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 13917 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13917action=edit [SIGNED-OFF] bug_7243: Rewording and renaming Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7243] Do not take rentals as fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7243] Do not take rentals as fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #13666|0 |1 is obsolete|| --- Comment #27 from Srdjan Jankovic srd...@catalyst.net.nz --- Created attachment 13693 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13693action=edit bug_7243: Rewording and renaming -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7243] Do not take rentals as fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Patch complexity|--- |Medium patch --- Comment #28 from Srdjan Jankovic srd...@catalyst.net.nz --- Sorry, substandard grep. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7243] Do not take rentals as fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243 Duncan dun...@catalyst.net.nz changed: What|Removed |Added CC|dun...@catalyst.net.nz | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7243] Do not take rentals as fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #23 from Jared Camins-Esakov jcam...@cpbibliography.com --- Srdjan, Could you please revise the follow-up to change ballance = balance? The other changes in the follow-up look good, though, thanks. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7243] Do not take rentals as fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #13261|0 |1 is obsolete|| --- Comment #24 from Srdjan Jankovic srd...@catalyst.net.nz --- Created attachment 13664 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13664action=edit bug_7243: Rewording and renaming -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7243] Do not take rentals as fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #13664|0 |1 is obsolete|| --- Comment #25 from Srdjan Jankovic srd...@catalyst.net.nz --- Created attachment 13666 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13666action=edit bug_7243: Rewording and renaming -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7243] Do not take rentals as fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7243] Do not take rentals as fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243 --- Comment #26 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Srdjan, can you check your last patch again? I can still spot some 'Ballances' =head2 GetMemberAccountBallance - ($total_ballance, $non_issue_ballance, $other_charges) = GetMemberAccountBallance($borrowernumber); + ($total_balance, $non_issue_balance, $other_charges) = GetMemberAccountBallance($borrowernumber); -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7243] Do not take rentals as fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243 --- Comment #20 from Jared Camins-Esakov jcam...@cpbibliography.com --- Srdjan, Is there any chance we could get a follow-up (not a squashed patch) correcting the spelling errors Marcel identified? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7243] Do not take rentals as fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243 --- Comment #21 from Srdjan Jankovic srd...@catalyst.net.nz --- Created attachment 13261 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13261action=edit bug_7243: Rewording and renaming -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7243] Do not take rentals as fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243 --- Comment #22 from Srdjan Jankovic srd...@catalyst.net.nz --- Sorry about the delay, just slipped. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7243] Do not take rentals as fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Version|master |rel_3_12 --- Comment #19 from Paul Poulain paul.poul...@biblibre.com --- Changes Circulation.pm, Members.pm and circulation. Adds a column to the database I won't push this patch for 3.10 because of the Feature Freeze. Affecting rel_3_12 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7243] Do not take rentals as fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl QA Contact|koha.sek...@gmail.com |m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7243] Do not take rentals as fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Attachment #12454|0 |1 is obsolete|| --- Comment #16 from M. de Rooy m.de.r...@rijksmuseum.nl --- Created attachment 12781 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12781action=edit Signed patch 7243 Rebased for updatedatabase. Automerging of last version went wrong. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7243] Do not take rentals as fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243 --- Comment #17 from M. de Rooy m.de.r...@rijksmuseum.nl --- Preliminary QA comment (result of qa-tools on Member.pm): * C4/Members.pmFAIL pod OK forbidden patterns OK valid FAIL Subroutine GetMemberAccountBallance redefined critic OK Please note that a routine name with the misspelled Ballance (read: Balance) should be corrected too. Such spelling errors (even for a non-native speaker like me) do not increase the trust level of corresponding code :-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7243] Do not take rentals as fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243 M. de Rooy m.de.r...@rijksmuseum.nl changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #18 from M. de Rooy m.de.r...@rijksmuseum.nl --- QA Comment: Code looks good to me. Worked as described during limited testing. The above warning seems to be false; the remark on spelling remains! The enhancement is written such a way that it does not interfere with current behavior. By default rentals and manual invoices are included in the patron balance used when checking out. Only by explicitly changing the prefs behavior changes. (Exception here could be the amounts marked with Res.) I only have a few non-blocker comments. Followups are always welcome! You mention NoissueCharge in some descriptions. Please correct. Looking for noissuescharge will help find the pref much easier ;) Note the additional s in the middle. The description of the prefs could be improved (see below). t/db_dependent/lib/KohaTest/Members.pm looks to me like an unused test module; I once asked the RM already to remove such files Not a blocker, but just mentioning: The names of the prefs and also the names of the variables (returned values) by the new GetMemberAccountBallance are confusing. E.g. What means Do not include .. in No issues .. (double no)? Not intuitively clear. Could you say something like Consider rentals as fines? And explain in one sentence that they do or do not block checkout. And similarly Consider other charges as fines? Note that this is just to stimulate the process of finding more understandable names :) E.g. what is $non_issue_ballance (note double l ..)? Actually you mean here total fines. It would be easier if you say total amount= fines + other charges, and work with such names in code. Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7243] Do not take rentals as fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243 Marc Véron ve...@veron.ch changed: What|Removed |Added Attachment #11943|0 |1 is obsolete|| --- Comment #14 from Marc Véron ve...@veron.ch --- Created attachment 12452 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12452action=edit bug_7243: Be selective when summing up charges for blocking issues Added RentalsInNoissueCharges and ManInvlsInNoissueCharges sys prefs Created C4::Members::cwGetMemberAccountBallance() * A wrapper for GetMemberAccountRecords that gives info on non-issue and other charges * Other charges are: 'Res' 'Rent' if RentalsInNoissueCharges is Mo authorised_values MANUAL_INV if ManInvlsInNoissueCharges is No C4::Members::GetMemberAccountRecords() changes: * Dropped input param $date, it is not used Use split charges in C4::Circulation::CanBookBeIssued() and C4::Members::patronflags(). That way only fines decide whether an item can be issued, and not other non-fine charges -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7243] Do not take rentals as fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243 Marc Véron ve...@veron.ch changed: What|Removed |Added Attachment #12452|0 |1 is obsolete|| --- Comment #15 from Marc Véron ve...@veron.ch --- Created attachment 12454 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12454action=edit [SIGNED-OFF] bug_7243: Be selective when summing up charges for blocking issues Added RentalsInNoissueCharges and ManInvlsInNoissueCharges sys prefs Created C4::Members::cwGetMemberAccountBallance() * A wrapper for GetMemberAccountRecords that gives info on non-issue and other charges * Other charges are: 'Res' 'Rent' if RentalsInNoissueCharges is Mo authorised_values MANUAL_INV if ManInvlsInNoissueCharges is No C4::Members::GetMemberAccountRecords() changes: * Dropped input param $date, it is not used Use split charges in C4::Circulation::CanBookBeIssued() and C4::Members::patronflags(). That way only fines decide whether an item can be issued, and not other non-fine charges Signed-off-by: Marc Veron ve...@veron.ch Rebased (updatedatabase.pl) ManInvInNoissueCharges and RentalsInNoissueCharges ar both included by default (= behaviour as before) All variants tested: Both included, none included, manual invoice included, rentals included. Works fine, blocks/does not blok as appropirate, messages appear as expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7243] Do not take rentals as fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243 Marc Véron ve...@veron.ch changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7243] Do not take rentals as fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #7127|0 |1 is obsolete|| --- Comment #12 from Srdjan Jankovic srd...@catalyst.net.nz --- Created attachment 11943 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11943action=edit bug_7243: Be selective when summing up charges for blocking issues Added RentalsInNoissueCharges and ManInvlsInNoissueCharges sys prefs Created C4::Members::cwGetMemberAccountBallance() * A wrapper for GetMemberAccountRecords that gives info on non-issue and other charges * Other charges are: 'Res' 'Rent' if RentalsInNoissueCharges is Mo authorised_values MANUAL_INV if ManInvlsInNoissueCharges is No C4::Members::GetMemberAccountRecords() changes: * Dropped input param $date, it is not used Use split charges in C4::Circulation::CanBookBeIssued() and C4::Members::patronflags(). That way only fines decide whether an item can be issued, and not other non-fine charges -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7243] Do not take rentals as fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Status|In Discussion |Needs Signoff --- Comment #13 from Srdjan Jankovic srd...@catalyst.net.nz --- A slightly changed approach. Should be very backward compatible. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7243] Do not take rentals as fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added CC||neng...@gmail.com --- Comment #7 from Nicole C. Engard neng...@gmail.com 2012-01-16 14:30:45 UTC --- I agree with Katrin. This is the kind of thing that will cause trouble for those who have been long time Koha users. There should be some way to say this fine is a FINE and this fine is a CHARGE or whatever we need to distinguish between them. Nicole -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7243] Do not take rentals as fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243 Ian Walls ian.wa...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |In Discussion --- Comment #8 from Ian Walls ian.wa...@bywatersolutions.com 2012-01-16 14:43:04 UTC --- Fine types need to be broken out into their own table in the database. Right now, they're hardcoded in the system, and that makes for all kinds of confusion and overlap of features. We need to be able to indicate, on configurable level, which kind of fines count against patron checkout and against patron holds. We should also be able to indicate whether those fines are capped or unlimited (Overdues should stop at $5, let's say, but lost book fees and card renewals fees should accrue infinitely) I'm moving this to the new In Discussion value, since I think we've got more to discuss before a workable change can be made. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7243] Do not take rentals as fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243 --- Comment #9 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-01-16 14:59:31 UTC --- I think we will end up with a total rewrite of accounts if we try to find a real perfect solution for this. In fact this has already been talked about and there is bug 6427 for it. The feature as described here could be helpful for now and get into the next release, while we get the big picture right and a total rewrite done. For example MAN_INV is helpful - but I don't really like to have it as a authorised value. But it shows there is a need for user configurable charges and fines. This bug shows there is a need to distinguish between different fines and charges. For this bug I think the question is about making an enhancement without adding regression or confusion for libraries being used to the current behaviour. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7243] Do not take rentals as fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243 --- Comment #10 from Srdjan Jankovic srd...@catalyst.net.nz 2012-01-16 23:56:08 UTC --- My intention was to make it work as it is now out of the box. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7243] Do not take rentals as fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243 --- Comment #5 from Katrin Fischer katrin.fisc...@bsz-bw.de 2012-01-15 18:45:30 UTC --- Hi Srdjan, thx a lot for taking my comments into account. Reading through this again I wonder if a better solution would be to make the fine types that can block checkouts a list? We have some system preferences now that take | or comma separated lists of values. It would allow for more flexibility and it would work with 1 additional system preference instead of 2. I am really not sure here and perhaps your solution is what others think is the best way to do it. Some more opinions about this would be good. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7243] Do not take rentals as fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243 --- Comment #6 from Srdjan Jankovic srd...@catalyst.net.nz 2012-01-15 23:42:15 UTC --- I have no personal preferences in terms how we store sysprefs. Two sysprefs were suggested, and I went with that. I'm still kind of learning how community operates. Having one syspref with comma or | delimited values (as I saw it elsewhere) makes sense, but some people may find it confusing. From my point of view it is trivial how we store it, so if you think it's better to have one syspref I can change it. One syspref has following advantages: * it scales better, ie if a new charge code needs to be added * MAN_INV charges can be fine grained Disadvantage is that is maybe harder to understand/use. Your call. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7243] Do not take rentals as fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Attachment #6709|0 |1 is obsolete|| --- Comment #4 from Srdjan Jankovic srd...@catalyst.net.nz 2012-01-13 07:13:03 UTC --- Created attachment 7127 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7127 patch I have introduced RentalsInNoissueCharges and ManInvInNoissueCharges sys prefs to fine control issue blocking charge. Those are set to Yes initially to have current behaviour. 'Res' charges are not in the fines total unconditionally. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7243] Do not take rentals as fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer katrin.fisc...@bsz-bw.de 2011-12-31 07:58:01 UTC --- I am not sure I agree with this change for several reasons: I am not sure MAN_INV should be included in the list of fines that don't block. I am not sure if this change makes sense, as the MAN_INV values can be used for a lot of different things and libraries might want to block patrons from checkout here. Having 'Res' not block checkout is also a change to current behaviour, although I agree that it might make sense. I think this needs a system preference. Perhaps a third option for 'issuinginprocess' that makes rental fees never block circ. This way we don't change the behaviour of this for all libraries, which is something that libraries may not want. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7243] Do not take rentals as fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243 Duncan dun...@catalyst.net.nz changed: What|Removed |Added Attachment #6335|0 |1 is obsolete|| --- Comment #2 from Duncan dun...@catalyst.net.nz 2011-12-11 21:35:53 UTC --- Created attachment 6709 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6709 Tested patch, correctly solves the problem, requires further sign off. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7243] Do not take rentals as fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243 Duncan dun...@catalyst.net.nz changed: What|Removed |Added CC||dun...@catalyst.net.nz -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7243] Do not take rentals as fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Status|NEW |ASSIGNED AssignedTo|kyle.m.h...@gmail.com |srd...@catalyst.net.nz --- Comment #1 from Srdjan Jankovic srd...@catalyst.net.nz 2011-11-18 08:59:35 UTC --- Created attachment 6335 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=6335 patch This proved to be a bit wider then originally expected, changed patronflags() not to raise CHARGES if owing amount is not fines. I've also noticed some other possible issues, but will raise them in a separate bug request -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7243] Do not take rentals as fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Priority|P5 - low|PATCH-Sent Patch Status|--- |Needs Signoff Change sponsored?|--- |Sponsored -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7243] Do not take rentals as fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7243 Srdjan Jankovic srd...@catalyst.net.nz changed: What|Removed |Added Blocks||7244 -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
