[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||28590


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=28590
[Bug 28590] get_shelves_userenv and set_shelves_userenv not used
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

Marcel de Rooy  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=18228

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310
Bug 7310 depends on bug 5763, which changed state.

Bug 5763 Summary: Add users private list management functionality for 
administrators
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5763

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |DUPLICATE

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=13417

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310
Bug 7310 depends on bug 5901, which changed state.

Bug 5901 Summary: Make virtualshelves permissions more granular
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5901

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |WONTFIX

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=10679

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

Bug 7310 depends on bug 5488, which changed state.

Bug 5488 Summary: Restrict the type of list which can be created by non-staff 
users
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5488

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

Bug 7310 depends on bug 6632, which changed state.

Bug 6632 Summary: [security] XXS on list name (on admin part)
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6632

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

Bug 7310 depends on bug 2676, which changed state.

Bug 2676 Summary: When adding an item to a list from opac-detail.pl, the 'open' 
list type is omitted
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2676

   What|Removed |Added

 Status|NEW |RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=9032

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

--- Comment #91 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Actually, the work for this report is not finished yet.
My next step is a proposed patch for Share a list. The foundation is already
there in code and tables.
Will open a new report for that step.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Pushed to Master|ASSIGNED

--- Comment #89 from Chris Cormack ch...@bigballofwax.co.nz ---
We need the ability to add items to others lists now, because currently that is
missing.

ie if you look at the screenshot, the options to share do not exist.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|ASSIGNED|RESOLVED
 Resolution|--- |FIXED

--- Comment #90 from Chris Cormack ch...@bigballofwax.co.nz ---
Ignore that :) It is working as it should

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

--- Comment #85 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 8467
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8467action=edit
Screen shot for new permissions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

--- Comment #86 from M. de Rooy m.de.r...@rijksmuseum.nl ---
This screen shot is somewhat dubious: an owner is always allowed to add but not
to delete. Just creating confusion..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   Attachment #8467|0   |1
is obsolete||

--- Comment #87 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 8519
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8519action=edit
Screenshot for new permissions

This reflects reality much better ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

--- Comment #88 from Paul Poulain paul.poul...@biblibre.com ---
I just pushed a small follow-up : it was written lt instead of  in DBrev
number comparison, that made updatedatabase not working well.

Ppl running master should apply manually the following SQL:
ALTER TABLE virtualshelves MODIFY COLUMN owner int;
UPDATE virtualshelves vi LEFT JOIN borrowers bo ON bo.borrowernumber=vi.owner
SET vi.owner=NULL where bo.borrowernumber IS NULL;
DELETE FROM virtualshelves WHERE owner IS NULL and category=1;
ALTER TABLE virtualshelves ADD COLUMN allow_add tinyint(1) DEFAULT 0, ADD
COLUMN allow_delete_own tinyint(1) DEFAULT 1, ADD COLUMN allow_delete_other
tinyint(1) DEFAULT 0, ADD CONSTRAINT `virtualshelves_ibfk_1` FOREIGN KEY
(`owner`) REFERENCES `borrowers` (`borrowernumber`) ON DELETE SET NULL ON
UPDATE SET NULL;
UPDATE virtualshelves SET allow_add=0, allow_delete_own=1, allow_delete_other=0
WHERE category=1;
UPDATE virtualshelves SET allow_add=0, allow_delete_own=1, allow_delete_other=0
WHERE category=2;
UPDATE virtualshelves SET allow_add=1, allow_delete_own=1, allow_delete_other=1
WHERE category=3;
UPDATE virtualshelves SET category=2 WHERE category=3;

ALTER TABLE virtualshelfcontents ADD COLUMN borrowernumber int, ADD CONSTRAINT
`shelfcontents_ibfk_3` FOREIGN KEY (`borrowernumber`) REFERENCES `borrowers`
(`borrowernumber`) ON DELETE SET NULL ON UPDATE SET NULL;
UPDATE virtualshelfcontents co LEFT JOIN virtualshelves sh USING (shelfnumber)
SET co.borrowernumber=sh.owner;

CREATE TABLE virtualshelfshares
(id int AUTO_INCREMENT PRIMARY KEY, shelfnumber int NOT NULL,
borrowernumber int, invitekey varchar(10), sharedate datetime,
CONSTRAINT `virtualshelfshares_ibfk_1` FOREIGN KEY (`shelfnumber`)
REFERENCES `virtualshelves` (`shelfnumber`) ON DELETE CASCADE ON UPDATE
CASCADE,
CONSTRAINT `virtualshelfshares_ibfk_2` FOREIGN KEY (`borrowernumber`)
REFERENCES `borrowers` (`borrowernumber`) ON DELETE SET NULL ON UPDATE SET
NULL) ENGINE=InnoDB DEFAULT CHARSET=utf8;

INSERT INTO systempreferences (variable,value,explanation,options,type)
VALUES('OpacAllowPublicListCreation',1,'If set, allows opac users to create
public lists',NULL,'YesNo');
INSERT INTO systempreferences (variable,value,explanation,options,type)
VALUES('OpacAllowSharingPrivateLists',0,'If set, allows opac users to share
private lists with other patrons',NULL,'YesNo');

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Passed QA   |Patch doesn't apply

--- Comment #76 from Paul Poulain paul.poul...@biblibre.com ---
I'm really sorry Marcel, but patch 4 [main part] does not apply anymore.
There's a large conflict on Auth.pm that I can't solve easily. Could you rebase
please ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

--- Comment #77 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Will rebase again.. What is the easiest way to get the patches again in the
right order without git bz?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

--- Comment #78 from Paul Poulain paul.poul...@biblibre.com ---
(In reply to comment #77)
 Will rebase again.. What is the easiest way to get the patches again in the
 right order without git bz?

I don't think there's an easy option. Why don't you want to go the git-bz way ?

Otherwise, as the patch already passed QA, i can take care of ordering the
patches correctly when pushing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

--- Comment #79 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Will install git-bz on a new dev server soon.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   Attachment #8259|0   |1
is obsolete||

--- Comment #80 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 8410
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8410action=edit
Part 1: DB revision for Improving list permissions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   Attachment #8410|0   |1
   is patch||
   Attachment #8410|Part 1: DB revision for |Bug 7310 Part 1: DB
description|Improving list permissions  |revision for Improving list
   ||permissions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   Attachment #8262|0   |1
is obsolete||

--- Comment #81 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 8411
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8411action=edit
Bug 7310 Part 4: Code changes [main part]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   Attachment #8265|0   |1
is obsolete||

--- Comment #82 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 8412
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8412action=edit
Bug 7310 Part 7: followup for sysprefs

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   Attachment #8412|0   |1
   is patch||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Patch doesn't apply |Passed QA

--- Comment #83 from M. de Rooy m.de.r...@rijksmuseum.nl ---
That's it for now. Hopefully the rebased patches will not be sleeping too long
on the queue again. Have tested again and discovered another minor issue that
already exists in master now that this report resolves on the staff side, but
not on the opac side. Will not mention it here for simplicity. But will send
another followup for it soon.
Back to Passed QA.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Blocks||7783

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
Version|master  |rel_3_8
   Severity|normal  |enhancement

--- Comment #84 from Paul Poulain paul.poul...@biblibre.com ---
seeing the size of those patches, it's hard to guarantee all coding guidelines
are OK.
I tested it for a while, and could not find any problem.

Pushing before Feature Freeze, guys, we have one month to find a problem if
there's one !

(switched to enhancement and versionned to 3.8, it's a bad idea to have that
in 3.6 for now)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

--- Comment #64 from M. de Rooy m.de.r...@rijksmuseum.nl ---
(In reply to comment #63)
 I haven't spotted
 anything problematic yet, but I'm getting a little tired and pressed for
 time, so I'll need to pick this up tomorrow.  I just wanted to note that
 this is in progress, and should have a final pass/fail shortly.
Great! Thanks for your QA. Look forward to final pass ;)

 Would folks prefer that, if and when the patches pass QA, I reapply them to
 the report in the correct order, or squash them into a single patch, and
 obsolete the rest?
Would not squash them. If this report just keeps pending a few days longer in
the next queue, rebasing a squashed coding changes and indentation could be a
nightmare, just to mention the worst example.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

Ian Walls koha.sek...@gmail.com changed:

   What|Removed |Added

   Attachment #8007|0   |1
is obsolete||

--- Comment #66 from Ian Walls koha.sek...@gmail.com ---
Created attachment 8259
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8259action=edit
Bug 7310 Part 1: DB revision for Improving list permissions

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

Ian Walls koha.sek...@gmail.com changed:

   What|Removed |Added

   Attachment #7875|0   |1
is obsolete||

--- Comment #67 from Ian Walls koha.sek...@gmail.com ---
Created attachment 8260
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8260action=edit
Bug 7310 Part 2: Improving Lists permissions new prefs

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

Ian Walls koha.sek...@gmail.com changed:

   What|Removed |Added

   Attachment #7926|0   |1
is obsolete||

--- Comment #68 from Ian Walls koha.sek...@gmail.com ---
Created attachment 8261
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8261action=edit
Bug 7310 Part 3: improving list permissions changing Koha SQL structure

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

Ian Walls koha.sek...@gmail.com changed:

   What|Removed |Added

   Attachment #8008|0   |1
is obsolete||

--- Comment #69 from Ian Walls koha.sek...@gmail.com ---
Created attachment 8262
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8262action=edit
Bug 7310 Part 4: Code changes [main part]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

Ian Walls koha.sek...@gmail.com changed:

   What|Removed |Added

   Attachment #7878|0   |1
is obsolete||

--- Comment #71 from Ian Walls koha.sek...@gmail.com ---
Created attachment 8264
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8264action=edit
Bug 7310 Part 6: VirtualShelves unit test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

Ian Walls koha.sek...@gmail.com changed:

   What|Removed |Added

   Attachment #7953|0   |1
is obsolete||

--- Comment #72 from Ian Walls koha.sek...@gmail.com ---
Created attachment 8265
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8265action=edit
Bug 7310 Part 7: followup for sysprefs

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

Ian Walls koha.sek...@gmail.com changed:

   What|Removed |Added

   Attachment #8009|0   |1
is obsolete||

--- Comment #73 from Ian Walls koha.sek...@gmail.com ---
Created attachment 8266
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8266action=edit
Bug 7310 Part 8: Indentation cleanup

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

Ian Walls koha.sek...@gmail.com changed:

   What|Removed |Added

   Attachment #7879|0   |1
is obsolete||

--- Comment #74 from Ian Walls koha.sek...@gmail.com ---
Created attachment 8267
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8267action=edit
Bug 7310 Part 9: followup for warnings in nothingdeleted and somedeleted in
staff client

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

--- Comment #75 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Will send a followup under a new report number in order to not disturb further
processsing of this set of patches.
See bug 7732.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Blocks||7732

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   Attachment #7942|0   |1
is obsolete||

--- Comment #57 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 8006
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8006action=edit
Bug 7310: DB revision for Improving list permissions

Rebased.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   Attachment #8006|0   |1
   is patch||
   Attachment #8006|0   |1
is obsolete||

--- Comment #58 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Comment on attachment 8006
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8006
Bug 7310: DB revision for Improving list permissions

Wrong file

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

--- Comment #59 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 8007
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8007action=edit
Bug 7310: DB revision for Improving list permissions

Rebased

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   Attachment #7940|0   |1
is obsolete||

--- Comment #60 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 8008
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8008action=edit
Bug 7310: Code changes for Improving list permissions

Rebased for 4912 push

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   Attachment #7910|0   |1
is obsolete||

--- Comment #61 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 8009
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8009action=edit
Bug 7310 Indentation followup replacing leading tabs with spaces

Rebased

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

--- Comment #62 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Ongoing effort to keep this up-to-date. Note that order of patches is relevant.
I just applied in this order:

Applying: Bug 7310: DB revision for Improving list permissions
Applying: Bug 7310: Improving lists permissions -- New prefs
Applying: Bug 7310: Improving list permissions: Changing Koha SQL structure
Applying: Bug 7310: Code changes for Improving list permissions
Applying: Bug 7310: Improving list permissions: Deleting patron
Applying: Bug 7310: Updated VirtualShelves unit test
Applying: Bug 7310: Followup for sysprefs.sql
Applying: Bug 7310 Indentation followup replacing leading tabs with spaces
Applying: Bug 7310 Followup: Warnings for nothingdeleted and somedeleted for
staff client.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   Attachment #7925|0   |1
is obsolete||

--- Comment #51 from M. de Rooy m.de.r...@rijksmuseum.nl 2012-02-29 12:39:12 
UTC ---
Created attachment 7939
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7939
Bug 7310: DB revision for Improving list permissions

Rebased again.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   Attachment #7876|0   |1
is obsolete||

--- Comment #52 from M. de Rooy m.de.r...@rijksmuseum.nl 2012-02-29 12:41:27 
UTC ---
Created attachment 7940
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7940
Bug 7310: Code changes for Improving list permissions

Automerged version.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #53 from M. de Rooy m.de.r...@rijksmuseum.nl 2012-02-29 12:44:16 
UTC ---
This should do it for now. Further documentation followups coming later. Note
that the Deleting patron patch should follow the Code changes patch.
Indentation patch should be the last one.

Setting status back to Signed off now.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

--- Comment #54 from M. de Rooy m.de.r...@rijksmuseum.nl 2012-02-29 13:20:39 
UTC ---
This report is driving me crazy: I will send another dbrev update in order to
make sure that the new FK will not block updating. If there are lists with a
deleted owner, they should be set to null before adding the constraint.
Updated patch dbrev forthcoming..

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   Attachment #7939|0   |1
is obsolete||

--- Comment #55 from M. de Rooy m.de.r...@rijksmuseum.nl 2012-02-29 14:24:21 
UTC ---
Created attachment 7942
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7942
Bug 7310: DB revision for Improving list permissions

Small adjustment to make sure that adding the FK constraint is not frustrated
by existing records in virtualshelves with invalid owner. Tested.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

--- Comment #56 from M. de Rooy m.de.r...@rijksmuseum.nl 2012-03-01 07:31:18 
UTC ---
Created attachment 7953
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7953
Bug 7310: Followup for sysprefs.sql

Resolving the omission to add the prefs to sysprefs.sql. *Sorry*

Signed-off-by: Marcel de Rooy m.de.r...@rijksmuseum.nl
Tested it separately by running the sql file on a new db. 324 entries now..

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

--- Comment #45 from M. de Rooy m.de.r...@rijksmuseum.nl 2012-02-28 14:27:22 
UTC ---
Delayed additional comment on point 7 from Paul: I got your point now. I will
add a FK to owner in virtualshelves without compromising the whole retaining
public lists-stuff as described. Please wait one moment ..

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

--- Comment #46 from M. de Rooy m.de.r...@rijksmuseum.nl 2012-02-28 16:10:02 
UTC ---
Created attachment 7925
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7925
Bug 7310: DB revision for Improving list permissions

Feb 28, 2012: Added three FK constraints for QA (for owner/borrowernumber in
virtualshelves, shelfcontents and shelfshares). Tested update again.
Also removed the note about public lists, made obsolete by earlier adjustments
for comments from Owen.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   Attachment #7873|0   |1
is obsolete||

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   Attachment #7874|0   |1
is obsolete||

--- Comment #47 from M. de Rooy m.de.r...@rijksmuseum.nl 2012-02-28 16:11:56 
UTC ---
Created attachment 7926
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7926
Bug 7310: Improving list permissions: Changing Koha SQL structure

Feb 28, 2012: Added three FK constraints for QA (for owner/borrowernumber in
virtualshelves, shelfcontents and shelfshares). Resolved syntax error with a
comment. Tested the install.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   Attachment #7926|0   |1
   is patch||

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

--- Comment #48 from M. de Rooy m.de.r...@rijksmuseum.nl 2012-02-28 17:05:51 
UTC ---
While testing it again, now stumble over:
[Tue Feb 28 17:54:43 2012] [error] [client 82.173.53.17] [Tue Feb 28 17:54:43
2012] addbybiblionumber.pl: DBD::mysql::st execute failed: Cannot add or update
a child row: a foreign key constraint fails (`kohatest/virtualshelfcontents`,
CONSTRAINT `shelfcontents_ibfk_2` FOREIGN KEY (`biblionumber`) REFERENCES
`biblio` (`biblionumber`) ON DELETE CASCADE ON UPDATE CASCADE) at
/usr/share/koha/testclone/C4/VirtualShelves.pm line 366., referer:
http://libdevelop.rijksmuseum.nl:8009/cgi-bin/koha/virtualshelves/addbybiblionumber.pl?newshelf=1biblionumber=198700biblionumber=120300biblionumber=120500

Will check ASAP..

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

--- Comment #49 from M. de Rooy m.de.r...@rijksmuseum.nl 2012-02-28 17:12:33 
UTC ---
(In reply to comment #48)
 While testing it again, now stumble over:
 [Tue Feb 28 17:54:43 2012] [error] [client 82.173.53.17] [Tue Feb 28 17:54:43
 2012] addbybiblionumber.pl: DBD::mysql::st execute failed: Cannot add or 
 update
 a child row: a foreign key constraint fails (`kohatest/virtualshelfcontents`,
 CONSTRAINT `shelfcontents_ibfk_2` FOREIGN KEY (`biblionumber`) REFERENCES
 `biblio` (`biblionumber`) ON DELETE CASCADE ON UPDATE CASCADE) at
 /usr/share/koha/testclone/C4/VirtualShelves.pm line 366., referer:
 http://libdevelop.rijksmuseum.nl:8009/cgi-bin/koha/virtualshelves/addbybiblionumber.pl?newshelf=1biblionumber=198700biblionumber=120300biblionumber=120500
 
 Will check ASAP..

Well. Just confirms that the FK works. I was adding a biblio from an old Zebra
index that did not exist anymore ;)

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

--- Comment #50 from M. de Rooy m.de.r...@rijksmuseum.nl 2012-02-28 17:19:35 
UTC ---
Still checking another issue, please keep this report on HOLD now.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA
 CC||paul.poul...@biblibre.com

--- Comment #38 from Paul Poulain paul.poul...@biblibre.com 2012-02-27 
16:51:35 UTC ---
QA comment:
1- am I wrong if I say that the most important new features are not here yet
(share a list, temporary share via a temporary key)
2- Am I wrong if I say that the user can't (at least for instance) set
allow_add, allow_delete_own, allow_delete_other themselves
3- you have added many sub to opac-addbybiblionumber.pl, without any pod doc,
please add at least a few lines for each of them
4- please confirm those sub in opac-addbybiblionumber.pl are not worth being
moved to C4::
5- there are many tab, please change for 4 spaces (PERL6
http://wiki.koha-community.org/wiki/Coding_Guidelines)
6- the name GetSomeShelfNames sound strange and unusal. What does the Some
mean ? shouldn't it be GetShelfNamesBy... instead ?
7- borrower deletion: I agree that deletion of a borrower should not result
always in shelved deletion. BUT there should be fallback with FK, just in case
borrowers are deleted from mySQL, not through Koha. I mean: the
HandleDelBorrower should not prevent us from having a FK


* do you have a timeline for #1 and #2 ?
* marking failed QA for 3 and 5
* please answer to 4, 6 and 7, maybe with a follow-up, maybe with a comment

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

--- Comment #39 from M. de Rooy m.de.r...@rijksmuseum.nl 2012-02-27 18:27:35 
UTC ---
(In reply to comment #38)
 1- am I wrong if I say that the most important new features are not here yet
 (share a list, temporary share via a temporary key)
 2- Am I wrong if I say that the user can't (at least for instance) set
 allow_add, allow_delete_own, allow_delete_other themselves
On the wiki I did present a gradual implementation of these features. First
laying the foundation and staying close to current functionality, while at the
same time already resolving a lot(!) of minor issues with lists.
I do not have an exact timeline because I do not know when (and even if) these
patches are coming through. As soon as they are, the first followup will deal
with exposing the permissions. This will be in one or two weeks. The share
feature will follow after that (perhaps one or two months).

 3- you have added many sub to opac-addbybiblionumber.pl, without any pod doc,
 please add at least a few lines for each of them
 4- please confirm those sub in opac-addbybiblionumber.pl are not worth being
 moved to C4::
The code in both scripts was very hard to read and has been refactored with
this patch. IMO they are just local subroutines, no candidates for a module. In
that view I did not include pod doc. If you think that it would be beneficial,
I will make a follow-up for that.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

--- Comment #40 from M. de Rooy m.de.r...@rijksmuseum.nl 2012-02-27 18:45:08 
UTC ---
(In reply to comment #38)
 5- there are many tab, please change for 4 spaces (PERL6
 http://wiki.koha-community.org/wiki/Coding_Guidelines)
Oops, this is not my greatest specialty. Can we run something generic on the
files where many lines were changed? Perhaps also in a specific commit that
only does that kind of thing? 

 6- the name GetSomeShelfNames sound strange and unusal. What does the Some
 mean ? shouldn't it be GetShelfNamesBy... instead ?
I called it Some, because that is what the routine does (and what Koha already
did). The routine does not get all columns, but only returns names and numbers
for some shelves (10 to 20). But I would be happy to send a followup for a
better name, agreeing that it sounds unusual. Do you have a suggestion? 

 7- borrower deletion: I agree that deletion of a borrower should not result
 always in shelved deletion. BUT there should be fallback with FK, just in case
 borrowers are deleted from mySQL, not through Koha. I mean: the
 HandleDelBorrower should not prevent us from having a FK
There are already some FKs here with a cascaded delete and that works fine. If
you delete e.g. a shelf, all biblios and all shares will be automatically
purged that way. (I discovered now that the lines deleting them in
HandleDelBorrower are not needed.) The advantage of not having the cascade on
owner in virtualshelves itself helps us to retain public and shared lists. The
routine purges unused shared lists. A followup in the form of an admin job
could purge public lists without owner, if a library really wants to do so.
In summary, I think that the situation improves compared to current Koha.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz

--- Comment #41 from Chris Cormack ch...@bigballofwax.co.nz 2012-02-27 
19:19:33 UTC ---
(In reply to comment #40)
 (In reply to comment #38)
  5- there are many tab, please change for 4 spaces (PERL6
  http://wiki.koha-community.org/wiki/Coding_Guidelines)
 Oops, this is not my greatest specialty. Can we run something generic on the
 files where many lines were changed? Perhaps also in a specific commit that
 only does that kind of thing? 
 
Do you use vim? If so check out the vim page on the koha wiki you can set it up
so you can select text and perltidy it that would fix this.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

--- Comment #42 from M. de Rooy m.de.r...@rijksmuseum.nl 2012-02-27 20:43:18 
UTC ---
Created attachment 7909
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7909
Bug 7310: Indentation followup

Thanks Chris. Will look into it.
This patch was created with mainly this line:
 while(s/^(\s*)\t/$1$spc/) {}
Did the four files with the most changes.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

--- Comment #43 from M. de Rooy m.de.r...@rijksmuseum.nl 2012-02-27 20:44:01 
UTC ---
Wrong version. Please wait..

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   Attachment #7909|0   |1
is obsolete||

--- Comment #44 from M. de Rooy m.de.r...@rijksmuseum.nl 2012-02-27 20:45:58 
UTC ---
Created attachment 7910
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7910
Bug 7310: Indentation followup

Second try :-)

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

--- Comment #37 from M. de Rooy m.de.r...@rijksmuseum.nl 2012-02-27 07:51:06 
UTC ---
jcamins: thx for testing and signing off!

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

   Attachment #7680|0   |1
is obsolete||
   Attachment #7769|0   |1
is obsolete||
   Attachment #7819|0   |1
is obsolete||
   Attachment #7820|0   |1
is obsolete||
   Attachment #7824|0   |1
is obsolete||
   Attachment #7825|0   |1
is obsolete||
   Attachment #7828|0   |1
is obsolete||

--- Comment #30 from Jared Camins-Esakov jcam...@cpbibliography.com 
2012-02-25 21:34:02 UTC ---
Created attachment 7873
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7873
Bug 7310: DB revision for Improving list permissions

DB revision for improving list permissions.
Adds new table virtualshelfshares for maintaining shared private lists.
Adds three columns to virtualshelves for permissions per list.
Adds column borrowernumber to virtualshelfcontents.

Feb 16, 2012: Rebased.

Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

--- Comment #31 from Jared Camins-Esakov jcam...@cpbibliography.com 
2012-02-25 21:34:21 UTC ---
Created attachment 7874
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7874
Bug 7310: Improving list permissions: Changing Koha SQL structure

Modifying Koha structure for improving list permissions.
Adds new table virtualshelfshares for maintaining shared private lists.
Adds three columns to virtualshelves for permissions per list.
Adds column borrowernumber to virtualshelfcontents.

Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

--- Comment #32 from Jared Camins-Esakov jcam...@cpbibliography.com 
2012-02-25 21:34:35 UTC ---
Created attachment 7875
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7875
Bug 7310: Improving lists permissions -- New prefs

Adds two new preferences to OPAC/Policy tab.

Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

--- Comment #33 from Jared Camins-Esakov jcam...@cpbibliography.com 
2012-02-25 21:35:13 UTC ---
Created attachment 7876
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7876
Bug 7310: Code changes for Improving list permissions

This lays the foundation for further changes for report 7310.
Implements following points from the wiki page List permissions:
1) Preference that controls if users may create public lists in opac.
2) New add/delete own/delete other permissions per list.

Code has been changed (in some cases refactored). New permissions are not yet
visible; with this patch current functionality is kept as much as possible
while resolving several issues, improving permissions and extending the code
for further developments (using the new permissions and sharing lists).

Feb 23, 2012 (revision): Changed defaults for new lists. Could also remove
routine GetRecentShelves by using GetSomeShelfNames in catalogue/search.pl just
as opac-search.pl already did. (More consistent.)

Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

--- Comment #34 from Jared Camins-Esakov jcam...@cpbibliography.com 
2012-02-25 21:35:25 UTC ---
Created attachment 7877
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7877
Bug 7310: Improving list permissions: Deleting patron

Implements following points from the wiki page List permissions:
5) Delete or move list information when deleting a patron.

Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

--- Comment #35 from Jared Camins-Esakov jcam...@cpbibliography.com 
2012-02-25 21:35:40 UTC ---
Created attachment 7878
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7878
Bug 7310: Updated VirtualShelves unit test

Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

--- Comment #36 from Jared Camins-Esakov jcam...@cpbibliography.com 
2012-02-25 21:35:54 UTC ---
Created attachment 7879
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7879
Bug 7310 Followup: Warnings for nothingdeleted and somedeleted for staff
client.

Test this patch by trying to delete items from a public list that someone else
created (so you do not have sufficient permissions). Check the warning.

Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

Jared Camins-Esakov jcam...@cpbibliography.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||jcam...@cpbibliography.com

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

--- Comment #18 from M. de Rooy m.de.r...@rijksmuseum.nl 2012-02-23 09:25:38 
UTC ---
(In reply to comment #17)
 I think it is contrary to current expectations for others to be able to add to
 a public list.
Will send an adjusted patch.

 I do not find this to be the case in current master. I see no option for
 deleting items from a public list when I'm logged in as someone other than the
 list creator.
Tested in current master: Let user 1 create a public list and add an item.
Login as user 2. Goto opac-shelves by clicking Lists button. Select the newly
created public list. You can select the item and click Remove selected items.
List is empty.

 Why would it not be a must to do that? If the list has no owner there's no way
 to delete it, correct?
I mean this: As long as you do not have a need to rename or delete, the public
list can remain as it is. (There is no burden for the librarians to immediately
examine public lists without owner.) Depending on the permissions set, people
can even add or delete items. I agree that if you want to delete it, you must
get ownership. Will be handled in a followup.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   Attachment #7819|0   |1
   is patch||

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   Attachment #7679|0   |1
is obsolete||

--- Comment #20 from M. de Rooy m.de.r...@rijksmuseum.nl 2012-02-23 09:56:42 
UTC ---
Created attachment 7820
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7820
[PATCH 2][REVISED]Changing Koha SQL structure

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

--- Comment #21 from M. de Rooy m.de.r...@rijksmuseum.nl 2012-02-23 09:58:15 
UTC ---
Created attachment 7821
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7821
[PATCH 4][REVISED]Code revisions for improving permissions

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   Attachment #7681|0   |1
is obsolete||

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

--- Comment #22 from M. de Rooy m.de.r...@rijksmuseum.nl 2012-02-23 11:15:51 
UTC ---
(In reply to comment #15)
 Should deleting the patron delete the list? I see that
 after deleting patron user 1's private shelves are still in the database.
Owen, maybe you did not apply patch 5 (deleting patron) when you tested this
one? Happened to me now too when testing patch 4 again..

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   Attachment #7821|0   |1
is obsolete||

--- Comment #23 from M. de Rooy m.de.r...@rijksmuseum.nl 2012-02-23 11:27:57 
UTC ---
Created attachment 7823
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7823
[PATCH 4][REVISED]Code revisions for improving permissions

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

--- Comment #24 from M. de Rooy m.de.r...@rijksmuseum.nl 2012-02-23 12:04:33 
UTC ---
Please wait: Found something. Another version of patch 4 is coming..

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   Attachment #7823|0   |1
is obsolete||

--- Comment #25 from M. de Rooy m.de.r...@rijksmuseum.nl 2012-02-23 13:20:02 
UTC ---
Created attachment 7824
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7824
[PATCH 4][REVISED]Code revisions for improving permissions

Changed defaults for new lists. Could also remove routine GetRecentShelves by
using GetSomeShelfNames in catalogue/search.pl just as opac-search.pl already
did. (More consistent.)

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

--- Comment #26 from M. de Rooy m.de.r...@rijksmuseum.nl 2012-02-23 13:21:30 
UTC ---
Created attachment 7825
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7825
[PATCH 5]Deleting patron

Rebased.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

   Attachment #7682|0   |1
is obsolete||

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

--- Comment #27 from M. de Rooy m.de.r...@rijksmuseum.nl 2012-02-23 13:24:38 
UTC ---
ADJUSTED TEST PLAN (also on wiki):

Login with user 2 in staff. Create user 1 for opac (to be deleted at the end).
Enable OpacAllowPublicListCreation.

Login with user 1 in opac. Add a private list V1 via shelves screen. Add a
private list V2 via search results, Add to combo. Add some items to both lists.
Add a public list P1 via shelves, P2 via search results (Save to another list).
Add some items.

Login with user 2 in staff. Goto Lists. Check P1 and P2. Try to rename or
delete (should be impossible). Add some items via catalog detail and search
results (should NOT be possible). Add private V3 via shelves, private V4 via
search results, public P3. Add some items.

Login with user 1 in opac. Try to rename or delete P3 (should not be possible).
Add items to P3 (should NOT be possible). Delete list V1.

Login with user 2 in staff. Delete list P3. Try to delete all items from P2
(should not be possible). Delete patron user 1. Check if you still have P1 and
P2. Check items on P2.

Login with user 2 in opac. Check again if you still have P1 and P2. Check items
on P2.

Login with user 2 in staff. Disable OpacAllowPublicListCreation. 

Login with user 2 in opac. Try to add a public list via shelves, search results
(AddTo combo: New List) and search results (Save to another list). Should not
be possible.

Logout with user 2 in opac. Check lists P1 and P2 (you should see items). Try
to delete a list or delete an entry from a list. (Should not be possible.) Try
to create a list. Try to add an item to P1 via search results, opac detail
(should not be possible).

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

--- Comment #28 from M. de Rooy m.de.r...@rijksmuseum.nl 2012-02-23 13:30:46 
UTC ---
Wiki page http://wiki.koha-community.org/wiki/List_permissions also lists a few
minor issues to be taken care of in a followup.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

--- Comment #29 from M. de Rooy m.de.r...@rijksmuseum.nl 2012-02-23 13:45:52 
UTC ---
Created attachment 7828
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7828
[PATCH 7]Followup for warnings on somedeleted and nothingdeleted in staff
client.

This patch builds on top of patches 4 and 5.
Test this patch by trying to delete items from a public list that someone else 
created (so you do not have sufficient permissions). Check the warning.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

--- Comment #15 from Owen Leonard oleon...@myacpl.org 2012-02-22 15:15:28 UTC 
---
(In reply to comment #13)
 Login with user 2 in staff. Goto Lists. Check P1 and P2. Try to rename or
 delete (should be impossible). Add some items via catalog detail and search
 results (should be possible).
...
 Add items to P3 (should be possible).

So if OpacAllowPublicListCreation is ON, creating a public list means creating
a list which is not only viewable by the everyone but can be added to by
everyone? If I have that right that seems like a big change from how it has
worked in the past.

 (only the ones you added should be deleted). Delete patron user 1. Check if 
 you
 still have P1 and P2. Check items on P2.

What should happen here? Should deleting the patron delete the list? I see that
after deleting patron user 1's private shelves are still in the database.
Shouldn't they be deleted? If they have public shelves, what should happen to
them? Right now I see patron user 1's public shelves in the staff interface but
I can't edit or delete them.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

--- Comment #16 from M. de Rooy m.de.r...@rijksmuseum.nl 2012-02-22 16:08:54 
UTC ---
Hi Owen,
Thx for testing!
First question: Yes, if you create a public list now, anyone can indeed add an
item. Should we change that back to not allowing to create?
Note that current functionality does not allow me to add an entry, but does
allow me to remove an entry (from someone else) from a public list. In the new
situation that cannot be done anymore on the contrary.
The defaults when creating a public list can easily be changed however. Or do
you think that it is better to rightaway introduce the three new allow flags
when creating a list? 

Second question: The private shelves (which do not have shares yet) should
indeed be deleted. My (repeated) testing confirmed that. (Could you check
that?)
The public shelves are not deleted but the owner is set to null. This keeps
them visible. On the wiki page I mentioned an option for a followup to let a
staff user change ownership for such lists. But it would not be a must to do
that.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

--- Comment #17 from Owen Leonard oleon...@myacpl.org 2012-02-22 16:37:52 UTC 
---
(In reply to comment #16)
 First question: Yes, if you create a public list now, anyone can indeed add an
 item. Should we change that back to not allowing to create?

I think it is contrary to current expectations for others to be able to add to
a public list.

 Note that current functionality does not allow me to add an entry, but does
 allow me to remove an entry (from someone else) from a public list.

I do not find this to be the case in current master. I see no option for
deleting items from a public list when I'm logged in as someone other than the
list creator.

 Second question: The private shelves (which do not have shares yet) should
 indeed be deleted. My (repeated) testing confirmed that. (Could you check
 that?)

I will test again.

 The public shelves are not deleted but the owner is set to null. This keeps
 them visible. On the wiki page I mentioned an option for a followup to let a
 staff user change ownership for such lists. But it would not be a must to do
 that.

Why would it not be a must to do that? If the list has no owner there's no way
to delete it, correct?

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

--- Comment #13 from M. de Rooy m.de.r...@rijksmuseum.nl 2012-02-20 08:46:01 
UTC ---
TEST PLAN for first five patches (from wiki):

Login with user 2 in staff. Create user 1 for opac (to be deleted at the end).
Enable OpacAllowPublicListCreation.

Login with user 1 in opac. Add a private list V1 via shelves screen. Add a
private list V2 via search results, Add to combo. Add some items to both lists.
Add a public list P1 via shelves, P2 via search results (Save to another list).
Add some items.

Login with user 2 in staff. Goto Lists. Check P1 and P2. Try to rename or
delete (should be impossible). Add some items via catalog detail and search
results (should be possible). Add private V3 via shelves, private V4 via search
results, public P3. Add some items.

Login with user 1 in opac. Try to rename or delete P3 (should not be possible).
Add items to P3 (should be possible). Try to delete an item from P3 that you
did not add (user 2 did): should not be possible. Delete an item that you added
yourself (should be possible). Delete list V1.

Login with user 2 in staff. Delete list P3. Try to delete all items from P2
(only the ones you added should be deleted). Delete patron user 1. Check if you
still have P1 and P2. Check items on P2. 

Login with user 2 in opac. Check again if you still have P1 and P2. Check items
on P2.

Login with user 2 in staff. Disable OpacAllowPublicListCreation. 

Login with user 2 in opac. Try to add a public list via shelves, search results
(AddTo combo: New List) and search results (Save to another list). Should not
be possible.

Logout with user 2 in opac. You are anonymous user now. Check lists P1 and P2
(you should see items). Try to delete a list or delete an entry from a list.
(Should not be possible.) Try to create a list. Try to add an item to P1 via
search results, opac detail (should not be possible).

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

--- Comment #14 from M. de Rooy m.de.r...@rijksmuseum.nl 2012-02-20 10:33:26 
UTC ---
Created attachment 7769
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7769
[PATCH 6]Updated unit test

Updated VirtualShelves unit test.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

Paul Poulain paul.poul...@biblibre.com changed:

   What|Removed |Added

 Blocks||4912

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

--- Comment #7 from M. de Rooy m.de.r...@rijksmuseum.nl 2012-02-16 11:39:38 
UTC ---
Created attachment 7678
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7678
[PATCH 1]DB revision for Improving list permissions

When testing, use this patch to run updatedatabase. Note that open lists are
converted to public lists with adequate permissions.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

--- Comment #8 from M. de Rooy m.de.r...@rijksmuseum.nl 2012-02-16 11:41:34 
UTC ---
Created attachment 7679
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7679
[PATCH 2]Changing Koha SQL structure

Can be tested by running kohastructure on a new database via command-line, or
installing new Koha.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

--- Comment #9 from M. de Rooy m.de.r...@rijksmuseum.nl 2012-02-16 11:42:47 
UTC ---
Created attachment 7680
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7680
[PATCH 3]New prefs on opac tab

Check new prefs on OPAC tab, under Policy.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 7310] Improving permissions on lists (virtual shelves)

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7310

--- Comment #10 from M. de Rooy m.de.r...@rijksmuseum.nl 2012-02-16 11:49:23 
UTC ---
Created attachment 7681
  -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7681
[PATCH 4]Code revisions for improving permissions

Mimics current functionality as much as possible (not yet releasing the new
permissions on screen, and not allowing sharing yet).
Will send a more detailed test plan via wiki.
Testing mainly comes down to:
Add new private and public lists, add and delete entries, delete list via OPAC
and staff. Use shelves screen, search results and catalog detail screen. Do
this under two different logins. Check what you can/cannot do with public lists
from the other login.

-- 
Configure bugmail: 
http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email
--- You are receiving this mail because: ---
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/