[Koha-bugs] [Bug 7581] Holds not working in OPAC in singlebranchmode
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7581 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #10 from Jared Camins-Esakov jcam...@cpbibliography.com --- This bug will be included in the Koha 3.6.5 release. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7581] Holds not working in OPAC in singlebranchmode
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7581 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||paul.poul...@biblibre.com --- Comment #9 from Paul Poulain paul.poul...@biblibre.com --- QA comment: tiny patch ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7581] Holds not working in OPAC in singlebranchmode
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7581 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7581] Holds not working in OPAC in singlebranchmode
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7581 Kristina Hoeppner krist...@catalyst.net.nz changed: What|Removed |Added CC||krist...@catalyst.net.nz --- Comment #3 from Kristina Hoeppner krist...@catalyst.net.nz --- I was not able to reproduce the bug on the BibLibre sandboxes 4 and 8. This is what I did: 1. Switched SingleBranchMode to Allow. 2. Went to the Opac side and placed a hold on an item. The status Pending was displayed. 3. Switched to the staff client and went to the holds for the book and saw the hold. No error message. Did I miss a step? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7581] Holds not working in OPAC in singlebranchmode
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7581 --- Comment #4 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hm, perhaps there is a difference between item level holds and title level holds - but only guessing here. Did you try both? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7581] Holds not working in OPAC in singlebranchmode
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7581 --- Comment #5 from Kristina Hoeppner krist...@catalyst.net.nz --- I tried both just now on master: 1. Make sure that singlebranch mode is allowed. 2. Make sure that I can place holds. 3. Find a book for which I can place a hold on the OPAC side. 4. Place a hold and choose Next available copy. 5. I can place the hold. 6. Find another book for which I can place a hold, click the Place Hold link. 7. Choose A specific copy and can place the hold. 8. Do the same as 4 and 7 but choosing a different branch (the one that is not the default). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7581] Holds not working in OPAC in singlebranchmode
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7581
--- Comment #6 from Maxime Pelletier pelletiermax...@gmail.com ---
Sorry, here are more details.
You can see in the code :
if ($singleBranchMode || ! $OPACChooseBranch) { # single branch mode or
disabled user choosing
Without my patch, singleBranchMode is always 0, so if
OPACAllowUserToChooseBranch is 0, then no branch is ever set and the code
doesn't work.
So to reproduce set OPACAllowUserToChooseBranch to Don't allow. The bug is
present when users can't choose the branch and the code use the borrowers's
defautl branch.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7581] Holds not working in OPAC in singlebranchmode
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7581 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added CC||ch...@bigballofwax.co.nz --- Comment #7 from Chris Cormack ch...@bigballofwax.co.nz --- Without patch With singlebranchmode = Allow And OPACAllowUserToChooseBranch = Don't allow Can still place holds in the opac With singblebranchmode= Don't Allow and OPACAllowUserToChooseBranch = Don't allow, Can still place holds With singlebranch = Don't Allow and OPACAllowUserToChooseBranch = Allow, Can not place holds (silent fail) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7581] Holds not working in OPAC in singlebranchmode
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7581 Kristina Hoeppner krist...@catalyst.net.nz changed: What|Removed |Added Attachment #7811|0 |1 is obsolete|| --- Comment #8 from Kristina Hoeppner krist...@catalyst.net.nz --- Created attachment 8324 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=8324action=edit signed-off patch I used Chris' test scenarios as basis for my testing because eventually we had a silent fail. Sorry that I didn't see some things earlier, but code is pretty much a mystery to me. ;-) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7581] Holds not working in OPAC in singlebranchmode
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7581 Kristina Hoeppner krist...@catalyst.net.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7581] Holds not working in OPAC in singlebranchmode
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7581 Maxime Pelletier pelletiermax...@gmail.com changed: What|Removed |Added Priority|P5 - low|P3 Change sponsored?|--- |Sponsored Severity|enhancement |major --- Comment #2 from Maxime Pelletier pelletiermax...@gmail.com --- Marking as a bug and and a note that this is sponsored by our client CCSR (http://ccsr.qc.ca). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7581] Holds not working in OPAC in singlebranchmode
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7581 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|NEW |Needs Signoff CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 7581] Holds not working in OPAC in singlebranchmode
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7581 --- Comment #1 from Maxime Pelletier pelletiermax...@gmail.com 2012-02-22 17:10:52 UTC --- Created attachment 7811 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7811 Singlebranchmode was always 0 causing the branch to be null and the reservations in the OPAC not to work in singlebranchmode. -- Configure bugmail: http://bugs.koha-community.org/bugzilla3/userprefs.cgi?tab=email --- You are receiving this mail because: --- You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
