[Koha-bugs] [Bug 7595] Add branchcode to accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Kyle M Hall changed: What|Removed |Added Resolution|WONTFIX

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Kyle M Hall changed: What|Removed |Added Resolution|---

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Nicole C. Engard changed: What|Removed |Added CC|neng...@gmail.com | --

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 --- Comment #51 from Katrin Fischer --- Continued testing, but didn't get much further: IV CIRCULATION 1) Checkout with rental fine OK 2) Renew with rental fine NOT OK - no rental fine recorded >From

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Katrin Fischer changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 --- Comment #49 from Kyle M Hall --- Created attachment 54264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54264=edit Bug 7595 - Update Schema -- You are receiving this mail because:

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 --- Comment #48 from Kyle M Hall --- Created attachment 54263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=54263=edit Bug 7595 - Unit Tests -- You are receiving this mail because: You

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Kyle M Hall changed: What|Removed |Added Attachment #52909|0 |1

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 --- Comment #46 from Katrin Fischer --- Looking at this again. Passes tests and QA test tools. I'd have preferred smaller steps here, it will take a while to work through this as it touches all of the

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 --- Comment #45 from Kyle M Hall --- (In reply to Katrin Fischer from comment #44) > I have done some first tests - not so bad so far, but I worry about paying > via SIP. Can you please verify that this

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 --- Comment #44 from Katrin Fischer --- I have done some first tests - not so bad so far, but I worry about paying via SIP. Can you please verify that this works still as well? Which branch should be logged?

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 --- Comment #43 from Katrin Fischer --- There are no sign-off lines on these patches - Kyle & Marc, can you please check? -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 --- Comment #41 from Kyle M Hall --- Created attachment 52911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52911=edit Bug 7595 - Update Schema -- You are receiving this mail because:

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 --- Comment #42 from Kyle M Hall --- > If 15894 will include testing for > > makepayment, > > recordpayment_selectaccts, > > makepartialpayment > then that would seem acceptable to me. Yes, that bug will

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 --- Comment #40 from Kyle M Hall --- Created attachment 52910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52910=edit Bug 7595 - Unit Tests -- You are receiving this mail because: You

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Kyle M Hall changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Kyle M Hall changed: What|Removed |Added Attachment #38235|0 |1

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 --- Comment #38 from M. Tompsett --- [SEVERELY EDIT'D AND REORDERED] (In reply to Kyle M Hall from comment #37) > (In reply to M. Tompsett from comment #36) > > chargelostitem, > > manualinvoice, > >

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 --- Comment #37 from Kyle M Hall --- (In reply to M. Tompsett from comment #36) > (In reply to Jonathan Druart from comment #35) > > Please provide tests for changes in modules. > > True, most is covered:

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Nicole C. Engard changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Marc Véron changed: What|Removed |Added See Also|

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Marc Véron ve...@veron.ch changed: What|Removed |Added Attachment #38225|0 |1 is

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Marc Véron ve...@veron.ch changed: What|Removed |Added Status|Needs Signoff |Signed Off --

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 --- Comment #34 from Marc Véron ve...@veron.ch --- Created attachment 38235 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38235action=edit [Signed-off] Bug 7595 - Add branchcode to accountlines Adds a branchcode

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 --- Comment #36 from M. Tompsett mtomp...@hotmail.com --- (In reply to Jonathan Druart from comment #35) Please provide tests for changes in modules. True, most is covered: t/db_dependent/Accounts.t t/db_dependent/Circulation.t

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #38150|0 |1

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|ASSIGNED|Needs

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|Patch doesn't apply |ASSIGNED

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #30950|0 |1

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added CC|

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added CC|

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Marc Véron ve...@veron.ch changed: What|Removed |Added CC||ve...@veron.ch

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #27337|0 |1

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #30946|0 |1

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 --- Comment #27 from Kyle M Hall k...@bywatersolutions.com --- Good catch. I've updated all references to branchcode to check for the existance of userenv first. (In reply to M. Tompsett from comment #24) Comment on attachment 27337

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #30947|0 |1

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #23308|0 |1

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Status|Patch doesn't apply |Needs

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 --- Comment #24 from M. Tompsett mtomp...@hotmail.com --- Comment on attachment 27337 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27337 Bug 7595 - Add branchcode to accountlines Review of attachment 27337: --

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 wajasu matted-34...@mypacks.net changed: What|Removed |Added Status|Needs Signoff |Patch

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #20808|0 |1

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |Needs

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #20809|0 |1

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 --- Comment #20 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hm, the follow up was never signed off, but touches a lot of sensitive areas. Please switch back to Needs Signoff later. -- You are receiving this mail because: You are

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC|

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #14815|0 |1

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Patch doesn't apply |Signed

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #14814|0 |1

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Version|3.8 |master

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 cedric.v...@dracenie.com changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #12394|0 |1

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #12395|0 |1

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Patch doesn't apply |Needs

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Needs Signoff |Patch

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 M. Tompsett mtomp...@hotmail.com changed: What|Removed |Added Attachment #12719|0 |1

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 --- Comment #12 from M. Tompsett mtomp...@hotmail.com --- Created attachment 12717 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12717action=edit fredericd fixed 2 perlcritic errors Originally posted on bug 8849, but

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 wajasu matted-34...@mypacks.net changed: What|Removed |Added Attachment #12717|0 |1 is

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #8162|0 |1

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 --- Comment #11 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 12395 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12395action=edit Bug 7595 - Add branchcode to accountlines - Followup -- You are

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |Needs

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Ian Walls koha.sek...@gmail.com changed: What|Removed |Added Status|Signed Off |Failed QA

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Attachment #8037|0 |1

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Attachment #7870|0 |1

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Status|Failed QA |Needs

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Ian Walls koha.sek...@gmail.com changed: What|Removed |Added Status|Signed Off |Failed QA

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 --- Comment #1 from Kyle M Hall kyle.m.h...@gmail.com 2012-02-24 20:23:37 UTC --- Created attachment 7866 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=7866 Bug 7595 - Add branchcode to accountlines Adds a

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Status|NEW |Needs

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Attachment #7866|0 |1

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Attachment #7868|0 |1

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Attachment #7869|0 |1

[Koha-bugs] [Bug 7595] Add branchcode to accountlines

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7595 Nicole C. Engard neng...@gmail.com changed: What|Removed |Added Status|Needs Signoff |Signed