[Koha-bugs] [Bug 8017] Remove unnecessary processing on return of GetAllIssues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8017 --- Comment #18 from Chris Cormack ch...@bigballofwax.co.nz --- Patch contains no string changes, makes some template changes which I think are safe, pushed to 3.8.x, will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8017] Remove unnecessary processing on return of GetAllIssues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8017 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8017] Remove unnecessary processing on return of GetAllIssues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8017 --- Comment #17 from Colin Campbell colin.campb...@ptfs-europe.com --- Created attachment 12207 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12207action=edit Patch - Version for 3.8 This is a version of patch that should apply to 3.8 - The last rebase was to account for some new functionality in master. This omits updating that non existent code -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8017] Remove unnecessary processing on return of GetAllIssues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8017 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply |Passed QA --- Comment #14 from Jonathan Druart jonathan.dru...@biblibre.com --- switching back to passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8017] Remove unnecessary processing on return of GetAllIssues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8017 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master Version|master |rel_3_8 Severity|enhancement |minor --- Comment #15 from Paul Poulain paul.poul...@biblibre.com --- Patch pushed to master. Could be ported to 3.8 imo -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8017] Remove unnecessary processing on return of GetAllIssues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8017 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added CC||ch...@bigballofwax.co.nz --- Comment #16 from Chris Cormack ch...@bigballofwax.co.nz --- I would like this in 3.8.x but unfortunately does not apply cleanly # Changes to be committed: # #modified: C4/Members.pm #modified: koha-tmpl/intranet-tmpl/prog/en/modules/members/readingrec.tt #modified: members/readingrec.pl # # Unmerged paths: # (use git add/rm file... as appropriate to mark resolution) # #both modified: koha-tmpl/opac-tmpl/prog/en/modules/opac-readingrecord.tt #both modified: opac/opac-readingrecord.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8017] Remove unnecessary processing on return of GetAllIssues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8017 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Patch doesn't apply --- Comment #12 from Paul Poulain paul.poul...@biblibre.com --- Sorry, but the patch does not apply anymore, because of bug 6494. Could you rebase resubmit (conflict not trivial to solve: I feel most of it is tidying code, but to avoid any mistake, I let you do) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8017] Remove unnecessary processing on return of GetAllIssues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8017 Colin Campbell colin.campb...@ptfs-europe.com changed: What|Removed |Added Attachment #11330|0 |1 is obsolete|| --- Comment #13 from Colin Campbell colin.campb...@ptfs-europe.com --- Created attachment 12177 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12177action=edit Patch rebased against current head Rebased to incorporate changes introduced by the opachtmlsummary code -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8017] Remove unnecessary processing on return of GetAllIssues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8017 --- Comment #10 from Paul Poulain paul.poul...@biblibre.com --- Colin = pinging my comment 8 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8017] Remove unnecessary processing on return of GetAllIssues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8017 --- Comment #11 from Colin Campbell colin.campb...@ptfs-europe.com --- Paul, Id be happy to see this pushed as is. I think I'll look at what can be done to improve the query as a separate piece of work -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8017] Remove unnecessary processing on return of GetAllIssues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8017 --- Comment #9 from Colin Campbell colin.campb...@ptfs-europe.com --- I'll take a look at Paul's suggestions The main performance hit was the unnecessary repetitions of loops and in production the patch as is does enough to fix large sites that were having problems displaying circ history. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8017] Remove unnecessary processing on return of GetAllIssues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8017
Paul Poulain paul.poul...@biblibre.com changed:
What|Removed |Added
CC||paul.poul...@biblibre.com
--- Comment #8 from Paul Poulain paul.poul...@biblibre.com ---
I realize that this patch modify a SELECT * that is LARGE as it's a JOIN on
issues / biblio / items / biblioitems
I agree it was like this before the patch. But Colin, could you improve it to
return only needed columns, because that's probably also a source of the perfs
problem.
Side note : there is a call to
+my $branches = GetBranches();
+foreach my $issue ( @{$issues} ) {
+$issue-{issuingbranch} = $branches-{ $issue-{branchcode}
}-{branchname};
}
That could be replaced by another JOIN (not sure it's a good idea, just
sharing)
(not failing QA, the mistake was here before your patch. If you can't provide a
follow-up, i'll push like this. But if you agree for a follow-up, it will be
cool ;-) )
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8017] Remove unnecessary processing on return of GetAllIssues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8017 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- This patch seems already signed off. But it does not apply. Could you resubmit a rebased patch please ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8017] Remove unnecessary processing on return of GetAllIssues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8017 Colin Campbell colin.campb...@ptfs-europe.com changed: What|Removed |Added Attachment #10192|0 |1 is obsolete|| --- Comment #6 from Colin Campbell colin.campb...@ptfs-europe.com --- Created attachment 11330 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=11330action=edit Patch rebased against current head Rebase of patch against HEAD -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8017] Remove unnecessary processing on return of GetAllIssues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8017 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Patch doesn't apply |Passed QA --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- Thanks Colin ! I did not find any regression. So I mark it as Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8017] Remove unnecessary processing on return of GetAllIssues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8017 Colin Campbell colin.campb...@ptfs-europe.com changed: What|Removed |Added Attachment #9536|0 |1 is obsolete|| Status|Failed QA |Needs Signoff Assignee|gmcha...@gmail.com |colin.campbell@ptfs-europe. ||com --- Comment #4 from Colin Campbell colin.campb...@ptfs-europe.com --- Created attachment 10192 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10192action=edit Proposed Amended Patch Patch rebased against master. Have added sanitizing of order and limit parameters (although order is currently always passed a constant string from the caller) Note on issue 2 adding parens around the variable forces the tt parser to evaluate as an expression. i.e. potentially adding processing where a simple variable is used. While it was used defensively in converting templates I'd suggest following normal tt style in new code -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8017] Remove unnecessary processing on return of GetAllIssues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8017 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Signed Off |Failed QA CC||jonathan.dru...@biblibre.co ||m --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- QA Comments: 1/ You remove the FIXME in getAllIssues (sanity-check order and limit) but $order is not sanitized. Please call $dbh-quote with the $order variable. 2/ Why do you remove the parenthesis for the IF statement (template) ? It seems mandatory by the koha guidelines. But I agree with you, it is useless :) Failed QA for 1. Replacement of fetchrow_hashref with a more adapted fetchall_arrayref is good. I think there is others occurrences of this into the koha code. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8017] Remove unnecessary processing on return of GetAllIssues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8017 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added QA Contact|koha.sek...@gmail.com |jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8017] Remove unnecessary processing on return of GetAllIssues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8017 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #9317|0 |1 is obsolete|| --- Comment #2 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 9536 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9536action=edit Bug 8017 reduce manipulation of GetAllIssues return GetAllIssues can produce large lists For performance purposes: Dont loop over the list without cause Dont do expensive processing in the loop Dont needlessly copy the array Do display formatting in the template Dont extract the barcode list unless we are producing it Reduce db calls by using the data to hand Make the table in the template a bit more readable where everything was stuffed into one line Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8017] Remove unnecessary processing on return of GetAllIssues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8017 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8017] Remove unnecessary processing on return of GetAllIssues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8017 --- Comment #1 from Colin Campbell colin.campb...@ptfs-europe.com --- Created attachment 9317 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9317action=edit Proposed patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8017] Remove unnecessary processing on return of GetAllIssues
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8017 Colin Campbell colin.campb...@ptfs-europe.com changed: What|Removed |Added Priority|P5 - low|P4 Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
