[Koha-bugs] [Bug 8028] Make table collapsing on parcel.pl sticky
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8028 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=9130 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8028] Make table collapsing on parcel.pl sticky
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8028 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master Version|master |rel_3_10 --- Comment #16 from Paul Poulain paul.poul...@biblibre.com --- This time it's OK, patch pushed to master ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8028] Make table collapsing on parcel.pl sticky
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8028 --- Comment #13 from Paul Poulain paul.poul...@biblibre.com --- Kyle, ping on my comment 12. I need to test that before pushing ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8028] Make table collapsing on parcel.pl sticky
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8028 --- Comment #14 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 12059 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12059action=edit Bug 8028 - Followup -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8028] Make table collapsing on parcel.pl sticky
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8028 --- Comment #15 from Kyle M Hall k...@bywatersolutions.com --- (In reply to comment #12) mmm... I made a basket with 6 lines, and had another one with 2 lines pending. When I reach the parcel.pl page, I see the 8 pending lines directly, and no link to collapse/expand. Am I missing something ? (I recieved 4 of them, and saw no change) Good catch. I've attach a small followup to fix the issue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8028] Make table collapsing on parcel.pl sticky
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8028 --- Comment #12 from Paul Poulain paul.poul...@biblibre.com --- mmm... I made a basket with 6 lines, and had another one with 2 lines pending. When I reach the parcel.pl page, I see the 8 pending lines directly, and no link to collapse/expand. Am I missing something ? (I recieved 4 of them, and saw no change) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8028] Make table collapsing on parcel.pl sticky
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8028 Ian Walls koha.sek...@gmail.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||koha.sek...@gmail.com --- Comment #11 from Ian Walls koha.sek...@gmail.com --- Adds a couple small cookies for stickiness, and some logic to handle them. Followup patch fixes conditional nesting. Marking Passed QA. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8028] Make table collapsing on parcel.pl sticky
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8028 --- Comment #10 from Kyle M Hall k...@bywatersolutions.com --- (In reply to comment #9) QA comment: I'm unable to understand reproduce the problem and the solution. Could you give me more explanations ? A screenshot ? Currently, if there are more than 5 items in the table on parcel.pl, it only shows you the first 5. You must click a link to show more than 5. This patch makes the page 'remember' if you would prefer to see just the first 5, or more than 5. 2 comments (that will maybe be removed when I understand reproduce): * is using a cookie the best way to do that ? I think it is the best way to accomplish this. The idea is to give the librarians the choice. A system preference would force all the librarians to have the same behavior ( 5 or more than 5 ). Additionally, parameter passing won't work without adding the parameter to *every* page in Koha, which sounds like a far worse solution. * isn't DataTable jquery plugin what we should use ? Nobody as implemented DataTables here, and it is outside the scope of this bug. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8028] Make table collapsing on parcel.pl sticky
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8028 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added CC||paul.poul...@biblibre.com --- Comment #9 from Paul Poulain paul.poul...@biblibre.com --- QA comment: I'm unable to understand reproduce the problem and the solution. Could you give me more explanations ? A screenshot ? 2 comments (that will maybe be removed when I understand reproduce): * is using a cookie the best way to do that ? * isn't DataTable jquery plugin what we should use ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8028] Make table collapsing on parcel.pl sticky
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8028 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #10878|0 |1 is obsolete|| --- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 10926 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10926action=edit Bug 8028 - Make table collapsing on parcel.pl sticky - Hide link for 5 or fewer items. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8028] Make table collapsing on parcel.pl sticky
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8028 --- Comment #6 from Jonathan Druart jonathan.dru...@biblibre.com --- Kyle, Thanks for signed-off ! If anyone has a suggestion for a good way to word this, I will write a patch to update the language. I think we can just check if the number of items are 5 to display links. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8028] Make table collapsing on parcel.pl sticky
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8028 --- Comment #7 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 10878 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10878action=edit Bug 8028 - Make table collapsing on parcel.pl sticky - Hide link for 5 or fewer items. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8028] Make table collapsing on parcel.pl sticky
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8028 kyle.m.h...@gmail.com k...@bywatersolutions.com changed: What|Removed |Added CC||k...@bywatersolutions.com --- Comment #5 from kyle.m.h...@gmail.com k...@bywatersolutions.com --- If anyone has a suggestion for a good way to word this, I will write a patch to update the language. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8028] Make table collapsing on parcel.pl sticky
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8028 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #9372|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 10797 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10797action=edit Bug 8028 - Make table collapsing on parcel.pl sticky The tables on parcel.pl default to show only the first five items in the table, and librarians must click the a link to display all the items. Every time the page is reloaded, the table gets re-collapsed, and the librarian must again click the link. Parcel.pl should remember which way the table is set and keep it that way until it is changed again. This is accomplished by adding two cookies for this page, one for each table. This cookie stores the state of the table ( collapsed, or uncollapsed ) and sets each table to the correct state on each page load. Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com Works as expected. But a funny behaviour, if I have only 1 item (or 6): All 1 items are displayed. Click here to show only the first 5 items. and Only the first 5 items are displayed. Click here to show all 1 items. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8028] Make table collapsing on parcel.pl sticky
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8028 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8028] Make table collapsing on parcel.pl sticky
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8028 Kyle M Hall kyle.m.h...@gmail.com changed: What|Removed |Added Assignee|henridam...@koha-fr.org |kyle.m.h...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8028] Make table collapsing on parcel.pl sticky
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8028 --- Comment #3 from Kyle M Hall kyle.m.h...@gmail.com --- (In reply to comment #2) Hi Kyle, wouldn't it work to pass around the setting instead of using cookies? That would work for refreshing the page, but not for moving from say parcel.pl to the item details page and back. It could be done, but would require far more code and I don't see any advantage to that. The alternative would be a system preference, but then the librarians would be in the opposite situation, where if they wanted it collapsed, they'd have to click the link every time. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8028] Make table collapsing on parcel.pl sticky
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8028 --- Comment #1 from Kyle M Hall kyle.m.h...@gmail.com --- Created attachment 9372 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=9372action=edit Bug 8028 - Make table collapsing on parcel.pl sticky The tables on parcel.pl default to show only the first five items in the table, and librarians must click the a link to display all the items. Every time the page is reloaded, the table gets re-collapsed, and the librarian must again click the link. Parcel.pl should remember which way the table is set and keep it that way until it is changed again. This is accomplished by adding two cookies for this page, one for each table. This cookie stores the state of the table ( collapsed, or uncollapsed ) and sets each table to the correct state on each page load. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8028] Make table collapsing on parcel.pl sticky
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8028 --- Comment #2 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Kyle, wouldn't it work to pass around the setting instead of using cookies? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
