[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #67 from Marc Véron --- Attachment 22301: Merge conflict in sco-main.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 I'm just a bot changed: What|Removed |Added CC||git...@bugs.koha-community. ||org When did the bot||2013-10-30 last check this|| --- Comment #66 from I'm just a bot --- Patch applied cleanly, go forth and signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Owen Leonard changed: What|Removed |Added Attachment #18054|0 |1 is obsolete|| --- Comment #65 from Owen Leonard --- Created attachment 22302 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22302&action=edit Bug 8033 - add print receipt option to Koha self-check (edit) Reimplementation of Kyle's follow-up, minus the addition of "" which is I don't understand. From the original commit message: 3 misc follow-up fixes 1/ fixed printslip.tmpl typo 2/ moved hardcoded text string from script to template. 3/ delete unused receipt.tt file To Test: - Sign in to self checkout. - Enter a barcode and click submit. - Click the finish button - You should be prompted with a message asking if you would like a receipt. If you click OK you should be taken to the page with the receipt. If you click Cancel you should not see the reciept and you should be logged out. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Owen Leonard changed: What|Removed |Added Attachment #18053|0 |1 is obsolete|| --- Comment #64 from Owen Leonard --- Created attachment 22301 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22301&action=edit Bug 8033 [Follow-up] add print receipt option to Koha self-check This follow-up makes some corrections to JavaScript, most importantly by enabling translation of strings embedded in the script. Other corrections: Trailing whitespace, proper
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 --- Comment #63 from Chris Cormack --- (In reply to Derryn from comment #62) > I would like to voice my annoyance at this bug. > > We have no printer, no need or want for receipts. > Why should our users be forced to get out the mouse/keyboard and hit no > every time they log out? > This should be an option in the preferences and not forced upon everyone. Awesome, I look forward to your patch implementing this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Derryn changed: What|Removed |Added CC||derr...@gmail.com --- Comment #62 from Derryn --- I would like to voice my annoyance at this bug. We have no printer, no need or want for receipts. Why should our users be forced to get out the mouse/keyboard and hit no every time they log out? This should be an option in the preferences and not forced upon everyone. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Owen Leonard changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #61 from Owen Leonard --- (In reply to comment #60) > 2/ fixed display bug What is 'i18n-content="title"' supposed to do? This template should not have a beginning tag. is supplied by doc-head-open.inc. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Kyle M Hall changed: What|Removed |Added Attachment #17374|0 |1 is obsolete|| --- Comment #60 from Kyle M Hall --- Created attachment 18054 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18054&action=edit Bug 8033 - add print receipt option to Koha self-check (edit) 4 misc follow-up fixes 1/ fixed printslip.tmpl typo 2/ fixed display bug 3/ moved hardcoded text string from script to template. 4/ delete unused receipt.tt file To Test: - Sign in to self checkout. - Enter a barcode and click submit. - Click the finish button - You should be prompted with a message asking if you would like a receipt. If you click OK you should be taken to the page with the receipt. If you click Cancel you should not see the reciept and you should be logged out. fyi: you should no longer see a " Print Receipt for..." line in chrome/IE Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Kyle M Hall changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Kyle M Hall changed: What|Removed |Added Attachment #17373|0 |1 is obsolete|| --- Comment #59 from Kyle M Hall --- Created attachment 18053 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18053&action=edit Bug 8033 [Follow-up] add print receipt option to Koha self-check This follow-up makes some corrections to JavaScript, most importantly by enabling translation of strings embedded in the script. Other corrections: Trailing whitespace, proper
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Kyle M Hall changed: What|Removed |Added Attachment #14102|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Kyle M Hall changed: What|Removed |Added Attachment #14101|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Kyle M Hall changed: What|Removed |Added Attachment #14100|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Kyle M Hall changed: What|Removed |Added Attachment #14102|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Kyle M Hall changed: What|Removed |Added Attachment #14101|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Kyle M Hall changed: What|Removed |Added Attachment #14100|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Nicole C. Engard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply --- Comment #58 from Nicole C. Engard --- I was going to sign off on the follow up but I can't apply the original signed off patch anymore. Bug 8033 - add print receipt option to Koha self-check (edit) Apply? [yn] y Applying: Bug 8033 - add print receipt option to Koha self-check (edit) error: patch failed: koha-tmpl/opac-tmpl/prog/en/modules/sco/receipt.tt:1 error: koha-tmpl/opac-tmpl/prog/en/modules/sco/receipt.tt: patch does not apply Patch failed at 0001 Bug 8033 - add print receipt option to Koha self-check (edit) When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Patch left in /tmp/Bug-8033---add-print-receipt-option-to-Koha-self-c-gJKXQ0.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 --- Comment #57 from Mason James --- Created attachment 17374 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17374&action=edit Bug 8033 - add print receipt option to Koha self-check (edit) 4 misc follow-up fixes 1/ fixed printslip.tmpl typo 2/ fixed display bug 3/ moved hardcoded text string from script to template. 4/ delete unused receipt.tt file To Test: - Sign in to self checkout. - Enter a barcode and click submit. - Click the finish button - You should be prompted with a message asking if you would like a receipt. If you click OK you should be taken to the page with the receipt. If you click Cancel you should not see the reciept and you should be logged out. fyi: you should no longer see a " Print Receipt for..." line in chrome/IE -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Mason James changed: What|Removed |Added Status|Passed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 --- Comment #56 from Mason James --- (In reply to comment #55) > Created attachment 17373 [details] [review] > Bug 8033 [Follow-up] add print receipt option to Koha self-check > > This follow-up makes some corrections to JavaScript, most importantly > by enabling translation of strings embedded in the script. Other > corrections: Trailing whitespace, proper
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Mason James changed: What|Removed |Added Attachment #14498|0 |1 is obsolete|| --- Comment #55 from Mason James --- Created attachment 17373 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=17373&action=edit Bug 8033 [Follow-up] add print receipt option to Koha self-check This follow-up makes some corrections to JavaScript, most importantly by enabling translation of strings embedded in the script. Other corrections: Trailing whitespace, proper
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Mason James changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 --- Comment #54 from Mason James --- (In reply to comment #53) > (In reply to comment #51) > > (In reply to comment #50) > > > Could someone confirm this file (sco/receipt.tt) can be removed? > > > > I've searched in my text editor and grepped the files within the sco > > directories in cgi-bin and htdocs, and I cannot see any reference to > > sco/receipt.tt > > interesting... > > despite sco/receipt.tt being added to the repo in commit a0b220f8551 > it looks like it's probably never been used/referred to? > > so, delete this file for sure :) ah, i see now... the orig. file was opac/sco/receipt.tmpl and was used by opac/sco/printer.pl opac/sco/printer.pl was removed, but its tmpl/tt file was not the file can still be removed safely -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 --- Comment #53 from Mason James --- (In reply to comment #51) > (In reply to comment #50) > > Could someone confirm this file (sco/receipt.tt) can be removed? > > I've searched in my text editor and grepped the files within the sco > directories in cgi-bin and htdocs, and I cannot see any reference to > sco/receipt.tt interesting... despite sco/receipt.tt being added to the repo in commit a0b220f8551 it looks like it's probably never been used/referred to? so, delete this file for sure :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 --- Comment #52 from David Cook --- Also, it looks like there is an issue with the HTML tags. Chrome and IE9 (I haven't checked out browsers) seem to add a tag, which causes the opening tag to be rendered as part of the innerHTML, so you wind up with " Print Receipt for..." I don't know if the best solution is to remove the opening tag or if others have other ideas, but it would be worth a quick follow-up... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 --- Comment #51 from David Cook --- (In reply to comment #50) > Could someone confirm this file (sco/receipt.tt) can be removed? I've searched in my text editor and grepped the files within the sco directories in cgi-bin and htdocs, and I cannot see any reference to sco/receipt.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 --- Comment #50 from Jonathan Druart --- Could someone confirm this file (sco/receipt.tt) can be removed? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 --- Comment #49 from Jonathan Druart --- (In reply to comment #48) > Click 'Finish' on /cgi-bin/koha/sco/sco-main.pl and it will prompt to print. > > Nicole According to the code this action uses the sco/printslip.tt file, not sco/receipt.tt -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 --- Comment #48 from Nicole C. Engard --- Click 'Finish' on /cgi-bin/koha/sco/sco-main.pl and it will prompt to print. Nicole -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #47 from Jonathan Druart --- I cannot test the modifications on the sco/receipt.tt file. Where is it used? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Nicole C. Engard changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #46 from Nicole C. Engard --- Obsoleted all patches that appeared to have been pushed already - if I was wrong feel free to restore. Follow up signed off. Nicole -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Nicole C. Engard changed: What|Removed |Added Attachment #14100|0 |1 is obsolete|| Attachment #14101|0 |1 is obsolete|| Attachment #14102|0 |1 is obsolete|| Attachment #14496|0 |1 is obsolete|| --- Comment #45 from Nicole C. Engard --- Created attachment 14498 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14498&action=edit [SIGNED-OFF] Bug 8033 [Follow-up] add print receipt option to Koha self-check This follow-up makes some corrections to JavaScript, most importantly by enabling translation of strings embedded in the script. Other corrections: Trailing whitespace, proper
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Owen Leonard changed: What|Removed |Added Attachment #14134|0 |1 is obsolete|| --- Comment #44 from Owen Leonard --- Created attachment 14496 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14496&action=edit Bug 8033 [Follow-up] add print receipt option to Koha self-check This follow-up makes some corrections to JavaScript, most importantly by enabling translation of strings embedded in the script. Other corrections: Trailing whitespace, proper
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Owen Leonard changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Nicole C. Engard changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||neng...@gmail.com --- Comment #43 from Nicole C. Engard --- Bug 8033 : This patch adds print slips to self checkout. Apply? [yn] y Applying: Bug 8033 : This patch adds print slips to self checkout. error: koha-tmpl/opac-tmpl/prog/en/modules/sco/printslip.tt: already exists in index error: patch failed: koha-tmpl/opac-tmpl/prog/en/modules/sco/sco-main.tt:8 error: koha-tmpl/opac-tmpl/prog/en/modules/sco/sco-main.tt: patch does not apply error: opac/sco/printslip.pl: already exists in index error: patch failed: opac/sco/sco-main.pl:239 error: opac/sco/sco-main.pl: patch does not apply Patch failed at 0001 Bug 8033 : This patch adds print slips to self checkout. When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". Patch left in /tmp/Bug-8033--This-patch-adds-print-slips-to-self-chec-33SuJQ.patch nengard@kohavm:~/kohaclone$ -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 --- Comment #42 from Owen Leonard --- Created attachment 14134 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14134&action=edit Bug 8033 [Follow-up] add print receipt option to Koha self-check This follow-up makes some corrections to JavaScript, most importantly by enabling translation of strings embedded in the script. Other corrections: Trailing whitespace, proper
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Owen Leonard changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Owen Leonard changed: What|Removed |Added Status|Pushed to Master|ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Jared Camins-Esakov changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #41 from Jared Camins-Esakov --- This patch has been pushed to master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Elliott Davis changed: What|Removed |Added Attachment #14097|0 |1 is obsolete|| --- Comment #40 from Elliott Davis --- Created attachment 14102 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14102&action=edit Bug 8033: Change javascipt behavior to degrade nicely Signed-off-by: Elliott Davis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Elliott Davis changed: What|Removed |Added Attachment #14098|0 |1 is obsolete|| --- Comment #39 from Elliott Davis --- Created attachment 14101 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14101&action=edit Bug 8033 follow-up removing tabs in indentation Signed-off-by: Elliott Davis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Elliott Davis changed: What|Removed |Added Attachment #14099|0 |1 is obsolete|| --- Comment #38 from Elliott Davis --- Created attachment 14100 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14100&action=edit Bug 8033 : This patch adds print slips to self checkout. To Test: Sign in to self checkout. Enter a barcode and click submit. Click the finish button You should be prompted with a message asking if you would like a receipt. If you click OK you should be taken to the page with the receipt. If you click Cancel you should not see the reciept and you should be logged out. http://bugs.koha-community.org/show_bug.cgi?id=8033 Signed-off-by: Chris Cormack Added copyright to print slip for SCO Modified POD and copyright. Also perltidied http://bugs.koha-community.org/show_bug.cgi?id=8033 updated print slip option to show on the click of the finish button instead of the submit button Signed-off-by: Elliott Davis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Elliott Davis changed: What|Removed |Added Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Elliott Davis changed: What|Removed |Added Attachment #14094|0 |1 is obsolete|| --- Comment #37 from Elliott Davis --- Created attachment 14099 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14099&action=edit Bug 8033 : This patch adds print slips to self checkout. To Test: Sign in to self checkout. Enter a barcode and click submit. Click the finish button You should be prompted with a message asking if you would like a receipt. If you click OK you should be taken to the page with the receipt. If you click Cancel you should not see the reciept and you should be logged out. http://bugs.koha-community.org/show_bug.cgi?id=8033 Signed-off-by: Chris Cormack Added copyright to print slip for SCO Modified POD and copyright. Also perltidied http://bugs.koha-community.org/show_bug.cgi?id=8033 updated print slip option to show on the click of the finish button instead of the submit button Signed-off-by: Elliott Davis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Elliott Davis changed: What|Removed |Added Attachment #14095|0 |1 is obsolete|| --- Comment #36 from Elliott Davis --- Created attachment 14098 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14098&action=edit Bug 8033 follow-up removing tabs in indentation Signed-off-by: Elliott Davis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Elliott Davis changed: What|Removed |Added Attachment #14096|0 |1 is obsolete|| --- Comment #35 from Elliott Davis --- Created attachment 14097 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14097&action=edit Bug 8033: Change javascipt behavior to degrade nicely Signed-off-by: Elliott Davis -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Jared Camins-Esakov changed: What|Removed |Added Attachment #14091|0 |1 is obsolete|| --- Comment #34 from Jared Camins-Esakov --- Created attachment 14096 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14096&action=edit Bug 8033: Change javascipt behavior to degrade nicely -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Jared Camins-Esakov changed: What|Removed |Added Attachment #14026|0 |1 is obsolete|| --- Comment #33 from Jared Camins-Esakov --- Created attachment 14095 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14095&action=edit Bug 8033 follow-up removing tabs in indentation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Jared Camins-Esakov changed: What|Removed |Added Attachment #14024|0 |1 is obsolete|| --- Comment #32 from Jared Camins-Esakov --- Created attachment 14094 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14094&action=edit Bug 8033 : This patch adds print slips to self checkout. To Test: Sign in to self checkout. Enter a barcode and click submit. Click the finish button You should be prompted with a message asking if you would like a receipt. If you click OK you should be taken to the page with the receipt. If you click Cancel you should not see the reciept and you should be logged out. http://bugs.koha-community.org/show_bug.cgi?id=8033 Signed-off-by: Chris Cormack Added copyright to print slip for SCO Modified POD and copyright. Also perltidied http://bugs.koha-community.org/show_bug.cgi?id=8033 updated print slip option to show on the click of the finish button instead of the submit button -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Jared Camins-Esakov changed: What|Removed |Added Attachment #14025|0 |1 is obsolete|| --- Comment #31 from Jared Camins-Esakov --- Created attachment 14091 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14091&action=edit Bug 8033: Change javascipt behavior to degrade nicely -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Jared Camins-Esakov changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #30 from Jared Camins-Esakov --- Marking as "Failed QA" until guidance is provided on how to test this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 --- Comment #29 from Jared Camins-Esakov --- I followed the test plan, and I am definitely not asked if I want to print out a receipt. Is there a syspref that needs to be set? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 --- Comment #28 from Paul Poulain --- Created attachment 14026 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14026&action=edit Bug 8033 follow-up removing tabs in indentation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 --- Comment #27 from Paul Poulain --- Created attachment 14025 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14025&action=edit Change javascipt behavior to degrade nicely http://bugs.koha-community.org/show_bug.cgi?id=8033 Signed-off-by: Mason James Signed-off-by: Paul Poulain -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Paul Poulain changed: What|Removed |Added Attachment #12316|0 |1 is obsolete|| Attachment #13716|0 |1 is obsolete|| --- Comment #26 from Paul Poulain --- Created attachment 14024 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14024&action=edit Bug 8033 : This patch adds print slips to self checkout. To Test: Sign in to self checkout. Enter a barcode and click submit. Click the finish button You should be prompted with a message asking if you would like a receipt. If you click OK you should be taken to the page with the receipt. If you click Cancel you should not see the reciept and you should be logged out. http://bugs.koha-community.org/show_bug.cgi?id=8033 Signed-off-by: Chris Cormack Added copyright to print slip for SCO Modified POD and copyright. Also perltidied http://bugs.koha-community.org/show_bug.cgi?id=8033 updated print slip option to show on the click of the finish button instead of the submit button -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Paul Poulain changed: What|Removed |Added Status|Signed Off |Passed QA QA Contact||paul.poul...@biblibre.com --- Comment #25 from Paul Poulain --- QA comment: * passes koha-qa.pl although there are a few tabs I've replaced by 4 spaces in a follow-up * work as expected/announced, no side effect risk I can see * there are some missing images with ccsr theme, but this problem is not related to this patch * Idea for an improvement = make sco slip printing compatible with silent printing (see bug 7563) passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 --- Comment #24 from Owen Leonard --- (In reply to comment #23) > Is adding a seperate button something that needs to be done before this patch > sees some QA love? I would think it could be left for a follow-up. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 --- Comment #23 from Elliott Davis --- Owen is right, it is expected behavior as the pop-up is javascript. Is adding a seperate button something that needs to be done before this patch sees some QA love? Elliott -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 --- Comment #22 from Owen Leonard --- (In reply to comment #21) > with jscript disabled, 'finish' button works as expected > ... but printing pop-up is disabled This is to be expected since the trigger for the pop-up is JavaScript. If we wanted to be sure we offered a print view to non-JS users we might add a separate button and hide it with JavaScript. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Mason James changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||m...@kohaaloha.com Patch complexity|--- |Small patch Change sponsored?|--- |Sponsored --- Comment #21 from Mason James --- (In reply to comment #20) > Created attachment 13716 [details] > Change javascipt behavior to degrade nicely > > http://bugs.koha-community.org/show_bug.cgi?id=8033 > Signed-off-by: Mason James with jscript disabled, 'finish' button works as expected ... but printing pop-up is disabled Elliot, i assume this is the expected behaviour? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Mason James changed: What|Removed |Added Attachment #13559|0 |1 is obsolete|| --- Comment #20 from Mason James --- Created attachment 13716 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13716&action=edit Change javascipt behavior to degrade nicely http://bugs.koha-community.org/show_bug.cgi?id=8033 Signed-off-by: Mason James -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Elliott Davis changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #19 from Elliott Davis --- Please apply both the original patch and the follow up. The testing plan is the same as before. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 --- Comment #18 from Elliott Davis --- Created attachment 13559 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=13559&action=edit [Follow-up] Change javascipt behavior to degrade nicely -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033
Owen Leonard changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #17 from Owen Leonard ---
This seems to work fine, but I would feel more comfortable signing off if the
"Finish" action wasn't so dependent on JavaScript. Instead of using a click
handler on the submit button, I suggest using a submit handler:
$("#logout_form").submit(function(){
if(confirm("Would you like to print a receipt?")){
window.open("/cgi-bin/koha/sco/printslip.pl?borrowernumber=[%
borrowernumber %]&print=qslip");
}
return true;
});
You don't have to rewrite the "action" of the form because whether the user
wants to print a receipt or not they want to log out. Keep the default action
of the form and pop up the window if the user has JavaScript on and chooses to
confirm.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Elliott Davis changed: What|Removed |Added Attachment #10678|0 |1 is obsolete|| Attachment #2|0 |1 is obsolete|| --- Comment #16 from Elliott Davis --- Created attachment 12316 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12316&action=edit Bug 8033 : This patch adds print slips to self checkout. To Test: Sign in to self checkout. Enter a barcode and click submit. Click the finish button You should be prompted with a message asking if you would like a receipt. If you click OK you should be taken to the page with the receipt. If you click Cancel you should not see the reciept and you should be logged out. http://bugs.koha-community.org/show_bug.cgi?id=8033 Signed-off-by: Chris Cormack Added copyright to print slip for SCO Modified POD and copyright. Also perltidied http://bugs.koha-community.org/show_bug.cgi?id=8033 updated print slip option to show on the click of the finish button instead of the submit button -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 --- Comment #15 from David Cook --- Not to hassle you too much, but it's also worth noting that renewals aren't included in the print out. Just check outs. I haven't looked too much into the guts of this script, but they should probably be included too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 --- Comment #14 from David Cook --- (In reply to comment #13) > (In reply to comment #12) > > (In reply to comment #11) > > > The reason I added it to the submit button rather than the finish button > > > was > > > because I feared someone would not click finish and just leave the > > > terminal. > > > > This was a potential problem before this patch, wasn't it? I think it's too > > much of a disruption to the process to pop up a message after each > > transaction. I think it would be better to leave it up to the user to decide > > when to print their receipt. Perhaps another button alongside "finish," > > "Finish and print receipt?" > > I agree with Owen. If someone skips the receipt printing step, that's their > problem. Additionally, you're skipping the server-side validation when you have your script on the submit button. You generate a slip even though the item might not actually be checked out (because it is reference book, currently checked out to someone else, on hold for someone else, a renewal, and so on). While this isn't a crippling deficiency, it is certainly problematic. I also wanted to mention that I agree with Owen as well. I use the self-checkout at my local branch all the time, and you print the receipt by pressing the "Print Receipt" button on the screen. It's a much smoother behaviour. (I've also noticed recently that there is an "Email Receipt" button as an alternative to the paper receipt.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 --- Comment #13 from Jared Camins-Esakov --- (In reply to comment #12) > (In reply to comment #11) > > The reason I added it to the submit button rather than the finish button was > > because I feared someone would not click finish and just leave the terminal. > > This was a potential problem before this patch, wasn't it? I think it's too > much of a disruption to the process to pop up a message after each > transaction. I think it would be better to leave it up to the user to decide > when to print their receipt. Perhaps another button alongside "finish," > "Finish and print receipt?" I agree with Owen. If someone skips the receipt printing step, that's their problem. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 --- Comment #12 from Owen Leonard --- (In reply to comment #11) > The reason I added it to the submit button rather than the finish button was > because I feared someone would not click finish and just leave the terminal. This was a potential problem before this patch, wasn't it? I think it's too much of a disruption to the process to pop up a message after each transaction. I think it would be better to leave it up to the user to decide when to print their receipt. Perhaps another button alongside "finish," "Finish and print receipt?" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 --- Comment #11 from Elliott Davis --- Owen, The reason I added it to the submit button rather than the finish button was because I feared someone would not click finish and just leave the terminal. If you think that this is an improbable case it is a pretty easy change. (In reply to comment #10) > I find that submitting a barcode to check out results in a "Would you like > to print a receipt" dialog. Shouldn't it only offer to print when you click > "Finish?" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 --- Comment #10 from Owen Leonard --- I find that submitting a barcode to check out results in a "Would you like to print a receipt" dialog. Shouldn't it only offer to print when you click "Finish?" -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Elliott Davis changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Elliott Davis changed: What|Removed |Added Attachment #2|Modified POD and copyright. |[Followup] Modified POD and description| Also perltidied|copyright. Also perltidied -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 --- Comment #9 from Elliott Davis --- Created attachment 2 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=2&action=edit Modified POD and copyright. Also perltidied -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Paul Poulain changed: What|Removed |Added Status|Signed Off |Failed QA CC||paul.poul...@biblibre.com --- Comment #8 from Paul Poulain --- QA comments * new script passes perlcritic * Eliott, if you don't want to copyright your code to bywatersolutions, please copyright it to HLT * your new script sco/printslip.pl seems not to be perltidy-ed (see PERL1 coding guidelines http://wiki.koha-community.org/wiki/Coding_Guidelines) * I tested, got the message, but the printed paper was empty. Filling ISSUEQSLIP notice make things looking better ! failed QA for now, when you've fixed 2 and 3, switch back to signed off, as the QA comments are just coding style related -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Chris Cormack changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Chris Cormack changed: What|Removed |Added Attachment #10677|0 |1 is obsolete|| --- Comment #7 from Chris Cormack --- Created attachment 10678 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10678&action=edit Bug 8033 : This patch adds print slips to self checkout. To Test: Sign in to self checkout. Enter a barcode and click submit. You should be prompted with a message asking if you would like a receipt. If you click OK you should be taken to the page with the receipt. If you click Cancel you should not see the reciept and your item should check out. Signed-off-by: Chris Cormack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 --- Comment #6 from Chris Cormack --- (In reply to comment #5) > Chris, > > I made the changes you requested. Let me know if it looks ok. The reason I > left the copyright headers was because it was basically a direct copy and I > didn't want to take credit for someone else's work. Yep, you could add parts copyright Bywater Solutions in that case. Also now we have no copyright headers :( And no POD. A follow up fixing those would be great. But I'll sign off on it because functionality wise it works, but you will probably need that follow up to get passed QA. (The POD is handy for this http://perldoc.koha-community.org/members/patronimage.html) http://perldoc.koha-community.org/ is a great resource for developing and it gets better the better we document our code. But that will be up to QA not me :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Elliott Davis changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #5 from Elliott Davis --- Chris, I made the changes you requested. Let me know if it looks ok. The reason I left the copyright headers was because it was basically a direct copy and I didn't want to take credit for someone else's work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Elliott Davis changed: What|Removed |Added Attachment #10649|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Elliott Davis changed: What|Removed |Added Attachment #10648|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 --- Comment #4 from Elliott Davis --- Created attachment 10677 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10677&action=edit This patch adds print slips to self checkout. To Test: Sign in to self checkout. Enter a barcode and click submit. You should be prompted with a message asking if you would like a receipt. If you click OK you should be taken to the page with the receipt. If you click Cancel you should not see the reciept and your item should check out. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033
Chris Cormack changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
CC||ch...@bigballofwax.co.nz
--- Comment #3 from Chris Cormack ---
Hi Elliott
This looks good, but a few little things that need to be fixed
in opac/sco/printslip.pl
1/ Copyright headers (it says biblibre and katipo at the moment)
2/ use warnings is commented out, we shouldn't be making new scripts with
warnings commented out
3/ The pod is still referring to moremember.pl which is where the script was
copied from I guess
4/ $template->param( is a HTML::Template thing, they still exist in old scripts
and we have a shim in C4::Templates to fix it, but its best to make no ones
like this
$template->{VARS}->{'slip'} = $slip;
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Elliott Davis changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 --- Comment #2 from Elliott Davis --- Created attachment 10649 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10649&action=edit This patch adds print slips to self checkout. To Test: Sign in to self checkout. Enter a barcode and click submit. You should be prompted with a message asking if you would like a receipt. If you click OK you should be taken to the page with the receipt. If you click Cancel you should not see the reciept and your item should check out. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 --- Comment #1 from Elliott Davis --- Created attachment 10648 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10648&action=edit Adds a print receipt to Self Checkout To Test: Log in to self checkout Enter a barcode and click submit You will be asked if you would like a receipt If you click ok you should be taken to the print receipt page and the item should check out if you click cancel the item should be checked out -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Elliott Davis changed: What|Removed |Added CC||elli...@bywatersolutions.co ||m Assignee|savitra.sir...@osslabs.biz |elli...@bywatersolutions.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8033] add print receipt option to Koha self-check
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8033 Savitra Sirohi changed: What|Removed |Added Status|NEW |In Discussion CC||savitra.sir...@osslabs.biz Assignee|koha.sek...@gmail.com |savitra.sir...@osslabs.biz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
