[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

--- Comment #123 from Katrin Fischer  ---
Hi Nicole,

3 spots it shows are:

Staff
- subscription detail page, issues tab
- serial collection page

OPAC
- full history

There was some discussion about where else it should show - so there is
probably some room for improvement :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Nicole C. Engard  changed:

   What|Removed |Added

 CC||neng...@gmail.com

--- Comment #122 from Nicole C. Engard  ---
Created attachment 45469
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45469=edit
serials area where text shows

I'm documenting this and am wondering where the text displays other than in the
serials module. Shouldn't is show in the holdings area?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #121 from Tomás Cohen Arazi  ---
Patches pushed to master.

Thanks Julian!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

--- Comment #115 from Katrin Fischer  ---
Created attachment 43667
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43667=edit
[PASSED QA] Bug 8296: Follow up for QA

1 redefined variable removed

Signed-off-by: Julian Maurice 
Signed-off-by: Cedric Vita 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #41830|0   |1
is obsolete||
  Attachment #41831|0   |1
is obsolete||
  Attachment #41832|0   |1
is obsolete||
  Attachment #41833|0   |1
is obsolete||
  Attachment #41834|0   |1
is obsolete||
  Attachment #41835|0   |1
is obsolete||
  Attachment #41836|0   |1
is obsolete||

--- Comment #113 from Katrin Fischer  ---
Created attachment 43665
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43665=edit
[PASSED QA] Bug 8296: Add descriptive (text) published date field for serials

Add a new field serial.publisheddatetext for displaying published date
in another format that dateformat syspref permit.

Signed-off-by: Cedric Vita 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

--- Comment #114 from Katrin Fischer  ---
Created attachment 43666
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43666=edit
[PASSED QA] Bug 8296: set input maxlength to the same of sql field length

Signed-off-by: Cedric Vita 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #120 from Katrin Fischer  ---
I have to admit, I am not sure about the use case for this patch, but it works
as described and shouldn't affect the existing workflows.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

--- Comment #119 from Katrin Fischer  ---
Created attachment 43671
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43671=edit
[PASSED QA] Bug 8296: Follow-up - don't display publisheddate when
publisheddatetext is empty

To test:
- make sure you have a subscription where only some fields have a published
date (text) set
- check the subscription detail page, issues tab
- check the serial collection page
- both pages should show an empty field, when published date (text) has not
been set

Signed-off-by: Julian Maurice 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

--- Comment #117 from Katrin Fischer  ---
Created attachment 43669
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43669=edit
[PASSED QA] Bug 8296: Display publisheddatetext in OPAC bootstrap theme

and remove modifications for OPAC prog theme

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

--- Comment #118 from Katrin Fischer  ---
Created attachment 43670
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43670=edit
[PASSED QA] Bug 8296: Fix unit tests in t/db_dependent/Serials.t

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

--- Comment #116 from Katrin Fischer  ---
Created attachment 43668
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43668=edit
[PASSED QA] Bug 8296: Don't fill text field automatically

+ minor fixes:
  * Add bug number to updatedatabase
  * Fix colspan in serials-edit.tt

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

--- Comment #112 from Katrin Fischer  ---
(In reply to Julian Maurice from comment #111)
> (In reply to Katrin Fischer from comment #103)
> > Hi Julian, 
> > 
> > I think the common "entry page" to subscriptions for parons in the OPAC is
> > opac-detail > subscriptions tab. This view is labelled as 'Normal view' when
> > you look at it from the the full history page. I think adding the
> > information there the same way we have it on the full history page would
> > make sense to me. 
> 
> It appears that the date shown on this page is the 'planneddate' which is
> the date of reception. Should we change that and display the 'publisheddate'
> instead ?

Sorry to come back to this so late - I feel like it is a little weird to not
display in the OPAC, but not sure right now how best to fix. I will look at the
patches again.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #35865|0   |1
is obsolete||

--- Comment #104 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 41830
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41830action=edit
Bug 8296: Add descriptive (text) published date field for serials

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #35868|0   |1
is obsolete||

--- Comment #107 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 41833
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41833action=edit
Bug 8296: Don't fill text field automatically

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #35869|0   |1
is obsolete||

--- Comment #108 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 41834
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41834action=edit
Bug 8296: Display publisheddatetext in OPAC bootstrap theme

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #35866|0   |1
is obsolete||

--- Comment #105 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 41831
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41831action=edit
Bug 8296: set input maxlength to the same of sql field length

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #35867|0   |1
is obsolete||

--- Comment #106 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 41832
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41832action=edit
Bug 8296: Follow up for QA

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #35871|0   |1
is obsolete||

--- Comment #110 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 41836
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41836action=edit
Bug 8296: Follow-up - don't display publisheddate when publisheddatetext is
empty

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #111 from Julian Maurice julian.maur...@biblibre.com ---
(In reply to Katrin Fischer from comment #103)
 Hi Julian, 
 
 I think the common entry page to subscriptions for parons in the OPAC is
 opac-detail  subscriptions tab. This view is labelled as 'Normal view' when
 you look at it from the the full history page. I think adding the
 information there the same way we have it on the full history page would
 make sense to me. 

It appears that the date shown on this page is the 'planneddate' which is the
date of reception. Should we change that and display the 'publisheddate'
instead ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #35870|0   |1
is obsolete||

--- Comment #109 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 41835
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41835action=edit
Bug 8296: Fix unit tests in t/db_dependent/Serials.t

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #103 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Julian, 

I think the common entry page to subscriptions for parons in the OPAC is
opac-detail  subscriptions tab. This view is labelled as 'Normal view' when
you look at it from the the full history page. I think adding the information
there the same way we have it on the full history page would make sense to me. 

I am a bit torn about the feature still, but I think with that follow-up it
would make enough sense to me to pass QA. Patches tested ok so far. :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de
   |y.org   |

--- Comment #101 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Julian, 

I have started on this and so far it looks good, but I am a little confused
about the general idea of this:

- Could you maybe give some more explanation about the use case?
- Why do we display it almost everywhere in staff, but only on a very hidden
page in the OPAC?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

--- Comment #102 from Julian Maurice julian.maur...@biblibre.com ---
1/ The initial need was to describe the date in a more human-friendly format.
For instance, if periodicity is once every two months, instead of 2015-01-01
we can have 2015 January-February

2/ I don't know very well the subscriptions part in OPAC. I can add this
information in other pages as well, if you tell me where :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

--- Comment #100 from Julian Maurice julian.maur...@biblibre.com ---
Hi Katrin,

Your patch is ok, no problem at all, it is already signed off ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

--- Comment #99 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Going to work on this next. Julian - could you check the last patch if you like
or hate it? I have no problem with either, but would be good to have your
feedback.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

--- Comment #91 from Julian Maurice julian.maur...@biblibre.com ---
Why is the bug status Failed QA ? Shouldn't it be Needs Signoff ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #33009|0   |1
is obsolete||

--- Comment #95 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 35868
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35868action=edit
Bug 8296: Don't fill text field automatically

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #33010|0   |1
is obsolete||

--- Comment #96 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 35869
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35869action=edit
Bug 8296: Display publisheddatetext in OPAC bootstrap theme

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #33006|0   |1
is obsolete||

--- Comment #92 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 35865
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35865action=edit
Bug 8296: Add descriptive (text) published date field for serials

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #33011|0   |1
is obsolete||

--- Comment #97 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 35870
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35870action=edit
Bug 8296: Fix unit tests in t/db_dependent/Serials.t

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #33012|0   |1
is obsolete||

--- Comment #98 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 35871
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35871action=edit
Bug 8296: Follow-up - don't display publisheddate when publisheddatetext is
empty

Rebased on master and signed off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #33008|0   |1
is obsolete||

--- Comment #94 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 35867
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35867action=edit
Bug 8296: Follow up for QA

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #33007|0   |1
is obsolete||

--- Comment #93 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 35866
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35866action=edit
Bug 8296: set input maxlength to the same of sql field length

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

--- Comment #90 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
After 'sleeping over it' I think the duplication of the 'published date' into
'published date (text)' was maybe done for sorting purposes?

Maybe we could make it visually more clear, using a different text color
(grey?) for a published date in a published date (text) column?

I hope this makes any sense. Feel free to dislike and obsolete my follow-up :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #81 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Hi Julian,

I have a few questions about this:

For the OPAC, you only change the full history:
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-full-serial-issues.tt 

Why not the normal one on opac-detail.tt?

If we only change one view, the displayed dates seem to be inconsistent.


I am also wondering about you display the publisheddate in staff, when there is
nothing set for publisheddate. This way it's really hard to see in the lists,
where you have entered custom data and where not.

I am suggesting to change that and only display publisheddatetext when we have
both columns next to each other. 

I will attach a patch with that suggestion - but not sure what to do about the
OPAC.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

--- Comment #82 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Ah, also applying rebaesd patches - I removed the prog theme OPAC files.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #32903|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #32904|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #32905|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #32907|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #32906|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

  Attachment #32908|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

--- Comment #83 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 33006
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33006action=edit
Bug 8296: Add descriptive (text) published date field for serials

Add a new field serial.publisheddatetext for displaying published date
in another format that dateformat syspref permit.

Signed-off-by: Cedric Vita cedric.v...@dracenie.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

--- Comment #84 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 33007
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33007action=edit
Bug 8296: set input maxlength to the same of sql field length

Signed-off-by: Cedric Vita cedric.v...@dracenie.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

--- Comment #87 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 33010
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33010action=edit
Bug 8296: Display publisheddatetext in OPAC bootstrap theme

and remove modifications for OPAC prog theme

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

--- Comment #86 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 33009
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33009action=edit
Bug 8296: Don't fill text field automatically

+ minor fixes:
  * Add bug number to updatedatabase
  * Fix colspan in serials-edit.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

--- Comment #85 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 33008
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33008action=edit
Bug 8296: Follow up for QA

1 redefined variable removed

Signed-off-by: Julian Maurice julian.maur...@biblibre.com
Signed-off-by: Cedric Vita cedric.v...@dracenie.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

--- Comment #88 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 33011
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33011action=edit
Bug 8296: Fix unit tests in t/db_dependent/Serials.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

--- Comment #89 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
Created attachment 33012
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=33012action=edit
Bug 8296: Follow-up - don't display publisheddate when publisheddatetext is
empty

To test:
- make sure you have a subscription where only some fields have a published
date (text) set
- check the subscription detail page, issues tab
- check the serial collection page
- both pages should show an empty field, when published date (text) has not
been set

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #30380|0   |1
is obsolete||

--- Comment #76 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 32904
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32904action=edit
Bug 8296: set input maxlength to the same of sql field length

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #30483|0   |1
is obsolete||

--- Comment #77 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 32905
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32905action=edit
Bug 8296: Follow up for QA

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #30485|0   |1
is obsolete||

--- Comment #78 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 32906
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32906action=edit
Bug 8296: Don't fill text field automatically

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

--- Comment #74 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I am sorry, but I am having problems to get this to apply :( 
I fixed a conflict in the first patch but then got stuck later on number 5.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

--- Comment #73 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 32124
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=32124action=edit
Bug 8296: Fix unit tests in t/db_dependent/Serials.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #72 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I've applied the patches, ran the database update and then tried to run the
unit tests specific for serials, sadly, they are failing with these patches,
but are ok on master:

Test Summary Report
---
t/db_dependent/Serials.t (Wstat: 1024 Tests: 44 Failed: 4)
  Failed tests:  39-40, 42-43
  Non-zero exit status: 4


The QA script was ok, no problems there.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   Patch complexity|--- |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

  Attachment #30381|0   |1
is obsolete||

--- Comment #69 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 30483
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30483action=edit
Bug 8296: Follow up for QA

1 redefined variable removed

Signed-off-by: Julian Maurice julian.maur...@biblibre.com
Signed-off-by: Cedric Vita cedric.v...@dracenie.com
Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

  Attachment #30383|0   |1
is obsolete||

--- Comment #70 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 30484
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30484action=edit
Bug 8296: Display publisheddatetext in OPAC bootstrap theme

and remove modifications for OPAC prog theme

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

  Attachment #30382|0   |1
is obsolete||

--- Comment #71 from Chris Cormack ch...@bigballofwax.co.nz ---
Created attachment 30485
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30485action=edit
Bug 8296: Don't fill text field automatically

+ minor fixes:
  * Add bug number to updatedatabase
  * Fix colspan in serials-edit.tt

Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #28974|0   |1
is obsolete||

--- Comment #64 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 30379
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30379action=edit
Bug 8296: Add descriptive (text) published date field for serials

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #28976|0   |1
is obsolete||

--- Comment #66 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 30381
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30381action=edit
Bug 8296: Follow up for QA

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #28975|0   |1
is obsolete||

--- Comment #65 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 30380
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30380action=edit
Bug 8296: set input maxlength to the same of sql field length

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #28977|0   |1
is obsolete||

--- Comment #67 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 30382
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30382action=edit
Bug 8296: Don't fill text field automatically

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

--- Comment #68 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 30383
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=30383action=edit
Bug 8296: Display publisheddatetext in OPAC bootstrap theme

and remove modifications for OPAC prog theme

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #22727|0   |1
is obsolete||

--- Comment #59 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 28974
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28974action=edit
Bug 8296: Add descriptive (text) published date field for serials

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #22728|0   |1
is obsolete||

--- Comment #60 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 28975
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28975action=edit
Bug 8296: set input maxlength to the same of sql field length

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #22729|0   |1
is obsolete||

--- Comment #61 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 28976
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28976action=edit
Bug 8296: Follow up for QA

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #22730|0   |1
is obsolete||

--- Comment #62 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 28977
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28977action=edit
Bug 8296: Don't fill text field automatically

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Koha Team Lyon 3 k...@univ-lyon3.fr changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #63 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
I add a text formatted date in the Serial collection page like this :

Date published Date published (text) 
01/04/2014 mai 2014 

but the date at the opac (moredetails/fullhistory/date column) remains
01/04/2014.

Olivier Crouzet

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Koha Team Lyon 3 k...@univ-lyon3.fr changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||k...@univ-lyon3.fr

--- Comment #58 from Koha Team Lyon 3 k...@univ-lyon3.fr ---
h1Something went wrong !/h1Applying: Bug 8296: Add descriptive (text)
published date field for serials Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging C4/Serials.pm
CONFLICT (content): Merge conflict in C4/Serials.pm Auto-merging
installer/data/mysql/kohastructure.sql
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt
Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-full-serial-issues.tt
Auto-merging misc/cronjobs/serialsUpdate.pl Auto-merging
serials/serials-collection.pl Failed to merge in the changes.
Patch failed at 0001 Bug 8296: Add descriptive (text) published date field for
serials When you have resolved this problem run git bz apply --continue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #21342|0   |1
is obsolete||

--- Comment #55 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 22728
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22728action=edit
[SIGNED-OFF] Bug 8296: set input maxlength to the same of sql field length

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #21341|0   |1
is obsolete||

--- Comment #54 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 22727
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22727action=edit
[SIGNED-OFF] Bug 8296: Add descriptive (text) published date field for serials

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #21343|0   |1
is obsolete||

--- Comment #56 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 22729
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22729action=edit
[SIGNED-OFF] Bug 8296: Follow up for QA

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #21344|0   |1
is obsolete||

--- Comment #57 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 22730
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=22730action=edit
Bug 8296: Don't fill text field automatically

Rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

I'm just a bot git...@bugs.koha-community.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
   When did the bot|2013-09-24 00:00:00 |2013-10-25
last check this||

--- Comment #53 from I'm just a bot git...@bugs.koha-community.org ---
Applying: Bug 8296: Add descriptive (text) published date field for serials
Using index info to reconstruct a base tree...
MC4/Serials.pm
Minstaller/data/mysql/kohastructure.sql
Minstaller/data/mysql/updatedatabase.pl
Mkoha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt
Mmisc/cronjobs/serialsUpdate.pl
Falling back to patching base and 3-way merge...
Auto-merging misc/cronjobs/serialsUpdate.pl
CONFLICT (content): Merge conflict in misc/cronjobs/serialsUpdate.pl
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging installer/data/mysql/kohastructure.sql
Auto-merging C4/Serials.pm
Patch failed at 0001 Bug 8296: Add descriptive (text) published date field for
serials
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run git am --continue.
If you prefer to skip this patch, run git am --skip instead.
To restore the original branch and stop patching, run git am --abort.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #18812|0   |1
is obsolete||

--- Comment #48 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 21342
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21342action=edit
[SIGNED-OFF] Bug 8296: set input maxlength to the same of sql field length

Signed-off-by: Cedric Vita cedric.v...@dracenie.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #18811|0   |1
is obsolete||

--- Comment #47 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 21341
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21341action=edit
[SIGNED-OFF] Bug 8296: Add descriptive (text) published date field for serials

Add a new field serial.publisheddatetext for displaying published date
in another format that dateformat syspref permit.

Signed-off-by: Cedric Vita cedric.v...@dracenie.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #18813|0   |1
is obsolete||

--- Comment #49 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 21343
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21343action=edit
[SIGNED-OFF] Bug 8296: Follow up for QA

1 redefined variable removed

Signed-off-by: Julian Maurice julian.maur...@biblibre.com
Signed-off-by: Cedric Vita cedric.v...@dracenie.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #19860|0   |1
is obsolete||

--- Comment #50 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 21344
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=21344action=edit
Bug 8296: Don't fill text field automatically

+ minor fixes:
  * Add bug number to updatedatabase
  * Fix colspan in serials-edit.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #51 from Julian Maurice julian.maur...@biblibre.com ---
All patches rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

I'm just a bot git...@bugs.koha-community.org changed:

   What|Removed |Added

   When did the bot||2013-09-24
last check this||

--- Comment #52 from I'm just a bot git...@bugs.koha-community.org ---
Patch applied cleanly, go forth and signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

I'm just a bot git...@bugs.koha-community.org changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||git...@bugs.koha-community.
   ||org

--- Comment #46 from I'm just a bot git...@bugs.koha-community.org ---
Applying: Bug 8296: Add descriptive (text) published date field for serials
Using index info to reconstruct a base tree...
MC4/Serials.pm
Minstaller/data/mysql/kohastructure.sql
Minstaller/data/mysql/updatedatabase.pl
Mkoha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt
Mkoha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt
Mkoha-tmpl/opac-tmpl/prog/en/modules/opac-full-serial-issues.tt
Mserials/serials-edit.pl
Falling back to patching base and 3-way merge...
Auto-merging serials/serials-edit.pl
Auto-merging koha-tmpl/opac-tmpl/prog/en/modules/opac-full-serial-issues.tt
CONFLICT (content): Merge conflict in
koha-tmpl/opac-tmpl/prog/en/modules/opac-full-serial-issues.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-edit.tt
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/serials/serials-collection.tt
Auto-merging installer/data/mysql/updatedatabase.pl
CONFLICT (content): Merge conflict in installer/data/mysql/updatedatabase.pl
Auto-merging installer/data/mysql/kohastructure.sql
Auto-merging C4/Serials.pm
Patch failed at 0001 Bug 8296: Add descriptive (text) published date field for
serials
The copy of the patch that failed is found in:
   /home/christopher/git/koha/.git/rebase-apply/patch
When you have resolved this problem, run git am --continue.
If you prefer to skip this patch, run git am --skip instead.
To restore the original branch and stop patching, run git am --abort.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #45 from Julian Maurice julian.maur...@biblibre.com ---
Hi Katrin, thank you for the review.
This patch fixes 1) 2) and 3)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

--- Comment #44 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 19860
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19860action=edit
Bug 8296: Don't fill text field automatically

+ minor fixes:
  * Add bug number to updatedatabase
  * Fix colspan in serials-edit.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 QA Contact|jonathan.dru...@biblibre.co |testo...@bugs.koha-communit
   |m   |y.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #43 from Katrin Fischer katrin.fisc...@bsz-bw.de ---
I have started testing this yesterday and after sleeping over it, there is
something that worries me:

1) After update, the new column publisheddatetext is empty in the database for
all existing issues, but when you receive new issues, the field is always
filled with the publisheddate if you don't change it manually. My feeling is,
that we should not fill the field, when there is no new information in it. 
Also, is it helpful if you have to delete the date first before you can type in
April 2013?

In the templates that would work nicely as they already fall back to the
publisheddate when the new field is empty:
[% newserialloo.publisheddatetext || newserialloo.publisheddate %]

2) If you are going to touch the patches - could you also add the bug number to
the updatedatabase?

3) The table in serials-edit.pl is a little broken, when you are adding items
for each issue. The colspan needs to be increased to 6 there now in the last
row.

td colspan=5
  a id=label[% serialslis.subscriptionid %]...
 Click to add item/a

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #16420|0   |1
is obsolete||

--- Comment #33 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 18796
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18796action=edit
Bug 8296: Add descriptive (text) published date field for serials

Add a new field serial.publisheddatetext for displaying published date
in another format that dateformat syspref permit.

Signed-off-by: Cedric Vita cedric.v...@dracenie.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #16421|0   |1
is obsolete||

--- Comment #34 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 18797
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18797action=edit
Bug 8296: set input maxlength to the same of sql field length

Signed-off-by: Cedric Vita cedric.v...@dracenie.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

  Attachment #16422|0   |1
is obsolete||

--- Comment #35 from M. de Rooy m.de.r...@rijksmuseum.nl ---
Created attachment 18798
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18798action=edit
Bug 8296: Follow up for QA

1 redefined variable removed

Signed-off-by: Julian Maurice julian.maur...@biblibre.com
Signed-off-by: Cedric Vita cedric.v...@dracenie.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

--- Comment #36 from M. de Rooy m.de.r...@rijksmuseum.nl ---
One warning, no complaints from qa-tools.
Argument  isn't numeric in numeric lt () at
/usr/share/koha/testclone/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt
line 241.
Seems not to be introduced by your patches, though.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

M. de Rooy m.de.r...@rijksmuseum.nl changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #37 from M. de Rooy m.de.r...@rijksmuseum.nl ---
I actually miss a test plan for this report.
I have the impresssion that the opac change is only visible under specific
circumstances (pref value and/or unimarc??)

This needs more information/documentation. Please add. Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

--- Comment #38 from M. de Rooy m.de.r...@rijksmuseum.nl ---
See this in the rebase of kohastructure:

+  `itemnumber` text default NULL,

Should not be reintroduced..

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #18797|0   |1
is obsolete||

--- Comment #40 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 18812
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18812action=edit
[SIGNED-OFF] Bug 8296: set input maxlength to the same of sql field length

Signed-off-by: Cedric Vita cedric.v...@dracenie.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8296] Add descriptive (text) published date field for serials

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8296

Julian Maurice julian.maur...@biblibre.com changed:

   What|Removed |Added

  Attachment #18796|0   |1
is obsolete||

--- Comment #39 from Julian Maurice julian.maur...@biblibre.com ---
Created attachment 18811
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18811action=edit
[SIGNED-OFF] Bug 8296: Add descriptive (text) published date field for serials

Add a new field serial.publisheddatetext for displaying published date
in another format that dateformat syspref permit.

Signed-off-by: Cedric Vita cedric.v...@dracenie.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/