[Koha-bugs] [Bug 8336] SIP Server does not process renewal transaction correctly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8336 Paul Poulain paul.poul...@biblibre.com changed: What|Removed |Added Status|Passed QA |Pushed to Master CC||paul.poul...@biblibre.com Version|master |rel_3_8 --- Comment #7 from Paul Poulain paul.poul...@biblibre.com --- Patch pushed to master (patch untested by me though) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8336] SIP Server does not process renewal transaction correctly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8336 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #8 from Chris Cormack ch...@bigballofwax.co.nz --- Pushed to 3.8.x, will be in 3.8.5 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8336] SIP Server does not process renewal transaction correctly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8336 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #12035|0 |1 is obsolete|| --- Comment #5 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 12260 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12260action=edit Bug 8336 Support Sip Renewal Transaction Renewals were being rejected for incorrect reasons Checking was being done against the wrong object Add more informative messages on failure Correctly set due_date for renewal response Avoid crashing the SIPServer because it handles RenewAll incorrectly Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8336] SIP Server does not process renewal transaction correctly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8336 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||ch...@bigballofwax.co.nz Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8336] SIP Server does not process renewal transaction correctly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8336 Mason James m...@kohaaloha.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||m...@kohaaloha.com QA Contact||m...@kohaaloha.com --- Comment #6 from Mason James m...@kohaaloha.com --- Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz $ koha-qa.pl patch looks good, passing QA… testing 1 commit(s) (applied to commit 2a60d49) * 551c673 Bug 8336 Support Sip Renewal Transaction C4/SIP/ILS.pm C4/SIP/ILS/Transaction/Renew.pm C4/SIP/ILS/Transaction/RenewAll.pm C4/SIP/Sip/MsgType.pm * C4/SIP/ILS.pmOK * C4/SIP/ILS/Transaction/Renew.pm OK * C4/SIP/ILS/Transaction/RenewAll.pm OK * C4/SIP/Sip/MsgType.pmOK -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8336] SIP Server does not process renewal transaction correctly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8336 Colin Campbell colin.campb...@ptfs-europe.com changed: What|Removed |Added Attachment #10567|0 |1 is obsolete|| --- Comment #3 from Colin Campbell colin.campb...@ptfs-europe.com --- Created attachment 12035 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=12035action=edit Revised Patch Cleaned up the code. Handle some cases better - rebased against current master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8336] SIP Server does not process renewal transaction correctly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8336 Colin Campbell colin.campb...@ptfs-europe.com changed: What|Removed |Added Priority|P5 - low|P1 - high Severity|enhancement |major --- Comment #4 from Colin Campbell colin.campb...@ptfs-europe.com --- Changed status to bug as without this patch the SIPServer crashes when faced with a RenewAll transaction. Also the current sip server reports to the client that it supports Renew and Renewall transactions but it does not and in ways that cause the client and/or server to fail. Tested by Staffordshire University with Talking Tech telephone renewals -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8336] SIP Server does not process renewal transaction correctly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8336 --- Comment #2 from Colin Campbell colin.campb...@ptfs-europe.com --- Tested by Staffordshire University with help from Talking Tech -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8336] SIP Server does not process renewal transaction correctly
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8336 Colin Campbell colin.campb...@ptfs-europe.com changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|koha-b...@lists.koha-commun |colin.campbell@ptfs-europe. |ity.org |com --- Comment #1 from Colin Campbell colin.campb...@ptfs-europe.com --- Created attachment 10567 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=10567action=edit Proposed Patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/