[Koha-bugs] [Bug 8387] Hide headings in tools when user has no permissions for any listed below
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8387 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to Stable|RESOLVED Resolution|--- |FIXED CC||fridolin.som...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8387] Hide headings in tools when user has no permissions for any listed below
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8387 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #10 from Lucas Gass --- backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8387] Hide headings in tools when user has no permissions for any listed below
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8387 Martin Renvoize changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #9 from Martin Renvoize --- Pushed to 18.11.x for 18.11.04.. it's great seeing these old bugs getting some love! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8387] Hide headings in tools when user has no permissions for any listed below
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8387 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #8 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8387] Hide headings in tools when user has no permissions for any listed below
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8387 Katrin Fischer changed: What|Removed |Added Blocks||9422 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9422 [Bug 9422] Patron picture uploader ignores patronimages syspref -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8387] Hide headings in tools when user has no permissions for any listed below
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8387 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #7 from Martin Renvoize --- Just done a quick test to check and it looks good to my untrained eye.. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8387] Hide headings in tools when user has no permissions for any listed below
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8387 Martin Renvoize changed: What|Removed |Added Attachment #84767|0 |1 is obsolete|| --- Comment #6 from Martin Renvoize --- Created attachment 84880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84880=edit Bug 8387: Hide headings in tools when user has no permissions for any listed below The headings for each column on the tools page will show, even if the user has no permission for any tool below it. This patch tries to correct this. To test: - Try various combinations of tool permissions - On the tools module start page and for the tools sidebar visible on the left on a tool's page: - Make sure headings don't show when you have no permissions for any of the tools listed below - Make sure headings show correctly if you have one or many of the tools permissions needed Signed-off-by: Owen Leonard The qa tool gives some warnings but I think they can be considered false positives. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8387] Hide headings in tools when user has no permissions for any listed below
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8387 --- Comment #5 from Martin Renvoize --- Thanks Katrin :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8387] Hide headings in tools when user has no permissions for any listed below
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8387 --- Comment #4 from Katrin Fischer --- I only added "IF" statements, so I think that should not affect translations as those don't get translated, especially as they are not inside an translated HTML element. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8387] Hide headings in tools when user has no permissions for any listed below
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8387 Martin Renvoize changed: What|Removed |Added CC||bgkrie...@gmail.com, ||indr...@l2c2.co.in -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8387] Hide headings in tools when user has no permissions for any listed below
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8387 --- Comment #3 from Martin Renvoize --- Any translation guru's in the house? Will the QA Script failure mentioned here cause a regression of the likes of bug 18675? `forbidden pattern: Do not use line breaks inside template tags (bug 18675) (line 48)` -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8387] Hide headings in tools when user has no permissions for any listed below
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8387 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com, ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8387] Hide headings in tools when user has no permissions for any listed below
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8387 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8387] Hide headings in tools when user has no permissions for any listed below
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8387 Owen Leonard changed: What|Removed |Added Attachment #84757|0 |1 is obsolete|| --- Comment #2 from Owen Leonard --- Created attachment 84767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84767=edit Bug 8387: Hide headings in tools when user has no permissions for any listed below The headings for each column on the tools page will show, even if the user has no permission for any tool below it. This patch tries to correct this. To test: - Try various combinations of tool permissions - On the tools module start page and for the tools sidebar visible on the left on a tool's page: - Make sure headings don't show when you have no permissions for any of the tools listed below - Make sure headings show correctly if you have one or many of the tools permissions needed Signed-off-by: Owen Leonard The qa tool gives some warnings but I think they can be considered false positives. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8387] Hide headings in tools when user has no permissions for any listed below
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8387 --- Comment #1 from Katrin Fischer --- Created attachment 84757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84757=edit Bug 8387: Hide headings in tools when user has no permissions for any listed below The headings for each column on the tools page will show, even if the user has no permission for any tool below it. This patch tries to correct this. To test: - Try various combinations of tool permissions - On the tools module start page and for the tools sidebar visible on the left on a tool's page: - Make sure headings don't show when you have no permissions for any of the tools listed below - Make sure headings show correctly if you have one or many of the tools permissions needed -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8387] Hide headings in tools when user has no permissions for any listed below
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8387 Katrin Fischer changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 8387] Hide headings in tools when user has no permissions for any listed below
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8387 Katrin Fischer changed: What|Removed |Added Summary|Hide labels when no links |Hide headings in tools when |exist under them|user has no permissions for ||any listed below -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
