[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Fridolin Somers  changed:

   What|Removed |Added

 CC||fridolin.som...@biblibre.co
   ||m

--- Comment #55 from Fridolin Somers  ---
Enhancement not pushed to 20.11.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||27831

--- Comment #54 from Jonathan Druart  
---
(In reply to Jonathan Druart from comment #49)
> However I found an inconsistency. Those patches introduced
> Koha::AuthSubfieldStructure[s], but we already had
> Koha::Authority::Subfield[s].
> It also introduced Koha::MarcSubfieldStructure[s].
> 
> What about:
> Koha::Framework::Biblio::Subfield[s]
> Koha::Framework::Authority::Subfield[s]
> 
> Then later:
> Koha::Framework::Biblio::Tag[s]
> Koha::Framework::Authority::Tag[s]
> 
> Or... Koha::MARC::Biblio::Subfield? Koha::MARCStructure::Biblio::Subfield?
> 
> Or... Koha::Framework::Subfield::Biblio and
> Koha::FrameworkSubfield::Authority that would inherit from
> Koha::Framework::Subfield. But then we need to drop the plural forms.

See bug 27831


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27831
[Bug 27831] Object Name Inconsistencies
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

--- Comment #53 from Jonathan Druart  
---
Last 2 patches pushed to master.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

--- Comment #52 from Jonathan Druart  
---
Created attachment 117478
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117478=edit
Bug 8976: (follow-up) Code cleaning

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

--- Comment #51 from Martin Renvoize  ---
Followup reviewed and tested.. works well for me.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

--- Comment #50 from Jonathan Druart  
---
Created attachment 117477
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117477=edit
Bug 8976: Use existing Koha::Authority::Subfield[s]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Caroline Cyr La Rose  changed:

   What|Removed |Added

   Keywords||Manual

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Jonathan Druart  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com,
   ||n...@bywatersolutions.com

--- Comment #49 from Jonathan Druart  
---
Hum, there is a test failing that may be related to this, but I don't recreate
locally (D9_My8):

16:25:53 koha_1   | #   Failed test 'Module
Koha::AuthSubfieldStructures should have koha_object[s]_class method if needed'
16:25:53 koha_1   | #   at t/db_dependent/TestBuilder.t line 402.
16:25:53 koha_1   | #  got: 'Can't locate object method
"_new_from_dbic" via package "Koha::Authority::Subfield" (perhaps you forgot to
load "Koha::Authority::Subfield"?) at /kohadevbox/koha/Koha/Object.pm line 335.
16:25:53 koha_1   | # '
16:25:53 koha_1   | # expected: ''
16:26:47 koha_1   | # Looks like you failed 1 test of 526.
16:26:47 koha_1   | 
16:26:47 koha_1   | #   Failed test 'Test all classes'
16:26:47 koha_1   | #   at t/db_dependent/TestBuilder.t line 413.
16:26:48 koha_1   | # Looks like you failed 1 test of 5.



However I found an inconsistency. Those patches introduced
Koha::AuthSubfieldStructure[s], but we already had
Koha::Authority::Subfield[s].
It also introduced Koha::MarcSubfieldStructure[s].

What about:
Koha::Framework::Biblio::Subfield[s]
Koha::Framework::Authority::Subfield[s]

Then later:
Koha::Framework::Biblio::Tag[s]
Koha::Framework::Authority::Tag[s]

Or... Koha::MARC::Biblio::Subfield? Koha::MARCStructure::Biblio::Subfield?

Or... Koha::Framework::Subfield::Biblio and Koha::FrameworkSubfield::Authority
that would inherit from Koha::Framework::Subfield. But then we need to drop the
plural forms.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

--- Comment #48 from Jonathan Druart  
---
Pushed to master for 21.05, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||21.05.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||27775


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27775
[Bug 27775] Add hint about drag and drop feature on framework subfield edit
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

--- Comment #47 from Tomás Cohen Arazi  ---
I love this feature.

I tested all the use cases and things work as expected. Specially, respecting
existing auth/biblio subfield orderings. Changing the framework preserves
ordering as well.

The only thing this lacks, is some visible explanation about the drag and drop
feature. I will file a dependent bug requesting that added.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

--- Comment #46 from Tomás Cohen Arazi  ---
Created attachment 117276
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117276=edit
Bug 8976: (QA follow-up) Trivial POD fixes

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

--- Comment #45 from Tomás Cohen Arazi  ---
Created attachment 117275
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117275=edit
Bug 8976: (QA follow-up) Add a better feature decription

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

--- Comment #44 from Tomás Cohen Arazi  ---
Created attachment 117274
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117274=edit
Bug 8976: DBIC schema changes

Sponsored-by: Orex Digital

Signed-off-by: Michal Denar 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

--- Comment #43 from Tomás Cohen Arazi  ---
Created attachment 117273
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117273=edit
Bug 8976: Code cleaning

It was tricky to write the previous patch so I decided to clean the
ground (a bit) for later, taking advantage of having people who are
going to test the whole area.
We can move it to its own bug report if QA wants to.

Sponsored-by: Orex Digital

Signed-off-by: Michal Denar 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

--- Comment #42 from Tomás Cohen Arazi  ---
Created attachment 117272
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117272=edit
Bug 8976: Add Koha::AuthSubfieldStructure[s]

Sponsored-by: Orex Digital

Signed-off-by: Michal Denar 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

--- Comment #41 from Tomás Cohen Arazi  ---
Created attachment 117271
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117271=edit
Bug 8976: Change for the item forms

Sponsored-by: Orex Digital

Signed-off-by: Michal Denar 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

--- Comment #40 from Tomás Cohen Arazi  ---
Created attachment 117270
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117270=edit
Bug 8976: Sort subfields for authority records

Same patch for the authority frameworks/records

Sponsored-by: Orex Digital

Signed-off-by: Michal Denar 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

--- Comment #39 from Tomás Cohen Arazi  ---
Created attachment 117269
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117269=edit
Bug 8976: Add the ability to sort subfields for the MARC frameworks

This new enhancement adds the ability to change the default order the
subfields.

Both bibliographic and authority MARC subfield structure are taken into
account. And so the item edition as well (in the different screens when
item can be added/edited).

This will answer the following needs that have been listed in the
comments of the bug report:
- $i in 7xx fields should be the first subfield in the sequence
- 300 fields are sorted number first when cataloguers enter the letter fields
first
- 100 field, it's commonly $a, $q, $d.

Test plan:
1. Edit a MARC frameworks, field 300
2. Resort the subfield (drag and drop the tab of the subfield) as you
like
3. Save
=> Notice that the list of fields are displayed following the order you
chose
4. Edit it again
=> The order is correctly kept!
5. Create a new bibliographic record
6. Notice that the subfields are order in the same sequence
7. Fill different subfields, not all
8. Save, edit again
9. Note that the subfields that have been filled are listed first, then
the empty ones. But the sequence defined at the framework level is kept.
10. Do the same for an authority framework and create/edit an authority
record
11. Modify item (952) subfields order
12. Create an item and confirm that the order is correct
13. Modify the ACQ framework, 952, modify the order of the subfield
14. Create a new order and confirm that the item form has the subfield
ordered following the sequence defined at the framework level

QA: Note that this patch is about bibliographic records only, next
patches deal with authotiries and items.

Sponsored-by: Orex Digital

Signed-off-by: Michal Denar 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

--- Comment #38 from Tomás Cohen Arazi  ---
Created attachment 117268
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117268=edit
Bug 8976: Add marc_subfield_structure.display_order

Sponsored-by: Orex Digital

Signed-off-by: Michal Denar 
Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #117151|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #117150|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #117149|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #117148|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #117147|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #117153|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Attachment #117152|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #114498|0   |1
is obsolete||

--- Comment #37 from Jonathan Druart  
---
Created attachment 117153
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117153=edit
Bug 8976: DBIC schema changes

Sponsored-by: Orex Digital

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #114497|0   |1
is obsolete||

--- Comment #36 from Jonathan Druart  
---
Created attachment 117152
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117152=edit
Bug 8976: Code cleaning

It was tricky to write the previous patch so I decided to clean the
ground (a bit) for later, taking advantage of having people who are
going to test the whole area.
We can move it to its own bug report if QA wants to.

Sponsored-by: Orex Digital

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #114496|0   |1
is obsolete||

--- Comment #35 from Jonathan Druart  
---
Created attachment 117151
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117151=edit
Bug 8976: Add Koha::AuthSubfieldStructure[s]

Sponsored-by: Orex Digital

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #114495|0   |1
is obsolete||

--- Comment #34 from Jonathan Druart  
---
Created attachment 117150
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117150=edit
Bug 8976: Change for the item forms

Sponsored-by: Orex Digital

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #114494|0   |1
is obsolete||

--- Comment #33 from Jonathan Druart  
---
Created attachment 117149
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117149=edit
Bug 8976: Sort subfields for authority records

Same patch for the authority frameworks/records

Sponsored-by: Orex Digital

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #114493|0   |1
is obsolete||

--- Comment #32 from Jonathan Druart  
---
Created attachment 117148
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117148=edit
Bug 8976: Add the ability to sort subfields for the MARC frameworks

This new enhancement adds the ability to change the default order the
subfields.

Both bibliographic and authority MARC subfield structure are taken into
account. And so the item edition as well (in the different screens when
item can be added/edited).

This will answer the following needs that have been listed in the
comments of the bug report:
- $i in 7xx fields should be the first subfield in the sequence
- 300 fields are sorted number first when cataloguers enter the letter fields
first
- 100 field, it's commonly $a, $q, $d.

Test plan:
1. Edit a MARC frameworks, field 300
2. Resort the subfield (drag and drop the tab of the subfield) as you
like
3. Save
=> Notice that the list of fields are displayed following the order you
chose
4. Edit it again
=> The order is correctly kept!
5. Create a new bibliographic record
6. Notice that the subfields are order in the same sequence
7. Fill different subfields, not all
8. Save, edit again
9. Note that the subfields that have been filled are listed first, then
the empty ones. But the sequence defined at the framework level is kept.
10. Do the same for an authority framework and create/edit an authority
record
11. Modify item (952) subfields order
12. Create an item and confirm that the order is correct
13. Modify the ACQ framework, 952, modify the order of the subfield
14. Create a new order and confirm that the item form has the subfield
ordered following the sequence defined at the framework level

QA: Note that this patch is about bibliographic records only, next
patches deal with authotiries and items.

Sponsored-by: Orex Digital

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #114492|0   |1
is obsolete||

--- Comment #31 from Jonathan Druart  
---
Created attachment 117147
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=117147=edit
Bug 8976: Add marc_subfield_structure.display_order

Sponsored-by: Orex Digital

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Jonathan Druart  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Tomás Cohen Arazi  changed:

   What|Removed |Added

 QA Contact||tomasco...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Tomás Cohen Arazi  changed:

   What|Removed |Added

 CC||tomasco...@gmail.com
 Status|Signed Off  |Patch doesn't apply

--- Comment #30 from Tomás Cohen Arazi  ---
Can you please rebase?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||27526


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27526
[Bug 27526] Remove Mod/AddItemFromMarc from additem.pl
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

--- Comment #29 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #21)
> I agree with Jonathan in that we should never change the sequence of
> subfields in an existing bibliographic record - imported or already in Koha.
> MARC requires some subfields to be in a specific sequence that is not
> alphabetical or easy to guess.

Thanks for the confirmation.

> I am not sure how the item forms are build in several places - only that the
> ones in acq and serials are "different" and have not all features from the
> frameworks. Maybe worth checking those for a separate bug. But I think this
> one here aims mostly at bibliographic and authority records?

Items as well. Item add/mod form from cataloguing and acq are taken into
account in those patches.

Thanks Michal for the signoff!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

--- Comment #28 from Michal Denar  ---
Created attachment 114498
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114498=edit
Bug 8976: DBIC schema changes

Sponsored-by: Orex Digital

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

--- Comment #27 from Michal Denar  ---
Created attachment 114497
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114497=edit
Bug 8976: Code cleaning

It was tricky to write the previous patch so I decided to clean the
ground (a bit) for later, taking advantage of having people who are
going to test the whole area.
We can move it to its own bug report if QA wants to.

Sponsored-by: Orex Digital

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

--- Comment #26 from Michal Denar  ---
Created attachment 114496
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114496=edit
Bug 8976: Add Koha::AuthSubfieldStructure[s]

Sponsored-by: Orex Digital

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

--- Comment #25 from Michal Denar  ---
Created attachment 114495
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114495=edit
Bug 8976: Change for the item forms

Sponsored-by: Orex Digital

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

--- Comment #24 from Michal Denar  ---
Created attachment 114494
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114494=edit
Bug 8976: Sort subfields for authority records

Same patch for the authority frameworks/records

Sponsored-by: Orex Digital

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

--- Comment #23 from Michal Denar  ---
Created attachment 114493
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114493=edit
Bug 8976: Add the ability to sort subfields for the MARC frameworks

This new enhancement adds the ability to change the default order the
subfields.

Both bibliographic and authority MARC subfield structure are taken into
account. And so the item edition as well (in the different screens when
item can be added/edited).

This will answer the following needs that have been listed in the
comments of the bug report:
- $i in 7xx fields should be the first subfield in the sequence
- 300 fields are sorted number first when cataloguers enter the letter fields
first
- 100 field, it's commonly $a, $q, $d.

Test plan:
1. Edit a MARC frameworks, field 300
2. Resort the subfield (drag and drop the tab of the subfield) as you
like
3. Save
=> Notice that the list of fields are displayed following the order you
chose
4. Edit it again
=> The order is correctly kept!
5. Create a new bibliographic record
6. Notice that the subfields are order in the same sequence
7. Fill different subfields, not all
8. Save, edit again
9. Note that the subfields that have been filled are listed first, then
the empty ones. But the sequence defined at the framework level is kept.
10. Do the same for an authority framework and create/edit an authority
record
11. Modify item (952) subfields order
12. Create an item and confirm that the order is correct
13. Modify the ACQ framework, 952, modify the order of the subfield
14. Create a new order and confirm that the item form has the subfield
ordered following the sequence defined at the framework level

QA: Note that this patch is about bibliographic records only, next
patches deal with authotiries and items.

Sponsored-by: Orex Digital

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Michal Denar  changed:

   What|Removed |Added

 Attachment #114345|0   |1
is obsolete||
 Attachment #114346|0   |1
is obsolete||
 Attachment #114351|0   |1
is obsolete||
 Attachment #114352|0   |1
is obsolete||
 Attachment #114353|0   |1
is obsolete||
 Attachment #114354|0   |1
is obsolete||
 Attachment #114355|0   |1
is obsolete||

--- Comment #22 from Michal Denar  ---
Created attachment 114492
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114492=edit
Bug 8976: Add marc_subfield_structure.display_order

Sponsored-by: Orex Digital

Signed-off-by: Michal Denar 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Michal Denar  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

--- Comment #21 from Katrin Fischer  ---
I agree with Jonathan in that we should never change the sequence of subfields
in an existing bibliographic record - imported or already in Koha. MARC
requires some subfields to be in a specific sequence that is not alphabetical
or easy to guess.

I am not sure how the item forms are build in several places - only that the
ones in acq and serials are "different" and have not all features from the
frameworks. Maybe worth checking those for a separate bug. But I think this one
here aims mostly at bibliographic and authority records?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

--- Comment #20 from Jonathan Druart  
---
(In reply to Michal Denar from comment #19)
> Hi Jonathan,
> I'm testing this patch. I think the testplan works, but I found a problem if
> I pull record from z39.50. Subfields order doesn't correspond to framework
> settings. 

In that case we are pulling the record with the subfields ordered like they are
coming from the z3950 server. I don't think we should reprocess them when
importing them.

> What about the Batch item modification tool? Or the item editing form? How
> will we display the subfields order there? Alphabetically or based on the
> framework definition?

I am not sure I understand. How would the batch modification tools modify the
order of the subfields?

The item edition form is following the sequence of the framework.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Michal Denar  changed:

   What|Removed |Added

 CC||r...@rbit.cz

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

--- Comment #19 from Michal Denar  ---
Hi Jonathan,
I'm testing this patch. I think the testplan works, but I found a problem if I
pull record from z39.50. Subfields order doesn't correspond to framework
settings. 
What about the Batch item modification tool? Or the item editing form? How will
we display the subfields order there? Alphabetically or based on the framework
definition?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

--- Comment #18 from Jonathan Druart  
---
Some screenshots:

Before the sequence change: https://snipboard.io/7ACU0L.jpg
During the sequence change: https://snipboard.io/NUXbTY.jpg
After the sequence change:  https://snipboard.io/tbJYlO.jpg

List of the subfields with the new sequence: https://snipboard.io/v3V9tJ.jpg

Edition of a new bibliographic record: https://snipboard.io/RlEeV0.jpg

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Jonathan Druart  changed:

   What|Removed |Added

  Text to go in the||This new enhancement adds
  release notes||the ability to change the
   ||default order the
   ||subfields.
   ||
   ||Both
   ||bibliographic and authority
   ||MARC subfield structure are
   ||taken into account. And so
   ||the item edition as well.
   ||
   ||This will answer, for
   ||instance, the following
   ||needs:
   || - $i in 7xx fields
   ||should be the first
   ||subfield in the sequence
   || -
   ||300 fields are sorted
   ||number first when
   ||cataloguers enter the
   ||letter fields first
   || - 100
   ||field, it's commonly $a,
   ||$q, $d.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

--- Comment #17 from Jonathan Druart  
---
Created attachment 114355
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114355=edit
Bug 8976: DBIC schema changes

Sponsored-by: Orex Digital

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #114350|0   |1
is obsolete||

--- Comment #16 from Jonathan Druart  
---
Created attachment 114354
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114354=edit
Bug 8976: Code cleaning

It was tricky to write the previous patch so I decided to clean the
ground (a bit) for later, taking advantage of having people who are
going to test the whole area.
We can move it to its own bug report if QA wants to.

Sponsored-by: Orex Digital

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #114349|0   |1
is obsolete||

--- Comment #15 from Jonathan Druart  
---
Created attachment 114353
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114353=edit
Bug 8976: Add Koha::AuthSubfieldStructure[s]

Sponsored-by: Orex Digital

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #114348|0   |1
is obsolete||

--- Comment #14 from Jonathan Druart  
---
Created attachment 114352
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114352=edit
Bug 8976: Change for the item forms

Sponsored-by: Orex Digital

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Jonathan Druart  changed:

   What|Removed |Added

 Attachment #114347|0   |1
is obsolete||

--- Comment #13 from Jonathan Druart  
---
Created attachment 114351
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114351=edit
Bug 8976: Sort subfields for authority records

Same patch for the authority frameworks/records

Sponsored-by: Orex Digital

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

--- Comment #12 from Jonathan Druart  
---
Created attachment 114350
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114350=edit
Bug 8976: Code cleaning

It was tricky to write the previous patch so I decided to clean the
ground (a bit) for later, taking advantage of having people who are
going to test the whole area.
We can move it to its own bug report if QA wants to.

Sponsored-by: Orex Digital

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

--- Comment #11 from Jonathan Druart  
---
Created attachment 114349
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114349=edit
Bug 8976: Add Koha::AuthSubfieldStructure[s]

Sponsored-by: Orex Digital

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

--- Comment #10 from Jonathan Druart  
---
Created attachment 114348
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114348=edit
Bug 8976: Change for the item forms

Sponsored-by: Orex Digital

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

--- Comment #9 from Jonathan Druart  
---
Created attachment 114347
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114347=edit
Bug 8976: Sort subfields for authority records

Same patch for the authority frameworks/records

Sponsored-by: Orex Digital

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

--- Comment #7 from Jonathan Druart  
---
Created attachment 114345
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114345=edit
Bug 8976: Add marc_subfield_structure.display_order

Sponsored-by: Orex Digital

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

--- Comment #8 from Jonathan Druart  
---
Created attachment 114346
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=114346=edit
Bug 8976: Add the ability to sort subfields for the MARC frameworks

This new enhancement adds the ability to change the default order the
subfields.

Both bibliographic and authority MARC subfield structure are taken into
account. And so the item edition as well (in the different screens when
item can be added/edited).

This will answer the following needs that have been listed in the
comments of the bug report:
- $i in 7xx fields should be the first subfield in the sequence
- 300 fields are sorted number first when cataloguers enter the letter fields
first
- 100 field, it's commonly $a, $q, $d.

Test plan:
1. Edit a MARC frameworks, field 300
2. Resort the subfield (drag and drop the tab of the subfield) as you
like
3. Save
=> Notice that the list of fields are displayed following the order you
chose
4. Edit it again
=> The order is correctly kept!
5. Create a new bibliographic record
6. Notice that the subfields are order in the same sequence
7. Fill different subfields, not all
8. Save, edit again
9. Note that the subfields that have been filled are listed first, then
the empty ones. But the sequence defined at the framework level is kept.
10. Do the same for an authority framework and create/edit an authority
record
11. Modify item (952) subfields order
12. Create an item and confirm that the order is correct
13. Modify the ACQ framework, 952, modify the order of the subfield
14. Create a new order and confirm that the item form has the subfield
ordered following the sequence defined at the framework level

QA: Note that this patch is about bibliographic records only, next
patches deal with authotiries and items.

Sponsored-by: Orex Digital

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Jonathan Druart  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

--- Comment #6 from Michal Denar  ---
+1

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Jonathan Druart  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |jonathan.dru...@bugs.koha-c
   ||ommunity.org
 CC||ha...@orex.es,
   ||jonathan.dru...@bugs.koha-c
   ||ommunity.org
  Change sponsored?|--- |Sponsored
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Heather  changed:

   What|Removed |Added

 CC||heather_hernan...@nps.gov

--- Comment #5 from Heather  ---
This would be SO useful and would save me SO much time if I could set the order
of subfields in each MARC field in the framework for bibs, but especially for
authorities, since there is only a basic editor for authorities, and I spend a
lot of time going, "click, click, click, click..." to put the subfield in the
correct order, e.g., in a 100 field, it's commonly $a, $q, $d...

It would also encourage correct cataloging for those who use the basic bib
editor because the the most commonly correct order of subfields could be set at
the framework level, encouraging more correct input.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Christian Nelson  changed:

   What|Removed |Added

 CC||christian.nelson@tritonia.f
   ||i

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Michal Denar  changed:

   What|Removed |Added

 CC||blac...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Patrick Robitaille  changed:

   What|Removed |Added

 CC||patrick.robitaille@collecto
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

--- Comment #4 from Marjorie Barry-Vila  ---
*** Bug 17051 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-vila@collect
   ||o.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

--- Comment #3 from Lisette  ---
Today my cataloger mentioned that the 300 fields we put the RDA in are sorted
number first, then letters (3xx 1,3xx 2, 3xx a) but they enter the letter
fields first, then the number fields. 
Every time she opens a new record she fixes the order of all the 3xx fields and
she requested if we could change this.

Lisette

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Lisette  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

--- Comment #2 from Katrin Fischer  ---
Still valid in current versions - it would be nice to be able to change the
default sequence of subfields appearing in the editor. Another example is $i in
7xx fields which usually should be the first subfield in the sequence.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8976] Default sequence of subfields in cataloguing editor

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8976

Katrin Fischer  changed:

   What|Removed |Added

Summary|Sequence of subfield in |Default sequence of
   |Editor  |subfields in cataloguing
   ||editor

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/