subject:"\[Koha\-bugs\] \[Bug 8995\] Show OpenURL links in OPAC search results"

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2024-03-11 Thread bugzilla-daemon--- via Koha-bugs

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||36293


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36293
[Bug 36293] OpenURL shows on wrong entries in OPAC result list
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-09-16 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Tomás Cohen Arazi  changed:

   What|Removed |Added

 Blocks||23627


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23627
[Bug 23627] Koha::Biblio->get_coins too noisy if no 245$b
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-05-18 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Martin Renvoize  changed:

   What|Removed |Added

   Keywords|release-notes-needed,   |
   |rel_19_05_candidate |
  Text to go in the|This feature allows you to  |This new feature allows you
  release notes|link documents in your  |to link documents in your
   |catalogue to OpenURL|catalogue to an OpenURL
   |resolver and possibly   |resolver and possibly
   |enable your patrons to get  |enable your patrons to get
   |full texts in digital form. |full texts in digital form.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-05-08 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Martin Renvoize  changed:

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED
 Version(s)||19.05.00
released in||

--- Comment #142 from Martin Renvoize  ---
New feature will not be backported to 18.11.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-04-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

--- Comment #141 from Tomás Cohen Arazi  ---
Created attachment 89120
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89120=edit
Bug 8995: (QA follow-up) Mock required sysprefs in the tests

Signed-off-by: Tomas Cohen Arazi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-04-30 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Josef Moravec  changed:

   What|Removed |Added

  Text to go in the||This feature allows you to
  release notes||link documents in your
   ||catalogue to OpenURL
   ||resolver and possibly
   ||enable your patrons to get
   ||full texts in digital form.
   Severity|enhancement |new feature

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-04-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

--- Comment #140 from Katrin Fischer  ---
Maybe we should update to new feature?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-04-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #139 from Nick Clemens  ---
Awesome work all!

Pushed to master for 19.05

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-04-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

--- Comment #138 from Nick Clemens  ---
(In reply to Josef Moravec from comment #137)
> (In reply to Nick Clemens from comment #132)
> > I like this one a lot - can we get a squashed/clean version of these patches
> > just for readability sake?
> 
> Is this rebase OK for you Nick?

Indeed, thanks Josef!.  I was worried that changes don't work without XSLT, but
if I understand earlier comments they were remove as that view is deprecated.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-04-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

--- Comment #137 from Josef Moravec  ---
(In reply to Nick Clemens from comment #132)
> I like this one a lot - can we get a squashed/clean version of these patches
> just for readability sake?

Is this rebase OK for you Nick?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-04-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

--- Comment #135 from Josef Moravec  ---
Created attachment 89014
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89014=edit
Bug 8995: (follow-up) Add tests, move open_url/coins routines to Koha namespace

Test plan:
1) Ensure the COinS span tag is still included on this pages. You need
to look into html source and search for span tag with class 'Z3988',
   which has COinS string in title.
   Staff client:
   catalogue -> ISBDdetail
   catalogue -> MARCdetail
   catalogue -> detail
   virtualshelves -> shelves
OPAC (you should have COinSinOPACResults system preference enabled):
opac detail
opac search
opac shelves
2) Run tests:
prove t/Biblio.t t/db_dependent/Biblio.t t/db_dependent/Koha/Biblio.t

Signed-off-by: Magnus Enger 
Tested with all 9 current patches. Works as advertised, including
OPACURLOpenInNewWindow. If a record has no items, no OpenURL link
is displayed. All the suggested tests pass. I did not test with
XSLT turned off.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-04-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

--- Comment #134 from Josef Moravec  ---
Created attachment 89013
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89013=edit
Bug 8995: Add IGNORE to the INSERT statement

Signed-off-by: Magnus Enger 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-04-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

--- Comment #136 from Josef Moravec  ---
Created attachment 89015
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89015=edit
Bug 8995: (QA follow-up) Convert db update to perl

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-04-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Josef Moravec  changed:

   What|Removed |Added

  Attachment #88735|0   |1
is obsolete||
  Attachment #88736|0   |1
is obsolete||
  Attachment #88737|0   |1
is obsolete||
  Attachment #88738|0   |1
is obsolete||
  Attachment #88739|0   |1
is obsolete||
  Attachment #88740|0   |1
is obsolete||
  Attachment #88741|0   |1
is obsolete||
  Attachment #88742|0   |1
is obsolete||
  Attachment #88743|0   |1
is obsolete||
  Attachment #88744|0   |1
is obsolete||

--- Comment #133 from Josef Moravec  ---
Created attachment 89012
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89012=edit
Bug 8995: Show OpenURL links in OPAC search results

This patch use GetCOinS sub to provide an OpenURL link in OPAC search
results. It uses 4 new system preferences:
  - OpenURLinOPACResults: enable or disable this feature
  - OpenURLResolverURL: url of the openURL resolver
  - OpenURLText: text of the link
  - OpenURLImageLocation: image of the link

Link is displayed as an image if OpenURLImageLocation is defined, and as
text otherwise.
It works both with and without XSLT enabled.

Changes made to GetCOinSBiblio:

For 'journal':
- Title should be in rft.jtitle instead of rft.title
- rft.date, rft.aulast, rft.aufirst, rft.au, rft.pub and rft.pages have
  no meaning for a subscription, so they are simply removed from URL

This patch refactors GetCOinSBiblio, so the construction of URL is done
only at the end. This way we do not have ugly
  $var .= "$value"
in the function body.

Also use URI::Escape instead of custom regexps.

This development consider the value of syspref OPACURLOpenInNewWindow
when building the link.

Test plan:
1/ Enable syspref OPACShowOpenURL and put your OpenURL resolver URL in
OpenURLResolverURL syspref (if you don't have one, just fill it with
some fake URL, you'll have to check if OpenURL links are correct)
2/ If you want, set the other sysprefs OpenURLImageLocation and
OpenURLText
3/ Fill syspref OPACOpenURLItemTypes with some (not all) of your
item types.
4/ Empty sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay
5/ Go to OPAC and launch a search.
6/ Check you have in the results (near the title) the OpenURL link (only
for itemtypes that are in OPACOpenURLItemTypes).
Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of
the link is correct.
7/ Go to the detail page of one of those and check you have the OpenURL
link too. (Above tags)
Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of
the link is correct.
8/ Set sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay to
"default" and repeat steps 5 to 7

Signed-off-by: Paola Rossi 

Signed-off-by: Magnus Enger 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-04-26 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Nick Clemens  changed:

   What|Removed |Added

   Keywords||rel_19_05_candidate
 CC||n...@bywatersolutions.com

--- Comment #132 from Nick Clemens  ---
I like this one a lot - can we get a squashed/clean version of these patches
just for readability sake?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-04-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-04-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

--- Comment #131 from Martin Renvoize  ---
Good work team, well shepherded to completion.

This works well for me and I'm unable to find any regressions.. QA scripts all
pass (with the exception of the git manipulation issue where I converted the
.sql file to a .perl one as per the current RM's preference). 

Passing QA.. any chance of something for the release notes?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-04-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
  Attachment #88673|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-04-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

--- Comment #130 from Martin Renvoize  ---
Created attachment 88744
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88744=edit
Bug 8995: (QA follow-up) Convert db update to perl

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-04-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #88670|0   |1
is obsolete||

--- Comment #126 from Martin Renvoize  ---
Created attachment 88740
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88740=edit
Bug 8995: (follow-up) Move GetOpenURLResolverURL to Koha::Biblio->get_openurl

Signed-off-by: Magnus Enger 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-04-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #88669|0   |1
is obsolete||

--- Comment #125 from Martin Renvoize  ---
Created attachment 88739
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88739=edit
Bug 8995: (follow-up) Add POD for GetOpenURLResolverURL

Signed-off-by: Magnus Enger 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-04-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #88672|0   |1
is obsolete||

--- Comment #128 from Martin Renvoize  ---
Created attachment 88742
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88742=edit
Bug 8995: (follow-up) Add one more test fot get_openurl

Test plan:
prove t/db_dependent/Koha/Biblio.t

Signed-off-by: Magnus Enger 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-04-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

--- Comment #129 from Martin Renvoize  ---
Created attachment 88743
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88743=edit
Bug 8995: (follow-up) Take system preference item-level_itypes into account

Signed-off-by: Magnus Enger 
Tested with all 9 current patches. Works as advertised, including
OPACURLOpenInNewWindow. If a record has no items, no OpenURL link
is displayed. All the suggested tests pass. I did not test with
XSLT turned off.

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-04-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #88671|0   |1
is obsolete||

--- Comment #127 from Martin Renvoize  ---
Created attachment 88741
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88741=edit
Bug 8995: (follow-up) Move GetCOinSBiblio to Koha::Biblio->get_coins

Signed-off-by: Magnus Enger 

Test plan:
1) Ensure the COinS span tag is still included on this pages. You need
to look into html source and search for span tag with class 'Z3988',
   which has COinS string in title.
   Staff client:
   catalogue -> ISBDdetail
   catalogue -> MARCdetail
   catalogue -> detail
   virtualshelves -> shelves
OPAC (you should have COinSinOPACResults system preference enabled):
opac detail
opac search
opac shelves
2) Run tests:
prove t/Biblio.t t/db_dependent/Biblio.t t/db_dependent/Koha/Biblio.t

Signed-off-by: Magnus Enger 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-04-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #88666|0   |1
is obsolete||

--- Comment #122 from Martin Renvoize  ---
Created attachment 88736
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88736=edit
Bug 8995: Add IGNORE to the INSERT statement

Signed-off-by: Magnus Enger 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-04-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #88668|0   |1
is obsolete||

--- Comment #124 from Martin Renvoize  ---
Created attachment 88738
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88738=edit
Bug 8995: (follow-up) Added test

Signed-off-by: Magnus Enger 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-04-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #88667|0   |1
is obsolete||

--- Comment #123 from Martin Renvoize  ---
Created attachment 88737
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88737=edit
Bug 8995: (follow-up) Adapt to current codebase

Signed-off-by: Magnus Enger 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-04-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #88665|0   |1
is obsolete||

--- Comment #121 from Martin Renvoize  ---
Created attachment 88735
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88735=edit
Bug 8995: Show OpenURL links in OPAC search results

This patch use GetCOinS sub to provide an OpenURL link in OPAC search
results. It uses 4 new system preferences:
  - OpenURLinOPACResults: enable or disable this feature
  - OpenURLResolverURL: url of the openURL resolver
  - OpenURLText: text of the link
  - OpenURLImageLocation: image of the link

Link is displayed as an image if OpenURLImageLocation is defined, and as
text otherwise.
It works both with and without XSLT enabled.

Changes made to GetCOinSBiblio:

For 'journal':
- Title should be in rft.jtitle instead of rft.title
- rft.date, rft.aulast, rft.aufirst, rft.au, rft.pub and rft.pages have
  no meaning for a subscription, so they are simply removed from URL

This patch refactors GetCOinSBiblio, so the construction of URL is done
only at the end. This way we do not have ugly
  $var .= "$value"
in the function body.

Also use URI::Escape instead of custom regexps.

This development consider the value of syspref OPACURLOpenInNewWindow
when building the link.

Test plan:
1/ Enable syspref OPACShowOpenURL and put your OpenURL resolver URL in
OpenURLResolverURL syspref (if you don't have one, just fill it with
some fake URL, you'll have to check if OpenURL links are correct)
2/ If you want, set the other sysprefs OpenURLImageLocation and
OpenURLText
3/ Fill syspref OPACOpenURLItemTypes with some (not all) of your
item types.
4/ Empty sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay
5/ Go to OPAC and launch a search.
6/ Check you have in the results (near the title) the OpenURL link (only
for itemtypes that are in OPACOpenURLItemTypes).
Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of
the link is correct.
7/ Go to the detail page of one of those and check you have the OpenURL
link too. (Above tags)
Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of
the link is correct.
8/ Set sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay to
"default" and repeat steps 5 to 7

Signed-off-by: Paola Rossi 

Signed-off-by: Magnus Enger 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

--- Comment #120 from Josef Moravec  ---
Just rebased on master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Josef Moravec  changed:

   What|Removed |Added

  Attachment #86610|0   |1
is obsolete||

--- Comment #119 from Josef Moravec  ---
Created attachment 88673
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88673=edit
Bug 8995: (follow-up) Tak system preference item-level_itypes into account

Signed-off-by: Magnus Enger 
Tested with all 9 current patches. Works as advertised, including
OPACURLOpenInNewWindow. If a record has no items, no OpenURL link
is displayed. All the suggested tests pass. I did not test with
XSLT turned off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Josef Moravec  changed:

   What|Removed |Added

  Attachment #86609|0   |1
is obsolete||

--- Comment #118 from Josef Moravec  ---
Created attachment 88672
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88672=edit
Bug 8995: (follow-up) Add one more test fot get_openurl

Test plan:
prove t/db_dependent/Koha/Biblio.t

Signed-off-by: Magnus Enger 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Josef Moravec  changed:

   What|Removed |Added

  Attachment #86608|0   |1
is obsolete||

--- Comment #117 from Josef Moravec  ---
Created attachment 88671
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88671=edit
Bug 8995: (follow-up) Move GetCOinSBiblio to Koha::Biblio->get_coins

Signed-off-by: Magnus Enger 

Test plan:
1) Ensure the COinS span tag is still included on this pages. You need
to look into html source and search for span tag with class 'Z3988',
   which has COinS string in title.
   Staff client:
   catalogue -> ISBDdetail
   catalogue -> MARCdetail
   catalogue -> detail
   virtualshelves -> shelves
OPAC (you should have COinSinOPACResults system preference enabled):
opac detail
opac search
opac shelves
2) Run tests:
prove t/Biblio.t t/db_dependent/Biblio.t t/db_dependent/Koha/Biblio.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Josef Moravec  changed:

   What|Removed |Added

  Attachment #86607|0   |1
is obsolete||

--- Comment #116 from Josef Moravec  ---
Created attachment 88670
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88670=edit
Bug 8995: (follow-up) Move GetOpenURLResolverURL to Koha::Biblio->get_openurl

Signed-off-by: Magnus Enger 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Josef Moravec  changed:

   What|Removed |Added

  Attachment #86605|0   |1
is obsolete||

--- Comment #114 from Josef Moravec  ---
Created attachment 88668
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88668=edit
Bug 8995: (follow-up) Added test

Signed-off-by: Magnus Enger 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Josef Moravec  changed:

   What|Removed |Added

  Attachment #86606|0   |1
is obsolete||

--- Comment #115 from Josef Moravec  ---
Created attachment 88669
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88669=edit
Bug 8995: (follow-up) Add POD for GetOpenURLResolverURL

Signed-off-by: Magnus Enger 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Josef Moravec  changed:

   What|Removed |Added

  Attachment #86604|0   |1
is obsolete||

--- Comment #113 from Josef Moravec  ---
Created attachment 88667
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88667=edit
Bug 8995: (follow-up) Adapt to current codebase

Signed-off-by: Magnus Enger 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Josef Moravec  changed:

   What|Removed |Added

  Attachment #86602|0   |1
is obsolete||

--- Comment #111 from Josef Moravec  ---
Created attachment 88665
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88665=edit
Bug 8995: Show OpenURL links in OPAC search results

This patch use GetCOinS sub to provide an OpenURL link in OPAC search
results. It uses 4 new system preferences:
  - OpenURLinOPACResults: enable or disable this feature
  - OpenURLResolverURL: url of the openURL resolver
  - OpenURLText: text of the link
  - OpenURLImageLocation: image of the link

Link is displayed as an image if OpenURLImageLocation is defined, and as
text otherwise.
It works both with and without XSLT enabled.

Changes made to GetCOinSBiblio:

For 'journal':
- Title should be in rft.jtitle instead of rft.title
- rft.date, rft.aulast, rft.aufirst, rft.au, rft.pub and rft.pages have
  no meaning for a subscription, so they are simply removed from URL

This patch refactors GetCOinSBiblio, so the construction of URL is done
only at the end. This way we do not have ugly
  $var .= "$value"
in the function body.

Also use URI::Escape instead of custom regexps.

This development consider the value of syspref OPACURLOpenInNewWindow
when building the link.

Test plan:
1/ Enable syspref OPACShowOpenURL and put your OpenURL resolver URL in
OpenURLResolverURL syspref (if you don't have one, just fill it with
some fake URL, you'll have to check if OpenURL links are correct)
2/ If you want, set the other sysprefs OpenURLImageLocation and
OpenURLText
3/ Fill syspref OPACOpenURLItemTypes with some (not all) of your
item types.
4/ Empty sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay
5/ Go to OPAC and launch a search.
6/ Check you have in the results (near the title) the OpenURL link (only
for itemtypes that are in OPACOpenURLItemTypes).
Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of
the link is correct.
7/ Go to the detail page of one of those and check you have the OpenURL
link too. (Above tags)
Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of
the link is correct.
8/ Set sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay to
"default" and repeat steps 5 to 7

Signed-off-by: Paola Rossi 

Signed-off-by: Magnus Enger 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-04-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Josef Moravec  changed:

   What|Removed |Added

  Attachment #86603|0   |1
is obsolete||

--- Comment #112 from Josef Moravec  ---
Created attachment 88666
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=88666=edit
Bug 8995: Add IGNORE to the INSERT statement

Signed-off-by: Magnus Enger 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-03-15 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Joy Nelson  changed:

   What|Removed |Added

 CC||j...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-03-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Magnus Enger  changed:

   What|Removed |Added

  Attachment #86601|0   |1
is obsolete||

--- Comment #110 from Magnus Enger  ---
Created attachment 86610
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86610=edit
Bug 8995: (follow-up) Tak system preference item-level_itypes into account

Signed-off-by: Magnus Enger 
Tested with all 9 current patches. Works as advertised, including
OPACURLOpenInNewWindow. If a record has no items, no OpenURL link
is displayed. All the suggested tests pass. I did not test with
XSLT turned off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-03-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Magnus Enger  changed:

   What|Removed |Added

  Attachment #86559|0   |1
is obsolete||

--- Comment #109 from Magnus Enger  ---
Created attachment 86609
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86609=edit
Bug 8995: (follow-up) Add one more test fot get_openurl

Test plan:
prove t/db_dependent/Koha/Biblio.t

Signed-off-by: Magnus Enger 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-03-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Magnus Enger  changed:

   What|Removed |Added

  Attachment #86558|0   |1
is obsolete||

--- Comment #108 from Magnus Enger  ---
Created attachment 86608
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86608=edit
Bug 8995: (follow-up) Move GetCOinSBiblio to Koha::Biblio->get_coins

Test plan:
1) Ensure the COinS span tag is still included on this pages. You need
to look into html source and search for span tag with class 'Z3988',
   which has COinS string in title.
   Staff client:
   catalogue -> ISBDdetail
   catalogue -> MARCdetail
   catalogue -> detail
   virtualshelves -> shelves
OPAC (you should have COinSinOPACResults system preference enabled):
opac detail
opac search
opac shelves
2) Run tests:
prove t/Biblio.t t/db_dependent/Biblio.t t/db_dependent/Koha/Biblio.t

Signed-off-by: Magnus Enger 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-03-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Magnus Enger  changed:

   What|Removed |Added

  Attachment #86492|0   |1
is obsolete||

--- Comment #104 from Magnus Enger  ---
Created attachment 86604
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86604=edit
Bug 8995: (follow-up) Adapt to current codebase

Signed-off-by: Magnus Enger 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-03-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Magnus Enger  changed:

   What|Removed |Added

  Attachment #86542|0   |1
is obsolete||

--- Comment #106 from Magnus Enger  ---
Created attachment 86606
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86606=edit
Bug 8995: (follow-up) Add POD for GetOpenURLResolverURL

Signed-off-by: Magnus Enger 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-03-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Magnus Enger  changed:

   What|Removed |Added

  Attachment #86557|0   |1
is obsolete||

--- Comment #107 from Magnus Enger  ---
Created attachment 86607
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86607=edit
Bug 8995: (follow-up) Move GetOpenURLResolverURL to Koha::Biblio->get_openurl

Signed-off-by: Magnus Enger 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-03-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Magnus Enger  changed:

   What|Removed |Added

  Attachment #86541|0   |1
is obsolete||

--- Comment #105 from Magnus Enger  ---
Created attachment 86605
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86605=edit
Bug 8995: (follow-up) Added test

Signed-off-by: Magnus Enger 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-03-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Magnus Enger  changed:

   What|Removed |Added

  Attachment #86491|0   |1
is obsolete||

--- Comment #103 from Magnus Enger  ---
Created attachment 86603
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86603=edit
Bug 8995: Add IGNORE to the INSERT statement

Signed-off-by: Magnus Enger 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-03-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Magnus Enger  changed:

   What|Removed |Added

  Attachment #86490|0   |1
is obsolete||

--- Comment #102 from Magnus Enger  ---
Created attachment 86602
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86602=edit
Bug 8995: Show OpenURL links in OPAC search results

This patch use GetCOinS sub to provide an OpenURL link in OPAC search
results. It uses 4 new system preferences:
  - OpenURLinOPACResults: enable or disable this feature
  - OpenURLResolverURL: url of the openURL resolver
  - OpenURLText: text of the link
  - OpenURLImageLocation: image of the link

Link is displayed as an image if OpenURLImageLocation is defined, and as
text otherwise.
It works both with and without XSLT enabled.

Changes made to GetCOinSBiblio:

For 'journal':
- Title should be in rft.jtitle instead of rft.title
- rft.date, rft.aulast, rft.aufirst, rft.au, rft.pub and rft.pages have
  no meaning for a subscription, so they are simply removed from URL

This patch refactors GetCOinSBiblio, so the construction of URL is done
only at the end. This way we do not have ugly
  $var .= "$value"
in the function body.

Also use URI::Escape instead of custom regexps.

This development consider the value of syspref OPACURLOpenInNewWindow
when building the link.

Test plan:
1/ Enable syspref OPACShowOpenURL and put your OpenURL resolver URL in
OpenURLResolverURL syspref (if you don't have one, just fill it with
some fake URL, you'll have to check if OpenURL links are correct)
2/ If you want, set the other sysprefs OpenURLImageLocation and
OpenURLText
3/ Fill syspref OPACOpenURLItemTypes with some (not all) of your
item types.
4/ Empty sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay
5/ Go to OPAC and launch a search.
6/ Check you have in the results (near the title) the OpenURL link (only
for itemtypes that are in OPACOpenURLItemTypes).
Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of
the link is correct.
7/ Go to the detail page of one of those and check you have the OpenURL
link too. (Above tags)
Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of
the link is correct.
8/ Set sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay to
"default" and repeat steps 5 to 7

Signed-off-by: Paola Rossi 

Signed-off-by: Magnus Enger 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-03-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Magnus Enger  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-03-14 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

--- Comment #101 from Josef Moravec  ---
Created attachment 86601
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86601=edit
Bug 8995: (follow-up) Tak system preference item-level_itypes into account

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-03-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Josef Moravec  changed:

   What|Removed |Added

 QA Contact|josef.mora...@gmail.com |testo...@bugs.koha-communit
   ||y.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-03-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

--- Comment #100 from Josef Moravec  ---
Created attachment 86559
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86559=edit
Bug 8995: (follow-up) Add one more test fot get_openurl

Test plan:
prove t/db_dependent/Koha/Biblio.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-03-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

--- Comment #98 from Josef Moravec  ---
Created attachment 86557
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86557=edit
Bug 8995: (follow-up) Move GetOpenURLResolverURL to Koha::Biblio->get_openurl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-03-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

--- Comment #99 from Josef Moravec  ---
Created attachment 86558
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86558=edit
Bug 8995: (follow-up) Move GetCOinSBiblio to Koha::Biblio->get_coins

Test plan:
1) Ensure the COinS span tag is still included on this pages. You need
to look into html source and search for span tag with class 'Z3988',
   which has COinS string in title.
   Staff client:
   catalogue -> ISBDdetail
   catalogue -> MARCdetail
   catalogue -> detail
   virtualshelves -> shelves
OPAC (you should have COinSinOPACResults system preference enabled):
opac detail
opac search
opac shelves
2) Run tests:
prove t/Biblio.t t/db_dependent/Biblio.t t/db_dependent/Koha/Biblio.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-03-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

--- Comment #96 from Josef Moravec  ---
Created attachment 86541
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86541=edit
Bug 8995: (follow-up) Added test

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-03-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

--- Comment #97 from Josef Moravec  ---
Created attachment 86542
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86542=edit
Bug 8995: (follow-up) Add POD for GetOpenURLResolverURL

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-03-12 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Josef Moravec  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-03-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Josef Moravec  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Failed QA

--- Comment #95 from Josef Moravec  ---
I rebased and squashed the patches a bit. 
To pass QA there are at least missing tests for GetOpenURLResolverURL.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-03-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

--- Comment #94 from Josef Moravec  ---
Created attachment 86492
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86492=edit
Bug 8995: (follow-up) Adapt to current codebase

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-03-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Josef Moravec  changed:

   What|Removed |Added

  Attachment #86483|0   |1
is obsolete||
  Attachment #86484|0   |1
is obsolete||
  Attachment #86485|0   |1
is obsolete||
  Attachment #86486|0   |1
is obsolete||
  Attachment #86487|0   |1
is obsolete||
  Attachment #86488|0   |1
is obsolete||
  Attachment #86489|0   |1
is obsolete||

--- Comment #92 from Josef Moravec  ---
Created attachment 86490
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86490=edit
Bug 8995: Show OpenURL links in OPAC search results

This patch use GetCOinS sub to provide an OpenURL link in OPAC search
results. It uses 4 new system preferences:
  - OpenURLinOPACResults: enable or disable this feature
  - OpenURLResolverURL: url of the openURL resolver
  - OpenURLText: text of the link
  - OpenURLImageLocation: image of the link

Link is displayed as an image if OpenURLImageLocation is defined, and as
text otherwise.
It works both with and without XSLT enabled.

Changes made to GetCOinSBiblio:

For 'journal':
- Title should be in rft.jtitle instead of rft.title
- rft.date, rft.aulast, rft.aufirst, rft.au, rft.pub and rft.pages have
  no meaning for a subscription, so they are simply removed from URL

This patch refactors GetCOinSBiblio, so the construction of URL is done
only at the end. This way we do not have ugly
  $var .= "$value"
in the function body.

Also use URI::Escape instead of custom regexps.

This development consider the value of syspref OPACURLOpenInNewWindow
when building the link.

Test plan:
1/ Enable syspref OPACShowOpenURL and put your OpenURL resolver URL in
OpenURLResolverURL syspref (if you don't have one, just fill it with
some fake URL, you'll have to check if OpenURL links are correct)
2/ If you want, set the other sysprefs OpenURLImageLocation and
OpenURLText
3/ Fill syspref OPACOpenURLItemTypes with some (not all) of your
item types.
4/ Empty sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay
5/ Go to OPAC and launch a search.
6/ Check you have in the results (near the title) the OpenURL link (only
for itemtypes that are in OPACOpenURLItemTypes).
Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of
the link is correct.
7/ Go to the detail page of one of those and check you have the OpenURL
link too. (Above tags)
Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of
the link is correct.
8/ Set sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay to
"default" and repeat steps 5 to 7

Signed-off-by: Paola Rossi 

Signed-off-by: Magnus Enger 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-03-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

--- Comment #93 from Josef Moravec  ---
Created attachment 86491
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86491=edit
Bug 8995: Add IGNORE to the INSERT statement

Signed-off-by: Magnus Enger 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-03-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

--- Comment #91 from Josef Moravec  ---
Created attachment 86489
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86489=edit
Bug 8995: (follow-up) Adapt to current codebase

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-03-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

--- Comment #90 from Josef Moravec  ---
Created attachment 86488
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86488=edit
Bug 8995: Add IGNORE to the INSERT statement

Signed-off-by: Magnus Enger 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-03-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

--- Comment #88 from Josef Moravec  ---
Created attachment 86486
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86486=edit
Bug 8995: Tell about the new sysprefs in COinSinOPACResults description

Signed-off-by: Magnus Enger 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-03-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

--- Comment #86 from Josef Moravec  ---
Created attachment 86484
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86484=edit
Bug 8995: Remove useless code

OpenURL link display is done in XSLT only, so this code is now useless

Signed-off-by: Magnus Enger 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-03-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Josef Moravec  changed:

   What|Removed |Added

  Attachment #64532|0   |1
is obsolete||
  Attachment #64533|0   |1
is obsolete||
  Attachment #64534|0   |1
is obsolete||
  Attachment #64535|0   |1
is obsolete||
  Attachment #64536|0   |1
is obsolete||
  Attachment #64537|0   |1
is obsolete||
  Attachment #64538|0   |1
is obsolete||

--- Comment #85 from Josef Moravec  ---
Created attachment 86483
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86483=edit
Bug 8995: Show OpenURL links in OPAC search results

This patch use GetCOinS sub to provide an OpenURL link in OPAC search
results. It uses 4 new system preferences:
  - OpenURLinOPACResults: enable or disable this feature
  - OpenURLResolverURL: url of the openURL resolver
  - OpenURLText: text of the link
  - OpenURLImageLocation: image of the link

Link is displayed as an image if OpenURLImageLocation is defined, and as
text otherwise.
It works both with and without XSLT enabled.

Changes made to GetCOinSBiblio:

For 'journal':
- Title should be in rft.jtitle instead of rft.title
- rft.date, rft.aulast, rft.aufirst, rft.au, rft.pub and rft.pages have
  no meaning for a subscription, so they are simply removed from URL

This patch refactors GetCOinSBiblio, so the construction of URL is done
only at the end. This way we do not have ugly
  $var .= "$value"
in the function body.

Also use URI::Escape instead of custom regexps.

This development consider the value of syspref OPACURLOpenInNewWindow
when building the link.

Test plan:
1/ Enable syspref OPACShowOpenURL and put your OpenURL resolver URL in
OpenURLResolverURL syspref (if you don't have one, just fill it with
some fake URL, you'll have to check if OpenURL links are correct)
2/ If you want, set the other sysprefs OpenURLImageLocation and
OpenURLText
3/ Fill syspref OPACOpenURLItemTypes with some (not all) of your
item types.
4/ Empty sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay
5/ Go to OPAC and launch a search.
6/ Check you have in the results (near the title) the OpenURL link (only
for itemtypes that are in OPACOpenURLItemTypes).
Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of
the link is correct.
7/ Go to the detail page of one of those and check you have the OpenURL
link too. (Above tags)
Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of
the link is correct.
8/ Set sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay to
"default" and repeat steps 5 to 7

Signed-off-by: Paola Rossi 

Signed-off-by: Magnus Enger 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-03-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

--- Comment #89 from Josef Moravec  ---
Created attachment 86487
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86487=edit
Bug 8995: Fix and simplify usage of syspref OpenURLImageLocation

There were still references to the OPAC 'prog' theme in XSL files
Now, when using a relative URL, we have to give the full path

Signed-off-by: Magnus Enger 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-03-11 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

--- Comment #87 from Josef Moravec  ---
Created attachment 86485
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86485=edit
Bug 8995: Fix URL generation when the URL in syspref has a query part

Signed-off-by: Magnus Enger 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2019-02-25 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Kelly McElligott  changed:

   What|Removed |Added

 CC||jza...@bywatersolutions.com
   ||,
   ||ke...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2018-02-20 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Josef Moravec  changed:

   What|Removed |Added

 QA Contact||josef.mora...@gmail.com
 CC||josef.mora...@gmail.com
 Status|Signed Off  |Patch doesn't apply

--- Comment #84 from Josef Moravec  ---
Patch doesn't apply, please, rebase.

Also, we will need pod and test for GetOpenURLResolverURL in C4::Biblio

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2017-11-26 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Jonathan Druart  changed:

   What|Removed |Added

   Keywords|rel_17_11_candidate |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2017-10-13 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||rel_17_11_candidate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2017-06-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

--- Comment #83 from Katrin Fischer  ---
I will! ;)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2017-06-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

--- Comment #82 from Magnus Enger  ---
(In reply to Katrin Fischer from comment #81)
> Hi Magnuse, as you have a good test case for it - could I get you to write
> something for the manual once this goes in?

Sure! Can you remind me about it?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2017-06-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

--- Comment #81 from Katrin Fischer  ---
Hi Magnuse, as you have a good test case for it - could I get you to write
something for the manual once this goes in?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2017-06-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

--- Comment #80 from Magnus Enger  ---
One of my customers have tested this, and are very happy with the result. This
should be a very nice addition for many academic libraries.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2017-06-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Magnus Enger  changed:

   What|Removed |Added

  Attachment #64517|0   |1
is obsolete||

--- Comment #77 from Magnus Enger  ---
Created attachment 64536
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64536=edit
Bug 8995: Tell about the new sysprefs in COinSinOPACResults description

Signed-off-by: Magnus Enger 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2017-06-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Magnus Enger  changed:

   What|Removed |Added

  Attachment #64516|0   |1
is obsolete||

--- Comment #76 from Magnus Enger  ---
Created attachment 64535
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64535=edit
Bug 8995: Fix URL generation when the URL in syspref has a query part

Signed-off-by: Magnus Enger 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2017-06-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Magnus Enger  changed:

   What|Removed |Added

  Attachment #64519|0   |1
is obsolete||

--- Comment #79 from Magnus Enger  ---
Created attachment 64538
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64538=edit
Bug 8995: Add IGNORE to the INSERT statement

Signed-off-by: Magnus Enger 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2017-06-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Magnus Enger  changed:

   What|Removed |Added

  Attachment #64518|0   |1
is obsolete||

--- Comment #78 from Magnus Enger  ---
Created attachment 64537
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64537=edit
Bug 8995: Fix and simplify usage of syspref OpenURLImageLocation

There were still references to the OPAC 'prog' theme in XSL files
Now, when using a relative URL, we have to give the full path

Signed-off-by: Magnus Enger 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2017-06-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Magnus Enger  changed:

   What|Removed |Added

   Patch complexity|--- |Small patch
 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2017-06-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Magnus Enger  changed:

   What|Removed |Added

  Attachment #64515|0   |1
is obsolete||

--- Comment #75 from Magnus Enger  ---
Created attachment 64534
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64534=edit
Bug 8995: Remove useless code

OpenURL link display is done in XSLT only, so this code is now useless

Signed-off-by: Magnus Enger 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2017-06-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Magnus Enger  changed:

   What|Removed |Added

  Attachment #64513|0   |1
is obsolete||

--- Comment #73 from Magnus Enger  ---
Created attachment 64532
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64532=edit
Bug 8995: Show OpenURL links in OPAC search results

This patch use GetCOinS sub to provide an OpenURL link in OPAC search
results. It uses 4 new system preferences:
  - OpenURLinOPACResults: enable or disable this feature
  - OpenURLResolverURL: url of the openURL resolver
  - OpenURLText: text of the link
  - OpenURLImageLocation: image of the link

Link is displayed as an image if OpenURLImageLocation is defined, and as
text otherwise.
It works both with and without XSLT enabled.

Changes made to GetCOinSBiblio:

For 'journal':
- Title should be in rft.jtitle instead of rft.title
- rft.date, rft.aulast, rft.aufirst, rft.au, rft.pub and rft.pages have
  no meaning for a subscription, so they are simply removed from URL

This patch refactors GetCOinSBiblio, so the construction of URL is done
only at the end. This way we do not have ugly
  $var .= "$value"
in the function body.

Also use URI::Escape instead of custom regexps.

This development consider the value of syspref OPACURLOpenInNewWindow
when building the link.

Test plan:
1/ Enable syspref OPACShowOpenURL and put your OpenURL resolver URL in
OpenURLResolverURL syspref (if you don't have one, just fill it with
some fake URL, you'll have to check if OpenURL links are correct)
2/ If you want, set the other sysprefs OpenURLImageLocation and
OpenURLText
3/ Fill syspref OPACOpenURLItemTypes with some (not all) of your
item types.
4/ Empty sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay
5/ Go to OPAC and launch a search.
6/ Check you have in the results (near the title) the OpenURL link (only
for itemtypes that are in OPACOpenURLItemTypes).
Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of
the link is correct.
7/ Go to the detail page of one of those and check you have the OpenURL
link too. (Above tags)
Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of
the link is correct.
8/ Set sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay to
"default" and repeat steps 5 to 7

Signed-off-by: Paola Rossi 

Signed-off-by: Magnus Enger 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2017-06-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Magnus Enger  changed:

   What|Removed |Added

  Attachment #64514|0   |1
is obsolete||

--- Comment #74 from Magnus Enger  ---
Created attachment 64533
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64533=edit
Bug 8995: Update opac.css

Signed-off-by: Magnus Enger 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2017-06-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Julian Maurice  changed:

   What|Removed |Added

  Attachment #55882|0   |1
is obsolete||

--- Comment #71 from Julian Maurice  ---
Created attachment 64519
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64519=edit
Bug 8995: Add IGNORE to the INSERT statement

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2017-06-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Julian Maurice  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #72 from Julian Maurice  ---
Patches rebased

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2017-06-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Julian Maurice  changed:

   What|Removed |Added

  Attachment #55136|0   |1
is obsolete||

--- Comment #70 from Julian Maurice  ---
Created attachment 64518
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64518=edit
Bug 8995: Fix and simplify usage of syspref OpenURLImageLocation

There were still references to the OPAC 'prog' theme in XSL files
Now, when using a relative URL, we have to give the full path

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2017-06-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Julian Maurice  changed:

   What|Removed |Added

  Attachment #55135|0   |1
is obsolete||

--- Comment #69 from Julian Maurice  ---
Created attachment 64517
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64517=edit
Bug 8995: Tell about the new sysprefs in COinSinOPACResults description

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2017-06-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Julian Maurice  changed:

   What|Removed |Added

  Attachment #55134|0   |1
is obsolete||

--- Comment #68 from Julian Maurice  ---
Created attachment 64516
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64516=edit
Bug 8995: Fix URL generation when the URL in syspref has a query part

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2017-06-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Julian Maurice  changed:

   What|Removed |Added

  Attachment #55133|0   |1
is obsolete||

--- Comment #67 from Julian Maurice  ---
Created attachment 64515
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64515=edit
Bug 8995: Remove useless code

OpenURL link display is done in XSLT only, so this code is now useless

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2017-06-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Julian Maurice  changed:

   What|Removed |Added

  Attachment #55132|0   |1
is obsolete||

--- Comment #66 from Julian Maurice  ---
Created attachment 64514
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64514=edit
Bug 8995: Update opac.css

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2017-06-22 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Julian Maurice  changed:

   What|Removed |Added

  Attachment #55131|0   |1
is obsolete||

--- Comment #65 from Julian Maurice  ---
Created attachment 64513
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64513=edit
Bug 8995: Show OpenURL links in OPAC search results

This patch use GetCOinS sub to provide an OpenURL link in OPAC search
results. It uses 4 new system preferences:
  - OpenURLinOPACResults: enable or disable this feature
  - OpenURLResolverURL: url of the openURL resolver
  - OpenURLText: text of the link
  - OpenURLImageLocation: image of the link

Link is displayed as an image if OpenURLImageLocation is defined, and as
text otherwise.
It works both with and without XSLT enabled.

Changes made to GetCOinSBiblio:

For 'journal':
- Title should be in rft.jtitle instead of rft.title
- rft.date, rft.aulast, rft.aufirst, rft.au, rft.pub and rft.pages have
  no meaning for a subscription, so they are simply removed from URL

This patch refactors GetCOinSBiblio, so the construction of URL is done
only at the end. This way we do not have ugly
  $var .= "$value"
in the function body.

Also use URI::Escape instead of custom regexps.

This development consider the value of syspref OPACURLOpenInNewWindow
when building the link.

Test plan:
1/ Enable syspref OPACShowOpenURL and put your OpenURL resolver URL in
OpenURLResolverURL syspref (if you don't have one, just fill it with
some fake URL, you'll have to check if OpenURL links are correct)
2/ If you want, set the other sysprefs OpenURLImageLocation and
OpenURLText
3/ Fill syspref OPACOpenURLItemTypes with some (not all) of your
item types.
4/ Empty sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay
5/ Go to OPAC and launch a search.
6/ Check you have in the results (near the title) the OpenURL link (only
for itemtypes that are in OPACOpenURLItemTypes).
Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of
the link is correct.
7/ Go to the detail page of one of those and check you have the OpenURL
link too. (Above tags)
Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of
the link is correct.
8/ Set sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay to
"default" and repeat steps 5 to 7

Signed-off-by: Paola Rossi 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2017-06-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

--- Comment #64 from Magnus Enger  ---
If anyone needs an OpenURL linkresolver to test these patches against, I have a
customer that has one that can be used. Please contact me for details.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2017-06-21 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

--- Comment #63 from Magnus Enger  ---
Any chance of another rebase? I'll sign off quickley this time.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2017-03-03 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #62 from M. Tompsett  ---
If one fixes the opac.less (easy to fix), and recompiles the opac.css (easy to
do in kohadevbox -- mine isn't booted), this patch set could be rescued.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2017-01-23 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Marjorie Barry-Vila  changed:

   What|Removed |Added

 CC||marjorie.barry-v...@ccsr.qc
   ||.ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2016-11-24 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2016-09-29 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

--- Comment #61 from Magnus Enger  ---
(In reply to Jonathan Druart from comment #59)
> How can we test this feature correctly?

The trouble is finding a link resolver that can be used. One of my customers is
very interested in this patch, so I have set up a gitified, temporary instance
for them with the patches on this bug. They have configured it to use their
existing SFX lin resolver. Here is an example:
http://stami.demo.bibkat.no/cgi-bin/koha/opac-detail.pl?biblionumber=9810

They have tested it and found it satisfactory. Their testing was before the 5
followup patches, but the instance is currently running with all the patches on
this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2016-09-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

--- Comment #60 from Jonathan Druart  
---
Created attachment 55882
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=55882=edit
Bug 8995: Add IGNORE to the INSERT statement

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results

2016-09-28 Thread bugzilla-daemon

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995

--- Comment #59 from Jonathan Druart  
---
How can we test this feature correctly?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

1 2 >

1 - 100 of 169 matches

Mail list logo