[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Jonathan Druart changed: What|Removed |Added Blocks||24735 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24735 [Bug 24735] Remove QueryParser-related code -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 claire.hernan...@biblibre.com claire.hernan...@biblibre.com changed: What|Removed |Added CC||claire.hernandez@biblibre.c ||om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #76 from Jared Camins-Esakov jcam...@cpbibliography.com --- If you are using a git install and do not run the installer, you will need to update koha-conf.xml and add the following line (modified to point to your git clone) before /config near the bottom of the koha-conf.xml file: queryparser_config/home/jcamins/kohaclone/etc/searchengine/queryparser.yaml/queryparser_config -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #59 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 16180 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16180action=edit Bug 9239: Add QueryParser module to Koha Although the OpenILS::QueryParser class is going to be moved into a separate CPAN distribution, this hasn't been done yet, and for ease of testing it makes sense to include the class in Koha for the moment. Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Elliott Davis elli...@bywatersolions.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #60 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 16181 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16181action=edit Bug 9239: Introduce QueryParser driver for PQF Since the most expressive query language supported by Zebra is PQF, this patch adds a PQF driver for QueryParser which will translate QueryParser queries into standard PQF (guided by mappings which have been written to match Koha's existing Zebra configuration) which can then be sent to Zebra. This driver, Koha::QueryParser::Driver::PQF(::*) extends the OpenILS::QueryParser(::*) class(es), so as to preserve maximum interoperability between the various users of the QueryParser driver. Initially, search syntax is as follows: * AND operator: * OR operator: || * GROUPING operators: ( ) Fields can mostly be searched using the ccl prefixes they have now. The exception is the various date limits which are searched with a syntax like this: pubdate(2008) For sorting, you can simply add #title-sort-az (etc.) to your query. Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Elliott Davis elli...@bywatersolions.com Test Passed successfully after installing missing dep for Test::Deep Signed-off-by: Katrin Fischer katrin.fischer...@web.de Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #61 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 16182 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16182action=edit Bug 9239: Add syspref to enable QueryParser In light of the experimental nature of the QueryParser code at this juncture, it behooves Koha to have the option of disabling QP, at least for the purpose of comparing results between QP-enabled and QP-disabled searches. This patch adds a UseQueryParser syspref to do just that. In cases where the user enables QP without having QP installed, however, there will be no dramatic failure, and Koha will simply fall back to using the non-QP search code. In order to reduce the overhead added by the introduction of QueryParser, this patch adds a C4::Context-queryparser accessor to a static QueryParser object which is initialized the first time it is required and then reset thereafter. Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Elliott Davis elli...@bywatersolions.com Fixed merge conflict in sysprefs.sql and updatedatabase.sql Signed-off-by: Katrin Fischer katrin.fischer...@web.de Fixed merge conflict in sysprefs.sql und updatedatabase.pl Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #62 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 16183 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16183action=edit Bug 9239: Allow the use of QueryParser for all queries With the inclusion of this patch, all searches will (try) to use QueryParser for handling queries for both the bibliographic and authority databases if UseQueryParser is enabled. If QueryParser is unavailable, UseQueryParser is disabled, or the search uses CCL indexes, the old search code will be used. To test: 1) Apply patch. 2) Run the unit test with `prove t/QueryParser.t` 3) Enable the UseQueryParser syspref. 4) Try searches that should return results in the following places: * OPAC (simple search) * OPAC (advanced search) * OPAC (authorities) * Staff client (header search) * Staff client (advanced search) * Staff client (cataloging search) * Staff client (authorities) * Staff client (importing a batch using a match point) * Staff client (searching for an item for adding to a label) * Staff client (acquisitions) * Staff client (searching for a record to create a serial) * ANYWHERE ELSE I HAVE FORGOTTEN 5) Disable the UseQueryParser syspref. Repeat at least some of the searches you did above. 6) If all searches worked, sign off. Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Elliott Davis elli...@bywatersolions.com Searching still works as expected for variuos places. QueryParser syspref seemed to be enabled by default Signed-off-by: Katrin Fischer katrin.fischer...@web.de Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #63 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 16184 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16184action=edit Bug 9239 follow-up: POD and perlcritic fixes There were several perlcritic violations for returning explicit undef, and splitting up the various driver classes resulted in POD compliance errors, where the POD was starting with head2 rather than head1. This patch fixes those errors (but has no functional impact). Signed-off-by: Elliott Davis elli...@bywatersolions.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #64 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 16185 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16185action=edit Bug 9239 follow-up: update koha-conf.xml The previous patches were missing the koha-conf.xml updates. This patch updates koha-conf.xml and makes the changes neccessary to include the QueryParser configuration file in the packages. To test: 1) Run Makefile and check generated koha-conf.xml to confirm that the line queryparser_config.../queryparser_config is there with an absolute path. 2) That was it. Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Katrin Fischer katrin.fischer...@web.de Tested update successfully - new line now shows up and query parser is used. Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #65 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 16186 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16186action=edit Bug 9239 QA follow-up: fix highlighting and merge error QP searches with broke search highlighting on the OPAC details page. This patch corrects encoding of the query_desc parameter that is passed to the details page. My last attempt at rebasing also transposed the variable for index names with the variable for operators, meaning that the dropdown in the basic search did not work. Signed-off-by: Chris Cormack chr...@catalyst.net.nz Signed-off-by: Katrin Fischer katrin.fischer...@web.de Fixes some problems raised during QA successfully. Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #66 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 16187 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16187action=edit Bug 9239 QA-follow-up: quiet warnings and fix problem with limits Signed-off-by: Katrin Fischer katrin.fischer...@web.de Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #67 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 16188 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16188action=edit Bug 9239 QA follow-up: escape CGI input Koha was not previously escaping CGI input, which caused problems for highlighting and is a security issue. Signed-off-by: Katrin Fischer katrin.fischer...@web.de Thx for fixing this. Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #68 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 16189 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16189action=edit Bug 9239 QA follow-up: the last QA follow-up was missing a require This patch also corrects the definition of the an= index, which was missing exactness. Signed-off-by: Katrin Fischer katrin.fischer...@web.de Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #69 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 16190 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16190action=edit Bug 9239 QA follow-up: don't fall back to kw if field is specified Signed-off-by: Katrin Fischer katrin.fischer...@web.de Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #70 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 16191 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16191action=edit Bug 9239 QA follow-up: remove stray debug code Remove a line of debug code from EG, provide better error handling when presented with weird data in the authority linker, and correct queryparser configuration to reflect the correct configuration for Zebra. Signed-off-by: Katrin Fischer katrin.fischer...@web.de Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #71 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 16192 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16192action=edit Bug 9239 QA follow-up: better error handling * Fix a long-standing bug in the linker that could crash the linker when run against odd data. * Sanitize input to SimpleSearch. * Correctly handle CCL indexes with QP. Signed-off-by: Katrin Fischer katrin.fischer...@web.de Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #72 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 16193 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16193action=edit Bug 9239 QA follow-up: escape quotes in searches This patch escapes quotes in searches for those rare instances where there is a literal quote inside a search term. Signed-off-by: Katrin Fischer katrin.fischer...@web.de Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #73 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 16194 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16194action=edit Bug 9239 QA follow-up: amend error handling Signed-off-by: Katrin Fischer katrin.fischer...@web.de Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #74 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 16195 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16195action=edit Bug 9239 QA follow-up: fix overeager quote escaping The quote escaping added two follow-ups ago was a little too eager, and escaped perfectly valid quotes in some instances. This patch moves the escaping deeper into the loop so that no needed quotes will be escaped. Signed-off-by: Katrin Fischer katrin.fischer...@web.de Test plan included here, as this is the last patch in the series: All tests pass. OPAC Simple search - Keyword searches using boolean operators || and - OK - Pubdate searches using pubdate() - OK - Using different search options: keyword, title, etc. - OK Facets - limit to available from a query parser simple search - OK - Other facets - OK Advanced search - Date range search - OK - Itemtype limits - OK - Language limit - OK - Combining various serach options with and without 'more' options and using boolean operators - OK Authorities - Searching for partial and complete names like M, Benedictus works. - OK - Biblio count isc correct - OK - Links to linked biblios work. - OK. INTRANET Staged MARC import - Import records using various matching points - OK Serials - Search for a serial in subscription form - OK Acquisitions - Search for existing record from basket - OK Authorities - Running the linker script with QP on works. - OK - Searching for authorities works. - OK - Biblio count isc correct - OK - Links to linked biblios work. - OK. NOTE: As agreed with Jared in chat, query parser should be off by default for the next release. Signed-off-by: Jared Camins-Esakov jcam...@cpbibliography.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #16140|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #16142|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #16141|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #16143|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #16144|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #16146|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #16145|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #16147|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #16148|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #16151|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #16149|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #16150|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #16153|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #16152|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #16155|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #16154|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #37 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 16125 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16125action=edit Bug 9239 QA follow-up: better error handling * Fix a long-standing bug in the linker that could crash the linker when run against odd data. * Sanitize input to SimpleSearch. * Correctly handle CCL indexes with QP. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #38 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 16130 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16130action=edit Bug 9239 QA follow-up: remove stray debug code Remove a line of debug code from EG, provide better error handling when presented with weird data in the authority linker, and correct queryparser configuration to reflect the correct configuration for Zebra. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #39 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 16131 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16131action=edit Bug 9239 QA follow-up: escape quotes in searches This patch escapes quotes in searches for those rare instances where there is a literal quote inside a search term. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #40 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 16132 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16132action=edit Bug 9239 QA follow-up: amend error handling -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #16132|0 |1 is obsolete|| --- Comment #41 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 16133 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16133action=edit Bug 9239 QA follow-up: amend error handling -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #42 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 16136 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16136action=edit Bug 9239 QA follow-up: fix overeager quote escaping The quote escaping added two follow-ups ago was a little too eager, and escaped perfectly valid quotes in some instances. This patch moves the escaping deeper into the loop so that no needed quotes will be escaped. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #14949|0 |1 is obsolete|| Attachment #14950|0 |1 is obsolete|| Attachment #14951|0 |1 is obsolete|| Attachment #14952|0 |1 is obsolete|| Attachment #14953|0 |1 is obsolete|| Attachment #15437|0 |1 is obsolete|| Attachment #15867|0 |1 is obsolete|| Attachment #15929|0 |1 is obsolete|| Attachment #15999|0 |1 is obsolete|| Attachment #16004|0 |1 is obsolete|| Attachment #16051|0 |1 is obsolete|| Attachment #16125|0 |1 is obsolete|| Attachment #16130|0 |1 is obsolete|| Attachment #16131|0 |1 is obsolete|| Attachment #16133|0 |1 is obsolete|| Attachment #16136|0 |1 is obsolete|| --- Comment #43 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 16140 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16140action=edit [PASSED QA] Bug 9239: Add QueryParser module to Koha Although the OpenILS::QueryParser class is going to be moved into a separate CPAN distribution, this hasn't been done yet, and for ease of testing it makes sense to include the class in Koha for the moment. Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Elliott Davis elli...@bywatersolions.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #44 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 16141 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16141action=edit [PASSED QA] Bug 9239: Introduce QueryParser driver for PQF Since the most expressive query language supported by Zebra is PQF, this patch adds a PQF driver for QueryParser which will translate QueryParser queries into standard PQF (guided by mappings which have been written to match Koha's existing Zebra configuration) which can then be sent to Zebra. This driver, Koha::QueryParser::Driver::PQF(::*) extends the OpenILS::QueryParser(::*) class(es), so as to preserve maximum interoperability between the various users of the QueryParser driver. Initially, search syntax is as follows: * AND operator: * OR operator: || * GROUPING operators: ( ) Fields can mostly be searched using the ccl prefixes they have now. The exception is the various date limits which are searched with a syntax like this: pubdate(2008) For sorting, you can simply add #title-sort-az (etc.) to your query. Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Elliott Davis elli...@bywatersolions.com Test Passed successfully after installing missing dep for Test::Deep Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #45 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 16142 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16142action=edit [PASSED QA] Bug 9239: Add syspref to enable QueryParser In light of the experimental nature of the QueryParser code at this juncture, it behooves Koha to have the option of disabling QP, at least for the purpose of comparing results between QP-enabled and QP-disabled searches. This patch adds a UseQueryParser syspref to do just that. In cases where the user enables QP without having QP installed, however, there will be no dramatic failure, and Koha will simply fall back to using the non-QP search code. In order to reduce the overhead added by the introduction of QueryParser, this patch adds a C4::Context-queryparser accessor to a static QueryParser object which is initialized the first time it is required and then reset thereafter. Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Elliott Davis elli...@bywatersolions.com Fixed merge conflict in sysprefs.sql and updatedatabase.sql Signed-off-by: Katrin Fischer katrin.fischer...@web.de Fixed merge conflict in sysprefs.sql und updatedatabase.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #46 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 16143 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16143action=edit [PASSED QA] Bug 9239: Allow the use of QueryParser for all queries With the inclusion of this patch, all searches will (try) to use QueryParser for handling queries for both the bibliographic and authority databases if UseQueryParser is enabled. If QueryParser is unavailable, UseQueryParser is disabled, or the search uses CCL indexes, the old search code will be used. To test: 1) Apply patch. 2) Run the unit test with `prove t/QueryParser.t` 3) Enable the UseQueryParser syspref. 4) Try searches that should return results in the following places: * OPAC (simple search) * OPAC (advanced search) * OPAC (authorities) * Staff client (header search) * Staff client (advanced search) * Staff client (cataloging search) * Staff client (authorities) * Staff client (importing a batch using a match point) * Staff client (searching for an item for adding to a label) * Staff client (acquisitions) * Staff client (searching for a record to create a serial) * ANYWHERE ELSE I HAVE FORGOTTEN 5) Disable the UseQueryParser syspref. Repeat at least some of the searches you did above. 6) If all searches worked, sign off. Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Elliott Davis elli...@bywatersolions.com Searching still works as expected for variuos places. QueryParser syspref seemed to be enabled by default Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #47 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 16144 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16144action=edit [PASSED QA] Bug 9239 follow-up: POD and perlcritic fixes There were several perlcritic violations for returning explicit undef, and splitting up the various driver classes resulted in POD compliance errors, where the POD was starting with head2 rather than head1. This patch fixes those errors (but has no functional impact). Signed-off-by: Elliott Davis elli...@bywatersolions.com Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #48 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 16145 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16145action=edit [PASSED QA] Bug 9239 follow-up: update koha-conf.xml The previous patches were missing the koha-conf.xml updates. This patch updates koha-conf.xml and makes the changes neccessary to include the QueryParser configuration file in the packages. To test: 1) Run Makefile and check generated koha-conf.xml to confirm that the line queryparser_config.../queryparser_config is there with an absolute path. 2) That was it. Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Katrin Fischer katrin.fischer...@web.de Tested update successfully - new line now shows up and query parser is used. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #49 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 16146 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16146action=edit [PASSED QA] Bug 9239 QA follow-up: fix highlighting and merge error QP searches with broke search highlighting on the OPAC details page. This patch corrects encoding of the query_desc parameter that is passed to the details page. My last attempt at rebasing also transposed the variable for index names with the variable for operators, meaning that the dropdown in the basic search did not work. Signed-off-by: Chris Cormack chr...@catalyst.net.nz Signed-off-by: Katrin Fischer katrin.fischer...@web.de Fixes some problems raised during QA successfully. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #50 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 16147 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16147action=edit [PASSED QA] Bug 9239 QA-follow-up: quiet warnings and fix problem with limits Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #51 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 16148 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16148action=edit [PASSED QA] Bug 9239 QA follow-up: escape CGI input Koha was not previously escaping CGI input, which caused problems for highlighting and is a security issue. Signed-off-by: Katrin Fischer katrin.fischer...@web.de Thx for fixing this. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #52 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 16149 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16149action=edit [PASSED QA] Bug 9239 QA follow-up: the last QA follow-up was missing a require This patch also corrects the definition of the an= index, which was missing exactness. Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #53 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 16150 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16150action=edit [PASSED QA] Bug 9239 QA follow-up: don't fall back to kw if field is specified Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #54 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 16151 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16151action=edit [PASSED QA] Bug 9239 QA follow-up: remove stray debug code Remove a line of debug code from EG, provide better error handling when presented with weird data in the authority linker, and correct queryparser configuration to reflect the correct configuration for Zebra. Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #55 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 16152 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16152action=edit [PASSED QA] Bug 9239 QA follow-up: better error handling * Fix a long-standing bug in the linker that could crash the linker when run against odd data. * Sanitize input to SimpleSearch. * Correctly handle CCL indexes with QP. Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #56 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 16153 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16153action=edit [PASSED QA] Bug 9239 QA follow-up: escape quotes in searches This patch escapes quotes in searches for those rare instances where there is a literal quote inside a search term. Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #57 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 16154 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16154action=edit [PASSED QA] Bug 9239 QA follow-up: amend error handling Signed-off-by: Katrin Fischer katrin.fischer...@web.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #58 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Created attachment 16155 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16155action=edit [PASSED QA] Bug 9239 QA follow-up: fix overeager quote escaping The quote escaping added two follow-ups ago was a little too eager, and escaped perfectly valid quotes in some instances. This patch moves the escaping deeper into the loop so that no needed quotes will be escaped. Signed-off-by: Katrin Fischer katrin.fischer...@web.de Test plan included here, as this is the last patch in the series: All tests pass. OPAC Simple search - Keyword searches using boolean operators || and - OK - Pubdate searches using pubdate() - OK - Using different search options: keyword, title, etc. - OK Facets - limit to available from a query parser simple search - OK - Other facets - OK Advanced search - Date range search - OK - Itemtype limits - OK - Language limit - OK - Combining various serach options with and without 'more' options and using boolean operators - OK Authorities - Searching for partial and complete names like M, Benedictus works. - OK - Biblio count isc correct - OK - Links to linked biblios work. - OK. INTRANET Staged MARC import - Import records using various matching points - OK Serials - Search for a serial in subscription form - OK Acquisitions - Search for existing record from basket - OK Authorities - Running the linker script with QP on works. - OK - Searching for authorities works. - OK - Biblio count isc correct - OK - Links to linked biblios work. - OK. NOTE: As agreed with Jared in chat, query parser should be off by default for the next release. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #36 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 16051 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16051action=edit Bug 9239 QA follow-up: don't fall back to kw if field is specified -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #35 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 16004 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=16004action=edit Bug 9239 QA follow-up: the last QA follow-up was missing a require This patch also corrects the definition of the an= index, which was missing exactness. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #34 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 15999 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15999action=edit Bug 9239 QA follow-up: escape CGI input Koha was not previously escaping CGI input, which caused problems for highlighting and is a security issue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #33 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 15929 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15929action=edit Bug 9239 QA-follow-up: quiet warnings and fix problem with limits -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #30 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 15865 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15865action=edit Bug 9239 QA follow-up: fix highlighting and merge error QP searches with broke search highlighting on the OPAC details page. This patch corrects encoding of the query_desc parameter that is passed to the details page. My last attempt at rebasing also transposed the variable for index names with the variable for operators, meaning that the dropdown in the basic search did not work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #15865|0 |1 is obsolete|| --- Comment #31 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 15867 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15867action=edit Bug 9239 QA follow-up: fix highlighting and merge error QP searches with broke search highlighting on the OPAC details page. This patch corrects encoding of the query_desc parameter that is passed to the details page. My last attempt at rebasing also transposed the variable for index names with the variable for operators, meaning that the dropdown in the basic search did not work. Signed-off-by: Chris Cormack chr...@catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #29 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Starting testing on this again... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #15121|0 |1 is obsolete|| --- Comment #28 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 15437 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15437action=edit Bug 9239 follow-up: update koha-conf.xml The previous patches were missing the koha-conf.xml updates. This patch updates koha-conf.xml and makes the changes neccessary to include the QueryParser configuration file in the packages. To test: 1) Run Makefile and check generated koha-conf.xml to confirm that the line queryparser_config.../queryparser_config is there with an absolute path. 2) That was it. Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #27 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 15121 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=15121action=edit Bug 9239 follow-up: update koha-conf.xml The previous patches were missing the koha-conf.xml updates. This patch updates koha-conf.xml and makes the changes neccessary to include the QueryParser configuration file in the packages. To test: 1) Run Makefile and check generated koha-conf.xml to confirm that the line queryparser_config.../queryparser_config is there with an absolute path. 2) That was it. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Passed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Elliott Davis elli...@bywatersolutions.com changed: What|Removed |Added Attachment #14180|0 |1 is obsolete|| --- Comment #19 from Elliott Davis elli...@bywatersolutions.com --- Created attachment 14949 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14949action=edit [PAssed QA] Bug 9239: Add QueryParser module to Koha Although the OpenILS::QueryParser class is going to be moved into a separate CPAN distribution, this hasn't been done yet, and for ease of testing it makes sense to include the class in Koha for the moment. Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Elliott Davis elli...@bywatersolions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Elliott Davis elli...@bywatersolutions.com changed: What|Removed |Added Attachment #14181|0 |1 is obsolete|| --- Comment #20 from Elliott Davis elli...@bywatersolutions.com --- Created attachment 14950 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14950action=edit [Passed QA] Bug 9239: Introduce QueryParser driver for PQF Since the most expressive query language supported by Zebra is PQF, this patch adds a PQF driver for QueryParser which will translate QueryParser queries into standard PQF (guided by mappings which have been written to match Koha's existing Zebra configuration) which can then be sent to Zebra. This driver, Koha::QueryParser::Driver::PQF(::*) extends the OpenILS::QueryParser(::*) class(es), so as to preserve maximum interoperability between the various users of the QueryParser driver. Initially, search syntax is as follows: * AND operator: * OR operator: || * GROUPING operators: ( ) Fields can mostly be searched using the ccl prefixes they have now. The exception is the various date limits which are searched with a syntax like this: pubdate(2008) For sorting, you can simply add #title-sort-az (etc.) to your query. Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Elliott Davis elli...@bywatersolions.com Test Passed successfully after installing missing dep for Test::Deep -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Elliott Davis elli...@bywatersolutions.com changed: What|Removed |Added Attachment #14182|0 |1 is obsolete|| --- Comment #21 from Elliott Davis elli...@bywatersolutions.com --- Created attachment 14951 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14951action=edit [Passed QA] Bug 9239: Add syspref to enable QueryParser In light of the experimental nature of the QueryParser code at this juncture, it behooves Koha to have the option of disabling QP, at least for the purpose of comparing results between QP-enabled and QP-disabled searches. This patch adds a UseQueryParser syspref to do just that. In cases where the user enables QP without having QP installed, however, there will be no dramatic failure, and Koha will simply fall back to using the non-QP search code. In order to reduce the overhead added by the introduction of QueryParser, this patch adds a C4::Context-queryparser accessor to a static QueryParser object which is initialized the first time it is required and then reset thereafter. Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Elliott Davis elli...@bywatersolions.com Fixed merge conflict in sysprefs.sql and updatedatabase.sql -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Elliott Davis elli...@bywatersolutions.com changed: What|Removed |Added Attachment #14183|0 |1 is obsolete|| --- Comment #22 from Elliott Davis elli...@bywatersolutions.com --- Created attachment 14952 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14952action=edit [Passed QA] Bug 9239: Allow the use of QueryParser for all queries With the inclusion of this patch, all searches will (try) to use QueryParser for handling queries for both the bibliographic and authority databases if UseQueryParser is enabled. If QueryParser is unavailable, UseQueryParser is disabled, or the search uses CCL indexes, the old search code will be used. To test: 1) Apply patch. 2) Run the unit test with `prove t/QueryParser.t` 3) Enable the UseQueryParser syspref. 4) Try searches that should return results in the following places: * OPAC (simple search) * OPAC (advanced search) * OPAC (authorities) * Staff client (header search) * Staff client (advanced search) * Staff client (cataloging search) * Staff client (authorities) * Staff client (importing a batch using a match point) * Staff client (searching for an item for adding to a label) * Staff client (acquisitions) * Staff client (searching for a record to create a serial) * ANYWHERE ELSE I HAVE FORGOTTEN 5) Disable the UseQueryParser syspref. Repeat at least some of the searches you did above. 6) If all searches worked, sign off. Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz Signed-off-by: Elliott Davis elli...@bywatersolions.com Searching still works as expected for variuos places. QueryParser syspref seemed to be enabled by default -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Elliott Davis elli...@bywatersolutions.com changed: What|Removed |Added Attachment #14847|0 |1 is obsolete|| --- Comment #23 from Elliott Davis elli...@bywatersolutions.com --- Created attachment 14953 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14953action=edit [Signed off] Bug 9239 follow-up: POD and perlcritic fixes There were several perlcritic violations for returning explicit undef, and splitting up the various driver classes resulted in POD compliance errors, where the POD was starting with head2 rather than head1. This patch fixes those errors (but has no functional impact). Signed-off-by: Elliott Davis elli...@bywatersolions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Elliott Davis elli...@bywatersolutions.com changed: What|Removed |Added Status|Signed Off |Passed QA CC||elli...@bywatersolutions.co ||m --- Comment #24 from Elliott Davis elli...@bywatersolutions.com --- Applied to fix a couple of merge issues. Appears to work as advertised. Provided test plan passes. I didn't experience the issues that katrin did but I already had those fields in my koha-conf xml file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #25 from Elliott Davis elli...@bywatersolutions.com --- I went back and removed a line from my conf file that I had from testing previously (which is why it worked for me initially) and re-ran make and got the same error as KF. Apologies for the mis-informed test. I think there should be a follow up to add this line to make but shouldn't be a reason to fail the test. (In reply to comment #24) Applied to fix a couple of merge issues. Appears to work as advertised. Provided test plan passes. I didn't experience the issues that katrin did but I already had those fields in my koha-conf xml file. --- Comment #26 from Elliott Davis elli...@bywatersolutions.com --- I went back and removed a line from my conf file that I had from testing previously (which is why it worked for me initially) and re-ran make and got the same error as KF. Apologies for the mis-informed test. I think there should be a follow up to add this line to make but shouldn't be a reason to fail the test. (In reply to comment #24) Applied to fix a couple of merge issues. Appears to work as advertised. Provided test plan passes. I didn't experience the issues that katrin did but I already had those fields in my koha-conf xml file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #25 from Elliott Davis elli...@bywatersolutions.com --- I went back and removed a line from my conf file that I had from testing previously (which is why it worked for me initially) and re-ran make and got the same error as KF. Apologies for the mis-informed test. I think there should be a follow up to add this line to make but shouldn't be a reason to fail the test. (In reply to comment #24) Applied to fix a couple of merge issues. Appears to work as advertised. Provided test plan passes. I didn't experience the issues that katrin did but I already had those fields in my koha-conf xml file. --- Comment #26 from Elliott Davis elli...@bywatersolutions.com --- I went back and removed a line from my conf file that I had from testing previously (which is why it worked for me initially) and re-ran make and got the same error as KF. Apologies for the mis-informed test. I think there should be a follow up to add this line to make but shouldn't be a reason to fail the test. (In reply to comment #24) Applied to fix a couple of merge issues. Appears to work as advertised. Provided test plan passes. I didn't experience the issues that katrin did but I already had those fields in my koha-conf xml file. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #17 from Katrin Fischer katrin.fisc...@bsz-bw.de --- Hi Jared, there is a little problem on updating the koha-conf.xml file for existing installations. I have tested this with 2 different installations now and updating the koha-conf.xml file to add the query parser line does not work for me. To reproduce: 1) Apply all patches 2) (Run database update) 3) Update koha-conf.xml: perl Makefile.PL --prev-install-log ../koha-dev/misc/koha-install-log make make test sudo make upgrade It prompted me for dom and icu (which I thought I had already activated). It completed successfully, but checking the generated file, the tag for the query parser is missing. Can you please take a look what's going wrong here? I will try to continue testing with a new installation. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #18 from Katrin Fischer katrin.fisc...@bsz-bw.de --- I set up a new dev installation with Normarc and the conf file still doesn't show anything related to the query parser: Last lines of my koha-conf.xml file: zebra_bib_index_modedom/zebra_bib_index_mode zebra_auth_index_modedom/zebra_auth_index_mode /config /yazgfs When I added the lines you gave me on IRC I was able to successfully test some searches with the new query syntax, so I think this might be the only piece missing? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #15 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 14847 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14847action=edit Bug 9239 follow-up: POD and perlcritic fixes There were several perlcritic violations for returning explicit undef, and splitting up the various driver classes resulted in POD compliance errors, where the POD was starting with head2 rather than head1. This patch fixes those errors (but has no functional impact). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Patch complexity|--- |Large patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #16 from Katrin Fischer katrin.fisc...@bsz-bw.de --- First tests look promising :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de QA Contact||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added CC||ch...@bigballofwax.co.nz --- Comment #10 from Chris Cormack ch...@bigballofwax.co.nz --- Tests all pass t/QueryParser.t .. ok All tests successful. Files=1, Tests=27, 0 wallclock secs ( 0.03 usr 0.01 sys + 0.14 cusr 0.01 csys = 0.19 CPU) Result: PASS Working through the rest of the test plan now -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #14172|0 |1 is obsolete|| --- Comment #11 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 14180 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14180action=edit Bug 9239: Add QueryParser module to Koha Although the OpenILS::QueryParser class is going to be moved into a separate CPAN distribution, this hasn't been done yet, and for ease of testing it makes sense to include the class in Koha for the moment. Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #14173|0 |1 is obsolete|| --- Comment #12 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 14181 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14181action=edit Bug 9239: Introduce QueryParser driver for PQF Since the most expressive query language supported by Zebra is PQF, this patch adds a PQF driver for QueryParser which will translate QueryParser queries into standard PQF (guided by mappings which have been written to match Koha's existing Zebra configuration) which can then be sent to Zebra. This driver, Koha::QueryParser::Driver::PQF(::*) extends the OpenILS::QueryParser(::*) class(es), so as to preserve maximum interoperability between the various users of the QueryParser driver. Initially, search syntax is as follows: * AND operator: * OR operator: || * GROUPING operators: ( ) Fields can mostly be searched using the ccl prefixes they have now. The exception is the various date limits which are searched with a syntax like this: pubdate(2008) For sorting, you can simply add #title-sort-az (etc.) to your query. Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #14174|0 |1 is obsolete|| --- Comment #13 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 14182 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14182action=edit Bug 9239: Add syspref to enable QueryParser In light of the experimental nature of the QueryParser code at this juncture, it behooves Koha to have the option of disabling QP, at least for the purpose of comparing results between QP-enabled and QP-disabled searches. This patch adds a UseQueryParser syspref to do just that. In cases where the user enables QP without having QP installed, however, there will be no dramatic failure, and Koha will simply fall back to using the non-QP search code. In order to reduce the overhead added by the introduction of QueryParser, this patch adds a C4::Context-queryparser accessor to a static QueryParser object which is initialized the first time it is required and then reset thereafter. Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #14175|0 |1 is obsolete|| --- Comment #14 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 14183 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14183action=edit Bug 9239: Allow the use of QueryParser for all queries With the inclusion of this patch, all searches will (try) to use QueryParser for handling queries for both the bibliographic and authority databases if UseQueryParser is enabled. If QueryParser is unavailable, UseQueryParser is disabled, or the search uses CCL indexes, the old search code will be used. To test: 1) Apply patch. 2) Run the unit test with `prove t/QueryParser.t` 3) Enable the UseQueryParser syspref. 4) Try searches that should return results in the following places: * OPAC (simple search) * OPAC (advanced search) * OPAC (authorities) * Staff client (header search) * Staff client (advanced search) * Staff client (cataloging search) * Staff client (authorities) * Staff client (importing a batch using a match point) * Staff client (searching for an item for adding to a label) * Staff client (acquisitions) * Staff client (searching for a record to create a serial) * ANYWHERE ELSE I HAVE FORGOTTEN 5) Disable the UseQueryParser syspref. Repeat at least some of the searches you did above. 6) If all searches worked, sign off. Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #14020|0 |1 is obsolete|| --- Comment #6 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 14172 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14172action=edit Bug 9239: Add QueryParser module to Koha Although the OpenILS::QueryParser class is going to be moved into a separate CPAN distribution, this hasn't been done yet, and for ease of testing it makes sense to include the class in Koha for the moment. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #14021|0 |1 is obsolete|| --- Comment #7 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 14173 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14173action=edit Bug 9239: Introduce QueryParser driver for PQF Since the most expressive query language supported by Zebra is PQF, this patch adds a PQF driver for QueryParser which will translate QueryParser queries into standard PQF (guided by mappings which have been written to match Koha's existing Zebra configuration) which can then be sent to Zebra. This driver, Koha::QueryParser::Driver::PQF(::*) extends the OpenILS::QueryParser(::*) class(es), so as to preserve maximum interoperability between the various users of the QueryParser driver. Initially, search syntax is as follows: * AND operator: * OR operator: || * GROUPING operators: ( ) Fields can mostly be searched using the ccl prefixes they have now. The exception is the various date limits which are searched with a syntax like this: pubdate(2008) For sorting, you can simply add #title-sort-az (etc.) to your query. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #14022|0 |1 is obsolete|| --- Comment #8 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 14174 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14174action=edit Bug 9239: Add syspref to enable QueryParser In light of the experimental nature of the QueryParser code at this juncture, it behooves Koha to have the option of disabling QP, at least for the purpose of comparing results between QP-enabled and QP-disabled searches. This patch adds a UseQueryParser syspref to do just that. In cases where the user enables QP without having QP installed, however, there will be no dramatic failure, and Koha will simply fall back to using the non-QP search code. In order to reduce the overhead added by the introduction of QueryParser, this patch adds a C4::Context-queryparser accessor to a static QueryParser object which is initialized the first time it is required and then reset thereafter. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Attachment #14023|0 |1 is obsolete|| --- Comment #9 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 14175 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14175action=edit Bug 9239: Allow the use of QueryParser for all queries With the inclusion of this patch, all searches will (try) to use QueryParser for handling queries for both the bibliographic and authority databases if UseQueryParser is enabled. If QueryParser is unavailable, UseQueryParser is disabled, or the search uses CCL indexes, the old search code will be used. To test: 1) Apply patch. 2) Run the unit test with `prove t/QueryParser.t` 3) Enable the UseQueryParser syspref. 4) Try searches that should return results in the following places: * OPAC (simple search) * OPAC (advanced search) * OPAC (authorities) * Staff client (header search) * Staff client (advanced search) * Staff client (cataloging search) * Staff client (authorities) * Staff client (importing a batch using a match point) * Staff client (searching for an item for adding to a label) * Staff client (acquisitions) * Staff client (searching for a record to create a serial) * ANYWHERE ELSE I HAVE FORGOTTEN 5) Disable the UseQueryParser syspref. Repeat at least some of the searches you did above. 6) If all searches worked, sign off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Mirko Tietgen mi...@abunchofthings.net changed: What|Removed |Added CC||mi...@abunchofthings.net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #1 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 14020 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14020action=edit Bug 9239: Add QueryParser module to Koha Although the OpenILS::QueryParser class is going to be moved into a separate CPAN distribution, this hasn't been done yet, and for ease of testing it makes sense to include the class in Koha for the moment. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #2 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 14021 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14021action=edit Bug 9239: Introduce QueryParser driver for PQF Since the most expressive query language supported by Zebra is PQF, this patch adds a PQF driver for QueryParser which will translate QueryParser queries into standard PQF (guided by mappings which have been written to match Koha's existing Zebra configuration) which can then be sent to Zebra. This driver, Koha::QueryParser::Driver::PQF(::*) extends the OpenILS::QueryParser(::*) class(es), so as to preserve maximum interoperability between the various users of the QueryParser driver. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #3 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 14022 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14022action=edit Bug 9239: Add syspref to enable QueryParser In light of the experimental nature of the QueryParser code at this juncture, it behooves Koha to have the option of disabling QP, at least for the purpose of comparing results between QP-enabled and QP-disabled searches. This patch adds a UseQueryParser syspref to do just that. In cases where the user enables QP without having QP installed, however, there will be no dramatic failure, and Koha will simply fall back to using the non-QP search code. In order to reduce the overhead added by the introduction of QueryParser, this patch adds a C4::Context-queryparser accessor to a static QueryParser object which is initialized the first time it is required and then resed thereafter. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 9239] Koha should share Evergreen's QueryParser module for parsing queries
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9239 --- Comment #4 from Jared Camins-Esakov jcam...@cpbibliography.com --- Created attachment 14023 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=14023action=edit Bug 9239: Allow the use of QueryParser for all queries With the inclusion of this patch, all searches will (try) to use QueryParser for handling queries for both the bibliographic and authority databases if UseQueryParser is enabled. If QueryParser is unavailable, UseQueryParser is disabled, or the search uses CCL indexes, the old search code will be used. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
