[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Patrick Robitaille  changed:

   What|Removed |Added

 CC||patrick.robitai...@ccsr.qc.
   ||ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #65910|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #65911|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #65914|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #65912|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #65913|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #66093|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #65909|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #113 from Katrin Fischer  ---
Created attachment 66098
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66098=edit
[SIGNED OFF] Bug 11317 - Move file access under Tools and add specific
permission

- Moves the .pl and .tt under tools/ instead of reports/ and adds
tools/access_files permission.
- Remove datatables-strings.inc from .tt
- Allow sorting on date column in file access tool.  For some reason, the table
was blocking sorting based on timestamp,
  even though most users would probably want that since the feature is used
primarily to access generated (daily) reports i
  and finding the last ones is very important.

Testing
-1) Having done requirements of previous patches, like adding 'accessdir' to
koha-conf...
0) apply patch, update database to add permission option.
1) Login as NON-superadmin.  Go under tools, see no Report/Log under the third
column
2) Go to add tools/access_file permission to user
3) See new entry under tools third column.
4) validate link is ok.

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #114 from Katrin Fischer  ---
Created attachment 66099
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66099=edit
[SIGNED OFF] Bug 11317 - Update the link under reports

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #112 from Katrin Fischer  ---
Created attachment 66097
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66097=edit
[SIGNED OFF] Bug 11317 - Allows for multiple directories to be accessible

It is now possible to add as many SOMEDIR as needed to
the config file.

Signed-off-by: Nick Clemens 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #115 from Katrin Fischer  ---
Created attachment 66100
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66100=edit
[SIGNED OFF] Bug 11317 - Follow-up - Fixing merge error and cosmetic changes

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #110 from Katrin Fischer  ---
Created attachment 66095
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66095=edit
[SIGNED OFF] Bug 11317: Follow up - Update ID to allow for permalinking

This follow up modifies the id parameter to use a digest of the
filename to enable permalinking to files even if the array order
changes due to new files being created.

Signed-off-by: Jonathan Druart 
Signed-off-by: Bernardo Gonzalez Kriegel 

Signed-off-by: Nick Clemens 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #111 from Katrin Fischer  ---
Created attachment 66096
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66096=edit
[SIGNED OFF] Bug 11317 - Rename config to 'accessdir' and fix qa

Also translate date with datetime format preference and move to Tools.

Signed-off-by: Nick Clemens 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #109 from Katrin Fischer  ---
Created attachment 66094
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66094=edit
[SIGNED OFF] Bug 11317: Adds a page to access log files on the server from the
intranet.

The directory used is defined by the "publiclogdir" preference in
koha-conf.xml.

Test case :

Preparation :
* Add the "publiclogdir" preference to your "koha-conf.xml" file. This
* preference should be in the "config" section. For this test cas, we
* will use the "/tmp/koha-public" directory :

 ...
  /tmp/koha-public
 ...

* Create the log directory on your server. Make sure this directory
* is readable by your web server :
$ mkdir /tmp/koha-public
* Add a test file in the log directory :
$ cd /tmp/koha-public
$ echo "Hello world!" > test.txt

Test :
* Go in the "Reports" section in the intranet and select "Report/log
* files"
* The "test.txt" should appear in the files list.
* Click on the "test.txt" file, a download dialog should appear.
* Download the file and verify its content. It should contain the
* text "Hello world!".

Sponsored by : CCSR

Signed-off-by: Jonathan Druart 
Signed-off-by: Bernardo Gonzalez Kriegel 
Signed-off-by: Nick Clemens 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Philippe Audet-Fortin  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #108 from Philippe Audet-Fortin  
---
Hi Katrine,
I found the problem. It didn't work with plack because when a file was
download, access_files.pl exited with error flag even there had no error. It
seem like plack doesn't love that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Philippe Audet-Fortin  changed:

   What|Removed |Added

  Attachment #66092|0   |1
is obsolete||

--- Comment #107 from Philippe Audet-Fortin  
---
Created attachment 66093
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66093=edit
Bug 11317 - Follow-up - Fixing merge error and cosmetic changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Philippe Audet-Fortin  changed:

   What|Removed |Added

  Attachment #66091|0   |1
is obsolete||

--- Comment #106 from Philippe Audet-Fortin  
---
Created attachment 66092
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66092=edit
Bug 11317 - Follow-up - Fixing merge error and cosmetic changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Philippe Audet-Fortin  changed:

   What|Removed |Added

  Attachment #65918|0   |1
is obsolete||

--- Comment #105 from Philippe Audet-Fortin  
---
Created attachment 66091
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66091=edit
Bug 11317 - Follow-up - Fixing merge error and cosmetic changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #104 from Katrin Fischer  ---
Global var in the BEGIN block might be the cause.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #103 from Katrin Fischer  ---
I have tested with Plack deactivated and it does WORK.

Using Plack is strongly recommende/standard setup now, so we really need it to
work under Plack too. I am leaving this as Failed QA and hope that the new
information will help you to fix it. We are close, please don't give up now.

The QA tools have some complaints, maybe it would help to squash at least the
patches by the same authors:

 OK etc/koha-conf.xml
   OK git manipulation
   OK xml_valid

 OK koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc
   OK forbidden patterns
   OK git manipulation
   OK spelling
   OK tt_valid
   OK valid_template

 OK koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc
   OK forbidden patterns
   OK git manipulation
   OK spelling
   OK tt_valid
   OK valid_template

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/reports/report_files.tt
   OK forbidden patterns
   FAIL   git manipulation
The file has been added and deleted in the same patchset
   OK spelling
   OK tt_valid
   OK valid_template

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt
   FAIL   forbidden patterns
forbidden pattern: tab char (line 55)
forbidden pattern: tab char (line 59)
forbidden pattern: tab char (line 65)
forbidden pattern: tab char (line 63)
forbidden pattern: tab char (line 61)
forbidden pattern: tab char (line 64)
forbidden pattern: tab char (line 57)
forbidden pattern: tab char (line 60)
forbidden pattern: tab char (line 58)
forbidden pattern: tab char (line 68)
forbidden pattern: tab char (line 72)
   OK git manipulation
   OK spelling
   OK tt_valid
   OK valid_template

 OK koha-tmpl/intranet-tmpl/prog/en/modules/tools/access_files.tt
   OK forbidden patterns
   OK git manipulation
   OK spelling
   OK tt_valid
   OK valid_template

 OK koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt
   OK forbidden patterns
   OK git manipulation
   OK spelling
   OK tt_valid
   OK valid_template

 FAIL   reports/report_files.pl
   OK critic
   OK forbidden patterns
   FAIL   git manipulation
The file has been added and deleted in the same patchset
   OK pod
   OK spelling
   OK valid

 OK tools/access_files.pl
   OK critic
   OK forbidden patterns
   OK git manipulation
   OK pod
   OK spelling
   OK valid

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #102 from Blou  ---
plack-error.log?  Curious, do you have the issue when not using plack?  Must be
some kind of permission issue... :(

Here it works like a charm.  But Philippe will confirm himself.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #101 from Katrin Fischer  ---
Hi Phillipe, follow-up is looking good, but I still can't open or download the
file. This is the error from the plack-error-log:
exited nonzero: 1 at /home/vagrant/kohaclone/tools/access_files.pl line 120.

Which is odd, as the file does end at line 107... :(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Philippe Audet-Fortin  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #100 from Philippe Audet-Fortin  
---
Sorry for the mess in the comment. 
I made the changes and now the patch apply without conflict.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Philippe Audet-Fortin  changed:

   What|Removed |Added

  Attachment #65915|0   |1
is obsolete||

--- Comment #99 from Philippe Audet-Fortin  
---
Created attachment 65918
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65918=edit
Bug 11317 - Follow-up - Fixing merge error and cosmetic changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Philippe Audet-Fortin  changed:

   What|Removed |Added

  Attachment #65856|0   |1
is obsolete||

--- Comment #98 from Philippe Audet-Fortin  
---
Created attachment 65915
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65915=edit
Bug 11317 - Follow-up - Fixing merge error and cosmetic changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Philippe Audet-Fortin  changed:

   What|Removed |Added

  Attachment #65857|0   |1
is obsolete||

--- Comment #97 from Philippe Audet-Fortin  
---
Created attachment 65914
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65914=edit
Bug 11317 - Update the link under reports

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Philippe Audet-Fortin  changed:

   What|Removed |Added

  Attachment #62973|0   |1
is obsolete||

--- Comment #94 from Philippe Audet-Fortin  
---
Created attachment 65911
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65911=edit
Bug 11317 - Rename config to 'accessdir' and fix qa

Also translate date with datetime format preference and move to Tools.

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Philippe Audet-Fortin  changed:

   What|Removed |Added

  Attachment #62975|0   |1
is obsolete||

--- Comment #96 from Philippe Audet-Fortin  
---
Created attachment 65913
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65913=edit
Bug 11317 - Move file access under Tools and add specific permission

- Moves the .pl and .tt under tools/ instead of reports/ and adds
tools/access_files permission.
- Remove datatables-strings.inc from .tt
- Allow sorting on date column in file access tool.  For some reason, the table
was blocking sorting based on timestamp,
  even though most users would probably want that since the feature is used
primarily to access generated (daily) reports i
  and finding the last ones is very important.

Testing
-1) Having done requirements of previous patches, like adding 'accessdir' to
koha-conf...
0) apply patch, update database to add permission option.
1) Login as NON-superadmin.  Go under tools, see no Report/Log under the third
column
2) Go to add tools/access_file permission to user
3) See new entry under tools third column.
4) validate link is ok.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Philippe Audet-Fortin  changed:

   What|Removed |Added

  Attachment #62974|0   |1
is obsolete||

--- Comment #95 from Philippe Audet-Fortin  
---
Created attachment 65912
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65912=edit
Bug 11317 - Allows for multiple directories to be accessible

It is now possible to add as many SOMEDIR as needed to
the config file.

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Philippe Audet-Fortin  changed:

   What|Removed |Added

  Attachment #62971|0   |1
is obsolete||

--- Comment #92 from Philippe Audet-Fortin  
---
Created attachment 65909
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65909=edit
Bug 11317: Adds a page to access log files on the server from the intranet.

The directory used is defined by the "publiclogdir" preference in
koha-conf.xml.

Test case :

Preparation :
* Add the "publiclogdir" preference to your "koha-conf.xml" file. This
* preference should be in the "config" section. For this test cas, we
* will use the "/tmp/koha-public" directory :

 ...
  /tmp/koha-public
 ...

* Create the log directory on your server. Make sure this directory
* is readable by your web server :
$ mkdir /tmp/koha-public
* Add a test file in the log directory :
$ cd /tmp/koha-public
$ echo "Hello world!" > test.txt

Test :
* Go in the "Reports" section in the intranet and select "Report/log
* files"
* The "test.txt" should appear in the files list.
* Click on the "test.txt" file, a download dialog should appear.
* Download the file and verify its content. It should contain the
* text "Hello world!".

Sponsored by : CCSR

Signed-off-by: Jonathan Druart 
Signed-off-by: Bernardo Gonzalez Kriegel 
Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Philippe Audet-Fortin  changed:

   What|Removed |Added

  Attachment #62972|0   |1
is obsolete||

--- Comment #93 from Philippe Audet-Fortin  
---
Created attachment 65910
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65910=edit
Bug 11317: Follow up - Update ID to allow for permalinking

This follow up modifies the id parameter to use a digest of the
filename to enable permalinking to files even if the array order
changes due to new files being created.

Signed-off-by: Jonathan Druart 
Signed-off-by: Bernardo Gonzalez Kriegel 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Eric Bégin  changed:

   What|Removed |Added

 CC|simith.dolive...@inlibro.co |
   |m   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Eric Bégin  changed:

   What|Removed |Added

 CC|maxime.beaul...@inlibro.com |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #91 from Katrin Fischer  ---
Sorry, yes, that's what I meant!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #90 from Philippe Audet-Fortin  
---
When you say remove the link from the tools page, do you mean report page?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #89 from Katrin Fischer  ---
Please:
- Remove link from the tools page
- Include link in the tools menu
koha-tmpl/intranet-tmpl/prog/en/includes/tools-menu.inc

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #88 from Katrin Fischer  ---
Philippe, you also killed my follow-up :(

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #87 from Philippe Audet-Fortin  
---
The new attachment are there because I had sha1 error. I change nothing. 
However I don't see why you can't access files. Everything seem to work. I
tried with different type of files and permissions and I can't replicate the
error.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Philippe Audet-Fortin  changed:

   What|Removed |Added

  Attachment #65855|0   |1
is obsolete||

--- Comment #86 from Philippe Audet-Fortin  
---
Created attachment 65857
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65857=edit
Bug 11317 - Update the link under reports

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Philippe Audet-Fortin  changed:

   What|Removed |Added

  Attachment #65691|0   |1
is obsolete||

--- Comment #85 from Philippe Audet-Fortin  
---
Created attachment 65856
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65856=edit
Bug 11317 - Follow-up - Fixing merge error and cosmetic changes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #84 from Philippe Audet-Fortin  
---
Created attachment 65855
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65855=edit
Bug 11317 - Update the link under reports

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #83 from Katrin Fischer  ---
Philippe, can this be tested again?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Philippe Audet-Fortin  changed:

   What|Removed |Added

  Attachment #65851|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Philippe Audet-Fortin  changed:

   What|Removed |Added

  Attachment #64089|0   |1
is obsolete||

--- Comment #82 from Philippe Audet-Fortin  
---
Created attachment 65851
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65851=edit
Bug 11317 - Move file access under Tools and add specific permission

- Moves the .pl and .tt under tools/ instead of reports/ and adds
tools/access_files permission.
- Remove datatables-strings.inc from .tt
- Allow sorting on date column in file access tool.  For some reason, the table
was blocking sorting based on timestamp,
  even though most users would probably want that since the feature is used
primarily to access generated (daily) reports i
  and finding the last ones is very important.

Testing
-1) Having done requirements of previous patches, like adding 'accessdir' to
koha-conf...
0) apply patch, update database to add permission option.
1) Login as NON-superadmin.  Go under tools, see no Report/Log under the third
column
2) Go to add tools/access_file permission to user
3) See new entry under tools third column.
4) validate link is ok.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Philippe Audet-Fortin  changed:

   What|Removed |Added

  Attachment #64089|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Philippe Audet-Fortin  changed:

   What|Removed |Added

 CC||philippe.audet-fortin@inlib
   ||ro.com
  Attachment #64089|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #81 from Katrin Fischer  ---
Created attachment 65691
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65691=edit
Bug 11317 - Follow-up - Fixing merge error and cosmetic changes

- Fixed conflicts on reports-home.tt from adding/removing
  the link before moving it to tools
- Slightly reworded second line on the tools page to be
  a bit more verbose.
- Added entry to the tools-menu.inc.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-08-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #80 from Katrin Fischer  ---
I am testing with a kohadevbox, but have problems to access the file, even
though it is listed on the page. This is what I did:

- Added the entry to koha-conf.xml, copied from the plugins/uploads default
  /var/lib/koha/kohadev/files
- Created a file with runreport.pl and moved it to the files directory
- The file is listed on the tool page
- When I try to access the file, I get "internal server error"
- The Plack error log shows:
  /home/vagrant/kohaclone/tools/access_files.pl line 119.
  I thought it might be permission related, but even with 
  777 the problem remains:
  -rwxrwxrwx 1 kohadev-koha kohadev-koha 592 Aug  8  2017 report1.csv

While testing I've made a few little changes:
- Fixed conflicts on reports-home.tt from adding/removing the link before
moving it to tools
- Slightly reworded second line on the tools page to be a bit more verbose.
- Added entry to the tools-menu.inc.

Attaching this as a follow-up for sign-off if you agree.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-07-03 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Blou  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #79 from Blou  ---
Should have been in Need Signoff for a month, now.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Philippe Audet-Fortin  changed:

   What|Removed |Added

  Attachment #64088|0   |1
is obsolete||

--- Comment #78 from Philippe Audet-Fortin  
---
Created attachment 64089
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64089=edit
Bug 11317 - Update the link under reports

Signed-off-by: Paudet 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-06-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #77 from Philippe Audet-Fortin  
---
Created attachment 64088
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64088=edit
Bug 11317 - Update the link under reports

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-05-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

M. Tompsett  changed:

   What|Removed |Added

 CC|mtomp...@hotmail.com|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-05-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #76 from Katrin Fischer  ---
Ok, trying to get this tested :)

First: QA tools:

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/reports/report_files.tt
   FAIL   git manipulation
The file has been added and deleted in the same patchset

 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/reports/reports-home.tt
   FAIL   forbidden patterns
forbidden pattern: tab char (line 55)
forbidden pattern: tab char (line 68)
forbidden pattern: tab char (line 63)
forbidden pattern: tab char (line 61)
forbidden pattern: tab char (line 64)
forbidden pattern: tab char (line 58)
forbidden pattern: tab char (line 65)
forbidden pattern: tab char (line 73)
forbidden pattern: tab char (line 59)
forbidden pattern: tab char (line 57)
forbidden pattern: tab char (line 60)

 FAIL   reports/report_files.pl
   FAIL   git manipulation
The file has been added and deleted in the same patchset

Easy to fix - as we got no sign-off yet, we'd just need to fix the tabs and
squash the patches.

Second: Some code review

1) I think as the permission is under Tools and the files live there too, it
should also be shown as a tool on the tools page instead of under reports. I'd
put it under "Additional tools", maybe under the log viewer.
Report/log files

2) When I click on the link under Reports, I get a 'not found' error. What am I
missing?

3) Looking at the history of this bug, are we missing 2 patches?
Bug 11317 - Allow sorting on date column in file access tool. (1.29 KB, patch)
Bug 11317 - Remove datatables-strings.inc from .tt (959 bytes, patch) 

4) 
+use strict;
+use warnings;
Shoudl be: use Modern::Perl;

Sorry, can't test further because of 2)!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Blou  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

--- Comment #75 from Blou  ---
Rebased the (evil Sha1!!) patch .  Squashed the unsigned patches (last three). 
Ready for take off.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Blou  changed:

   What|Removed |Added

  Attachment #58224|0   |1
is obsolete||

--- Comment #74 from Blou  ---
Created attachment 62975
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62975=edit
Bug 11317 - Move file access under Tools and add specific permission

- Moves the .pl and .tt under tools/ instead of reports/ and adds
tools/access_files permission.
- Remove datatables-strings.inc from .tt
- Allow sorting on date column in file access tool.  For some reason, the table
was blocking sorting based on timestamp,
  even though most users would probably want that since the feature is used
primarily to access generated (daily) reports i
  and finding the last ones is very important.

Testing
-1) Having done requirements of previous patches, like adding 'accessdir' to
koha-conf...
0) apply patch, update database to add permission option.
1) Login as NON-superadmin.  Go under tools, see no Report/Log under the third
column
2) Go to add tools/access_file permission to user
3) See new entry under tools third column.
4) validate link is ok.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Blou  changed:

   What|Removed |Added

  Attachment #58223|0   |1
is obsolete||

--- Comment #73 from Blou  ---
Created attachment 62974
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62974=edit
Bug 11317 - Allows for multiple directories to be accessible

It is now possible to add as many SOMEDIR as needed to
the config file.

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Blou  changed:

   What|Removed |Added

  Attachment #58221|0   |1
is obsolete||

--- Comment #71 from Blou  ---
Created attachment 62972
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62972=edit
Bug 11317: Follow up - Update ID to allow for permalinking

This follow up modifies the id parameter to use a digest of the
filename to enable permalinking to files even if the array order
changes due to new files being created.

Signed-off-by: Jonathan Druart 
Signed-off-by: Bernardo Gonzalez Kriegel 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Blou  changed:

   What|Removed |Added

  Attachment #58220|0   |1
is obsolete||

--- Comment #70 from Blou  ---
Created attachment 62971
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62971=edit
Bug 11317: Adds a page to access log files on the server from the intranet.

The directory used is defined by the "publiclogdir" preference in
koha-conf.xml.

Test case :

Preparation :
* Add the "publiclogdir" preference to your "koha-conf.xml" file. This
* preference should be in the "config" section. For this test cas, we
* will use the "/tmp/koha-public" directory :

 ...
  /tmp/koha-public
 ...

* Create the log directory on your server. Make sure this directory
* is readable by your web server :
$ mkdir /tmp/koha-public
* Add a test file in the log directory :
$ cd /tmp/koha-public
$ echo "Hello world!" > test.txt

Test :
* Go in the "Reports" section in the intranet and select "Report/log
* files"
* The "test.txt" should appear in the files list.
* Click on the "test.txt" file, a download dialog should appear.
* Download the file and verify its content. It should contain the
* text "Hello world!".

Sponsored by : CCSR

Signed-off-by: Jonathan Druart 
Signed-off-by: Bernardo Gonzalez Kriegel 
Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Blou  changed:

   What|Removed |Added

  Attachment #58222|0   |1
is obsolete||

--- Comment #72 from Blou  ---
Created attachment 62973
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62973=edit
Bug 11317 - Rename config to 'accessdir' and fix qa

Also translate date with datetime format preference and move to Tools.

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Blou  changed:

   What|Removed |Added

  Attachment #58225|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-05-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Blou  changed:

   What|Removed |Added

  Attachment #58226|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet

2017-05-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
Summary|Add a way to access files   |Add a way to access files
   |from the intranet.  |from the intranet

--- Comment #69 from Katrin Fischer  ---
Sorry, this does no longer apply:

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 11317: Adds a page to access log files on the server from the
intranet.
Auto packing the repository in background for optimum performance.
See "git help gc" for manual housekeeping.
Applying: Bug 11317: Follow up - Update ID to allow for permalinking
Auto packing the repository in background for optimum performance.
See "git help gc" for manual housekeeping.
Applying: Bug 11317 - Rename config to 'accessdir' and fix qa
Applying: Bug 11317 - Allows for multiple directories to be accessible
Applying: Bug 11317 - Move file access under Tools and add specific permission
fatal: sha1 information is lacking or useless
(koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt).
Repository lacks necessary blobs to fall back on 3-way merge.
Cannot fall back to three-way merge.
Patch failed at 0001 Bug 11317 - Move file access under Tools and add specific
permission
The copy of the patch that failed is found in:
   /home/vagrant/kohaclone/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in
/tmp/Bug-11317---Move-file-access-under-Tools-and-add-s-D7DJsU.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet.

2016-12-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #66 from Charles Farmer  ---
Created attachment 58224
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58224=edit
Bug 11317 - Move file access under Tools and add specific permission

Moves the .pl and .tt under tools/ instead of reports/ and adds
tools/access_files permission.

Testing
-1) Having done requirements of previous patches, like adding 'accessdir' to
koha-conf...
0) apply patch, update database to add permission option.
1) Login as NON-superadmin.  Go under tools, see no Report/Log under the third
column
2) Go to add tools/access_file permission to user
3) See new entry under tools third column.
4) validate link is ok.

Sponsored by : CCSR

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet.

2016-12-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #64 from Charles Farmer  ---
Created attachment 58222
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58222=edit
Bug 11317 - Rename config to 'accessdir' and fix qa

Also translate date with datetime format preference and move to Tools.

Test preparation :
* Add the "accessdir" preference to your "koha-conf.xml" file. This
* preference should be in the "config" section. For this test cas, we
* will use the "/tmp/files-access" directory :

 ...
  /tmp/files-access
 ...

* Create the log directory on your server. Make sure this directory
* is readable by your web server :
$ mkdir /tmp/files-access
* Add a test file in the log directory :
$ cd /tmp/files-access
$ echo "Hello world!" > test.txt

Test :
* Go in the "tools/Additional tools" section in the intranet and select
"Report/log
* files"
* The "test.txt" should appear in the files list.
* Click on the "test.txt" file, a download dialog should appear.
* Download the file and verify its content. It should contain the
* text "Hello world!".

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet.

2016-12-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Charles Farmer  changed:

   What|Removed |Added

  Attachment #49944|0   |1
is obsolete||
  Attachment #49945|0   |1
is obsolete||
  Attachment #49946|0   |1
is obsolete||
  Attachment #49947|0   |1
is obsolete||
  Attachment #50425|0   |1
is obsolete||
  Attachment #50440|0   |1
is obsolete||
  Attachment #53446|0   |1
is obsolete||

--- Comment #62 from Charles Farmer  ---
Created attachment 58220
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58220=edit
Bug 11317: Adds a page to access log files on the server from the intranet.

The directory used is defined by the "publiclogdir" preference in
koha-conf.xml.

Test case :

Preparation :
* Add the "publiclogdir" preference to your "koha-conf.xml" file. This
* preference should be in the "config" section. For this test cas, we
* will use the "/tmp/koha-public" directory :

 ...
  /tmp/koha-public
 ...

* Create the log directory on your server. Make sure this directory
* is readable by your web server :
$ mkdir /tmp/koha-public
* Add a test file in the log directory :
$ cd /tmp/koha-public
$ echo "Hello world!" > test.txt

Test :
* Go in the "Reports" section in the intranet and select "Report/log
* files"
* The "test.txt" should appear in the files list.
* Click on the "test.txt" file, a download dialog should appear.
* Download the file and verify its content. It should contain the
* text "Hello world!".

Signed-off-by: Jonathan Druart 
Signed-off-by: Bernardo Gonzalez Kriegel 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet.

2016-12-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #65 from Charles Farmer  ---
Created attachment 58223
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58223=edit
Bug 11317 - Allows for multiple directories to be accessible

It is now possible to add as many SOMEDIR as needed to
the config file.

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet.

2016-12-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #67 from Charles Farmer  ---
Created attachment 58225
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58225=edit
Bug 11317 - Allow sorting on date column in file access tool.

For some reason, the table was blocking sorting based on timestamp, even though
most users would probably want that
since the feature is used primarily to access generated (daily) reports and
finding the last ones is very important.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet.

2016-12-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #68 from Charles Farmer  ---
Created attachment 58226
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58226=edit
Bug 11317 - Remove datatables-strings.inc from .tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet.

2016-12-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #63 from Charles Farmer  ---
Created attachment 58221
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=58221=edit
Bug 11317: Follow up - Update ID to allow for permalinking

This follow up modifies the id parameter to use a digest of the
filename to enable permalinking to files even if the array order
changes due to new files being created.

Signed-off-by: Jonathan Druart 
Signed-off-by: Bernardo Gonzalez Kriegel 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet.

2016-12-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Charles Farmer  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff
 CC||charles.far...@inlibro.com

--- Comment #61 from Charles Farmer  ---
For easier testing, I'm resubmitting the whole shebang rebased on the current
master.

Patches to follow

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet.

2016-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Nicolas Legrand  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||nicolas.legr...@bulac.fr

--- Comment #60 from Nicolas Legrand  ---
Tried to rebase it, but after a couple of apply --continue, I've lost track of
where I was and where I should go :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet.

2016-07-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #59 from Blou  ---
Created attachment 53446
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53446=edit
Bug 11317 - Remove datatables-strings.inc from .tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet.

2016-04-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #58 from Blou  ---
Created attachment 50440
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50440=edit
Bug 11317 - Allow sorting on date column in file access tool.

For some reason, the table was blocking sorting based on timestamp, even though
most users would probably want that
since the feature is used primarily to access generated (daily) reports and
finding the last ones is very important.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet.

2016-04-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Blou  changed:

   What|Removed |Added

  Attachment #50424|0   |1
is obsolete||

--- Comment #57 from Blou  ---
Created attachment 50425
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50425=edit
Bug 11317 - Move file access under Tools and add specific permission

Moves the .pl and .tt under tools/ instead of reports/ and adds
tools/access_files permission.

Testing
-1) Having done requirements of previous patches, like adding 'accessdir' to
koha-conf...
0) apply patch, update database to add permission option.
1) Login as NON-superadmin.  Go under tools, see no Report/Log under the third
column
2) Go to add tools/access_file permission to user
3) See new entry under tools third column.
4) validate link is ok.

Sponsored by : CCSR

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet.

2016-04-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Blou  changed:

   What|Removed |Added

  Attachment #50421|0   |1
is obsolete||

--- Comment #56 from Blou  ---
Created attachment 50424
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50424=edit
Bug 11317 - Move file access under Tools and add specific permission

Moves the .pl and .tt under tools/ instead of reports/ and adds
tools/access_files permission.

Testing
-1) Having done requirements of previous patches, like adding 'accessdir' to
koha-conf...
0) apply patch, update database to add permission option.
1) Login as NON-superadmin.  Go under tools, see no Report/Log under the third
column
2) Go to add tools/access_file permission to user
3) See new entry under tools third column.
4) validate link is ok.

Sponsored by : CCSR

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet.

2016-04-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Blou  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

--- Comment #55 from Blou  ---
THe little patch that could.  Should cover all the points discussed EXCEPT the
sha1 which I did not experience.  I would have done a squash, but this little
patch is easier to review.

I *think* i covered all bases.  Template, code, db...  Hopefully.  I hope...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet.

2016-04-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #54 from Blou  ---
Created attachment 50421
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50421=edit
Bug 11317 - Move file access under Tools and add specific permission

Moves the .pl and .tt under tools/ instead of reports/ and adds
tools/access_files permission.

Testing
-1) Having done requirements of previous patches, like adding 'accessdir' to
koha-conf...
0) apply patch, update database to add permission option.
1) Login as NON-superadmin.  Go under tools, see no Report/Log under the third
column
2) Go to add tools/access_file permission to user
3) See new entry under tools third column.
4) validate link is ok.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet.

2016-04-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #53 from Blou  ---
#koha voted for "tools".  I will add new patch moving files under /tools, and
add new permission for it.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet.

2016-04-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #52 from Blou  ---
Although viewiing the action logs is a tool, not a report.  So I'm not sure
this fits.  
Personnally, I view "reports" really as giving me a report.  And reports do not
have sub-permissions, really.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet.

2016-04-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #51 from Kyle M Hall  ---
(In reply to Blou from comment #49)

I think from a usability/permissions/technical standpoint this should probably
be considered a report. This script does not alter data, but only makes it
accessible. This makes it technically a "report" to me.

Furthermore, it seems likely that the librarians needing to access this data
are the same ones who would run other reports, and not necessarily be the same
ones running tools. This to me is another reason to move it back to the reports
page.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet.

2016-04-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #50 from Katrin Fischer  ---
To me this feels more like a tool and I really like the idea of having a
separate permission. Starting a little survey on #koha to get some more
opinions.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet.

2016-04-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #49 from Blou  ---
I can rebase the patches.  

But before that, I'd like to understand something: this was a report that
became a tool, but it's still a report (reports/report_files.pl) and has report
permissions.  While being always available in the tools list... as long as you
have access to other tools (because with 'reports' right you can run the report
if you have the URL, but you can't view it in tools-home.tt unless you have
some other tool access, which you don't necessarily want to give).

My suggestion:
- Make it fully a report OR a tool.  Moving/renaming the files accordingly.
- Add a specific permission to it if it's a tool.

This is an original CCSR patch we've alreay put lot of hours on to make it
acceptable, so I hate to pull the rug under so many Signed-off, and I fear the
"In discussion", but the situation descrived above is live with a customer, so
this is a real-world problem.  

If a QA would just tell me the standard acceptable solution, I'll code it
quickly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet.

2016-04-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Blou  changed:

   What|Removed |Added

   Assignee|bouzid.ferg...@inlibro.com  |philippe.blo...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet.

2016-04-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl
 Status|Signed Off  |Patch doesn't apply

--- Comment #48 from Marcel de Rooy  ---
Applying: Bug 11317 - Rename config to 'accessdir' and fix qa
fatal: sha1 information is lacking or useless
(koha-tmpl/intranet-tmpl/prog/en/modules/reports/report_files.tt).
Repository lacks necessary blobs to fall back on 3-way merge.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet.

2016-04-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Nick Clemens  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #47 from Nick Clemens  ---
(In reply to Katrin Fischer from comment #46)
> Hi Nick, that qa test problem will be fixed by another patch soon. Is this
> otherwise ok?

Yes

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet.

2016-04-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

--- Comment #46 from Katrin Fischer  ---
Hi Nick, that qa test problem will be fixed by another patch soon. Is this
otherwise ok?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet.

2016-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Nick Clemens  changed:

   What|Removed |Added

  Attachment #49944|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet.

2016-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Nick Clemens  changed:

   What|Removed |Added

  Attachment #39784|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet.

2016-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Nick Clemens  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #45 from Nick Clemens  ---
Very minor conflict from EDI cleared

qa tool complains:
 FAIL   reports/report_files.pl
   OK critic
   OK forbidden patterns
   OK pod
   OK spelling
   FAIL   valid
Name "Tie::Hash::FIELDS" used only once: possible typo 
Name "Cache::RemovalStrategy::LRU::FIELDS" used only once:
possible typo 
Name "Cache::RemovalStrategy::FIELDS" used only once: possible
typo

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet.

2016-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
  Attachment #39783|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet.

2016-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Nick Clemens  changed:

   What|Removed |Added

  Attachment #49944|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet.

2016-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Nick Clemens  changed:

   What|Removed |Added

  Attachment #49943|0   |1
is obsolete||

--- Comment #43 from Nick Clemens  ---
Created attachment 49946
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49946=edit
Bug 11317 - Rename config to 'accessdir' and fix qa

Also translate date with datetime format preference and move to Tools.

Test preparation :
* Add the "accessdir" preference to your "koha-conf.xml" file. This
* preference should be in the "config" section. For this test cas, we
* will use the "/tmp/files-access" directory :

 ...
  /tmp/files-access
 ...

* Create the log directory on your server. Make sure this directory
* is readable by your web server :
$ mkdir /tmp/files-access
* Add a test file in the log directory :
$ cd /tmp/files-access
$ echo "Hello world!" > test.txt

Test :
* Go in the "tools/Additional tools" section in the intranet and select
"Report/log
* files"
* The "test.txt" should appear in the files list.
* Click on the "test.txt" file, a download dialog should appear.
* Download the file and verify its content. It should contain the
* text "Hello world!".

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet.

2016-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Nick Clemens  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet.

2016-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Nick Clemens  changed:

   What|Removed |Added

  Attachment #48635|0   |1
is obsolete||

--- Comment #44 from Nick Clemens  ---
Created attachment 49947
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49947=edit
Bug 11317 - Allows for multiple directories to be accessible

It is now possible to add as many SOMEDIR as needed to
the config file.

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet.

2016-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Nick Clemens  changed:

   What|Removed |Added

  Attachment #49942|0   |1
is obsolete||

--- Comment #42 from Nick Clemens  ---
Created attachment 49945
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49945=edit
Bug 11317: Follow up - Update ID to allow for permalinking

This follow up modifies the id parameter to use a digest of the
filename to enable permalinking to files even if the array order
changes due to new files being created.

Signed-off-by: Jonathan Druart 
Signed-off-by: Bernardo Gonzalez Kriegel 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 11317] Add a way to access files from the intranet.

2016-04-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11317

Nick Clemens  changed:

   What|Removed |Added

  Attachment #49941|0   |1
is obsolete||

--- Comment #41 from Nick Clemens  ---
Created attachment 49944
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49944=edit
Bug 11317: Adds a page to access log files on the server from the intranet.

The directory used is defined by the "publiclogdir" preference in
koha-conf.xml.

Test case :

Preparation :
* Add the "publiclogdir" preference to your "koha-conf.xml" file. This
* preference should be in the "config" section. For this test cas, we
* will use the "/tmp/koha-public" directory :

 ...
  /tmp/koha-public
 ...

* Create the log directory on your server. Make sure this directory
* is readable by your web server :
$ mkdir /tmp/koha-public
* Add a test file in the log directory :
$ cd /tmp/koha-public
$ echo "Hello world!" > test.txt

Test :
* Go in the "Reports" section in the intranet and select "Report/log
* files"
* The "test.txt" should appear in the files list.
* Click on the "test.txt" file, a download dialog should appear.
* Download the file and verify its content. It should contain the
* text "Hello world!".

Signed-off-by: Jonathan Druart 
Signed-off-by: Bernardo Gonzalez Kriegel 

Signed-off-by: Nick Clemens 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >