[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 --- Comment #13 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #11) > 1. I prefer the version without Marcel's patch (especially because of the > size of the parameter list) I have seen

[Koha-bugs] [Bug 17833] _initilize_memcached() warns if errors

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17833 --- Comment #8 from Jonathan Druart --- Created attachment 70307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70307=edit Bug 17833: Make sure this warning will not be

[Koha-bugs] [Bug 19911] Passwords displayed to user during self-registration are not HTML-encoded

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19911 --- Comment #7 from sandbo...@biblibre.com --- Created attachment 70308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70308=edit Bug 19911: Do not escape html characters when saving

[Koha-bugs] [Bug 19911] Passwords displayed to user during self-registration are not HTML-encoded

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19911 sandbo...@biblibre.com changed: What|Removed |Added Attachment #70289|0

[Koha-bugs] [Bug 19911] Passwords displayed to user during self-registration are not HTML-encoded

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19911 --- Comment #8 from sandbo...@biblibre.com --- Created attachment 70309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70309=edit Bug 19911: Escape password value during self-registration

[Koha-bugs] [Bug 19884] Improve performance of GetItem

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884 --- Comment #40 from David Gustafsson --- As far as I know the Mysql 'max_allowed_packet' setting is the only concern for large IN-clauses, 1MB is the default I think (but can be raised if necessary). 1MB is

[Koha-bugs] [Bug 19920] New: changepasswordis exported from C4:: Members but has been removed

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19920 Bug ID: 19920 Summary: changepasswordis exported from C4::Members but has been removed Change sponsored?: --- Product: Koha Version: unspecified Hardware:

[Koha-bugs] [Bug 16853] Move changepassword to Koha::Patron->update_password

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16853 Jonathan Druart changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 19920] changepassword is exported from C4:: Members but has been removed

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19920 Jonathan Druart changed: What|Removed |Added

[Koha-bugs] [Bug 19922] New: Reordering of fields in elasticsearch mapping configuration does not work

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19922 Bug ID: 19922 Summary: Reordering of fields in elasticsearch mapping configuration does not work Change sponsored?: --- Product: Koha Version: master

[Koha-bugs] [Bug 15407] Move the patron categories related code to Koha::Patron:: Categories - part 2

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15407 Jonathan Druart changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 19921] Error when updating child to adult patron on system with only one adult patron category

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19921 Jonathan Druart changed: What|Removed |Added Depends on|

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 --- Comment #12 from Jonathan Druart --- Created attachment 70306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70306=edit Bug 19792: Few minor fixes - No string

[Koha-bugs] [Bug 19921] Error when updating child to adult patron on system with only one adult patron category

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19921 --- Comment #2 from Jonathan Druart --- Created attachment 70313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70313=edit Bug 19921: Fix update child when only one adult

[Koha-bugs] [Bug 19921] Error when updating child to adult patron on system with only one adult patron category

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19921 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Marcel de Rooy changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 19921] New: Error when updating child to adult patron on system with only one adult patron category

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19921 Bug ID: 19921 Summary: Error when updating child to adult patron on system with only one adult patron category Change sponsored?: --- Product: Koha Version: master

[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 Owen Leonard changed: What|Removed |Added Depends on||19921

[Koha-bugs] [Bug 18071] Add new script update_authorities.pl

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18071 Nick Clemens changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit

[Koha-bugs] [Bug 18071] Add new script update_authorities.pl

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18071 --- Comment #18 from Nick Clemens --- Created attachment 70312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70312=edit Bug 18071: (QA Followup) - Add additional feedback and expand

[Koha-bugs] [Bug 19911] Passwords displayed to user during self-registration are not HTML-encoded

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19911 sandbo...@biblibre.com changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19911] Passwords displayed to user during self-registration are not HTML-encoded

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19911 sandbo...@biblibre.com changed: What|Removed |Added Attachment #70271|0

[Koha-bugs] [Bug 18071] Add new script update_authorities.pl

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18071 Nick Clemens changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 18071] Add new script update_authorities.pl

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18071 --- Comment #17 from Nick Clemens --- Created attachment 70311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70311=edit Bug 18071: (QA follow-up) Add commit parameter, add warning

[Koha-bugs] [Bug 18071] Add new script update_authorities.pl

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18071 Nick Clemens changed: What|Removed |Added Attachment #66854|0 |1

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19911] Passwords displayed to user during self-registration are not HTML-encoded

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19911 --- Comment #9 from Arturo --- Just tested again and it looks great to me. Thank you for your work on this, Jonathan! -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 13520] add rental to circ matrix

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13520 Mike changed: What|Removed |Added CC||blac...@gmail.com

[Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 --- Comment #8 from Owen Leonard --- Created attachment 70315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70315=edit Bug 19474 (Follow-up) Convert staff client CSS to SCSS This patch

[Koha-bugs] [Bug 12001] GetMemberAccountRecords slows down display of patron details and checkout pages

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12001 Jonathan Druart changed: What|Removed |Added Status|NEW

[Koha-bugs] [Bug 12001] GetMemberAccountRecords slows down display of patron details and checkout pages

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12001 --- Comment #1 from Jonathan Druart --- Created attachment 70314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70314=edit Bug 12001: Move

[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 --- Comment #5 from Owen Leonard --- *** Bug 19728 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 17858] Omnibus: Move staff client JavaScript to the footer

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17858 Bug 17858 depends on bug 19728, which changed state. Bug 19728 Summary: Move template JavaScript to the footer: Circulation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19728 What|Removed

[Koha-bugs] [Bug 19728] Move template JavaScript to the footer: Circulation

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19728 Owen Leonard changed: What|Removed |Added Status|ASSIGNED

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #18 from Nick Clemens --- Created attachment 70295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70295=edit Bug 15494 - Followup: Make sure items in tests are not overdue

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Nick Clemens changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #19 from Nick Clemens --- It seems due dates were being set to now. If the tests take long enough to run then the items were overdue. Set the date in the future now -- You are receiving this

[Koha-bugs] [Bug 19641] Move patron templates JavaScript to the footer

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19641 --- Comment #6 from Owen Leonard --- (In reply to Josef Moravec from comment #4) > Few buttons in patron toolbar on checkouts screen does not work - > circulation.tt is not part of this patch and so does not

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 --- Comment #7 from Marcel de Rooy --- (In reply to David Bourgault from comment #6) > I don't think I can move the recursive sub out of GetBudgetHierarchy, since > it calls variables local to that

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 --- Comment #9 from Marcel de Rooy --- Created attachment 70297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70297=edit Bug 19792: (QA follow-up) Move anonymous sub out of GetHierarchy

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 Marcel de Rooy changed: What|Removed |Added Attachment #69960|0

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 Marcel de Rooy changed: What|Removed |Added Patch complexity|---

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 Marcel de Rooy changed: What|Removed |Added Attachment #70297|0

[Koha-bugs] [Bug 19792] Reduce number of SQL calls in GetBudgetHierarchy

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19792 Marcel de Rooy changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 18007] Interface updates to notices and notice previews

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18007 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't

[Koha-bugs] [Bug 18007] Interface updates to notices and notice previews

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18007 Jonathan Druart changed: What|Removed |Added Attachment #69413|0

[Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't

[Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981 --- Comment #40 from Jonathan Druart --- Created attachment 70303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70303=edit Bug 17981: Better error handling

[Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981 --- Comment #39 from Jonathan Druart --- Created attachment 70302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70302=edit Bug 17981: Add a preview mode for notice

[Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981 Jonathan Druart changed: What|Removed |Added Attachment #67144|0

[Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981 --- Comment #38 from Jonathan Druart --- Created attachment 70301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70301=edit Bug 17981: Add a 'letter' param to

[Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981 --- Comment #41 from Jonathan Druart --- Created attachment 70304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70304=edit Bug 17981: Move the divs to the top of the

[Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981 --- Comment #42 from Jonathan Druart --- Created attachment 70305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70305=edit Bug 17981: Remove uneeded module JS var As we

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #20 from Marcel de Rooy --- (In reply to Nick Clemens from comment #19) > It seems due dates were being set to now. If the tests take long enough to > run then the items were overdue. Set the

[Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX )

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #59 from Marcel de Rooy --- +eval { eval "require $linker_module"; }; Does not look good. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX )

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #60 from Marcel de Rooy --- Bouzid: I will still continue on this one. But how do you make sure that you do not save a personal name into say field 610 that should only include corporate names ?

[Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX )

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit

[Koha-bugs] [Bug 19884] Improve performance of GetItem

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884 --- Comment #32 from David Gustafsson --- I made variants of GetMarcBiblio and EmbedItemsInMarcBiblio (GetMarcBiblios and EmbedItemsInMarcBiblio) that accepts multiple biblionumbers instead of just one. This way

[Koha-bugs] [Bug 19899] Software error while check in, The method noreturn is not covered by tests! after upgrade from 16.05 to 17.11

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 --- Comment #5 from Mohd Hafiz Yusoff --- Return from command lib/C4/Circulation.pm: noreturn: do not return, let item remain where checked in (floating collections) lib/C4/Circulation.pm:# if $hbr was

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Nick Clemens changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 19884] Improve performance of GetItem

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884 --- Comment #33 from David Gustafsson --- Forgot to add my results of running the script: Batching enabled + SQL-hack: 32.422s Batching enabled (using ->search, no SQL-hack): 33.387s Batching disabled +

[Koha-bugs] [Bug 19884] Improve performance of GetItem

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884 --- Comment #31 from David Gustafsson --- Created attachment 70284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70284=edit Add new functions GetMarcBiblios and EmbedItemsInMarcBiblios for

[Koha-bugs] [Bug 19899] Software error while check in, The method noreturn is not covered by tests! after upgrade from 16.05 to 17.11

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 --- Comment #4 from Mohd Hafiz Yusoff --- Fresh install koha using this instruction: https://wiki.koha-community.org/wiki/Koha_on_ubuntu_-_packages After install, I restore old database (from KOHA 16.05). And

[Koha-bugs] [Bug 19884] Improve performance of GetItem

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884 --- Comment #34 from David Gustafsson --- Also note that this latest benchmark includes all work done in GetMarcBiblio, so more illustrates the actual speedup of loading biblios for indexing (for example), not

[Koha-bugs] [Bug 19884] Improve performance of GetItem

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884 --- Comment #36 from David Gustafsson --- Created attachment 70286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70286=edit search_batched -- You are receiving this mail because: You are

[Koha-bugs] [Bug 19015] Searches fail with error Fielddata is disabled on text fields by default for elastic search 5.3 and 5.4

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19015 Nick Clemens changed: What|Removed |Added Status|NEW

[Koha-bugs] [Bug 19884] Improve performance of GetItem

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884 --- Comment #38 from David Gustafsson --- The SQL-hack is still included in the last patch, but if you like the biblio-batch-loading approach, I can polish and test this some more (add subroutine documentation

[Koha-bugs] [Bug 19280] CanBookBeIssued must take a Koha::Patron in parameter

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19280 --- Comment #7 from Jonathan Druart --- Created attachment 70287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70287=edit Bug 19280: refresh unblessed patron too -- You

[Koha-bugs] [Bug 19280] CanBookBeIssued must take a Koha::Patron in parameter

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19280 Jonathan Druart changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 19884] Improve performance of GetItem

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884 --- Comment #35 from David Gustafsson --- Created attachment 70285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70285=edit search_not_batched -- You are receiving this mail because: You are

[Koha-bugs] [Bug 19884] Improve performance of GetItem

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884 --- Comment #37 from David Gustafsson --- The last two flamegraphes are from running this script (https://gist.github.com/gnucifer/1e33f9aa7155b1b771baaa357dfc7141) without the SQL-hack and batching

[Koha-bugs] [Bug 19280] CanBookBeIssued must take a Koha::Patron in parameter

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19280 --- Comment #8 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #6) > -$patron = Koha::Patrons->find( $borrower->{borrowernumber} ); > +$patron =

[Koha-bugs] [Bug 19918] New: span tag not closed in opac-registration-confirmation.tt

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19918 Bug ID: 19918 Summary: span tag not closed in opac-registration-confirmation.tt Change sponsored?: --- Product: Koha Version: unspecified Hardware: All

[Koha-bugs] [Bug 19918] span tag not closed in opac-registration-confirmation.tt

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19918 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED

[Koha-bugs] [Bug 19918] span tag not closed in opac-registration-confirmation.tt

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19918 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 19918] span tag not closed in opac-registration-confirmation.tt

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19918 --- Comment #1 from Jonathan Druart --- Created attachment 70288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70288=edit Bug 19918: Close span tag in

[Koha-bugs] [Bug 19918] span tag not closed in opac-registration-confirmation.tt

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19918 Jonathan Druart changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 19918] span tag not closed in opac-registration-confirmation.tt

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19918 Jonathan Druart changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Jessie Zairo changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19911] Passwords displayed to user during self-registration are not HTML-encoded

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19911 Jonathan Druart changed: What|Removed |Added Depends on|

[Koha-bugs] [Bug 19899] Software error while check in, The method noreturn is not covered by tests! after upgrade from 16.05 to 17.11

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 --- Comment #6 from Jonathan Druart --- Do you have something else in the Koha log file? I will need the file and line number where the error occurs. -- You are receiving this mail

[Koha-bugs] [Bug 19899] Software error while check in, The method noreturn is not covered by tests!

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 Jonathan Druart changed: What|Removed |Added Summary|Software

[Koha-bugs] [Bug 19899] Software error while check in, The method noreturn is not covered by tests!

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 Jonathan Druart changed: What|Removed |Added Status|NEW

[Koha-bugs] [Bug 19899] Software error while check in, The method noreturn is not covered by tests!

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 Jonathan Druart changed: What|Removed |Added Depends on|

[Koha-bugs] [Bug 19899] The float items feature is broken - cannot checkin

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19899 Jonathan Druart changed: What|Removed |Added Summary|Software

[Koha-bugs] [Bug 19280] CanBookBeIssued must take a Koha::Patron in parameter

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19280 Marcel de Rooy changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 19280] CanBookBeIssued must take a Koha::Patron in parameter

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19280 --- Comment #10 from Marcel de Rooy --- Created attachment 70292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70292=edit Bug 19280: refresh unblessed patron too Signed-off-by: Marcel

[Koha-bugs] [Bug 19280] CanBookBeIssued must take a Koha::Patron in parameter

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19280 Marcel de Rooy changed: What|Removed |Added Attachment #68916|0

[Koha-bugs] [Bug 19919] New: Writing off a Lost Item Fee marks as "Paid for by patron"

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Bug ID: 19919 Summary: Writing off a Lost Item Fee marks as "Paid for by patron" Change sponsored?: --- Product: Koha Version: unspecified Hardware: All

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Marcel de Rooy changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 Kyle M Hall changed: What|Removed |Added Status|In Discussion

[Koha-bugs] [Bug 18856] Cancel Waiting Hold in OPAC does not give useful message

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18856 --- Comment #9 from Kyle M Hall --- Created attachment 70294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70294=edit Bug 18856 [QA Followup] - Catch missed instance of is_cancelable

[Koha-bugs] [Bug 19897] Make status 'on hold' more specific

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19897 Lisette changed: What|Removed |Added CC|

[Koha-bugs] [Bug 19884] Improve performance of GetItem

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19884 --- Comment #39 from Jonathan Druart --- David, my main concern with your approach is that we are adding new subroutines to C4 (against our coding guidelines) and too specific methods (for

[Koha-bugs] [Bug 13599] Add patron cardnumber to self registration confirmation

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13599 Jonathan Druart changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 19911] Passwords displayed to user during self-registration are not HTML-encoded

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19911 Jonathan Druart changed: What|Removed |Added Attachment #70253|0

[Koha-bugs] [Bug 19918] span tag not closed in opac-registration-confirmation.tt

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19918 Jonathan Druart changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 18276] Koha::Biblio - Remove GetBiblioFromItemNumber

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18276 Jonathan Druart changed: What|Removed |Added Blocks|

[Koha-bugs] [Bug 17981] Add the ability to preview generated notice templates

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17981 Owen Leonard changed: What|Removed |Added Status|Signed Off |Patch

  1   2   >