[Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 Bernardo Gonzalez Kriegel bgkrie...@gmail.com changed: What|Removed |Added CC||bgkrie...@gmail.com --- Comment #18 from Bernardo Gonzalez Kriegel bgkrie...@gmail.com --- Pushed to 3.10.x, will be in 3.10.10 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||tomasco...@gmail.com --- Comment #17 from Tomás Cohen Arazi tomasco...@gmail.com --- This patch has been pushed to 3.12.x, will be in 3.12.2. Thanks Jonathan! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added CC||gmcha...@gmail.com --- Comment #13 from Galen Charlton gmcha...@gmail.com --- (In reply to Jonathan Druart from comment #10) (In reply to comment #9) (In reply to comment #8) (In reply to comment #6) I'm still getting failures: Are these tests pass with the master's ut file? No. Isn't that the point of the patch, that the unit tests should pass even if there isn't any data for them? Yes of course, but in fact the only data I create is the borrower. So if the DB contains at least 1 borrower, this patch is useless. That's a little too strong of a requirement, IMO, as I, for one, and I suspect most developers, would like to be able to run the DB-dependent tests in our normal testing databases. I rather suspect what Jared is running into is that his test database already has a patron whose cardnumber is CARDNUMBER42. I think that the requirement that tests should create their own data has a more general expression: tests should make as few assumptions about the state of the database as possible. What this means in this specific case is that the cardnumber for the patron created for this test should be set in such a way as to be guaranteed unique for that test run. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 Galen Charlton gmcha...@gmail.com changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #14 from Galen Charlton gmcha...@gmail.com --- Pushed to master. Thanks, Jonathan! I've also pushed two follow-ups, one to wrap the tests in a transaction and another to remove the hard-coded patron cardnumber, which doesn't need to be set to any specific value for the tests to work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 --- Comment #15 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Galen Charlton from comment #13) Yes of course, but in fact the only data I create is the borrower. So if the DB contains at least 1 borrower, this patch is useless. That's a little too strong of a requirement, IMO, as I, for one, and I suspect most developers, would like to be able to run the DB-dependent tests in our normal testing databases. Currently nobody is able to launch them, and the goal is to launch tests with sample data. They don't insert patron, so I think we have to have some prerequisites. I rather suspect what Jared is running into is that his test database already has a patron whose cardnumber is CARDNUMBER42. Yes, it was maybe to generic :) (In reply to Galen Charlton from comment #14) Pushed to master. Thanks, Jonathan! I've also pushed two follow-ups, one to wrap the tests in a transaction and another to remove the hard-coded patron cardnumber, which doesn't need to be set to any specific value for the tests to work. Thanks for the followups! But now tests fail if a borrower exists with a cardnumber == NULL (and I don't have any idea how it's happen, but I got 1 in my DB :)) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 --- Comment #16 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to Jonathan Druart from comment #15) But now tests fail if a borrower exists with a cardnumber == NULL (and I don't have any idea how it's happen, but I got 1 in my DB :)) Forget that, they pass! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Attachment #19185|0 |1 is obsolete|| --- Comment #12 from Chris Cormack ch...@bigballofwax.co.nz --- Created attachment 19448 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19448action=edit Bug 10289: UT: Reserves.t needs to create its own data Try before the patch: prove t/db_dependent/Reserves.t And after, it should produce: t/db_dependent/Reserves.t .. 1/4 # # Creating biblio instance for testing. # Creating item instance for testing. # Deleting item testing instance. # Deleting biblio testing instance. # Deleting borrower. t/db_dependent/Reserves.t .. ok All tests successful. Files=1, Tests=4, 1 wallclock secs ( 0.02 usr 0.01 sys + 0.39 cusr 0.02 csys = 0.44 CPU) Result: PASS Signed-off-by: Kyle M Hall k...@bywatersolutions.com Signed-off-by: Chris Cormack ch...@bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #18660|0 |1 is obsolete|| --- Comment #11 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 19185 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19185action=edit Bug 10289: UT: Reserves.t needs to create its own data Try before the patch: prove t/db_dependent/Reserves.t And after, it should produce: t/db_dependent/Reserves.t .. 1/4 # # Creating biblio instance for testing. # Creating item instance for testing. # Deleting item testing instance. # Deleting biblio testing instance. # Deleting borrower. t/db_dependent/Reserves.t .. ok All tests successful. Files=1, Tests=4, 1 wallclock secs ( 0.02 usr 0.01 sys + 0.39 cusr 0.02 csys = 0.44 CPU) Result: PASS Signed-off-by: Kyle M Hall k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Blocks||10487 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 --- Comment #8 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to comment #6) I'm still getting failures: Are these tests pass with the master's ut file? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 --- Comment #9 from Jared Camins-Esakov jcam...@cpbibliography.com --- (In reply to comment #8) (In reply to comment #6) I'm still getting failures: Are these tests pass with the master's ut file? No. Isn't that the point of the patch, that the unit tests should pass even if there isn't any data for them? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 --- Comment #10 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to comment #9) (In reply to comment #8) (In reply to comment #6) I'm still getting failures: Are these tests pass with the master's ut file? No. Isn't that the point of the patch, that the unit tests should pass even if there isn't any data for them? Yes of course, but in fact the only data I create is the borrower. So if the DB contains at least 1 borrower, this patch is useless. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 --- Comment #6 from Jared Camins-Esakov jcam...@cpbibliography.com --- (In reply to comment #4) Jared, thank you for testing. I confirm the tests pass here :-/ Could you retry with the last patch please? It replaces ok with is. We should have a more readable failure. I'm still getting failures: jcamins@kohadev:~/kohaclone$ prove t/db_dependent/Reserves.t t/db_dependent/Reserves.t .. 1/4 # # Creating biblio instance for testing. # Creating item instance for testing. INSERT INTO borrowers SET borrowers.firstname = ? , borrowers.dateenrolled = ? , borrowers.userid = ? , borrowers.categorycode = ? , borrowers.surname = ? , borrowers.dateexpiry = ? , borrowers.password = ? , borrowers.cardnumber = ? , borrowers.branchcode = ? my firstname,2013-06-07,myfirstname.mysurname,S,my surname,2021-09-07,!,CARDNUMBER42,CPL at /home/jcamins/kohaclone/C4/SQLHelper.pm line 182. SELECT borrowers.*, categories.category_type, categories.description FROM borrowers LEFT JOIN categories on borrowers.categorycode=categories.categorycode WHERE borrowernumber = ? 78 at /home/jcamins/kohaclone/C4/Members.pm line 556. SELECT borrowers.*, categories.category_type, categories.description FROM borrowers LEFT JOIN categories on borrowers.categorycode=categories.categorycode WHERE borrowernumber = ? 78 at /home/jcamins/kohaclone/C4/Members.pm line 556. # Failed test 'CheckReserves Test 1' # at t/db_dependent/Reserves.t line 67. # got: '' # expected: 'Reserved' SELECT borrowers.*, categories.category_type, categories.description FROM borrowers LEFT JOIN categories on borrowers.categorycode=categories.categorycode WHERE borrowernumber = ? 78 at /home/jcamins/kohaclone/C4/Members.pm line 556. t/db_dependent/Reserves.t .. 3/4 # Failed test 'CheckReserves Test 2' # at t/db_dependent/Reserves.t line 70. # got: '' # expected: 'Reserved' SELECT borrowers.*, categories.category_type, categories.description FROM borrowers LEFT JOIN categories on borrowers.categorycode=categories.categorycode WHERE borrowernumber = ? 78 at /home/jcamins/kohaclone/C4/Members.pm line 556. # Failed test 'CheckReserves Test 3' # at t/db_dependent/Reserves.t line 73. # got: '' # expected: 'Reserved' # Deleting item testing instance. # Deleting biblio testing instance. # Deleting borrower. # Looks like you failed 3 tests of 4. t/db_dependent/Reserves.t .. Dubious, test returned 3 (wstat 768, 0x300) Failed 3/4 subtests Test Summary Report --- t/db_dependent/Reserves.t (Wstat: 768 Tests: 4 Failed: 3) Failed tests: 2-4 Non-zero exit status: 3 Files=1, Tests=4, 1 wallclock secs ( 0.03 usr 0.01 sys + 0.60 cusr 0.06 csys = 0.70 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 --- Comment #7 from Jonathan Druart jonathan.dru...@biblibre.com --- (In reply to comment #6) (In reply to comment #4) Jared, thank you for testing. I confirm the tests pass here :-/ Could you retry with the last patch please? It replaces ok with is. We should have a more readable failure. I'm still getting failures: Yes, it is normal, I did not change the way to retrieve data. I am really sorry but the output does not give information for debugging this. I think it is caused by your data. I use the database generated with the script provided on bug 10337 (depends on bug 10298). Like that the database just contains sample data. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #18250|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18659 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18659action=edit Bug 10289: UT: Reserves.t needs to create its own data Try before the patch: prove t/db_dependent/Reserves.t And after, it should produce: t/db_dependent/Reserves.t .. 1/4 # # Creating biblio instance for testing. # Creating item instance for testing. # Deleting item testing instance. # Deleting biblio testing instance. # Deleting borrower. t/db_dependent/Reserves.t .. ok All tests successful. Files=1, Tests=4, 1 wallclock secs ( 0.02 usr 0.01 sys + 0.39 cusr 0.02 csys = 0.44 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 --- Comment #4 from Jonathan Druart jonathan.dru...@biblibre.com --- Jared, thank you for testing. I confirm the tests pass here :-/ Could you retry with the last patch please? It replaces ok with is. We should have a more readable failure. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Attachment #18659|0 |1 is obsolete|| --- Comment #5 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18660 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18660action=edit Bug 10289: UT: Reserves.t needs to create its own data Try before the patch: prove t/db_dependent/Reserves.t And after, it should produce: t/db_dependent/Reserves.t .. 1/4 # # Creating biblio instance for testing. # Creating item instance for testing. # Deleting item testing instance. # Deleting biblio testing instance. # Deleting borrower. t/db_dependent/Reserves.t .. ok All tests successful. Files=1, Tests=4, 1 wallclock secs ( 0.02 usr 0.01 sys + 0.39 cusr 0.02 csys = 0.44 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 Jared Camins-Esakov jcam...@cpbibliography.com changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #2 from Jared Camins-Esakov jcam...@cpbibliography.com --- This one does not work for me. I get the following output (with DEBUG on): jcamins@kohadev:~/kohaclone$ perl t/db_dependent/Reserves.t 1..4 ok 1 - use C4::Reserves; # # Creating biblio instance for testing. # Creating item instance for testing. INSERT INTO borrowers SET borrowers.firstname = ? , borrowers.dateenrolled = ? , borrowers.userid = ? , borrowers.categorycode = ? , borrowers.surname = ? , borrowers.dateexpiry = ? , borrowers.password = ? , borrowers.cardnumber = ? , borrowers.branchcode = ? my firstname,2013-06-04,myfirstname.mysurname,S,my surname,2021-09-04,!,CARDNUMBER42,CPL at /home/jcamins/kohaclone/C4/SQLHelper.pm line 182. SELECT borrowers.*, categories.category_type, categories.description FROM borrowers LEFT JOIN categories on borrowers.categorycode=categories.categorycode WHERE borrowernumber = ? 75 at /home/jcamins/kohaclone/C4/Members.pm line 556. SELECT borrowers.*, categories.category_type, categories.description FROM borrowers LEFT JOIN categories on borrowers.categorycode=categories.categorycode WHERE borrowernumber = ? 75 at /home/jcamins/kohaclone/C4/Members.pm line 556. not ok 2 - CheckReserves Test 1 # Failed test 'CheckReserves Test 1' # at t/db_dependent/Reserves.t line 66. SELECT borrowers.*, categories.category_type, categories.description FROM borrowers LEFT JOIN categories on borrowers.categorycode=categories.categorycode WHERE borrowernumber = ? 75 at /home/jcamins/kohaclone/C4/Members.pm line 556. not ok 3 - CheckReserves Test 2 # Failed test 'CheckReserves Test 2' # at t/db_dependent/Reserves.t line 69. SELECT borrowers.*, categories.category_type, categories.description FROM borrowers LEFT JOIN categories on borrowers.categorycode=categories.categorycode WHERE borrowernumber = ? 75 at /home/jcamins/kohaclone/C4/Members.pm line 556. not ok 4 - CheckReserves Test 3 # Failed test 'CheckReserves Test 3' # at t/db_dependent/Reserves.t line 72. # Deleting item testing instance. # Deleting biblio testing instance. # Deleting borrower. # Looks like you failed 3 tests of 4. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|NEW |ASSIGNED Blocks||10273 Assignee|gmcha...@gmail.com |jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 --- Comment #1 from Jonathan Druart jonathan.dru...@biblibre.com --- Created attachment 18250 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18250action=edit Bug 10289: UT: Reserves.t needs to create its own data Try before the patch: prove t/db_dependent/Reserves.t And after, it should produce: t/db_dependent/Reserves.t .. 1/4 # # Creating biblio instance for testing. # Creating item instance for testing. # Deleting item testing instance. # Deleting biblio testing instance. # Deleting borrower. t/db_dependent/Reserves.t .. ok All tests successful. Files=1, Tests=4, 1 wallclock secs ( 0.02 usr 0.01 sys + 0.39 cusr 0.02 csys = 0.44 CPU) Result: PASS -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10289] UT: Reserves.t needs to create its own data
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10289 Jonathan Druart jonathan.dru...@biblibre.com changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
