[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Fridolin SOMERS changed: What|Removed |Added Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE --- Comment #24 from Fridolin SOMERS --- Will be fixed on Bug 18743 *** This bug has been marked as a duplicate of bug 18743 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Fridolin SOMERS changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=18743 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Patrick Robitaille changed: What|Removed |Added CC||patrick.robitai...@ccsr.qc. ||ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Lisette changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 --- Comment #23 from Katrin Fischer --- Thinking about this some more: We had a similar, but not quite the same problem with patron modification requests. It was solved with the system preference IndependentBranchesPatronModifications. So we could have a setting to see suggestions from all branches and a setting to see only your own. Ideally the suggestions page should reflect that as well in the preset filter. But patron modification requests always have a branch - suggestions do not. So 'only your own' does not quite work. Maybe the solution is to change the text of the message on the dashboard for this setting, so that it's clearer. I am not quite sure what would work here best. Thinking of something like: 1 suggestion for your branch [and 2 for any branch] are pending. I also like Fridolin's idea to make the selected option more visible as this has caused confusion in our libraries too. Instead of moving the acquisition filters to the top, I suggest having the branch filter outside and always visible, putting it below or over the tab organization filter. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 --- Comment #22 from Fridolin SOMERS --- Maybe we should write the current branch in acquisition home page : XX suggestions waiting for library. Manage suggestions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 --- Comment #21 from Fridolin SOMERS --- Maybe filter on acquisition information should be first and its content always visible -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Magnus Enger changed: What|Removed |Added CC||mag...@libriotech.no --- Comment #20 from Magnus Enger --- (In reply to Jonathan Druart from comment #18) > Fridolin, It's not obvious that what you described in the bug description is > a bug. > The sentence is "XXX suggestions waiting. Manage suggestions.", it implies > all suggestions. One of my customers reported this as a bug. When they see "Suggestions pending approval: 2" and click on that text they find it confusing that they are shown zero suggestions. I have explained the workaround to show all waiting suggestions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Nicole C. Engard changed: What|Removed |Added CC|neng...@gmail.com | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 --- Comment #19 from Marcel de Rooy --- If you have some suggestions with branchcode == null, how would a staff user get to them? Seems impossible in the interface. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Fridolin SOMERS changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=14958 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Fridolin SOMERS changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=8147 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Jonathan Druart changed: What|Removed |Added Status|Failed QA |In Discussion --- Comment #18 from Jonathan Druart --- Fridolin, It's not obvious that what you described in the bug description is a bug. The sentence is "XXX suggestions waiting. Manage suggestions.", it implies all suggestions. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 --- Comment #17 from Jonathan Druart --- (In reply to Jonathan Druart from comment #16) > (In reply to Katrin Fischer from comment #15) > > Can this be rescued? The branch specific suggestions + any with an empty > > branch code sounds reasonable to me. > > As far as I understand, this is the current behavior. Sorry, forget that, it's not. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 --- Comment #16 from Jonathan Druart --- (In reply to Katrin Fischer from comment #15) > Can this be rescued? The branch specific suggestions + any with an empty > branch code sounds reasonable to me. As far as I understand, this is the current behavior. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 --- Comment #15 from Katrin Fischer --- Can this be rescued? The branch specific suggestions + any with an empty branch code sounds reasonable to me. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 --- Comment #14 from Sophie MEYNIEUX --- Does bug 10753 help to resolve ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Sophie MEYNIEUX changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=10753 CC||sophie.meyni...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #13 from Jonathan Druart --- Can I know how we want to see this number calculated? On master I got all suggestions, with these 2 patches, I got the suggestions from the current branch + from any library. So the number is still different... -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Peggy Thrasher changed: What|Removed |Added CC||p.thras...@dover.nh.gov -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 --- Comment #12 from Katrin Fischer --- Hm, not sure right now why this got stuck. I think we should either replace the _ANY_ by an empty branchcode and correct existing suggestions or we need to make the SQL take those _ANY_ into account. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 --- Comment #11 from Fridolyn SOMERS --- (In reply to Katrin Fischer from comment #10) Oh, indeed. What should I do ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Katrin Fischer changed: What|Removed |Added Depends on||10753 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #10 from Katrin Fischer --- Fridolyn, it might be a separate bug, but it means that your follow-up does not work - there is currently no way to have a suggestion which an empty branchcode. When you don't allow the patron to pick the branch in the OPAC the homelibrary will be used. When you create a suggestion for any library in staff, the branchcode is _ANY_ - so your change to the SQL query will currently have no effect: +$query .= q{ AND (branchcode='' OR branchcode=?) }; -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Owen Leonard changed: What|Removed |Added CC||neng...@gmail.com --- Comment #9 from Owen Leonard --- *** Bug 8274 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 --- Comment #8 from Fridolyn SOMERS --- (In reply to Katrin Fischer from comment #5) > The code used in the database for those seems to be _ANY_ - which is a bit > confusing as I would have expected the branchcode column to be empty in this > case. I think this is indeed a bug. You should open a new one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Fridolyn SOMERS changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #7 from Fridolyn SOMERS --- (In reply to Katrin Fischer from comment #5) > Failing QA for 1). Does the follow-up need signoff ? I'd say no because it is very small. I set to signed-off. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Fridolyn SOMERS changed: What|Removed |Added Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 --- Comment #6 from Fridolyn SOMERS --- Created attachment 19929 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=19929&action=edit Bug 10449 - Count suggestions without branch also See commit message -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #5 from Katrin Fischer --- Hi fridolyn, I have some concerns about your patch: 1) The patch works nicely according to the description, but it limits on branchcode and so suggestions created for _ANY_ library are always left out. The code used in the database for those seems to be _ANY_ - which is a bit confusing as I would have expected the branchcode column to be empty in this case. But that doesn't change anything about 1) :) 2) I am also wondering if superlibrarians should see the total count instead of a branch related one, but I think showing them the count for the branch they are logged in at is probably right. Failing QA for 1). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 --- Comment #4 from Katrin Fischer --- Ok, forget that... I had confused my bug numbers :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Katrin Fischer changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer --- I am sorry, but this does no longer apply due to a conflict in the VirtualShelves.t: Apply? [y]es/[n]o/[e]dit/[v]iew patch/[a]ccept all y Applying: Bug 10499: VirtualShelves.t - wrap tests in a database connection Using index info to reconstruct a base tree... Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/VirtualShelves.t CONFLICT (content): Merge conflict in t/db_dependent/VirtualShelves.t Failed to merge in the changes. Patch failed at 0001 Bug 10499: VirtualShelves.t - wrap tests in a database connection When you have resolved this problem run "git am --resolved". If you would prefer to skip this patch, instead run "git am --skip". To restore the original branch and stop patching run "git am --abort". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Kyle M Hall changed: What|Removed |Added Attachment #18885|0 |1 is obsolete|| --- Comment #2 from Kyle M Hall --- Created attachment 18985 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18985&action=edit Bug 10449 - Suggestions pending approval should count only suggestions of current branch In intranet main page and acquisition home page, a text can display the number of suggestions pending for approval. When clicking on this like, the suggestions management page is displayed. In this page, by default, only the suggestions of current branch are visible. This patch modifies "Suggestions pending approval" count so that when clicking on link, you see the same count in "Pending" tab. Test plan : - Create pending suggestions in several branches - Connect with user in koha-conf.xml to have no selected branch (you see NO LIBRARY SET) - On main page, look at "Suggestions pending approval" - Click on this link - In suggestions management page, click on "Go" near "Status" => You see the same count in "Pending" tab - Come back to main page - Select a branch (with pending suggestions) - On main page, look at "Suggestions pending approval" - Click on this link => You see the same count in "Pending" tab Signed-off-by: Kyle M Hall -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 10449] Suggestions pending approval should count only suggestions of current branch
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10449 Fridolyn SOMERS changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|koha-b...@lists.koha-commun |fridolyn.som...@biblibre.co |ity.org |m --- Comment #1 from Fridolyn SOMERS --- Created attachment 18885 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=18885&action=edit Proposed patch See commit message -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/