[Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/copyrightdate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 --- Comment #20 from Marcel de Rooy --- Just a late observation about the last changes: -} elsif( $retval =~ m/(\d)[.Xx?]{3}|(\d\d)[.Xx?]{2}|(\d{3})[.Xx?]/ ) { -my $digits = $1 || $2 || $3; -$retval = $digits * ( 10 ** ( 4 - length($digits) )); -} elsif( $retval =~ m/(\d)[-]{3}\?|(\d\d)[-]{2}\?|(\d{3})[-]\?/ ) { -# the form 198-? occurred in Dutch ISBD rules -my $digits = $1 || $2 || $3; +} elsif( $retval =~ m/ + (?\d)[-]?[.Xx?]{3} +|(?\d{2})[.Xx?]{2} +|(?\d{3})[.Xx?] +|(?\d)[-]{3}\? +|(?\d\d)[-]{2}\? +|(?\d{3})[-]\? +/xms ) { # the form 198-? occurred in Dutch ISBD rules This part of the regex made me wonder: (?\d)[-]?[.Xx?]{3} What does the minus do here after the first digit? Do we allow 1-234 or so? Looking at the above, this must have been a typo (copy/paste) after all.. Continued on bug 24674 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/copyrightdate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 Nick Clemens changed: What|Removed |Added Blocks||26516 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=26516 [Bug 26516] Importing records with unexpected format of copyrightdate fails -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/copyrightdate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 Jonathan Druart changed: What|Removed |Added Blocks||24674 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24674 [Bug 24674] Uncertain years for publicationyear/copyrightdate -- corrected -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/copyrightdate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 --- Comment #19 from Marcel de Rooy--- For documentation or release: The patches of this report make that unknown publication/copyright years like 19.. or 19xx or 19XX or 19?? or 19--? (and similar forms) are interpreted as 1900 instead of 0 when saving copyrightdate (MARC21) or publicationyear (UNIMARC). These fields are so-called kohafields (fields extracted from the MARC record and saved additionally in the database for optimization). Since it is now possible to connect multiple MARC fields to one kohafield, you can enter something like 1xxx or 201x into MARC21 fields like 260$c or 264$c. When you save the record, the estimated publication year (1000 or 2010) will be saved into the corresponding kohafield. This field is used for sorting lists [virtual shelves] by copyrightdate among others. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 Nick Clemenschanged: What|Removed |Added CC||n...@bywatersolutions.com Resolution|--- |FIXED Status|Pushed to Master|RESOLVED --- Comment #18 from Nick Clemens --- Enhancement, skipping for 17.11.x. Awesome work everybody! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 --- Comment #17 from Jonathan Druart--- (In reply to Marcel de Rooy from comment #15) > (In reply to Jonathan Druart from comment #13) > > Can we have a patch for the manual please? :) > > Does the Manual keyword trigger someone of the Documentation team to do so? I think the author or someone involved in the development/testing of the patch should write something to explain to the manual team what the feature/change is. And then the manual team could adapt it correctly to the manual and make a patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 Katrin Fischerchanged: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #16 from Katrin Fischer --- The manual team is still small, maybe write something up and send it to them? ;) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 --- Comment #15 from Marcel de Rooy--- (In reply to Jonathan Druart from comment #13) > Can we have a patch for the manual please? :) Does the Manual keyword trigger someone of the Documentation team to do so? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 Jonathan Druartchanged: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #14 from Jonathan Druart --- Pushed to master for 18.05, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 Jonathan Druartchanged: What|Removed |Added Keywords||Manual CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #13 from Jonathan Druart --- Can we have a patch for the manual please? :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 --- Comment #12 from Jonathan Druart--- Created attachment 70394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70394=edit Bug 11046: Improve the readability of the regex using named capture The tests tell me I am good -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 --- Comment #11 from Marcel de Rooy--- (In reply to Josef Moravec from comment #10) > Signed-off-by: Josef Moravec Thanks Josef. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 --- Comment #10 from Josef Moravec--- Created attachment 70236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70236=edit Bug 11046: Add the form YYY-? for uncertain years This form occurred in Dutch ISBD rules. The question mark should follow the hyphen(s). Test plan: Run t/db_dependent/Biblio/TransformMarcToKoha.t Signed-off-by: Marcel de Rooy TransformMarcToKoha tests passed. Also this patch passed QA test tool Signed-off-by: Alex Buckley Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 Josef Moravecchanged: What|Removed |Added QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com |y.org | CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 Josef Moravecchanged: What|Removed |Added Attachment #68349|0 |1 is obsolete|| Attachment #68350|0 |1 is obsolete|| --- Comment #9 from Josef Moravec --- Created attachment 70235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70235=edit Bug 11046: Better handling of uncertain years for publicationyear This patch makes it possible that uncertain year like 18.. or 197x are converted to 1800 or 1970 in Koha field copyrightdate (MARC21) or publicationyear (UNIMARC). (The corresponding MARC record will not be changed obviously.) This change will allow for better results when sorting search results or list contents on copyrightdate. Currently, things like 18.. will sort together with zero. Note: The regex now allows four possible uncertain year markers: x or X, question mark or dot. Test plan: [1] Run t/db_dependent/Biblio/TransformMarcToKoha.t [2] Edit a biblio record. Save 18.. into 260c. Check biblio.copyrightdate. Signed-off-by: Marcel de Rooy Followed test plan, patch worked as described, it also passed QA test tool Signed-off-by: Alex Buckley Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 Josef Moravecchanged: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 Bug 11046 depends on bug 19096, which changed state. Bug 19096 Summary: Koha to MARC mappings (Part 2): Make Default authoritative https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 --- Comment #8 from Marcel de Rooy--- (In reply to Alex Buckley from comment #7) > Signed-off-by: Alex Buckley Thanks Alex -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 Alex Buckleychanged: What|Removed |Added Attachment #66552|0 |1 is obsolete|| --- Comment #7 from Alex Buckley --- Created attachment 68350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68350=edit Bug 11046: Add the form YYY-? for uncertain years This form occurred in Dutch ISBD rules. The question mark should follow the hyphen(s). Test plan: Run t/db_dependent/Biblio/TransformMarcToKoha.t Signed-off-by: Marcel de Rooy TransformMarcToKoha tests passed. Also this patch passed QA test tool Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 Alex Buckleychanged: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 Alex Buckleychanged: What|Removed |Added Attachment #66549|0 |1 is obsolete|| --- Comment #6 from Alex Buckley --- Created attachment 68349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68349=edit Bug 11046: Better handling of uncertain years for publicationyear This patch makes it possible that uncertain year like 18.. or 197x are converted to 1800 or 1970 in Koha field copyrightdate (MARC21) or publicationyear (UNIMARC). (The corresponding MARC record will not be changed obviously.) This change will allow for better results when sorting search results or list contents on copyrightdate. Currently, things like 18.. will sort together with zero. Note: The regex now allows four possible uncertain year markers: x or X, question mark or dot. Test plan: [1] Run t/db_dependent/Biblio/TransformMarcToKoha.t [2] Edit a biblio record. Save 18.. into 260c. Check biblio.copyrightdate. Signed-off-by: Marcel de Rooy Followed test plan, patch worked as described, it also passed QA test tool Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 Marcel de Rooychanged: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=19206 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 --- Comment #5 from Marcel de Rooy--- Created attachment 66552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66552=edit Bug 11046: Add the form YYY-? for uncertain years This form occurred in Dutch ISBD rules. The question mark should follow the hyphen(s). Test plan: Run t/db_dependent/Biblio/TransformMarcToKoha.t Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 --- Comment #4 from Marcel de Rooy--- Watch the dependencies ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 --- Comment #3 from Marcel de Rooy--- Created attachment 66549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66549=edit Bug 11046: Better handling of uncertain years for publicationyear This patch makes it possible that uncertain year like 18.. or 197x are converted to 1800 or 1970 in Koha field copyrightdate (MARC21) or publicationyear (UNIMARC). (The corresponding MARC record will not be changed obviously.) This change will allow for better results when sorting search results or list contents on copyrightdate. Currently, things like 18.. will sort together with zero. Note: The regex now allows four possible uncertain year markers: x or X, question mark or dot. Test plan: [1] Run t/db_dependent/Biblio/TransformMarcToKoha.t [2] Edit a biblio record. Save 18.. into 260c. Check biblio.copyrightdate. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 Marcel de Rooychanged: What|Removed |Added Patch complexity|--- |Small patch Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 Marcel de Rooychanged: What|Removed |Added Depends on||19096 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19096 [Bug 19096] Koha to MARC mappings (Part 2): Make Default authoritative -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 11046] Better handling of uncertain years for publicationyear/ copyrightdate
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11046 Marcel de Rooychanged: What|Removed |Added Summary|keeping uncertain or range |Better handling of |dates in publicationyear|uncertain years for |and copyright date |publicationyear/copyrightda ||te Status|NEW |ASSIGNED Assignee|gmcha...@gmail.com |m.de.r...@rijksmuseum.nl --- Comment #2 from Marcel de Rooy --- (In reply to mathieu saby from comment #0) > Sometime MARC dates are a range, like "2010-2013". In that case, Koha is > currently using only the first one. Why not both? We cannot pick both. But could someone confirm that picking the first year is the preferred approach ? Or would the last year be better ?? We currently pick the first one. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/