https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
Fridolin SOMERS changed:
What|Removed |Added
See Also||https://bugs.koha-communit
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
--- Comment #65 from Owen Leonard ---
*** Bug 11899 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
Bug 11360 depends on bug 16942, which changed state.
Bug 16942 Summary: Confirm hold results in ugly error
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16942
What|Removed |Added
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
Mason James changed:
What|Removed |Added
CC||m...@kohaaloha.com
--- Commen
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
Marc Véron changed:
What|Removed |Added
Blocks||18438
Referenced Bugs:
https
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
Lucy Vaux-Harvey changed:
What|Removed |Added
CC||lucy.vaux-harvey@ptfs-eur
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
Katrin Fischer changed:
What|Removed |Added
CC||bedmonds...@gmail.com
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
Nicole C. Engard changed:
What|Removed |Added
CC|neng...@gmail.com |
--
You are receiving t
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
Kyle M Hall changed:
What|Removed |Added
Status|Passed QA |Pushed to Master
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
--- Comment #61 from Katrin Fischer ---
Just took another look - agree with Jonathan!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Passed QA
--- Comment #60
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
--- Comment #59 from Kyle M Hall ---
(In reply to Jonathan Druart from comment #58)
> Created attachment 53686 [details] [review]
> Bug 11360 [QA Followup] - Fix styles and button order
>
> Signed-off-by: Jonathan Druart
Jonathan
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
--- Comment #58 from Jonathan Druart
---
Created attachment 53686
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53686&action=edit
Bug 11360 [QA Followup] - Fix styles and button order
Signed-off-by: Jonathan Dru
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
Jonathan Druart changed:
What|Removed |Added
Attachment #53205|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
Jonathan Druart changed:
What|Removed |Added
Depends on||16942
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
--- Comment #56 from Jonathan Druart
---
(In reply to Katrin Fischer from comment #53)
Everything looks good to me (you will need bug 16942 to test this patch).
> BTW - do we need to repeat all that code for those 2 similar cases?
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
--- Comment #55 from Kyle M Hall ---
(In reply to Katrin Fischer from comment #53)
> Long read... and I have also tested this a bit:
I believe this followup should take care of your concerns! We can't do much
about the buttons break
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
--- Comment #54 from Kyle M Hall ---
Created attachment 53531
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53531&action=edit
Bug 11360 [QA Followup] - Fix styles and button order
--
You are receiving this mail
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
Kyle M Hall changed:
What|Removed |Added
Status|Failed QA |Signed Off
--
You are receiv
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
Nicole C. Engard changed:
What|Removed |Added
CC||a...@bywatersolutions.com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
Katrin Fischer changed:
What|Removed |Added
Severity|minor |enhancement
St
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
Nick Clemens changed:
What|Removed |Added
Change sponsored?|--- |Sponsored
Assignee
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
Nick Clemens changed:
What|Removed |Added
Attachment #51964|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
Nick Clemens changed:
What|Removed |Added
Status|Patch doesn't apply |Signed Off
--
You are recei
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Patch doesn't apply
--- C
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
sandbo...@biblibre.com changed:
What|Removed |Added
Attachment #50343|0 |1
is obsole
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
--- Comment #50 from sandbo...@biblibre.com ---
Created attachment 51964
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51964&action=edit
Bug 11360 - Disable barcode field and submit button when a hold is found
At
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
sandbo...@biblibre.com changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--- Com
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
--- Comment #48 from Nicole C. Engard ---
Does that mean you sign off on this patch? If so please go ahead and submit a
sign off.
Nicole
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
Koha Team Lyon 3 changed:
What|Removed |Added
CC||k...@univ-lyon3.fr
--- C
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
--- Comment #46 from Kyle M Hall ---
(In reply to Owen Leonard from comment #45)
> This looks good, and the test plan checks out. I do see some other instances
> of a left in the template which seem to be
> related to holds.
>
> Sh
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
--- Comment #45 from Owen Leonard ---
This looks good, and the test plan checks out. I do see some other instances of
a left in the template which seem to be related to
holds.
Shouldn't these cases be covered too?
--
You are rece
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
--- Comment #44 from Kyle M Hall ---
(In reply to Jonathan Druart from comment #42)
> (In reply to Kyle M Hall from comment #41)
> > This latest patch should fix both of your issues Owen!
>
> Does it mean it's ready to be tested?
I
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
Kyle M Hall changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
Kyle M Hall changed:
What|Removed |Added
Attachment #48790|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
--- Comment #42 from Jonathan Druart
---
(In reply to Kyle M Hall from comment #41)
> This latest patch should fix both of your issues Owen!
Does it mean it's ready to be tested?
--
You are receiving this mail because:
You are wa
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
Owen Leonard changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
--
You
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
--- Comment #41 from Kyle M Hall ---
This latest patch should fix both of your issues Owen!
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
Kyle M Hall changed:
What|Removed |Added
Attachment #48749|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
Kyle M Hall changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
--- Comment #39 from Owen Leonard ---
Unless there is a good case for hiding all messages, why not simply leave them
there?
--
You are receiving this mail because:
You are watching all bug changes.
_
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
--- Comment #38 from Kyle M Hall ---
(In reply to Owen Leonard from comment #37)
> (In reply to Kyle M Hall from comment #36)
> > Which part of comment 27?
>
> The whole thing!
>
> 1. The dialog obscures any other messages which mi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
--- Comment #37 from Owen Leonard ---
(In reply to Kyle M Hall from comment #36)
> Which part of comment 27?
The whole thing!
1. The dialog obscures any other messages which might be displayed during
checkin, then hides those messa
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
--- Comment #36 from Kyle M Hall ---
(In reply to Owen Leonard from comment #34)
> Lest all this talk of style suggest otherwise, it was the issues in comment
> #27 that prompted me to mark this as Failed QA.
Which part of comment 2
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
--- Comment #35 from Christopher Brannon ---
(In reply to Kyle M Hall from comment #31)
> (In reply to Christopher Brannon from comment #29)
> > (In reply to Owen Leonard from comment #28)
> > > I personally find the default Bootstra
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
--- Comment #34 from Owen Leonard ---
Lest all this talk of style suggest otherwise, it was the issues in comment #27
that prompted me to mark this as Failed QA.
--
You are receiving this mail because:
You are watching all bug chan
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
Katrin Fischer changed:
What|Removed |Added
CC||katrin.fisc...@bsz-bw.de
-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
--- Comment #32 from Owen Leonard ---
I think it's best not to introduce new global style changes in patches which
have a non-global scope. Changing the buttons just in this interface would make
it break with the design of all simila
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
--- Comment #31 from Kyle M Hall ---
(In reply to Christopher Brannon from comment #29)
> (In reply to Owen Leonard from comment #28)
> > I personally find the default Bootstrap colored button styles to be garish
> > and I don't thin
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
--- Comment #30 from Kyle M Hall ---
(In reply to Owen Leonard from comment #27)
> (In reply to Owen Leonard from comment #20)
>
> > If a checkin triggers the modal, any messages or alerts which were also
> > triggered by the checki
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
--- Comment #29 from Christopher Brannon ---
(In reply to Owen Leonard from comment #28)
> I personally find the default Bootstrap colored button styles to be garish
> and I don't think we should use them. I prefer a standard button
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
--- Comment #28 from Owen Leonard ---
I personally find the default Bootstrap colored button styles to be garish and
I don't think we should use them. I prefer a standard button with color added
to the icons.
This is another case wh
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
Owen Leonard changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #27 fr
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
Kyle M Hall changed:
What|Removed |Added
Attachment #47594|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
Kyle M Hall changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
Marc Véron changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
Kyle M Hall changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
Kyle M Hall changed:
What|Removed |Added
Attachment #45038|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
Owen Leonard changed:
What|Removed |Added
Status|Failed QA |Patch doesn't apply
--- Comm
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
--- Comment #22 from Kyle M Hall ---
(In reply to Owen Leonard from comment #21)
> Created attachment 45122 [details]
> Screenshot of layout issues
>
> This screenshot highlights a few markup/layout issues:
>
> - The list which disp
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
--- Comment #21 from Owen Leonard ---
Created attachment 45122
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45122&action=edit
Screenshot of layout issues
This screenshot highlights a few markup/layout issues:
- T
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
Owen Leonard changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #20 fro
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
--- Comment #19 from Kyle M Hall ---
(In reply to Nick Clemens from comment #17)
> To be more clear:
>
> Failing QA because the input box is still selected and active while the
> modal is up.
>
> Typing a barcode and pressing enter
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
Kyle M Hall changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are rece
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
Kyle M Hall changed:
What|Removed |Added
Attachment #44967|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
Nick Clemens changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--- Comment #17 fro
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
Nicole C. Engard changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
Nicole C. Engard changed:
What|Removed |Added
CC||neng...@gmail.com,
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
Nick Clemens changed:
What|Removed |Added
CC||n...@bywatersolutions.com
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
Kyle M Hall changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are rece
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
Kyle M Hall changed:
What|Removed |Added
Attachment #23511|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
--- Comment #14 from Kyle M Hall ---
> I agree about consistency, but from the other direction: namely, Bootstrap
> modals are only used in a couple places currently, but if folks generally
> think that they're a good direction to go
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
--- Comment #13 from Galen Charlton ---
(In reply to Christopher Brannon from comment #12)
> I don't know if it is worth going to a modal dialog window in this one
> function. It isn't a consistent workflow throughout Koha. When you
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
--- Comment #12 from Christopher Brannon ---
There are a couple approaches you could go from here.
Currently we have a jquery setup that simply takes the focus off the input box.
It doesn't disable anything. This has been a success
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
--- Comment #11 from Galen Charlton ---
By the way, my gut feeling is that taking up Liz's suggestion using modal
dialog windows for checkin conditions that require staff acknowledgement would
help avoid the sort of regression I found
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
Galen Charlton changed:
What|Removed |Added
Status|Passed QA |Failed QA
--- Comment #10 f
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
Jonathan Druart changed:
What|Removed |Added
Attachment #23367|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |Passed QA
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
Liz Rea changed:
What|Removed |Added
CC||l...@catalyst.net.nz
--- Comment #
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
--- Comment #6 from Christopher Brannon ---
Owen,
Can you provide any examples of when the field is hidden? I was unaware it did
this. Maybe I have not been in a circumstance that it has.
Christopher
--
You are receiving this mai
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
--- Comment #5 from Owen Leonard ---
Sorry to come late to this patch, but I want to jump in:
Is there any reason to show the input field at all if it's disabled? We are
inconsistent on the checkout page. Sometimes the input is displ
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
Christopher Brannon changed:
What|Removed |Added
CC||cbran...@cdalibrary.org
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
sandbo...@biblibre.com changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
sandbo...@biblibre.com changed:
What|Removed |Added
Attachment #23364|0 |1
is obsolet
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
--- Comment #3 from sandbo...@biblibre.com ---
Created attachment 23367
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23367&action=edit
Bug 11360 - Disable barcode field and submit button when a hold is found
At th
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
Kyle M Hall changed:
What|Removed |Added
Patch complexity|--- |Small patch
--
You are receiv
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
Kyle M Hall changed:
What|Removed |Added
Status|NEW |Needs Signoff
--
You are rece
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
--- Comment #1 from Kyle M Hall ---
Created attachment 23364
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=23364&action=edit
Bug 11360 - Disable barcode field and submit button when a hold is found
At the moment wh
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11360
Kyle M Hall changed:
What|Removed |Added
Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
89 matches
Mail list logo
