https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Marcel de Rooy changed:
What|Removed |Added
Status|RESOLVED|CLOSED
--
You are receivi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Marcel de Rooy changed:
What|Removed |Added
Resolution|--- |DUPLICATE
Stat
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Marcel de Rooy changed:
What|Removed |Added
Blocks||17908
Referenced Bugs:
h
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Jonathan Druart changed:
What|Removed |Added
Status|Signed Off |In Discussion
--- Comment
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #70 from Martin Renvoize ---
I often tidy the file for my own sanity and commit just that tidy.. then I
commit the actual fixes in the next commit(s) and backport them to the untidy
branch if needed for submission.
--
Y
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #69 from Jonathan Druart
---
(In reply to Jacek Ablewicz from comment #68)
> (In reply to Jonathan Druart from comment #66)
> > All the indentation changes make this patchset really hard to read, but
> > basically it see
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #68 from Jacek Ablewicz ---
(In reply to Jonathan Druart from comment #66)
> All the indentation changes make this patchset really hard to read, but
> basically it seems that there are only 2 changes:
> So, why all these
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #67 from Jacek Ablewicz ---
(In reply to Jonathan Druart from comment #66)
> 1/
> Add
> +$MARCfrom ||= GetAuthority($mergefrom);
$MARCfrom (and @record_from) are currently not used in this function for
anything a
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #66 from Jonathan Druart
---
All the indentation changes make this patchset really hard to read, but
basically it seems that there are only 2 changes:
1/
Add
+$MARCfrom ||= GetAuthority($mergefrom);
+$MARCto
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Julian Maurice changed:
What|Removed |Added
Status|Patch doesn't apply |Signed Off
--
You are rec
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Julian Maurice changed:
What|Removed |Added
Attachment #46402|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #61 from Julian Maurice ---
Created attachment 56470
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56470&action=edit
Bug 11700: C4::AuthoritiesMarc::merge enhancements/fixes
- Returns the list of modi
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Julian Maurice changed:
What|Removed |Added
Attachment #46401|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Julian Maurice changed:
What|Removed |Added
Attachment #46400|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Julian Maurice changed:
What|Removed |Added
Attachment #46397|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Julian Maurice changed:
What|Removed |Added
Attachment #46399|0 |1
is obsolete|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Fridolin SOMERS changed:
What|Removed |Added
Status|BLOCKED |Patch doesn't apply
--- C
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Fridolin SOMERS changed:
What|Removed |Added
Depends on|13762 |
Referenced Bugs:
https
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Bug 11700 depends on bug 13762, which changed state.
Bug 13762 Summary: biblionumber field and subfield can be called once in
authorities merge
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13762
What|Remo
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Jacek Ablewicz changed:
What|Removed |Added
See Also||https://bugs.koha-community
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Jacek Ablewicz changed:
What|Removed |Added
CC||a...@biblos.pk.edu.pl
--
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |BLOCKED
Depends on|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Julian Maurice changed:
What|Removed |Added
Attachment #45053|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #52 from Julian Maurice ---
Created attachment 46398
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46398&action=edit
Bug 11700: C4::AuthoritiesMarc::merge enhancements/fixes
- Returns the list of modifi
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Julian Maurice changed:
What|Removed |Added
Attachment #45050|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #50 from Katrin Fischer ---
Merging authorities is broken currently - see bug 15358
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mail
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Kyle M Hall changed:
What|Removed |Added
CC||k...@bywatersolutions.com
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Kyle M Hall changed:
What|Removed |Added
Attachment #45048|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #47 from Kyle M Hall ---
Created attachment 45052
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45052&action=edit
Bug 11700: Add description to unit tests
Signed-off-by: Kyle M Hall
--
You are receiv
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #46 from Kyle M Hall ---
Created attachment 45051
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45051&action=edit
Bug 11700: Add unit tests for C4::AuthoritiesMarc::merge
Signed-off-by: Bernardo Gonzale
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #45 from Kyle M Hall ---
Created attachment 45050
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45050&action=edit
Bug 11700: Avoid to try to delete the authority twice
Signed-off-by: Bernardo Gonzalez K
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #48 from Kyle M Hall ---
Created attachment 45053
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45053&action=edit
Bug 11700 [QA Followup] - Tidy merge a bit, fix warning triggered during unit
tests
Sign
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Kyle M Hall changed:
What|Removed |Added
Attachment #40968|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Kyle M Hall changed:
What|Removed |Added
Status|Signed Off |Passed QA
--
You are receivin
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #42 from Katrin Fischer ---
This is a bit of a mixed bag of things - can you please add test plans to the
2nd and 3rd patch?
--
You are receiving this mail because:
You are watching all bug changes.
_
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Julian Maurice changed:
What|Removed |Added
Attachment #39268|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #40 from Julian Maurice ---
Created attachment 40972
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40972&action=edit
Bug 11700: Add description to unit tests
--
You are receiving this mail because:
You
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Julian Maurice changed:
What|Removed |Added
Status|Failed QA |Signed Off
--- Comment #41
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Julian Maurice changed:
What|Removed |Added
Attachment #39266|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Julian Maurice changed:
What|Removed |Added
Attachment #39265|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Julian Maurice changed:
What|Removed |Added
Attachment #39264|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Katrin Fischer changed:
What|Removed |Added
Status|Signed Off |Failed QA
C
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Bernardo Gonzalez Kriegel changed:
What|Removed |Added
Status|Needs Signoff |Signed Off
--
Y
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Bernardo Gonzalez Kriegel changed:
What|Removed |Added
Attachment #35107|0 |1
is obso
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Bernardo Gonzalez Kriegel changed:
What|Removed |Added
Attachment #28177|0 |1
is obso
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Bernardo Gonzalez Kriegel changed:
What|Removed |Added
Attachment #27973|0 |1
is obso
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Bernardo Gonzalez Kriegel changed:
What|Removed |Added
Attachment #27972|0 |1
is obso
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Bernardo Gonzalez Kriegel changed:
What|Removed |Added
Attachment #27970|0 |1
is obso
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Bernardo Gonzalez Kriegel changed:
What|Removed |Added
Attachment #27971|0 |1
is obso
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Fridolin SOMERS changed:
What|Removed |Added
CC||fridolyn.som...@biblibre.co
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Fridolin SOMERS changed:
What|Removed |Added
See Also||http://bugs.koha-community.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Fridolin SOMERS changed:
What|Removed |Added
See Also||http://bugs.koha-community.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Julian Maurice changed:
What|Removed |Added
Blocks||13706
--
You are receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Julian Maurice changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are r
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #27 from Julian Maurice ---
Created attachment 35107
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35107&action=edit
Bug 11700: Fix unit test when index mode is not defined
Use the same default value as
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #26 from Julian Maurice ---
Jonathan reproduced the bug on one of the sandbox, so no need to do this on
your side.
I think I've found the problem and will submit a patch.
--
You are receiving this mail because:
You are
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #25 from Julian Maurice ---
Hi Marcel,
Unfortunately I am not able to reproduce your problem.
Could you add some debug prints in the mock of ZOOM::Record::raw (line 242 of
t/db_dependent/AuthoritiesMarc.t) ?
Maybe somethi
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #24 from M. de Rooy ---
(In reply to Jonathan Druart from comment #23)
> (In reply to M. de Rooy from comment #21)
> > Hm. I cannot find any reference to field 109 in unimarc too?
>
> Julian has certainly chosen 109 arbit
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #23 from Jonathan Druart ---
(In reply to M. de Rooy from comment #21)
> Hm. I cannot find any reference to field 109 in unimarc too?
Julian has certainly chosen 109 arbitrarily.
The tests pass on a MARC21 installation.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #22 from M. de Rooy ---
OK. I had a closer look. But we are not there yet:
I added some debug prints to the unit test:
warn "L251a"; my @biblios = C4::AuthoritiesMarc::merge($authid2, undef,
$authid1, undef); warn "L251b
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #21 from M. de Rooy ---
Hm. I cannot find any reference to field 109 in unimarc too?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mai
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
M. de Rooy changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
CC|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Jonathan Druart changed:
What|Removed |Added
Attachment #28176|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #18 from Jonathan Druart ---
(In reply to Jonathan Druart from comment #17)
> Created attachment 28176 [details] [review]
> Bug 11700: Avoid to try to delete the authority twice
Not sure dying is the best thing to do...
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Jonathan Druart changed:
What|Removed |Added
Status|Failed QA |Needs Signoff
--
You are
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #17 from Jonathan Druart ---
Created attachment 28176
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28176&action=edit
Bug 11700: Avoid to try to delete the authority twice
--
You are receiving this mai
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.dru...@biblibre.co
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Galen Charlton changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
C
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Martin Renvoize changed:
What|Removed |Added
CC||martin.renvoize@ptfs-europe
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Julian Maurice changed:
What|Removed |Added
Status|Patch doesn't apply |Needs Signoff
--- Comment #
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #12 from Julian Maurice ---
Created attachment 27973
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27973&action=edit
Bug 11700: Fix unit tests when index mode is 'dom'
--
You are receiving this mail be
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Julian Maurice changed:
What|Removed |Added
Attachment #25414|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Julian Maurice changed:
What|Removed |Added
Attachment #25413|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Julian Maurice changed:
What|Removed |Added
Attachment #25426|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Bernardo Gonzalez Kriegel changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't app
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #7 from Julian Maurice ---
Created attachment 25426
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25426&action=edit
Bug 11700: Add unit tests for C4::AuthoritiesMarc::merge
--
You are receiving this ma
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #6 from Julian Maurice ---
I split patch in two parts: 1) whitespace fixes 2) real changes
I'll try to write unit tests asap
--
You are receiving this mail because:
You are watching all bug changes.
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #5 from Julian Maurice ---
Created attachment 25414
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25414&action=edit
Bug 11700: C4::AuthoritiesMarc::merge enhancements/fixes
- Returns the list of modifie
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Julian Maurice changed:
What|Removed |Added
Attachment #25086|0 |1
is obsolete|
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #3 from M. Tompsett ---
Please also note:
http://wiki.koha-community.org/wiki/Coding_Guidelines#PERL6:_Indentation
"If you want to reindent large amounts of existing code in connection with a
bugfix or enhancement, you mus
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
M. Tompsett changed:
What|Removed |Added
CC||mtomp...@hotmail.com
--- Comme
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Julian Maurice changed:
What|Removed |Added
Status|ASSIGNED|Needs Signoff
--
You are r
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
Julian Maurice changed:
What|Removed |Added
Blocks||7419
--
You are receiving
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11700
--- Comment #1 from Julian Maurice ---
Created attachment 25086
-->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=25086&action=edit
Bug 11700: C4::AuthoritiesMarc::merge enhancements/fixes
- Returns the list of modifie
84 matches
Mail list logo
