[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2018-04-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Katrin Fischer changed: What|Removed |Added CC|

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2018-04-19 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Jonathan Druart changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2018-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 --- Comment #41 from Kyle M Hall --- Created attachment 74169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74169=edit Bug 12123 - Make iframe large enough to remove scroll bars --

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2018-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 --- Comment #40 from Jonathan Druart --- We are going to use iframe with a weird display (scrollbars) to catch possible malformed notices. I still do not like the solution. Something else to

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2018-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Kyle M Hall changed: What|Removed |Added Attachment #74113|0 |1

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2018-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Kyle M Hall changed: What|Removed |Added Status|In Discussion

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2018-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 --- Comment #39 from Kyle M Hall --- (In reply to Marcel de Rooy from comment #35) > The example Kyle suggested in comment26 is sufficient to demonstrate that > this patch makes a difference. I recommend

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2018-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 --- Comment #38 from Kyle M Hall --- It seems like the consensus is that the new alternative patch is not acceptable. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2018-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 --- Comment #37 from David Cook --- (In reply to Katrin Fischer from comment #36) > Be careful with the check - HTML5 is not valid XML. Unclosed tags are > perfectly valid. Often browsers are forgiving and

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2018-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 --- Comment #36 from Katrin Fischer --- Be careful with the check - HTML5 is not valid XML. Unclosed tags are perfectly valid. Often browsers are forgiving and probably mail clients too. We don't want to

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2018-04-13 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 --- Comment #35 from Marcel de Rooy --- The example Kyle suggested in comment26 is sufficient to demonstrate that this patch makes a difference. I recommend to restore PQA status and move the html check to

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2018-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 --- Comment #34 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #32) > I'd like your opinions on this alternative patch. Can we add that test to saving the letter in tools/letter.pl ? I

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2018-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 --- Comment #33 from Kyle M Hall --- (In reply to Jonathan Druart from comment #32) > I'd like your opinions on this alternative patch. Your patch will definitely fix any issues with malformed html, but

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2018-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Jonathan Druart changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2018-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 --- Comment #31 from Jonathan Druart --- Created attachment 74113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74113=edit [ALTERNATIVE-PATCH] Bug 12123: Do not render

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2018-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Jonathan Druart changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2018-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Jonathan Druart changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2018-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 --- Comment #29 from Kyle M Hall --- (In reply to Jonathan Druart from comment #27) > Still working. > > SO is from 2014, Marcel did not confirm it recreates the issues. > > Switch back to NSO.

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2018-04-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 --- Comment #28 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #27) > Still working. > > SO is from 2014, Marcel did not confirm it recreates the issues. Will have another look at this

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2018-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Jonathan Druart changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2018-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 --- Comment #26 from Kyle M Hall --- (In reply to Jonathan Druart from comment #25) > Still works: > https://screenshots.firefox.com/XkVBMvtHEg4P3sfT/pro.kohadev.org >

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2018-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 --- Comment #25 from Jonathan Druart --- Still works: https://screenshots.firefox.com/XkVBMvtHEg4P3sfT/pro.kohadev.org https://screenshots.firefox.com/cmfWvx4WeOHNkELn/pro.kohadev.org --

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2018-04-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 --- Comment #24 from Kyle M Hall --- Try something like: <> Thank you for visiting <>. -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2018-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 --- Comment #23 from Jonathan Druart --- I tried that: The following items have been checked out: <> Thank you for visiting <>. And it looks ok. -- You are receiving this

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2018-04-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 --- Comment #22 from Kyle M Hall --- (In reply to Katrin Fischer from comment #21) > I've tried it with the example from the commit message in Firefox and > Chromium and no problems found (without patch).

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2018-04-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 --- Comment #21 from Katrin Fischer --- I've tried it with the example from the commit message in Firefox and Chromium and no problems found (without patch). Maybe something is missing from the test plan?

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2018-04-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Jonathan Druart changed: What|Removed |Added CC|

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2018-04-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Marcel de Rooy changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2018-04-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Marcel de Rooy changed: What|Removed |Added Attachment #73650|0

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2018-04-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2018-04-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Marcel de Rooy changed: What|Removed |Added CC|

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2018-04-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Kyle M Hall changed: What|Removed |Added Attachment #33876|0 |1

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2018-04-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Kyle M Hall changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2018-04-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Kyle M Hall changed: What|Removed |Added Status|REOPENED

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2018-04-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Kyle M Hall changed: What|Removed |Added Attachment #33876|1 |0

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2018-04-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Kyle M Hall changed: What|Removed |Added Attachment #33976|0 |1

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2018-04-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Kyle M Hall changed: What|Removed |Added Status|CLOSED

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2015-04-13 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Tom Misilo misi...@fit.edu changed: What|Removed |Added CC||misi...@fit.edu

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2014-12-03 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Tomás Cohen Arazi tomasco...@gmail.com changed: What|Removed |Added Status|Passed QA

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2014-12-03 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Chris Cormack ch...@bigballofwax.co.nz changed: What|Removed |Added Status|Pushed to Master

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2014-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Needs Signoff |Signed Off

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2014-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #33885|0 |1

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2014-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 David Cook dc...@prosentient.com.au changed: What|Removed |Added CC|

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2014-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Attachment #33950|0 |1

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2014-11-26 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2014-11-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|Failed QA |Needs

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2014-11-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #27403|0 |1

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2014-11-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Attachment #33863|0 |1

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2014-11-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Needs Signoff |Signed Off

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2014-11-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Katrin Fischer katrin.fisc...@bsz-bw.de changed: What|Removed |Added CC|

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2014-11-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Liz Rea l...@catalyst.net.nz changed: What|Removed |Added Attachment #33876|0 |1 is

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2014-11-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Liz Rea l...@catalyst.net.nz changed: What|Removed |Added Status|Signed Off |Needs Signoff

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2014-11-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 David Cook dc...@prosentient.com.au changed: What|Removed |Added Attachment #33885|1 |0

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2014-11-24 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Liz Rea l...@catalyst.net.nz changed: What|Removed |Added Attachment #33885|0 |1 is

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2014-04-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Status|NEW |Needs

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2014-04-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 --- Comment #1 from Kyle M Hall k...@bywatersolutions.com --- Created attachment 27402 -- http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=27402action=edit Bug 12123 - HTML notices can break the notice viewer -- You are

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2014-04-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2014-04-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Kyle M Hall k...@bywatersolutions.com changed: What|Removed |Added Attachment #27402|0 |1

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2014-04-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 jdem...@roseville.ca.us jdem...@roseville.ca.us changed: What|Removed |Added CC|

[Koha-bugs] [Bug 12123] HTML notices can break the notice viewer

2014-04-22 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12123 Owen Leonard oleon...@myacpl.org changed: What|Removed |Added Status|Needs Signoff |Failed QA