[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 --- Comment #52 from Emmi Takkinen --- (In reply to Katrin Fischer from comment #51) > Hi Emmi, bug 31713 has been pushed now. I think it makes this probably a > duplicate, but could you have a look if it covers all your requirements? > > *** This bug has been marked as a duplicate of bug 31713 *** I'm gonna ask one our librarians to test this next week, they have better understanding if something is missing :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Katrin Fischer changed: What|Removed |Added Status|BLOCKED |RESOLVED Resolution|--- |DUPLICATE --- Comment #51 from Katrin Fischer --- Hi Emmi, bug 31713 has been pushed now. I think it makes this probably a duplicate, but could you have a look if it covers all your requirements? *** This bug has been marked as a duplicate of bug 31713 *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 --- Comment #50 from Marcel de Rooy --- In the meantime 31713 moved to FQA. So we might give this a chance again unless it moves quickly. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED CC||m.de.r...@rijksmuseum.nl --- Comment #49 from Marcel de Rooy --- I am blocking this report now in favor of bug 31713. Please communicate about things you might miss from this patch set. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31714 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 --- Comment #48 from Martin Renvoize --- Please see my simplified and modernized alternative in bug 31713 and bug 31714. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Martin Renvoize changed: What|Removed |Added Blocks|31713 | See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=31713 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713 [Bug 31713] Allow easy printing of patron's fines -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Martin Renvoize changed: What|Removed |Added Blocks||31713 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=31713 [Bug 31713] Allow easy printing of patron's fines -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Lisette Scheer changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #47 from Lisette Scheer --- Worked as expected. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 ByWater Sandboxes changed: What|Removed |Added Attachment #139042|0 |1 is obsolete|| --- Comment #46 from ByWater Sandboxes --- Created attachment 140800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140800&action=edit Bug 12285: Determine patrons preferred languge Fineslip is not printed by patrons preferred language choice. To test: 1) Add content to fineslip under "en" tab. 2) Find patron with fines. 3) Set patrons preferred language as "en". 4) Print fines. => Fineslip has default content. 5) Apply patch. 6) Print slip. => Fineslip has "en" content. Sponsored-by: Koha-Suomi Oy Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 ByWater Sandboxes changed: What|Removed |Added Attachment #139041|0 |1 is obsolete|| --- Comment #45 from ByWater Sandboxes --- Created attachment 140799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140799&action=edit Bug 12285: Don't print fines with undef amountoutstanding Accountlines with undefined amountoutstading value are printed in fineslip. To test: 1) Find patron with credit type accountlines. 2) Edit some of those lines from database, set their amountoutstanding as NULL. 3) Print fineslip. => Note that edited credit lines are displayed in the fineslip. 4) Apply patch. 5) Print fineslip. => Note that lines are no longer displayed in the fineslip. Sponsored-by: Koha-Suomi Oy Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 ByWater Sandboxes changed: What|Removed |Added Attachment #139040|0 |1 is obsolete|| --- Comment #44 from ByWater Sandboxes --- Created attachment 140798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140798&action=edit Bug 12285: (follow-up) Correct extra quote in yml file Signed-off-by: Owen Leonard Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 ByWater Sandboxes changed: What|Removed |Added Attachment #139039|0 |1 is obsolete|| --- Comment #43 from ByWater Sandboxes --- Created attachment 140797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140797&action=edit Bug 12285: Use accountlines date if issue is not found Printing fines slip would raise error if patron has manually created invoice. In these cases use accountlines date instead of issues date_due. Also silence error: "Argument "" isn't numeric in numeric comparison (<=>)" Sponsored-by: Koha-Suomi Oy Signed-off-by: Owen Leonard Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 ByWater Sandboxes changed: What|Removed |Added Attachment #139038|0 |1 is obsolete|| --- Comment #42 from ByWater Sandboxes --- Created attachment 140796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140796&action=edit Bug 12285: Fix QA issues This patch: - removes GetBorrowerFines and reworks Fineslip to use Koha objects - adds the new notice template in the translated sample_notices.sql files - adds unit tests Sponsored-by: Koha-Suomi Oy Signed-off-by: Owen Leonard Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 ByWater Sandboxes changed: What|Removed |Added Attachment #139037|0 |1 is obsolete|| --- Comment #41 from ByWater Sandboxes --- Created attachment 140795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=140795&action=edit Bug 12285: Allow easy printing of patron's fines. Add a printing option to the staff client patron details page to print a slip of patron's fines. To test: 1) Apply patch. 2) Check in tools > Notices & Slips that you have FINESLIP slip, and a print message there. If not, run updatedatabase.pl 3) Either create some fines for a patron, or look up a patron with existing fines. 4) From that patron's detail page, and the Print-menu in the toolbar, select "Print fines" 5) You should get a slip of the patron's fines. I removed superfluous $ signs in sample_notices.sql and updatedatabase.pl Patch works now as expected. However, it needs now a Sign-off by somebody else. Signed-off-by: Aleisha Rebased-by: Emmi Takkinen Signed-off-by: Owen Leonard Signed-off-by: Lisette Scheer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Emmi Takkinen changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #40 from Emmi Takkinen --- Rebased patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Emmi Takkinen changed: What|Removed |Added Attachment #133147|0 |1 is obsolete|| --- Comment #39 from Emmi Takkinen --- Created attachment 139042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139042&action=edit Bug 12285: Determine patrons preferred languge Fineslip is not printed by patrons preferred language choice. To test: 1) Add content to fineslip under "en" tab. 2) Find patron with fines. 3) Set patrons preferred language as "en". 4) Print fines. => Fineslip has default content. 5) Apply patch. 6) Print slip. => Fineslip has "en" content. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Emmi Takkinen changed: What|Removed |Added Attachment #133112|0 |1 is obsolete|| --- Comment #38 from Emmi Takkinen --- Created attachment 139041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139041&action=edit Bug 12285: Don't print fines with undef amountoutstanding Accountlines with undefined amountoutstading value are printed in fineslip. To test: 1) Find patron with credit type accountlines. 2) Edit some of those lines from database, set their amountoutstanding as NULL. 3) Print fineslip. => Note that edited credit lines are displayed in the fineslip. 4) Apply patch. 5) Print fineslip. => Note that lines are no longer displayed in the fineslip. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Emmi Takkinen changed: What|Removed |Added Attachment #129947|0 |1 is obsolete|| --- Comment #37 from Emmi Takkinen --- Created attachment 139040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139040&action=edit Bug 12285: (follow-up) Correct extra quote in yml file Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Emmi Takkinen changed: What|Removed |Added Attachment #129946|0 |1 is obsolete|| --- Comment #36 from Emmi Takkinen --- Created attachment 139039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139039&action=edit Bug 12285: Use accountlines date if issue is not found Printing fines slip would raise error if patron has manually created invoice. In these cases use accountlines date instead of issues date_due. Also silence error: "Argument "" isn't numeric in numeric comparison (<=>)" Sponsored-by: Koha-Suomi Oy Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Emmi Takkinen changed: What|Removed |Added Attachment #129945|0 |1 is obsolete|| --- Comment #35 from Emmi Takkinen --- Created attachment 139038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139038&action=edit Bug 12285: Fix QA issues This patch: - removes GetBorrowerFines and reworks Fineslip to use Koha objects - adds the new notice template in the translated sample_notices.sql files - adds unit tests Sponsored-by: Koha-Suomi Oy Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Emmi Takkinen changed: What|Removed |Added Attachment #129944|0 |1 is obsolete|| --- Comment #34 from Emmi Takkinen --- Created attachment 139037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=139037&action=edit Bug 12285: Allow easy printing of patron's fines. Add a printing option to the staff client patron details page to print a slip of patron's fines. To test: 1) Apply patch. 2) Check in tools > Notices & Slips that you have FINESLIP slip, and a print message there. If not, run updatedatabase.pl 3) Either create some fines for a patron, or look up a patron with existing fines. 4) From that patron's detail page, and the Print-menu in the toolbar, select "Print fines" 5) You should get a slip of the patron's fines. I removed superfluous $ signs in sample_notices.sql and updatedatabase.pl Patch works now as expected. However, it needs now a Sign-off by somebody else. Signed-off-by: Aleisha Rebased-by: Emmi Takkinen Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285
Lisette Scheer changed:
What|Removed |Added
Status|Needs Signoff |Patch doesn't apply
--- Comment #33 from Lisette Scheer ---
Patch Failed to apply.
TASK [Apply bug 12285 via git-bz in docker container]
**
fatal: [localhost -> koha-fineprint]: FAILED! => {"changed": true, "cmd": "cd
/kohadevbox/koha && yes | git bz apply 12285", "delta": "0:00:04.819270",
"end": "2022-08-11 16:05:34.779629", "msg": "non-zero return code", "rc": 1,
"start": "2022-08-11 16:05:29.960359", "stderr": "error: Failed to merge in the
changes.\nhint: Use 'git am --show-current-patch=diff' to see the failed
patch\nPatch left in
/tmp/Bug-12285-Allow-easy-printing-of-patrons-fines-MrApna.patch",
"stderr_lines": ["error: Failed to merge in the changes.", "hint: Use 'git am
--show-current-patch=diff' to see the failed patch", "Patch left in
/tmp/Bug-12285-Allow-easy-printing-of-patrons-fines-MrApna.patch"], "stdout":
"Applying: Bug 12285: Allow easy printing of patron's fines.\nUsing index info
to reconstruct a base
tree...\nM\tC4/Members.pm\nM\tinstaller/data/mysql/en/mandatory/sample_notices.yml\nM\tkoha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc\nM\tkoha-tmpl/intranet-tmpl/prog/js/members-menu.js\nFalling
back to patching base and 3-way merge...\nAuto-merging
koha-tmpl/intranet-tmpl/prog/js/members-menu.js\nAuto-merging
koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc\nAuto-merging
installer/data/mysql/en/mandatory/sample_notices.yml\nCONFLICT (content): Merge
conflict in installer/data/mysql/en/mandatory/sample_notices.yml\nAuto-merging
C4/Members.pm\nPatch failed at 0001 Bug 12285: Allow easy printing of patron's
fines.\nWhen you have resolved this problem run \"git bz apply
--continue\".\nIf you would prefer to skip this patch, instead run \"git bz
apply --skip\".\nTo restore the original branch and stop patching run \"git bz
apply --abort\".\n\nBug 12285 - Allow easy printing of patron's fines\n\n129944
- Bug 12285: Allow easy printing of patron's fines.\n129945 - Bug 12285: Fix QA
issues\n129946 - Bug 12285: Use accountlines date if issue is not found\n129947
- Bug 12285: (follow-up) Correct extra quote in yml file\n133112 - Bug 12285:
Don't print fines with undef amountoutstanding\n133147 - Bug 12285: Determine
patrons preferred languge\n\nApply? [(y)es, (n)o, (i)nteractive] ",
"stdout_lines": ["Applying: Bug 12285: Allow easy printing of patron's fines.",
"Using index info to reconstruct a base tree...", "M\tC4/Members.pm",
"M\tinstaller/data/mysql/en/mandatory/sample_notices.yml",
"M\tkoha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc",
"M\tkoha-tmpl/intranet-tmpl/prog/js/members-menu.js", "Falling back to patching
base and 3-way merge...", "Auto-merging
koha-tmpl/intranet-tmpl/prog/js/members-menu.js", "Auto-merging
koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc", "Auto-merging
installer/data/mysql/en/mandatory/sample_notices.yml", "CONFLICT (content):
Merge conflict in installer/data/mysql/en/mandatory/sample_notices.yml",
"Auto-merging C4/Members.pm", "Patch failed at 0001 Bug 12285: Allow easy
printing of patron's fines.", "When you have resolved this problem run \"git bz
apply --continue\".", "If you would prefer to skip this patch, instead run
\"git bz apply --skip\".", "To restore the original branch and stop patching
run \"git bz apply --abort\".", "", "Bug 12285 - Allow easy printing of
patron's fines", "", "129944 - Bug 12285: Allow easy printing of patron's
fines.", "129945 - Bug 12285: Fix QA issues", "129946 - Bug 12285: Use
accountlines date if issue is not found", "129947 - Bug 12285: (follow-up)
Correct extra quote in yml file", "133112 - Bug 12285: Don't print fines with
undef amountoutstanding", "133147 - Bug 12285: Determine patrons preferred
languge", "", "Apply? [(y)es, (n)o, (i)nteractive] "]}
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 --- Comment #32 from Emmi Takkinen --- Created attachment 133147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133147&action=edit Bug 12285: Determine patrons preferred languge Fineslip is not printed by patrons preferred language choice. To test: 1) Add content to fineslip under "en" tab. 2) Find patron with fines. 3) Set patrons preferred language as "en". 4) Print fines. => Fineslip has default content. 5) Apply patch. 6) Print slip. => Fineslip has "en" content. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Emmi Takkinen changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 --- Comment #31 from Emmi Takkinen --- Created attachment 133112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=133112&action=edit Bug 12285: Don't print fines with undef amountoutstanding Accountlines with undefined amountoutstading value are printed in fineslip. To test: 1) Find patron with credit type accountlines. 2) Edit some of those lines from database, set their amountoutstanding as NULL. 3) Print fineslip. => Note that edited credit lines are displayed in the fineslip. 4) Apply patch. 5) Print fineslip. => Note that lines are no longer displayed in the fineslip. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 --- Comment #30 from Emmi Takkinen --- Just noticed that accountlines with undefined amountoutstanding are printed in fineslip. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 --- Comment #29 from Emmi Takkinen --- (In reply to Kyle M Hall from comment #28) > t/db_dependent/Members/FineSlip.t is failing Tested and tests pass fine. Could you take a look where it exactly fails for you? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Kyle M Hall changed: What|Removed |Added QA Contact|k...@bywatersolutions.com |testo...@bugs.koha-communit ||y.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #28 from Kyle M Hall --- t/db_dependent/Members/FineSlip.t is failing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Kyle M Hall changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |k...@bywatersolutions.com |y.org | CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Emmi Takkinen changed: What|Removed |Added Status|ASSIGNED|Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Emmi Takkinen changed: What|Removed |Added Status|Signed Off |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 --- Comment #27 from Owen Leonard --- Created attachment 129947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129947&action=edit Bug 12285: (follow-up) Correct extra quote in yml file Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 --- Comment #26 from Owen Leonard --- Created attachment 129946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129946&action=edit Bug 12285: Use accountlines date if issue is not found Printing fines slip would raise error if patron has manually created invoice. In these cases use accountlines date instead of issues date_due. Also silence error: "Argument "" isn't numeric in numeric comparison (<=>)" Sponsored-by: Koha-Suomi Oy Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 --- Comment #25 from Owen Leonard --- Created attachment 129945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129945&action=edit Bug 12285: Fix QA issues This patch: - removes GetBorrowerFines and reworks Fineslip to use Koha objects - adds the new notice template in the translated sample_notices.sql files - adds unit tests Sponsored-by: Koha-Suomi Oy Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Owen Leonard changed: What|Removed |Added Attachment #129943|0 |1 is obsolete|| --- Comment #24 from Owen Leonard --- Created attachment 129944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129944&action=edit Bug 12285: Allow easy printing of patron's fines. Add a printing option to the staff client patron details page to print a slip of patron's fines. To test: 1) Apply patch. 2) Check in tools > Notices & Slips that you have FINESLIP slip, and a print message there. If not, run updatedatabase.pl 3) Either create some fines for a patron, or look up a patron with existing fines. 4) From that patron's detail page, and the Print-menu in the toolbar, select "Print fines" 5) You should get a slip of the patron's fines. I removed superfluous $ signs in sample_notices.sql and updatedatabase.pl Patch works now as expected. However, it needs now a Sign-off by somebody else. Signed-off-by: Aleisha Rebased-by: Emmi Takkinen Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Owen Leonard changed: What|Removed |Added Attachment #129922|0 |1 is obsolete|| Attachment #129923|0 |1 is obsolete|| Attachment #129937|0 |1 is obsolete|| --- Comment #23 from Owen Leonard --- Created attachment 129943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129943&action=edit Bug 12285: Allow easy printing of patron's fines. Add a printing option to the staff client patron details page to print a slip of patron's fines. To test: 1) Apply patch. 2) Check in tools > Notices & Slips that you have FINESLIP slip, and a print message there. If not, run updatedatabase.pl 3) Either create some fines for a patron, or look up a patron with existing fines. 4) From that patron's detail page, and the Print-menu in the toolbar, select "Print fines" 5) You should get a slip of the patron's fines. I removed superfluous $ signs in sample_notices.sql and updatedatabase.pl Patch works now as expected. However, it needs now a Sign-off by somebody else. Signed-off-by: Aleisha Rebased-by: Emmi Takkinen Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Emmi Takkinen changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 --- Comment #22 from Emmi Takkinen --- Created attachment 129937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129937&action=edit Bug 12285: Use accountlines date if issue is not found Printing fines slip would raise error if patron has manually created invoice. In these cases use accountlines date instead of issues date_due. Also silence error: "Argument "" isn't numeric in numeric comparison (<=>)" Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #21 from Owen Leonard --- > > FAIL installer/data/mysql/en/mandatory/sample_notices.yml > >FAIL yaml_valid > > ARRAY(0x55d88d804738) Line 1594 has an extra quote: - """ I get an error when printing a fine slip for a charge which isn't associated with a checkout: Can't call method "date_due" on an undefined value at /kohadevbox/koha/C4/Members.pm line 711 I triggered this by going to Accounting -> Create manual invoice and adding an arbitrary amount. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Emmi Takkinen changed: What|Removed |Added Status|Failed QA |Needs Signoff --- Comment #20 from Emmi Takkinen --- (In reply to Owen Leonard from comment #17) > I'm still getting warnings from the QA tool: > > FAIL installer/data/mysql/en/mandatory/sample_notices.yml >FAIL yaml_valid > ARRAY(0x55d88d804738) > > The change to sample_notices.yml also lacks a value for "module," which is > required. > > After applying the patch and running "reset_all" in koha-testing-docker I > see this error in the output: > > C4::Installer::load_sql returned the following errors while attempting to > load /kohadevbox/koha/installer/data/mysql/en/mandatory/sample_notices.yml: > DBD::mysql::db do failed: Cannot add or update a child row: a foreign key > constraint fails (`koha_kohadev`.`letter`, CONSTRAINT > `message_transport_type_fk` FOREIGN KEY (`message_transport_type`) > REFERENCES `message_transport_types` (`message_transport_type`) ON DELETE > CASCADE ON UPDA) at /kohadevbox/koha/C4/Installer.pm line 574. I was unable to produce these errors, but fixed invalid yaml syntax and missing "module" value to the first patch. Also fixed atomicupdate files name (there was cap between 12285 and -allow) and added IGNORE to INSERT statement (my wild guess is that this caused that last error). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Emmi Takkinen changed: What|Removed |Added Attachment #129724|0 |1 is obsolete|| --- Comment #19 from Emmi Takkinen --- Created attachment 129923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129923&action=edit Bug 12285: Fix QA issues This patch: - removes GetBorrowerFines and reworks Fineslip to use Koha objects - adds the new notice template in the translated sample_notices.sql files - adds unit tests Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Emmi Takkinen changed: What|Removed |Added Attachment #129723|0 |1 is obsolete|| --- Comment #18 from Emmi Takkinen --- Created attachment 129922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129922&action=edit Bug 12285: Allow easy printing of patron's fines. Add a printing option to the staff client patron details page to print a slip of patron's fines. To test: 1) Apply patch. 2) Check in tools > Notices & Slips that you have FINESLIP slip, and a print message there. If not, run updatedatabase.pl 3) Either create some fines for a patron, or look up a patron with existing fines. 4) From that patron's detail page, and the Print-menu in the toolbar, select "Print fines" 5) You should get a slip of the patron's fines. I removed superfluous $ signs in sample_notices.sql and updatedatabase.pl Patch works now as expected. However, it needs now a Sign-off by somebody else. Signed-off-by: Aleisha Rebased-by: Emmi Takkinen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #17 from Owen Leonard --- I'm still getting warnings from the QA tool: FAIL installer/data/mysql/en/mandatory/sample_notices.yml FAIL yaml_valid ARRAY(0x55d88d804738) The change to sample_notices.yml also lacks a value for "module," which is required. After applying the patch and running "reset_all" in koha-testing-docker I see this error in the output: C4::Installer::load_sql returned the following errors while attempting to load /kohadevbox/koha/installer/data/mysql/en/mandatory/sample_notices.yml: DBD::mysql::db do failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`letter`, CONSTRAINT `message_transport_type_fk` FOREIGN KEY (`message_transport_type`) REFERENCES `message_transport_types` (`message_transport_type`) ON DELETE CASCADE ON UPDA) at /kohadevbox/koha/C4/Installer.pm line 574. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Emmi Takkinen changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Emmi Takkinen changed: What|Removed |Added Attachment #123243|0 |1 is obsolete|| --- Comment #16 from Emmi Takkinen --- Created attachment 129724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129724&action=edit Bug 12285: Fix QA issues This patch: - removes GetBorrowerFines and reworks Fineslip to use Koha objects - adds the new notice template in the translated sample_notices.sql files - adds unit tests Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Emmi Takkinen changed: What|Removed |Added Attachment #123202|0 |1 is obsolete|| --- Comment #15 from Emmi Takkinen --- Created attachment 129723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=129723&action=edit Bug 12285: Allow easy printing of patron's fines. Add a printing option to the staff client patron details page to print a slip of patron's fines. To test: 1) Apply patch. 2) Check in tools > Notices & Slips that you have FINESLIP slip, and a print message there. If not, run updatedatabase.pl 3) Either create some fines for a patron, or look up a patron with existing fines. 4) From that patron's detail page, and the Print-menu in the toolbar, select "Print fines" 5) You should get a slip of the patron's fines. I removed superfluous $ signs in sample_notices.sql and updatedatabase.pl Patch works now as expected. However, it needs now a Sign-off by somebody else. Signed-off-by: Aleisha Rebased-by: Emmi Takkinen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Kelly McElligott changed: What|Removed |Added CC||ke...@bywatersolutions.com Status|Needs Signoff |Failed QA --- Comment #14 from Kelly McElligott --- Hi ! Tried to sign off on this bug and received this error: Can't call method "date_due" on an undefined value at /kohadevbox/koha/C4/Members.pm line 702 Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Emmi Takkinen changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Emmi Takkinen changed: What|Removed |Added Attachment #123203|0 |1 is obsolete|| --- Comment #13 from Emmi Takkinen --- Created attachment 123243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123243&action=edit Bug 12285: Fix QA issues This patch: - removes GetBorrowerFines and reworks Fineslip to use Koha objects - adds the new notice template in the translated sample_notices.sql files - adds unit tests Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #12 from Owen Leonard --- The print slip page gives me an error: Can't call method "unblessed" on an undefined value at /kohadevbox/koha/C4/Members.pm line 692 QA tool reports the following failures: FAIL C4/Members.pm FAIL pod coverage POD is missing for FineSlip POD is missing for checkcardnumber FAIL t/db_dependent/Members/FineSlip.t FAIL file permissions File must have the exec flag -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Emmi Takkinen changed: What|Removed |Added Status|Failed QA |Needs Signoff Assignee|koha-b...@lists.koha-commun |emmi.takki...@koha-suomi.fi |ity.org | --- Comment #11 from Emmi Takkinen --- Created attachment 123203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123203&action=edit Bug 12285: Fix QA issues This patch: - removes GetBorrowerFines and reworks Fineslip to use Koha objects - adds the new notice template in the translated sample_notices.sql files - adds unit tests To test follow test plan from previous patch and confirm everything works as intented. Also prove t/db_dependent/Members/FineSlip.t. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Emmi Takkinen changed: What|Removed |Added Attachment #29692|0 |1 is obsolete|| CC||emmi.takki...@koha-suomi.fi --- Comment #10 from Emmi Takkinen --- Created attachment 123202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=123202&action=edit Bug 12285: Allow easy printing of patron's fines. Add a printing option to the staff client patron details page to print a slip of patron's fines. To test: 1) Apply patch. 2) Check in tools > Notices & Slips that you have FINESLIP slip, and a print message there. If not, run updatedatabase.pl 3) Either create some fines for a patron, or look up a patron with existing fines. 4) From that patron's detail page, and the Print-menu in the toolbar, select "Print fines" 5) You should get a slip of the patron's fines. I removed superfluous $ signs in sample_notices.sql and updatedatabase.pl Patch works now as expected. However, it needs now a Sign-off by somebody else. Signed-off-by: Aleisha Rebased-by: Emmi Takkinen -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Barton Chittenden changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=10708 CC||bar...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Lisette changed: What|Removed |Added CC||lisettesla...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 paxed changed: What|Removed |Added Assignee|pasi.kalli...@pttk.fi |koha-b...@lists.koha-commun ||ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 --- Comment #9 from Katrin Fischer --- Pasi, is this still on your todo list or would it be ok to reset the Assignee? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Nicole C. Engard changed: What|Removed |Added CC|neng...@gmail.com | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 NancyK. changed: What|Removed |Added CC||nkee...@washoecounty.us --- Comment #8 from NancyK. --- Hi, is anyone still considering his bug. I have had a request from staff for this very feature. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Josef Moravec changed: What|Removed |Added CC||josef.mora...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Katrin Fischer changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=1232 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285
--- Comment #7 from Katrin Fischer ---
Comment on attachment 29692
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29692
Bug 12285: Allow easy printing of patron's fines.
Review of attachment 29692:
-->
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=12285&attachment=29692)
-
Hi Pasi,
I have added my comments using Splinter review, hope everything is clear.
Again, I really like the idea of this and hope you can provide a follow-up.
Addition to Splinter comments:
Please include the new notice template in the translated sample_notices.sql as
well. Leaving them in English is fine.
::: C4/Members.pm
@@ +2406,5 @@
> );
> }
>
> +
> +sub GetBorrowerFines {
I am not sure this one is needed - why not use GetMemberAccountRecords? If we
are to keep this one, please point out why it's more useful and add unit tests
and documentation (POD).
@@ +2422,5 @@
> +my $data = $sth->fetchall_arrayref({});
> +return $data;
> +}
> +
> +sub FineSlip {
Needs unit tests.
::: installer/data/mysql/en/mandatory/sample_notices.sql
@@ +143,5 @@
> Your library.'
> );
> +
> +INSERT INTO letter (module, code, branchcode, name, is_html, title,
> content, message_transport_type)
> +VALUES ( 'circulation', 'FINESLIP', '', 'Patron fines -slip', '1', 'Fines',
> '<> <>
I think 'Fines and fees slip' would maybe be better.
@@ +149,5 @@
> +Fines: <>
> +
> +
> +<>, <>
> +Bar code: <>
Small typo - barcode, please fix.
::: installer/data/mysql/updatedatabase.pl
@@ +8573,5 @@
> +$DBversion = "3.17.00.XXX";
> +if ( CheckVersion($DBversion) ) {
> +$dbh->do("
> +INSERT INTO letter (module, code, branchcode, name, is_html, title,
> content, message_transport_type)
> +VALUES ( 'circulation', 'FINESLIP', '', 'Patron fines -slip', '1', 'Fines',
> '<> <>
Please fix the name here too.
@@ +8579,5 @@
> +Fines: <>
> +
> +
> +<>, <>
> +Bar code: <>
Small typo, please fix.
::: koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc
@@ +129,4 @@
> [% IF ( CAN_user_borrowers ) %] href="#">Print summary[% END %]
> Print slip
> Print quick slip
> +Print fines
Maybe print fines and fees? Just a suggestion, not blocker.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Failed QA CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 --- Comment #6 from sandbo...@biblibre.com --- Created attachment 29692 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29692&action=edit Bug 12285: Allow easy printing of patron's fines. Add a printing option to the staff client patron details page to print a slip of patron's fines. To test: 1) Apply patch. 2) Check in tools > Notices & Slips that you have FINESLIP slip, and a print message there. If not, run updatedatabase.pl 3) Either create some fines for a patron, or look up a patron with existing fines. 4) From that patron's detail page, and the Print-menu in the toolbar, select "Print fines" 5) You should get a slip of the patron's fines. I removed superfluous $ signs in sample_notices.sql and updatedatabase.pl Patch works now as expected. However, it needs now a Sign-off by somebody else. Signed-off-by: Aleisha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 sandbo...@biblibre.com changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||sandbo...@biblibre.com --- Comment #5 from sandbo...@biblibre.com --- Patch tested with a sandbox, by Aleisha -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 sandbo...@biblibre.com changed: What|Removed |Added Attachment #29144|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Marc Véron changed: What|Removed |Added Attachment #28327|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Marc Véron changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 --- Comment #4 from Marc Véron --- Created attachment 29144 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=29144&action=edit Bug 12285: Allow easy printing of patron's fines. Add a printing option to the staff client patron details page to print a slip of patron's fines. To test: 1) Apply patch. 2) Check in tools > Notices & Slips that you have FINESLIP slip, and a print message there. If not, run updatedatabase.pl 3) Either create some fines for a patron, or look up a patron with existing fines. 4) From that patron's detail page, and the Print-menu in the toolbar, select "Print fines" 5) You should get a slip of the patron's fines. I removed superfluous $ signs in sample_notices.sql and updatedatabase.pl Patch works now as expected. However, it needs now a Sign-off by somebody else. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Nicole C. Engard changed: What|Removed |Added Status|Needs Signoff |Failed QA CC||neng...@gmail.com --- Comment #3 from Nicole C. Engard --- Changing status so Marc's concerns are addressed in a new patch. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch --- Comment #2 from Marc Véron --- I tested. After applying the patch the menu item appeared as expected, but the slip did not display properly. Ic checked FINESLIP in Home › Tools › Notices & Slips. It had missing angle brackets (<) at two places. After fixing it the slip printed as expected. The HTML in FINESLIP inserted by the patch was: <> <> <> Fines: <> <>, 1001> Bar code: <> <> Total: 1001> If I look at the patch, the strange 1001's appear at the places where, in both SQL statemens, we have $<> and $<> Could it be that the $ signes are superfluous? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12285] Allow easy printing of patron's fines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12285 paxed changed: What|Removed |Added Status|NEW |Needs Signoff Assignee|koha-b...@lists.koha-commun |pasi.kalli...@pttk.fi |ity.org | --- Comment #1 from paxed --- Created attachment 28327 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=28327&action=edit Add a printing option to the staff client patron details page to print a slip of patron's fines. Add a printing option to the staff client patron details page to print a slip of patron's fines. To test: 1) Apply patch. 2) Check in tools > Notices & Slips that you have FINESLIP slip, and a print message there. If not, run updatedatabase.pl 3) Either create some fines for a patron, or look up a patron with existing fines. 4) From that patron's detail page, and the Print-menu in the toolbar, select "Print fines" 5) You should get a slip of the patron's fines. --- Yes, the C4/Members.pm is missing docs. I'm just getting this out in case it's of any use. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
