https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #78 from Victor Grousset/tuxayo ---
(In reply to Koha Team Lyon 3 from comment #77)
> With DecimalSeparators=',.', when you are on paycollect.pl and choose to
> writeoff a fine, if you enter
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Koha Team Lyon 3 changed:
What|Removed |Added
Status|Needs Signoff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Victor Grousset/tuxayo changed:
What|Removed |Added
Status|Signed Off
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Séverine Queune changed:
What|Removed |Added
Attachment #74525|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Séverine Queune changed:
What|Removed |Added
Attachment #74526|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Séverine Queune changed:
What|Removed |Added
Attachment #74524|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Séverine Queune changed:
What|Removed |Added
Status|Needs Signoff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Séverine Queune changed:
What|Removed |Added
Attachment #73874|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Séverine Queune changed:
What|Removed |Added
Attachment #73880|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Séverine Queune changed:
What|Removed |Added
Attachment #73873|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Victor Grousset/tuxayo changed:
What|Removed |Added
Status|In Discussion
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Victor Grousset/tuxayo changed:
What|Removed |Added
Status|Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Patrick Robitaille changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
M. Tompsett changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #66 from M. Tompsett ---
Comment on attachment 73873
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73873
Bug 12310 : Decimal separator issues: fixes in fines
Review of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #65 from M. Tompsett ---
Created attachment 73880
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73880=edit
Bug 12310: Follow up to prevent updatedatabase noise
Added IGNORE into
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Jonathan Druart changed:
What|Removed |Added
Keywords|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #73874|1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #73785|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #73784|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #73874|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #63 from Victor Grousset/tuxayo ---
Created attachment 73873
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73873=edit
Bug 12310 : Decimal separator issues: fixes in fines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #64 from Victor Grousset/tuxayo ---
Created attachment 73874
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73874=edit
Bug 12310 : Follow up to keep the example text in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Jonathan Druart changed:
What|Removed |Added
Severity|critical
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #62 from M. Tompsett ---
Created attachment 73785
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73785=edit
Bug 12310: Follow up to keep example text
This put the example text
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #61 from Victor Grousset/tuxayo ---
*Has everything been addressed?
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #60 from Victor Grousset/tuxayo ---
(In reply to M. Tompsett from comment #58)
> The function name is decimal_from_string. It's not intuitive to return false.
It doesn't make sense to
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #73657|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #58 from M. Tompsett ---
Comment on attachment 73657
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73657
Bug 12310 : Decimal separator issues: some fixes in fines
Review of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Victor Grousset/tuxayo changed:
What|Removed |Added
Status|ASSIGNED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #73546|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #73215|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #56 from Victor Grousset/tuxayo ---
Created attachment 73546
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73546=edit
Bug 12310 : Decimal separator issues: some fixes in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #55 from Victor Grousset/tuxayo ---
not yet, TODO:
- don't bind change event in HTML but with JS
- be consistent with the position of the includes
- ensure var and function names are clear
-
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Victor Grousset/tuxayo changed:
What|Removed |Added
Blocks|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #54 from Katrin Fischer ---
Hi Victor, should this be Needs Signoff?
--
You are receiving this mail because:
You are watching all bug changes.
___
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #73055|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #72983|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #52 from Victor Grousset/tuxayo ---
Created attachment 73055
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73055=edit
Bug 12310 : Decimal separators issues: some fixes in
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #51 from Séverine Queune ---
Tested with different separators on the syspref : patch correctly applies on
the indicated pages.
The messages "Please use any of the following character(s) "." as
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #64675|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #50 from Victor Grousset/tuxayo ---
Created attachment 72983
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72983=edit
Bug 12310 : Decimal separators issues: fix
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #72213|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #49 from Victor Grousset/tuxayo ---
TODO check that bug 18471 isn't back.
== Plan ==
- Make the patch work again
- Fix all the QA issues, make a clean thing
- sign off (spam Lyon 3, cait,
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #48 from Victor Grousset/tuxayo ---
After talking to Lyon 3, BULAC, Owen, cait and another library. The conclusions
are:
- the current behavior is okay
- we need to keep the syspref to leave
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #47 from Victor Grousset/tuxayo ---
- 1.1
- 1.000,6 → 1 with syspref ",."
- 1.000,6 → 1000.6 with syspref ","
- .6,
- 0
- 1,346.55 → 1.346.55 with syspref ",."
- 1,346.55 → 1346.55 with
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #46 from Victor Grousset/tuxayo ---
some QA feedback:
- enforce JS9 coding guideline
- JS10: use JQuery validation
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #45 from Victor Grousset/tuxayo ---
After talking to cait: must support thousands separators
After talking to BULAC and Lyon 3 and at least 2 other libraries: must support
multiple decimal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Victor Grousset/tuxayo changed:
What|Removed |Added
Severity|normal
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #43 from Victor Grousset/tuxayo ---
Some QA feedback:
- create a dedicated JS lib instead of an include
--
You are receiving this mail because:
You are watching all bug changes.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #42 from Victor Grousset/tuxayo ---
some QA feedback:
- maybe hardcode the two decimal separators (,.) instead of creating a syspref
- don't display a long hint message next to each field.
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #41 from Koha Team Lyon 3 ---
First test, first issue...
I had ".," in the digitseparator syspref.
I tried to add a manual invoice in Patron (/cgi-bin/koha/members/maninvoice.pl)
I put "10,34" and it
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Victor Grousset/tuxayo changed:
What|Removed |Added
Status|Patch doesn't
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #64696|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Victor Grousset/tuxayo changed:
What|Removed |Added
Severity|enhancement
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #64696|1
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #72104|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Victor Grousset/tuxayo changed:
What|Removed |Added
Attachment #64696|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Victor Grousset/tuxayo changed:
What|Removed |Added
Status|Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Victor Grousset/tuxayo changed:
What|Removed |Added
Status|Needs Signoff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #35 from Koha Team Lyon 3 ---
Hello,
if someone is OK to work on this before the next hackfest in March, I'm OK to
test it during the hackfest.
Sonia
--
You are receiving this mail because:
You are
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Victor Grousset/tuxayo changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Marjorie Barry-Vila changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Koha Team Lyon 3 changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Koha Team Lyon 3 changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #33 from Baptiste ---
> Hi Babtiste
>
> - Functionality works OK
Owww yeah ! :p
>
> - In syspref DigitSeparator I have . and , defined as separators, however
> the message says:
>
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #32 from Marc Véron ---
Hi Babtiste
- Functionality works OK
- In syspref DigitSeparator I have . and , defined as separators, however the
message says:
Please use any of the following character(s) ","
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Baptiste changed:
What|Removed |Added
Status|Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Séverine Queune changed:
What|Removed |Added
See Also|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Séverine Queune changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Baptiste changed:
What|Removed |Added
Attachment #64679|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #30 from Marc Véron ---
(In reply to Katrin Fischer from comment #29)
> What about just "Edit separators"?
>
> It's a pet peeve of mine... not so much a fan of 'click here' - a link
> should be obvious
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Katrin Fischer changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Marc Véron changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
---
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Baptiste changed:
What|Removed |Added
Status|Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Baptiste changed:
What|Removed |Added
Attachment #64678|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Baptiste changed:
What|Removed |Added
Attachment #64672|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Marc Véron changed:
What|Removed |Added
Status|Needs Signoff |Failed QA
--
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #25 from Marc Véron ---
1)
The syspref is populated with ,.
The text says:
"The separator used between integer and decimal part"
Maybe it would be better to explain a little bit more:
"Accept any of
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #24 from Marc Véron ---
Created attachment 64675
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64675=edit
Screenshot rebasing problem
Screenshot of text that remained from a merge /
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #23 from Baptiste ---
Rebased
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Baptiste changed:
What|Removed |Added
Attachment #61604|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Baptiste changed:
What|Removed |Added
Attachment #64671|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Baptiste changed:
What|Removed |Added
Attachment #62655|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Baptiste changed:
What|Removed |Added
Attachment #60563|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Fridolin SOMERS changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Fridolin SOMERS changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #17 from Baptiste ---
Created attachment 62655
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62655=edit
Bug 12310: Format prices on other pages
Fields on thoses page
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #16 from Koha Team Lyon 3 ---
I repeat tests proposed by Marc in Comment 5 :
With syspref DigitSeparator : ",."
CHF 1.45 -> 1.45 OK
12.50$ -> 12.50 OK
199 -> 199.00 OK
1'345.95 -> 1345.95 OK
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #15 from Koha Team Lyon 3 ---
I'm testing now.
Looks goog but I haven't finished yet.
But It should be extended to this page : /cgi-bin/koha/admin/aqbudgets.pl
/cgi-bin/koha/members/mancredit.pl
and
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Baptiste changed:
What|Removed |Added
Status|Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Baptiste changed:
What|Removed |Added
Attachment #61603|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Baptiste changed:
What|Removed |Added
Attachment #61357|0
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Koha Team Lyon 3 changed:
What|Removed |Added
CC|
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Baptiste changed:
What|Removed |Added
Status|Failed QA
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #10 from Baptiste ---
Created attachment 61357
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61357=edit
BUG 12310: Modified the tooltips
Modified the tooltips
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
--- Comment #9 from Rozenn Davenel ---
With or without the "", the result is the same.
when entering amount of "12,34" it is saved as "12.40" in the system.
Don't accept formats with full stop or
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Rozenn Davenel changed:
What|Removed |Added
Status|Needs Signoff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Baptiste changed:
What|Removed |Added
Status|ASSIGNED
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12310
Baptiste changed:
What|Removed |Added
Attachment #60530|0
1 - 100 of 113 matches
Mail list logo