[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Frédéric Demians changed: What|Removed |Added CC||frede...@tamil.fr --- Comment #70 from Frédéric Demians --- It would be nice to have this functionnality with more granularity, not with a global system preference, but with a SIPconfig.xml parameter. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Tomás Cohen Arazi changed: What|Removed |Added Blocks||32529 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=32529 [Bug 32529] Holds in processing should block item deletion -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Josef Moravec changed: What|Removed |Added Blocks||27030 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27030 [Bug 27030] The new "Processing" hold status is missing in C4::Reserves module documentation -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Lucas Gass changed: What|Removed |Added CC||lu...@bywatersolutions.com --- Comment #69 from Lucas Gass --- enhancement will not be backported to 20.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Joonas Kylmälä changed: What|Removed |Added Blocks||27012 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27012 [Bug 27012] Merging records with holds causes SQL error -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Joonas Kylmälä changed: What|Removed |Added Text to go in the||This new system preference release notes||HoldsNeedProcessingSIP ||allows the libraries to ||prepare the items in peace ||for the next patron before ||a notification about a ||waiting hold is sent to the ||patron. Without this system ||preference in some cases ||the item might not have ||been ready for pick up by ||the time patron came to the ||library to checkout the ||item they had on hold. This ||feature works only with ||SIP2 return machines for ||the time being. Keywords|release-notes-needed| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Tomás Cohen Arazi changed: What|Removed |Added Blocks||25260 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=25260 [Bug 25260] Merge 'reserves' and 'old_reserves' into a new 'holds' table -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 --- Comment #68 from Jonathan Druart --- Pushed to master for 20.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||20.11.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 --- Comment #67 from Jonathan Druart --- Created attachment 111610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111610&action=edit Bug 12556: Add missig POD for ->set_processing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Jonathan Druart changed: What|Removed |Added Keywords||release-notes-needed CC||jonathan.dru...@bugs.koha-c ||ommunity.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Jonathan Druart changed: What|Removed |Added Attachment #111500|0 |1 is obsolete|| --- Comment #66 from Jonathan Druart --- Created attachment 111585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111585&action=edit Bug 12556: (QA follow-up) Fix QA Script failures Signed-off-by: Martin Renvoize JD amended patch, fix: FAIL C4/RotatingCollections.pm FAIL pod *** WARNING: line containing nothing but whitespace in paragraph in file C4/RotatingCollections.pm -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Passed QA --- Comment #65 from Martin Renvoize --- No regressions found, QA scripts are happy. Glad to see a bit of tidying up going on in here prior to working in the new functionality. Passing QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Martin Renvoize changed: What|Removed |Added Attachment #111509|0 |1 is obsolete|| --- Comment #64 from Martin Renvoize --- Created attachment 111516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111516&action=edit Bug 12556: (follow-up) Fix failing test The method call set_waiting(1) was renamed to be set_transfer() Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 --- Comment #63 from Martin Renvoize --- (In reply to Joonas Kylmälä from comment #62) > (In reply to Martin Renvoize from comment #60) > > However, sorry Joonas, but t/db_dependent/api/v1/holds.t is failing.. and > > ideally I'd love to see some basic tests for the new set_* methods > > introduced in Koha::Hold. They're trivial methods, but having a unit test > > that proves they correctly set the three fields for each of the methods will > > help prevent future regressions. > > thanks, fixed the api test. I added the same test to set_processing and > set_transfer methods by calling $hold->suspend_hold as there was originally > with the set_waiting method. That should check what the function already > does (just set the found status). Do you think it is still required to > explicitly check the found status for these (even though it indirectly is > checked by suspend_hold call)? Fair point.. they are tested indirectly so they are covered. Lets go with it as is and we can continue to follow through further cleanups at a later date :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 --- Comment #62 from Joonas Kylmälä --- (In reply to Martin Renvoize from comment #60) > However, sorry Joonas, but t/db_dependent/api/v1/holds.t is failing.. and > ideally I'd love to see some basic tests for the new set_* methods > introduced in Koha::Hold. They're trivial methods, but having a unit test > that proves they correctly set the three fields for each of the methods will > help prevent future regressions. thanks, fixed the api test. I added the same test to set_processing and set_transfer methods by calling $hold->suspend_hold as there was originally with the set_waiting method. That should check what the function already does (just set the found status). Do you think it is still required to explicitly check the found status for these (even though it indirectly is checked by suspend_hold call)? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 --- Comment #61 from Joonas Kylmälä --- Created attachment 111509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111509&action=edit Bug 12556: (follow-up) Fix failing test The method call set_waiting(1) was renamed to be set_transfer() -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #60 from Martin Renvoize --- Looks good :) However, sorry Joonas, but t/db_dependent/api/v1/holds.t is failing.. and ideally I'd love to see some basic tests for the new set_* methods introduced in Koha::Hold. They're trivial methods, but having a unit test that proves they correctly set the three fields for each of the methods will help prevent future regressions. Failing QA, but hopefully not for long. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Martin Renvoize changed: What|Removed |Added Attachment #111409|0 |1 is obsolete|| --- Comment #57 from Martin Renvoize --- Created attachment 111498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111498&action=edit Bug 12556: Simplify and correct logic in holds-table.inc template The states is_waiting and is_found are already implied by is_at_destination. Also we would never get the 'transfered' html class since transfer's status is T (this might not have been true in the past but now is). Signed-off-by: Timothy Alexis Vass Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Martin Renvoize changed: What|Removed |Added Attachment #111410|0 |1 is obsolete|| --- Comment #58 from Martin Renvoize --- Created attachment 111499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111499&action=edit Bug 12556: Add new "in processing" state to holds This adds new syspref, HoldsNeedProcessingSIP, which controls whether a hold that is related to item will be filled automatically or not. If the user has enabled the syspref then instead of fulfilling the hold automatically the hold will go to "in processing" state. To test: 1. Checkout a book to patron A 2. Place a bib level hold to the book for B 3. Patron A returns the book via SIP, to simulate this use: ./misc/sip_cli_emulator.pl -su koha -sp koha -l CPL -a 127.0.0.1 -p 6001 --item -m checkin 4. Notice that no notification is generated for Patron B about hold and that the hold status in intranet and opac is "In Processing". 5. Notice that patron A (or other patrons) cannot checkout a book that is in processing, because it is considered to be attached to the holdee (similarly to the waiting state): ./misc/sip_cli_emulator.pl -su koha -sp koha -l CPL -a 127.0.0.1 -p 6001 --patron --item -m checkout Signed-off-by: Timothy Alexis Vass Rebased-by: Joonas Kylmälä Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 --- Comment #59 from Martin Renvoize --- Created attachment 111500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111500&action=edit Bug 12556: (QA follow-up) Fix QA Script failures Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Martin Renvoize changed: What|Removed |Added Attachment #111408|0 |1 is obsolete|| --- Comment #56 from Martin Renvoize --- Created attachment 111497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111497&action=edit Bug 12556: reserves/request.pl: Reuse code from Koha::Hold Signed-off-by: Timothy Alexis Vass Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Martin Renvoize changed: What|Removed |Added Attachment #111407|0 |1 is obsolete|| --- Comment #55 from Martin Renvoize --- Created attachment 111496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111496&action=edit Bug 12556: Reuse code from Koha::Hold instead of duplicating it Signed-off-by: Timothy Alexis Vass Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Martin Renvoize changed: What|Removed |Added Attachment #111405|0 |1 is obsolete|| --- Comment #53 from Martin Renvoize --- Created attachment 111494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111494&action=edit Bug 12556: Refactor hold transfer status setting to its own method Signed-off-by: Timothy Alexis Vass Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Martin Renvoize changed: What|Removed |Added Attachment #111406|0 |1 is obsolete|| --- Comment #54 from Martin Renvoize --- Created attachment 111495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111495&action=edit Bug 12556: Remove unused HTML Koha::Hold::is_at_destination() already checks for found = 'W' so the ELSE code path which would print "Item waiting to be pulled from [...]" never gets executed. Signed-off-by: Timothy Alexis Vass Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 --- Comment #52 from Joonas Kylmälä --- Created attachment 111410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111410&action=edit Bug 12556: Add new "in processing" state to holds This adds new syspref, HoldsNeedProcessingSIP, which controls whether a hold that is related to item will be filled automatically or not. If the user has enabled the syspref then instead of fulfilling the hold automatically the hold will go to "in processing" state. To test: 1. Checkout a book to patron A 2. Place a bib level hold to the book for B 3. Patron A returns the book via SIP, to simulate this use: ./misc/sip_cli_emulator.pl -su koha -sp koha -l CPL -a 127.0.0.1 -p 6001 --item -m checkin 4. Notice that no notification is generated for Patron B about hold and that the hold status in intranet and opac is "In Processing". 5. Notice that patron A (or other patrons) cannot checkout a book that is in processing, because it is considered to be attached to the holdee (similarly to the waiting state): ./misc/sip_cli_emulator.pl -su koha -sp koha -l CPL -a 127.0.0.1 -p 6001 --patron --item -m checkout Signed-off-by: Timothy Alexis Vass Rebased-by: Joonas Kylmälä -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 --- Comment #51 from Joonas Kylmälä --- Created attachment 111409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111409&action=edit Bug 12556: Simplify and correct logic in holds-table.inc template The states is_waiting and is_found are already implied by is_at_destination. Also we would never get the 'transfered' html class since transfer's status is T (this might not have been true in the past but now is). Signed-off-by: Timothy Alexis Vass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 --- Comment #49 from Joonas Kylmälä --- Created attachment 111407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111407&action=edit Bug 12556: Reuse code from Koha::Hold instead of duplicating it Signed-off-by: Timothy Alexis Vass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Joonas Kylmälä changed: What|Removed |Added Attachment #110961|0 |1 is obsolete|| Attachment #110962|0 |1 is obsolete|| Attachment #110963|0 |1 is obsolete|| Attachment #110964|0 |1 is obsolete|| Attachment #110965|0 |1 is obsolete|| Attachment #110966|0 |1 is obsolete|| --- Comment #47 from Joonas Kylmälä --- Created attachment 111405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111405&action=edit Bug 12556: Refactor hold transfer status setting to its own method Signed-off-by: Timothy Alexis Vass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 --- Comment #48 from Joonas Kylmälä --- Created attachment 111406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111406&action=edit Bug 12556: Remove unused HTML Koha::Hold::is_at_destination() already checks for found = 'W' so the ELSE code path which would print "Item waiting to be pulled from [...]" never gets executed. Signed-off-by: Timothy Alexis Vass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Joonas Kylmälä changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 --- Comment #50 from Joonas Kylmälä --- Created attachment 111408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=111408&action=edit Bug 12556: reserves/request.pl: Reuse code from Koha::Hold Signed-off-by: Timothy Alexis Vass -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #46 from Martin Renvoize --- Sorry Joonas, this one now has some conflicts.. code looks good.. if you rebase it I'll QA it asap. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com Assignee|koha-b...@lists.koha-commun |joonas.kylm...@helsinki.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Timothy Alexis Vass changed: What|Removed |Added Attachment #110719|0 |1 is obsolete|| --- Comment #45 from Timothy Alexis Vass --- Created attachment 110966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110966&action=edit Bug 12556: Add new "in processing" state to holds This adds new syspref, HoldsNeedProcessingSIP, which controls whether a hold that is related to item will be filled automatically or not. If the user has enabled the syspref then instead of fulfilling the hold automatically the hold will go to "in processing" state. To test: 1. Checkout a book to patron A 2. Place a bib level hold to the book for B 3. Patron A returns the book via SIP, to simulate this use: ./misc/sip_cli_emulator.pl -su koha -sp koha -l CPL -a 127.0.0.1 -p 6001 --item -m checkin 4. Notice that no notification is generated for Patron B about hold and that the hold status in intranet and opac is "In Processing". 5. Notice that patron A (or other patrons) cannot checkout a book that is in processing, because it is considered to be attached to the holdee (similarly to the waiting state): ./misc/sip_cli_emulator.pl -su koha -sp koha -l CPL -a 127.0.0.1 -p 6001 --patron --item -m checkout Signed-off-by: Timothy Alexis Vass -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Timothy Alexis Vass changed: What|Removed |Added Attachment #109926|0 |1 is obsolete|| --- Comment #42 from Timothy Alexis Vass --- Created attachment 110963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110963&action=edit Bug 12556: Reuse code from Koha::Hold instead of duplicating it Signed-off-by: Timothy Alexis Vass -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Timothy Alexis Vass changed: What|Removed |Added Attachment #109928|0 |1 is obsolete|| --- Comment #44 from Timothy Alexis Vass --- Created attachment 110965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110965&action=edit Bug 12556: Simplify and correct logic in holds-table.inc template The states is_waiting and is_found are already implied by is_at_destination. Also we would never get the 'transfered' html class since transfer's status is T (this might not have been true in the past but now is). Signed-off-by: Timothy Alexis Vass -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Timothy Alexis Vass changed: What|Removed |Added Attachment #109927|0 |1 is obsolete|| --- Comment #43 from Timothy Alexis Vass --- Created attachment 110964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110964&action=edit Bug 12556: reserves/request.pl: Reuse code from Koha::Hold Signed-off-by: Timothy Alexis Vass -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Timothy Alexis Vass changed: What|Removed |Added Attachment #109924|0 |1 is obsolete|| --- Comment #40 from Timothy Alexis Vass --- Created attachment 110961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110961&action=edit Bug 12556: Refactor hold transfer status setting to its own method Signed-off-by: Timothy Alexis Vass -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Timothy Alexis Vass changed: What|Removed |Added Attachment #109925|0 |1 is obsolete|| --- Comment #41 from Timothy Alexis Vass --- Created attachment 110962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110962&action=edit Bug 12556: Remove unused HTML Koha::Hold::is_at_destination() already checks for found = 'W' so the ELSE code path which would print "Item waiting to be pulled from [...]" never gets executed. Signed-off-by: Timothy Alexis Vass -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Joonas Kylmälä changed: What|Removed |Added Attachment #110719|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Joonas Kylmälä changed: What|Removed |Added Attachment #109928|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Joonas Kylmälä changed: What|Removed |Added Attachment #109925|1 |0 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Joonas Kylmälä changed: What|Removed |Added Attachment #109927|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Joonas Kylmälä changed: What|Removed |Added Attachment #109924|1 |0 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Joonas Kylmälä changed: What|Removed |Added Attachment #109926|1 |0 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Joonas Kylmälä changed: What|Removed |Added Attachment #110954|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Joonas Kylmälä changed: What|Removed |Added Attachment #110956|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Joonas Kylmälä changed: What|Removed |Added Attachment #110953|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Joonas Kylmälä changed: What|Removed |Added Attachment #110955|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Joonas Kylmälä changed: What|Removed |Added Attachment #110952|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Joonas Kylmälä changed: What|Removed |Added Attachment #110951|0 |1 is obsolete|| -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Timothy Alexis Vass changed: What|Removed |Added Attachment #110950|0 |1 is obsolete|| --- Comment #39 from Timothy Alexis Vass --- Created attachment 110956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110956&action=edit Bug 12556: Remove unused HTML Koha::Hold::is_at_destination() already checks for found = 'W' so the ELSE code path which would print "Item waiting to be pulled from [...]" never gets executed. Signed-off-by: John Doe -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Timothy Alexis Vass changed: What|Removed |Added Attachment #110949|0 |1 is obsolete|| --- Comment #38 from Timothy Alexis Vass --- Created attachment 110955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110955&action=edit Bug 12556: Refactor hold transfer status setting to its own method Signed-off-by: John Doe -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Timothy Alexis Vass changed: What|Removed |Added Attachment #110946|0 |1 is obsolete|| --- Comment #35 from Timothy Alexis Vass --- Created attachment 110952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110952&action=edit Bug 12556: reserves/request.pl: Reuse code from Koha::Hold Signed-off-by: John Doe -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Timothy Alexis Vass changed: What|Removed |Added Attachment #110945|0 |1 is obsolete|| --- Comment #34 from Timothy Alexis Vass --- Created attachment 110951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110951&action=edit Bug 12556: Reuse code from Koha::Hold instead of duplicating it Signed-off-by: John Doe -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Timothy Alexis Vass changed: What|Removed |Added Attachment #110948|0 |1 is obsolete|| --- Comment #37 from Timothy Alexis Vass --- Created attachment 110954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110954&action=edit Bug 12556: Add new "in processing" state to holds This adds new syspref, HoldsNeedProcessingSIP, which controls whether a hold that is related to item will be filled automatically or not. If the user has enabled the syspref then instead of fulfilling the hold automatically the hold will go to "in processing" state. To test: 1. Checkout a book to patron A 2. Place a bib level hold to the book for B 3. Patron A returns the book via SIP, to simulate this use: ./misc/sip_cli_emulator.pl -su koha -sp koha -l CPL -a 127.0.0.1 -p 6001 --item -m checkin 4. Notice that no notification is generated for Patron B about hold and that the hold status in intranet and opac is "In Processing". 5. Notice that patron A (or other patrons) cannot checkout a book that is in processing, because it is considered to be attached to the holdee (similarly to the waiting state): ./misc/sip_cli_emulator.pl -su koha -sp koha -l CPL -a 127.0.0.1 -p 6001 --patron --item -m checkout Signed-off-by: John Doe -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Timothy Alexis Vass changed: What|Removed |Added Attachment #110944|0 |1 is obsolete|| --- Comment #33 from Timothy Alexis Vass --- Created attachment 110950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110950&action=edit Bug 12556: Remove unused HTML Koha::Hold::is_at_destination() already checks for found = 'W' so the ELSE code path which would print "Item waiting to be pulled from [...]" never gets executed. Signed-off-by: John Doe -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Timothy Alexis Vass changed: What|Removed |Added Attachment #110947|0 |1 is obsolete|| --- Comment #36 from Timothy Alexis Vass --- Created attachment 110953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110953&action=edit Bug 12556: Simplify and correct logic in holds-table.inc template The states is_waiting and is_found are already implied by is_at_destination. Also we would never get the 'transfered' html class since transfer's status is T (this might not have been true in the past but now is). Signed-off-by: John Doe -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Timothy Alexis Vass changed: What|Removed |Added Attachment #110943|0 |1 is obsolete|| --- Comment #32 from Timothy Alexis Vass --- Created attachment 110949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110949&action=edit Bug 12556: Refactor hold transfer status setting to its own method Signed-off-by: Timothy Alexis Vass -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Timothy Alexis Vass changed: What|Removed |Added Attachment #110719|0 |1 is obsolete|| --- Comment #31 from Timothy Alexis Vass --- Created attachment 110948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110948&action=edit Bug 12556: Add new "in processing" state to holds This adds new syspref, HoldsNeedProcessingSIP, which controls whether a hold that is related to item will be filled automatically or not. If the user has enabled the syspref then instead of fulfilling the hold automatically the hold will go to "in processing" state. To test: 1. Checkout a book to patron A 2. Place a bib level hold to the book for B 3. Patron A returns the book via SIP, to simulate this use: ./misc/sip_cli_emulator.pl -su koha -sp koha -l CPL -a 127.0.0.1 -p 6001 --item -m checkin 4. Notice that no notification is generated for Patron B about hold and that the hold status in intranet and opac is "In Processing". 5. Notice that patron A (or other patrons) cannot checkout a book that is in processing, because it is considered to be attached to the holdee (similarly to the waiting state): ./misc/sip_cli_emulator.pl -su koha -sp koha -l CPL -a 127.0.0.1 -p 6001 --patron --item -m checkout Signed-off-by: John Doe -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Timothy Alexis Vass changed: What|Removed |Added Attachment #109927|0 |1 is obsolete|| --- Comment #29 from Timothy Alexis Vass --- Created attachment 110946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110946&action=edit Bug 12556: reserves/request.pl: Reuse code from Koha::Hold Signed-off-by: John Doe -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Timothy Alexis Vass changed: What|Removed |Added Attachment #109928|0 |1 is obsolete|| --- Comment #30 from Timothy Alexis Vass --- Created attachment 110947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110947&action=edit Bug 12556: Simplify and correct logic in holds-table.inc template The states is_waiting and is_found are already implied by is_at_destination. Also we would never get the 'transfered' html class since transfer's status is T (this might not have been true in the past but now is). Signed-off-by: John Doe -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Timothy Alexis Vass changed: What|Removed |Added Attachment #110942|0 |1 is obsolete|| --- Comment #26 from Timothy Alexis Vass --- Created attachment 110943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110943&action=edit Bug 12556: Refactor hold transfer status setting to its own method Signed-off-by: Timothy Alexis Vass -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Timothy Alexis Vass changed: What|Removed |Added Attachment #109926|0 |1 is obsolete|| --- Comment #28 from Timothy Alexis Vass --- Created attachment 110945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110945&action=edit Bug 12556: Reuse code from Koha::Hold instead of duplicating it Signed-off-by: John Doe -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Timothy Alexis Vass changed: What|Removed |Added Attachment #109925|0 |1 is obsolete|| --- Comment #27 from Timothy Alexis Vass --- Created attachment 110944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110944&action=edit Bug 12556: Remove unused HTML Koha::Hold::is_at_destination() already checks for found = 'W' so the ELSE code path which would print "Item waiting to be pulled from [...]" never gets executed. Signed-off-by: John Doe -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Timothy Alexis Vass changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Timothy Alexis Vass changed: What|Removed |Added Attachment #109924|0 |1 is obsolete|| --- Comment #25 from Timothy Alexis Vass --- Created attachment 110942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110942&action=edit Bug 12556: Refactor hold transfer status setting to its own method Signed-off-by: Timothy Alexis Vass -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Joonas Kylmälä changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 --- Comment #24 from Joonas Kylmälä --- Timothy, strange, I'm not able to reproduce the issue by going to that page. Can you do koha-plack --restart and see if the issue goes away? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Joonas Kylmälä changed: What|Removed |Added Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556
Timothy Alexis Vass changed:
What|Removed |Added
CC||timothy_alexis.v...@ub.lu.s
||e
--- Comment #23 from Timothy Alexis Vass ---
Steps 1, 2 and 3 worked fine:
./misc/sip_cli_emulator.pl -su koha -sp koha -l CPL -a 127.0.0.1 -p 6001 --item
30001 -m checkin
Attempting socket connection to 127.0.0.1:6001...connected!
SEND: 9300CNkoha|COkoha|CPCPL|
READ: 941
Trying 'checkin'
SEND: 09N2020092511172320200925
111723APCPL|AOCPL|AB30001|ACkoha|BIN|
READ: 101YNY20200925111725AOCPL|AB30001|AQCPL|AJE Street shuffle
:|CY23529000120056|CTCPL|DAJohnny Bryan ((212) 555-1212)|CV01|
Then, when reloading the page
'cgi-bin/koha/reserve/request.pl?biblionumbers=1/' There is an error beginning
with:
The method Koha::Hold->is_in_processing is not covered by tests!
Trace begun at /kohadevbox/koha/Koha/Object.pm line 780
Koha::Object::AUTOLOAD('Koha::Hold=HASH(0x55d06d6dbac0)') called at
/kohadevbox/koha/reserve/request.pl line 668
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 --- Comment #22 from Joonas Kylmälä --- Rebased. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Joonas Kylmälä changed: What|Removed |Added Attachment #109929|0 |1 is obsolete|| --- Comment #21 from Joonas Kylmälä --- Created attachment 110719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110719&action=edit Bug 12556: Add new "in processing" state to holds This adds new syspref, HoldsNeedProcessingSIP, which controls whether a hold that is related to item will be filled automatically or not. If the user has enabled the syspref then instead of fulfilling the hold automatically the hold will go to "in processing" state. To test: 1. Checkout a book to patron A 2. Place a bib level hold to the book for B 3. Patron A returns the book via SIP, to simulate this use: ./misc/sip_cli_emulator.pl -su koha -sp koha -l CPL -a 127.0.0.1 -p 6001 --item -m checkin 4. Notice that no notification is generated for Patron B about hold and that the hold status in intranet and opac is "In Processing". 5. Notice that patron A (or other patrons) cannot checkout a book that is in processing, because it is considered to be attached to the holdee (similarly to the waiting state): ./misc/sip_cli_emulator.pl -su koha -sp koha -l CPL -a 127.0.0.1 -p 6001 --patron --item -m checkout -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 --- Comment #20 from Joonas Kylmälä --- Rebased and fixed the issue with another patron being able to checkout in processing hold via SIP machine. Ready for sign-off again. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 --- Comment #17 from Joonas Kylmälä --- Created attachment 109927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109927&action=edit Bug 12556: reserves/request.pl: Reuse code from Koha::Hold -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 --- Comment #18 from Joonas Kylmälä --- Created attachment 109928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109928&action=edit Bug 12556: Simplify and correct logic in holds-table.inc template The states is_waiting and is_found are already implied by is_at_destination. Also we would never get the 'transfered' html class since transfer's status is T (this might not have been true in the past but now is). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 --- Comment #16 from Joonas Kylmälä --- Created attachment 109926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109926&action=edit Bug 12556: Reuse code from Koha::Hold instead of duplicating it -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 --- Comment #19 from Joonas Kylmälä --- Created attachment 109929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109929&action=edit Bug 12556: Add new "in processing" state to holds This adds new syspref, HoldsNeedProcessingSIP, which controls whether a hold that is related to item will be filled automatically or not. If the user has enabled the syspref then instead of fulfilling the hold automatically the hold will go to "in processing" state. To test: 1. Checkout a book to patron A 2. Place a bib level hold to the book for B 3. Patron A returns the book via SIP, to simulate this use: ./misc/sip_cli_emulator.pl -su koha -sp koha -l CPL -a 127.0.0.1 -p 6001 --item -m checkin 4. Notice that no notification is generated for Patron B about hold and that the hold status in intranet and opac is "In Processing". 5. Notice that patron A (or other patrons) cannot checkout a book that is in processing, because it is considered to be attached to the holdee (similarly to the waiting state): ./misc/sip_cli_emulator.pl -su koha -sp koha -l CPL -a 127.0.0.1 -p 6001 --patron --item -m checkout -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Joonas Kylmälä changed: What|Removed |Added Attachment #107181|0 |1 is obsolete|| Attachment #107182|0 |1 is obsolete|| Attachment #107183|0 |1 is obsolete|| Attachment #107184|0 |1 is obsolete|| Attachment #107185|0 |1 is obsolete|| Attachment #109140|0 |1 is obsolete|| --- Comment #14 from Joonas Kylmälä --- Created attachment 109924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109924&action=edit Bug 12556: Refactor hold transfer status setting to its own method -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 --- Comment #15 from Joonas Kylmälä --- Created attachment 109925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109925&action=edit Bug 12556: Remove unused HTML Koha::Hold::is_at_destination() already checks for found = 'W' so the ELSE code path which would print "Item waiting to be pulled from [...]" never gets executed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Joonas Kylmälä changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Joonas Kylmälä changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #13 from Joonas Kylmälä --- One of our customers was testing the proposed patches and found out that if the setting AllowItemsOnHoldCheckoutSIP is enabled then In processing state holds can be checked out. They shouldn't be able to be since the item for the patron's hold is already attached for the patron in the same way it is with Waiting state. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Joonas Kylmälä changed: What|Removed |Added Attachment #108711|0 |1 is obsolete|| --- Comment #12 from Joonas Kylmälä --- Created attachment 109140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109140&action=edit Bug 12556: Add new "in processing" state to holds This adds new syspref, HoldsNeedProcessingSIP, which controls whether a hold that is related to item will be filled automatically or not. If the user has enabled the syspref then instead of fulfilling the hold automatically the hold will go to "in processing" state. To test: 1. Checkout a book to patron A 2. Place a bib level hold to the book for B 3. Patron A returns the book via SIP, to simulate this use: ./misc/sip_cli_emulator.pl -su koha -sp koha -l CPL -a 127.0.0.1 -p 6001 --item -m checkin 4. Notice that no notification is generated for Patron B about hold and that the hold status in intranet and opac is "In Processing". 5. Notice that patron A (or other patrons) cannot checkout a book that is in processing, because it is considered to be attached to the holdee (similarly to the waiting state): ./misc/sip_cli_emulator.pl -su koha -sp koha -l CPL -a 127.0.0.1 -p 6001 --patron --item -m checkout -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Joonas Kylmälä changed: What|Removed |Added Attachment #107186|0 |1 is obsolete|| --- Comment #11 from Joonas Kylmälä --- Created attachment 108711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=108711&action=edit Bug 12556: Add new "in processing" state to holds This adds new syspref, HoldsNeedProcessingSIP, which controls whether a hold that is related to item will be filled automatically or not. If the user has enabled the syspref then instead of fulfilling the hold automatically the hold will go to "in processing" state. To test: 1. Checkout a book to patron A 2. Place a bib level hold to the book for B 3. Patron A returns the book via SIP, to simulate this use: ./misc/sip_cli_emulator.pl -su koha -sp koha -l CPL -a 127.0.0.1 -p 6001 --item -m checkin 4. Notice that no notification is generated for Patron B about hold and that the hold status in intranet and opac is "In Processing". 5. Notice that patron A (or other patrons) cannot checkout a book that is in processing, because it is considered to be attached to the holdee (similarly to the waiting state): ./misc/sip_cli_emulator.pl -su koha -sp koha -l CPL -a 127.0.0.1 -p 6001 --patron --item -m checkout -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Joonas Kylmälä changed: What|Removed |Added CC||joonas.kylm...@helsinki.fi Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 --- Comment #10 from Joonas Kylmälä --- Created attachment 107186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107186&action=edit Bug 12556: Add new "in processing" state to holds This adds new syspref, HoldsNeedProcessingSIP, which controls whether a hold that is related to item will be filled automatically or not. If the user has enabled the syspref then instead of fulfilling the hold automatically the hold will go to "in processing" state. To test: 1. Checkout a book to patron A 2. Place a bib level hold to the book for B 3. Patron A returns the book via SIP, to simulate this use: ./misc/sip_cli_emulator.pl -su koha -sp koha -l CPL -a 127.0.0.1 -p 6001 --item -m checkin 4. Notice that no notification is generated for Patron B about hold and that the hold status in intranet and opac is "In Processing". 5. Notice that patron A (or other patrons) cannot checkout a book that is in processing, because it is considered to be attached to the holdee (similarly to the waiting state): ./misc/sip_cli_emulator.pl -su koha -sp koha -l CPL -a 127.0.0.1 -p 6001 --patron --item -m checkout -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 --- Comment #8 from Joonas Kylmälä --- Created attachment 107184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107184&action=edit Bug 12556: reserves/request.pl: Reuse code from Koha::Hold -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 --- Comment #9 from Joonas Kylmälä --- Created attachment 107185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107185&action=edit Bug 12556: Simplify and correct logic in holds-table.inc template The states is_waiting and is_found are already implied by is_at_destination. Also we would never get the 'transfered' html class since transfer's status is T (this might not have been true in the past but now is). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 --- Comment #7 from Joonas Kylmälä --- Created attachment 107183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107183&action=edit Bug 12556: Reuse code from Koha::Hold instead of duplicating it -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 --- Comment #6 from Joonas Kylmälä --- Created attachment 107182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107182&action=edit Bug 12556: Remove unused HTML Koha::Hold::is_at_destination() already checks for found = 'W' so the ELSE code path which would print "Item waiting to be pulled from [...]" never gets executed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 --- Comment #5 from Joonas Kylmälä --- Created attachment 107181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=107181&action=edit Bug 12556: Refactor hold transfer status setting to its own method -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 BASE Library Consortium changed: What|Removed |Added CC||baselibrary.consortium@nhs. ||net -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 jdem...@roseville.ca.us changed: What|Removed |Added CC||jdem...@roseville.ca.us -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 --- Comment #4 from Olli-Antti Kivilahti --- (In reply to Benjamin Rokseth from comment #2) > I notice this bug is rather old, but we actually suffered badly from this, > as we have several fully automated branches that are open 24/7 without staff. > They get better with age, like good wine and other stuff. Sorry to hear about your misery. We can completely relate to that :) > Our solution, by any mean not ideal, was to have separated branches for > automated selfcheck machines, a SIP translation proxy that fixes the items > that are NOT reserved so they can be put directly on the shelf, and finally > a cronjob to clean up the branchtransfer mess. > Our self-service libraries are separate branches and strangely I haven't heard of this problem manifesting yet for us, but I know sooner or later someone will notice. > We (Oslo Public Library) would gladly cooperate on this if any good ideas > turn up! You could attach the opening hours of the pickup library in the hold notification? Maybe this would help? Tinker a bit with the Letters-module. The C4::Letters::GetPreparedLetter() is very very hairy tho. Also you would need to add the library opening hours somewhere. Easiest thing to do is to make a YAML-config syspref with those opening hours per branch. Super fast GUI-replacement and will get this problem solved in no time. No need for DB or GUI code. >Instead of an email being sent immediately at that point to the patron next in >line for the request, the item would have a new circulation status e.g. ‘In >SelfService’ this removes the item from the patron’s record but does not >trigger the next hold until it is checked-in by a member of the library, at >which point the item moves onto the next circulation status that it would have >had before going into ‘In SelfService’ (e.g. ‘On hold’ or ‘in transit’ etc.) >However if the limbo-available-state between check-in can be fixed, (this >might be more trouble than it's worth) I guess this would make sense. Maybe this idea is a good solution? Put all SIP2-server checkouts to a Limbo-state Skip catching holds and transfers when put to a 'Limbo'-status? But relinguish ties to the previous borrower. Show in OPAC/Intra the status as Limbo, this is more brittle to program. Shouldn't be too difficult to test and program in. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #3 from Katrin Fischer --- I think the nicest thing to do might be a separate status or a flag? We always get asked how to identify books on hold that have been returned, so they can be pulled off the cart. Or even that an email is sent to the circulation desk so they can go and pick it up from the return station. Currently you can't really make that happen and it would be nice if we could. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Benjamin Rokseth changed: What|Removed |Added CC||benjamin.roks...@kul.oslo.k ||ommune.no --- Comment #2 from Benjamin Rokseth --- I notice this bug is rather old, but we actually suffered badly from this, as we have several fully automated branches that are open 24/7 without staff. Self service machines with reservation boxes often resulted in things checked in and patrons then turning up to collect their long-awaited material which is locked up in reservation boxes until next day. Our solution, by any mean not ideal, was to have separated branches for automated selfcheck machines, a SIP translation proxy that fixes the items that are NOT reserved so they can be put directly on the shelf, and finally a cronjob to clean up the branchtransfer mess. We (Oslo Public Library) would gladly cooperate on this if any good ideas turn up! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 sally.hea...@cheshirewestandchester.gov.uk changed: What|Removed |Added CC||sally.healey@cheshirewestan ||dchester.gov.uk -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 12556] SelfCheck machine starts the hold instantly with an email sent out
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12556 Olli-Antti Kivilahti changed: What|Removed |Added CC||olli-antti.kivila...@jns.fi --- Comment #1 from Olli-Antti Kivilahti --- Hi! We experimented by disabling the hold catching when checking in Items with the SIP Server. This was because our borrowers would get the Reservation notice and come looking for the Item while the Item was still being processed. Then we started to get issues with Items (that had reservations) being in Available-state between getting checked in with the SIP server and waiting for the librarian to check them in using Koha. We reverted back to the way things are, because we get less issues this way. Our librarians know where to look for the reserved Item if on the rare occasion a borrower is fast enough to intercept the hold before we place it to the self pickup shelf. However if the limbo-available-state between check-in can be fixed, (this might be more trouble than it's worth) I guess this would make sense. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
