[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

--- Comment #109 from Martin Renvoize  ---
Enhancement, will not be backported to 18.05.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #108 from Nick Clemens  ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

--- Comment #106 from Katrin Fischer  ---
Created attachment 79350
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79350=edit
Bug 12747: (QA follow-up) Treat 010 according to marcflavour

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

--- Comment #107 from Katrin Fischer  ---
Created attachment 79351
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79351=edit
Bug 12747: (QA follow-up) Rephrase system preference description

Just a suggestion for a little change to the pref description.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #78687|0   |1
is obsolete||
  Attachment #78688|0   |1
is obsolete||

--- Comment #105 from Katrin Fischer  ---
Created attachment 79349
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79349=edit
Bug 12747: Add extra column in Z3950 search

This patch makes it possible to add an extra column to Z3950 search results.
The system preference AdditionalFieldsInZ3950ResultSearch decides which MARC
field/subfields are displayed in the column.

Testing:

I Apply the patch
II Run updatedatabase.pl

ACQUISITIONS
0) Enter a field/subfield in the AdditionalFieldsInZ3950ResultSearch
1) Create a new basket or use an existing one
2) In -Add order to basket-, click "From an external source"
3) Select some search targets and enter a subject heading ex. house
4) Click Search bouton
5) Validate "Additional fields" column with the field/subfield value.

CATALOGUING
0) Shares same syspref as above
1) Go to cataloguing, click New from z3950
2) Fill to result in a successful search
3) Validate column Addition Fields

prove t/db_dependent/Breeding.t

Sponsored-by: CCSR (https://ccsr.qc.ca)

Signed-off-by: Katrin Fischer 

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA
   Patch complexity|Small patch |Medium patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

--- Comment #104 from sandbo...@biblibre.com  ---
Created attachment 78688
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78688=edit
Bug 12747: (QA follow-up) Treat 010 according to marcflavour

Signed-off-by: Séverine QUEUNE 
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

--- Comment #103 from sandbo...@biblibre.com  ---
Created attachment 78687
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78687=edit
Bug 12747: Add extra column in Z3950 search

This patch makes it possible to add an extra column to Z3950 search results.
The system preference AdditionalFieldsInZ3950ResultSearch decides which MARC
field/subfields are displayed in the column.

Testing:

I Apply the patch
II Run updatedatabase.pl

ACQUISITIONS
0) Enter a field/subfield in the AdditionalFieldsInZ3950ResultSearch
1) Create a new basket or use an existing one
2) In -Add order to basket-, click "From an external source"
3) Select some search targets and enter a subject heading ex. house
4) Click Search bouton
5) Validate "Additional fields" column with the field/subfield value.

CATALOGUING
0) Shares same syspref as above
1) Go to cataloguing, click New from z3950
2) Fill to result in a successful search
3) Validate column Addition Fields

prove t/db_dependent/Breeding.t

Sponsored-by: CCSR (https://ccsr.qc.ca)

Signed-off-by: Katrin Fischer 

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #78272|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

sandbo...@biblibre.com  changed:

   What|Removed |Added

  Attachment #78271|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

sandbo...@biblibre.com  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off
 CC||sandbo...@biblibre.com

--- Comment #102 from sandbo...@biblibre.com  ---
Patch tested with a sandbox, by Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Eric Bégin  changed:

   What|Removed |Added

 CC|david.bourga...@inlibro.com |
   |, maksim@inlibro.com,   |
   |philippe.audet-fortin@inlib |
   |ro.com, |
   |remi.mayrand-provencher@inL |
   |ibro.com,   |
   |roch.dam...@inlibro.com |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

--- Comment #101 from Charles Farmer  ---
>From the information I could gather on IFLA.org, you're completely right, the
010 field of UNIMARC is indeed used for ISBN and has subfields.

I rebased the first patch on the current master, and added a QA follow-up one
to deal with the 010 issue, but I did not consider the case for NORMARC in part
because of Bug 18984. If this is a problem, I'll add another patch for it.

Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

--- Comment #100 from Charles Farmer  ---
Created attachment 78272
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78272=edit
Bug 12747: (QA follow-up) Treat 010 according to marcflavour

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Charles Farmer  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Charles Farmer  changed:

   What|Removed |Added

  Attachment #77729|0   |1
is obsolete||

--- Comment #98 from Charles Farmer  ---
Created attachment 78270
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78270=edit
Bug 12747: Add extra column in Z3950 search

This patch makes it possible to add an extra column to Z3950 search results.
The system preference AdditionalFieldsInZ3950ResultSearch decides which MARC
field/subfields are displayed in the column.

Testing:

I Apply the patch
II Run updatedatabase.pl

ACQUISITIONS
0) Enter a field/subfield in the AdditionalFieldsInZ3950ResultSearch
1) Create a new basket or use an existing one
2) In -Add order to basket-, click "From an external source"
3) Select some search targets and enter a subject heading ex. house
4) Click Search bouton
5) Validate "Additional fields" column with the field/subfield value.

CATALOGUING
0) Shares same syspref as above
1) Go to cataloguing, click New from z3950
2) Fill to result in a successful search
3) Validate column Addition Fields

prove t/db_dependent/Breeding.t

Sponsored-by: CCSR (https://ccsr.qc.ca)

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Charles Farmer  changed:

   What|Removed |Added

  Attachment #78270|0   |1
is obsolete||

--- Comment #99 from Charles Farmer  ---
Created attachment 78271
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78271=edit
Bug 12747: Add extra column in Z3950 search

This patch makes it possible to add an extra column to Z3950 search results.
The system preference AdditionalFieldsInZ3950ResultSearch decides which MARC
field/subfields are displayed in the column.

Testing:

I Apply the patch
II Run updatedatabase.pl

ACQUISITIONS
0) Enter a field/subfield in the AdditionalFieldsInZ3950ResultSearch
1) Create a new basket or use an existing one
2) In -Add order to basket-, click "From an external source"
3) Select some search targets and enter a subject heading ex. house
4) Click Search bouton
5) Validate "Additional fields" column with the field/subfield value.

CATALOGUING
0) Shares same syspref as above
1) Go to cataloguing, click New from z3950
2) Fill to result in a successful search
3) Validate column Addition Fields

prove t/db_dependent/Breeding.t

Sponsored-by: CCSR (https://ccsr.qc.ca)

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|katrin.fisc...@bsz-bw.de|

--- Comment #97 from Katrin Fischer  ---
Note: signed off this one, so won't be able to QA - unless someone else gives
it another sign-off then.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #96 from Katrin Fischer  ---
Can you please take a look at comment#94? Sorry for leaving this unfinished,
will try to return asap when fixed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #75096|0   |1
is obsolete||

--- Comment #95 from Katrin Fischer  ---
Created attachment 77729
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77729=edit
Bug 12747: Add extra column in Z3950 search

This patch makes it possible to add an extra column to Z3950 search results.
The system preference AdditionalFieldsInZ3950ResultSearch decides which MARC
field/subfields are displayed in the column.

Testing:

I Apply the patch
II Run updatedatabase.pl

ACQUISITIONS
0) Enter a field/subfield in the AdditionalFieldsInZ3950ResultSearch
1) Create a new basket or use an existing one
2) In -Add order to basket-, click "From an external source"
3) Select some search targets and enter a subject heading ex. house
4) Click Search bouton
5) Validate "Additional fields" column with the field/subfield value.

CATALOGUING
0) Shares same syspref as above
1) Go to cataloguing, click New from z3950
2) Fill to result in a successful search
3) Validate column Addition Fields

prove t/db_dependent/Breeding.t

Sponsored-by: CCSR (https://ccsr.qc.ca)

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

--- Comment #94 from Katrin Fischer  ---
Comment on attachment 75096
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75096
Bug 12747: Add extra column in Z3950 search

Review of attachment 75096:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=12747=75096)
-

::: C4/Breeding.pm
@@ +371,5 @@
> +if ( not $str eq '') {
> +push @content, $str;
> +}
> +} elsif ( $tag <= 10 ) {
> +push @content, $marcfield->data();

If I looked it up correctly 010 in UNIMARC is ISBN and has subfields. Can you
please double check?
https://archive.ifla.org/VI/8/unimarc-concise-bibliographic-format-2008.pdf

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=19436

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Charles Farmer  changed:

   What|Removed |Added

   Assignee|david.bourga...@inlibro.com |charles.far...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

--- Comment #93 from David Bourgault  ---
I've resquashed the patch to keep it clean.

New changes:
* Support repeatable tags
Repeated tags will repeat the field name, e.g.:
" 035$a:
   some value
  035$a:
   another value "

* Delimiter switched to comma from whitespace (whitespace is ignored).
I did this to make it uniform with the sysprefs 'z3950NormalizeAuthor' and
'z3950AuthorAuthFields'.

* Reworded syspref description slightly, added '001' to example
" Display the MARC field/subfields <> in the 'Additional fields' column in the
result of a search Z3950 (use comma as delimiter e.g.: "001, 082$ab, 090$ab") "

* No longer shows tags missing the target subfield

* Added a test for repeatable tags and syspref splitting to
t/db_dependent/Breeding.t


Adding multiple additional tags will result in the result table being very big
(lots of whitespace). I tried using a  to make it more compact, but it
became too hard to read (cluttered).
I left it with  for now.

QA Tool green.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

David Bourgault  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

David Bourgault  changed:

   What|Removed |Added

  Attachment #74783|0   |1
is obsolete||
  Attachment #74784|0   |1
is obsolete||
  Attachment #74785|0   |1
is obsolete||
  Attachment #74786|0   |1
is obsolete||
  Attachment #74787|0   |1
is obsolete||

--- Comment #92 from David Bourgault  ---
Created attachment 75096
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75096=edit
Bug 12747: Add extra column in Z3950 search

This patch makes it possible to add an extra column to Z3950 search results.
The system preference AdditionalFieldsInZ3950ResultSearch decides which MARC
field/subfields are displayed in the column.

Testing:

I Apply the patch
II Run updatedatabase.pl

ACQUISITIONS
0) Enter a field/subfield in the AdditionalFieldsInZ3950ResultSearch
1) Create a new basket or use an existing one
2) In -Add order to basket-, click "From an external source"
3) Select some search targets and enter a subject heading ex. house
4) Click Search bouton
5) Validate "Additional fields" column with the field/subfield value.

CATALOGUING
0) Shares same syspref as above
1) Go to cataloguing, click New from z3950
2) Fill to result in a successful search
3) Validate column Addition Fields

prove t/db_dependent/Breeding.t

Sponsored-by: CCSR (https://ccsr.qc.ca)



Current patch-complexity: Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #91 from Katrin Fischer  ---
Hi all, 

retesting this, there are a few small glitches (tested with MARC21):

- the label will show empty, if the subfield you asked for doesn't exist. 
  Example: 035$a: will show, if there is a 035 with only a $9 in the data.
- it will only show the first field from the data, making this not work for
  repeatable fields like 700$a - only the first entry is shown.


The sys pref should be reworded a little, but that's minor and can be done
easily (I would have done it, but got stuck on the other items)

I am not entirely persuaded by the 2 line display using  , but also non
blocker.

Plus:
Works well for control fields without subfields, Example: 001. Maybe be good   
 to add an example to the list of fields in the sys pref description.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #74035|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

--- Comment #90 from Séverine Queune  ---
Feature works fine.
A detail : maybe the pull down menu is too far from the selected line (1 or 2
lines down). I can't remember exactly what the first feature looked like.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Séverine Queune  changed:

   What|Removed |Added

  Attachment #74040|0   |1
is obsolete||

--- Comment #89 from Séverine Queune  ---
Created attachment 74787
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74787=edit
Bug 12747: Adjustment to Z39.05 search template

Removed some old columns that were moved in a previous patch and brought back
in while rebasing.
Also moved the additionnal fields column to the left of the action columns, so
the pull down menu
stays at the far right of the line.

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Séverine Queune  changed:

   What|Removed |Added

  Attachment #74039|0   |1
is obsolete||

--- Comment #88 from Séverine Queune  ---
Created attachment 74786
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74786=edit
Bug 12747: (follow-up) Removed unwanted tab character and fixed typo in tests

Removed a typo introduced while adding missing `use t::lib::Mocks ...` to
Breeding.t
Also removed tab character from z3950_search.tt

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Séverine Queune  changed:

   What|Removed |Added

  Attachment #74037|0   |1
is obsolete||

--- Comment #87 from Séverine Queune  ---
Created attachment 74785
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74785=edit
Bug 12747: Switch date field on marc flavour

Amended _add_rowdata to check only for the marcflavour-appropriate date field.
This makes the test pass without noise.

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Séverine Queune  changed:

   What|Removed |Added

  Attachment #72981|0   |1
is obsolete||

--- Comment #85 from Séverine Queune  ---
Created attachment 74783
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74783=edit
Bug 12747 - Add extra column in Z3950 search

This is a complete squash of previous patches, with additional code quality
improvments following M. Tompsett's feedback. Squashing was done (as suggested)
because many lines add be added and subsequently deleted, which made for
confusing patches.

New changes:
* Major enhancement to _add_custom_rowdata(), as suggested by QA. The $_
variable is no longer used (at all), and the split() routine is used.
* t/db_dependent/Breeding.t now uses the mocked preference logic to avoid
sysprefs being affected.

Functionality and test plan have not changed.

--

This patch makes it possible to add an extra column to Z3950 search results.
The system preference AdditionalFieldsInZ3950ResultSearch maps which MARC
field/subfields are displayed in the column.

Testing:

I Apply the patch
II Run updatedatabase.pl

ACQUISITIONS
0) Enter a field/subfield in the AdditionalFieldsInZ3950ResultSearch
1) Create a new basket or use an existing one
2) In -Add order to basket-, click "From an external source"
3) Select some search targets and enter a subject heading ex. house
4) Click Search bouton
5) Validate "Additional fields" column with the field/subfield value.

CATALOGUING
0) Shares same syspref as above
1) Go to cataloguing, click New from z3950
2) Fill to result in a successful search
3) Validate column Addition Fields

Sponsored-by: CCSR (https://ccsr.qc.ca)
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

--- Comment #86 from Séverine Queune  ---
Created attachment 74784
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74784=edit
Bug 12747 - Missing use in tests

Adds missing `use t::lib::Mocks ...` to Breeding.t

Tests should now pass correctly.

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Séverine Queune  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Roch D'Amour  changed:

   What|Removed |Added

  Attachment #74038|0   |1
is obsolete||

--- Comment #84 from Roch D'Amour  ---
Created attachment 74040
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74040=edit
Bug 12747: Adjustment to Z39.05 search template

Removed some old columns that were moved in a previous patch and brought back
in while rebasing.
Also moved the additionnal fields column to the left of the action columns, so
the pull down menu
stays at the far right of the line.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Roch D'Amour  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Roch D'Amour  changed:

   What|Removed |Added

  Attachment #73955|0   |1
is obsolete||

--- Comment #83 from Roch D'Amour  ---
Created attachment 74039
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74039=edit
Bug 12747: (follow-up) Removed unwanted tab character and fixed typo in tests

Removed a typo introduced while adding missing `use t::lib::Mocks ...` to
Breeding.t
Also removed tab character from z3950_search.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Roch D'Amour  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Roch D'Amour  changed:

   What|Removed |Added

  Attachment #72981|1   |0
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Roch D'Amour  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

--- Comment #82 from Roch D'Amour  ---
Created attachment 74038
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74038=edit
Bug 12747: Adjustment to Z39.05 search template

Removed some old columns that were moved in a previous patch and brought back
in while rebasing.
Also moved the additionnal fields column to the left of the action columns, so
the pull down menu
stays at the far right of the line.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Roch D'Amour  changed:

   What|Removed |Added

  Attachment #72980|0   |1
is obsolete||

--- Comment #81 from Roch D'Amour  ---
Created attachment 74037
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74037=edit
Bug 12747: Switch date field on marc flavour

Amended _add_rowdata to check only for the marcflavour-appropriate date field.
This makes the test pass without noise.

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Roch D'Amour  changed:

   What|Removed |Added

  Attachment #72981|0   |1
is obsolete||

--- Comment #80 from Roch D'Amour  ---
Created attachment 74035
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=74035=edit
Bug 12747: Missing use in tests

Adds missing `use t::lib::Mocks ...` to Breeding.t

Tests should now pass correctly.

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

--- Comment #79 from Katrin Fischer  ---
Please also fix your commit messages on the first 2 patches as pointed out by
the QA tools:

Bug 12747 - Add extra column in Z3950 search result

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #78 from Katrin Fischer  ---
Please double check the Z39.05 search, MARC, ISBD, etc. have been moved into a
pull down menu a whlie ago and your patch adds back the initial separate
columns.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Katrin Fischer  changed:

   What|Removed |Added

 QA Contact|m.de.r...@rijksmuseum.nl|katrin.fisc...@bsz-bw.de

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Roch D'Amour  changed:

   What|Removed |Added

  Attachment #73930|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Roch D'Amour  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Roch D'Amour  changed:

   What|Removed |Added

  Attachment #72979|0   |1
is obsolete||

--- Comment #77 from Roch D'Amour  ---
Created attachment 73955
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73955=edit
Bug 12747: (follow-up) Removed unwanted tab character and fixed typo in tests

Removed a typo introduced while adding missing `use t::lib::Mocks ...` to
Breeding.t
Also removed tab character from z3950_search.tt

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Roch D'Amour  changed:

   What|Removed |Added

 CC||roch.dam...@inlibro.com

--- Comment #76 from Roch D'Amour  ---
You're right, that commit was a bit rushed :/
I will clean it up a bit and fix all the red stuff from the QA tools.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #75 from Jonathan Druart  
---
(In reply to Roch D'Amour from comment #74)
> Created attachment 73930 [details] [review]
> Bug 12747 - fixed typo in uses in tests

Really? please read
https://wiki.koha-community.org/wiki/Commit_messages#Formatting
Update your QA tools repo and run the tests.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

--- Comment #74 from Roch D'Amour  ---
Created attachment 73930
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=73930=edit
Bug 12747 - fixed typo in uses in tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Roch D'Amour  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #73 from Katrin Fischer  ---
 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt
   FAIL   forbidden patterns
forbidden pattern: tab char (line 110)
   OK git manipulation
   OK spelling
   OK tt_valid
   OK valid_template

 FAIL   t/db_dependent/Breeding.t
   OK critic
   OK forbidden patterns
   OK git manipulation
   OK pod
   OK spelling
   FAIL   valid
Can't locate t/luib/Mocks.pm in @INC (you may need to install
the t::luib::Mocks module) (@INC contains: /home/vagrant/kohaclone
/home/vagrant/qa-test-tools /etc/perl
/usr/local/lib/x86_64-linux-gnu/perl/5.20.2 /usr/local/share/perl/5.20.2
/usr/lib/x86_64-linux-gnu/perl5/5.20 /usr/share/perl5
/usr/lib/x86_64-linux-gnu/perl/5.20 /usr/share/perl/5.20
/usr/local/lib/site_perl .) 

Typo in the test file? Please fix!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Séverine Queune  changed:

   What|Removed |Added

 CC||severine.que...@bulac.fr

--- Comment #72 from Séverine Queune  ---
Tested with Unimarc DB, worked as described on both basket and cataloguing.
Thanks for this enhancement !

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Séverine Queune  changed:

   What|Removed |Added

  Attachment #72896|0   |1
is obsolete||

--- Comment #69 from Séverine Queune  ---
Created attachment 72979
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72979=edit
Bug 12747 - Missing use in tests

Adds missing `use t::lib::Mocks ...` to Breeding.t

Tests should now pass correctly.

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Séverine Queune  changed:

   What|Removed |Added

  Attachment #72898|0   |1
is obsolete||

--- Comment #71 from Séverine Queune  ---
Created attachment 72981
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72981=edit
Bug 12747 - Add extra column in Z3950 search

This is a complete squash of previous patches, with additional code quality
improvments following M. Tompsett's feedback. Squashing was done (as suggested)
because many lines add be added and subsequently deleted, which made for
confusing patches.

New changes:
* Major enhancement to _add_custom_rowdata(), as suggested by QA. The $_
variable is no longer used (at all), and the split() routine is used.
* t/db_dependent/Breeding.t now uses the mocked preference logic to avoid
sysprefs being affected.

Functionality and test plan have not changed.

--

This patch makes it possible to add an extra column to Z3950 search results.
The system preference AdditionalFieldsInZ3950ResultSearch maps which MARC
field/subfields are displayed in the column.

Testing:

I Apply the patch
II Run updatedatabase.pl

ACQUISITIONS
0) Enter a field/subfield in the AdditionalFieldsInZ3950ResultSearch
1) Create a new basket or use an existing one
2) In -Add order to basket-, click "From an external source"
3) Select some search targets and enter a subject heading ex. house
4) Click Search bouton
5) Validate "Additional fields" column with the field/subfield value.

CATALOGUING
0) Shares same syspref as above
1) Go to cataloguing, click New from z3950
2) Fill to result in a successful search
3) Validate column Addition Fields

Sponsored-by: CCSR (https://ccsr.qc.ca)
Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Séverine Queune  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Séverine Queune  changed:

   What|Removed |Added

  Attachment #72897|0   |1
is obsolete||

--- Comment #70 from Séverine Queune  ---
Created attachment 72980
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72980=edit
Bug 12747 - Switch date field on marc flavour

Amended _add_rowdata to check only for the marcflavour-appropriate date field.
This makes the test pass without noise.

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Roch D'Amour  changed:

   What|Removed |Added

  Attachment #72706|0   |1
is obsolete||

--- Comment #68 from Roch D'Amour  ---
Created attachment 72898
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72898=edit
Bug 12747 - Add extra column in Z3950 search

This is a complete squash of previous patches, with additional code quality
improvments following M. Tompsett's feedback. Squashing was done (as suggested)
because many lines add be added and subsequently deleted, which made for
confusing patches.

New changes:
* Major enhancement to _add_custom_rowdata(), as suggested by QA. The $_
variable is no longer used (at all), and the split() routine is used.
* t/db_dependent/Breeding.t now uses the mocked preference logic to avoid
sysprefs being affected.

Functionality and test plan have not changed.

--

This patch makes it possible to add an extra column to Z3950 search results.
The system preference AdditionalFieldsInZ3950ResultSearch maps which MARC
field/subfields are displayed in the column.

Testing:

I Apply the patch
II Run updatedatabase.pl

ACQUISITIONS
0) Enter a field/subfield in the AdditionalFieldsInZ3950ResultSearch
1) Create a new basket or use an existing one
2) In -Add order to basket-, click "From an external source"
3) Select some search targets and enter a subject heading ex. house
4) Click Search bouton
5) Validate "Additional fields" column with the field/subfield value.

CATALOGUING
0) Shares same syspref as above
1) Go to cataloguing, click New from z3950
2) Fill to result in a successful search
3) Validate column Addition Fields

Sponsored-by: CCSR (https://ccsr.qc.ca)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Roch D'Amour  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Roch D'Amour  changed:

   What|Removed |Added

  Attachment #69297|0   |1
is obsolete||

--- Comment #67 from Roch D'Amour  ---
Created attachment 72897
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72897=edit
Bug 12747 - Switch date field on marc flavour

Amended _add_rowdata to check only for the marcflavour-appropriate date field.
This makes the test pass without noise.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Roch D'Amour  changed:

   What|Removed |Added

  Attachment #68215|0   |1
is obsolete||

--- Comment #66 from Roch D'Amour  ---
Created attachment 72896
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72896=edit
Bug 12747 - Missing use in tests

Adds missing `use t::lib::Mocks ...` to Breeding.t

Tests should now pass correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Hugo Agud  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #65 from Hugo Agud  ---
patch doesn't apply

The sandbox you've requested is not ready.
Some problems occurred applying patches from bug 12747:
Something went wrong !Applying: Bug 12747 - Missing use in tests
fatal: sha1 information is lacking or useless (t/db_dependent/Breeding.t).
Patch failed at 0001 Bug 12747 - Missing use in tests
The copy of the patch that failed is found in: .git/rebase-apply/patch
When you have resolved this problem run git bz apply --continue.
If you would prefer to skip this patch, instead run git bz apply --skip.
To restore the original branch and stop patching run git bz apply --abort.
error: could not build fake ancestor
Bug 12747 - Add extra column in Z3950 search result

68215 - Bug 12747 - Missing use in tests
69297 - Bug 12747 - Switch date field on marc flavour

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Maksim Sen  changed:

   What|Removed |Added

 CC||maksim@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Maksim Sen  changed:

   What|Removed |Added

  Attachment #68214|0   |1
is obsolete||

--- Comment #64 from Maksim Sen  ---
Created attachment 72706
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=72706=edit
Bug 12747 - Add extra column in Z3950 search

This is a complete squash of previous patches, with additional code quality
improvments following M. Tompsett's feedback. Squashing was done (as suggested)
because many lines add be added and subsequently deleted, which made for
confusing patches.

New changes:
* Major enhancement to _add_custom_rowdata(), as suggested by QA. The $_
variable is no longer used (at all), and the split() routine is used.
* t/db_dependent/Breeding.t now uses the mocked preference logic to avoid
sysprefs being affected.

Functionality and test plan have not changed.

--

This patch makes it possible to add an extra column to Z3950 search results.
The system preference AdditionalFieldsInZ3950ResultSearch maps which MARC
field/subfields are displayed in the column.

Testing:

I Apply the patch
II Run updatedatabase.pl

ACQUISITIONS
0) Enter a field/subfield in the AdditionalFieldsInZ3950ResultSearch
1) Create a new basket or use an existing one
2) In -Add order to basket-, click "From an external source"
3) Select some search targets and enter a subject heading ex. house
4) Click Search bouton
5) Validate "Additional fields" column with the field/subfield value.

CATALOGUING
0) Shares same syspref as above
1) Go to cataloguing, click New from z3950
2) Fill to result in a successful search
3) Validate column Addition Fields

Sponsored-by: CCSR (https://ccsr.qc.ca)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Maksim Sen  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Patch doesn't apply

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

--- Comment #63 from David Bourgault  ---
Created attachment 69297
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69297=edit
Bug 12747 - Switch date field on marc flavour

Amended _add_rowdata to check only for the marcflavour-appropriate date field.
This makes the test pass without noise.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

David Bourgault  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

M. Tompsett  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #62 from M. Tompsett  ---
Ah ha! I figured out why there is noise. Sorry my brain is slow. You have
MARC21 and UNIMARC attempts in the same loop (biblioitems.publicationyear).
That's going to generate noise on a MARC21 system. I have yet to test on a
UNIMARC system.

And sorry... fails on unimarc system. You create 245$a, which is MARC21. You
need to grab the appropriate title tag and subtag for title under the current
system MARC flavour, so that the test won't die.

In fact, you should split the test to a unimarc and marc21 run. Sorry, but
Failed QA again.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

--- Comment #61 from M. Tompsett  ---
Oh the code is so much prettier. Thank you. I'll sign off after lunch, after
retest.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

--- Comment #60 from David Bourgault  ---
Created attachment 68215
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68215=edit
Bug 12747 - Missing use in tests

Adds missing `use t::lib::Mocks ...` to Breeding.t

Tests should now pass correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

David Bourgault  changed:

   What|Removed |Added

  Attachment #66586|0   |1
is obsolete||
  Attachment #66587|0   |1
is obsolete||
  Attachment #66588|0   |1
is obsolete||
  Attachment #66589|0   |1
is obsolete||
  Attachment #67314|0   |1
is obsolete||
  Attachment #67315|0   |1
is obsolete||

--- Comment #59 from David Bourgault  ---
Created attachment 68214
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68214=edit
Bug 12747 - Add extra column in Z3950 search results

This is a complete squash of previous patches, with additional code quality
improvments following M. Tompsett's feedback. Squashing was done (as suggested)
because many lines add be added and subsequently deleted, which made for
confusing patches.

New changes:
* Major enhancement to _add_custom_rowdata(), as suggested by QA. The $_
variable is no longer used (at all), and the split() routine is used.
* t/db_dependent/Breeding.t now uses the mocked preference logic to avoid
sysprefs being affected.

Functionality and test plan have not changed.

--

This patch makes it possible to add an extra column to Z3950 search results.
The system preference AdditionalFieldsInZ3950ResultSearch maps which MARC
field/subfields are displayed in the column.

Testing:

I Apply the patch
II Run updatedatabase.pl

ACQUISITIONS
0) Enter a field/subfield in the AdditionalFieldsInZ3950ResultSearch
1) Create a new basket or use an existing one
2) In -Add order to basket-, click "From an external source"
3) Select some search targets and enter a subject heading ex. house
4) Click Search bouton
5) Validate "Additional fields" column with the field/subfield value.

CATALOGUING
0) Shares same syspref as above
1) Go to cataloguing, click New from z3950
2) Fill to result in a successful search
3) Validate column Addition Fields

Sponsored-by: CCSR (https://ccsr.qc.ca)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

--- Comment #58 from M. Tompsett  ---
Okay, tested. It generally works. However, the test bothers me. The preference
is not mocked; it is used directly. This can be bad if the test is interrupted
in the middle of the test with the value changed. And the test is loud,
generating noise when the prove is run.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

M. Tompsett  changed:

   What|Removed |Added

 CC||mtomp...@hotmail.com

--- Comment #57 from M. Tompsett  ---
Trying to test acquisition change... having difficulties. I don't think it is a
code issue. BTW, Additional fields does look okay for a circulation Z39.50
search.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

--- Comment #56 from M. Tompsett  ---
Comment on attachment 67314
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67314
Bug 12747 - Corrections on QA feedback

Review of attachment 67314:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=12747=67314)
-

::: C4/Breeding.pm
@@ -224,5 @@
> -@servers = ();
> -foreach my $id (@id) {
> -push @servers, {id => $id};
> -}
> -

Why was this removed? Did you add it before?

@@ +344,5 @@
> +
> +return $row;
> +}
> +
> +sub _add_custom_field_rowdata

Nice extraction.

::: installer/data/mysql/sysprefs.sql
@@ +9,2 @@
>  ('AdditionalFieldsInZ3950ResultSearch', '', NULL, 'Determines which MARC 
> field/subfields are displayed in -Additional field- column in the result of a 
> search Z3950', 'Free'),
> +('AddressFormat','us','us|de|fr','Choose format to display postal 
> addresses', 'Choice'),

Intermediate patches dealing with rebases makes this look like a mistake.
Squashing is frequently a good idea where possible.

::: koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt
@@ +133,4 @@
>  Author
>  ISBN
>  LCCN
> +[% IF Koha.Preference('AdditionalFieldsInZ3950ResultSearch') != '' %]

Length, != ''... okay, this is better.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

David Bourgault  changed:

   What|Removed |Added

   Assignee|philippe.blo...@inlibro.com |david.bourga...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

--- Comment #55 from M. Tompsett  ---
Comment on attachment 66589
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66589
Bug12747 - Small fix for add this field correctly in cataloging module

Review of attachment 66589:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=12747=66589)
-

I don't see the point of this patch. If the issue was adding 000, then check
length. Less parameters is always better.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

--- Comment #54 from M. Tompsett  ---
Comment on attachment 66588
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66588
Bug12747 - Follow-up to QA

Review of attachment 66588:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=12747=66588)
-

::: t/db_dependent/Breeding.t
@@ +195,5 @@
> +
> +sub test_add_rowdata {
> +
> + my $old_preference = 
> C4::Context->preference("AdditionalFieldsInZ3950ResultSearch");
> +C4::Context->set_preference("AdditionalFieldsInZ3950ResultSearch","");

It would be better to mock the preference, so that failure would not affect the
database.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

--- Comment #53 from M. Tompsett  ---
Comment on attachment 66587
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66587
Bug 12747 - Add extra column in Z3950 search result

Review of attachment 66587:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=12747=66587)
-

::: C4/Breeding.pm
@@ +362,4 @@
>  my @addnumberfields;
>  foreach (@addnumber_array) {
>  my $length = length($_);
>  my $adTag = substr($_, 0, 3);

If the field is:
100$a 245$a 700$a
Then why aren't you:
my @fields_to_add = split / /, $pref_addnumber;
And inside the the loop:
foreach my $field (@fields_to_add) {
my ($tag,$subtags) = split |\$|, $field;
You are making an assumption that the user won't type something bad like
20$a instead of 020$a.
Notice my use of $subtags, because that would be the 'abc' or whatever was set.
my @subtags = split //,$subtags; # I believe this splits each character out.
foreach my $subtag (@subtags) {
substr() calculations are just messy and slow.

@@ +385,5 @@
> +   my $subfields_text = $field->as_string();
> +   push(@addnumberfields, $_);
> +   $row->{$_} = $subfields_text;
> +   }
> +   }

And then all this logic could be optimized.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

--- Comment #52 from M. Tompsett  ---
Comment on attachment 66586
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66586
Bug 12747 - Add extra column in Z3950 search

Review of attachment 66586:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=12747=66586)
-

::: C4/Breeding.pm
@@ +365,5 @@
> +   my $fieldContent='';
> +   if ($length > 3){
> +   my $adSubfield;
> +   for (my $i=0; $i<$length-3; $i++){
> +  $adSubfield = substr($_, 3+$i, 1);

When you have nested loops, one should avoid $_ and be explicit (on line 359)
to improve readability and prevent accidental breakage later.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

David Bourgault  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff
 CC||david.bourga...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

--- Comment #51 from David Bourgault  ---
Created attachment 67315
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67315=edit
Bug 12747 - Fix : INSERT IGNORE INTO in atomicupdate

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

--- Comment #50 from David Bourgault  ---
Created attachment 67314
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67314=edit
Bug 12747 - Corrections on QA feedback

C4/Breeding.pm
+ code in _add_rowdata moved to new subroutine (_add_custom_field_rowdata)
- removed useless code

Templates:
* template use Koha.Preference instead of passed param.

Syspref.sql
* corrected order
- removed unrelated modification to other system preferences

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Patrick Robitaille  changed:

   What|Removed |Added

 CC||patrick.robitai...@ccsr.qc.
   ||ca

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

--- Comment #49 from Blou  ---
To the last comment:
<<
   You add all additional fields in one column??
>>
Yes.  And it's beautiful.

I'll get someone to look at your other points as soon as possible.  The one
about Koha.Preference just shows the age of this feature.  :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Marcel de Rooy  changed:

   What|Removed |Added

 QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Marcel de Rooy  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #48 from Marcel de Rooy  ---
QA Comment:
Thx for your proposal. Some points that need attention:

Breeding.pm:
@servers = ();
foreach my $id (@id) {
push @servers, {id => $id};
}
Please explain what you are doing here. Seems unneeded or wrong. 

$template->param(
additionalFields => '1'
) if C4::Context->preference('AdditionalFieldsInZ3950ResultSearch');
Please use Koha::Preference in the template.

sub _add_rowdata
Just intuitive, these additions dont look that nice to me. I think you should
add more validation and put this in another subroutine, taking care that you do
not overwrite the default fields.

+++
b/installer/data/mysql/atomicupdate/bug_12747-additional_fields_in_Z3950_search_result.sql
@@ -0,0 +1 @@
+INSERT INTO systempreferences 
Please INSERT IGNORE

+('AddressFormat','us','','Choose format to display postal addresses',
'Choice'),
+('AdditionalFieldsInZ3950ResultSearch', '', NULL, 'Determines which MARC
field/subfields are displayed in -Additional field- column in the result of a
search Z3950', 'Free'),
Please respect the sort order in sysprefs.
Note: I saw that a LOT of other new prefs are not in the right order. But you
dont need to correct that here of course. Just add your own one in the right
place.

+[% IF additionalFields %]
+
+   
+  [% FOREACH addnumberfield IN breeding_loo.addnumberfields %]
+  [% addnumberfield %]:
+  [% breeding_loo.$addnumberfield %]
+  [% END %]
+   
+
+[% END %]
You add all additional fields in one column??

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Hugo Agud  changed:

   What|Removed |Added

 CC||ha...@orex.es
 Status|Needs Signoff   |Signed Off

--- Comment #47 from Hugo Agud  ---
I have applied the patch to kohadevbox and proceed with test plan and It works
according the expected

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Philippe Audet-Fortin  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff
 CC||philippe.audet-fortin@inlib
   ||ro.com

--- Comment #46 from Philippe Audet-Fortin  
---
The patch apply without conflict.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Philippe Audet-Fortin  changed:

   What|Removed |Added

  Attachment #60965|0   |1
is obsolete||

--- Comment #45 from Philippe Audet-Fortin  
---
Created attachment 66589
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66589=edit
Bug12747 - Small fix for add this field correctly in cataloging module

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Philippe Audet-Fortin  changed:

   What|Removed |Added

  Attachment #58426|0   |1
is obsolete||

--- Comment #44 from Philippe Audet-Fortin  
---
Created attachment 66588
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66588=edit
Bug12747 - Follow-up to QA

Removed unnecessary code in Breeding.pm and provided a new test in Breeding.t

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Philippe Audet-Fortin  changed:

   What|Removed |Added

  Attachment #58425|0   |1
is obsolete||

--- Comment #43 from Philippe Audet-Fortin  
---
Created attachment 66587
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66587=edit
Bug 12747 - Add extra column in Z3950 search result

This patch uses the standard field syntax (ex: 023$ab), allows writing fields
without mentionning subfields and uses whitespace as a field separator instead
of semicolon.

sponsored by the CCSR ( http://www.ccsr.qc.ca )

Tested with both patches, works as expected.
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Philippe Audet-Fortin  changed:

   What|Removed |Added

  Attachment #58424|0   |1
is obsolete||

--- Comment #42 from Philippe Audet-Fortin  
---
Created attachment 66586
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66586=edit
Bug 12747 - Add extra column in Z3950 search

This patch permits to add an extra column in Z3950 search result.
The system preference AdditionalFieldsInZ3950ResultSearch maps which MARC
field/subfields are displayed in the column.

Testing:

I Apply the patch
II Run updatedatabase.pl

ACQUISITIONS
0) Enter a field/subfield in the AdditionalFieldsInZ3950ResultSearch
1) Create a new basket or use an existing one
2) In -Add order to basket-, click "From an external source"
3) Select some search targets and enter a subject heading ex. house
4) Click Search bouton
5) Validate "Additional fields" column with the field/subfield value.

CATALOGUING
0) shares same syspref as above
1) Go to cataloguing, click New from z3950
2) fill to result in a successful search
3) validate column Addition Fields

sponsored by the CCSR ( http://www.ccsr.qc.ca )

Tested with both patches together, followed test plan, works as expected
Signed-off-by: Marc Véron 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Jesse Maseto  changed:

   What|Removed |Added

 CC||je...@bywatersolutions.com
 Status|Needs Signoff   |Patch doesn't apply

--- Comment #41 from Jesse Maseto  ---
This patch no longer applies:

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 12747 - Add extra column in Z3950 search
Using index info to reconstruct a base tree...
M   installer/data/mysql/sysprefs.sql
M   koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt
M   koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt
Falling back to patching base and 3-way merge...
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt
Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt
Auto-merging installer/data/mysql/sysprefs.sql
CONFLICT (content): Merge conflict in installer/data/mysql/sysprefs.sql
Failed to merge in the changes.
Patch failed at 0001 Bug 12747 - Add extra column in Z3950 search
The copy of the patch that failed is found in:
   /home/vagrant/kohaclone/.git/rebase-apply/patch
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-12747---Add-extra-column-in-Z3950-search-rZkwMW.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

Bouzid  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff
 CC||bouzid.ferg...@inlibro.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 12747] Add extra column in Z3950 search result

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747

--- Comment #40 from Bouzid  ---
Created attachment 60965
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60965=edit
Bug12747 - Small fix for add this field correctly in cataloging module

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/