[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 --- Comment #40 from Katrin Fischer --- Sorry, was a little too fast, not reading closely enough. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 --- Comment #39 from Jonathan Druart --- (In reply to Katrin Fischer from comment #38) > Yes, always a new bug after things are pushed (no confusion in release notes > etc.) If it is not backported yet and the fix is trivial I prefer a follow-up on the same bug report and push it directly without the SO+QA steps. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 --- Comment #38 from Katrin Fischer --- Yes, always a new bug after things are pushed (no confusion in release notes etc.) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 Fridolin SOMERS changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #37 from Fridolin SOMERS --- Ok when cancelling from a basket page. But I found breadcrumbs are also broken when cancelling from a receipt summary. For example : /cgi-bin/koha/acqui/parcel.pl?invoiceid=1&op=cancelreceipt&ordernumber=1 The URL does not provide "basketno". Do we create a new bug ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #36 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 --- Comment #32 from Nick Clemens --- Created attachment 67769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67769&action=edit Bug 13208: [FOLLOW-UP] Creating and implementing new Koha::Acquisition::Basket[s] modules Test plan remains the same. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: David Bourgault Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 --- Comment #35 from Nick Clemens --- Created attachment 67772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67772&action=edit Bug 13208: [FOLLOW-UP] Tests for Koha::Acquisition::Baskets To test: prove -v t/db_dependent/Koha/Acquisition/Baskets.t Signed-off-by: David Bourgault Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 --- Comment #34 from Nick Clemens --- Created attachment 67771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67771&action=edit Bug 13208: (QA follow-up) Remove blank breadcrumbs on successful deletion After order is deleted we don't have a vendor or basket so we get blank breadcrumbs, this removes them Signed-off-by: David Bourgault Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 --- Comment #33 from Nick Clemens --- Created attachment 67770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67770&action=edit Bug 13208: [FOLLOW-UP] Perl documentation for modules Signed-off-by: Katrin Fischer Signed-off-by: David Bourgault Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 Nick Clemens changed: What|Removed |Added Attachment #67167|0 |1 is obsolete|| Attachment #67168|0 |1 is obsolete|| Attachment #67169|0 |1 is obsolete|| Attachment #67170|0 |1 is obsolete|| Attachment #67171|0 |1 is obsolete|| --- Comment #31 from Nick Clemens --- Created attachment 67768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67768&action=edit Bug 13208: Improving breadcrumbs for when cancelling an order To test: 1) Go to Acquisitions -> Find a vendor -> View a basket with orders in it (or make a new basket and add an order) 2) Click Cancel order 3) Notice incomplete breadcrumbs, and 'Acquisition' typo 4) Apply patch and refresh page 5) Breadcrumbs should be fixed. Confirm links to vendor and basket work as expected Sponsored-by: Catalyst IT Signed-off-by: severine.queune Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Signed-off-by: David Bourgault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 David Bourgault changed: What|Removed |Added Attachment #66738|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 David Bourgault changed: What|Removed |Added Attachment #66831|0 |1 is obsolete|| --- Comment #30 from David Bourgault --- Created attachment 67171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67171&action=edit Bug 13208: [FOLLOW-UP] Tests for Koha::Acquisition::Baskets To test: prove -v t/db_dependent/Koha/Acquisition/Baskets.t Signed-off-by: David Bourgault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 David Bourgault changed: What|Removed |Added Attachment #66740|0 |1 is obsolete|| --- Comment #28 from David Bourgault --- Created attachment 67169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67169&action=edit Bug 13208: [FOLLOW-UP] Perl documentation for modules Signed-off-by: Katrin Fischer Signed-off-by: David Bourgault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 David Bourgault changed: What|Removed |Added Attachment #66741|0 |1 is obsolete|| --- Comment #29 from David Bourgault --- Created attachment 67170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67170&action=edit Bug 13208: (QA follow-up) Remove blank breadcrumbs on successful deletion After order is deleted we don't have a vendor or basket so we get blank breadcrumbs, this removes them Signed-off-by: David Bourgault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 David Bourgault changed: What|Removed |Added Attachment #66739|0 |1 is obsolete|| --- Comment #27 from David Bourgault --- Created attachment 67168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67168&action=edit Bug 13208: [FOLLOW-UP] Creating and implementing new Koha::Acquisition::Basket[s] modules Test plan remains the same. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: David Bourgault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 --- Comment #26 from David Bourgault --- Created attachment 67167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67167&action=edit Bug 13208: Improving breadcrumbs for when cancelling an order To test: 1) Go to Acquisitions -> Find a vendor -> View a basket with orders in it (or make a new basket and add an order) 2) Click Cancel order 3) Notice incomplete breadcrumbs, and 'Acquisition' typo 4) Apply patch and refresh page 5) Breadcrumbs should be fixed. Confirm links to vendor and basket work as expected Sponsored-by: Catalyst IT Signed-off-by: severine.queune Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer Signed-off-by: David Bourgault -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 --- Comment #25 from Katrin Fischer --- Hi David, please add your sign-off line to the patches before you switch the status. It's quite easy with kohadevbox, but we can help you with whatever setup you have. See here: https://wiki.koha-community.org/wiki/Git_bz_configuration#Signing_off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 David Bourgault changed: What|Removed |Added CC||david.bourga...@inlibro.com Status|Needs Signoff |Signed Off --- Comment #24 from David Bourgault --- All tests successful. Files=1, Tests=4, 2 wallclock secs ( 0.02 usr 0.00 sys + 0.64 cusr 0.02 csys = 0.68 CPU) Result: PASS Signed off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 --- Comment #23 from Aleisha Amohia --- Created attachment 66831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66831&action=edit Bug 13208: [FOLLOW-UP] Tests for Koha::Acquisition::Baskets To test: prove -v t/db_dependent/Koha/Acquisition/Baskets.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #22 from Jonathan Druart --- Please provide tests for new modules (based on t/db_dependent/Koha/Cities.t). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 --- Comment #20 from Nick Clemens --- Created attachment 66740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66740&action=edit Bug 13208: [FOLLOW-UP] Perl documentation for modules Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 --- Comment #21 from Nick Clemens --- Created attachment 66741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66741&action=edit Bug 13208: (QA follow-up) Remove blank breadcrumbs on successful deletion After order is deleted we don't have a vendor or basket so we get blank breadcrumbs, this removes them -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 --- Comment #19 from Nick Clemens --- Created attachment 66739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66739&action=edit Bug 13208: [FOLLOW-UP] Creating and implementing new Koha::Acquisition::Basket[s] modules Test plan remains the same. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 Nick Clemens changed: What|Removed |Added Attachment #66499|0 |1 is obsolete|| Attachment #66500|0 |1 is obsolete|| Attachment #66501|0 |1 is obsolete|| --- Comment #18 from Nick Clemens --- Created attachment 66738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66738&action=edit Bug 13208: Improving breadcrumbs for when cancelling an order To test: 1) Go to Acquisitions -> Find a vendor -> View a basket with orders in it (or make a new basket and add an order) 2) Click Cancel order 3) Notice incomplete breadcrumbs, and 'Acquisition' typo 4) Apply patch and refresh page 5) Breadcrumbs should be fixed. Confirm links to vendor and basket work as expected Sponsored-by: Catalyst IT Signed-off-by: severine.queune Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com QA Contact|testo...@bugs.koha-communit |n...@bywatersolutions.com |y.org | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 --- Comment #17 from Katrin Fischer --- Found another problem with the breadcrumbs in acq while testing this: bug 19180 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 Katrin Fischer changed: What|Removed |Added Attachment #65954|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 Katrin Fischer changed: What|Removed |Added Attachment #65176|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 Katrin Fischer changed: What|Removed |Added Attachment #66161|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 --- Comment #16 from Katrin Fischer --- Created attachment 66501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66501&action=edit [SIGNED OFF] Bug 13208: [FOLLOW-UP] Perl documentation for modules Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 --- Comment #15 from Katrin Fischer --- Created attachment 66500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66500&action=edit [SIGNED OFF] Bug 13208: [FOLLOW-UP] Creating and implementing new Koha::Acquisition::Basket[s] modules Test plan remains the same. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 --- Comment #14 from Katrin Fischer --- Created attachment 66499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66499&action=edit [SIGNED OFF] Bug 13208: Improving breadcrumbs for when cancelling an order To test: 1) Go to Acquisitions -> Find a vendor -> View a basket with orders in it (or make a new basket and add an order) 2) Click Cancel order 3) Notice incomplete breadcrumbs, and 'Acquisition' typo 4) Apply patch and refresh page 5) Breadcrumbs should be fixed. Confirm links to vendor and basket work as expected Sponsored-by: Catalyst IT Signed-off-by: severine.queune Signed-off-by: Nick Clemens Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 --- Comment #13 from Katrin Fischer --- Personally I feel that the 'for ' is unecessary as the information is already visible in the breadcrumbs, but at the moment, this seems a common pattern in the module (Osiander being my vendor): Home › Acquisitions › Osiander › Basket Test bug 15347 (1) for Osiander -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 --- Comment #12 from Aleisha Amohia --- Created attachment 66161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66161&action=edit Bug 13208: [FOLLOW-UP] Perl documentation for modules -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #11 from Jonathan Druart --- (In reply to Owen Leonard from comment #8) > This works well for me, but there is some noise from the QA tool: > > FAIL Koha/Acquisition/Basket.pm >FAIL pod coverage > POD coverage was greater before, try perl > -MPod::Coverage=PackageName -e666 (In reply to Katrin Fischer from comment #9) > Marcel commented on this error from the qa script here: > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19049#c11 It was indeed a false positive on bug 19049 (because it was a module in the t directory), but here it's a real failure. There is missing POD for methods in Koha::Acquisition::Basket. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 Owen Leonard changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 Owen Leonard changed: What|Removed |Added Attachment #65291|0 |1 is obsolete|| --- Comment #10 from Owen Leonard --- Created attachment 65954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65954&action=edit [SIGNED-OFF] Bug 13208: [FOLLOW-UP] Creating and implementing new Koha::Acquisition::Basket[s] modules Test plan remains the same. Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 --- Comment #9 from Katrin Fischer --- Marcel commented on this error from the qa script here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19049#c11 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #8 from Owen Leonard --- This works well for me, but there is some noise from the QA tool: FAIL Koha/Acquisition/Basket.pm OK critic OK forbidden patterns OK git manipulation OK pod FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 OK spelling OK valid -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 --- Comment #7 from Aleisha Amohia --- Created attachment 65291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65291&action=edit Bug 13208: [FOLLOW-UP] Creating and implementing new Koha::Acquisition::Basket[s] modules Test plan remains the same. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Failed QA CC||jonathan.dru...@bugs.koha-c ||ommunity.org --- Comment #6 from Jonathan Druart --- I would prefer to have new Koha::Acquisition::Basket[s] modules here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 Nick Clemens changed: What|Removed |Added Attachment #64697|0 |1 is obsolete|| --- Comment #5 from Nick Clemens --- Created attachment 65176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=65176&action=edit Bug 13208: Improving breadcrumbs for when cancelling an order To test: 1) Go to Acquisitions -> Find a vendor -> View a basket with orders in it (or make a new basket and add an order) 2) Click Cancel order 3) Notice incomplete breadcrumbs, and 'Acquisition' typo 4) Apply patch and refresh page 5) Breadcrumbs should be fixed. Confirm links to vendor and basket work as expected Sponsored-by: Catalyst IT Signed-off-by: severine.queune Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 sandbo...@biblibre.com changed: What|Removed |Added Attachment #64686|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 --- Comment #4 from sandbo...@biblibre.com --- Created attachment 64697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64697&action=edit Bug 13208: Improving breadcrumbs for when cancelling an order To test: 1) Go to Acquisitions -> Find a vendor -> View a basket with orders in it (or make a new basket and add an order) 2) Click Cancel order 3) Notice incomplete breadcrumbs, and 'Acquisition' typo 4) Apply patch and refresh page 5) Breadcrumbs should be fixed. Confirm links to vendor and basket work as expected Sponsored-by: Catalyst IT Signed-off-by: severine.queune -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 sandbo...@biblibre.com changed: What|Removed |Added CC||sandbo...@biblibre.com --- Comment #3 from sandbo...@biblibre.com --- Patch tested with a sandbox, by severine.queune -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 Séverine Queune changed: What|Removed |Added Status|Needs Signoff |Signed Off CC||severine.que...@bulac.fr --- Comment #2 from Séverine Queune --- The patch applies correctly : breadcrumbs is complete and both links to vendor and basket work. 'Aquisitions' is now ended by an 's'. Thanks Aleisha ! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 Aleisha Amohia changed: What|Removed |Added CC||alei...@catalyst.net.nz Change sponsored?|--- |Sponsored Keywords||Academy Assignee|koha-b...@lists.koha-commun |alei...@catalyst.net.nz |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 --- Comment #1 from Aleisha Amohia --- Created attachment 64686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64686&action=edit Bug 13208: Improving breadcrumbs for when cancelling an order To test: 1) Go to Acquisitions -> Find a vendor -> View a basket with orders in it (or make a new basket and add an order) 2) Click Cancel order 3) Notice incomplete breadcrumbs, and 'Acquisition' typo 4) Apply patch and refresh page 5) Breadcrumbs should be fixed. Confirm links to vendor and basket work as expected Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13208] More complete breadcrumbs when cancelling an order
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13208 Aleisha Amohia changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/