[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Mathieu Saby changed: What|Removed |Added CC||mathsaby...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Didier Gautheron changed: What|Removed |Added CC||didier.gautheron@biblibre.c ||om Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Julian Maurice changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Julian Maurice changed: What|Removed |Added Attachment #103433|0 |1 is obsolete|| Attachment #103434|0 |1 is obsolete|| Attachment #103435|0 |1 is obsolete|| --- Comment #34 from Julian Maurice --- Created attachment 119078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=119078&action=edit Bug 13345: Allow patrons to choose format on sending basket/list by email It is already possible to download a basket(cart) or a list using different format. But by email, only iso2709 is possible. This patch adds the ability to select a format for the file attached to the email when sending the basket/list content. Test plan: 1/ At the OPAC, add some records to your basket and send it by email using different formats (RIS, BibTeX, MARC and the CSV profiles defined). 2/ At the OPAC, add some records to a list and send it by email using the different formats. 3/ Redo step 1 at the intranet 4/ Redo step 2 at the intranet Note that subtitles are not displayed in all these cases. Note for QA: This patch refactors 2 main things: 1/ Template side: the dropdown list to select the format is now in an include file (indeed, this list is used in 4 templates, this will make easier further changes). The include files are named 'download-export-available-formats.inc', feel free to suggest something better. The are used in: [opac-]sendbasket.tt, [opac-]sendshelf.tt, [opac-]downloadbasket.tt and [opac-]downloadshelf.tt. 2/ Build records data and the records file This job was done in 4 scripts: - opac/opac-sendbasket.pl - opac/opac-sendshelf.pl - basket/sendbasket.pl - virtualshelves/sendshelf.pl Now it's done in C4::Biblio::BuildBiblioDataForExport and tests are provided in t/db_dependent/Biblio/BuildBiblioDataForExport.t Note that a similar job is done in [opac-]downloadcart.pl and [opac-]downloadshelf.pl Sponsored-by: Mines Paristech Signed-off-by: Nicole C. Engard Signed-off-by: Bernardo Gonzalez Kriegel Test pass and mail sent, no errors. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Séverine Queune changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||severine.que...@bulac.fr --- Comment #33 from Séverine Queune --- Falling back to patching base and 3-way merge... Auto-merging virtualshelves/sendshelf.pl CONFLICT (content): Merge conflict in virtualshelves/sendshelf.pl Auto-merging virtualshelves/downloadshelf.pl CONFLICT (modify/delete): t/Koha_Email.t deleted in HEAD and modified in Bug 13345: Allow patrons to choose format on sending basket/list by email. Version Bug 13345: Allow patrons to choose format on sending basket/list by email of t/Koha_Email.t left in tree. Auto-merging opac/opac-sendshelf.pl CONFLICT (content): Merge conflict in opac/opac-sendshelf.pl Auto-merging opac/opac-sendbasket.pl CONFLICT (content): Merge conflict in opac/opac-sendbasket.pl Auto-merging opac/opac-downloadshelf.pl Auto-merging opac/opac-downloadcart.pl Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelfform.tt Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendbasketform.tt Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-downloadshelf.tt Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-downloadcart.tt Auto-merging basket/sendbasket.pl CONFLICT (content): Merge conflict in basket/sendbasket.pl Auto-merging basket/downloadcart.pl Auto-merging basket/basket.pl Auto-merging Koha/Email.pm CONFLICT (content): Merge conflict in Koha/Email.pm Auto-merging C4/Biblio.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 13345: Allow patrons to choose format on sending basket/list by email The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-13345-Allow-patrons-to-choose-format-on-sendin-QUTNYW.patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Bernardo Gonzalez Kriegel changed: What|Removed |Added CC||bgkrie...@gmail.com --- Comment #32 from Bernardo Gonzalez Kriegel --- (In reply to Katrin Fischer from comment #28) > This is quite an old patch that changes more files than you'd think at first > glance. We got a sign-off from Nicole here, but it's from March 2015. Hope > it's ok, but I'd like to ask for a new sign off here. > > Tests pass and QA script too - I like to see the amount of 'red' (removed > code) too. Signed both patches, but sending a list by email fails because there is a forgotten call to GetMember, follow-up added -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 --- Comment #31 from Bernardo Gonzalez Kriegel --- Created attachment 103435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103435&action=edit Bug 13345: follow-up remove call to GetMember This followup removes a forgotten call to GetMember -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #101999|0 |1 is obsolete|| --- Comment #30 from Bernardo Gonzalez Kriegel --- Created attachment 103434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103434&action=edit Bug 13345: Fix BuildBiblioDataForExport tests Signed-off-by: Bernardo Gonzalez Kriegel -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Bernardo Gonzalez Kriegel changed: What|Removed |Added Attachment #101998|0 |1 is obsolete|| --- Comment #29 from Bernardo Gonzalez Kriegel --- Created attachment 103433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=103433&action=edit Bug 13345: Allow patrons to choose format on sending basket/list by email It is already possible to download a basket(cart) or a list using different format. But by email, only iso2709 is possible. This patch adds the ability to select a format for the file attached to the email when sending the basket/list content. Test plan: 1/ At the OPAC, add some records to your basket and send it by email using different formats (RIS, BibTeX, MARC and the CSV profiles defined). 2/ At the OPAC, add some records to a list and send it by email using the different formats. 3/ Redo step 1 at the intranet 4/ Redo step 2 at the intranet Note that subtitles are not displayed in all these cases. Note for QA: This patch refactors 3 main things: 1/ Template side: the dropdown list to select the format is now in an include file (indeed, this list is used in 4 templates, this will make easier further changes). The include files are named 'download-export-available-formats.inc', feel free to suggest something better. The are used in: [opac-]sendbasket.tt, [opac-]sendshelf.tt, [opac-]downloadbasket.tt and [opac-]downloadshelf.tt. 2/ Build records data and the records file This job was done in 4 scripts: - opac/opac-sendbasket.pl - opac/opac-sendshelf.pl - basket/sendbasket.pl - virtualshelves/sendshelf.pl Now it's done in C4::Biblio::BuildBiblioDataForExport and tests are provided in t/db_dependent/Biblio/BuildBiblioDataForExport.t Not that a similar job is done in [opac-]downloadcart.pl and [opac-]downloadshelf.pl 3/ Build the subject and body of the email sent Same as before, the job was done at the same places. Now it's done in Koha::Email->fill_body_for_sending (feel free to suggestion a better name) and tests are provided in t/Koha_Email.t Sponsored-by: Mines Paristech Signed-off-by: Nicole C. Engard Signed-off-by: Bernardo Gonzalez Kriegel Test pass and mail sent, no errors. But a follow-up to remove useless call to GetMember is needed for email list to work. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Needs Signoff --- Comment #28 from Katrin Fischer --- This is quite an old patch that changes more files than you'd think at first glance. We got a sign-off from Nicole here, but it's from March 2015. Hope it's ok, but I'd like to ask for a new sign off here. Tests pass and QA script too - I like to see the amount of 'red' (removed code) too. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Julian Maurice changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 --- Comment #27 from Julian Maurice --- Created attachment 101999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101999&action=edit Bug 13345: Fix BuildBiblioDataForExport tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Julian Maurice changed: What|Removed |Added Attachment #100886|0 |1 is obsolete|| --- Comment #26 from Julian Maurice --- Created attachment 101998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=101998&action=edit Bug 13345: Allow patrons to choose format on sending basket/list by email It is already possible to download a basket(cart) or a list using different format. But by email, only iso2709 is possible. This patch adds the ability to select a format for the file attached to the email when sending the basket/list content. Test plan: 1/ At the OPAC, add some records to your basket and send it by email using different formats (RIS, BibTeX, MARC and the CSV profiles defined). 2/ At the OPAC, add some records to a list and send it by email using the different formats. 3/ Redo step 1 at the intranet 4/ Redo step 2 at the intranet Note that subtitles are not displayed in all these cases. Note for QA: This patch refactors 3 main things: 1/ Template side: the dropdown list to select the format is now in an include file (indeed, this list is used in 4 templates, this will make easier further changes). The include files are named 'download-export-available-formats.inc', feel free to suggest something better. The are used in: [opac-]sendbasket.tt, [opac-]sendshelf.tt, [opac-]downloadbasket.tt and [opac-]downloadshelf.tt. 2/ Build records data and the records file This job was done in 4 scripts: - opac/opac-sendbasket.pl - opac/opac-sendshelf.pl - basket/sendbasket.pl - virtualshelves/sendshelf.pl Now it's done in C4::Biblio::BuildBiblioDataForExport and tests are provided in t/db_dependent/Biblio/BuildBiblioDataForExport.t Not that a similar job is done in [opac-]downloadcart.pl and [opac-]downloadshelf.pl 3/ Build the subject and body of the email sent Same as before, the job was done at the same places. Now it's done in Koha::Email->fill_body_for_sending (feel free to suggestion a better name) and tests are provided in t/Koha_Email.t Sponsored-by: Mines Paristech Signed-off-by: Nicole C. Engard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345
Kyle M Hall changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #25 from Kyle M Hall ---
prove t/db_dependent/Biblio/BuildBiblioDataForExport.t
t/db_dependent/Biblio/BuildBiblioDataForExport.t .. 1/4 Use of uninitialized
value in numeric ne (!=) at /kohadevbox/koha/C4/Ris.pm line 833.
Use of uninitialized value in numeric ne (!=) at /kohadevbox/koha/C4/Ris.pm
line 833.
# Failed test at t/db_dependent/Biblio/BuildBiblioDataForExport.t line
68.
# got: 'TY - BOOK
# AU - Knuth,Donald Ervin
# TI - The art of computer programming
# KW - Computer programming
# KW - Computer algorithms
# ER -
# '
# expected: 'TY - BOOK
# AU - Knuth, Donald Ervin
# TI - The art of computer programming
# KW - Computer programming
# KW - Computer algorithms
# ER -
# '
# Looks like you failed 1 test of 1.
# Failed test 'ris'
# at t/db_dependent/Biblio/BuildBiblioDataForExport.t line 69.
# Failed test at t/db_dependent/Biblio/BuildBiblioDataForExport.t line
77.
# got: '@book{440,
# author = {Knuth, Donald Ervin},
# title = {The art of computer programming}
# }
# '
# expected: '@book{440,
# author = {Knuth, Donald Ervin},
# title = {The art of computer programming}
# }
# '
# Looks like you failed 1 test of 1.
# Failed test 'bibtex'
# at t/db_dependent/Biblio/BuildBiblioDataForExport.t line 82.
# Looks like you failed 2 tests of 4.
t/db_dependent/Biblio/BuildBiblioDataForExport.t .. Dubious, test returned 2
(wstat 512, 0x200)
Failed 2/4 subtests
Test Summary Report
---
t/db_dependent/Biblio/BuildBiblioDataForExport.t (Wstat: 512 Tests: 4 Failed:
2)
Failed tests: 3-4
Non-zero exit status: 2
Files=1, Tests=4, 3 wallclock secs ( 0.02 usr 0.01 sys + 1.46 cusr 0.27
csys = 1.76 CPU)
Result: FAIL
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Julian Maurice changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #24 from Julian Maurice --- Patch rebased on master. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Julian Maurice changed: What|Removed |Added Attachment #61210|0 |1 is obsolete|| --- Comment #23 from Julian Maurice --- Created attachment 100886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=100886&action=edit Bug 13345: Allow patrons to choose format on sending basket/list by email It is already possible to download a basket(cart) or a list using different format. But by email, only iso2709 is possible. This patch adds the ability to select a format for the file attached to the email when sending the basket/list content. Test plan: 1/ At the OPAC, add some records to your basket and send it by email using different formats (RIS, BibTeX, MARC and the CSV profiles defined). 2/ At the OPAC, add some records to a list and send it by email using the different formats. 3/ Redo step 1 at the intranet 4/ Redo step 2 at the intranet Note that subtitles are not displayed in all these cases. Note for QA: This patch refactors 3 main things: 1/ Template side: the dropdown list to select the format is now in an include file (indeed, this list is used in 4 templates, this will make easier further changes). The include files are named 'download-export-available-formats.inc', feel free to suggest something better. The are used in: [opac-]sendbasket.tt, [opac-]sendshelf.tt, [opac-]downloadbasket.tt and [opac-]downloadshelf.tt. 2/ Build records data and the records file This job was done in 4 scripts: - opac/opac-sendbasket.pl - opac/opac-sendshelf.pl - basket/sendbasket.pl - virtualshelves/sendshelf.pl Now it's done in C4::Biblio::BuildBiblioDataForExport and tests are provided in t/db_dependent/Biblio/BuildBiblioDataForExport.t Not that a similar job is done in [opac-]downloadcart.pl and [opac-]downloadshelf.pl 3/ Build the subject and body of the email sent Same as before, the job was done at the same places. Now it's done in Koha::Email->fill_body_for_sending (feel free to suggestion a better name) and tests are provided in t/Koha_Email.t Sponsored-by: Mines Paristech Signed-off-by: Nicole C. Engard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Eric Phetteplace changed: What|Removed |Added CC||ephettepl...@cca.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 --- Comment #22 from Jonathan Druart --- (In reply to Marcel de Rooy from comment #21) > Can't locate object method "biblionumber" via package "41" (perhaps you > forgot to load "41"?) at > /usr/share/koha/masterclone/virtualshelves/sendshelf.pl line 76 > > Both opac-sendshelf and virtualshelves/sendshelf.pl contain this statement: > my $biblionumber = $content->biblionumber->biblionumber; > Is not correct. Because of bug 17094. About the test failures, I guess we will adjust the tests as it is certainly not this patch that make them fail, but it looks like a Koha regression then. I am pretty sure the tests passed when I wrote them. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #21 from Marcel de Rooy --- Can't locate object method "biblionumber" via package "41" (perhaps you forgot to load "41"?) at /usr/share/koha/masterclone/virtualshelves/sendshelf.pl line 76 Both opac-sendshelf and virtualshelves/sendshelf.pl contain this statement: my $biblionumber = $content->biblionumber->biblionumber; Is not correct. Also please add your signoff to the original patch. And/or add follow-ups. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345
--- Comment #20 from Marcel de Rooy ---
# Subtest: bibtex
1..1
not ok 1
# Failed test at t/db_dependent/Biblio/BuildBiblioDataForExport.t line
77.
# got: '@book{1945,
# author = {Knuth, Donald Ervin},
# title = {The art of computer programming}
# }
# '
# expected: '@book{1945,
# author = {Knuth, Donald Ervin},
# title = {The art of computer programming}
# }
# '
# Looks like you failed 1 test of 1.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 --- Comment #19 from Marcel de Rooy --- # Subtest: ris 1..1 Use of uninitialized value in numeric ne (!=) at /usr/share/koha/masterclone/C4/Ris.pm line 834. Use of uninitialized value in numeric ne (!=) at /usr/share/koha/masterclone/C4/Ris.pm line 834. not ok 1 # Failed test at t/db_dependent/Biblio/BuildBiblioDataForExport.t line 68. # got: 'TY - BOOK # AU - Knuth,Donald Ervin # TI - The art of computer programming # KW - Computer programming # KW - Computer algorithms # ER - # ' # expected: 'TY - BOOK # AU - Knuth, Donald Ervin # TI - The art of computer programming # KW - Computer programming # KW - Computer algorithms # ER - # ' # Looks like you failed 1 test of 1. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 --- Comment #18 from Marcel de Rooy --- # Subtest: iso2709 1..7 ok 1 - BuildBiblioDataForExport should return a correct records file in iso2709 ok 2 ok 3 - 499 and 462 ok 4 ok 5 - 1 item ok 6 - 0 author ok 7 - bibionumber is correct Please add test descriptions -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Marcel de Rooy changed: What|Removed |Added Attachment #56499|0 |1 is obsolete|| --- Comment #17 from Marcel de Rooy --- Created attachment 61210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=61210&action=edit Bug 13345: Allow patrons to choose format on sending basket/list by email It is already possible to download a basket(cart) or a list using different format. But by email, only iso2709 is possible. This patch adds the ability to select a format for the file attached to the email when sending the basket/list content. Test plan: 1/ At the OPAC, add some records to your basket and send it by email using different formats (RIS, BibTeX, MARC and the CSV profiles defined). 2/ At the OPAC, add some records to a list and send it by email using the different formats. 3/ Redo step 1 at the intranet 4/ Redo step 2 at the intranet Not that subtitles are not displayed in all these cases. Note for QA: This patch refactors 3 main things: 1/ Template side: the dropdown list to select the format is now in an include file (indeed, this list is used in 4 templates, this will make easier further changes). The include files are named 'download-export-available-formats.inc', feel free to suggest something better. The are used in: [opac-]sendbasket.tt, [opac-]sendshelf.tt, [opac-]downloadbasket.tt and [opac-]downloadshelf.tt. 2/ Build records data and the records file This job was done in 4 scripts: - opac/opac-sendbasket.pl - opac/opac-sendshelf.pl - basket/sendbasket.pl - virtualshelves/sendshelf.pl Now it's done in C4::Biblio::BuildBiblioDataForExport and tests are provided in t/db_dependent/Biblio/BuildBiblioDataForExport.t Not that a similar job is done in [opac-]downloadcart.pl and [opac-]downloadshelf.pl 3/ Build the subject and body of the email sent Same as before, the job was done at the same places. Now it's done in Koha::Email->fill_body_for_sending (feel free to suggestion a better name) and tests are provided in t/Koha_Email.t Sponsored-by: Mines Paristech Signed-off-by: Nicole C. Engard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Nicole C. Engard changed: What|Removed |Added CC|neng...@gmail.com | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Julian Maurice changed: What|Removed |Added Attachment #47297|0 |1 is obsolete|| --- Comment #16 from Julian Maurice --- Created attachment 56499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56499&action=edit Bug 13345: Allow patrons to choose format on sending basket/list by email It is already possible to download a basket(cart) or a list using different format. But by email, only iso2709 is possible. This patch adds the ability to select a format for the file attached to the email when sending the basket/list content. Test plan: 1/ At the OPAC, add some records to your basket and send it by email using different formats (RIS, BibTeX, MARC and the CSV profiles defined). 2/ At the OPAC, add some records to a list and send it by email using the different formats. 3/ Redo step 1 at the intranet 4/ Redo step 2 at the intranet Not that subtitles are not displayed in all these cases. Note for QA: This patch refactors 3 main things: 1/ Template side: the dropdown list to select the format is now in an include file (indeed, this list is used in 4 templates, this will make easier further changes). The include files are named 'download-export-available-formats.inc', feel free to suggest something better. The are used in: [opac-]sendbasket.tt, [opac-]sendshelf.tt, [opac-]downloadbasket.tt and [opac-]downloadshelf.tt. 2/ Build records data and the records file This job was done in 4 scripts: - opac/opac-sendbasket.pl - opac/opac-sendshelf.pl - basket/sendbasket.pl - virtualshelves/sendshelf.pl Now it's done in C4::Biblio::BuildBiblioDataForExport and tests are provided in t/db_dependent/Biblio/BuildBiblioDataForExport.t Not that a similar job is done in [opac-]downloadcart.pl and [opac-]downloadshelf.pl 3/ Build the subject and body of the email sent Same as before, the job was done at the same places. Now it's done in Koha::Email->fill_body_for_sending (feel free to suggestion a better name) and tests are provided in t/Koha_Email.t Sponsored-by: Mines Paristech Signed-off-by: Nicole C. Engard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Julian Maurice changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #15 from Katrin Fischer --- I am sorry, conflicting again: CONFLICT (content): Merge conflict in virtualshelves/sendshelf.pl Auto-merging opac/opac-sendshelf.pl CONFLICT (content): Merge conflict in opac/opac-sendshelf.pl Auto-merging opac/opac-sendbasket.pl CONFLICT (content): Merge conflict in opac/opac-sendbasket.pl Auto-merging opac/opac-downloadshelf.pl Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendbasket.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/basket/sendbasket.tt Auto-merging basket/sendbasket.pl CONFLICT (content): Merge conflict in basket/sendbasket.pl Will return to this asap when rebased. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Alex Arnaud changed: What|Removed |Added CC||alex.arn...@biblibre.com Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Patch doesn't apply CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Julian Maurice changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Julian Maurice changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff --- Comment #14 from Julian Maurice --- Patch rebased on master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Julian Maurice changed: What|Removed |Added Attachment #38032|0 |1 is obsolete|| --- Comment #13 from Julian Maurice --- Created attachment 47297 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47297&action=edit Bug 13345: Allow patrons to choose format on sending basket/list by email It is already possible to download a basket(cart) or a list using different format. But by email, only iso2709 is possible. This patch adds the ability to select a format for the file attached to the email when sending the basket/list content. Test plan: 1/ At the OPAC, add some records to your basket and send it by email using different formats (RIS, BibTeX, MARC and the CSV profiles defined). 2/ At the OPAC, add some records to a list and send it by email using the different formats. 3/ Redo step 1 at the intranet 4/ Redo step 2 at the intranet Not that subtitles are not displayed in all these cases. Note for QA: This patch refactors 3 main things: 1/ Template side: the dropdown list to select the format is now in an include file (indeed, this list is used in 4 templates, this will make easier further changes). The include files are named 'download-export-available-formats.inc', feel free to suggest something better. The are used in: [opac-]sendbasket.tt, [opac-]sendshelf.tt, [opac-]downloadbasket.tt and [opac-]downloadshelf.tt. 2/ Build records data and the records file This job was done in 4 scripts: - opac/opac-sendbasket.pl - opac/opac-sendshelf.pl - basket/sendbasket.pl - virtualshelves/sendshelf.pl Now it's done in C4::Biblio::BuildBiblioDataForExport and tests are provided in t/db_dependent/Biblio/BuildBiblioDataForExport.t Not that a similar job is done in [opac-]downloadcart.pl and [opac-]downloadshelf.pl 3/ Build the subject and body of the email sent Same as before, the job was done at the same places. Now it's done in Koha::Email->fill_body_for_sending (feel free to suggestion a better name) and tests are provided in t/Koha_Email.t Some tests for BuildBiblioDataForExport can fail if bug 13360 is not pushed yet. Sponsored-by: Mines Paristech Signed-off-by: Nicole C. Engard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Sophie MEYNIEUX changed: What|Removed |Added CC||sophie.meyni...@biblibre.co ||m Assignee|claire.hernandez@biblibre.c |julian.maur...@biblibre.com |om | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Marjorie Barry-Vila changed: What|Removed |Added CC||marjorie.barry-v...@ccsr.qc ||.ca -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Jonathan Druart changed: What|Removed |Added Assignee|jonathan.dru...@bugs.koha-c |claire.hernandez@biblibre.c |ommunity.org|om -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #12 from Katrin Fischer --- Jonathan, there are some conflicts - can you please take a look and fix? Applying: Bug 13345: Allow patrons to choose format on sending basket/list by email Using index info to reconstruct a base tree... M C4/Biblio.pm M basket/basket.pl M basket/downloadcart.pl M basket/sendbasket.pl M koha-tmpl/intranet-tmpl/prog/en/modules/basket/sendbasket.tt M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-downloadcart.tt M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-downloadshelf.tt M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendbasket.tt M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendbasketform.tt M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelfform.tt M opac/opac-downloadcart.pl M opac/opac-downloadshelf.pl M opac/opac-sendbasket.pl M opac/opac-sendshelf.pl M virtualshelves/downloadshelf.pl M virtualshelves/sendshelf.pl Falling back to patching base and 3-way merge... Auto-merging virtualshelves/sendshelf.pl CONFLICT (content): Merge conflict in virtualshelves/sendshelf.pl Auto-merging virtualshelves/downloadshelf.pl Auto-merging opac/opac-sendshelf.pl CONFLICT (content): Merge conflict in opac/opac-sendshelf.pl Auto-merging opac/opac-sendbasket.pl CONFLICT (content): Merge conflict in opac/opac-sendbasket.pl Auto-merging opac/opac-downloadshelf.pl Auto-merging opac/opac-downloadcart.pl Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendshelfform.tt Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendbasketform.tt Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-sendbasket.tt Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-downloadshelf.tt Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-downloadcart.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/basket/sendbasket.tt Auto-merging basket/sendbasket.pl CONFLICT (content): Merge conflict in basket/sendbasket.pl Auto-merging basket/downloadcart.pl Auto-merging basket/basket.pl Auto-merging C4/Biblio.pm Failed to merge in the changes. Patch failed at 0001 Bug 13345: Allow patrons to choose format on sending basket/list by email The copy of the patch that failed is found in: /home/katrin/kohaclone/.git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Bug 13345 depends on bug 11944, which changed state. Bug 11944 Summary: Cleanup Koha UTF-8 http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11944 What|Removed |Added Status|Pushed to Master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Katrin Fischer changed: What|Removed |Added QA Contact|m.de.r...@rijksmuseum.nl|testo...@bugs.koha-communit ||y.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 --- Comment #11 from Marcel de Rooy --- (In reply to Katrin Fischer from comment #10) > Hi Marcel, you started on this a while ago - do you want to continue or is > it ok to change the QA contact? Patches apply now. Go ahead if you want to QA this one.. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de --- Comment #10 from Katrin Fischer --- Hi Marcel, you started on this a while ago - do you want to continue or is it ok to change the QA contact? Patches apply now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Jonathan Druart changed: What|Removed |Added Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Jonathan Druart changed: What|Removed |Added Attachment #36270|0 |1 is obsolete|| --- Comment #9 from Jonathan Druart --- Created attachment 38032 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=38032&action=edit Bug 13345: Allow patrons to choose format on sending basket/list by email Conflict with bug 13695 fixed. Now it's also possible to send basket/cart using the ISBD format -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 M. de Rooy changed: What|Removed |Added Status|Signed Off |Patch doesn't apply --- Comment #8 from M. de Rooy --- CONFLICT (content): Merge conflict in opac/opac-sendbasket.pl CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-downloadshelf.tt CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-downloadcart.tt CONFLICT (content): Merge conflict in basket/sendbasket.pl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 M. de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | --- Comment #7 from M. de Rooy --- QA: Looking at this one now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Matthias Meusburger changed: What|Removed |Added CC||matthias.meusburger@biblibr ||e.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Nicole C. Engard changed: What|Removed |Added Attachment #35509|0 |1 is obsolete|| CC||neng...@gmail.com --- Comment #6 from Nicole C. Engard --- Created attachment 36270 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36270&action=edit [SIGNED-OFF] Bug 13345: Allow patrons to choose format on sending basket/list by email -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Nicole C. Engard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Jonathan Druart changed: What|Removed |Added Depends on|13596 | --- Comment #5 from Jonathan Druart --- Last patch fixes conflicts with bug 13510. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Jonathan Druart changed: What|Removed |Added Attachment #34392|0 |1 is obsolete|| --- Comment #4 from Jonathan Druart --- Created attachment 35509 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35509&action=edit Bug 13345: Allow patrons to choose format on sending basket/list by email -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Martin Renvoize changed: What|Removed |Added Depends on||13596 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Jonathan Druart changed: What|Removed |Added See Also|http://bugs.koha-community. | |org/bugzilla3/show_bug.cgi? | |id=13343| Depends on||13343 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Jonathan Druart changed: What|Removed |Added Attachment #34013|0 |1 is obsolete|| --- Comment #3 from Jonathan Druart --- Created attachment 34392 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34392&action=edit Bug 13345: Allow patrons to choose format on sending basket/list by email -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Paul Poulain changed: What|Removed |Added CC||paul.poul...@biblibre.com --- Comment #2 from Paul Poulain --- Jonathan: can you add a "Sponsored-by: Mines Paristech" in the patch ? thus, MPT will appear in the credits -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Jonathan Druart changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Jonathan Druart changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=13343, ||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=13360 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 --- Comment #1 from Jonathan Druart --- Created attachment 34013 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=34013&action=edit Bug 13345: Allow patrons to choose format on sending basket/list by email It is already possible to download a basket(cart) or a list using different format. But by email, only iso2709 is possible. This patch adds the ability to select a format for the file attached to the email when sending the basket/list content. Test plan: 1/ At the OPAC, add some records to your basket and send it by email using different formats (RIS, BibTeX, MARC and the CSV profiles defined). 2/ At the OPAC, add some records to a list and send it by email using the different formats. 3/ Redo step 1 at the intranet 4/ Redo step 2 at the intranet Not that subtitles are not displayed in all these cases. Note for QA: This patch refactors 3 main things: 1/ Template side: the dropdown list to select the format is now in an include file (indeed, this list is used in 4 templates, this will make easier further changes). The include files are named 'download-export-available-formats.inc', feel free to suggest something better. The are used in: [opac-]sendbasket.tt, [opac-]sendshelf.tt, [opac-]downloadbasket.tt and [opac-]downloadshelf.tt. 2/ Build records data and the records file This job was done in 4 scripts: - opac/opac-sendbasket.pl - opac/opac-sendshelf.pl - basket/sendbasket.pl - virtualshelves/sendshelf.pl Now it's done in C4::Biblio::BuildBiblioDataForExport and tests are provided in t/db_dependent/Biblio/BuildBiblioDataForExport.t Not that a similar job is done in [opac-]downloadcart.pl and [opac-]downloadshelf.pl 3/ Build the subject and body of the email sent Same as before, the job was done at the same places. Now it's done in Koha::Email->fill_body_for_sending (feel free to suggestion a better name) and tests are provided in t/Koha_Email.t Some tests for BuildBiblioDataForExport can fail if bug 13360 is not pushed yet. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Jonathan Druart changed: What|Removed |Added Status|NEW |ASSIGNED Assignee|oleon...@myacpl.org |jonathan.dru...@biblibre.co ||m -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13345] Choose the format when sending a basket/list by email
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13345 Jonathan Druart changed: What|Removed |Added Depends on||11944 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
