[Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452 Mason James changed: What|Removed |Added CC||m...@kohaaloha.com --- Comment #28 from Mason James --- Pushed to 16.05.x, for 16.05.15 release -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452 --- Comment #27 from Katrin Fischer --- These patches have been pushed to 16.11.x and will be in 16.11.10. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452 --- Comment #26 from Fridolin SOMERS --- (In reply to Fridolin SOMERS from comment #25) > Pushed to 17.05.x, will be in 17.05.01 Oh 17.05.02 now -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable --- Comment #25 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.01 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452 Kyle M Hall changed: What|Removed |Added Status|Signed Off |Passed QA Attachment #63322|0 |1 is obsolete|| Attachment #63323|0 |1 is obsolete|| Attachment #63324|0 |1 is obsolete|| Attachment #64304|0 |1 is obsolete|| Attachment #64305|0 |1 is obsolete|| Attachment #64306|0 |1 is obsolete|| Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #18 from Kyle M Hall --- Created attachment 64304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64304&action=edit Bug 13452: 'Average loan time' report to obey item-level_itypes preference Fixes the 'Average loan time' report so that the system preference setting item-level_itypes is taken into account. Before the patch, the report was always using the biblio level itemtype. With the patch, it will depend on the pref setting. To test: - Run various reports, compare results with both possible pref settings - Try limiting your search in various ways, especially on a specific itemtype - Make sure you switch checkboxes in testing, using itemtype as the row or as the column Notes: - Filtering on a specific itemtype on master was not working if the itemtype was chosen as column. The patch should fix that. - Fixes headings and breadcrumbs so that the name of the report is the same as on the reports start page Signed-off-by: Indranil Das Gupta (L2C2 Technologies) Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall --- Comment #19 from Kyle M Hall --- Created attachment 64305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64305&action=edit Bug 13452: Fix for plack Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall --- Comment #20 from Kyle M Hall --- Created attachment 64306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64306&action=edit Bug 13452: 'Average loan time' report to obey item-level_itypes preference Fixes the 'Average loan time' report so that the system preference setting item-level_itypes is taken into account. Before the patch, the report was always using the biblio level itemtype. With the patch, it will depend on the pref setting. To test: - Run various reports, compare results with both possible pref settings - Try limiting your search in various ways, especially on a specific itemtype - Make sure you switch checkboxes in testing, using itemtype as the row or as the column Notes: - Filtering on a specific itemtype on master was not working if the itemtype was chosen as column. The patch should fix that. - Fixes headings and breadcrumbs so that the name of the report is the same as on the reports start page Signed-off-by: Indranil Das Gupta (L2C2 Technologies) Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall --- Comment #21 from Kyle M Hall --- Created attachment 64307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64307&action=edit Bug 13452: 'Average loan time' report to obey item-level_itypes preference Fixes the 'Average loan time' report so that the system preference setting item-level_itypes is taken into account. Before the patch, the report was always using the biblio level itemtype. With the patch, it will depend on the pref setting. To test: - Run various reports, compare results with both possible pref settings - Try limiting your search in various ways, especially on a specific itemtype - Make sure you switch checkboxes in testing, using itemtype as the row or as the column Notes: - Filtering on a specific itemtype on master was not working if the itemtype was chosen as column. The patch should fix that. - Fixes headings and breadcrumbs so that the name of the report is the same as on the reports start page Signed-off-by: Indranil Das Gupta (L2C2 Technologies) Signed-off-by: Josef Moravec Signed-off-by: Kyle M Hall --- Comment #22 from Kyle M Hall --- Created attachment 64308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64308&action=edit Bug 13452: Fix obvious issues in issues_avg_stats.pl - Remove joins with issuingrules which are not needed - Fix the SQL query so that $weight is now the value of COUNT(*) instead of a timestamp - QA fix: '$column eq $itype' instead of '$column =~ $itype' (same fo
[Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl --- Comment #17 from Marcel de Rooy --- String changes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452 --- Comment #16 from Josef Moravec --- Created attachment 63324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63324&action=edit [SIGNED-OFF] Bug 13452: Fix for plack Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452 --- Comment #15 from Josef Moravec --- Created attachment 63323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63323&action=edit [SIGNED-OFF] Bug 13452: Fix obvious issues in issues_avg_stats.pl - Remove joins with issuingrules which are not needed - Fix the SQL query so that $weight is now the value of COUNT(*) instead of a timestamp - QA fix: '$column eq $itype' instead of '$column =~ $itype' (same for $line) Signed-off-by: Srdjan Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452 Josef Moravec changed: What|Removed |Added Attachment #40798|0 |1 is obsolete|| Attachment #48987|0 |1 is obsolete|| Attachment #56246|0 |1 is obsolete|| --- Comment #14 from Josef Moravec --- Created attachment 63322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63322&action=edit [SIGNED-OFF] Bug 13452: 'Average loan time' report to obey item-level_itypes preference Fixes the 'Average loan time' report so that the system preference setting item-level_itypes is taken into account. Before the patch, the report was always using the biblio level itemtype. With the patch, it will depend on the pref setting. To test: - Run various reports, compare results with both possible pref settings - Try limiting your search in various ways, especially on a specific itemtype - Make sure you switch checkboxes in testing, using itemtype as the row or as the column Notes: - Filtering on a specific itemtype on master was not working if the itemtype was chosen as column. The patch should fix that. - Fixes headings and breadcrumbs so that the name of the report is the same as on the reports start page Signed-off-by: Indranil Das Gupta (L2C2 Technologies) Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452 Josef Moravec changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452 Julian Maurice changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452 --- Comment #13 from Julian Maurice --- Created attachment 56246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56246&action=edit Bug 13452: Fix for plack -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452 Jonathan Druart changed: What|Removed |Added Assignee|katrin.fisc...@bsz-bw.de|julian.maur...@biblibre.com Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452 --- Comment #12 from Jonathan Druart --- Still the same. Actually $itype is set to undef because not defined in the same scope. If you are not using plack it should work correctly, with plack it will fail. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452 Julian Maurice changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #11 from Julian Maurice --- (In reply to Jonathan Druart from comment #10) > On reports/issues_avg_stats.pl, select row=patron category and column=item > type > > DBD::mysql::st execute failed: You have an error in your SQL syntax I tried just now and saw no errors. Generated SQL: SELECT borrowers.categorycode, items.itype, issuedate, returndate, COUNT(*) FROM `old_issues`,borrowers,biblioitems LEFT JOIN items ON (biblioitems.biblioitemnumber=items.biblioitemnumber) WHERE old_issues.itemnumber=items.itemnumber AND old_issues.borrowernumber=borrowers.borrowernumber group by borrowers.categorycode, items.itype, issuedate, returndate order by borrowers.categorycode, items.itype I tried to change the value of item-level_itypes syspref, but it works as well. Could you give it another try ? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452 Jonathan Druart changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #10 from Jonathan Druart --- On reports/issues_avg_stats.pl, select row=patron category and column=item type DBD::mysql::st execute failed: You have an error in your SQL syntax -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452 Srdjan Jankovic changed: What|Removed |Added Attachment #43053|0 |1 is obsolete|| --- Comment #9 from Srdjan Jankovic --- Created attachment 48987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48987&action=edit Bug 13452: Fix obvious issues in issues_avg_stats.pl - Remove joins with issuingrules which are not needed - Fix the SQL query so that $weight is now the value of COUNT(*) instead of a timestamp - QA fix: '$column eq $itype' instead of '$column =~ $itype' (same for $line) Signed-off-by: Srdjan -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452 Srdjan Jankovic changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452 I'm just a bot changed: What|Removed |Added CC||git...@bugs.koha-community. ||org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452 Julian Maurice changed: What|Removed |Added Status|Failed QA |Needs Signoff CC||julian.maur...@biblibre.com --- Comment #8 from Julian Maurice --- QA fix #2 not needed due to the removal of joins QA fix #3: the whole 'if' block is unnecessary, and wrong, since there is no placeholders in query. Replaced by a simple $sth2->execute; -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452 --- Comment #7 from Julian Maurice --- Created attachment 43053 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=43053&action=edit Bug 13452: Fix obvious issues in issues_avg_stats.pl - Remove joins with issuingrules which are not needed - Fix the SQL query so that $weight is now the value of COUNT(*) instead of a timestamp - QA fix: '$column eq $itype' instead of '$column =~ $itype' (same for $line) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452
Jonathan Druart changed:
What|Removed |Added
CC||jonathan.dru...@bugs.koha-c
||ommunity.org
Status|Signed Off |Failed QA
--- Comment #6 from Jonathan Druart
---
I won't use the splinter review, it will be confusing.
1/ There are 2 different ways to do the same thing:
247 if ( $line=~/itemtype/ ) { $line = $itype; }
257 $linefilter[0] = @$filters[9] if ($line =~ /itemtype/ ) ;
and
263 if ( $column=~/itemtype/ ) { $column = $itype; }
274 $colfilter[0] = @$filters[9] if ($column =~ $itype ) ;
2/ Please use sql placeholders for "issuingrules.itemtype=$itype" (x3)
3/
if (( @colfilter ) and ($colfilter[1])){
$sth2->execute("'".$colfilter[0]."'","'".$colfilter[1]."'");
} elsif ($colfilter[0]) {
$sth2->execute;
} else {
$sth2->execute;
}
Could be :
if (( @colfilter ) and ($colfilter[1])){
$sth2->execute("'".$colfilter[0]."'","'".$colfilter[1]."'");
} else {
$sth2->execute;
}
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452 Indranil Das Gupta changed: What|Removed |Added CC||indr...@gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452 Indranil Das Gupta changed: What|Removed |Added Attachment #40004|0 |1 is obsolete|| --- Comment #5 from Indranil Das Gupta --- Created attachment 40798 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40798&action=edit Bug 13452: 'Average loan time' report to obey item-level_itypes preference Fixes the 'Average loan time' report so that the system preference setting item-level_itypes is taken into account. Before the patch, the report was always using the biblio level itemtype. With the patch, it will depend on the pref setting. To test: - Run various reports, compare results with both possible pref settings - Try limiting your search in various ways, especially on a specific itemtype - Make sure you switch checkboxes in testing, using itemtype as the row or as the column Notes: - Filtering on a specific itemtype on master was not working if the itemtype was chosen as column. The patch should fix that. - Fixes headings and breadcrumbs so that the name of the report is the same as on the reports start page Signed-off-by: Indranil Das Gupta (L2C2 Technologies) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452
--- Comment #4 from Katrin Fischer ---
Comment on attachment 40004
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40004
Bug 13452: 'Average loan time' report to obey item-level_itypes preference
Review of attachment 40004:
-->
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13452&attachment=40004)
-
::: reports/issues_avg_stats.pl
@@ +407,4 @@
> if (( @colfilter ) and ($colfilter[1])){
> $sth2->execute("'".$colfilter[0]."'","'".$colfilter[1]."'");
> } elsif ($colfilter[0]) {
> +$sth2->execute;
Because without this change there was always an error in the logs - without any
of the other changes of the patch. I needed to change it to get it working
first... that's how I remember. The answer should be further above in the
code... this whole script should be rewritten to create the SQL in cleaner
ways.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452
--- Comment #3 from M. Tompsett ---
Comment on attachment 40004
--> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40004
Bug 13452: 'Average loan time' report to obey item-level_itypes preference
Review of attachment 40004:
-->
(http://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=13452&attachment=40004)
-
::: reports/issues_avg_stats.pl
@@ +407,4 @@
> if (( @colfilter ) and ($colfilter[1])){
> $sth2->execute("'".$colfilter[0]."'","'".$colfilter[1]."'");
> } elsif ($colfilter[0]) {
> +$sth2->execute;
Perhaps a shallow reading of the changes doesn't make this obvious, but why did
this change?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452 Amit changed: What|Removed |Added CC||amitddng...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452 Katrin Fischer changed: What|Removed |Added Attachment #40003|0 |1 is obsolete|| --- Comment #2 from Katrin Fischer --- Created attachment 40004 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40004&action=edit Bug 13452: 'Average loan time' report to obey item-level_itypes preference Fixes the 'Average loan time' report so that the system preference setting item-level_itypes is taken into account. Before the patch, the report was always using the biblio level itemtype. With the patch, it will depend on the pref setting. To test: - Run various reports, compare results with both possible pref settings - Try limiting your search in various ways, especially on a specific itemtype - Make sure you switch checkboxes in testing, using itemtype as the row or as the column Notes: - Filtering on a specific itemtype on master was not working if the itemtype was chosen as column. The patch should fix that. - Fixes headings and breadcrumbs so that the name of the report is the same as on the reports start page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de Severity|minor |normal Assignee|gmcha...@gmail.com |katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452 --- Comment #1 from Katrin Fischer --- Created attachment 40003 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=40003&action=edit Bug 13452: 'Average loan time' report to obey item-level_itypes preference Fixes the 'Average loan time' report so that the system preference setting item-level_itypes is taken into account. Before the patch, the report was always using the biblio level itemtype. With the patch, it will depend on the pref setting. To test: - Run various reports, compare results with both possible pref settings - Try limiting your search in various ways, especially on a specific itemtype - Make sure you switch checkboxes in testing, using itemtype as the row or as the column Notes: - Filtering on a specific itemtype does not work without the patch as it fixes a bug there. - Fixes headings and breadcrumbs so that the name of the report is the same as on the reports start page -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13452] Average checkout report always uses biblioitems.itemtype
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13452 Katrin Fischer changed: What|Removed |Added Status|NEW |Needs Signoff Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
