[Koha-bugs] [Bug 13630] Angular-based circulation client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 Bug 13630 depends on bug 13563, which changed state. Bug 13563 Summary: AngularJS https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13563 What|Removed |Added Status|BLOCKED |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13630] Angular-based circulation client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 --- Comment #20 from Katrin Fischer --- Thx for explaining! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13630] Angular-based circulation client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 --- Comment #19 from David Cook --- (In reply to Kyle M Hall from comment #18) > (In reply to Katrin Fischer from comment #17) > > Out of interest, dead for Koha or in general? > > In general. Angular was renamed AngularJs and a new project is now named > Angular which was a complete rewrite and is incompatible with the original > Angular. More context: AngularJS (now only supported until 2021): https://github.com/angular/angular.js Move from AngularJS to Angular: https://blog.angular.io/stable-angularjs-and-long-term-support-7e077635ee9c New Angular (Typescript-based complete-rewrite of AngularJS): https://github.com/angular/angular -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13630] Angular-based circulation client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 --- Comment #18 from Kyle M Hall --- (In reply to Katrin Fischer from comment #17) > Out of interest, dead for Koha or in general? In general. Angular was renamed AngularJs and a new project is now named Angular which was a complete rewrite and is incompatible with the original Angular. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13630] Angular-based circulation client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 --- Comment #17 from Katrin Fischer --- Out of interest, dead for Koha or in general? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13630] Angular-based circulation client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 Kyle M Hall changed: What|Removed |Added Resolution|--- |WONTFIX Status|Patch doesn't apply |RESOLVED --- Comment #16 from Kyle M Hall --- Closing this bug, AngularJS, which this is based on, is a dead project at this point. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13630] Angular-based circulation client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 Nicole C. Engard changed: What|Removed |Added CC|neng...@gmail.com | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13630] Angular-based circulation client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 Nicole C. Engard changed: What|Removed |Added Assignee|jwea...@bywatersolutions.co |k...@bywatersolutions.com |m | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13630] Angular-based circulation client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 Nicole C. Engard changed: What|Removed |Added CC||a...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13630] Angular-based circulation client
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 Bug 13630 depends on bug 12272, which changed state. Bug 12272 Summary: Refactor C4::Service API into Koha::Service class https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12272 What|Removed |Added Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13630] Angular-based circulation client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 Nick Clemens changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply CC||n...@bywatersolutions.com --- Comment #15 from Nick Clemens --- fatal: sha1 information is lacking or useless (Koha/Service.pm). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13630] Angular-based circulation client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 Zeno Tajoli changed: What|Removed |Added CC|z.taj...@cineca.it | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13630] Angular-based circulation client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 Zeno Tajoli changed: What|Removed |Added Patch complexity|--- |Large patch CC||z.taj...@cineca.it --- Comment #14 from Zeno Tajoli --- Patch complexity is 'Large' because this change has many architectural connections -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13630] Angular-based circulation client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 Nicole Engard (ByWater) changed: What|Removed |Added CC||nic...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13630] Angular-based circulation client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 Katrin Fischer changed: What|Removed |Added Assignee|koha-b...@lists.koha-commun |jwea...@bywatersolutions.co |ity.org |m CC||katrin.fisc...@bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13630] Angular-based circulation client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 Viktor Sarge changed: What|Removed |Added CC||viktor.sarge@regionhalland. ||se --- Comment #13 from Viktor Sarge --- Got this problem both in local git and sandbox: fatal: sha1 information is lacking or useless (Koha/Service.pm). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 13630 - Basic Angular circulation client It might be an easy problem so I won't change the status of the bug, but it's also a problem that means I can't test it. Any updates welcome since I'm curious about testing this to see if it gives a performance boost :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13630] Angular-based circulation client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 Mike changed: What|Removed |Added CC||blac...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13630] Angular-based circulation client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 --- Comment #12 from Nicole C. Engard --- Changed to 'needs signoff' since Jesse just attached a patch. Feel free to change back if that was inaccurate. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13630] Angular-based circulation client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 Nicole C. Engard changed: What|Removed |Added CC||neng...@gmail.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13630] Angular-based circulation client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 --- Comment #11 from Jesse Weaver --- Created attachment 36262 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36262&action=edit Bug 13630 - Basic Angular circulation client -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13630] Angular-based circulation client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 Tom Misilo changed: What|Removed |Added CC||misi...@fit.edu -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13630] Angular-based circulation client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 --- Comment #10 from Jesse Weaver --- (In reply to Jonathan Druart from comment #9) > This bug depends on bug 12272 and bug 13563, does the enh can be tested > checking out the branch on github? > > Testing with the angular-submit branch: > The checkout table looks broken and there are no action buttons > (circ/checkout.pl), that means this patch adds a 3rd place where this table > is defined. Maybe it could be good to refactor some code here. > > Still got the error 500. Will get you a detailed test plan. We were working on fixing some issues with the checkouts datatable, but any permanent fix will likely depend on Kyle. Yes, the branch should be testable simply by checking out the Github branch. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13630] Angular-based circulation client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 --- Comment #9 from Jonathan Druart --- This bug depends on bug 12272 and bug 13563, does the enh can be tested checking out the branch on github? Testing with the angular-submit branch: The checkout table looks broken and there are no action buttons (circ/checkout.pl), that means this patch adds a 3rd place where this table is defined. Maybe it could be good to refactor some code here. Still got the error 500. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13630] Angular-based circulation client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 --- Comment #8 from Jonathan Druart --- Please provide a detailed test plan. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13630] Angular-based circulation client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 --- Comment #7 from Jesse Weaver --- (In reply to Jonathan Druart from comment #6) > Brendan gave me the angular-circ url yesterday, but > https://github.com/pianohacker/koha/tree/angular-submit seems to be more > recent. > > Jesse, could you confirm where is the work related to this bug report ? Ah, yes, sorry. The angular-submit branch is more recent. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13630] Angular-based circulation client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 Jonathan Druart changed: What|Removed |Added See Also||http://bugs.koha-community. ||org/bugzilla3/show_bug.cgi? ||id=11759 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13630] Angular-based circulation client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 --- Comment #6 from Jonathan Druart --- Brendan gave me the angular-circ url yesterday, but https://github.com/pianohacker/koha/tree/angular-submit seems to be more recent. Jesse, could you confirm where is the work related to this bug report ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13630] Angular-based circulation client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630
--- Comment #5 from Jonathan Druart ---
1/ 51 files changed, 5515 insertions(+), 1722 deletions(-)
(11703 in it)
=> Should be split
2/ based on 3.16, need a rebase
3/ Squash please, ~40 commits
4/ Decent commit messages, with test plan
5/ Without test plan I had to git grep the code to know where circ/checkout.pl
was called
6/ on circ/circulation.pl, More > Switch checkout client
Enter a barcode, click on the Check out button, nothing append:
500 Internal Server Error
in koha logs:
patrons: Can't use string ("1") as a HASH ref while "strict refs" in use at
/home/koha/src/C4/Circulation.pm line 747.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13630] Angular-based circulation client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 Jonathan Druart changed: What|Removed |Added CC||jonathan.dru...@biblibre.co ||m --- Comment #4 from Jonathan Druart --- https://github.com/pianohacker/koha/tree/angular-circ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13630] Angular-based circulation client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 Heather Braum changed: What|Removed |Added CC||hbr...@nekls.org -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13630] Angular-based circulation client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 --- Comment #3 from Martin Renvoize --- This is a pretty massive piece of work me thinks... shall we get some team work going Jesse... are you following any style guidelines for your angular use? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13630] Angular-based circulation client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 David Cook changed: What|Removed |Added CC||dc...@prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13630] Angular-based circulation client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europe ||.com --- Comment #2 from Martin Renvoize --- Awesome... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13630] Angular-based circulation client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #1 from Tomás Cohen Arazi --- Git repo? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 13630] Angular-based circulation client
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 Jesse Weaver changed: What|Removed |Added Depends on||13563, 12272 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
