[Koha-bugs] [Bug 13676] OpacSuppression description says 'items' but means 'records'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #15 from Jonathan Druart  
---
Patch pushed to master for 18.05, congrats Sherryn for your first patch in!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13676] OpacSuppression description says 'items' but means 'records'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

--- Comment #14 from Chris Cormack  ---
Hi Jonathan

It is Mak

Thank you

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13676] OpacSuppression description says 'items' but means 'records'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #13 from Jonathan Druart  
---
Sherryn, you did not specify your lastname in the commit message, is it
expected?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13676] OpacSuppression description says 'items' but means 'records'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

Josef Moravec  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=19833

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13676] OpacSuppression description says 'items' but means 'records'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

Josef Moravec  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13676] OpacSuppression description says 'items' but means 'records'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

Josef Moravec  changed:

   What|Removed |Added

  Attachment #69863|0   |1
is obsolete||

--- Comment #12 from Josef Moravec  ---
Created attachment 69900
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69900=edit
Bug: 13676: Fixing the OpacSuppression description

To Test
1/ Search for OpacSuppression system preference
2/ Notice that it says "Items marked as suppressed from OPAC search
results
3/ Noticre also that addresses is spelt wrong
4/ Apply patch
5/ Refresh the page, notice addresses is fixed and items has become
biblios

Signed-off-by: Katrin Fischer 

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13676] OpacSuppression description says 'items' but means 'records'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com
   Assignee|ve...@veron.ch  |sher...@catalyst.net.nz
 QA Contact|testo...@bugs.koha-communit |josef.mora...@gmail.com
   |y.org   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13676] OpacSuppression description says 'items' but means 'records'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

--- Comment #11 from Katrin Fischer  ---
Thx for your first patch Sherryn!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13676] OpacSuppression description says 'items' but means 'records'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13676] OpacSuppression description says 'items' but means 'records'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #69862|0   |1
is obsolete||

--- Comment #10 from Katrin Fischer  ---
Created attachment 69863
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69863=edit
Bug: 13676: Fixing the OpacSuppression description

To Test
1/ Search for OpacSuppression system preference
2/ Notice that it says "Items marked as suppressed from OPAC search
results
3/ Noticre also that addresses is spelt wrong
4/ Apply patch
5/ Refresh the page, notice addresses is fixed and items has become
biblios

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13676] OpacSuppression description says 'items' but means 'records'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

Chris Cormack  changed:

   What|Removed |Added

  Attachment #36164|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13676] OpacSuppression description says 'items' but means 'records'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

sherryn  changed:

   What|Removed |Added

 CC||sher...@catalyst.net.nz
 Status|REOPENED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13676] OpacSuppression description says 'items' but means 'records'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

--- Comment #9 from sherryn  ---
Created attachment 69862
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=69862=edit
Bug: 13676: Fixing the OpacSuppression description

To Test
1/ Search for OpacSuppression system preference
2/ Notice that it says "Items marked as suppressed from OPAC search
results
3/ Noticre also that addresses is spelt wrong
4/ Apply patch
5/ Refresh the page, notice addresses is fixed and items has become
biblios

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13676] OpacSuppression description says 'items' but means 'records'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

Katrin Fischer  changed:

   What|Removed |Added

 CC||claire_grav...@hotmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13676] OpacSuppression description says 'items' but means 'records'

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

Jens Weber  changed:

   What|Removed |Added

 CC||jens.we...@phsh.ch
 Status|CLOSED  |REOPENED
 Resolution|FIXED   |---
   Patch complexity|Trivial patch   |String patch

--- Comment #8 from Jens Weber  ---
I agree with Nicole that this has to be changed in the preference description
just the same!
(I hope it is okay I didn't file a new bug on this ...)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13676] OpacSuppression description says 'items' but means 'records'

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

Chris Cormack  changed:

   What|Removed |Added

   Keywords|Academy, rel_3_16_candidate |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13676] OpacSuppression description says 'items' but means 'records'

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

Nicole C. Engard neng...@gmail.com changed:

   What|Removed |Added

 CC||neng...@gmail.com

--- Comment #7 from Nicole C. Engard neng...@gmail.com ---
Shouldn't we then change the beginning of the preference description:

___ items marked as suppressed from OPAC search results. 

should be

___ biblios marked as suppressed from OPAC search results.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13676] OpacSuppression description says 'items' but means 'records'

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

Mason James m...@kohaaloha.com changed:

   What|Removed |Added

   Keywords||rel_3_16_candidate
 CC||m...@kohaaloha.com

--- Comment #6 from Mason James m...@kohaaloha.com ---
Contains string changes, holding for 3.16.10

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13676] OpacSuppression description says 'items' but means 'records'

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

Chris Cormack ch...@bigballofwax.co.nz changed:

   What|Removed |Added

 CC||ch...@bigballofwax.co.nz
 Status|Pushed to Master|Pushed to Stable

--- Comment #5 from Chris Cormack ch...@bigballofwax.co.nz ---
Pushed to 3.18.x will be in 3.18.5

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13676] OpacSuppression description says 'items' but means 'records'

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

Tomás Cohen Arazi tomasco...@gmail.com changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||tomasco...@gmail.com

--- Comment #4 from Tomás Cohen Arazi tomasco...@gmail.com ---
Patch pushed to master.

Thanks Marc!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13676] OpacSuppression description says 'items' but means 'records'

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

  Attachment #36133|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart jonathan.dru...@biblibre.com ---
Created attachment 36164
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36164action=edit
Bug 13676 - OpacSuppression description says 'items' but means 'records'

This patch changes the wording for the OpacSuppression preference description.

Without patch:
... items marked as suppressed from OPAC search results. Note that you must
have the codeSuppress/code index set up in Zebra and at least one
suppressed item, or your searches will be broken. ...

With patch:
... items marked as suppressed from OPAC search results. Note that you must
have the codeSuppress/code index set up in Zebra and at least one
suppressed biblio record, or your searches will be broken. ...

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

Signed-off-by: Jonathan Druart jonathan.dru...@biblibre.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13676] OpacSuppression description says 'items' but means 'records'

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

Jonathan Druart jonathan.dru...@biblibre.com changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13676] OpacSuppression description says 'items' but means 'records'

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

Brendan Gallagher bren...@bywatersolutions.com changed:

   What|Removed |Added

  Attachment #35812|0   |1
is obsolete||

--- Comment #2 from Brendan Gallagher bren...@bywatersolutions.com ---
Created attachment 36133
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=36133action=edit
Bug 13676 - OpacSuppression description says 'items' but means 'records'

This patch changes the wording for the OpacSuppression preference description.

Without patch:
... items marked as suppressed from OPAC search results. Note that you must
have the codeSuppress/code index set up in Zebra and at least one
suppressed item, or your searches will be broken. ...

With patch:
... items marked as suppressed from OPAC search results. Note that you must
have the codeSuppress/code index set up in Zebra and at least one
suppressed biblio record, or your searches will be broken. ...

Signed-off-by: Brendan Gallagher bren...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13676] OpacSuppression description says 'items' but means 'records'

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

Brendan Gallagher bren...@bywatersolutions.com changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13676] OpacSuppression description says 'items' but means 'records'

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

Marc Véron ve...@veron.ch changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Assignee|koha-b...@lists.koha-commun |ve...@veron.ch
   |ity.org |
   Patch complexity|--- |Trivial patch
 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13676] OpacSuppression description says 'items' but means 'records'

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

--- Comment #1 from Marc Véron ve...@veron.ch ---
Created attachment 35812
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=35812action=edit
Bug 13676 - OpacSuppression description says 'items' but means 'records'

This patch changes the wording for the OpacSuppression preference description.

Without patch:
... items marked as suppressed from OPAC search results. Note that you must
have the codeSuppress/code index set up in Zebra and at least one
suppressed item, or your searches will be broken. ...

With patch:
... items marked as suppressed from OPAC search results. Note that you must
have the codeSuppress/code index set up in Zebra and at least one
suppressed biblio record, or your searches will be broken. ...

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 13676] OpacSuppression description says 'items' but means 'records'

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13676

Katrin Fischer katrin.fisc...@bsz-bw.de changed:

   What|Removed |Added

   Keywords||Academy

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/