[Koha-bugs] [Bug 13897] Use XML files for installer data

2019-12-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

--- Comment #27 from Jonathan Druart  
---
Created attachment 96397
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96397&action=edit
Bug 13897: Catch the error and warn it

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13897] Use XML files for installer data

2019-12-18 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

--- Comment #26 from Jonathan Druart  
---
Bernardo,

I am all good with it, we could improve (performance) later (like one INSERT
per file) if needed.
Another improvement would be to move the .txt file into the YAML.

I would like to see the translator tool ready before we push this one. Did you
investigate already the work that needs to be done?
I think we should move the already translated strings into a new .po (one .po
for all installer files?)


I can have a look if you did not already, but prefer to avoid duplication of
work :)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13897] Use XML files for installer data

2019-12-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

--- Comment #25 from David Cook  ---
That looks a lot nicer!

Since you're going with this approach, perhaps it would be worth turning off
AutoCommit, running the INSERTs, and then COMMITing? According to the MySQL
documentation, that should be higher performance. Probably easier to handle
exceptions that way too.

I wonder if we should add more error-handling in the eval{} block as well. I
suppose any errors will be caught during $loadyaml->execute(), so maybe that's
unnecessary. (Due to my nitpicker nature, I'd suggest $loadyaml be $load_sth
instead, but that's really just nitpicking, so feel free to ignore it.)

+1 Bernardo

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13897] Use XML files for installer data

2019-12-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13897] Use XML files for installer data

2019-12-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

--- Comment #24 from Martin Renvoize  ---
OK, that's lovely.. super simple to understand and write.. nice work Bernardo!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13897] Use XML files for installer data

2019-12-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

--- Comment #23 from Jonathan Druart  
---
Looks great to me!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13897] Use XML files for installer data

2019-12-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

--- Comment #22 from Bernardo Gonzalez Kriegel  ---
Great to have so many comment :)

(In reply to David Cook from comment #12)
> 
> Since this is installer data, I don't think it necessarily has to be fast? I
> figure the most important part is to make it easy to read and update? 

Agreed, I think it's worth it

> Actually, I don't know if we necessarily need to change C4/Installer.pm? 
> 
> We could use YAML as a declarative format for the database data, and then
> the Release Manager/Release Maintainer could run a tool to compile it into a
> SQL script.

I think, as Katrin and Jonathan, that it's better not to compile sql, just use
the files, then a change in C4/Installer.pm is needed.


(In reply to Jonathan Druart from comment #16)
> > > Why not write our own stuff, yml-based?
> ...
> I would:
> - Retrieve and parse the whole YAML file
> - Generate the SQL queries (like 1 per table)
> - Execute the INSERT statements (using DBIx::RunSQL->run_sql)

In the new patch I'm inserting directly. 
We can try to measure the delay, if any


(In reply to Katrin Fischer from comment #18)
> > Going back to the actual problem this patchset is trying to resolve.. can
> > you remind me what it is about the SQL format files in the first place means
> > we can't easily support translating them without moving to some intermediary
> > file format?
> 
> I think the problem is that you can't 'mark' what needs translation. You
> only want to translate a small bit of the SQL files, the descriptions while
> preventing people to translate values that should not be changed.

Katrin is right, I couldn't find a general way to parse sql files to
extract/replace strings. There are too many variations.
The only one I'd made is the one used to generate translated frameworks, in
translation server, that has different functions to extract/replace strings
with 1,2,6,15,16 commas (,); and that after massaging EN frameworks sql files
so they are exactly as expected.


(In reply to Martin Renvoize from comment #20)
> What I wasn't fully understanding is why we needed to move from a lots of
> SQL files to one YAML/XML/Whatever file instead of a single SQL file which
> gets translated via the tools.
> 
> Sounds like SQL is just too hard to parse as is for the existing translation
> tools.. that's the answer.

It is hard, at last for me :(

Thank you all!

If you can, please take a look at the second patch.
It uses YAML instead of XML, it's easier to read.
I tried it and works. Do not install the first patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13897] Use XML files for installer data

2019-12-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

--- Comment #21 from Bernardo Gonzalez Kriegel  ---
Created attachment 96370
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=96370&action=edit
Bug 13897: Use YAML files for installer data

This patch modifies C4/Installer.pm to add support
for loading YAML files into database.

As an example of the functionality, optional
auth_val.sql file is replaced by auth_val.yml

The rationale behind this feature is to enable the
translation of the data that is loaded into the
database. That will be addressed in another bug.

But taking into account that goal, translatable
values are declared in the YAML files, to ease
identification by translate script.

To test:
0) Do a clean install with all optional data,
   then dump authorised_values table, reserve.
1) Apply the patch
2) Do a clean install in English (marc21/unimarc)
3) On optional data check for description of auth_val
   "Some basic default authorised values for ..."
4) Select all optional data
5) Finish installation
6) Dump again authorised_values table and compare with that
   of point '0'.
   Expected differences: most rows now have 'lib_opac' field
   with the same value as 'lib'

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13897] Use XML files for installer data

2019-12-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

--- Comment #20 from Martin Renvoize  ---
Sorry.. I don't think my question was clear.. I'm totally onboard with wanting
to replace the workflow we have and having one update file which then followed
the standard translations workflow we have elsewhere..

What I wasn't fully understanding is why we needed to move from a lots of SQL
files to one YAML/XML/Whatever file instead of a single SQL file which gets
translated via the tools.

Sounds like SQL is just too hard to parse as is for the existing translation
tools.. that's the answer.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13897] Use XML files for installer data

2019-12-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

--- Comment #19 from Jonathan Druart  
---
(In reply to Martin Renvoize from comment #17)
> Going back to the actual problem this patchset is trying to resolve.. can
> you remind me what it is about the SQL format files in the first place means
> we can't easily support translating them without moving to some intermediary
> file format?

.sql files are not following the usual translation workflow.
There is 1 file per language (in the term of language in installer/data/mysql/,
so not so much compared to the number of languages we really support (POs).
If you want to translate a sql file, you need to open a bug report, patch it,
wait for someone to SO/QA/push.
Also it's painful to support (dev POV), as if you want to add an AV, you have
to edit X .sql files, test them, (rebase), etc.
With only 1 sql file, at the root of installer dir (installer/data/mysq) the
translation will be done using the usual workflow (after a change to our
translator tool as we still do not support YAML file, but we do support .pref
which are YAML, so should not be too hard)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13897] Use XML files for installer data

2019-12-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

--- Comment #18 from Katrin Fischer  ---

> Going back to the actual problem this patchset is trying to resolve.. can
> you remind me what it is about the SQL format files in the first place means
> we can't easily support translating them without moving to some intermediary
> file format?

I think the problem is that you can't 'mark' what needs translation. You only
want to translate a small bit of the SQL files, the descriptions while
preventing people to translate values that should not be changed.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13897] Use XML files for installer data

2019-12-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

--- Comment #17 from Martin Renvoize  ---
Sorry Bernardo, I didn't mean to knock this one off the rails so much :(.

Hmm, it's a shame SQL::Translator only handles definition... I must have
misremembered... it's SQL::Abstract ( the the various DBIx::Class extensions)
that does the rest. SQL::Abstract is Perl script however so may not be
especially helpful here?

As for DBIx::Class::Schema::Versioned, I'm really not sure I understand what
that would win for us (especially as the general recommendation in DBIx::Class
land now is not to use it, but rather use DeploymentHandler instead).  Koha's
installer is actually pretty powerful as it is in my opinion and this is just
one minor area we can improve.. please highlight some problems you feel such a
move would resolve?

Going back to the actual problem this patchset is trying to resolve.. can you
remind me what it is about the SQL format files in the first place means we
can't easily support translating them without moving to some intermediary file
format?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13897] Use XML files for installer data

2019-12-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

--- Comment #16 from Jonathan Druart  
---
(In reply to Bernardo Gonzalez Kriegel from comment #11)
> (In reply to Jonathan Druart from comment #9)
> > Hola Bernado,
> > I like the idea, but not XML, neither the MySQL only limitation.
> 
> Salut Jonathan,
> I don't like XML either, nor the MySQL only. 
> Just remember that I was thinking in translations, and xml support it's
> included right now.
> But yaml can be handled.
> 
> > Why not write our own stuff, yml-based?
> 
> No problem, I'll write a POC patch, but have a question:
> 
> Do you think the sequence 
>  a) Read YAML > Write $tmp/out.sql >
> DBIx_::RunSQL->run_sql_file($tmp/out.sql) 
> is a valid approach, or
>  b) Read YAML > Insert into DB somehow 
> it's better?
> I suppose b) is slower.

I would:
- Retrieve and parse the whole YAML file
- Generate the SQL queries (like 1 per table)
- Execute the INSERT statements (using DBIx::RunSQL->run_sql)

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13897] Use XML files for installer data

2019-12-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

--- Comment #15 from Katrin Fischer  ---
I am not sure if XML is really easier to read here, but enabling translation
would be great. :)

I'd vote against 'compiling at release time'. If we still need to create SQL
files and store them, we should do so continously like we do for CSS etc. as
this needs to be testable with current data all the time.

Please keep in mind when changing the web installer, that it's currently
possible to add additional SQL files to the installer that will be picked up -
it would be nice to keep that feature. There is also the option to have a
syspref.sql for some additional settings (see de-DE installer) that not all
languages have made use of.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13897] Use XML files for installer data

2019-12-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

--- Comment #14 from David Cook  ---
While we're on this topic, perhaps it's worthwhile talking about something like
this:

https://metacpan.org/pod/DBIx::Class::Schema::Versioned

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13897] Use XML files for installer data

2019-12-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

--- Comment #13 from David Cook  ---
(In reply to David Cook from comment #12)

> We could use YAML as a declarative format for the database data, and then
> the Release Manager/Release Maintainer could run a tool to compile it into a
> SQL script. 
> 

This could also be used to add support for different databases, especially in
terms of optimizing bulk data loading. 

https://dev.mysql.com/doc/refman/5.6/en/optimizing-innodb-bulk-data-loading.html
https://www.postgresql.org/docs/9.1/ecpg-sql-set-autocommit.html

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13897] Use XML files for installer data

2019-12-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

--- Comment #12 from David Cook  ---
(In reply to Bernardo Gonzalez Kriegel from comment #11)
> Do you think the sequence 
>  a) Read YAML > Write $tmp/out.sql >
> DBIx_::RunSQL->run_sql_file($tmp/out.sql) 
> is a valid approach, or
>  b) Read YAML > Insert into DB somehow 
> it's better?
> I suppose b) is slower.
> 

Since this is installer data, I don't think it necessarily has to be fast? I
figure the most important part is to make it easy to read and update? 

Actually, I don't know if we necessarily need to change C4/Installer.pm? 

We could use YAML as a declarative format for the database data, and then the
Release Manager/Release Maintainer could run a tool to compile it into a SQL
script. 

If we only do that compilation at release time, it would also be easier to
audit and find bugs in the final result.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13897] Use XML files for installer data

2019-12-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

--- Comment #11 from Bernardo Gonzalez Kriegel  ---
(In reply to Jonathan Druart from comment #9)
> Hola Bernado,
> I like the idea, but not XML, neither the MySQL only limitation.

Salut Jonathan,
I don't like XML either, nor the MySQL only. 
Just remember that I was thinking in translations, and xml support it's
included right now.
But yaml can be handled.

> Why not write our own stuff, yml-based?

No problem, I'll write a POC patch, but have a question:

Do you think the sequence 
 a) Read YAML > Write $tmp/out.sql > DBIx_::RunSQL->run_sql_file($tmp/out.sql) 
is a valid approach, or
 b) Read YAML > Insert into DB somehow 
it's better?
I suppose b) is slower.

(In reply to Martin Renvoize from comment #10)
> This looks good. My only slight concern is whether it ties us more strictly
> to MySQL or in particular a particular MySQL version. (I'm not sure how
> widely supported the MySQL XML dump format is.. do they change the format
> when new feature are introduced for example and does MariaDB support it
> natively too).
> 
> Perhaps we could use the well supported and maintained SQL::Translator to
> produce something similar in XML, YAML or JSON as our middle format ?
Hi Martin,
SQL::Translator documentation states: "Presently only the definition parts of
SQL are handled (CREATE, ALTER), not the manipulation of data (INSERT, UPDATE,
DELETE)."

And this files normally do INSERTs, don't know if it's useful in this case.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13897] Use XML files for installer data

2019-12-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

--- Comment #10 from Martin Renvoize  ---
This looks good. My only slight concern is whether it ties us more strictly to
MySQL or in particular a particular MySQL version. (I'm not sure how widely
supported the MySQL XML dump format is.. do they change the format when new
feature are introduced for example and does MariaDB support it natively too).

Perhaps we could use the well supported and maintained SQL::Translator to
produce something similar in XML, YAML or JSON as our middle format ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13897] Use XML files for installer data

2019-12-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #9 from Jonathan Druart  
---
Hola Bernado,
I like the idea, but not XML, neither the MySQL only limitation.
Why not write our own stuff, yml-based?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13897] Use XML files for installer data

2019-11-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13897] Use XML files for installer data

2019-11-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #75931|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13897] Use XML files for installer data

2019-11-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #75930|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13897] Use XML files for installer data

2019-11-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

--- Comment #8 from Bernardo Gonzalez Kriegel  ---
Created attachment 95884
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95884&action=edit
Bug 13897: Use XML files for installer data

This patch modifies C4/Installer.pm to add support
for loading XML files into database (MySQL only).

As an example of the functionality, optional
auth_val.sql file is replaced by auth_val.xml

The rationale behind this feature is to enable the
translation of the data that is loaded into the
database. That will be addressed in another bug.

But taking into account that goal, non translatable
values are put into XML attributes, translatable ones
into elements which can already be captured by
translate script.

To test:
0) Do a clean install with all optional data,
   then dump authorised_values table, reserve.
1) Apply the patch
2) Do a clean install in English (marc21/unimarc)
3) On optional data check for description of auth_val
   "Some basic default authorised values for ..."
4) Select all optional data
5) Finish installation
6) Dump again authorised_values table and compare with that
   of point '0'. There must be no differences.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13897] Use XML files for installer data

2019-10-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

Zeno Tajoli  changed:

   What|Removed |Added

 CC|ztaj...@gmail.com   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13897] Use XML files for installer data

2019-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

Martin Renvoize  changed:

   What|Removed |Added

   Keywords||rel_20_05_target

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13897] Use XML files for installer data

2019-10-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

Martin Renvoize  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=23895

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13897] Use XML files for installer data

2019-02-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

Martin Renvoize  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de,
   ||martin.renvoize@ptfs-europe
   ||.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13897] Use XML files for installer data

2018-10-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

Jonathan Druart  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=21540

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13897] Use XML files for installer data

2018-06-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

--- Comment #7 from Bernardo Gonzalez Kriegel  ---
Created attachment 75931
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75931&action=edit
Bug 13897: Split auth framework into xml and sql files

Bug 13897: Split auth framework into xml and sql files

This patch split authorities_normal_marc21.sql contents
between three XML files and a remanent SQL file

GZIP file of patch, it's too large

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13897] Use XML files for installer data

2018-06-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

--- Comment #6 from Bernardo Gonzalez Kriegel  ---
Created attachment 75930
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75930&action=edit
Bug 13897: C4/Installer.pm - process XML files

This patch modifies C4/Installer.pm to add support
for processing of XML files into database.
For MySQL only

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13897] Use XML files for installer data

2018-06-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #37165|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13897] Use XML files for installer data

2015-03-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13897] Use XML files for installer data

2015-03-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

--- Comment #5 from Zeno Tajoli  ---
I suggest to put .po file in a different git server, to limit the growth of
general git archive.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13897] Use XML files for installer data

2015-03-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

--- Comment #4 from Bernardo Gonzalez Kriegel  ---
(In reply to Zeno Tajoli from comment #3)
> Bernardo, can you describe 'the usual way' to transalte  XML files ?
> Do you plan to use a .po file ?

Yes, sorry, the plan is to use .po files-

In the patchset I introduce an XML file for each SQL one in common
mandatory/optional and MARC21 mandatory, soon I'll provide for marc21 optional
and hopefully UNIMARC.

I add mysql folders as targets to translation script, so new .po files are
build from XML files, and when we use the translation script it copy all sql
folders and rebuild sql and txt files from translated xml files, to allow an
install with translated values.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13897] Use XML files for installer data

2015-03-25 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

Zeno Tajoli  changed:

   What|Removed |Added

 Status|NEW |In Discussion
 CC||z.taj...@cineca.it

--- Comment #3 from Zeno Tajoli  ---
Bernardo, can you describe 'the usual way' to transalte  XML files ?
Do you plan to use a .po file ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13897] Use XML files for installer data

2015-03-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

--- Comment #2 from Bernardo Gonzalez Kriegel  ---
Created attachment 37165
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=37165&action=edit
Bug 13897 Patchset

Test implementation patchset
Only cover mysql mandatory/optional and marc21 mandatory, just as example

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13897] Use XML files for installer data

2015-03-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Depends on||7939, 10963, 13322

--- Comment #1 from Bernardo Gonzalez Kriegel  ---
I'll make this enh dependent on 7939 10963 13322.

Bug 7939 modifies LangInstaller.pm
Bug 10963 rewrites MARC21 sample bib frameworks, no need to translate them
Bug 13322 updates MARC21 default bib framework

All signed ATM

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 13897] Use XML files for installer data

2015-03-23 Thread bugzilla-daemon
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |bgkrie...@gmail.com
   |ity.org |

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/