[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Jonathan Druart changed: What|Removed |Added Blocks||27650 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=27650 [Bug 27650] Wrong variable passed to the template in opac-main -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Jonathan Druart changed: What|Removed |Added Blocks||24398 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24398 [Bug 24398] Error when viewing single news item and NewsAuthorDisplay pref set to OPAC -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Martin Renvoize changed: What|Removed |Added Version(s)||19.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Katrin Fischer changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m --- Comment #98 from Katrin Fischer --- *** Bug 14980 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Martin Renvoize changed: What|Removed |Added Resolution|--- |FIXED Status|Pushed to Master|RESOLVED --- Comment #97 from Martin Renvoize --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia changed: What|Removed |Added Blocks||22370 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22370 [Bug 22370] OPAC users should not be allowed to view staff news items -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 --- Comment #96 from Nick Clemens --- (In reply to Nick Clemens from comment #94) > I can input ids manually and access staff news items via the opac interface. > I think this should be prevented I pushed this one, filed a followup bug 22370 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Nick Clemens changed: What|Removed |Added Status|Failed QA |Passed QA --- Comment #95 from Nick Clemens --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Nick Clemens changed: What|Removed |Added Status|Passed QA |Failed QA --- Comment #94 from Nick Clemens --- I can input ids manually and access staff news items via the opac interface. I think this should be prevented -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #93 from Martin Renvoize --- Passing QA as the feature works as expected and I can't find any regressions at this time. It would be nice to have some selenium integration tests for this feature to prevent future regressions, but as they're not yet widespread I can't fail on that point. Also, can we get a relevant update patch submitted to the manual, please. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Martin Renvoize changed: What|Removed |Added Keywords||Manual -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Martin Renvoize changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |martin.renvoize@ptfs-europe |y.org |.com CC||martin.renvoize@ptfs-europe ||.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 --- Comment #92 from Martin Renvoize --- Created attachment 84874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84874=edit Bug 14272: (QA follow-up) Remove superflous filter Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Martin Renvoize changed: What|Removed |Added Attachment #83429|0 |1 is obsolete|| --- Comment #90 from Martin Renvoize --- Created attachment 84872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84872=edit Bug 14272: Fix missing TT filters Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Martin Renvoize changed: What|Removed |Added Attachment #83428|0 |1 is obsolete|| --- Comment #89 from Martin Renvoize --- Created attachment 84871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84871=edit Bug 14272: (follow-up) Fixing layout issues and expiration date hint Misunderstood the first time. I've added the hint to the news form on staff side. I've fixed the layout on OPAC. The RSS feed shows on the main page, but is hidden if there is no news and if viewing one news item. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Martin Renvoize changed: What|Removed |Added Attachment #83427|0 |1 is obsolete|| --- Comment #88 from Martin Renvoize --- Created attachment 84870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84870=edit Bug 14272: (follow-up) Fixing template error and layout To test, confirm that OpacMainUserBlock and Quote of the Day do not show if viewing a single news item, but do show otherwise. Confirm user dashboard shows where expected Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer UPDATE 24/Aug: Add expiration date text Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Martin Renvoize changed: What|Removed |Added Attachment #83430|0 |1 is obsolete|| --- Comment #91 from Martin Renvoize --- Created attachment 84873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84873=edit Bug 14272: (follow-up) Show single display of 'all' news This patch ensures that news items with location set to 'all' can be clicked on and shown individually also. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Martin Renvoize changed: What|Removed |Added Attachment #83425|0 |1 is obsolete|| --- Comment #86 from Martin Renvoize --- Created attachment 84868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84868=edit Bug 14272: Show single news item [alternative patch] This is a new patch for this bug that shows a single news item on the OPAC using Koha Objects (Koha::News). To test: 1) Go to Tools -> News on staff interface, make a news item to show on the OPAC 2) Go to OPAC 3) Notice news item shows and title cannot be clicked 4) Apply patch, refresh page 5) Notice title is now a link. Click title 6) Confirm breadcrumbs shows title of news item 7) Confirm RSS feed and OpacMainUserBlock are not visible 8) In the URL, change the news_id param to an ID that does not exist 9) Confirm that an appropriate error message shows Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Martin Renvoize changed: What|Removed |Added Attachment #83426|0 |1 is obsolete|| --- Comment #87 from Martin Renvoize --- Created attachment 84869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84869=edit Bug 14272: (follow-up) only display news available for a particular opac lang [alternative patch] Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Katrin Fischer changed: What|Removed |Added Attachment #82713|0 |1 is obsolete|| --- Comment #85 from Katrin Fischer --- Created attachment 83430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83430=edit Bug 14272: (follow-up) Show single display of 'all' news This patch ensures that news items with location set to 'all' can be clicked on and shown individually also. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Katrin Fischer changed: What|Removed |Added Attachment #78208|0 |1 is obsolete|| --- Comment #82 from Katrin Fischer --- Created attachment 83427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83427=edit Bug 14272: (follow-up) Fixing template error and layout To test, confirm that OpacMainUserBlock and Quote of the Day do not show if viewing a single news item, but do show otherwise. Confirm user dashboard shows where expected Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer UPDATE 24/Aug: Add expiration date text Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Katrin Fischer changed: What|Removed |Added Attachment #78206|0 |1 is obsolete|| --- Comment #80 from Katrin Fischer --- Created attachment 83425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83425=edit Bug 14272: Show single news item [alternative patch] This is a new patch for this bug that shows a single news item on the OPAC using Koha Objects (Koha::News). To test: 1) Go to Tools -> News on staff interface, make a news item to show on the OPAC 2) Go to OPAC 3) Notice news item shows and title cannot be clicked 4) Apply patch, refresh page 5) Notice title is now a link. Click title 6) Confirm breadcrumbs shows title of news item 7) Confirm RSS feed and OpacMainUserBlock are not visible 8) In the URL, change the news_id param to an ID that does not exist 9) Confirm that an appropriate error message shows Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Katrin Fischer changed: What|Removed |Added Attachment #81643|0 |1 is obsolete|| --- Comment #84 from Katrin Fischer --- Created attachment 83429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83429=edit Bug 14272: Fix missing TT filters Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Katrin Fischer changed: What|Removed |Added Attachment #78207|0 |1 is obsolete|| --- Comment #81 from Katrin Fischer --- Created attachment 83426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83426=edit Bug 14272: (follow-up) only display news available for a particular opac lang [alternative patch] Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Katrin Fischer changed: What|Removed |Added Attachment #78231|0 |1 is obsolete|| --- Comment #83 from Katrin Fischer --- Created attachment 83428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83428=edit Bug 14272: (follow-up) Fixing layout issues and expiration date hint Misunderstood the first time. I've added the hint to the news form on staff side. I've fixed the layout on OPAC. The RSS feed shows on the main page, but is hidden if there is no news and if viewing one news item. Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 --- Comment #79 from Aleisha Amohia --- Created attachment 82713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82713=edit Bug 14272: (follow-up) Show single display of 'all' news This patch ensures that news items with location set to 'all' can be clicked on and shown individually also. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 --- Comment #78 from Katrin Fischer --- Created attachment 81643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81643=edit Bug 14272: Fix missing TT filters -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #77 from Katrin Fischer --- Hi Aleisha, I found a little problem: When location is set to "all" (staff and opac), then the page view doesn't work. You see the news on the front page, but when you click on the headline it claims news item doesn't exist. I think this would be nice to have, maybe it can be fixed easily? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 --- Comment #76 from Aleisha Amohia --- Created attachment 78231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78231=edit Bug 14272: (follow-up) Fixing layout issues and expiration date hint Misunderstood the first time. I've added the hint to the news form on staff side. I've fixed the layout on OPAC. The RSS feed shows on the main page, but is hidden if there is no news and if viewing one news item. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 --- Comment #75 from Katrin Fischer --- Hm, yes, I didn't sign off on that, I think? Please always do follow-ups for changes like that once a patch has reached signed-off status. I also think this is a misunderstanding entirely. We were not asking for the expiration date to show on the news item, but for a hint on the news form in staff that the news will still be accessible by direct URL even if expired. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Failed QA --- Comment #74 from Owen Leonard --- (In reply to Owen Leonard from comment #53) > > A problem I found: If there is no news to display, OpacMainUserBlock and > Quote of the Day don't show at all. This problem is back. Why do we note the expiration date of the news item? That doesn't seem relevant to me. If we must keep it the date should be formatted according to dateformat preference. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 --- Comment #73 from Katrin Fischer --- If it's only the hint being added, I'd be ok putting this back into the QA queue. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 --- Comment #72 from Aleisha Amohia --- Rebased, ready for testing -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia changed: What|Removed |Added Attachment #78104|0 |1 is obsolete|| --- Comment #71 from Aleisha Amohia --- Created attachment 78208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78208=edit Bug 14272: (follow-up) Fixing template error and layout To test, confirm that OpacMainUserBlock and Quote of the Day do not show if viewing a single news item, but do show otherwise. Confirm user dashboard shows where expected Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer UPDATE 24/Aug: Add expiration date text -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia changed: What|Removed |Added Attachment #77568|0 |1 is obsolete|| --- Comment #70 from Aleisha Amohia --- Created attachment 78207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78207=edit Bug 14272: (follow-up) only display news available for a particular opac lang [alternative patch] Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia changed: What|Removed |Added Attachment #77567|0 |1 is obsolete|| --- Comment #69 from Aleisha Amohia --- Created attachment 78206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78206=edit Bug 14272: Show single news item [alternative patch] This is a new patch for this bug that shows a single news item on the OPAC using Koha Objects (Koha::News). To test: 1) Go to Tools -> News on staff interface, make a news item to show on the OPAC 2) Go to OPAC 3) Notice news item shows and title cannot be clicked 4) Apply patch, refresh page 5) Notice title is now a link. Click title 6) Confirm breadcrumbs shows title of news item 7) Confirm RSS feed and OpacMainUserBlock are not visible 8) In the URL, change the news_id param to an ID that does not exist 9) Confirm that an appropriate error message shows Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia changed: What|Removed |Added Attachment #77569|0 |1 is obsolete|| --- Comment #68 from Aleisha Amohia --- Created attachment 78104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78104=edit Bug 14272: (follow-up) Fixing template error and layout To test, confirm that OpacMainUserBlock and Quote of the Day do not show if viewing a single news item, but do show otherwise. Confirm user dashboard shows where expected Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer UPDATE 24/Aug: Add expiration date text -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Aleisha Amohia changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Nick Clemens changed: What|Removed |Added CC||n...@bywatersolutions.com Status|Passed QA |Patch doesn't apply --- Comment #67 from Nick Clemens --- Owen, can you rebase on 13618 and add the hint to expiration date as Jonathan suggested? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 --- Comment #66 from Jonathan Druart --- (In reply to Jonathan Druart from comment #65) > (In reply to Owen Leonard from comment #61) > > It is a change of behavior, but my vote is to consider it a feature not a > > bug. > > Usually it means it would be considered as a bug for someone else :) > > I would add a hint close to "Expiration date:" and highlight in the release > notes. Katrin updated the release notes on QAing! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 --- Comment #65 from Jonathan Druart --- (In reply to Owen Leonard from comment #61) > It is a change of behavior, but my vote is to consider it a feature not a > bug. Usually it means it would be considered as a bug for someone else :) I would add a hint close to "Expiration date:" and highlight in the release notes. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Katrin Fischer changed: What|Removed |Added Attachment #77566|0 |1 is obsolete|| --- Comment #64 from Katrin Fischer --- Created attachment 77569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77569=edit Bug 14272: (follow-up) Fixing template error and layout To test, confirm that OpacMainUserBlock and Quote of the Day do not show if viewing a single news item, but do show otherwise. Confirm user dashboard shows where expected Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Katrin Fischer changed: What|Removed |Added Attachment #77565|0 |1 is obsolete|| --- Comment #63 from Katrin Fischer --- Created attachment 77568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77568=edit Bug 14272: (follow-up) only display news available for a particular opac lang [alternative patch] Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Katrin Fischer changed: What|Removed |Added Attachment #77564|0 |1 is obsolete|| --- Comment #62 from Katrin Fischer --- Created attachment 77567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77567=edit Bug 14272: Show single news item [alternative patch] This is a new patch for this bug that shows a single news item on the OPAC using Koha Objects (Koha::News). To test: 1) Go to Tools -> News on staff interface, make a news item to show on the OPAC 2) Go to OPAC 3) Notice news item shows and title cannot be clicked 4) Apply patch, refresh page 5) Notice title is now a link. Click title 6) Confirm breadcrumbs shows title of news item 7) Confirm RSS feed and OpacMainUserBlock are not visible 8) In the URL, change the news_id param to an ID that does not exist 9) Confirm that an appropriate error message shows Sponsored-by: Catalyst IT Signed-off-by: Owen Leonard Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14272] Allow OPAC to show a single news entry
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14272 Katrin Fischer changed: What|Removed |Added Text to go in the||Allows to display OPAC news release notes||entries on their own page. ||The news entry will remain ||accessible by direct URL ||even after the entry itself ||has expired. Summary|Allow OPAC to show a single |Allow OPAC to show a single |news item |news entry -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
