[Koha-bugs] [Bug 14353] Show 'damaged' and other status on the 'place holds' page in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14353 --- Comment #10 from Katrin Fischer --- This patch has been pushed to 16.11.x and will be in 16.11.13. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14353] Show 'damaged' and other status on the 'place holds' page in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14353 Fridolin SOMERS changed: What|Removed |Added Status|Pushed to Master|Pushed to Stable CC||fridolin.som...@biblibre.co ||m --- Comment #9 from Fridolin SOMERS --- Pushed to 17.05.x, will be in 17.05.05. Very small enhancement, should ok for stable branches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14353] Show 'damaged' and other status on the 'place holds' page in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14353 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment #8 from Jonathan Druart --- Pushed to master for 17.11, thanks to everybody involved! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14353] Show 'damaged' and other status on the 'place holds' page in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14353 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14353] Show 'damaged' and other status on the 'place holds' page in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14353 Marcel de Rooy changed: What|Removed |Added Attachment #64161|0 |1 is obsolete|| --- Comment #7 from Marcel de Rooy --- Created attachment 66692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66692&action=edit Bug 14353 - Show 'damaged' and other status on the 'place holds' page in staff This patch adds status 'Damaged' to 'Information' 'Status' in the items table on 'Place hold' page. To test: - Apply patch - In staff client, try to place an item level hold for items with 'Damaged' status. - Verify that the status 'Damaged' appears in the column 'Information'. Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14353] Show 'damaged' and other status on the 'place holds' page in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14353 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl |y.org | CC||m.de.r...@rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14353] Show 'damaged' and other status on the 'place holds' page in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14353 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14353] Show 'damaged' and other status on the 'place holds' page in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14353 Owen Leonard changed: What|Removed |Added Attachment #62532|0 |1 is obsolete|| --- Comment #6 from Owen Leonard --- Created attachment 64161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=64161&action=edit [SIGNED-OFF] Bug 14353 - Show 'damaged' and other status on the 'place holds' page in staff This patch adds status 'Damaged' to 'Information' 'Status' in the items table on 'Place hold' page. To test: - Apply patch - In staff client, try to place an item level hold for items with 'Damaged' status. - Verify that the status 'Damaged' appears in the column 'Information'. Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14353] Show 'damaged' and other status on the 'place holds' page in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14353 Marc Véron changed: What|Removed |Added Blocks||18475 --- Comment #5 from Marc Véron --- (In reply to M. Tompsett from comment #2) (...) > > I think there are some underlying design issues which require further > thought or at least explanation. It makes little sense to me to have two > columns displaying something about the fact that it is damaged. It also is > confusing that itemlost, damaged, and withdrawn would be in the same column. > I didn't read the code deeper. My patch now adds a minimal information about the 'Damaged' status in the existing column 'Information'. The whole table would need some attention. I filed Bug 18475. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18475 [Bug 18475] Table 'Place a hold on a specific item' needs a tidy up -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14353] Show 'damaged' and other status on the 'place holds' page in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14353 Marc Véron changed: What|Removed |Added Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14353] Show 'damaged' and other status on the 'place holds' page in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14353 Marc Véron changed: What|Removed |Added Attachment #60433|0 |1 is obsolete|| --- Comment #4 from Marc Véron --- Created attachment 62532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=62532&action=edit Bug 14353 - Show 'damaged' and other status on the 'place holds' page in staff This patch adds status 'Damaged' to 'Information' 'Status' in the items table on 'Place hold' page. To test: - Apply patch - In staff client, try to place an item level hold for items with 'Damaged' status. - Verify that the status 'Damaged' appears in the column 'Information'. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14353] Show 'damaged' and other status on the 'place holds' page in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14353 --- Comment #3 from Marc Véron --- @Katrin: What would you like that it looks like? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14353] Show 'damaged' and other status on the 'place holds' page in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14353 M. Tompsett changed: What|Removed |Added CC||mtomp...@hotmail.com Status|Needs Signoff |In Discussion --- Comment #2 from M. Tompsett --- This is the first column: [% IF itemloo.not_holdable %] [% IF itemloo.not_holdable == 'damaged' %] Item damaged [% ELSIF itemloo.not_holdable == 'ageRestricted' %] Age restricted [% ELSIF itemloo.not_holdable == 'tooManyHoldsForThisRecord' %] Exceeded max holds per record [% ELSIF itemloo.not_holdable == 'tooManyReserves' %] Too many holds [% ELSIF itemloo.not_holdable == 'notReservable' %] Not holdable [% ELSIF itemloo.not_holdable == 'cannotReserveFromOtherBranches' %] Patron is from different library [% ELSIF itemloo.not_holdable == 'itemAlreadyOnHold' %] Patron already has hold for this item [% ELSE %] [% itemloo.not_holdable %] [% END %] [% END %] This is what Marc V added: [% IF ( itemloo.itemlost ) %]Lost[% END %] [% IF ( itemloo.damaged ) %]Damaged[% END %] [% IF ( itemloo.withdrawn ) %]Withdrawn[% END %] I think there are some underlying design issues which require further thought or at least explanation. It makes little sense to me to have two columns displaying something about the fact that it is damaged. It also is confusing that itemlost, damaged, and withdrawn would be in the same column. I didn't read the code deeper. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14353] Show 'damaged' and other status on the 'place holds' page in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14353 Marc Véron changed: What|Removed |Added Patch complexity|--- |Trivial patch Assignee|koha-b...@lists.koha-commun |ve...@veron.ch |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14353] Show 'damaged' and other status on the 'place holds' page in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14353 Marc Véron changed: What|Removed |Added Status|NEW |Needs Signoff CC||ve...@veron.ch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 14353] Show 'damaged' and other status on the 'place holds' page in staff
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14353 --- Comment #1 from Marc Véron --- Created attachment 60433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=60433&action=edit Bug 14353 - Show 'damaged' and other status on the 'place holds' page in staff This patch adds a 'Status' column to the items table on 'Place hold' page. To test: - Apply patch - In staff client, try to place an item level hold for items with Damaged, Lost, Withdrawn statuses. - Verify a new column 'Status' indicating the item's status as appropriate. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
