[Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514

Nicole C. Engard  changed:

   What|Removed |Added

 CC|neng...@gmail.com   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514

Frédéric Demians  changed:

   What|Removed |Added

 CC||frede...@tamil.fr
 Status|Pushed to Master|Pushed to Stable

--- Comment #26 from Frédéric Demians  ---
Pushed in 16.05. Will be in 16.05.05.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514

Brendan Gallagher  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master
 CC||bren...@bywatersolutions.co
   ||m

--- Comment #25 from Brendan Gallagher  ---
Pushed to Master - Should be in the November 16.11 Release.  Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com

--- Comment #24 from Martin Renvoize  ---
Code looks good, fixes the problem for me and I cannot replicate Liz's issue.
Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514

Martin Renvoize  changed:

   What|Removed |Added

  Attachment #56126|0   |1
is obsolete||

--- Comment #23 from Martin Renvoize  ---
Created attachment 56456
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56456=edit
[PASSED QA] Bug 14514 - LocalHoldsPriority and the HoldsQueue conflict with
each other

It appears that the LocalHoldsPriority feature and the Holds Queue are
fundamentally at odds with each other.

The problem appears to be that both are attempting to choose the best
way to fill holds. When you are using the holds queue and you check in
an item that has been selected by the holds queue builder, that part of
Koha where the LocalHoldsPriority feature lives doesn't get to see all
the holds in order to pick the best one. Instead only the hold selected
by the holds queue builder is returned so to the LocalHoldsPriority
feature, that is only one hold to pick from!

Test Plan:
1) Apply this patch
2) prove t/db_dependent/HoldsQueue.t
3) All tests should pass

Signed-off-by: Barton Chittenden bar...@bywatersolutions.com
Signed-off-by: Dani Elder 

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514

Martin Renvoize  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514

Lisette  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514

Danielle Elder  changed:

   What|Removed |Added

  Attachment #53787|0   |1
is obsolete||

--- Comment #22 from Danielle Elder  ---
Created attachment 56126
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=56126=edit
Bug 14514 - LocalHoldsPriority and the HoldsQueue conflict with each other

It appears that the LocalHoldsPriority feature and the Holds Queue are
fundamentally at odds with each other.

The problem appears to be that both are attempting to choose the best
way to fill holds. When you are using the holds queue and you check in
an item that has been selected by the holds queue builder, that part of
Koha where the LocalHoldsPriority feature lives doesn't get to see all
the holds in order to pick the best one. Instead only the hold selected
by the holds queue builder is returned so to the LocalHoldsPriority
feature, that is only one hold to pick from!

Test Plan:
1) Apply this patch
2) prove t/db_dependent/HoldsQueue.t
3) All tests should pass

Signed-off-by: Barton Chittenden bar...@bywatersolutions.com
Signed-off-by: Dani Elder 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514

Danielle Elder  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514

--- Comment #21 from Kyle M Hall  ---
(In reply to Liz Rea from comment #20)
> Yes, I have the syspref turned on. I have just tested this again with the
> same results: 
> 
> The book is captured for the correct patron on check in, it does not turn up
> on a hold queue for any library. This seems wrong.

Liz can you make a screencast? I don't see how this is even possible!

For what it's worth, here is a video demo I just made:
https://www.youtube.com/watch?v=d947TgBENwM

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514

Liz Rea  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #20 from Liz Rea  ---
Yes, I have the syspref turned on. I have just tested this again with the same
results: 

The book is captured for the correct patron on check in, it does not turn up on
a hold queue for any library. This seems wrong.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514

--- Comment #19 from Joel Sasse  ---
Liz,

Would you please respond to Kyle's questions in the previous comment? I am
anxious to test this patch, sign off on, and get it into Koha as soon as
possible.

Thanks,
Joel

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514

--- Comment #18 from Kyle M Hall  ---
(In reply to Liz Rea from comment #15)
> *with this patch, the reserve doesn't show up on any hold queue. Without it,
> as you noted, it does show up on the wrong priority library's hold queue.

Do you have Local Holds Priority enabled? Can you try again with it switched
both on and off?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514

--- Comment #17 from Kyle M Hall  ---
(In reply to Liz Rea from comment #14)
> Should we expect that this local hold that has priority for a branch turn up
> on the hold queue? Or do we only care about what happens when an item is
> checked in?
> 
> My instinct says that a local hold priority item should show up on the hold
> queue for the prioritised library/item/borrower
> 
> Example, Patron from springfield has a biblio level reserve for a book that
> has a springfield copy, the springfield copy is available, should this turn
> up on the hold queue for springfield? 
> 
> Currently the reserve doesn't show up on any hold queue. Is that correct
> behaviour? How would the library know the reserve exists in this case
> without scanning it to trap it?

Yes, the hold should show up in the holds queue. That's all this patch is
supposed to do is to select the same patron for the holds queue that would be
selected if the item in question was not already in the holds queue. The
problem right now is the holds queue is choosing the wrong patron.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514

Barton Chittenden  changed:

   What|Removed |Added

  Attachment #51595|0   |1
is obsolete||

--- Comment #16 from Barton Chittenden  ---
Created attachment 53787
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=53787=edit
[SIGNED-OFF] Bug 14514 - LocalHoldsPriority and the HoldsQueue conflict with
each other

It appears that the LocalHoldsPriority feature and the Holds Queue are
fundamentally at odds with each other.

The problem appears to be that both are attempting to choose the best
way to fill holds. When you are using the holds queue and you check in
an item that has been selected by the holds queue builder, that part of
Koha where the LocalHoldsPriority feature lives doesn't get to see all
the holds in order to pick the best one. Instead only the hold selected
by the holds queue builder is returned so to the LocalHoldsPriority
feature, that is only one hold to pick from!

Test Plan:
1) Apply this patch
2) prove t/db_dependent/HoldsQueue.t
3) All tests should pass

Signed-off-by: Barton Chittenden bar...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514

--- Comment #15 from Liz Rea  ---
*with this patch, the reserve doesn't show up on any hold queue. Without it, as
you noted, it does show up on the wrong priority library's hold queue.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514

Liz Rea  changed:

   What|Removed |Added

 CC||l...@catalyst.net.nz

--- Comment #14 from Liz Rea  ---
Should we expect that this local hold that has priority for a branch turn up on
the hold queue? Or do we only care about what happens when an item is checked
in?

My instinct says that a local hold priority item should show up on the hold
queue for the prioritised library/item/borrower

Example, Patron from springfield has a biblio level reserve for a book that has
a springfield copy, the springfield copy is available, should this turn up on
the hold queue for springfield? 

Currently the reserve doesn't show up on any hold queue. Is that correct
behaviour? How would the library know the reserve exists in this case without
scanning it to trap it?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514

--- Comment #13 from Kyle M Hall  ---
Test Plan:
1) Create a number of holds on a record such that the item will be trapped for
the last patron on the queue
2) Check in the item, note the hold is trapped for the priority patron
3) Run the holds queue builder
4) Check in the item, note the hold is now trapped for someone else
5) Apply this patch
6) Rerun the holds queue builder
7) Check in the item, note the hold is now trapped for the priority patron
again

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514

--- Comment #12 from Barton Chittenden  ---
Re-run under kohadevbox; all tests pass.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #11 from Kyle M Hall  ---
All the unit tests pass for me. Are you running them on a stock sample
database?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514

Nicole C. Engard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA
 CC||neng...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514

Srdjan Jankovic  changed:

   What|Removed |Added

 Depends on||16671


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16671
[Bug 16671] Wrong itemtype picked in HoldsQueue.t
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514

--- Comment #10 from Barton Chittenden  ---
t/db_dependent/HoldsQueue.t .. Dubious, test returned 11 (wstat 2816, 0xb00)
Failed 11/42 subtests 

Test Summary Report
---
t/db_dependent/HoldsQueue.t (Wstat: 2816 Tests: 42 Failed: 11)
  Failed tests:  22, 24-28, 32-34, 36, 40
  Non-zero exit status: 11
Files=1, Tests=42,  3 wallclock secs ( 0.03 usr  0.00 sys +  2.02 cusr  0.12
csys =  2.17 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514

Kyle M Hall  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #49089|0   |1
is obsolete||

--- Comment #9 from Kyle M Hall  ---
Created attachment 51595
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=51595=edit
Bug 14514 - LocalHoldsPriority and the HoldsQueue conflict with each other

It appears that the LocalHoldsPriority feature and the Holds Queue are
fundamentally at odds with each other.

The problem appears to be that both are attempting to choose the best
way to fill holds. When you are using the holds queue and you check in
an item that has been selected by the holds queue builder, that part of
Koha where the LocalHoldsPriority feature lives doesn't get to see all
the holds in order to pick the best one. Instead only the hold selected
by the holds queue builder is returned so to the LocalHoldsPriority
feature, that is only one hold to pick from!

Test Plan:
1) Apply this patch
2) prove t/db_dependent/HoldsQueue.t
3) All tests should pass

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514

Barton Chittenden  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply
 CC||bar...@bywatersolutions.com

--- Comment #8 from Barton Chittenden  ---
Patch does not apply.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514

Christopher Brannon  changed:

   What|Removed |Added

 CC||cbran...@cdalibrary.org

--- Comment #7 from Christopher Brannon  ---
*** Bug 15914 has been marked as a duplicate of this bug. ***

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #47655|0   |1
is obsolete||

--- Comment #6 from Kyle M Hall  ---
Created attachment 49089
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49089=edit
Bug 14514 - LocalHoldsPriority and the HoldsQueue conflict with each other

It appears that the LocalHoldsPriority feature and the Holds Queue are
fundamentally at odds with each other.

The problem appears to be that both are attempting to choose the best
way to fill holds. When you are using the holds queue and you check in
an item that has been selected by the holds queue builder, that part of
Koha where the LocalHoldsPriority feature lives doesn't get to see all
the holds in order to pick the best one. Instead only the hold selected
by the holds queue builder is returned so to the LocalHoldsPriority
feature, that is only one hold to pick from!

Test Plan:
1) Apply this patch
2) prove t/db_dependent/HoldsQueue.t
3) All tests should pass

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514

Srdjan Jankovic  changed:

   What|Removed |Added

 CC||srd...@catalyst.net.nz

--- Comment #5 from Srdjan Jankovic  ---
Applying: Bug 14514 - LocalHoldsPriority and the HoldsQueue conflict with each
other
Using index info to reconstruct a base tree...
M   C4/HoldsQueue.pm
M   t/db_dependent/HoldsQueue.t
Falling back to patching base and 3-way merge...
Auto-merging t/db_dependent/HoldsQueue.t
CONFLICT (content): Merge conflict in t/db_dependent/HoldsQueue.t
Auto-merging C4/HoldsQueue.pm
Failed to merge in the changes.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514

Heather Braum  changed:

   What|Removed |Added

 CC||hbr...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514

--- Comment #4 from Kyle M Hall  ---
(In reply to Aleisha Amohia from comment #3)
Aleisha, all the tests pass on my test server. Can you try running the tests on
a clean installation of Koha with just the default data installed? If they pass
for you that way, it means I need to fix my db assumptions for my unit tests.

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514

Aleisha Amohia  changed:

   What|Removed |Added

 CC||aleishaamo...@hotmail.com
 Status|Needs Signoff   |Failed QA

--- Comment #3 from Aleisha Amohia  ---
t/db_dependent/HoldsQueue.t .. 1/27 
#   Failed test 'Holds queue giving priority to patron who's home library
matches item's home library'
#   at t/db_dependent/HoldsQueue.t line 333.
#  got: 'cdoBnBl'
# expected: 'pkSI5p'

#   Failed test 'Holds queue giving priority to patron who's home library
matches item's holding library'
#   at t/db_dependent/HoldsQueue.t line 350.
#  got: 'cdoBnBl'
# expected: 'pkSI5p'

#   Failed test 'Holds queue giving priority to patron who's home library
matches item's holding library'
#   at t/db_dependent/HoldsQueue.t line 367.
#  got: 'cdoBnBl'
# expected: 'pkSI5p'

#   Failed test 'Holds queue giving priority to patron who's home library
matches item's holding library'
#   at t/db_dependent/HoldsQueue.t line 384.
#  got: 'cdoBnBl'
# expected: 'pkSI5p'

#   Failed test 'Bug 15062 - Holds queue with Transport Cost Matrix will
transfer item even if transfers disabled'
#   at t/db_dependent/HoldsQueue.t line 492.
#  got: '1'
# expected: '0'
# Looks like you failed 5 tests of 27.
t/db_dependent/HoldsQueue.t .. Dubious, test returned 5 (wstat 1280, 0x500)
Failed 5/27 subtests 

Test Summary Report
---
t/db_dependent/HoldsQueue.t (Wstat: 1280 Tests: 27 Failed: 5)
  Failed tests:  22-25, 27
  Non-zero exit status: 5
Files=1, Tests=27,  1 wallclock secs ( 0.03 usr  0.01 sys +  1.13 cusr  0.09
csys =  1.26 CPU)
Result: FAIL

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514

Kyle M Hall  changed:

   What|Removed |Added

   Severity|enhancement |normal
   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514

--- Comment #1 from Kyle M Hall  ---
Created attachment 47654
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47654=edit
Bug 14514 - LocalHoldsPriority and the HoldsQueue conflict with each other

It appears that the LocalHoldsPriority feature and the Holds Queue are
fundamentally at odds with each other.

The problem appears to be that both are attempting to choose the best
way to fill holds. When you are using the holds queue and you check in
an item that has been selected by the holds queue builder, that part of
Koha where the LocalHoldsPriority feature lives doesn't get to see all
the holds in order to pick the best one. Instead only the hold selected
by the holds queue builder is returned so to the LocalHoldsPriority
feature, that is only one hold to pick from!

Test Plan:
1) Apply this patch
2) prove t/db_dependent/HoldsQueue.t
3) All tests should pass

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #47654|0   |1
is obsolete||

--- Comment #2 from Kyle M Hall  ---
Created attachment 47655
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47655=edit
Bug 14514 - LocalHoldsPriority and the HoldsQueue conflict with each other

It appears that the LocalHoldsPriority feature and the Holds Queue are
fundamentally at odds with each other.

The problem appears to be that both are attempting to choose the best
way to fill holds. When you are using the holds queue and you check in
an item that has been selected by the holds queue builder, that part of
Koha where the LocalHoldsPriority feature lives doesn't get to see all
the holds in order to pick the best one. Instead only the hold selected
by the holds queue builder is returned so to the LocalHoldsPriority
feature, that is only one hold to pick from!

Test Plan:
1) Apply this patch
2) prove t/db_dependent/HoldsQueue.t
3) All tests should pass

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14514] LocalHoldsPriority and the HoldsQueue conflict with each other

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14514

Joel Sasse jsa...@plumcreeklibrary.net changed:

   What|Removed |Added

 CC||jsa...@plumcreeklibrary.net

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/