[Koha-bugs] [Bug 14543] Order lines updated that have a tax rate not in gist will have tax rate set to 0!

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14543

--- Comment #18 from Victor Grousset/tuxayo  ---
Can't backport to 19.05.x: can't solve a conflict.
If there is an interest in having this backported, feel free to submit a patch
for 19.05.

The following part of the conflict must considered carefully:

Not sure if it's

[% END %]
[% IF !gst_found %]Tax rate not
defined in system preference gist![% END %]

or


[% IF !gst_found %]Tax rate not
defined in system preference gist![% END %]
[% END %]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14543] Order lines updated that have a tax rate not in gist will have tax rate set to 0!

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14543

Aleisha Amohia  changed:

   What|Removed |Added

 Version(s)|20.11.00, 20.05.01  |20.11.00, 20.05.01,
released in||19.11.07
 Status|Pushed to stable|Pushed to oldstable
 CC||alei...@catalyst.net.nz

--- Comment #17 from Aleisha Amohia  ---
backported to 19.11.x for 19.11.07

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14543] Order lines updated that have a tax rate not in gist will have tax rate set to 0!

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14543

Lucas Gass  changed:

   What|Removed |Added

 Status|Pushed to master|Pushed to stable
 Version(s)|20.11.00|20.11.00, 20.05.01
released in||
 CC||lu...@bywatersolutions.com

--- Comment #16 from Lucas Gass  ---
backported to 20.05.x for 20.05.01

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14543] Order lines updated that have a tax rate not in gist will have tax rate set to 0!

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14543

Jonathan Druart  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to master
 Version(s)||20.11.00
released in||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14543] Order lines updated that have a tax rate not in gist will have tax rate set to 0!

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14543

--- Comment #15 from Jonathan Druart  
---
Pushed to master for 20.11, thanks to everybody involved!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14543] Order lines updated that have a tax rate not in gist will have tax rate set to 0!

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14543

Martin Renvoize  changed:

   What|Removed |Added

 Attachment #105404|0   |1
is obsolete||

--- Comment #12 from Martin Renvoize  ---
Created attachment 105629
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105629=edit
Bug 14543: Order lines updated that have a tax rate not in gist will have tax
rate set to 0!

If the tax rate for a given order line has been removed from the system
preference gist, that tax rate will show in the pulldown as 0. If a
librarian then saves the order line the original tax rate will be
overwritten with 0%!

Test Plan:
1) Find an order line
2) Remove the tax rate set for that order line from the syspref gist
3) Edit the order line
4) Note the tax rate is 0
5) Apply this patch
6) Edit the order line
7) Note the tax rate now displays with a warning

Signed-off-by: Victor Grousset/tuxayo 
Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14543] Order lines updated that have a tax rate not in gist will have tax rate set to 0!

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14543

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
 Status|Signed Off  |Passed QA

--- Comment #14 from Martin Renvoize  ---
Works as expected, with QA followup we pass the QA scripts.

Passing QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14543] Order lines updated that have a tax rate not in gist will have tax rate set to 0!

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14543

--- Comment #13 from Martin Renvoize  ---
Created attachment 105630
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105630=edit
Bug 14543: (QA follow-up) Add missing filter

This patch adds a missing `| html` filter to the tax_rate value option
that the patchset adds

Signed-off-by: Martin Renvoize 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14543] Order lines updated that have a tax rate not in gist will have tax rate set to 0!

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14543

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 CC||vic...@tuxayo.net
 Status|Needs Signoff   |Signed Off

--- Comment #11 from Victor Grousset/tuxayo  ---
It works! :D

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14543] Order lines updated that have a tax rate not in gist will have tax rate set to 0!

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14543

Victor Grousset/tuxayo  changed:

   What|Removed |Added

 Attachment #105181|0   |1
is obsolete||

--- Comment #10 from Victor Grousset/tuxayo  ---
Created attachment 105404
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105404=edit
Bug 14543: Order lines updated that have a tax rate not in gist will have tax
rate set to 0!

If the tax rate for a given order line has been removed from the system
preference gist, that tax rate will show in the pulldown as 0. If a
librarian then saves the order line the original tax rate will be
overwritten with 0%!

Test Plan:
1) Find an order line
2) Remove the tax rate set for that order line from the syspref gist
3) Edit the order line
4) Note the tax rate is 0
5) Apply this patch
6) Edit the order line
7) Note the tax rate now displays with a warning

Signed-off-by: Victor Grousset/tuxayo 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14543] Order lines updated that have a tax rate not in gist will have tax rate set to 0!

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14543

Katrin Fischer  changed:

   What|Removed |Added

 Status|Needs Signoff   |Failed QA

--- Comment #8 from Katrin Fischer  ---
Hi Kyle, I tested this, but it doesn't return the item for me :(

There is no error in the logs - just some debug information:
[Fri May 22 11:02:55 2020] [debug] 201 Created (0.0484s, 20.661/s)
[Fri May 22 11:08:03 2020] [debug] POST "/api/v1/return_claims"
[Fri May 22 11:08:03 2020] [debug] Routing to controller "Koha::REST::V1::Auth"
and action "under"
[Fri May 22 11:08:03 2020] [debug] Routing to controller
"Koha::REST::V1::ReturnClaims" and action "claim_returned"



I think we also need to update the options in sysprefs.sql and maybe have a
database update as well.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14543] Order lines updated that have a tax rate not in gist will have tax rate set to 0!

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14543

Katrin Fischer  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

--- Comment #9 from Katrin Fischer  ---
Sorry, wrong tab, wrong bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14543] Order lines updated that have a tax rate not in gist will have tax rate set to 0!

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14543

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #95943|0   |1
is obsolete||

--- Comment #6 from Jonathan Druart  
---
Created attachment 105181
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105181=edit
Bug 14543: Order lines updated that have a tax rate not in gist will have tax
rate set to 0!

If the tax rate for a given order line has been removed from the system
preference gist, that tax rate will show in the pulldown as 0. If a
librarian then saves the order line the original tax rate will be
overwritten with 0%!

Test Plan:
1) Find an order line
2) Remove the tax rate set for that order line from the syspref gist
3) Edit the order line
4) Note the tax rate is 0
5) Apply this patch
6) Edit the order line
7) Note the tax rate now displays with a warning

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14543] Order lines updated that have a tax rate not in gist will have tax rate set to 0!

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14543

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14543] Order lines updated that have a tax rate not in gist will have tax rate set to 0!

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14543

Lisette Scheer  changed:

   What|Removed |Added

 CC||lisettesla...@gmail.com
 Status|Needs Signoff   |Failed QA

--- Comment #5 from Lisette Scheer  ---
It doesn't warn, but it does keep the old GST even once it has been removed
from the gist sys pref. 
I tested in a sandbox.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14543] Order lines updated that have a tax rate not in gist will have tax rate set to 0!

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14543

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #95942|0   |1
is obsolete||

--- Comment #4 from Jonathan Druart  
---
Created attachment 95943
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95943=edit
Bug 14543: Order lines updated that have a tax rate not in gist will have tax
rate set to 0!

If the tax rate for a given order line has been removed from the system
preference gist, that tax rate will show in the pulldown as 0. If a
librarian then saves the order line the original tax rate will be
overwritten with 0%!

Test Plan:
1) Find an order line
2) Remove the tax rate set for that order line from the syspref gist
3) Edit the order line
4) Note the tax rate is 0
5) Apply this patch
6) Edit the order line
7) Note the tax rate now displays with a warning

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14543] Order lines updated that have a tax rate not in gist will have tax rate set to 0!

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14543

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #41033|0   |1
is obsolete||

--- Comment #3 from Jonathan Druart  
---
Created attachment 95942
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95942=edit
Bug 14543: Order lines updated that have a tax rate not in gist will have tax
rate set to 0!

If the tax rate for a given order line has been removed from the system
preference gist, that tax rate will show in the pulldown as 0. If a
librarian then saves the order line the original tax rate will be
overwritten with 0%!

Test Plan:
1) Find an order line
2) Remove the tax rate set for that order line from the syspref gist
3) Edit the order line
4) Note the tax rate is 0
5) Apply this patch
6) Edit the order line
7) Note the tax rate now displays with a warning

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14543] Order lines updated that have a tax rate not in gist will have tax rate set to 0!

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14543

Jonathan Druart  changed:

   What|Removed |Added

 Status|BLOCKED |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14543] Order lines updated that have a tax rate not in gist will have tax rate set to 0!

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14543

Jonathan Druart  changed:

   What|Removed |Added

 Status|Needs Signoff   |BLOCKED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14543] Order lines updated that have a tax rate not in gist will have tax rate set to 0!

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14543

Jonathan Druart jonathan.dru...@bugs.koha-community.org changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #2 from Jonathan Druart jonathan.dru...@bugs.koha-community.org 
---
I would be happy to test this patch if it was not dependent on bug 14541.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14543] Order lines updated that have a tax rate not in gist will have tax rate set to 0!

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14543

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

   Assignee|koha-b...@lists.koha-commun |k...@bywatersolutions.com
   |ity.org |

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14543] Order lines updated that have a tax rate not in gist will have tax rate set to 0!

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14543

--- Comment #1 from Kyle M Hall k...@bywatersolutions.com ---
Created attachment 41033
  --
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=41033action=edit
Bug 14543 - Order lines updated that have a tax rate not in gist will have tax
rate set to 0!

If the tax rate for a given order line has been removed from the system
preference gist, that tax rate will show in the pulldown as 0. If a
librarian then saves the order line the original tax rate will be
overwritten with 0%!

Test Plan:
1) Find an order line
2) Remove the tax rate set for that order line from the syspref gist
3) Edit the order line
4) Note the tax rate is 0
5) Apply this patch
6) Edit the order line
7) Note the tax rate now displays with a warning

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14543] Order lines updated that have a tax rate not in gist will have tax rate set to 0!

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14543

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Depends on||14541


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14541
[Bug 14541] Tax rate should not be forced to an arbitrary precision
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14543] Order lines updated that have a tax rate not in gist will have tax rate set to 0!

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14543

Kyle M Hall k...@bywatersolutions.com changed:

   What|Removed |Added

 Status|NEW |Needs Signoff
   Patch complexity|--- |Trivial patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/