[Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/ guarantee

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||19382


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19382
[Bug 19382] Add ability to block guarantees based on fees owed by guarantor and
other guarantees
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/ guarantee

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577

Nicole C. Engard  changed:

   What|Removed |Added

 CC|neng...@gmail.com   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/ guarantee

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577

Nicole C. Engard  changed:

   What|Removed |Added

 CC||a...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||16405


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16405
[Bug 16405] Fix Circulation/NoIssuesChargeGuarantees.t test 2
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #19 from Kyle M Hall  ---
Pushed to master for the May 2016 release!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||14570


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570
[Bug 14570] Make it possible to add multiple guarantors to a record
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577

--- Comment #18 from Kyle M Hall  ---
Created attachment 50835
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50835=edit
Bug 14577 [QA Followup]

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #49303|0   |1
is obsolete||
  Attachment #49304|0   |1
is obsolete||

--- Comment #17 from Kyle M Hall  ---
Created attachment 50834
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50834=edit
Bug 14577 - Allow restriction of checkouts based on fines of guarantor's
guarantees

This enhancment allows a library to prevent patrons from checking out
items if his or her guarantees own too much.

Test Plan:
1) Apply this patch
2) Find or create a patron with a guarantor
3) Add a fine to the patron's account
4) Set the new system preference NoIssuesChargeGuarantees to be less
   than the amount owed by the patron
4) Attempt to check out an item to the guarantor, you will either
   be warned or prevented from checking out based on your system
   settings.

Signed-off-by: Cathi Wiggin 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577

Kyle M Hall  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Passed QA

--- Comment #16 from Kyle M Hall  ---
(In reply to Brendan Gallagher from comment #15)
> Didn't apply cleanly

Odd, it seems to apply cleanly now!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577

Brendan Gallagher  changed:

   What|Removed |Added

 CC||bren...@bywatersolutions.co
   ||m
 Status|Passed QA   |Patch doesn't apply

--- Comment #15 from Brendan Gallagher  ---
Didn't apply cleanly

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577

--- Comment #12 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #9)

> - circ/circulation_batch_checkouts.tt will need to be modified too

Fixed!

> - The tests in Patron.t are not necessary. It's covered by
> t/db_dependent/Koha/Patrons.t

Fixed!

> ::: C4/Circulation.pm
> @@ +852,5 @@
> >  my $allfinesneedoverride = 
> > C4::Context->preference("AllFinesNeedOverride");
> > +
> > +# Check the debt of this patrons guarantees
> > +my $no_issues_charge_guarantees = 
> > C4::Context->preference("NoIssuesChargeGuarantees");
> > +$no_issues_charge_guarantees = undef unless looks_like_number( 
> > $no_issues_charge_guarantees );
> 
> Is there a difference with 'defined $a && $a > 0'?

It's a safety check in case some puts a non-number in the system preference (
since it's free text ).

> @@ +867,5 @@
> > +$issuingimpossible{DEBT_GUARANTEES} = sprintf( "%.2f", 
> > $guarantees_non_issues_charges );
> > +} elsif ( $guarantees_non_issues_charges > 
> > $no_issues_charge_guarantees && !$inprocess && $allowfineoverride) {
> > +$needsconfirmation{DEBT_GUARANTEES} = sprintf( "%.2f", 
> > $guarantees_non_issues_charges );
> > +} elsif ( $allfinesneedoverride && $guarantees_non_issues_charges 
> > > 0 && $guarantees_non_issues_charges <= $no_issues_charge_guarantees && 
> > !$inprocess ) {
> > +$needsconfirmation{DEBT_GUARANTEES} = sprintf( "%.2f", 
> > $guarantees_non_issues_charges );
> 
> It would be better to use the Price TT plugin to display these values.

Fixed!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577

--- Comment #14 from Jonathan Druart  
---
Created attachment 49304
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49304=edit
Bug 14577 [QA Followup]

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #49036|0   |1
is obsolete||

--- Comment #10 from Kyle M Hall  ---
Created attachment 49236
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49236=edit
Bug 14577 - Allow restriction of checkouts based on fines of guarantor's
guarantees

This enhancment allows a library to prevent patrons from checking out
items if his or her guarantees own too much.

Test Plan:
1) Apply this patch
2) Find or create a patron with a guarantor
3) Add a fine to the patron's account
4) Set the new system preference NoIssuesChargeGuarantees to be less
   than the amount owed by the patron
4) Attempt to check out an item to the guarantor, you will either
   be warned or prevented from checking out based on your system
   settings.

Signed-off-by: Cathi Wiggin 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577

--- Comment #11 from Kyle M Hall  ---
Created attachment 49237
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49237=edit
Bug 14577 [QA Followup]

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #49236|0   |1
is obsolete||
  Attachment #49237|0   |1
is obsolete||

--- Comment #13 from Jonathan Druart  
---
Created attachment 49303
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49303=edit
Bug 14577 - Allow restriction of checkouts based on fines of guarantor's
guarantees

This enhancment allows a library to prevent patrons from checking out
items if his or her guarantees own too much.

Test Plan:
1) Apply this patch
2) Find or create a patron with a guarantor
3) Add a fine to the patron's account
4) Set the new system preference NoIssuesChargeGuarantees to be less
   than the amount owed by the patron
4) Attempt to check out an item to the guarantor, you will either
   be warned or prevented from checking out based on your system
   settings.

Signed-off-by: Cathi Wiggin 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577

--- Comment #9 from Jonathan Druart  
---
Comment on attachment 49036
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49036
Bug 14577 - Allow restriction of checkouts based on fines of guarantor's
guarantees

Review of attachment 49036:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=14577=49036)
-

- circ/circulation_batch_checkouts.tt will need to be modified too

- The tests in Patron.t are not necessary. It's covered by
t/db_dependent/Koha/Patrons.t

::: C4/Circulation.pm
@@ +852,5 @@
>  my $allfinesneedoverride = 
> C4::Context->preference("AllFinesNeedOverride");
> +
> +# Check the debt of this patrons guarantees
> +my $no_issues_charge_guarantees = 
> C4::Context->preference("NoIssuesChargeGuarantees");
> +$no_issues_charge_guarantees = undef unless looks_like_number( 
> $no_issues_charge_guarantees );

Is there a difference with 'defined $a && $a > 0'?

@@ +867,5 @@
> +$issuingimpossible{DEBT_GUARANTEES} = sprintf( "%.2f", 
> $guarantees_non_issues_charges );
> +} elsif ( $guarantees_non_issues_charges > 
> $no_issues_charge_guarantees && !$inprocess && $allowfineoverride) {
> +$needsconfirmation{DEBT_GUARANTEES} = sprintf( "%.2f", 
> $guarantees_non_issues_charges );
> +} elsif ( $allfinesneedoverride && $guarantees_non_issues_charges > 
> 0 && $guarantees_non_issues_charges <= $no_issues_charge_guarantees && 
> !$inprocess ) {
> +$needsconfirmation{DEBT_GUARANTEES} = sprintf( "%.2f", 
> $guarantees_non_issues_charges );

It would be better to use the Price TT plugin to display these values.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577

Kyle M Hall  changed:

   What|Removed |Added

 Depends on||15656


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15656
[Bug 15656] Move the guarantor/guarantees code to Koha::Patron
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #48784|0   |1
is obsolete||

--- Comment #8 from Kyle M Hall  ---
Created attachment 49036
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49036=edit
Bug 14577 - Allow restriction of checkouts based on fines of guarantor's
guarantees

This enhancment allows a library to prevent patrons from checking out
items if his or her guarantees own too much.

Test Plan:
1) Apply this patch
2) Find or create a patron with a guarantor
3) Add a fine to the patron's account
4) Set the new system preference NoIssuesChargeGuarantees to be less
   than the amount owed by the patron
4) Attempt to check out an item to the guarantor, you will either
   be warned or prevented from checking out based on your system
   settings.

Signed-off-by: Cathi Wiggin 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #7 from Jonathan Druart  
---
I have added the Koha::Patron->guarantees method for bug 15656. Do you mind
rebasing this new enhancement on top of it?
I have provided much more tests and it has reached the QA queue 1 month ago.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577

Nicole C. Engard  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577

Nicole C. Engard  changed:

   What|Removed |Added

  Attachment #48759|0   |1
is obsolete||

--- Comment #6 from Nicole C. Engard  ---
Created attachment 48784
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48784=edit
Bug 14577 - Allow restriction of checkouts based on fines of guarantor's
guarantees

This enhancment allows a library to prevent patrons from checking out
items if his or her guarantees own too much.

Test Plan:
1) Apply this patch
2) Find or create a patron with a guarantor
3) Add a fine to the patron's account
4) Set the new system preference NoIssuesChargeGuarantees to be less
   than the amount owed by the patron
4) Attempt to check out an item to the guarantor, you will either
   be warned or prevented from checking out based on your system
   settings.

Signed-off-by: Cathi Wiggin 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577

Nicole C. Engard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #5 from Nicole C. Engard  ---
Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 14577 - Allow restriction of checkouts based on fines of
guarantor's guarantees
Using index info to reconstruct a base tree...
M   C4/Circulation.pm
M   installer/data/mysql/sysprefs.sql
M  
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
Falling back to patching base and 3-way merge...
Auto-merging
koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref
Auto-merging installer/data/mysql/sysprefs.sql
Auto-merging C4/Circulation.pm
Auto packing the repository in background for optimum performance.
See "git help gc" for manual housekeeping.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #48639|0   |1
is obsolete||

--- Comment #4 from Kyle M Hall  ---
Created attachment 48759
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48759=edit
Bug 14577 - Allow restriction of checkouts based on fines of guarantor's
guarantees

This enhancment allows a library to prevent patrons from checking out
items if his or her guarantees own too much.

Test Plan:
1) Apply this patch
2) Find or create a patron with a guarantor
3) Add a fine to the patron's account
4) Set the new system preference NoIssuesChargeGuarantees to be less
   than the amount owed by the patron
4) Attempt to check out an item to the guarantor, you will either
   be warned or prevented from checking out based on your system
   settings.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #48632|0   |1
is obsolete||

--- Comment #3 from Kyle M Hall  ---
Created attachment 48639
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48639=edit
Bug 14577 - Allow restriction of checkouts based on fines of guarantor's
guarantees

This enhancment allows a library to prevent patrons from checking out
items if his or her guarantees own too much.

Test Plan:
1) Apply this patch
2) Find or create a patron with a guarantor
3) Add a fine to the patron's account
4) Set the new system preference NoIssuesChargeGuarantees to be less
   than the amount owed by the patron
4) Attempt to check out an item to the guarantor, you will either
   be warned or prevented from checking out based on your system
   settings.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577

Kyle M Hall  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #47936|0   |1
is obsolete||

--- Comment #2 from Kyle M Hall  ---
Created attachment 48632
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48632=edit
Bug 14577 - Allow restriction of checkouts based on fines of guarantor's
guarantees

This enhancment allows a library to prevent patrons from checking out
items if his or her guarantees own too much.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577

--- Comment #1 from Kyle M Hall  ---
Created attachment 47936
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47936=edit
Bug 14577 - Allow restriction of checkouts based on fines of guarantor's
guarantees

This enhancment allows a library to prevent patrons from checking out
items if his or her guarantees own too much.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|jwea...@bywatersolutions.co |k...@bywatersolutions.com
   |m   |
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577

Nicole C. Engard  changed:

   What|Removed |Added

 CC||neng...@gmail.com
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577

Heather Braum  changed:

   What|Removed |Added

 CC||hbr...@nekls.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14577] Allow restriction of checkouts based on fines of guarantor/guarantee

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14577

Nicole Engard (ByWater) nic...@bywatersolutions.com changed:

   What|Removed |Added

 CC||nic...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/