[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Martin Renvoize  changed:

   What|Removed |Added

 Blocks|15276   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15276
[Bug 15276] Add documentation for Template Toolkit syntax for slips and notices
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Martin Renvoize  changed:

   What|Removed |Added

 Blocks||34472


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=34472
[Bug 34472] Template Toolkit reference guide needed
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||26663

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||17976


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17976
[Bug 17976] TT syntax for notices - Add an equivalence for items.fine
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Indranil Das Gupta  changed:

   What|Removed |Added

 CC||indr...@l2c2.co.in

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Lisa  changed:

   What|Removed |Added

 CC||l...@hchlibrary.org

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Mason James  changed:

   What|Removed |Added

 CC||m...@kohaaloha.com

--- Comment #63 from Mason James  ---
(In reply to Kyle M Hall from comment #55)
> Pushed to master for 16.11!

Enhancement, skipping for 16.05.x

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17960


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17960
[Bug 17960] Rename opac_news.new
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Katrin Fischer  changed:

   What|Removed |Added

   See Also||https://bugs.koha-community
   ||.org/bugzilla3/show_bug.cgi
   ||?id=10164

--- Comment #62 from Katrin Fischer  ---
Once implemented shoudl also fix bug 10164.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Nicole C. Engard  changed:

   What|Removed |Added

 CC|neng...@gmail.com   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||17246


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17246
[Bug 17246] GetPreparedLetter should not allow multiple FK defined in arrayref
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

--- Comment #61 from Jonathan Druart  
---
(In reply to Petter Goksøyr Åsen from comment #59)
> I seem to get a lot of failures after this patch.
> 
> I can't get HOLD_SLIP to render without error:
> SQL::Abstract::puke(): [SQL::Abstract::__ANON__] Fatal: unexpected operator
> 'author' with undef operand at /home/vagrant/kohaclone/Koha/Objects.pm line
> 168
> 
> I hooked it up with debugger and it fails in sub _get_tt_params

Bug 16942 should fix this problem.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

--- Comment #60 from Petter Goksøyr Åsen  ---
I managed to fix it by changing the config hash in _get_tt_params:

> git diff
diff --git a/C4/Letters.pm b/C4/Letters.pm
index 737c8cd..c1ef404 100644
--- a/C4/Letters.pm
+++ b/C4/Letters.pm
@@ -1437,7 +1437,7 @@ sub _get_tt_params {
 module   => 'Koha::Holds',
 singular => 'hold',
 plural   => 'holds',
-fk   => [ 'borrowernumber', 'biblionumber' ],
+pk   => 'reserve_id',
 },
 serial => {
 module   => 'Koha::Serials',


But I don't understand this code very well, so you folks have to look at it!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Petter Goksøyr Åsen  changed:

   What|Removed |Added

 CC||boutrosboutrosboutros@gmail
   ||.com

--- Comment #59 from Petter Goksøyr Åsen  ---
I seem to get a lot of failures after this patch.

I can't get HOLD_SLIP to render without error:
SQL::Abstract::puke(): [SQL::Abstract::__ANON__] Fatal: unexpected operator
'author' with undef operand at /home/vagrant/kohaclone/Koha/Objects.pm line 168

I hooked it up with debugger and it fails in sub _get_tt_params

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Katrin Fischer  changed:

   What|Removed |Added

 Blocks||16985


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16985
[Bug 16985] Self registration verification e-mail is broken - no token at the
end of the URL
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

--- Comment #58 from Marcel de Rooy  ---
(In reply to Jonathan Druart from comment #57)
> Kyle, bug 16929 has been introduced by these patches.
> Actually it seems that the changes made to Koha::Patron::Modification[s]
> were not intended. Could you confirm?

Should be bug 16960.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

--- Comment #57 from Jonathan Druart  
---
Kyle, bug 16929 has been introduced by these patches.
Actually it seems that the changes made to Koha::Patron::Modification[s] were
not intended. Could you confirm?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||16960


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16960
[Bug 16960] Patron::Modifications should be fixed
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||16942


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16942
[Bug 16942] Confirm hold results in ugly error
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

--- Comment #56 from Jonathan Druart  
---
(In reply to Kyle M Hall from comment #55)
> Pushed to master for 16.11!
> 
> (In reply to Jonathan Druart from comment #54)
> > Kyle, I have marked this patchset as Passed QA but we still need a patch to
> > take into account the 3 following tables: aqorders, aqbooksellers,
> > biblioitems.
> > I think this could be done on another bug report.
> 
> Yes, I think that's an excellent plan. Can you file the bug report(s) for
> those?

I have opened bug 16883.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||16883


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16883
[Bug 16883] TT syntax for notices should take aqorders, aqbooksellers,
biblioitems tables into account
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Kyle M Hall  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #55 from Kyle M Hall  ---
Pushed to master for 16.11!

(In reply to Jonathan Druart from comment #54)
> Kyle, I have marked this patchset as Passed QA but we still need a patch to
> take into account the 3 following tables: aqorders, aqbooksellers,
> biblioitems.
> I think this could be done on another bug report.

Yes, I think that's an excellent plan. Can you file the bug report(s) for
those?

Thanks!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

--- Comment #54 from Jonathan Druart  
---
Kyle, I have marked this patchset as Passed QA but we still need a patch to
take into account the 3 following tables: aqorders, aqbooksellers, biblioitems.
I think this could be done on another bug report.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

--- Comment #50 from Jonathan Druart  
---
Created attachment 52925
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52925=edit
Bug 14757 [QA Followup] - Add Unit Tests

Signed-off-by: Sean McGarvey 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

--- Comment #52 from Jonathan Druart  
---
Created attachment 52927
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52927=edit
Bug 14757 [QA Followup] - Don't overload new for Modifications

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

--- Comment #51 from Jonathan Druart  
---
Created attachment 52926
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52926=edit
Bug 14757: Add tests for new modules

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

--- Comment #53 from Jonathan Druart  
---
Created attachment 52928
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52928=edit
Bug 14757: Remove obsolete occurrence of is_tt

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52805|0   |1
is obsolete||
  Attachment #52806|0   |1
is obsolete||
  Attachment #52807|0   |1
is obsolete||
  Attachment #52895|0   |1
is obsolete||

--- Comment #49 from Jonathan Druart  
---
Created attachment 52924
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52924=edit
Bug 14757 - Allow the use of Template Toolkit syntax for slips and notices

This bug is the beginning of a conversion from our current bespoke
syntax for slips and notices to Template Toolkit syntax.

This patch is the initial seed which will evolve over time.
With this addition, we can take advantage of our Koha Objects
to greatly simplify the processing of Slips and Notices over time.

Test Plan:
1) Apply this patch
2) Ensure you have the default CHECKOUT notice
3) Check out and return an item for a patron
4) Note the text of the CHECKOUT notice
5) Replace your CHECKOUT notice with the following:

The following items have been checked out:

[% biblio.title %]

Thank you for visiting [% branch.branchname %].

6) Repeat step 3
7) Note the CHECKOUT notice text matches the previous CHECKOUT notice text

Signed-off-by: Bernardo Gonzalez Kriegel 
New notice syntax works, no koha-qa errors

Signed-off-by: Sean McGarvey 

Bug 14757 [QA Followup] - Change method type() to _type() for Koha objects

Signed-off-by: Sean McGarvey 

Bug 14757 [QA Followup] - Change all references to Koha::Borrower to
Koha::Patron

Signed-off-by: Sean McGarvey 

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

--- Comment #48 from Kyle M Hall  ---
Created attachment 52895
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52895=edit
Bug 14757 [QA Followup] - Don't overload new for Modifications

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

--- Comment #47 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #46)
> Kyle,
> I have squashed some patches (they failed qa tools:  FAIL
> Koha/Borrower/Modification.pm FAIL git manipulation: The file has been added
> and deleted in the same patchset) and added tests for the new modules.
> However, I do not understand why you overload the method 
> Koha::Patron::Modifications->new, this should not be needed
> 
> Moreover, the methods of Koha::Patron::Modifications should now use
> snake_case (as they use Koha::Object), but it's outside the scope of this
> bug.

I also don't know why I did that ; )

I will post a followup to remove the new() method, as it is not needed. We
should file a bug to fix the method names fo Koha::Patron::Modifications.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

--- Comment #46 from Jonathan Druart  
---
Kyle,
I have squashed some patches (they failed qa tools:  FAIL
Koha/Borrower/Modification.pm FAIL git manipulation: The file has been added
and deleted in the same patchset) and added tests for the new modules.
However, I do not understand why you overload the method 
Koha::Patron::Modifications->new, this should not be needed

Moreover, the methods of Koha::Patron::Modifications should now use snake_case
(as they use Koha::Object), but it's outside the scope of this bug.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

--- Comment #44 from Jonathan Druart  
---
Created attachment 52806
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52806=edit
Bug 14757 [QA Followup] - Add Unit Tests

Signed-off-by: Sean McGarvey 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

--- Comment #45 from Jonathan Druart  
---
Created attachment 52807
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52807=edit
Bug 14757: Add tests for new modules

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #52758|0   |1
is obsolete||
  Attachment #52759|0   |1
is obsolete||
  Attachment #52760|0   |1
is obsolete||
  Attachment #52761|0   |1
is obsolete||

--- Comment #43 from Jonathan Druart  
---
Created attachment 52805
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52805=edit
Bug 14757 - Allow the use of Template Toolkit syntax for slips and notices

This bug is the beginning of a conversion from our current bespoke
syntax for slips and notices to Template Toolkit syntax.

This patch is the initial seed which will evolve over time.
With this addition, we can take advantage of our Koha Objects
to greatly simplify the processing of Slips and Notices over time.

Test Plan:
1) Apply this patch
2) Ensure you have the default CHECKOUT notice
3) Check out and return an item for a patron
4) Note the text of the CHECKOUT notice
5) Replace your CHECKOUT notice with the following:

The following items have been checked out:

[% biblio.title %]

Thank you for visiting [% branch.branchname %].

6) Repeat step 3
7) Note the CHECKOUT notice text matches the previous CHECKOUT notice text

Signed-off-by: Bernardo Gonzalez Kriegel 
New notice syntax works, no koha-qa errors

Signed-off-by: Sean McGarvey 

Bug 14757 [QA Followup] - Change method type() to _type() for Koha objects

Signed-off-by: Sean McGarvey 

Bug 14757 [QA Followup] - Change all references to Koha::Borrower to
Koha::Patron

Signed-off-by: Sean McGarvey 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Katrin Fischer  changed:

   What|Removed |Added

Version|unspecified |master

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

--- Comment #40 from Kyle M Hall  ---
Created attachment 52759
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52759=edit
Bug 14757 [QA Followup] - Add Unit Tests

Signed-off-by: Sean McGarvey 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

--- Comment #41 from Kyle M Hall  ---
Created attachment 52760
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52760=edit
Bug 14757 [QA Followup] - Change method type() to _type() for Koha objects

Signed-off-by: Sean McGarvey 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

--- Comment #42 from Kyle M Hall  ---
Created attachment 52761
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52761=edit
Bug 14757 [QA Followup] - Change all references to Koha::Borrower to
Koha::Patron

Signed-off-by: Sean McGarvey 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #48806|0   |1
is obsolete||
  Attachment #48807|0   |1
is obsolete||
  Attachment #48808|0   |1
is obsolete||
  Attachment #48809|0   |1
is obsolete||
  Attachment #48810|0   |1
is obsolete||

--- Comment #39 from Kyle M Hall  ---
Created attachment 52758
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=52758=edit
Bug 14757 - Allow the use of Template Toolkit syntax for slips and notices

This bug is the beginning of a conversion from our current bespoke
syntax for slips and notices to Template Toolkit syntax.

This patch is the initial seed which will evolve over time.
With this addition, we can take advantage of our Koha Objects
to greatly simplify the processing of Slips and Notices over time.

Test Plan:
1) Apply this patch
2) Ensure you have the default CHECKOUT notice
3) Check out and return an item for a patron
4) Note the text of the CHECKOUT notice
5) Replace your CHECKOUT notice with the following:

The following items have been checked out:

[% biblio.title %]

Thank you for visiting [% branch.branchname %].

6) Repeat step 3
7) Note the CHECKOUT notice text matches the previous CHECKOUT notice text

Signed-off-by: Bernardo Gonzalez Kriegel 
New notice syntax works, no koha-qa errors

Signed-off-by: Sean McGarvey 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Nicole C. Engard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

--- Comment #38 from Nicole C. Engard  ---
We were holding on this until 16.05 was released and it's blocking 15969 which
we have a partner waiting on. Can we QA this one now?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Nicole C. Engard  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff
 CC||neng...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

--- Comment #37 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #36)
> I don't need anything else (for bug 15705) apart from the patches from this
> bug report. But I think it would be good to agree on the next steps.
> For instance, my note on comment 31 is still valid:
> > We cannot update the notices with the TT syntax and set the pref off by 
> > default.

Right, considering the number of blocked patches, I think it would make the
most sense for the setting to be enabled by default in this patch set. I'll add
a followup to do that.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

--- Comment #36 from Jonathan Druart  
---
I don't need anything else (for bug 15705) apart from the patches from this bug
report. But I think it would be good to agree on the next steps.
For instance, my note on comment 31 is still valid:
> We cannot update the notices with the TT syntax and set the pref off by 
> default.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

--- Comment #35 from Kyle M Hall  ---
(In reply to Jonathan Druart from comment #31)
> Kyle,
> Could you detail the plan for the dependent bugs please?
> You are adding a new pref and a new DB column (letter.is_tt) in this patch
> but they are not used in other patches.
> We cannot update the notices with the TT syntax and set the pref off by
> default.

The other patches will need to be updated. Are there any changes to this patch
set specifically that you need, or shall I go ahead and update all the
dependent patches?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

--- Comment #34 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #33)
> Is the status here correct? Should it be failed QA?

More or less the same, we need a new patch.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

--- Comment #33 from Katrin Fischer  ---
Is the status here correct? Should it be failed QA?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |ASSIGNED

--- Comment #32 from Jonathan Druart  
---
That needs some more works.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

--- Comment #31 from Jonathan Druart  
---
Kyle,
Could you detail the plan for the dependent bugs please?
You are adding a new pref and a new DB column (letter.is_tt) in this patch but
they are not used in other patches.
We cannot update the notices with the TT syntax and set the pref off by
default.

I'd like to QA this patch set and the others in one go.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Nicole C. Engard  changed:

   What|Removed |Added

  Attachment #48620|0   |1
is obsolete||

--- Comment #27 from Nicole C. Engard  ---
Created attachment 48807
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48807=edit
Bug 14757 [QA Followup] - Add Unit Tests

Signed-off-by: Sean McGarvey 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Nicole C. Engard  changed:

   What|Removed |Added

  Attachment #48622|0   |1
is obsolete||

--- Comment #29 from Nicole C. Engard  ---
Created attachment 48809
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48809=edit
Bug 14757 [QA Followup] - Change method type() to _type() for Koha objects

Signed-off-by: Sean McGarvey 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Nicole C. Engard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Nicole C. Engard  changed:

   What|Removed |Added

  Attachment #48805|0   |1
is obsolete||

--- Comment #30 from Nicole C. Engard  ---
Created attachment 48810
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48810=edit
Bug 14757 [QA Followup] - Change all references to Koha::Borrower to
Koha::Patron

Signed-off-by: Sean McGarvey 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Nicole C. Engard  changed:

   What|Removed |Added

  Attachment #48619|0   |1
is obsolete||

--- Comment #26 from Nicole C. Engard  ---
Created attachment 48806
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48806=edit
Bug 14757 - Allow the use of Template Toolkit syntax for slips and notices

This bug is the beginning of a conversion from our current bespoke
syntax for slips and notices to Template Toolkit syntax.

This patch is the initial seed which will evolve over time.
With this addition, we can take advantage of our Koha Objects
to greatly simplify the processing of Slips and Notices over time.

Test Plan:
1) Apply this patch
2) Ensure you have the default CHECKOUT notice
3) Check out and return an item for a patron
4) Note the text of the CHECKOUT notice
5) Replace your CHECKOUT notice with the following:

The following items have been checked out:

[% biblio.title %]

Thank you for visiting [% branch.branchname %].

6) Repeat step 3
7) Note the CHECKOUT notice text matches the previous CHECKOUT notice text

Signed-off-by: Bernardo Gonzalez Kriegel 
New notice syntax works, no koha-qa errors

Signed-off-by: Sean McGarvey 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Nicole C. Engard  changed:

   What|Removed |Added

  Attachment #48621|0   |1
is obsolete||

--- Comment #28 from Nicole C. Engard  ---
Created attachment 48808
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48808=edit
Bug 14757 [QA Followup] - Make the use of TT a controllable switch, hide it
behind a syspref

Signed-off-by: Sean McGarvey 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

--- Comment #25 from Kyle M Hall  ---
Created attachment 48805
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48805=edit
Bug 14757 [QA Followup] - Change all references to Koha::Borrower to
Koha::Patron

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||15969


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969
[Bug 15969] Allow use of Template Toolkit syntax for Phone Notices
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #48498|0   |1
is obsolete||
  Attachment #48499|0   |1
is obsolete||
  Attachment #48500|0   |1
is obsolete||

--- Comment #21 from Kyle M Hall  ---
Created attachment 48619
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48619=edit
Bug 14757 - Allow the use of Template Toolkit syntax for slips and notices

This bug is the beginning of a conversion from our current bespoke
syntax for slips and notices to Template Toolkit syntax.

This patch is the initial seed which will evolve over time.
With this addition, we can take advantage of our Koha Objects
to greatly simplify the processing of Slips and Notices over time.

Test Plan:
1) Apply this patch
2) Ensure you have the default CHECKOUT notice
3) Check out and return an item for a patron
4) Note the text of the CHECKOUT notice
5) Replace your CHECKOUT notice with the following:

The following items have been checked out:

[% biblio.title %]

Thank you for visiting [% branch.branchname %].

6) Repeat step 3
7) Note the CHECKOUT notice text matches the previous CHECKOUT notice text

Signed-off-by: Bernardo Gonzalez Kriegel 
New notice syntax works, no koha-qa errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

--- Comment #23 from Kyle M Hall  ---
Created attachment 48621
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48621=edit
Bug 14757 [QA Followup] - Make the use of TT a controllable switch, hide it
behind a syspref

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

--- Comment #22 from Kyle M Hall  ---
Created attachment 48620
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48620=edit
Bug 14757 [QA Followup] - Add Unit Tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

--- Comment #24 from Kyle M Hall  ---
Created attachment 48622
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48622=edit
Bug 14757 [QA Followup] - Change method type() to _type() for Koha objects

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Kyle M Hall  changed:

   What|Removed |Added

 Blocks|14758   |


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14758
[Bug 14758] Re-engineer Talking Tech support in Koha
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

--- Comment #20 from Kyle M Hall  ---
Created attachment 48500
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48500=edit
Bug 14757 [QA Followup] - Make the use of TT a controllable switch, hide it
behind a syspref

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

--- Comment #19 from Kyle M Hall  ---
Created attachment 48499
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48499=edit
Bug 14757 [QA Followup] - Add Unit Tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #47176|0   |1
is obsolete||
  Attachment #47177|0   |1
is obsolete||
  Attachment #47866|0   |1
is obsolete||

--- Comment #18 from Kyle M Hall  ---
Created attachment 48498
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=48498=edit
Bug 14757 - Allow the use of Template Toolkit syntax for slips and notices

This bug is the beginning of a conversion from our current bespoke
syntax for slips and notices to Template Toolkit syntax.

This patch is the initial seed which will evolve over time.
With this addition, we can take advantage of our Koha Objects
to greatly simplify the processing of Slips and Notices over time.

Test Plan:
1) Apply this patch
2) Ensure you have the default CHECKOUT notice
3) Check out and return an item for a patron
4) Note the text of the CHECKOUT notice
5) Replace your CHECKOUT notice with the following:

The following items have been checked out:

[% biblio.title %]

Thank you for visiting [% branch.branchname %].

6) Repeat step 3
7) Note the CHECKOUT notice text matches the previous CHECKOUT notice text

Signed-off-by: Bernardo Gonzalez Kriegel 
New notice syntax works, no koha-qa errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

--- Comment #16 from Kyle M Hall  ---
Created attachment 47865
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47865=edit
Bug 14757 [QA Followup] - Make the use of TT a controllable switch, hide it
behind a syspref

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Kyle M Hall  changed:

   What|Removed |Added

 Status|In Discussion   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #47865|0   |1
is obsolete||

--- Comment #17 from Kyle M Hall  ---
Created attachment 47866
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47866=edit
Bug 14757 [QA Followup] - Make the use of TT a controllable switch, hide it
behind a syspref

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |In Discussion

--- Comment #15 from Jonathan Druart  
---
Switch to "In discussion' according to the ML thread.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

--- Comment #14 from Bob Birchall  ---
(In reply to Kyle M Hall from comment #13)

> The current plan is to make this work with minimal or no changes! You can
> check out the mailing list thread for the on-going discussion.

For me, the discussion has led to a great outcome.  I'm happy for this to
proceed.  Thank you!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Nicole C. Engard  changed:

   What|Removed |Added

 Blocks||10708


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10708
[Bug 10708] make fine receipt customizable
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

--- Comment #13 from Kyle M Hall  ---
(In reply to Bob Birchall from comment #12)
> (In reply to Kyle M Hall from comment #0)
> > We should enable TT syntax for slips and notices. This could work side by
> > side with the existing syntax parser for a release or two before we
> > officially remove our bespoke parsing code for slips and notices, giving
> > libraries ample time to switch over.
> 
> I endorse the comments by Jonathan and Katrin that libraries must be able to
> edit their own notices.  They need a simple interface in which to do that
> and good documentation.
> 
> I'm also concerned about the potential cost of this change, for a support
> company and also for any large consortium that has notices defined
> separately by branch.  If every notice in use at every client needs at best
> examination and at worst to be re-written, that's a bit daunting.  Is that
> the implication?

The current plan is to make this work with minimal or no changes! You can check
out the mailing list thread for the on-going discussion.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

--- Comment #12 from Bob Birchall  ---
(In reply to Kyle M Hall from comment #0)
> We should enable TT syntax for slips and notices. This could work side by
> side with the existing syntax parser for a release or two before we
> officially remove our bespoke parsing code for slips and notices, giving
> libraries ample time to switch over.

I endorse the comments by Jonathan and Katrin that libraries must be able to
edit their own notices.  They need a simple interface in which to do that and
good documentation.

I'm also concerned about the potential cost of this change, for a support
company and also for any large consortium that has notices defined separately
by branch.  If every notice in use at every client needs at best examination
and at worst to be re-written, that's a bit daunting.  Is that the implication?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Bob Birchall  changed:

   What|Removed |Added

 CC||b...@calyx.net.au

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #11 from Katrin Fischer  ---
> The existing syntax is quite easy to understand/modify for everybody, but
> the TT syntax is not.
> I would like to see a discussion on koha-devel to know if everybody agrees
> on the removal of the existing syntax, or if we should support both.

It would be nice to have all the advantages of TT, but I am also worried that
it will make it harder for libraries to change the notices themselves. It
currently works quite well, although we have some placeholders that are not
well known or not very consistent ( vs. <> vs.  etc.)
and need explaining.

I looked at the changes on bug 15280 and that looked not too bad. I think key
is to have better documentation to explain the change and make it easier to see
which variables can be used where and what additional features this will make
available.

I'd be interested to see how this change will affect the editor - no patch
there yet on bug 15277, maybe a screenshot?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

--- Comment #9 from Jonathan Druart  
---
(In reply to Kyle M Hall from comment #0)
> We should enable TT syntax for slips and notices. This could work side by
> side with the existing syntax parser for a release or two before we
> officially remove our bespoke parsing code for slips and notices, giving
> libraries ample time to switch over.

The existing syntax is quite easy to understand/modify for everybody, but the
TT syntax is not.
I would like to see a discussion on koha-devel to know if everybody agrees on
the removal of the existing syntax, or if we should support both.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

--- Comment #10 from Jonathan Druart  
---
Comment on attachment 47176
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47176
Bug 14757 - Allow the use of Template Toolkit syntax for slips and notices

Review of attachment 47176:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=14757=47176)
-

::: C4/Letters.pm
@@ +1414,5 @@
> +issues => {
> +module   => 'Koha::Checkouts',
> +singular => 'checkout',
> +plural   => 'checkouts',
> +fk   => 'itemnumber',

We should use `pk => issue_id` and update existing calls.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||15705


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15705
[Bug 15705] Notify the user on auto renewing
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Marcel de Rooy  changed:

   What|Removed |Added

 CC||m.de.r...@rijksmuseum.nl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||15280


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15280
[Bug 15280] Switch default CHECKOUT notice to Template Toolkit
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

--- Comment #8 from Kyle M Hall  ---
Created attachment 47177
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47177=edit
Bug 14757 [QA Followup] - Add Unit Tests

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #47131|0   |1
is obsolete||

--- Comment #7 from Kyle M Hall  ---
Created attachment 47176
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47176=edit
Bug 14757 - Allow the use of Template Toolkit syntax for slips and notices

This bug is the beginning of a conversion from our current bespoke
syntax for slips and notices to Template Toolkit syntax.

This patch is the initial seed which will evolve over time.
With this addition, we can take advantage of our Koha Objects
to greatly simplify the processing of Slips and Notices over time.

Test Plan:
1) Apply this patch
2) Ensure you have the default CHECKOUT notice
3) Check out and return an item for a patron
4) Note the text of the CHECKOUT notice
5) Replace your CHECKOUT notice with the following:

The following items have been checked out:

[% biblio.title %]

Thank you for visiting [% branch.branchname %].

6) Repeat step 3
7) Note the CHECKOUT notice text matches the previous CHECKOUT notice text

Signed-off-by: Bernardo Gonzalez Kriegel 
New notice syntax works, no koha-qa errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Kyle M Hall  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #45884|0   |1
is obsolete||

--- Comment #5 from Kyle M Hall  ---
Created attachment 47123
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47123=edit
Bug 14757 - Allow the use of Template Toolkit syntax for slips and notices

This bug is the beginning of a conversion from our current bespoke
syntax for slips and notices to Template Toolkit syntax.

This patch is the initial seed which will evolve over time.
With this addition, we can take advantage of our Koha Objects
to greatly simplify the processing of Slips and Notices over time.

Test Plan:
1) Apply this patch
2) Ensure you have the default CHECKOUT notice
3) Check out and return an item for a patron
4) Note the text of the CHECKOUT notice
5) Replace your CHECKOUT notice with the following:

The following items have been checked out:

[% biblio.title %]

Thank you for visiting [% branch.branchname %].

6) Repeat step 3
7) Note the CHECKOUT notice text matches the previous CHECKOUT notice text

Signed-off-by: Bernardo Gonzalez Kriegel 
New notice syntax works, no koha-qa errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Kyle M Hall  changed:

   What|Removed |Added

  Attachment #47123|0   |1
is obsolete||

--- Comment #6 from Kyle M Hall  ---
Created attachment 47131
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=47131=edit
Bug 14757 - Allow the use of Template Toolkit syntax for slips and notices

This bug is the beginning of a conversion from our current bespoke
syntax for slips and notices to Template Toolkit syntax.

This patch is the initial seed which will evolve over time.
With this addition, we can take advantage of our Koha Objects
to greatly simplify the processing of Slips and Notices over time.

Test Plan:
1) Apply this patch
2) Ensure you have the default CHECKOUT notice
3) Check out and return an item for a patron
4) Note the text of the CHECKOUT notice
5) Replace your CHECKOUT notice with the following:

The following items have been checked out:

[% biblio.title %]

Thank you for visiting [% branch.branchname %].

6) Repeat step 3
7) Note the CHECKOUT notice text matches the previous CHECKOUT notice text

Signed-off-by: Bernardo Gonzalez Kriegel 
New notice syntax works, no koha-qa errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #4 from Jonathan Druart  
---
Kyle, please provide tests for this new feature.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

  Attachment #45325|0   |1
is obsolete||

--- Comment #3 from Bernardo Gonzalez Kriegel  ---
Created attachment 45884
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45884=edit
[SIGNED-OFF] Bug 14757 - Allow the use of Template Toolkit syntax for slips and
notices

This bug is the beginning of a conversion from our current bespoke
syntax for slips and notices to Template Toolkit syntax.

This patch is the initial seed which will evolve over time.
With this addition, we can take advantage of our Koha Objects
to greatly simplify the processing of Slips and Notices over time.

Test Plan:
1) Apply this patch
2) Ensure you have the default CHECKOUT notice
3) Check out and return an item for a patron
4) Note the text of the CHECKOUT notice
5) Replace your CHECKOUT notice with the following:

The following items have been checked out:

[% biblio.title %]

Thank you for visiting [% branch.branchname %].

6) Repeat step 3
7) Note the CHECKOUT notice text matches the previous CHECKOUT notice text

Signed-off-by: Bernardo Gonzalez Kriegel 
New notice syntax works, no koha-qa errors

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Bernardo Gonzalez Kriegel  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Josef Moravec  changed:

   What|Removed |Added

 CC||josef.mora...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Kyle M Hall  changed:

   What|Removed |Added

  Component|Architecture, internals,|Notices
   |and plumbing|
 CC||k...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||15276


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15276
[Bug 15276] Add documentation for Template Toolkit syntax for slips and notices
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||15278


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15278
[Bug 15278] Port default slips and notices from bespoke syntax to Template
Toolkit
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Kyle M Hall  changed:

   What|Removed |Added

 Status|NEW |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||15277


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15277
[Bug 15277] Add Template Toolkit syntax for slips and notices to editor
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

--- Comment #2 from Kyle M Hall  ---
Created attachment 45325
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=45325=edit
Bug 14757 - Allow the use of Template Toolkit syntax for slips and notices

This bug is the beginning of a conversion from our current bespoke
syntax for slips and notices to Template Toolkit syntax.

This patch is the initial seed which will evolve over time.
With this addition, we can take advantage of our Koha Objects
to greatly simplify the processing of Slips and Notices over time.

Test Plan:
1) Apply this patch
2) Ensure you have the default CHECKOUT notice
3) Check out and return an item for a patron
4) Note the text of the CHECKOUT notice
5) Replace your CHECKOUT notice with the following:

The following items have been checked out:

[% biblio.title %]

Thank you for visiting [% branch.branchname %].

6) Repeat step 3
7) Note the CHECKOUT notice text matches the previous CHECKOUT notice text

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org
   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=12404

--- Comment #1 from Jonathan Druart  
---
Kyle,
This sounds like a big work.
How do you plan to implement that?
Did you have a look at bug 12404?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Kyle M Hall  changed:

   What|Removed |Added

   Assignee|gmcha...@gmail.com  |kyle.m.h...@gmail.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 14757] Allow the use of Template Toolkit syntax for slips and notices

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14757

Kyle M Hall  changed:

   What|Removed |Added

 Blocks||14758


Referenced Bugs:

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14758
[Bug 14758] Re-engineer Talking Tech support in Koha
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/