[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Owen Leonard changed: What|Removed |Added Keywords|rel_22_05_candidate | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Andrew Nugged changed: What|Removed |Added CC||nug...@gmail.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 --- Comment #42 from David Nind --- I attempted to add release notes, but as I don't really understand the this and the terminology it may need reviewing and updating! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 David Nind changed: What|Removed |Added Text to go in the||This enhancement adds an release notes||API call that returns ||patrons filtered by how ||much money they owe, ||between passed limits (for ||example less than $2.50 or ||more than $0.50). ||Optionally, can limit to ||debts of a particular ||debit_type and owed to a ||particular library. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Kyle M Hall changed: What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED CC||k...@bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 --- Comment #41 from Fridolin Somers --- Pushed to master for 22.05, thanks to everybody involved 🦄 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Fridolin Somers changed: What|Removed |Added Status|Passed QA |Pushed to master Version(s)||22.05.00 released in|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 --- Comment #40 from Fridolin Somers --- Useful to find who will have no Christmas gifts 🎅 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 --- Comment #39 from Fridolin Somers --- I think this can be useful in other places like a patrons search filter. I'm looking at it for master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Fridolin Somers changed: What|Removed |Added Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Jonathan Druart changed: What|Removed |Added CC||jonathan.druart+koha@gmail. ||com Keywords||rel_22_05_candidate --- Comment #38 from Jonathan Druart --- As bug 15157 is not ready for 21.11 it does not make sense to have this one part of 21.11. Postponed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Nick Clemens changed: What|Removed |Added Attachment #124876|0 |1 is obsolete|| --- Comment #37 from Nick Clemens --- Created attachment 124978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124978&action=edit Bug 15156: Add filter_by_amount_owed that's chainable This patch acts as an alternative here. We pull out the code from bug 11983 and extend it to support filtering of debts by branchcode and debit_type. The advantage of this approach is that we can add the filter into the middle of a search chain to filter down an pre-existing search. Signed-off-by: David Nind Signed-off-by: Emmi Takkinen Signed-off-by: Nick Clemens -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Nick Clemens changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Emmi Takkinen changed: What|Removed |Added Attachment #124508|0 |1 is obsolete|| --- Comment #36 from Emmi Takkinen --- Created attachment 124876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124876&action=edit Bug 15156: Add filter_by_amount_owed that's chainable This patch acts as an alternative here. We pull out the code from bug 11983 and extend it to support filtering of debts by branchcode and debit_type. The advantage of this approach is that we can add the filter into the middle of a search chain to filter down an pre-existing search. Signed-off-by: David Nind Signed-off-by: Emmi Takkinen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 David Nind changed: What|Removed |Added CC||da...@davidnind.com --- Comment #35 from David Nind --- Tested by running prove t/db_dependent/Koha/Patrons.t before and after patch applied - tests pass (using koha-testing-docker). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 David Nind changed: What|Removed |Added Attachment #124497|0 |1 is obsolete|| --- Comment #34 from David Nind --- Created attachment 124508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124508&action=edit Bug 15156: Add filter_by_amount_owed that's chainable This patch acts as an alternative here. We pull out the code from bug 11983 and extend it to support filtering of debts by branchcode and debit_type. The advantage of this approach is that we can add the filter into the middle of a search chain to filter down an pre-existing search. Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156
--- Comment #33 from Martin Renvoize ---
(In reply to Marcel de Rooy from comment #28)
> +return $self
> + unless ( defined($options)
> +&& ( $options->{less_than} || $options->{more_than} ) );
>
> Would this raise questions if people only pass library or debit_type and get
> much more than expected ?
Hmm, I'm not so sure.. we could throw an exception I suppose.. the filter
expects/requires these options to be passed to make any sense.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Martin Renvoize changed: What|Removed |Added Attachment #122534|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Martin Renvoize changed: What|Removed |Added Attachment #122392|0 |1 is obsolete|| -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 --- Comment #32 from Martin Renvoize --- Created attachment 124497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=124497&action=edit Bug 15156: Add filter_by_amount_owed that's chainable This patch acts as an alternative here. We pull out the code from bug 11983 and extend it to support filtering of debts by branchcode and debit_type. The advantage of this approach is that we can add the filter into the middle of a search chain to filter down an pre-existing search. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156
--- Comment #31 from Martin Renvoize ---
(In reply to Marcel de Rooy from comment #29)
> +my $group_by =
> + [ map { 'me.' . $_ } $self->_resultset->result_source->columns ];
> +
> +my $attrs = {
> +join => 'accountlines',
> +group_by => $group_by,
>
> You probably dont want to group by on all patron columns, heh ?
Actually, that's required by strict mode SQL.. we're already doing it all over
the place.
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 --- Comment #30 from Tomás Cohen Arazi --- (In reply to Martin Renvoize from comment #25) > I've love to get peoples thoughts on my alternative implimentation.. I've > split out the relevant code I wrote for bug 11983 so we don't have to rely > on that entire bug working it's way through. > > It still needs a couple more tests adding to prove the branchcode/debit_type > refinement. > > I think it's really beneficial to be able to chain this.. I can see a really > clear use case for needing to filter to those patrons visible to the user > prior to using this function...? I love your alternate patch. It is in line with what we've been promoting the last couple years in the codebase. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Eric BĂ©gin changed: What|Removed |Added CC|hakam.almot...@inlibro.com | -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156
Marcel de Rooy changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #29 from Marcel de Rooy ---
+my $group_by =
+ [ map { 'me.' . $_ } $self->_resultset->result_source->columns ];
+
+my $attrs = {
+join => 'accountlines',
+group_by => $group_by,
You probably dont want to group by on all patron columns, heh ?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156
Marcel de Rooy changed:
What|Removed |Added
CC||m.de.r...@rijksmuseum.nl
--- Comment #28 from Marcel de Rooy ---
+return $self
+ unless ( defined($options)
+&& ( $options->{less_than} || $options->{more_than} ) );
Would this raise questions if people only pass library or debit_type and get
much more than expected ?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 --- Comment #27 from Martin Renvoize --- Tests added -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Martin Renvoize changed: What|Removed |Added Attachment #122528|0 |1 is obsolete|| --- Comment #26 from Martin Renvoize --- Created attachment 122534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122534&action=edit Bug 15156: [ALT] Add filter_by_amount_owed that's chainable This patch acts as an alternative here. We pull out the code from bug 11983 and extend it to support filtering of debts by branchcode and debit_type. The advantage of this approach is that we can add the filter into the middle of a search chain to filter down an pre-existing search. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 --- Comment #25 from Martin Renvoize --- I've love to get peoples thoughts on my alternative implimentation.. I've split out the relevant code I wrote for bug 11983 so we don't have to rely on that entire bug working it's way through. It still needs a couple more tests adding to prove the branchcode/debit_type refinement. I think it's really beneficial to be able to chain this.. I can see a really clear use case for needing to filter to those patrons visible to the user prior to using this function...? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 --- Comment #24 from Martin Renvoize --- Created attachment 122528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122528&action=edit Bug 15156: [ALT] Add filter_by_amount_owed that's chainable This patch acts as an alternative here. We pull out the code from bug 11983 and extend it to support filtering of debts by branchcode and debit_type. The advantage of this approach is that we can add the filter into the middle of a search chain to filter down an pre-existing search. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 David Nind changed: What|Removed |Added Attachment #122355|0 |1 is obsolete|| --- Comment #23 from David Nind --- Created attachment 122392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122392&action=edit Bug 15156: Get all patrons with owings This patch adds method to return set of unique patrons with accountlines matching filtering params. To test: prove t/db_dependent/Koha/Patrons.t Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 David Nind changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Emmi Takkinen changed: What|Removed |Added Attachment #110886|0 |1 is obsolete|| --- Comment #22 from Emmi Takkinen --- Created attachment 122355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=122355&action=edit Bug 15156: Get all patrons with owings This patch adds method to return set of unique patrons with accountlines matching filtering params. To test: prove t/db_dependent/Koha/Patrons.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 --- Comment #21 from Tomás Cohen Arazi --- Please fix the test name while rebasing. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Hakam Almotlak changed: What|Removed |Added CC||hakam.almot...@inlibro.com --- Comment #20 from Hakam Almotlak --- patch does not apply on master Applying: Bug 15156: Get all patrons with owings Using index info to reconstruct a base tree... M Koha/Patrons.pm M t/db_dependent/Koha/Patrons.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Koha/Patrons.t CONFLICT (content): Merge conflict in t/db_dependent/Koha/Patrons.t Auto-merging Koha/Patrons.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 15156: Get all patrons with owings -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 --- Comment #19 from Martin Renvoize --- Oh, totally forgot about this one, I'm really sorry Emmi. I actually introduced a similar method in bug 11983 though.. so perhaps worth comparing. I'll try to bring that one back up to date, updating tests etc.. it's been on my list for a long time :S -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Emmi Takkinen changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Emmi Takkinen changed: What|Removed |Added Attachment #109593|0 |1 is obsolete|| --- Comment #18 from Emmi Takkinen --- Created attachment 110886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=110886&action=edit Bug 15156: Get all patrons with owings This patch adds method to return set of unique patrons with accountlines matching filtering params. To test: prove t/db_dependent/Koha/Patrons.t -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156
--- Comment #17 from Emmi Takkinen ---
(In reply to Martin Renvoize from comment #16)
> Thanks Emmi; I hope I didn't come across too negative.. I'd happily pick up
> the bug if I had some time to do so.. I'll certainly keep and eye out on it
> and try to help with testing/qa as needed.
Not at all and thanks beforehand :)
Some thoughts I had about this:
1. I'm not sure if owes is quite right. Owings seems more appropriate (or maybe
debts?).
2. Maybe we could ditch whole search? Instead we could first search patrons
against wanted criteria and then do:
my $patrons = Koha::Patrons->filter_by_owings({ 'me.borrowernumber' => { '-in'
=> \@borrowernumbers }, amount => { '>=' => $max } });
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 --- Comment #16 from Martin Renvoize --- Thanks Emmi; I hope I didn't come across too negative.. I'd happily pick up the bug if I had some time to do so.. I'll certainly keep and eye out on it and try to help with testing/qa as needed. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 --- Comment #15 from Emmi Takkinen --- Looking back to this after feedback and I agree, this implementation isn't ideal. At least method should return Patron object. I'll work on it again based on feedback. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156
Martin Renvoize changed:
What|Removed |Added
Status|Signed Off |Failed QA
--- Comment #14 from Martin Renvoize ---
Whilst I understand the idea behind this, I'm not sure the implementation is
good.
We iterate through all patrons in the resultset (so, if you're calling this
without having first chained it to a search) we will literally fetch all
borrowers from the db.
We're also returning a weird hasref rather than a set of Koha::Patron objects
which you could then work with further to produce the data you want.
I would also suggest that it should support the standard attribute params
available to normal searches to allow for filtering.
So.. all in all I feel we can do better.. this method should produce a joined
query that can be used inline with a method chain on Koha::Patrons...
What I'de really like to see is something along the lines:
my $filtered_patrons = Koha::Patrons->search({ whatever
})->filter_by_owes({amount => { '>=' => $max_owed }});
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156
Fridolin SOMERS changed:
What|Removed |Added
CC||fridolin.som...@biblibre.co
||m
Status|Needs Signoff |Signed Off
--- Comment #13 from Fridolin SOMERS ---
Can really be usefull, signing.
Just a note :
Since account is not only for fines (there can be copy fees, subscription
payement ...) maybe use a more generic name for the method
"search_patrons_with_unpaid_fines".
With "owing" maybe, like in C4::Members :
$flaginfo{'message'} = sprintf 'Patron owes %.02f', $owing
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Fridolin SOMERS changed: What|Removed |Added Attachment #105656|0 |1 is obsolete|| --- Comment #12 from Fridolin SOMERS --- Created attachment 109593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=109593&action=edit Bug 15156: Get all Borrowers with pending/unpaid fines/accountlines This patch adds method to fetch all borrowers with unpaid fines. To test: prove t/db_dependent/Koha/Patrons.t Sponsored-by: Koha-Suomi Oy Signed-off-by: Fridolin Somers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Emmi Takkinen changed: What|Removed |Added Depends on|13906 | --- Comment #11 from Emmi Takkinen --- Removed dependency on bug 13906 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906 [Bug 13906] TestObjectFactory(ies) for Koha objects. Enable easy Test object creation from HASHes or from preconfigured test groups. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Emmi Takkinen changed: What|Removed |Added Attachment #99981|0 |1 is obsolete|| --- Comment #10 from Emmi Takkinen --- Created attachment 105656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=105656&action=edit Bug 15156: Get all Borrowers with pending/unpaid fines/accountlines Rebased patch and removed unnecessary line of code from Lines.pm. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 --- Comment #9 from Martin Renvoize --- Comment on attachment 99981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99981 Bug 15156: Get all Borrowers with pending/unpaid fines/accountlines Review of attachment 99981: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15156&attachment=99981) - ::: Koha/Account/Lines.pm @@ +23,4 @@ > use Koha::Account::Line; > > use base qw(Koha::Objects); > +use List::MoreUtils qw( uniq ); Unless I'm missing it.. you don't actually use 'uniq' here? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Emmi Takkinen changed: What|Removed |Added Attachment #46232|0 |1 is obsolete|| Status|BLOCKED |Needs Signoff Assignee|koha-b...@lists.koha-commun |emmi.takki...@outlook.com |ity.org | --- Comment #8 from Emmi Takkinen --- Created attachment 99981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=99981&action=edit Bug 15156: Get all Borrowers with pending/unpaid fines/accountlines This patch adds method to fetch all borrowers with unpaid fines. To test: prove t/db_dependent/Koha/Patrons.t Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Katrin Fischer changed: What|Removed |Added CC||katrin.fisc...@bsz-bw.de, ||martin.renvoize@ptfs-europe ||.com, tomasco...@gmail.com --- Comment #7 from Katrin Fischer --- (In reply to Emmi Takkinen from comment #6) > Maybe this needs to be reworked entirely? Bug 12603 introduced TestBuilder > module so bug 13906 might not be valid anymore. Also I think > GetAllBorrowersWithUnpaidFines should be implemented in Patrons.pm instead > of C4::Accounts.pm. I think you might be on the right track here - I think removing the dependency on bug 13906 would be good. Also adding Tomas and Martin. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Emmi Takkinen changed: What|Removed |Added CC||emmi.takki...@outlook.com --- Comment #6 from Emmi Takkinen --- Maybe this needs to be reworked entirely? Bug 12603 introduced TestBuilder module so bug 13906 might not be valid anymore. Also I think GetAllBorrowersWithUnpaidFines should be implemented in Patrons.pm instead of C4::Accounts.pm. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 M. Tompsett changed: What|Removed |Added Status|Patch doesn't apply |BLOCKED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 M. Tompsett changed: What|Removed |Added Attachment #44642|0 |1 is obsolete|| --- Comment #5 from M. Tompsett --- Created attachment 46232 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46232&action=edit Bug 15156 - Get all Borrowers with pending/unpaid fines/accountlines A new API call. Useful when doing group operations for Borrowers with fines. Includes some test-coverage for C4::Accountlines since it was missing any. NOTE: Renamed test file to t/db_dependent/Accounts/... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 M. Tompsett changed: What|Removed |Added Depends on||13906 CC||mtomp...@hotmail.com Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13906 [Bug 13906] TestObjectFactory(ies) for Koha objects. Enable easy Test object creation from HASHes or from preconfigured test groups. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Marc Véron changed: What|Removed |Added CC||ve...@veron.ch Status|Needs Signoff |Patch doesn't apply --- Comment #4 from Marc Véron --- (In reply to Frédéric Demians from comment #3) > I can't apply this patch on master: > > fatal: sha1 information is lacking or useless (C4/Accounts.pm). > error: could not build fake ancestor Same problem here. Setting to Patch doesn't apply. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Frédéric Demians changed: What|Removed |Added CC||frede...@tamil.fr --- Comment #3 from Frédéric Demians --- I can't apply this patch on master: fatal: sha1 information is lacking or useless (C4/Accounts.pm). error: could not build fake ancestor -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Olli-Antti Kivilahti changed: What|Removed |Added Attachment #44640|0 |1 is obsolete|| --- Comment #2 from Olli-Antti Kivilahti --- Created attachment 44642 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44642&action=edit Bug 15156 - Get all Borrowers with pending/unpaid fines/accountlines A new API call. Useful when doing group operations for Borrowers with fines. Includes some test-coverage for C4::Accountlines since it was missing any. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Olli-Antti Kivilahti changed: What|Removed |Added Blocks||15157 Referenced Bugs: http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15157 [Bug 15157] Cronjob to automatically debar Borrowers/Patrons with pending/unpaid fines/accountlines -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 Olli-Antti Kivilahti changed: What|Removed |Added Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15156] Get all Borrowers with pending/unpaid fines/accountlines
http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15156 --- Comment #1 from Olli-Antti Kivilahti --- Created attachment 44640 --> http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=44640&action=edit Bug 15156 - Get all Borrowers with pending/unpaid fines/accountlines A new API call. Useful when doing group operations for Borrowers with fines. Includes some test-coverage for C4::Accountlines since it was missing any. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
