[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2020-02-25 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

Nick Clemens  changed:

   What|Removed |Added

 Blocks||24733


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24733
[Bug 24733] Cannot search for duplicate orders using 'Basket created by' field
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2019-11-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

Jonathan Druart  changed:

   What|Removed |Added

 Blocks||23927


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23927
[Bug 23927] Duplicate a "Complete" order  link the "New" one to the invoice
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2019-02-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #116 from Jonathan Druart  
---
I have not provided tests for the two new methods added to
Koha::Acquisition::Order (oops!)

It is now done on bug 22390.

Also I think we did something wrong regarding the subscription tests. @BULAC
could you take a look at the patch I have just submitted on bug 22390 and told
us if you agree with the change?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2019-02-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

Nick Clemens  changed:

   What|Removed |Added

 Blocks||22390


Referenced Bugs:

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22390
[Bug 22390] When duplicating existing order lines new items are not created
-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-11-26 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

Nick Clemens  changed:

   What|Removed |Added

  Text to go in the||This enhancements adds the
  release notes||ability to add an order to
   ||a basket (duplicate) from
   ||existing order lines. It
   ||will help serials
   ||acquisitions or other
   ||workflows where the same
   ||publication is ordered
   ||frequently.
   Keywords|release-notes-needed|

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

Martin Renvoize  changed:

   What|Removed |Added

 CC||martin.renvoize@ptfs-europe
   ||.com
 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

--- Comment #115 from Martin Renvoize  ---
New Feature, will not be backported to 18.05.x series.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-11-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

Jonathan Druart  changed:

   What|Removed |Added

   Severity|enhancement |new feature

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-11-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

Nick Clemens  changed:

   What|Removed |Added

 Status|Passed QA   |Pushed to Master

--- Comment #114 from Nick Clemens  ---
Awesome work all!

Pushed to master for 18.11

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-11-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-11-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #113 from Jonathan Druart  
---
Created attachment 82079
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=82079=edit
Bug 15184: Fix bad merge conflict with created_by

Signed-off-by: Jonathan Druart 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-11-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

Nick Clemens  changed:

   What|Removed |Added

 CC||n...@bywatersolutions.com
 Status|Passed QA   |Failed QA

--- Comment #112 from Nick Clemens  ---
Searching for basket created_by is broken, please add a followup

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-11-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

Jonathan Druart  changed:

   What|Removed |Added

   Keywords||release-notes-needed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-10-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #111 from Katrin Fischer  ---
Phew.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-10-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #81435|0   |1
is obsolete||

--- Comment #110 from Katrin Fischer  ---
Created attachment 81448
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81448=edit
Bug 15184: Fix TT filter

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-10-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #80491|0   |1
is obsolete||

--- Comment #104 from Katrin Fischer  ---
Created attachment 81442
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81442=edit
Bug 15184: Remove the checkboxes on the last step

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-10-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #80495|0   |1
is obsolete||

--- Comment #108 from Katrin Fischer  ---
Created attachment 81446
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81446=edit
Bug 15184: Improve styling

- Move "Show inactive" checkbox closer to the "Show inactive" text.
- Put more space between the "Show inactive" checkbox and the "The
original..." text
- Add "Check boxes to duplicate the original values" at the top of the
fieldset

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-10-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #80493|0   |1
is obsolete||

--- Comment #106 from Katrin Fischer  ---
Created attachment 81444
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81444=edit
Bug 15184: Set created_by to the logged in user

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-10-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #80494|0   |1
is obsolete||

--- Comment #107 from Katrin Fischer  ---
Created attachment 81445
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81445=edit
Bug 15184: Change permission (+x) on .pl

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-10-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #80638|0   |1
is obsolete||

--- Comment #109 from Katrin Fischer  ---
Created attachment 81447
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81447=edit
Bug 15184: Add missing html filters

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-10-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #80492|0   |1
is obsolete||

--- Comment #105 from Katrin Fischer  ---
Created attachment 81443
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81443=edit
Bug 15184: Do copy items for not a serial OR if items are created on ordering

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-10-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #80489|0   |1
is obsolete||

--- Comment #102 from Katrin Fischer  ---
Created attachment 81440
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81440=edit
Bug 15184: Add POD

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-10-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

Katrin Fischer  changed:

   What|Removed |Added

   Patch complexity|--- |Medium patch
 Status|Signed Off  |Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-10-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #80490|0   |1
is obsolete||

--- Comment #103 from Katrin Fischer  ---
Created attachment 81441
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81441=edit
Bug 15184: add missing filters

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-10-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #80486|0   |1
is obsolete||

--- Comment #99 from Katrin Fischer  ---
Created attachment 81437
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81437=edit
Bug 15184: Prepare the ground - Move funds and sort fields autoupdate

We are going to reuse the same logic: when a fund is selected the
statistic values are automatically updated.
Let move it to make it reusable more easily and isolate the code.

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Josef Moravec 

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-10-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #80487|0   |1
is obsolete||

--- Comment #100 from Katrin Fischer  ---
Created attachment 81438
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81438=edit
Bug 15184: Add the ordernumbers filters to GetHistory

It adds the ability to return the result of GetHistory given a list a
ordernumbers

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Josef Moravec 

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-10-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #80488|0   |1
is obsolete||

--- Comment #101 from Katrin Fischer  ---
Created attachment 81439
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81439=edit
Bug 15184: Add the ability to duplicate existing order lines

This patchset adds the ability to duplicate existing order lines to a
given basket. It will help acquisitions of serials of when the same
publication is ordered frequently.

The workflow will be:
- Create a new basket
- Use the "Add to basket" button
- Select the new entry "From existing orders (copy)"
- Search and select the order you want to duplicate
- Define some default values for these orders
- Duplicate!

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Josef Moravec 

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-10-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #80485|0   |1
is obsolete||

--- Comment #98 from Katrin Fischer  ---
Created attachment 81436
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81436=edit
Bug 15184: Prepare the ground - Move order search filters

We are going to reuse these filters so we move it to a separate include
file.

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Josef Moravec 

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-10-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #97 from Katrin Fischer  ---
Created attachment 81435
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81435=edit
Bug 15184: Fix TT filter

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-10-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #96 from Katrin Fischer  ---
Back to work here.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-10-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #95 from Jonathan Druart  
---
Created attachment 80638
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80638=edit
Bug 15184: Add missing html filters

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-10-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #94 from Katrin Fischer  ---
 FAIL   koha-tmpl/intranet-tmpl/prog/en/modules/acqui/duplicate_orders.tt
   FAIL   filters
missing_filter at line 284 ( Return to the basket[% order.basketgroupid | html
%]))
missing_filter at line 82 ([% order.ordernumber %])
missing_filter at line 253 (Cancel)
missing_filter at line 114 ([% order.creationdate | $KohaDates %])

Continueing testing!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #93 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #81)
> Should we leave out the  "Bug 15184: Add users ? (2.30 KB, patch)" for
> testing this?

Yes, done.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #89 from Jonathan Druart  
---
Created attachment 80492
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80492=edit
Bug 15184: Do copy items for not a serial OR if items are created on ordering

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #90 from Jonathan Druart  
---
Created attachment 80493
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80493=edit
Bug 15184: Set created_by to the logged in user

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #92 from Jonathan Druart  
---
Created attachment 80495
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80495=edit
Bug 15184: Improve styling

- Move "Show inactive" checkbox closer to the "Show inactive" text.
- Put more space between the "Show inactive" checkbox and the "The
original..." text
- Add "Check boxes to duplicate the original values" at the top of the
fieldset

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #91 from Jonathan Druart  
---
Created attachment 80494
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80494=edit
Bug 15184: Change permission (+x) on .pl

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #88 from Jonathan Druart  
---
Created attachment 80491
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80491=edit
Bug 15184: Remove the checkboxes on the last step

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #84 from Jonathan Druart  
---
Created attachment 80487
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80487=edit
Bug 15184: Add the ordernumbers filters to GetHistory

It adds the ability to return the result of GetHistory given a list a
ordernumbers

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Josef Moravec 

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #85 from Jonathan Druart  
---
Created attachment 80488
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80488=edit
Bug 15184: Add the ability to duplicate existing order lines

This patchset adds the ability to duplicate existing order lines to a
given basket. It will help acquisitions of serials of when the same
publication is ordered frequently.

The workflow will be:
- Create a new basket
- Use the "Add to basket" button
- Select the new entry "From existing orders (copy)"
- Search and select the order you want to duplicate
- Define some default values for these orders
- Duplicate!

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Josef Moravec 

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #86 from Jonathan Druart  
---
Created attachment 80489
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80489=edit
Bug 15184: Add POD

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #87 from Jonathan Druart  
---
Created attachment 80490
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80490=edit
Bug 15184: add missing filters

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #83 from Jonathan Druart  
---
Created attachment 80486
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80486=edit
Bug 15184: Prepare the ground - Move funds and sort fields autoupdate

We are going to reuse the same logic: when a fund is selected the
statistic values are automatically updated.
Let move it to make it reusable more easily and isolate the code.

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Josef Moravec 

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-10-12 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #78959|0   |1
is obsolete||
  Attachment #78960|0   |1
is obsolete||
  Attachment #78961|0   |1
is obsolete||
  Attachment #78962|0   |1
is obsolete||
  Attachment #78963|0   |1
is obsolete||
  Attachment #78964|0   |1
is obsolete||
  Attachment #78965|0   |1
is obsolete||
  Attachment #78966|0   |1
is obsolete||
  Attachment #78967|0   |1
is obsolete||
  Attachment #78968|0   |1
is obsolete||
  Attachment #78969|0   |1
is obsolete||
  Attachment #78970|0   |1
is obsolete||

--- Comment #82 from Jonathan Druart  
---
Created attachment 80485
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80485=edit
Bug 15184: Prepare the ground - Move order search filters

We are going to reuse these filters so we move it to a separate include
file.

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Josef Moravec 

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-10-11 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #81 from Katrin Fischer  ---
Should we leave out the  "Bug 15184: Add users ? (2.30 KB, patch)" for testing
this?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184
Bug 15184 depends on bug 20661, which changed state.

Bug 20661 Summary: Implement blocking errors for circulation scripts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20661

   What|Removed |Added

 Status|Pushed to Stable|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-09-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

Séverine Queune  changed:

   What|Removed |Added

 Status|Needs Signoff   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-09-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

ByWater Sandboxes  changed:

   What|Removed |Added

  Attachment #78705|0   |1
is obsolete||

--- Comment #77 from ByWater Sandboxes  ---
Created attachment 78967
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78967=edit
Bug 15184: Do copy items for not a serial OR if items are created on ordering

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-09-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

ByWater Sandboxes  changed:

   What|Removed |Added

  Attachment #78958|0   |1
is obsolete||

--- Comment #80 from ByWater Sandboxes  ---
Created attachment 78970
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78970=edit
Bug 15184: Improve styling

- Move "Show inactive" checkbox closer to the "Show inactive" text.
- Put more space between the "Show inactive" checkbox and the "The
original..." text
- Add "Check boxes to duplicate the original values" at the top of the
fieldset

Signed-off-by: Séverine QUEUNE 

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-09-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

ByWater Sandboxes  changed:

   What|Removed |Added

  Attachment #78702|0   |1
is obsolete||

--- Comment #74 from ByWater Sandboxes  ---
Created attachment 78964
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78964=edit
Bug 15184: Add POD

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-09-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

ByWater Sandboxes  changed:

   What|Removed |Added

  Attachment #78898|0   |1
is obsolete||

--- Comment #79 from ByWater Sandboxes  ---
Created attachment 78969
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78969=edit
Bug 15184: Change permission (+x) on .pl

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-09-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

ByWater Sandboxes  changed:

   What|Removed |Added

  Attachment #78703|0   |1
is obsolete||

--- Comment #75 from ByWater Sandboxes  ---
Created attachment 78965
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78965=edit
Bug 15184: add missing filters

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-09-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

ByWater Sandboxes  changed:

   What|Removed |Added

  Attachment #78704|0   |1
is obsolete||

--- Comment #76 from ByWater Sandboxes  ---
Created attachment 78966
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78966=edit
Bug 15184: Remove the checkboxes on the last step

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-09-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

ByWater Sandboxes  changed:

   What|Removed |Added

  Attachment #78706|0   |1
is obsolete||

--- Comment #78 from ByWater Sandboxes  ---
Created attachment 78968
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78968=edit
Bug 15184: Set created_by to the logged in user

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-09-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

ByWater Sandboxes  changed:

   What|Removed |Added

  Attachment #78697|0   |1
is obsolete||

--- Comment #69 from ByWater Sandboxes  ---
Created attachment 78959
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78959=edit
Bug 15184: Prepare the ground - Move order search filters

We are going to reuse these filters so we move it to a separate include
file.

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Josef Moravec 

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-09-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

ByWater Sandboxes  changed:

   What|Removed |Added

  Attachment #78699|0   |1
is obsolete||

--- Comment #71 from ByWater Sandboxes  ---
Created attachment 78961
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78961=edit
Bug 15184: Add the ordernumbers filters to GetHistory

It adds the ability to return the result of GetHistory given a list a
ordernumbers

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Josef Moravec 

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-09-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

ByWater Sandboxes  changed:

   What|Removed |Added

  Attachment #78701|0   |1
is obsolete||

--- Comment #73 from ByWater Sandboxes  ---
Created attachment 78963
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78963=edit
Bug 15184: Add users ?

We certainly do not want this patch. What about users that are notified
on receiving?

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Josef Moravec 

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-09-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

ByWater Sandboxes  changed:

   What|Removed |Added

  Attachment #78700|0   |1
is obsolete||

--- Comment #72 from ByWater Sandboxes  ---
Created attachment 78962
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78962=edit
Bug 15184: Add the ability to duplicate existing order lines

This patchset adds the ability to duplicate existing order lines to a
given basket. It will help acquisitions of serials of when the same
publication is ordered frequently.

The workflow will be:
- Create a new basket
- Use the "Add to basket" button
- Select the new entry "From existing orders (copy)"
- Search and select the order you want to duplicate
- Define some default values for these orders
- Duplicate!

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Josef Moravec 

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-09-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

ByWater Sandboxes  changed:

   What|Removed |Added

  Attachment #78698|0   |1
is obsolete||

--- Comment #70 from ByWater Sandboxes  ---
Created attachment 78960
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78960=edit
Bug 15184: Prepare the ground - Move funds and sort fields autoupdate

We are going to reuse the same logic: when a fund is selected the
statistic values are automatically updated.
Let move it to make it reusable more easily and isolate the code.

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Josef Moravec 

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-09-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

ByWater Sandboxes  changed:

   What|Removed |Added

  Attachment #78927|0   |1
is obsolete||

--- Comment #68 from ByWater Sandboxes  ---
Created attachment 78958
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78958=edit
Bug 15184: Improve styling

- Move "Show inactive" checkbox closer to the "Show inactive" text.
- Put more space between the "Show inactive" checkbox and the "The
original..." text
- Add "Check boxes to duplicate the original values" at the top of the
fieldset

Signed-off-by: Séverine QUEUNE 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-09-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #67 from Séverine Queune  ---
The new display seems better to me.
Add a sentence like "To keep the original value, check the box." ?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-09-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #66 from Jonathan Druart  
---
With the last patch applied: https://snag.gy/uqnkpY.jpg

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-09-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #65 from Jonathan Druart  
---
Created attachment 78927
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78927=edit
Bug 15184: Improve styling

- Move "Show inactive" checkbox closer to the "Show inactive" text.
- Put more space between the "Show inactive" checkbox and the "The
original..." text
- Add "Check boxes to duplicate the original values" at the top of the
fieldset

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-09-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #64 from Caroline Cyr La Rose  ---
- Move "Show inactive" checkbox closer to the "Show inactive" text.
- Put more space between the "Show inactive" checkbox and the "The original..."
text
- Add "Check boxes to duplicate the original values" at the top of the blue box

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #63 from Caroline Cyr La Rose  ---
Created attachment 78911
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78911=edit
Screenshot of duplcating page

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

Caroline Cyr La Rose  changed:

   What|Removed |Added

 CC||caroline.cyr-la-rose@inlibr
   ||o.com

--- Comment #62 from Caroline Cyr La Rose  ---
I find the duplicating page confusing. I figured after a while of looking at it
that the checkbox is NOT related to the drop-down/text area next to it. The
checkbox copies the original value, whereas the drop-down/text area adds a new
value. It's not evident when looking at it since we're used to seeing check
boxes next to the things we want.

Furthermore, there is another design element that I find confusing. When I
click on the checkbox next to the fund, "The original fund..." appears next to
the checkbox for inactive funds, as if it was related to it (see screenshot).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-09-15 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #61 from Jonathan Druart  
---
Created attachment 78898
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78898=edit
Bug 15184: Change permission (+x) on .pl

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-09-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #56 from Jonathan Druart  
---
Created attachment 78702
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78702=edit
Bug 15184: Add POD

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-09-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #58 from Jonathan Druart  
---
Created attachment 78704
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78704=edit
Bug 15184: Remove the checkboxes on the last step

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-09-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #60 from Jonathan Druart  
---
Created attachment 78706
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78706=edit
Bug 15184: Set created_by to the logged in user

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-09-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #55 from Jonathan Druart  
---
Created attachment 78701
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78701=edit
Bug 15184: Add users ?

We certainly do not want this patch. What about users that are notified
on receiving?

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-09-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #57 from Jonathan Druart  
---
Created attachment 78703
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78703=edit
Bug 15184: add missing filters

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-09-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #59 from Jonathan Druart  
---
Created attachment 78705
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78705=edit
Bug 15184: Do copy items for not a serial OR if items are created on ordering

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-09-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #54 from Jonathan Druart  
---
Created attachment 78700
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78700=edit
Bug 15184: Add the ability to duplicate existing order lines

This patchset adds the ability to duplicate existing order lines to a
given basket. It will help acquisitions of serials of when the same
publication is ordered frequently.

The workflow will be:
- Create a new basket
- Use the "Add to basket" button
- Select the new entry "From existing orders (copy)"
- Search and select the order you want to duplicate
- Define some default values for these orders
- Duplicate!

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-09-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #78279|0   |1
is obsolete||
  Attachment #78280|0   |1
is obsolete||
  Attachment #78281|0   |1
is obsolete||
  Attachment #78282|0   |1
is obsolete||
  Attachment #78283|0   |1
is obsolete||
  Attachment #78284|0   |1
is obsolete||
  Attachment #78285|0   |1
is obsolete||
  Attachment #78535|0   |1
is obsolete||
  Attachment #78538|0   |1
is obsolete||
  Attachment #78539|0   |1
is obsolete||

--- Comment #51 from Jonathan Druart  
---
Created attachment 78697
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78697=edit
Bug 15184: Prepare the ground - Move order search filters

We are going to reuse these filters so we move it to a separate include
file.

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-09-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #53 from Jonathan Druart  
---
Created attachment 78699
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78699=edit
Bug 15184: Add the ordernumbers filters to GetHistory

It adds the ability to return the result of GetHistory given a list a
ordernumbers

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-09-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #52 from Jonathan Druart  
---
Created attachment 78698
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78698=edit
Bug 15184: Prepare the ground - Move funds and sort fields autoupdate

We are going to reuse the same logic: when a fund is selected the
statistic values are automatically updated.
Let move it to make it reusable more easily and isolate the code.

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-09-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #78536|0   |1
is obsolete||

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-09-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #78537|0   |1
is obsolete||

--- Comment #50 from Jonathan Druart  
---
Created attachment 78539
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78539=edit
Bug 15184: Set created_by to the logged in user

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-09-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #49 from Jonathan Druart  
---
Created attachment 78538
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78538=edit
Bug 15184: Do copy items for not a serial OR if items are created on ordering

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-09-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #48 from Jonathan Druart  
---
Created attachment 78537
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78537=edit
Bug 15184: Set created_by to the logged in user

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-09-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #78340|0   |1
is obsolete||

--- Comment #46 from Jonathan Druart  
---
Created attachment 78535
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78535=edit
Bug 15184: Remove the checkboxes on the last step

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-09-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #47 from Jonathan Druart  
---
Created attachment 78536
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78536=edit
Bug 15184: Do not copy items for serials

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-09-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184
Bug 15184 depends on bug 20366, which changed state.

Bug 20366 Summary: More information about orders linked to subscriptions on 
"Acquisition details" tab
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366

   What|Removed |Added

 Status|Pushed to Master|RESOLVED
 Resolution|--- |FIXED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-08-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #45 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #43)
> I quite like the mechanics of this! Some questions:
> 
> 1) Why another checkbox on the last step? (new from copy > search > select
> orders > copy order form > more checkboxes)

No sense, the last patch removes it.

> 2) How do you handle items? Does it depend on what was set for the original
> order or is the setting for the current basket taken into account as well?

Items are copied, do you think they should only be copied if
AcqCreateItem=placing an order?

> 3) comment#42
(In reply to Katrin Fischer from comment #42)
> Could we make copying the users a checkbox or similar on the copy order form
> with default off? That way we might get us the best and most flexible
> behaviour.

I would suggest to either copy them or not, at least for a first step. And give
more flexibility on another bug report.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-08-31 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #44 from Jonathan Druart  
---
Created attachment 78340
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78340=edit
Bug 15184: Remove the checkboxes on the last step

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-08-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #43 from Katrin Fischer  ---
I quite like the mechanics of this! Some questions:

1) Why another checkbox on the last step? (new from copy > search > select
orders > copy order form > more checkboxes)

2) How do you handle items? Does it depend on what was set for the original
order or is the setting for the current basket taken into account as well?

3) comment#42

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-08-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #42 from Katrin Fischer  ---
(In reply to Jonathan Druart from comment #39)
> Created attachment 78283 [details] [review]
> Bug 15184: Add users ?
> 
> We certainly do not want this patch. What about users that are notified
> on receiving?
> 
> Sponsored-by: BULAC - http://www.bulac.fr/
> 
> Signed-off-by: Josef Moravec 

Could we make copying the users a checkbox or similar on the copy order form
with default off? That way we might get us the best and most flexible
behaviour.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #41 from Jonathan Druart  
---
Created attachment 78285
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78285=edit
Bug 15184: add missing filters

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #39 from Jonathan Druart  
---
Created attachment 78283
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78283=edit
Bug 15184: Add users ?

We certainly do not want this patch. What about users that are notified
on receiving?

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #40 from Jonathan Druart  
---
Created attachment 78284
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78284=edit
Bug 15184: Add POD

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #37 from Jonathan Druart  
---
Created attachment 78281
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78281=edit
Bug 15184: Add the ordernumbers filters to GetHistory

It adds the ability to return the result of GetHistory given a list a
ordernumbers

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #38 from Jonathan Druart  
---
Created attachment 78282
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78282=edit
Bug 15184: Add the ability to duplicate existing order lines

This patchset adds the ability to duplicate existing order lines to a
given basket. It will help acquisitions of serials of when the same
publication is ordered frequently.

The workflow will be:
- Create a new basket
- Use the "Add to basket" button
- Select the new entry "From existing orders (copy)"
- Search and select the order you want to duplicate
- Define some default values for these orders
- Duplicate!

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

Jonathan Druart  changed:

   What|Removed |Added

  Attachment #78074|0   |1
is obsolete||
  Attachment #78075|0   |1
is obsolete||
  Attachment #78076|0   |1
is obsolete||
  Attachment #78077|0   |1
is obsolete||
  Attachment #78078|0   |1
is obsolete||
  Attachment #78277|0   |1
is obsolete||
  Attachment #78278|0   |1
is obsolete||

--- Comment #35 from Jonathan Druart  
---
Created attachment 78279
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78279=edit
Bug 15184: Prepare the ground - Move order search filters

We are going to reuse these filters so we move it to a separate include
file.

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #36 from Jonathan Druart  
---
Created attachment 78280
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78280=edit
Bug 15184: Prepare the ground - Move funds and sort fields autoupdate

We are going to reuse the same logic: when a fund is selected the
statistic values are automatically updated.
Let move it to make it reusable more easily and isolate the code.

Sponsored-by: BULAC - http://www.bulac.fr/

Signed-off-by: Josef Moravec 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

Jonathan Druart  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #34 from Jonathan Druart  
---
(In reply to Katrin Fischer from comment #29)
> QA scripts complain about missing POD:
>FAIL pod coverage
>   POD is missing for add_user
>   POD is missing for duplicate_to
>   POD is missing for items
>   POD is missing for users

Added in the last follow-up.

> This looks a little odd:
> +Fund: 
> +

Moved from acqui/histsearch.tt, existed before this patch.

> Wondering about missing |html filters, especially in
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/duplicate_orders.tt.

Added missing filters in a separate patch.

(In reply to Katrin Fischer from comment #30)
> Also, can you please explain the last patch?
> 
> Bug 15184: Add users ?
> 
> We certainly do not want this patch. What about users that are notified
> on receiving?

When an order is duplicated, do we want to duplicate the user list who were
notified on receiving? I.e. they will be notified on receiving items for the
duplicated order. I was not sure if it was wanted or not, so I put that code on
a separate patch and waited for a feedback.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #33 from Jonathan Druart  
---
Created attachment 78278
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78278=edit
Bug 15184: add missing filters

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

--- Comment #32 from Jonathan Druart  
---
Created attachment 78277
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=78277=edit
Bug 15184: Add POD

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


[Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket

2018-08-29 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #31 from Katrin Fischer  ---
Hm, waiting for the last comment to be answered before more testing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/


  1   2   >