[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

Nicole C. Engard  changed:

   What|Removed |Added

 CC|neng...@gmail.com   |

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

Katrin Fischer  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #38 from Katrin Fischer  ---
I think there is a majority here disagreeing with the way this patch was done
and Jonathan has a good point about Elastic Search and testability. Marking
this Failed QA, although I'd really like to have the feature.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

--- Comment #37 from Jonathan Druart  
---
Note: This does not work with Elastic.

The most I think about it, the most I am convinced it's not a good idea to make
it client side.
We will need to provide tests to unsure future patches won't break this
enhancement.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

--- Comment #36 from Katrin Fischer  ---
I've added this bug to the next dev meeting's agenda.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

Nicole C. Engard  changed:

   What|Removed |Added

 CC||a...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

--- Comment #35 from David Cook  ---
(In reply to Srdjan Jankovic from comment #34)
> I could have done it both ways, but these days I prefer client side.
> * As a sever side dude, I prefer that clients use their cycles

I think client capabilities really range a lot, so as a server side dude I'd
rather present as consistent a baseline as possible. 

> * Tomorrow we decide to make search an api call, this still works
> 

Your API call would still need to return the text for you to replace, so that
doesn't really make sense. The API call could return translated text. You'd
just need a locale parameter. 

> And a personal, not a valid reason: I find that translations are easier
> (cleaner) in js

I haven't done much with translations, but I believe you with that one. That
said, if we used resource files for certain strings as I've suggested
elsewhere, translations would be simple. In a persistent environment, you only
load the file once, so there's not much overhead. 

But that's just my 2 cents. I'm not offering up any alternative patches, so I'm
mostly just curious about the rationale. Thanks for taking the time to respond
:).

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

--- Comment #34 from Srdjan Jankovic  ---

> We build the breadcrumbs... so why are we doing this client-side? Why aren't
> we doing this server-side?

I could have done it both ways, but these days I prefer client side.
* As a sever side dude, I prefer that clients use their cycles
* Tomorrow we decide to make search an api call, this still works

And a personal, not a valid reason: I find that translations are easier
(cleaner) in js

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

--- Comment #33 from David Cook  ---
I haven't had time to go over this bug... but I don't really understand it.

We build the breadcrumbs... so why are we doing this client-side? Why aren't we
doing this server-side?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

--- Comment #32 from Katrin Fischer  ---
Found a loose end here... removed the * that caused the problems from my
follow-up. Please reconsider!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #50963|0   |1
is obsolete||

--- Comment #31 from Katrin Fischer  ---
Created attachment 50964
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50964=edit
Bug 15434: Follow-up - Add more index terms

Adds more index names, especially for
- search for location and collection from adv search page
- facet limits
- authority number search from detail pages

Also adds a space after the colon for limits.

Signed-off-by: Srdjan 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #49077|0   |1
is obsolete||

--- Comment #30 from Katrin Fischer  ---
Created attachment 50963
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=50963=edit
Bug 15434: Follow-up - Add more index terms

Adds more index names, especially for
- search for location and collection from adv search page
- facet limits
- authority number search from detail pages

Also adds a space after the colon for limits.

Signed-off-by: Srdjan 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

Katrin Fischer  changed:

   What|Removed |Added

 Status|Failed QA   |Signed Off
   Patch complexity|--- |Small patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

--- Comment #29 from Katrin Fischer  ---
My fault - sorry! Change can be removed from patch set.
I was thinking it would be nice to show a 'translated version' of rtrn, wrdl,
phr etc. and did some experimenting, forgot to undo.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

--- Comment #28 from Srdjan Jankovic  ---
Ah right, that's what Katrin wanted to replace rtrn.
Katrin, can you please defend your choice of "*".

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

--- Comment #27 from Jonathan Druart  
---
(In reply to Srdjan Jankovic from comment #26)
> (In reply to Jonathan Druart from comment #25)
> 
> Hi Jonathan,
> 
> > Select Language= French:
> >   Results of search  with limit(s): 'Language *:fr'
> 
> Can you please tell me how did you get that *. When I select French from the
> drop-down, I get "limit=ln%2Crtrn%3Afre" in the url which shows as "with
> limit(s): 'Language *:fre'" in the breadcrumbs.

Same as me.
So it's expected, that's what you mean?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

--- Comment #26 from Srdjan Jankovic  ---
(In reply to Jonathan Druart from comment #25)

Hi Jonathan,

> Select Language= French:
>   Results of search  with limit(s): 'Language *:fr'

Can you please tell me how did you get that *. When I select French from the
drop-down, I get "limit=ln%2Crtrn%3Afre" in the url which shows as "with
limit(s): 'Language *:fre'" in the breadcrumbs.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

Jonathan Druart  changed:

   What|Removed |Added

 Status|Signed Off  |Failed QA

--- Comment #25 from Jonathan Druart  
---
Select Language= French:
  Results of search  with limit(s): 'Language *:fr'
The * does not seem to be expected.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

--- Comment #24 from Katrin Fischer  ---
I think there might still be some missing, but I feel it's a good start and we
can improve on it step by step. Right now it should hopefully already cover
most searches done by patrons.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #49075|0   |1
is obsolete||

--- Comment #23 from Srdjan Jankovic  ---
Created attachment 49077
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49077=edit
[SIGNED-OFF] Bug 15434: Follow-up - Add more index terms

Adds more index names, especially for
- search for location and collection from adv search page
- facet limits
- authority number search from detail pages

Also adds a space after the colon for limits.

Signed-off-by: Srdjan 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

--- Comment #22 from Katrin Fischer  ---
Follow-up attached - Jonathan and Srjdan, can you check?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

--- Comment #21 from Katrin Fischer  ---
Created attachment 49075
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49075=edit
Bug 15434: Follow-up - Add more index terms

Adds more index names, especially for
- search for location and collection from adv search page
- facet limits
- authority number search from detail pages

Also adds a space after the colon for limits.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

Katrin Fischer  changed:

   What|Removed |Added

  Attachment #46887|0   |1
is obsolete||

--- Comment #20 from Katrin Fischer  ---
Created attachment 49074
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=49074=edit
[PASSED QA] Bug 15434: Search criteria definition table

Collected search criteria and limit labels in opac-bottom.inc, so it
can be used for both making search criteria selects and displaying back
selections on the result screen.

*-opac-bootstrap.po translation files need to be changed:
- references to opac-advanced-search.tt need to be updated to
  opac-bottom.inc
- messages and translations need -s removed

Signed-off-by: Nicole Engard 

Signed-off-by: Katrin Fischer 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

--- Comment #19 from Katrin Fischer  ---
Hi Joubu and Srdjan, I had started on this during a train trip recently and
have a follow-up for some additional phrases (facets, advanced search,
qualifiers). Could post tonight if that would be helpful.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

Jonathan Druart  changed:

   What|Removed |Added

 CC||jonathan.dru...@bugs.koha-c
   ||ommunity.org

--- Comment #18 from Jonathan Druart  
---
(In reply to Srdjan Jankovic from comment #13)
> > The other thing with this patch is that it doesn't include all CCL
> > qualifiers, so hand-made queries will still show as the codes instead of the
> > descriptions. Of course, providing descriptive labels for all CCL qualifiers
> > is probably outside the scope of this bug...
> 
> I can add that if you (or someone else) gives me the list. Or anyone can
> write a follow-up to add them, that's not a big thing.

ltrn, rltrn, ext, st-year, st-date-normalized

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

--- Comment #17 from Jonathan Druart  
---
Comment on attachment 46887
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46887
Bug 15434: Search criteria definition table

Review of attachment 46887:
 --> 
(https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html=15434=46887)
-

Don't you think it would be good to keep the existing phrasing somewhere (on
hover for instance)?

::: koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc
@@ +133,5 @@
> +};
> +var limit_xlate = {
> +"mc-itype": _("Type"),
> +"ln": _("Language"),
> +"branch": _("Branch"),

=> "Library"

@@ +136,5 @@
> +"ln": _("Language"),
> +"branch": _("Branch"),
> +"aud": _("Audience"),
> +"l-format": _("Format"),
> +"ctype": _("Content Type"),

=> "Content type"

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

Nicole C. Engard  changed:

   What|Removed |Added

 Status|Patch doesn't apply |Signed Off

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

Nicole C. Engard  changed:

   What|Removed |Added

  Attachment #46674|0   |1
is obsolete||

--- Comment #16 from Nicole C. Engard  ---
Created attachment 46887
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46887=edit
Bug 15434: Search criteria definition table

Collected search criteria and limit labels in opac-bottom.inc, so it
can be used for both making search criteria selects and displaying back
selections on the result screen.

*-opac-bootstrap.po translation files need to be changed:
- references to opac-advanced-search.tt need to be updated to
  opac-bottom.inc
- messages and translations need -s removed

Signed-off-by: Nicole Engard 

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

--- Comment #13 from Srdjan Jankovic  ---
> The whole of search needs an overhaul...

Oh yes...

> 
> The other thing with this patch is that it doesn't include all CCL
> qualifiers, so hand-made queries will still show as the codes instead of the
> descriptions. Of course, providing descriptive labels for all CCL qualifiers
> is probably outside the scope of this bug...

I can add that if you (or someone else) gives me the list. Or anyone can write
a follow-up to add them, that's not a big thing.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

--- Comment #14 from Srdjan Jankovic  ---
(In reply to Nicole C. Engard from comment #11)
> That new patch doesn't apply either :(
> 
> Apply? [(y)es, (n)o, (i)nteractive] y
> Applying: Bug 15434: Search criteria definition table
> Using index info to reconstruct a base tree...
> Falling back to patching base and 3-way merge...
> error: The following untracked working tree files would be overwritten by
> merge:
>   koha-tmpl/opac-tmpl/bootstrap/js/search.js
> Please move or remove them before you can merge.
> Aborting
> Failed to merge in the changes.
> Patch failed at 0001 Bug 15434: Search criteria definition table
> When you have resolved this problem run "git bz apply --continue".
> If you would prefer to skip this patch, instead run "git bz apply --skip".
> To restore the original branch and stop patching run "git bz apply --abort".
> Patch left in /tmp/Bug-15434-Search-criteria-definition-table-K9mxpF.patch
> 08:10 ~/kohaclone (bug15434-qa %|AM u=)$

Not sure why. I'm getting no errors:
srdjan@srdjan:~/koha/dev (bug_15434_wr251001)$ git checkout kc/master
Note: checking out 'kc/master'.
...
srdjan@srdjan:~/koha/dev ((e7e1da8...))$ git bz apply 15434
Bug 15434 - Make search results breadcrumbs human readable

46674 - Bug 15434: Search criteria definition table

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 15434: Search criteria definition table
srdjan@srdjan:~/koha/dev ((084446e...))$

Maybe your tree was not clean for some reason? Can you please check git status
after checking out master, maybe there are some leftovers? That sometimes
happens to me when changing branches.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

--- Comment #15 from David Cook  ---
(In reply to Srdjan Jankovic from comment #13)
> I can add that if you (or someone else) gives me the list. Or anyone can
> write a follow-up to add them, that's not a big thing.

Cool. I don't have time at the moment, but I'll keep that in mind. I've been
thinking about writing a parser for ccl.properties, so if I ever pull that off,
that could be useful.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

Katrin Fischer  changed:

   What|Removed |Added

   See Also||http://bugs.koha-community.
   ||org/bugzilla3/show_bug.cgi?
   ||id=7497

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

David Cook  changed:

   What|Removed |Added

 CC||dc...@prosentient.com.au

--- Comment #12 from David Cook  ---
(In reply to Srdjan Jankovic from comment #8)
> As far as I can see it is a bug either in
> * modules/svc/suggestion.tt, line 37, that composes query as q=[indexed
> query], or in
> * C4::Search::parseQuery() that cannot deal with that kind of query
> 
> I think that buildQuery() actually builds an invalid query, but I'd
> certainly need an authoritative opinion.

I used to know the answer to this one but I can't remember now.

That said:

1) buildQuery() is terribad
2) I think there might be some Javascript which adds the "su-br, su-na, su-rl"
stuff and I recall it also being terribad. 

The whole of search needs an overhaul...

The other thing with this patch is that it doesn't include all CCL qualifiers,
so hand-made queries will still show as the codes instead of the descriptions.
Of course, providing descriptive labels for all CCL qualifiers is probably
outside the scope of this bug...

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

--- Comment #11 from Nicole C. Engard  ---
That new patch doesn't apply either :(

Apply? [(y)es, (n)o, (i)nteractive] y
Applying: Bug 15434: Search criteria definition table
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
error: The following untracked working tree files would be overwritten by
merge:
koha-tmpl/opac-tmpl/bootstrap/js/search.js
Please move or remove them before you can merge.
Aborting
Failed to merge in the changes.
Patch failed at 0001 Bug 15434: Search criteria definition table
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-15434-Search-criteria-definition-table-K9mxpF.patch
08:10 ~/kohaclone (bug15434-qa %|AM u=)$

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

Nicole C. Engard  changed:

   What|Removed |Added

 Status|Needs Signoff   |Patch doesn't apply

--- Comment #9 from Nicole C. Engard  ---
Applying: Bug 15434: Search criteria definition table
Using index info to reconstruct a base tree...
Falling back to patching base and 3-way merge...
Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc
CONFLICT (content): Merge conflict in
koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc
Failed to merge in the changes.
Patch failed at 0001 Bug 15434: Search criteria definition table
When you have resolved this problem run "git bz apply --continue".
If you would prefer to skip this patch, instead run "git bz apply --skip".
To restore the original branch and stop patching run "git bz apply --abort".
Patch left in /tmp/Bug-15434-Search-criteria-definition-table-QMpnoE.patch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #46103|0   |1
is obsolete||

--- Comment #10 from Srdjan Jankovic  ---
Created attachment 46674
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46674=edit
Bug 15434: Search criteria definition table

Collected search criteria and limit labels in opac-bottom.inc, so it
can be used for both making search criteria selects and displaying back
selections on the result screen.

*-opac-bootstrap.po translation files need to be changed:
- references to opac-advanced-search.tt need to be updated to
  opac-bottom.inc
- messages and translations need -s removed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

Nicole C. Engard  changed:

   What|Removed |Added

 CC||neng...@gmail.com,
   ||nic...@bywatersolutions.com

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

--- Comment #8 from Srdjan Jankovic  ---
As far as I can see it is a bug either in
* modules/svc/suggestion.tt, line 37, that composes query as q=[indexed query],
or in
* C4::Search::parseQuery() that cannot deal with that kind of query

I think that buildQuery() actually builds an invalid query, but I'd certainly
need an authoritative opinion.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

--- Comment #6 from Srdjan Jankovic  ---
Template translations are a monster. Tried to add support for translations in
assignments/function calls within [% %] tags, but gave up when the pain became
unbearable.
Chickened out and used javascript, _() is clean and easy. The only thing that I
don't like is the fact that I had to put all strings in opac-bottom.inc. Please
comment.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

Srdjan Jankovic  changed:

   What|Removed |Added

  Attachment #46017|0   |1
is obsolete||

--- Comment #5 from Srdjan Jankovic  ---
Created attachment 46103
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46103=edit
Bug 15434: Search criteria definition table

Collected search criteria and limit labels in opac-bottom.inc, so it
can be used for both making search criteria selects and displaying back
selections on the result screen.

*-opac-bootstrap.po translation files need to be changed:
* references to opac-advanced-search.tt need to be updated to
  opac-bottom.inc
* messages and translations need -s removed

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

Marc Véron  changed:

   What|Removed |Added

 CC||ve...@veron.ch

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

--- Comment #7 from Marc Véron  ---
Hi Srdjan, I like this feature.

One question:
If I search for "test" I get as breadcrumb:
Results of search for 'Keyword: test'
(As expected)

Then I click on: Did you mean: Search also for broader subjects
The breadcrumb is now:
Results of search for 'Keyword: su-br=test'

Similar for related / narrower subjects

Is that intended? I see su-br, su-na, su-rl in the JavaScript, though.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

--- Comment #4 from Katrin Fischer  ---
Thx a lot!

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

Katrin Fischer  changed:

   What|Removed |Added

 CC||katrin.fisc...@bsz-bw.de

--- Comment #2 from Katrin Fischer  ---
Hi Srdjan, I am a bit worried about translatability - did you check by chance
if the moved strings show up in updated po files?

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

--- Comment #3 from Srdjan Jankovic  ---
Right, I can see a problem with separating "phrase". Will rework.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

Srdjan Jankovic  changed:

   What|Removed |Added

   Assignee|oleon...@myacpl.org |srd...@catalyst.net.nz
 Status|NEW |ASSIGNED

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

Srdjan Jankovic  changed:

   What|Removed |Added

 Status|ASSIGNED|Needs Signoff

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/

[Koha-bugs] [Bug 15434] Make search results breadcrumbs human readable

[bugzilla-daemon]

http://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15434

--- Comment #1 from Srdjan Jankovic  ---
Created attachment 46017
  -->
http://bugs.koha-community.org/bugzilla3/attachment.cgi?id=46017=edit
Bug 15434: search-xlate.inc - search criteria definition table

Collected search criteria and limit labels in search-xlate.inc, so it
can be used gor both making search criteria selects and displaying back
selections on the result screen.

-- 
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
http://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/