[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2023-05-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Jonathan Druart changed: What|Removed |Added Blocks||32478 Referenced Bugs:

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2021-08-06 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Katrin Fischer changed: What|Removed |Added Blocks||22866 Referenced Bugs: h

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2020-12-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Jonathan Druart changed: What|Removed |Added Blocks||27154 --- Comment #72 fro

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2020-12-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #71 from Jonathan Druart --- Nick, why did you copy/pasted get_yaml_pref_hash in Koha/Config/SysPref.pm and Koha/Util/SystemPreferences.pm? Koha/Config/SysPref.pm:sub get_yaml_pref_hash { Koha/Util/SystemPreferences.pm:

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2020-04-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Katrin Fischer changed: What|Removed |Added CC||k...@bywatersolutions.com

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-11-16 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Martin Renvoize changed: What|Removed |Added CC||martin.renvoize@ptfs-europ

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-11-07 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master --- Comment

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-10-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Katrin Fischer changed: What|Removed |Added Attachment #80327|0 |1 is obsolete|

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-10-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Katrin Fischer changed: What|Removed |Added Attachment #80328|0 |1 is obsolete|

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-10-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Katrin Fischer changed: What|Removed |Added Attachment #80329|0 |1 is obsolete|

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-10-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Katrin Fischer changed: What|Removed |Added Attachment #80330|0 |1 is obsolete|

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-10-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Katrin Fischer changed: What|Removed |Added Attachment #80331|0 |1 is obsolete|

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-10-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Katrin Fischer changed: What|Removed |Added Attachment #80332|0 |1 is obsolete|

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-10-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Katrin Fischer changed: What|Removed |Added Attachment #80333|0 |1 is obsolete|

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-10-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #64 from Katrin Fischer --- Created attachment 81414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81414&action=edit Bug 15494: Add syspref Signed-off-by: Marcel de Rooy Signed-off-by: Katrin Fische

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-10-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #63 from Katrin Fischer --- Created attachment 81413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81413&action=edit Bug 15494: Update display of renewal errors To test: 1 - Define a rule to deny rene

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-10-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Katrin Fischer changed: What|Removed |Added Patch complexity|Small patch |Medium patch S

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-10-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #62 from Katrin Fischer --- Created attachment 81412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81412&action=edit Bug 15494: Add _items_denied_renewal sub to C4:Circulation::CanBookBeRenewed Signed

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-10-28 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #61 from Katrin Fischer --- Created attachment 81411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81411&action=edit Bug 15494: Unit tests prove -v t/db_dependent/Circulation.t Signed-off-by: Marcel

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #60 from Nick Clemens --- Created attachment 80333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80333&action=edit Bug 15494: (follow-up) Update tests to generate their own data (no delete) -- You ar

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #58 from Nick Clemens --- Created attachment 80331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80331&action=edit Bug 15494: (QA follow-up) Additional polishing [1] Fix two typos in Circulation.t.

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #57 from Nick Clemens --- Created attachment 80330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80330&action=edit Bug 15494 - Add syspref Signed-off-by: Marcel de Rooy -- You are receiving this ma

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #59 from Nick Clemens --- Created attachment 80332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80332&action=edit Bug 15494: (follow-up) Move yaml syspref code to its own sub in SySpref object To tes

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #55 from Nick Clemens --- Created attachment 80328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80328&action=edit Bug 15494 - Add _items_denied_renewal sub to C4:Circulation::CanBookBeRenewed Signed-

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #56 from Nick Clemens --- Created attachment 80329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80329&action=edit Bug 15494 - Update display of renewal errors To test: 1 - Define a rule to deny renew

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Nick Clemens changed: What|Removed |Added Attachment #79249|0 |1 is obsolete|

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-10-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #53 from Jonathan Druart --- Should not Koha::Util::SystemPreferences->get_yaml_pref_hash be a method of Koha::Config::SysPref instead? -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-10-09 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #52 from Nick Clemens --- (In reply to Nick Clemens from comment #50) > (In reply to Jonathan Druart from comment #39) > > 1. In tests, prefer > > Koha::IssuingRules->search->update($what_you_need_to_be_set); > > instead

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-09-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #51 from Nick Clemens --- Created attachment 79293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79293&action=edit Bug 15494: Update tests to generate their own data (no delete) -- You are receiving

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Nick Clemens changed: What|Removed |Added Text to go in the||This enhancement offers the

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #50 from Nick Clemens --- (In reply to Jonathan Druart from comment #39) > 1. In tests, prefer > Koha::IssuingRules->search->update($what_you_need_to_be_set); > instead of the DELETE then INSERT. It makes the changes more

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #49 from Nick Clemens --- Created attachment 79254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79254&action=edit Bug 15494: Move yaml syspref code to its own sub To test: 1 - prove -v t/db_dependent

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #48 from Nick Clemens --- Created attachment 79253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79253&action=edit Bug 15494: (QA follow-up) Additional polishing [1] Fix two typos in Circulation.t.

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #45 from Nick Clemens --- Created attachment 79250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79250&action=edit Bug 15494 - Add _items_denied_renewal sub to C4:Circulation::CanBookBeRenewed Signed-

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #46 from Nick Clemens --- Created attachment 79251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79251&action=edit Bug 15494 - Update display of renewal errors To test: 1 - Define a rule to deny renew

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #47 from Nick Clemens --- Created attachment 79252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79252&action=edit Bug 15494 - Add syspref Signed-off-by: Marcel de Rooy -- You are receiving this ma

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Nick Clemens changed: What|Removed |Added Attachment #71134|0 |1 is obsolete|

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-09-21 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are recei

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Edie Discher changed: What|Removed |Added CC||edisc...@cityoffargo.com --

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Katrin Fischer changed: What|Removed |Added See Also||https://bugs.koha-community

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-04-30 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Cheryl changed: What|Removed |Added CC||clack...@cityoffargo.com -- You a

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #43 from Katrin Fischer --- Ah! Not sure the reason is available in the template tho. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs m

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #42 from Jonathan Druart --- s/people/Koha administrators In the update DB process I guess, a warning to tell this new code is added and must be taken into account in the template of the notice. -- You are receiving t

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #41 from Katrin Fischer --- (In reply to Jonathan Druart from comment #40) > We should also tell people that a new item_denied_renewal condition must be > added to AUTO_RENEWALS Can you explain that one? People? -- You

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #40 from Jonathan Druart --- We should also tell people that a new item_denied_renewal condition must be added to AUTO_RENEWALS -- You are receiving this mail because: You are watching all bug changes.

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Jonathan Druart changed: What|Removed |Added Status|Passed QA |Failed QA

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Passed QA --- Comment #38

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Marcel de Rooy changed: What|Removed |Added Attachment #71133|0 |1 is obsolete|

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Marcel de Rooy changed: What|Removed |Added Attachment #71132|0 |1 is obsolete|

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Marcel de Rooy changed: What|Removed |Added Attachment #71129|0 |1 is obsolete|

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Marcel de Rooy changed: What|Removed |Added Attachment #71130|0 |1 is obsolete|

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Marcel de Rooy changed: What|Removed |Added Attachment #71131|0 |1 is obsolete|

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #30 from Marcel de Rooy --- Created attachment 71131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71131&action=edit Bug 15494 - Update display of renewal errors To test: 1 - Define a rule to deny ren

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Marcel de Rooy changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are rec

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #31 from Marcel de Rooy --- Created attachment 71132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71132&action=edit Bug 15494 - Add syspref -- You are receiving this mail because: You are watching a

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #32 from Marcel de Rooy --- Created attachment 71133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71133&action=edit Bug 15494: (QA follow-up) Additional polishing [1] Fix two typos in Circulation.t.

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Marcel de Rooy changed: What|Removed |Added Attachment #70629|0 |1 is obsolete|

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-02-02 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #29 from Marcel de Rooy --- Created attachment 71130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=71130&action=edit Bug 15494 - Add _items_denied_renewal sub to C4:Circulation::CanBookBeRenewed -- Y

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-02-01 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #27 from Marcel de Rooy --- Working on this one now -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-c

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #26 from Nick Clemens --- (In reply to Marcel de Rooy from comment #21) > + unless ($item){ carp "No item passed in!" && return } > Not our preferred coding style This was just copying others in this file, changed to

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Nick Clemens changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are re

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #24 from Nick Clemens --- Created attachment 70631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70631&action=edit Bug 15494 - Update display of renewal errors To test: 1 - Define a rule to deny renew

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #25 from Nick Clemens --- Created attachment 70632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70632&action=edit Bug 15494 - Add syspref -- You are receiving this mail because: You are watching all

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Nick Clemens changed: What|Removed |Added Attachment #68146|0 |1 is obsolete|

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-01-17 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #23 from Nick Clemens --- Created attachment 70630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70630&action=edit Bug 15494 - Add _items_denied_renewal sub to C4:Circulation::CanBookBeRenewed -- You

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #21

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #20 from Marcel de Rooy --- (In reply to Nick Clemens from comment #19) > It seems due dates were being set to now. If the tests take long enough to > run then the items were overdue. Set the date in the future now Yes,

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #19 from Nick Clemens --- It seems due dates were being set to now. If the tests take long enough to run then the items were overdue. Set the date in the future now -- You are receiving this mail because: You are watchi

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off -- You are recei

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #18 from Nick Clemens --- Created attachment 70295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=70295&action=edit Bug 15494 - Followup: Make sure items in tests are not overdue prove -v t/db_dependen

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Marcel de Rooy changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |Failed QA --- Comment #17

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-01-05 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Nick Clemens changed: What|Removed |Added Status|Failed QA |Signed Off --- Comment #16 f

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2018-01-04 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Marcel de Rooy changed: What|Removed |Added CC||m.de.r...@rijksmuseum.nl

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2017-10-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Katrin Fischer changed: What|Removed |Added Attachment #67889|0 |1 is obsolete|

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2017-10-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Katrin Fischer changed: What|Removed |Added Attachment #67887|0 |1 is obsolete|

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2017-10-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Katrin Fischer changed: What|Removed |Added Attachment #67888|0 |1 is obsolete|

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2017-10-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Katrin Fischer changed: What|Removed |Added Attachment #67886|0 |1 is obsolete|

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2017-10-14 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Signed Off --- Comment #10

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2017-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #8 from Nick Clemens --- Created attachment 67888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67888&action=edit Bug 15494 - Update display of renewal errors To test: 1 - Define a rule to deny renewa

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2017-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #7 from Nick Clemens --- Created attachment 67887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67887&action=edit Bug 15494 - Add _items_denied_renewal sub to C4:Circulation::CanBookBeRenewed -- You

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2017-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #9 from Nick Clemens --- Created attachment 67889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67889&action=edit Bug 15494 - Add syspref -- You are receiving this mail because: You are watching all

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2017-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Nick Clemens changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are re

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2017-10-10 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Nick Clemens changed: What|Removed |Added Attachment #63700|0 |1 is obsolete|

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2017-10-08 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff |Patch doesn't apply

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2017-05-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #3 from Nick Clemens --- Created attachment 63702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63702&action=edit Bug 15494 - Update display of renewal errors To test: 1 - Define a rule to deny renewa

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2017-05-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #4 from Nick Clemens --- Created attachment 63703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63703&action=edit Bug 15494 - Add syspref -- You are receiving this mail because: You are watching all

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2017-05-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Nick Clemens changed: What|Removed |Added Status|NEW |Needs Signoff -- You are re

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2017-05-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #1 from Nick Clemens --- Created attachment 63700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63700&action=edit Bug 15494 - Unit tests prove t/db_dependent/Circulation.t -- You are receiving this

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2017-05-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 --- Comment #2 from Nick Clemens --- Created attachment 63701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=63701&action=edit Bug 15494 - Add _items_denied_renewal sub to C4:Circulation::CanBookBeRenewed -- You

[Koha-bugs] [Bug 15494] Block renewals by arbitrary item values

2017-05-24 Thread bugzilla-daemon
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15494 Nick Clemens changed: What|Removed |Added Change sponsored?|Seeking cosponsors |Sponsored Summary