[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize changed: What|Removed |Added See Also||https://bugs.koha-community ||.org/bugzilla3/show_bug.cgi ||?id=33997 -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Magnus Enger changed: What|Removed |Added Blocks||36536 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=36536 [Bug 36536] Make REST API's validateUserAndPassword update borrowers.lastseen -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Marcel de Rooy changed: What|Removed |Added Blocks||35231 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35231 [Bug 35231] Cannot logout from OPAC and not login afterwards -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #197 from Marcel de Rooy --- See 35231. OPAC is blocked when logging out. Did we miss an Auth.pm test here? :) -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 David Nind changed: What|Removed |Added Text to go in the|This enhancement changes|This enhancement changes release notes|how tracking patron |how tracking patron |activities (and updating|activities (and updating |the borrowers.lastseen |the borrowers.lastseen |field) works - you can now |field) works - you can now |select what patron |select what patron |activities to track. |activities to track. || |Previously, with|Previously, with |TrackLastPatronActivity |TrackLastPatronActivity |enabled, the|enabled, the |borrowers.lastseen field|borrowers.lastseen field |was updated the first time |was updated when one of the |each day one of the |"hard-coded" activities |"hard-coded" activities |occurred - you could not |occurred - you could not|select what patron |select what patron |activities to track |activities to track | | |With |With|this enhancement, you can |this enhancement, you can |now individually select the |now individually select the |patron activities to track. |patron activities to track. |The current trackable |The current trackable |activities are: |activities are: |- All |- All |activities |activities |- Checking in an |- Checking out |item |an item |- Checking out an item |- Connections to|- Connecting to Koha using |Koha using SIP and ILS-DI |SIP and ILS-DI |- |- Logging in |Logging in (for both the|(for both the OPAC and the |OPAC and the staff |staff interface) |interface) |- Placing |- Placing an|a hold on an item (added by |article request |bug 35027) |- Placing a |- Placing an |hold on an item |article request (added by |- Renewing |bug 35030) |an item |- Renewing an |- Returning an item |item | | |Notes: |Notes: |- If no activities |- If no |are selected, then patron |activities are selected, |activity is not tracked and |then patron activity is not |the borrowers.lastseen |tracked and the |field is not updated. |borrowers.lastseen field is |- The |not updated. |system preference |- The system |TrackLastPatronActivity was |preference |renamed to |TrackLastPatronActivity was |TrackLastPatronActivityTrig |renamed to |gers. |TrackLastPatronActivityTrig ||gers. --- Comment #196 from David Nind --- I renamed the activities in the release notes to match that used on bug 35221, and I also added the bug number for the activities added by other bugs (holds and article requests). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Caroline Cyr La Rose changed: What|Removed |Added CC||caroline.cyr-la-rose@inlibr ||o.com Status|Needs documenting |RESOLVED Documentation||Caroline Cyr La Rose contact|| Documentation||https://gitlab.com/koha-com submission||munity/koha-manual/-/merge_ ||requests/745 Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Caroline Cyr La Rose changed: What|Removed |Added Blocks||35221 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35221 [Bug 35221] TrackLastPatronActivityTriggers description is misleading -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 David Nind changed: What|Removed |Added Text to go in the|This enhancement enables|This enhancement changes release notes|tracking patron activities |how tracking patron |once per day. When enabled, |activities (and updating |this updates the|the borrowers.lastseen |borrowers.lastseen field|field) works - you can now |for patrons with the|select what patron |current date and time - the |activities to track. |first time each day that| |one of the triggering |Previously, with |activities occurs. |TrackLastPatronActivity | |enabled, the |Two new |borrowers.lastseen field |system preferences that |was updated the first time |enable patron activity |each day one of the |tracking are: |"hard-coded" activities |- |occurred - you could not |TrackLastPatronActivity:|select what patron |enables tracking patron |activities to track |activity | |- |With |TrackLastPatronActivityTrig |this enhancement, you can |gers: used to select the|now individually select the |activities to track |patron activities to track. ||The current trackable |Activities that are tracked |activities are: |are: |- All |- Checking out an item |activities |- Connection to Koha via|- Checking out |SIP or ILS-DI |an item |- Login to |- Connections to |OPAC |Koha using SIP and ILS-DI |- Renewing an item |- |- |Logging in (for both the |Returning an item |OPAC and the staff ||interface) ||- Placing an ||article request ||- Placing a ||hold on an item ||- Renewing ||an item ||- Returning an item || ||Notes: ||- If no activities ||are selected, then patron ||activity is not tracked and ||the borrowers.lastseen ||field is not updated. ||- The ||system preference ||TrackLastPatronActivity was ||renamed to ||TrackLastPatronActivityTrig ||gers. --- Comment #195 from David Nind --- I've updated the release notes, as this how the enhancement worked was changed between sign off and being pushed. Feel free to correct any mistakes I've made or make it better! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize changed: What|Removed |Added Component|Circulation |Patrons -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Fridolin Somers changed: What|Removed |Added CC||fridolin.som...@biblibre.co ||m Status|Pushed to master|Needs documenting --- Comment #194 from Fridolin Somers --- Enhancement not pushed to 23.05.x -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #193 from Andrii Nugged --- (In reply to Tomás Cohen Arazi from comment #191) > Pushed to master for 23.11. Good! /me taking this to our preprod pilot, and soon to pre-release prod pilot. So if something pop-ups, we'll feeback quickly :P \o] -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #192 from Cab Vinton --- Super-excited for this. Thanks to everyone for all their contributions & work to get this far! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #191 from Tomás Cohen Arazi --- Pushed to master for 23.11. Nice work everyone, thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Tomás Cohen Arazi changed: What|Removed |Added Version(s)||23.11.00 released in|| Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize changed: What|Removed |Added Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
--- Comment #190 from Victor Grousset/tuxayo ---
(In reply to Andrii Nugged from comment #187)
> btw, that atomic update quoting is very inconsistent:
It's just between 1st and 3rd case. The 2nd uses interpolation so needs the
double-q IIUC
Is there even a recommendation for a default choice for the others?
The examples at
https://wiki.koha-community.org/wiki/Database_updates#How_to_write_an_atomicupdate_file
use q{ so let's use that.
updatedatabase tested.
> I did the rebase. But which status we should put for the ticket?
Thanks for the rebase :) It was passed QA before. So passed QA, unless the
rebase showed that other changes could interfere with this and require
retesting. **How was it?**
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #189 from Victor Grousset/tuxayo --- Created attachment 157624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157624=edit Bug 15504: (QA follow-up): more consistent quotes in atomicupdate -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
--- Comment #188 from Andrii Nugged ---
btw, that atomic update quoting is very inconsistent:
my ($tracklastactivity) = $dbh->selectrow_array(
q|
SELECT value FROM systempreferences WHERE
variable='TrackLastPatronActivity';
|
);
vs
$dbh->do(
qq{INSERT IGNORE INTO systempreferences
(variable,value,options,explanation,type) VALUES
('TrackLastPatronActivityTriggers',?,NULL,'If set, the field borrowers.lastseen
will be updated every time a patron performs a selected action','multiple') },
undef, $triggers,
);
vs
$dbh->do(
q{
DELETE FROM systempreferences WHERE
variable='TrackLastPatronActivity'
}
);
why so?
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #187 from Andrii Nugged --- I did the rebase. But which status we should put for the ticket? -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #186 from Andrii Nugged --- Created attachment 157620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157620=edit Bug 15504: (QA follow-up) Final changes [1] Comment in Patron->is_active sharpened. [2] Patron->update_lastseen return if $cached && $cached eq $now->ymd; Should be return $self if $cached && $cached eq $now->ymd; Consistent return value. [3] Typo if there are not TrackLastPatronActivityTriggers enabled [4] Typo TrackLastPatronActivityTriggers must be contain [5] Typo patron is does .. option => performs an action [6] Tidy on dbrev to fix The file is less tidy than before (bad/messy lines before: 0, now: 4) Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
--- Comment #185 from Andrii Nugged ---
Created attachment 157619
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157619=edit
Bug 15504: (QA follow-up) Fix dbrev
Resolve:
ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Unknown column
'check_out' in 'field list' at /usr/share/koha/C4/Installer.pm line 741
Test plan:
Remove new pref from db.
Run dbrev again.
Check results.
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #184 from Andrii Nugged --- Created attachment 157618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157618=edit Bug 15504: Remove PatronLastActivity preference This patch removes the older PatronLastActivity preference opting to replace it by the new PatronLastActivityTriggers preference. The feature can now be disabled by simply not selecting any triggers Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #183 from Andrii Nugged --- Created attachment 157617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157617=edit Bug 15504: (follow-up) Clarify --last_seen option in delete_patrons This patch adds clarifications to the last_seen option in delete_patrons to clarify that TrackLastPatronActivity and TrackLastPatronActivityTriggers system preferences act as a couplet. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #182 from Andrii Nugged --- Created attachment 157616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157616=edit Bug 15504: (follow-up) Update terminology on cleanborrowers This patch updates the terminology on the cleanborrowers form to reflect that 'activity' and not just 'connectivity' is tracked by TrackLastPatronActivity. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #181 from Andrii Nugged --- Created attachment 157615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157615=edit Bug 15504: (QA follow-up) Terminology This just updates 'Login to OPAC' to 'Login'.. we should squash this Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #180 from Andrii Nugged --- Created attachment 157614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157614=edit Bug 15504: (follow-up) Rename cache key I agree, it's better to use borrowernumber for the cache key and I also take the oportunity to rename it to more clearly reflect the function (it's no longer 'login' only, it's now 'activity') Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #179 from Andrii Nugged --- Created attachment 157613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157613=edit Bug 15504: (follow-up) Respect existing TrackLastPatronActivity This patch updates the database update to set 'check_out,connection,login' as the activity triggers should we find at upgrade time that TrackLastPatronActivity is set to true. This retains the existing functionality. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #178 from Andrii Nugged --- Created attachment 157612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157612=edit Bug 15504: (follow-up) Fix is_active test Bug 33245 introduced a new is_active patron method and the corresponding tests included calls to the method we depreacte in this patchset Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #177 from Andrii Nugged --- Created attachment 157611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157611=edit Bug 15504: (follow-up) Tidy 'lastseen' section of unit test Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #176 from Andrii Nugged --- Created attachment 157610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157610=edit Bug 15504: (follow-up) Add Triggers mock to unit tests Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #175 from Andrii Nugged --- Created attachment 157609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157609=edit Bug 15504: (follow-up) Use borrowernumber in Koha::Patrons->find Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #174 from Andrii Nugged --- Created attachment 157608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157608=edit Bug 15504: (follow-up) Migrate to one clear method We were using a series of similarly named methods spread in distinct places around the codebase. This combines the logic of C4::Auth::track_login_daily and Koha::Patron->track_login into a new Koha::Patron->update_lastseen method. Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #173 from Andrii Nugged --- Created attachment 157607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157607=edit Bug 15504: (follow-up) Unit tests This patch removes, moves and updates the existing unit tests for track_login_daily and track_login to all sit under Koha::Patron and update_lastseen. Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #172 from Andrii Nugged --- Created attachment 157606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157606=edit Bug 15504: Add unit test prove -v t/db_dependent/Auth.t Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #171 from Andrii Nugged --- Created attachment 157605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157605=edit Bug 15504: Remove update_lastseen method This patch removes update_lastseen which has been replaced by a call to track_login_daily Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #170 from Andrii Nugged --- Created attachment 157604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157604=edit Bug 15504: Add triggers to instances of track_login_daily This patch adds a trigger to every instance of track_login_daily Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #169 from Andrii Nugged --- Created attachment 157603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157603=edit Bug 15504: Update track_login_daily to accept triggers This patch adds triggers to track_login_daily so that it only tracks activity when that trigger is active Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Andrii Nugged changed: What|Removed |Added Attachment #156917|0 |1 is obsolete|| Attachment #156918|0 |1 is obsolete|| Attachment #156919|0 |1 is obsolete|| Attachment #156920|0 |1 is obsolete|| Attachment #156921|0 |1 is obsolete|| Attachment #156922|0 |1 is obsolete|| Attachment #156923|0 |1 is obsolete|| Attachment #156924|0 |1 is obsolete|| Attachment #156925|0 |1 is obsolete|| Attachment #156926|0 |1 is obsolete|| Attachment #156927|0 |1 is obsolete|| Attachment #156928|0 |1 is obsolete|| Attachment #156929|0 |1 is obsolete|| Attachment #156930|0 |1 is obsolete|| Attachment #156931|0 |1 is obsolete|| Attachment #156932|0 |1 is obsolete|| Attachment #156933|0 |1 is obsolete|| Attachment #156934|0 |1 is obsolete|| Attachment #156935|0 |1 is obsolete|| --- Comment #168 from Andrii Nugged --- Created attachment 157602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=157602=edit Bug 15504: Add new syspref TrackLastPatronActivityTriggers This patch adds a new syspref TrackLastPatronActivityTriggers to determine which actions should update borrowers.lastseen Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Andrii Nugged changed: What|Removed |Added Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Tomás Cohen Arazi changed: What|Removed |Added Status|Passed QA |Patch doesn't apply --- Comment #167 from Tomás Cohen Arazi --- Please rebase ASAP. Thanks! -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Tomás Cohen Arazi changed: What|Removed |Added CC||tomasco...@gmail.com --- Comment #166 from Tomás Cohen Arazi --- (In reply to Marcel de Rooy from comment #165) > Note for RM: There are follow-up bugs opened to extend the feature. But imo > this can go in as-is. There is commitment to work further. Thanks for this clarification. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Bug 15504 depends on bug 33245, which changed state. Bug 33245 Summary: Add $patron->is_active https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=33245 What|Removed |Added Status|Pushed to master|RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize changed: What|Removed |Added Blocks|35001 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=35001 [Bug 35001] Patron->is_active should respect TrackLastPatronActivityTriggers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #165 from Marcel de Rooy --- Note for RM: There are follow-up bugs opened to extend the feature. But imo this can go in as-is. There is commitment to work further. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #164 from Marcel de Rooy --- Looks good to me now. Last commment. Just noticing here. Will open a new bug. t/db_dependent/Members.t $dbh->do(q|UPDATE borrowers SET lastseen=NULL|); Not from this patch set, but this is bad practice. We should change it (elsewhere). -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #163 from Marcel de Rooy --- Created attachment 156935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156935=edit Bug 15504: (QA follow-up) Final changes [1] Comment in Patron->is_active sharpened. [2] Patron->update_lastseen return if $cached && $cached eq $now->ymd; Should be return $self if $cached && $cached eq $now->ymd; Consistent return value. [3] Typo if there are not TrackLastPatronActivityTriggers enabled [4] Typo TrackLastPatronActivityTriggers must be contain [5] Typo patron is does .. option => performs an action [6] Tidy on dbrev to fix The file is less tidy than before (bad/messy lines before: 0, now: 4) Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
Marcel de Rooy changed:
What|Removed |Added
Attachment #156915|0 |1
is obsolete||
--- Comment #162 from Marcel de Rooy ---
Created attachment 156934
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156934=edit
Bug 15504: (QA follow-up) Fix dbrev
Resolve:
ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Unknown column
'check_out' in 'field list' at /usr/share/koha/C4/Installer.pm line 741
Test plan:
Remove new pref from db.
Run dbrev again.
Check results.
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Marcel de Rooy changed: What|Removed |Added Attachment #156914|0 |1 is obsolete|| --- Comment #161 from Marcel de Rooy --- Created attachment 156933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156933=edit Bug 15504: Remove PatronLastActivity preference This patch removes the older PatronLastActivity preference opting to replace it by the new PatronLastActivityTriggers preference. The feature can now be disabled by simply not selecting any triggers Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Marcel de Rooy changed: What|Removed |Added Attachment #156913|0 |1 is obsolete|| --- Comment #160 from Marcel de Rooy --- Created attachment 156932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156932=edit Bug 15504: (follow-up) Clarify --last_seen option in delete_patrons This patch adds clarifications to the last_seen option in delete_patrons to clarify that TrackLastPatronActivity and TrackLastPatronActivityTriggers system preferences act as a couplet. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Marcel de Rooy changed: What|Removed |Added Attachment #156912|0 |1 is obsolete|| --- Comment #159 from Marcel de Rooy --- Created attachment 156931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156931=edit Bug 15504: (follow-up) Update terminology on cleanborrowers This patch updates the terminology on the cleanborrowers form to reflect that 'activity' and not just 'connectivity' is tracked by TrackLastPatronActivity. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Marcel de Rooy changed: What|Removed |Added Attachment #156911|0 |1 is obsolete|| --- Comment #158 from Marcel de Rooy --- Created attachment 156930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156930=edit Bug 15504: (QA follow-up) Terminology This just updates 'Login to OPAC' to 'Login'.. we should squash this Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Marcel de Rooy changed: What|Removed |Added Attachment #156910|0 |1 is obsolete|| --- Comment #157 from Marcel de Rooy --- Created attachment 156929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156929=edit Bug 15504: (follow-up) Rename cache key I agree, it's better to use borrowernumber for the cache key and I also take the oportunity to rename it to more clearly reflect the function (it's no longer 'login' only, it's now 'activity') Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Marcel de Rooy changed: What|Removed |Added Attachment #156909|0 |1 is obsolete|| --- Comment #156 from Marcel de Rooy --- Created attachment 156928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156928=edit Bug 15504: (follow-up) Respect existing TrackLastPatronActivity This patch updates the database update to set 'check_out,connection,login' as the activity triggers should we find at upgrade time that TrackLastPatronActivity is set to true. This retains the existing functionality. Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Marcel de Rooy changed: What|Removed |Added Attachment #156908|0 |1 is obsolete|| --- Comment #155 from Marcel de Rooy --- Created attachment 156927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156927=edit Bug 15504: (follow-up) Fix is_active test Bug 33245 introduced a new is_active patron method and the corresponding tests included calls to the method we depreacte in this patchset Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Marcel de Rooy changed: What|Removed |Added Attachment #156907|0 |1 is obsolete|| --- Comment #154 from Marcel de Rooy --- Created attachment 156926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156926=edit Bug 15504: (follow-up) Tidy 'lastseen' section of unit test Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Marcel de Rooy changed: What|Removed |Added Attachment #156906|0 |1 is obsolete|| --- Comment #153 from Marcel de Rooy --- Created attachment 156925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156925=edit Bug 15504: (follow-up) Add Triggers mock to unit tests Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Marcel de Rooy changed: What|Removed |Added Attachment #156905|0 |1 is obsolete|| --- Comment #152 from Marcel de Rooy --- Created attachment 156924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156924=edit Bug 15504: (follow-up) Use borrowernumber in Koha::Patrons->find Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Marcel de Rooy changed: What|Removed |Added Attachment #156904|0 |1 is obsolete|| --- Comment #151 from Marcel de Rooy --- Created attachment 156923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156923=edit Bug 15504: (follow-up) Migrate to one clear method We were using a series of similarly named methods spread in distinct places around the codebase. This combines the logic of C4::Auth::track_login_daily and Koha::Patron->track_login into a new Koha::Patron->update_lastseen method. Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Marcel de Rooy changed: What|Removed |Added Attachment #156903|0 |1 is obsolete|| --- Comment #150 from Marcel de Rooy --- Created attachment 156922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156922=edit Bug 15504: (follow-up) Unit tests This patch removes, moves and updates the existing unit tests for track_login_daily and track_login to all sit under Koha::Patron and update_lastseen. Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Marcel de Rooy changed: What|Removed |Added Attachment #156902|0 |1 is obsolete|| --- Comment #149 from Marcel de Rooy --- Created attachment 156921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156921=edit Bug 15504: Add unit test prove -v t/db_dependent/Auth.t Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Marcel de Rooy changed: What|Removed |Added Attachment #156901|0 |1 is obsolete|| --- Comment #148 from Marcel de Rooy --- Created attachment 156920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156920=edit Bug 15504: Remove update_lastseen method This patch removes update_lastseen which has been replaced by a call to track_login_daily Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Marcel de Rooy changed: What|Removed |Added Attachment #156900|0 |1 is obsolete|| --- Comment #147 from Marcel de Rooy --- Created attachment 156919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156919=edit Bug 15504: Add triggers to instances of track_login_daily This patch adds a trigger to every instance of track_login_daily Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Marcel de Rooy changed: What|Removed |Added Attachment #156899|0 |1 is obsolete|| --- Comment #146 from Marcel de Rooy --- Created attachment 156918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156918=edit Bug 15504: Update track_login_daily to accept triggers This patch adds triggers to track_login_daily so that it only tracks activity when that trigger is active Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Marcel de Rooy changed: What|Removed |Added Attachment #156898|0 |1 is obsolete|| --- Comment #145 from Marcel de Rooy --- Created attachment 156917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156917=edit Bug 15504: Add new syspref TrackLastPatronActivityTriggers This patch adds a new syspref TrackLastPatronActivityTriggers to determine which actions should update borrowers.lastseen Signed-off-by: Martin Renvoize Signed-off-by: David Nind Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Passed QA Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #144 from Marcel de Rooy --- FAIL C4/Auth.pm FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 perl -MPod::Coverage=C4::Auth -e1 C4::Auth has a Pod::Coverage rating of 0.705882352941177 The following are uncovered: checkpw, checkpw_hash, checkpw_internal, getborrowernumber, safe_exit So no problems from this patch set. Ignoring this warn from qa tools here. We just removed a sub here. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #143 from Marcel de Rooy --- We also need 35041 to fix a current failure on Koha/Patron.t. Submitted now. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504
--- Comment #142 from Marcel de Rooy ---
Created attachment 156915
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156915=edit
Bug 15504: (QA follow-up) Fix dbrev
Resolve:
ERROR - {UNKNOWN}: DBI Exception: DBD::mysql::db do failed: Unknown column
'check_out' in 'field list' at /usr/share/koha/C4/Installer.pm line 741
Test plan:
Remove new pref from db.
Run dbrev again.
Check results.
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
___
Koha-bugs mailing list
Koha-bugs@lists.koha-community.org
https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs
website : http://www.koha-community.org/
git : http://git.koha-community.org/
bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Marcel de Rooy changed: What|Removed |Added Status|Patch doesn't apply |BLOCKED --- Comment #141 from Marcel de Rooy --- Coming back here. Just hang on a bit. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize changed: What|Removed |Added Attachment #156879|0 |1 is obsolete|| --- Comment #140 from Martin Renvoize --- Created attachment 156914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156914=edit Bug 15504: Remove PatronLastActivity preference This patch removes the older PatronLastActivity preference opting to replace it by the new PatronLastActivityTriggers preference. The feature can now be disabled by simply not selecting any triggers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize changed: What|Removed |Added Attachment #156870|0 |1 is obsolete|| --- Comment #139 from Martin Renvoize --- Created attachment 156913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156913=edit Bug 15504: (follow-up) Clarify --last_seen option in delete_patrons This patch adds clarifications to the last_seen option in delete_patrons to clarify that TrackLastPatronActivity and TrackLastPatronActivityTriggers system preferences act as a couplet. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize changed: What|Removed |Added Attachment #156869|0 |1 is obsolete|| --- Comment #138 from Martin Renvoize --- Created attachment 156912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156912=edit Bug 15504: (follow-up) Update terminology on cleanborrowers This patch updates the terminology on the cleanborrowers form to reflect that 'activity' and not just 'connectivity' is tracked by TrackLastPatronActivity. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize changed: What|Removed |Added Attachment #156868|0 |1 is obsolete|| --- Comment #137 from Martin Renvoize --- Created attachment 156911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156911=edit Bug 15504: (QA follow-up) Terminology This just updates 'Login to OPAC' to 'Login'.. we should squash this -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize changed: What|Removed |Added Attachment #156867|0 |1 is obsolete|| --- Comment #136 from Martin Renvoize --- Created attachment 156910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156910=edit Bug 15504: (follow-up) Rename cache key I agree, it's better to use borrowernumber for the cache key and I also take the oportunity to rename it to more clearly reflect the function (it's no longer 'login' only, it's now 'activity') -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize changed: What|Removed |Added Attachment #156866|0 |1 is obsolete|| --- Comment #135 from Martin Renvoize --- Created attachment 156909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156909=edit Bug 15504: (follow-up) Respect existing TrackLastPatronActivity This patch updates the database update to set 'check_out,connection,login' as the activity triggers should we find at upgrade time that TrackLastPatronActivity is set to true. This retains the existing functionality. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize changed: What|Removed |Added Attachment #156865|0 |1 is obsolete|| --- Comment #134 from Martin Renvoize --- Created attachment 156908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156908=edit Bug 15504: (follow-up) Fix is_active test Bug 33245 introduced a new is_active patron method and the corresponding tests included calls to the method we depreacte in this patchset -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize changed: What|Removed |Added Attachment #156864|0 |1 is obsolete|| --- Comment #133 from Martin Renvoize --- Created attachment 156907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156907=edit Bug 15504: (follow-up) Tidy 'lastseen' section of unit test -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize changed: What|Removed |Added Attachment #156863|0 |1 is obsolete|| --- Comment #132 from Martin Renvoize --- Created attachment 156906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156906=edit Bug 15504: (follow-up) Add Triggers mock to unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize changed: What|Removed |Added Attachment #156862|0 |1 is obsolete|| --- Comment #131 from Martin Renvoize --- Created attachment 156905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156905=edit Bug 15504: (follow-up) Use borrowernumber in Koha::Patrons->find -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize changed: What|Removed |Added Attachment #156861|0 |1 is obsolete|| --- Comment #130 from Martin Renvoize --- Created attachment 156904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156904=edit Bug 15504: (follow-up) Migrate to one clear method We were using a series of similarly named methods spread in distinct places around the codebase. This combines the logic of C4::Auth::track_login_daily and Koha::Patron->track_login into a new Koha::Patron->update_lastseen method. Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize changed: What|Removed |Added Attachment #156860|0 |1 is obsolete|| --- Comment #129 from Martin Renvoize --- Created attachment 156903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156903=edit Bug 15504: (follow-up) Unit tests This patch removes, moves and updates the existing unit tests for track_login_daily and track_login to all sit under Koha::Patron and update_lastseen. Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize changed: What|Removed |Added Attachment #156859|0 |1 is obsolete|| --- Comment #128 from Martin Renvoize --- Created attachment 156902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156902=edit Bug 15504: Add unit test prove -v t/db_dependent/Auth.t Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize changed: What|Removed |Added Attachment #156858|0 |1 is obsolete|| --- Comment #127 from Martin Renvoize --- Created attachment 156901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156901=edit Bug 15504: Remove update_lastseen method This patch removes update_lastseen which has been replaced by a call to track_login_daily Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize changed: What|Removed |Added Attachment #156857|0 |1 is obsolete|| --- Comment #126 from Martin Renvoize --- Created attachment 156900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156900=edit Bug 15504: Add triggers to instances of track_login_daily This patch adds a trigger to every instance of track_login_daily Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize changed: What|Removed |Added Attachment #156856|0 |1 is obsolete|| --- Comment #125 from Martin Renvoize --- Created attachment 156899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156899=edit Bug 15504: Update track_login_daily to accept triggers This patch adds triggers to track_login_daily so that it only tracks activity when that trigger is active Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize changed: What|Removed |Added Attachment #156855|0 |1 is obsolete|| --- Comment #124 from Martin Renvoize --- Created attachment 156898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156898=edit Bug 15504: Add new syspref TrackLastPatronActivityTriggers This patch adds a new syspref TrackLastPatronActivityTriggers to determine which actions should update borrowers.lastseen Signed-off-by: Martin Renvoize Signed-off-by: David Nind -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Marcel de Rooy changed: What|Removed |Added Status|BLOCKED |Patch doesn't apply --- Comment #123 from Marcel de Rooy --- I cant continue now. Please fix. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #122 from Marcel de Rooy --- Applying: Bug 15504: (follow-up) Unit tests error: sha1 information is lacking or useless (t/db_dependent/Koha/Patron.t). error: could not build fake ancestor Patch failed at 0001 Bug 15504: (follow-up) Unit tests -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Marcel de Rooy changed: What|Removed |Added Status|Signed Off |BLOCKED --- Comment #121 from Marcel de Rooy --- Resuming here now. Please dont touch the patches. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize changed: What|Removed |Added Attachment #156875|0 |1 is obsolete|| --- Comment #120 from Martin Renvoize --- Created attachment 156879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156879=edit Bug 15504: Remove PatronLastActivity preference This patch removes the older PatronLastActivity preference opting to replace it by the new PatronLastActivityTriggers preference. The feature can now be disabled by simply not selecting any triggers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #119 from Martin Renvoize --- I opted to just fold in the removal of TrackLastPatronActivity.. it can be moved to it's own bug if you prefer.. or squashed a bit.. I kept them as distict patches for now just to make it clear where I've responded to each of the feedback points. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #118 from Martin Renvoize --- Created attachment 156875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156875=edit Bug 15504: Remove PatronLastActivity preference This patch removes the older PatronLastActivity preference opting to replace it by the new PatronLastActivityTriggers preference. The feature can now be disabled by simply not selecting any triggers -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize changed: What|Removed |Added Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #117 from Martin Renvoize --- Created attachment 156870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156870=edit Bug 15504: (follow-up) Clarify --last_seen option in delete_patrons This patch adds clarifications to the last_seen option in delete_patrons to clarify that TrackLastPatronActivity and TrackLastPatronActivityTriggers system preferences act as a couplet. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #116 from Martin Renvoize --- Created attachment 156869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156869=edit Bug 15504: (follow-up) Update terminology on cleanborrowers This patch updates the terminology on the cleanborrowers form to reflect that 'activity' and not just 'connectivity' is tracked by TrackLastPatronActivity. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #115 from Martin Renvoize --- Created attachment 156868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156868=edit Bug 15504: (QA follow-up) Terminology This just updates 'Login to OPAC' to 'Login'.. we should squash this -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #114 from Martin Renvoize --- Created attachment 156867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156867=edit Bug 15504: (follow-up) Rename cache key I agree, it's better to use borrowernumber for the cache key and I also take the oportunity to rename it to more clearly reflect the function (it's no longer 'login' only, it's now 'activity') -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 --- Comment #113 from Martin Renvoize --- Created attachment 156866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156866=edit Bug 15504: (follow-up) Respect existing TrackLastPatronActivity This patch updates the database update to set 'check_out,connection,login' as the activity triggers should we find at upgrade time that TrackLastPatronActivity is set to true. This retains the existing functionality. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
[Koha-bugs] [Bug 15504] Track Patron's Last Activity
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Martin Renvoize changed: What|Removed |Added Attachment #156608|0 |1 is obsolete|| --- Comment #112 from Martin Renvoize --- Created attachment 156865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=156865=edit Bug 15504: (follow-up) Fix is_active test Bug 33245 introduced a new is_active patron method and the corresponding tests included calls to the method we depreacte in this patchset -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list Koha-bugs@lists.koha-community.org https://lists.koha-community.org/cgi-bin/mailman/listinfo/koha-bugs website : http://www.koha-community.org/ git : http://git.koha-community.org/ bugs : http://bugs.koha-community.org/
