[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Katrin Fischer changed: What|Removed |Added Blocks||22267 Referenced Bugs:

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Katrin Fischer changed: What|Removed |Added CC||neng...@gmail.com ---

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Martin Renvoize changed: What|Removed |Added CC|

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #60 from Nick Clemens --- (In reply to Jonathan Druart from comment #59) > Created attachment 81086 [details] [review] > Bug 15766: Update tests > > Signed-off-by: Jonathan Druart Pushed to master for 18.11 -- You

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Jonathan Druart changed: What|Removed |Added Attachment #81084|0 |1 is obsolete|

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #58 from Nick Clemens --- Created attachment 81084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81084=edit Bug 15766: Update tests -- You are receiving this mail because: You are watching all bug

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Nick Clemens changed: What|Removed |Added Status|Passed QA |Pushed to Master ---

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #56 from Jonathan Druart --- Created attachment 81070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81070=edit Bug 15766: Fix incorrect GROUP BY 'koha_kohadev.creator_batches.description' isn't in

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Katrin Fischer changed: What|Removed |Added Attachment #79845|0 |1 is obsolete|

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Katrin Fischer changed: What|Removed |Added Attachment #79842|0 |1 is obsolete|

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Katrin Fischer changed: What|Removed |Added Attachment #79846|0 |1 is obsolete|

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Katrin Fischer changed: What|Removed |Added Attachment #79840|0 |1 is obsolete|

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Katrin Fischer changed: What|Removed |Added Attachment #79841|0 |1 is obsolete|

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Katrin Fischer changed: What|Removed |Added Status|Signed Off |Passed QA -- You are

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Katrin Fischer changed: What|Removed |Added Attachment #79839|0 |1 is obsolete|

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #49 from Katrin Fischer --- Not do disagree with our RM, but I think I liked the button better next to the field as the behavior is a bit uncommon and it would serve as a visual reminder that you have to save this

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Katrin Fischer changed: What|Removed |Added QA Contact|testo...@bugs.koha-communit |katrin.fisc...@bsz-bw.de

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Owen Leonard changed: What|Removed |Added Attachment #79843|0 |1 is obsolete|

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #48 from Owen Leonard --- Created attachment 79846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79846=edit Bug 15766: (follow-up) Fixing layout of description button This patch moves the 'Save'

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Owen Leonard changed: What|Removed |Added Status|Needs Signoff |Signed Off -- You are

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #46 from Owen Leonard --- Patches rebased. -- You are receiving this mail because: You are watching all bug changes. ___ Koha-bugs mailing list

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #45 from Owen Leonard --- Created attachment 79844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79844=edit Bug 15766: (follow-up) Fixing layout of description button This patch moves the 'Save'

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #44 from Owen Leonard --- Created attachment 79843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79843=edit Bug 15766: (follow-up) Correct merge errors This patch corrects some problems applying this

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #43 from Owen Leonard --- Created attachment 79842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79842=edit Bug 15766: (follow-up) Hide description field if the batch is empty Because if it's empty,

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #42 from Owen Leonard --- Created attachment 79841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79841=edit Bug 15766: (follow-up) Save description link as button on patroncard side Signed-off-by:

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #41 from Owen Leonard --- Created attachment 79840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=79840=edit Bug 15766: (follow-up) Making 'Save description' link a button For consistency's sake in

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Owen Leonard changed: What|Removed |Added Attachment #75213|0 |1 is obsolete|

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Aleisha Amohia changed: What|Removed |Added Status|ASSIGNED|Needs Signoff -- You are

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #39 from Aleisha Amohia --- Created attachment 75843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75843=edit Bug 15766: [FOLLOW-UP] Fixing layout of description button This patch moves the 'Save'

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Aleisha Amohia changed: What|Removed |Added Status|Needs Signoff |ASSIGNED --- Comment #38

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #37 from Owen Leonard --- Although this was marked "Failed QA," it looks like it is ready for testing since there are no QA comments posted after the latest patches. -- You are receiving this mail because: You are

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Owen Leonard changed: What|Removed |Added Status|Failed QA |Needs Signoff -- You are

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #36 from Owen Leonard --- Created attachment 75715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75715=edit Bug 15766: (follow-up) Correct merge errors This patch corrects some problems applying this

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Aleisha Amohia changed: What|Removed |Added Attachment #68362|0 |1

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Aleisha Amohia changed: What|Removed |Added Attachment #68361|0 |1

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Aleisha Amohia changed: What|Removed |Added Attachment #68359|0 |1

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Aleisha Amohia changed: What|Removed |Added Attachment #68360|0 |1

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Katrin Fischer changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Nick Clemens changed: What|Removed |Added CC|

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Katrin Fischer changed: What|Removed |Added Attachment #68282|0

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Katrin Fischer changed: What|Removed |Added Attachment #66515|0

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Katrin Fischer changed: What|Removed |Added Attachment #67862|0

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Katrin Fischer changed: What|Removed |Added Attachment #67305|0

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #24 from Aleisha Amohia --- Created attachment 68282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=68282=edit Bug 15766: [FOLLOW-UP] Hide description field if the batch is

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #23 from Aleisha Amohia --- (In reply to Katrin Fischer from comment #22) > Hi Aleisha, > > I am sorry, but I am still having the same troubles: > > - No feedback on pushing the button > -

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #22 from Katrin Fischer --- Hi Aleisha, I am sorry, but I am still having the same troubles: - No feedback on pushing the button - Errors in the logs for patron card creator: Can't use string

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #21 from Aleisha Amohia --- (In reply to Katrin Fischer from comment #19) > There seems to be a bug in this patch set. I have run the database update > and restart_all, but when I click on "Save

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #20 from Aleisha Amohia --- Created attachment 67862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67862=edit Bug 15766: [FOLLOW-UP] Save description link as button on

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Aleisha Amohia changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Katrin Fischer changed: What|Removed |Added Status|Needs Signoff

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Katrin Fischer changed: What|Removed |Added Keywords|

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #18 from Aleisha Amohia --- Created attachment 67305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=67305=edit Bug 15766: [FOLLOW-UP] Making 'Save description' link a button

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 --- Comment #17 from Marcel de Rooy --- Thx for updating your patch. If I look at Manage Batches and click Edit, I can add a description and save it by clicking on the link next to the text box. After that

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Aleisha Amohia changed: What|Removed |Added Attachment #63221|0 |1

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Aleisha Amohia changed: What|Removed |Added Status|Failed QA

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Marcel de Rooy changed: What|Removed |Added Status|Signed Off

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Marc Véron changed: What|Removed |Added Status|Needs Signoff |Signed Off --

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Marc Véron changed: What|Removed |Added Attachment #61464|0 |1 is

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Marc Véron changed: What|Removed |Added Attachment #61463|0 |1 is

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Marc Véron changed: What|Removed |Added Attachment #61462|0 |1 is

[Koha-bugs] [Bug 15766] Give label and patron card batches a description

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15766 Marc Véron changed: What|Removed |Added Summary|A batch should be given a |Give label and